From 533ff7ab29a1ca6d35d0e306dd97273838ad3064 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 27 May 2019 09:39:34 +0000 Subject: [PATCH] Bug 15221: (QA follow-up) Fix Message.t As Jonathan reported on comment11, SIP/Message.t fails now. This is a trivial fix for that. In the first case we should just no longer expect the alert flag. In the second case it makes more sense to toggle the value of the checked_in_ok setting. Test plan: Run t/db_dependent/SIP/Message.t Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens --- t/db_dependent/SIP/Message.t | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/SIP/Message.t b/t/db_dependent/SIP/Message.t index dbab48efd3..499c2b6748 100755 --- a/t/db_dependent/SIP/Message.t +++ b/t/db_dependent/SIP/Message.t @@ -358,7 +358,7 @@ sub test_checkin_v2 { $msg = C4::SIP::Sip::MsgType->new( $siprequest, 0 ); $msg->handle_checkin( $server ); is( substr($response,2,1), '1', 'OK flag is true now with checked_in_ok flag set when checking in an item that was not checked out' ); - is( substr($response,5,1), 'Y', 'Alert flag is set' ); + is( substr($response,5,1), 'N', 'Alert flag no longer set' ); check_field( $respcode, $response, FID_SCREEN_MSG, undef, 'No screen msg' ); $server->{account}->{checked_in_ok} = 0; @@ -379,7 +379,7 @@ sub test_checkin_v2 { $server->{account}->{cv_send_00_on_success} = 0; t::lib::Mocks::mock_preference( 'RecordLocalUseOnReturn', '1' ); - $server->{account}->{checked_in_ok} = 1; + $server->{account}->{checked_in_ok} = 0; $server->{account}->{cv_triggers_alert} = 0; undef $response; $msg = C4::SIP::Sip::MsgType->new( $siprequest, 0 ); @@ -393,7 +393,6 @@ sub test_checkin_v2 { $msg->handle_checkin( $server ); $respcode = substr( $response, 0, 2 ); is( substr( $response, 5, 1 ), 'N', 'Checkin without CV does not trigger alert flag when cv_triggers_alert is on' ); - $server->{account}->{checked_in_ok} = 0; $server->{account}->{cv_triggers_alert} = 0; t::lib::Mocks::mock_preference( 'RecordLocalUseOnReturn', '1' ); -- 2.20.1