koha-small.git
8 years agoMerge remote-tracking branch 'origin/new/bug_5347' master
Paul Poulain [Thu, 19 Apr 2012 09:53:44 +0000 (11:53 +0200)]
Merge remote-tracking branch 'origin/new/bug_5347'

8 years agoBug 5347 Follow up, fix for broken test new/bug_5347
Chris Cormack [Thu, 19 Apr 2012 09:33:04 +0000 (21:33 +1200)]
Bug 5347 Follow up, fix for broken test

8 years agoBug 7726: explanation and options that were in the wrong order new/bug_7726
Paul Poulain [Tue, 27 Mar 2012 07:56:33 +0000 (09:56 +0200)]
Bug 7726: explanation and options that were in the wrong order

I also removed the ` mysql-ism

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7950 - Typo for preference intranetuserjs new/bug_7950
Kyle M Hall [Thu, 12 Apr 2012 16:25:09 +0000 (12:25 -0400)]
Bug 7950 - Typo for preference intranetuserjs

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7693 - clear screen button misaligned new/bug_7693
Gaetan Boisson [Thu, 12 Apr 2012 15:59:32 +0000 (17:59 +0200)]
Bug 7693 - clear screen button misaligned

This patch removes firefox specific lines in the css which were breaking the display

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
This fixes the layout problem in current versions of Firefox. I think
the CSS which is removed by this patch might be necessary for older
versions of Firefox, but if this turns out to be a problem we can
follow up.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7828 - On circulation home page, URL to offline circulation Firefox addon should... new/bug_7828
Owen Leonard [Wed, 11 Apr 2012 12:31:22 +0000 (08:31 -0400)]
Bug 7828 - On circulation home page, URL to offline circulation Firefox addon should be a hyperlink

Along with making the URL a hyperlink I removed the language
part of the URL ("/fr/"). The link correctly redirects to 'en'
for me. I'm curious whether it will for other languages.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Link works and redirects to my language (english).

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(Redirects to fr if your browser is FR)

8 years agoBug 3337 - RSS link is not correct for searches without results new/bug_3337
Katrin Fischer [Sat, 14 Apr 2012 22:09:34 +0000 (00:09 +0200)]
Bug 3337 - RSS link is not correct for searches without results

RSS links for searches without results didn't have the search terms.

To test:
- Search for something with results and check RSS link
- Search for something with no results and check RSS link

In both cases your search should show up in the link.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
RSS Link works in both cases listed in test plan.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7371: Add 'cardnumber' as option for AutoEmailPrimaryAddress new/bug_7371
Katrin Fischer [Thu, 12 Apr 2012 05:53:32 +0000 (07:53 +0200)]
Bug 7371: Add 'cardnumber' as option for AutoEmailPrimaryAddress

The systempref.sql file had one more option 'cardnumber' that was not
visible from the system preference editor. This patch adds the setting.

To test:
- Check new setting cardnumber is available for AutoEmailPrimaryAddress
- Use setting with a patron that has an email address as cardnumber and
verify email is sent out correctly.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7733 - HidePatronName not working on moredetail new/bug_7733
Katrin Fischer [Sun, 15 Apr 2012 09:03:31 +0000 (11:03 +0200)]
Bug 7733 - HidePatronName not working on moredetail

Patch implements HidePatronName system preference for 'Checkout status'
on moredetail (tab items from staff detail page).

Also adds some new 'if' statements, so 'Serial enumeration' and 'Paid for?' are
only shown when they are not empty.

Silences warns in the logs.

To test:
- Toggle system preference for an issued item and check name/cardnumber
are displayed correctly.
- Check serial enumeration and Paid for? show when not empty.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7833 - unique holiday link broken new/bug_7833
Katrin Fischer [Sat, 14 Apr 2012 15:50:51 +0000 (17:50 +0200)]
Bug 7833 - unique holiday link broken

As Nicole stated on the bug the branchcode was missing from the links.

To test:
- add unique holidays to calendar for different branches
- click on link and check that the date is opened in the right calendar

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Clicked links for unique holidays and exceptions for
multiple branches and everything works perfectly.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7845: Multiple 260s don't display properly in search results new/bug_7845
Katrin Fischer [Mon, 9 Apr 2012 15:44:38 +0000 (17:44 +0200)]
Bug 7845: Multiple 260s don't display properly in search results

Corrects display for multiple 260 fields in intranet and OPAC.
In intranet the order of fields was wrong on the detail page.
In OPAC and intranet punctuation for multiple 260 fields in the
result list was not displaying properly.

Example after correction:
Publisher: Jena : Elsevier, 1907 ; Stuttgart : Franckh, 1907-1992 ; Jena : Urban & Fischer, 1993-2003

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7922: Fixing typo in German sample news new/bug_7922
Katrin Fischer [Sun, 8 Apr 2012 11:30:10 +0000 (13:30 +0200)]
Bug 7922: Fixing typo in German sample news

Fehlerkorrektoren > Fehlerkorrekturen

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoRevert "Bug 7785: Remove unused function columns() which uses a MySQLism."
Paul Poulain [Thu, 19 Apr 2012 08:21:47 +0000 (10:21 +0200)]
Revert "Bug 7785: Remove unused function columns() which uses a MySQLism."

This reverts commit 1c8df08aea5eb173d7216cdfc9895fdd601a5f11.

See:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785#c5
and
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7975

This patch broke tools/import_borrowers.pl

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7962 - Cart missing from result lists new/bug_7962
Owen Leonard [Sun, 15 Apr 2012 20:46:57 +0000 (16:46 -0400)]
Bug 7962 - Cart missing from result lists

Removing duplicate inclusion of jQuery on the results page
which was added with the star ratings feature. Koha already
uses jQuery by default.

I have also made the inclusion of ratings JS and CSS dependent
on ratings being turned on.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7354: Can't edit local use system preferences new/bug_7354
Katrin Fischer [Thu, 12 Apr 2012 06:59:32 +0000 (08:59 +0200)]
Bug 7354: Can't edit local use system preferences

Fixes adding and editing of local use system preferences and redirects to correct
page after saving.

To test:
- Create a new local use system preference
- Edit an existing local use system preference from summary page
- Edit an existing local use system preference using 'Edit'
- Delete a local use system preference

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7528 - amount subtracting 1 cent new/bug_7528
mveron [Sun, 15 Apr 2012 15:20:16 +0000 (17:20 +0200)]
Bug 7528 - amount subtracting 1 cent

Rounding issue with JavaScript and float numbers, JavaScript changed to do no calculation if discount is 0

Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7927 - library not showing on subscription full history anymore new/bug_7927
Katrin Fischer [Wed, 11 Apr 2012 06:41:57 +0000 (08:41 +0200)]
Bug 7927 - library not showing on subscription full history anymore

Restores former functionality:
Shows the branchcode in the branch column for the full history
view of subscriptions in OPAC.

http://bugs.koha-community.org/show_bug.cgi?id=7929
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Branch codes are visible again.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7958 - Batch Item Delete Fails new/bug_7958
Katrin Fischer [Sat, 14 Apr 2012 10:13:44 +0000 (12:13 +0200)]
Bug 7958 - Batch Item Delete Fails

Adding back "use C4::Search;" in Items.pm fixes the problem.

I think this is probably related to the denesting efforts.

Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 5347: Followup: FIX 2 bugs in lateorders
Jonathan Druart [Fri, 13 Apr 2012 07:15:35 +0000 (09:15 +0200)]
Bug 5347: Followup: FIX 2 bugs in lateorders

1/ Failed to claim late orders (Can't use string as a HASH ref)
2/ Don't show the red error message after submit the form for claims

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
1/ Fixed.
2/ Also fixed.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_5347'
Paul Poulain [Wed, 18 Apr 2012 15:02:25 +0000 (17:02 +0200)]
Merge remote-tracking branch 'origin/new/bug_5347'

8 years agoBug 5374 [SIGNED-OFF] Followup: adds conditional check to unit test for late orders
Ian Walls [Mon, 19 Mar 2012 23:16:48 +0000 (19:16 -0400)]
Bug 5374 [SIGNED-OFF] Followup: adds conditional check to unit test for late orders

If there are no late orders in the database, the 5th unit test for C4/Acquisition.pm
fails, since no date is returned (and today's date is expected)

This patch adds a conditional check around whether any late orders are actually returned
by GetLateOrders. If so, tests proceed, if not, they're skipped.  This seems to quiet
the failures in the automated test suite.

http://bugs.koha-community.org/show_bug.cgi?id=5347

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

8 years agoMerge remote-tracking branch 'origin/new/bug_7016'
Paul Poulain [Wed, 18 Apr 2012 14:54:44 +0000 (16:54 +0200)]
Merge remote-tracking branch 'origin/new/bug_7016'

8 years agobug 7016 further followup: clarify return of GetItemnumbersForBiblio new/bug_7016
Galen Charlton [Wed, 11 Apr 2012 20:13:22 +0000 (16:13 -0400)]
bug 7016 further followup: clarify return of GetItemnumbersForBiblio

New function was actually returning an arrayref, so made
perldoc and function usage consistent.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7016 Followup: Add new GetItemnumberForBiblio subroutine
Ian Walls [Fri, 6 Jan 2012 14:53:49 +0000 (09:53 -0500)]
Bug 7016 Followup: Add new GetItemnumberForBiblio subroutine

Adds a new subroutine in C4::Items, GetItemnumbersForBiblio, which takes a
single biblionumber, and returns an array of all the corresponding itemnumbers.

This patch also replaces the usage of get_itemnumbers_of in C4::Reserves::CanBookBeReserved
with this new subroutine, as the output is more consistent with what we were
lookng for (this is what fixes the bug issue).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoBug 7902 - Adding Function to Check for Existence of Tables new/bug_7902
Chris Nighswonger [Thu, 5 Apr 2012 13:38:52 +0000 (09:38 -0400)]
Bug 7902 - Adding Function to Check for Existence of Tables

This patch adds a function TableExists which checks for the existence
of a given table and returns 1 or 0 accordingly. This allows us to
check for the existence of a given table when doing operations on
tables which may not exist in a given database which, in turn, will
reduce the number of red errors which show up after an upgrade.

An example of its use is included in this patch.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7936: Reports Help Files for 3.8 new/bug_7936
Nicole C. Engard [Thu, 12 Apr 2012 14:03:49 +0000 (10:03 -0400)]
Bug 7936: Reports Help Files for 3.8

This updates the existing help files and adds a new
help file for the holds stats report.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7936: Patron Help Files
Nicole C. Engard [Thu, 12 Apr 2012 08:15:54 +0000 (04:15 -0400)]
Bug 7936: Patron Help Files

8 years agoBug 7936: Catalogue Help Files
Nicole C. Engard [Wed, 11 Apr 2012 06:59:48 +0000 (02:59 -0400)]
Bug 7936: Catalogue Help Files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7936: Patron Card Help Files
Nicole C. Engard [Wed, 11 Apr 2012 04:24:16 +0000 (00:24 -0400)]
Bug 7936: Patron Card Help Files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7936: Label Help Files
Nicole C. Engard [Wed, 11 Apr 2012 04:20:55 +0000 (00:20 -0400)]
Bug 7936: Label Help Files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7936: Circ Help Files
Nicole C. Engard [Wed, 11 Apr 2012 03:56:15 +0000 (23:56 -0400)]
Bug 7936: Circ Help Files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7936: Holds Help File for 3.8
Nicole C. Engard [Wed, 11 Apr 2012 02:59:35 +0000 (22:59 -0400)]
Bug 7936: Holds Help File for 3.8

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7936: Comments Moderation Help File
Nicole C. Engard [Tue, 10 Apr 2012 19:46:07 +0000 (15:46 -0400)]
Bug 7936: Comments Moderation Help File

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7936: Suggestion help file
Nicole C. Engard [Tue, 10 Apr 2012 19:13:02 +0000 (15:13 -0400)]
Bug 7936: Suggestion help file

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7936: Authorities Help Files
Nicole C. Engard [Tue, 10 Apr 2012 19:01:10 +0000 (15:01 -0400)]
Bug 7936: Authorities Help Files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7936: Marc Export Help File
Nicole C. Engard [Tue, 10 Apr 2012 18:57:36 +0000 (14:57 -0400)]
Bug 7936: Marc Export Help File

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7936: Tags help file
Nicole C. Engard [Tue, 10 Apr 2012 18:55:30 +0000 (14:55 -0400)]
Bug 7936: Tags help file

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7936: Tools Help for 3.8
Nicole C. Engard [Tue, 10 Apr 2012 16:00:12 +0000 (12:00 -0400)]
Bug 7936: Tools Help for 3.8

This updates the tools help files and adds a new
help file for the new upload cover images tool.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7936: Cataloging Help Files
Nicole C. Engard [Mon, 9 Apr 2012 20:12:25 +0000 (16:12 -0400)]
Bug 7936: Cataloging Help Files

These are the updated help files for cataloging

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7936: Help file for Lists
Nicole C. Engard [Mon, 9 Apr 2012 20:06:36 +0000 (16:06 -0400)]
Bug 7936: Help file for Lists

This is the 3.8 help file for lists.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7936: 3.8 Help Files
Nicole C. Engard [Mon, 9 Apr 2012 19:57:41 +0000 (15:57 -0400)]
Bug 7936: 3.8 Help Files

These are the three help files that do not belong in any
specific directory. Links updated to the 3.8 manual.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 5345 [FOLLOW-UP] DataTables in Koha new/bug_5345
Owen Leonard [Tue, 6 Mar 2012 17:43:55 +0000 (12:43 -0500)]
Bug 5345 [FOLLOW-UP] DataTables in Koha

Adding missing images: The "disabled" version of the next,
previous, first, and last buttons.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_5668'
Paul Poulain [Fri, 13 Apr 2012 13:32:25 +0000 (15:32 +0200)]
Merge remote-tracking branch 'origin/new/bug_5668'

8 years agoBug 5668 Error during during insall with web installer, Step 3 new/bug_5668
mveron [Thu, 12 Apr 2012 20:17:02 +0000 (22:17 +0200)]
Bug 5668 Error during during insall with web installer, Step 3

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Mason James <mtj at kohaaloha.com>
Before patch web installer dies with error message on creating
database tables:
ERROR 1064 (42000) at line 2821: You have an error in your SQL
syntax; check the manual that corresponds to your MySQL server
version for the right syntax to use near '- biblionumber int(11)
NOT NULL, - rating_value tinyint(1) NOT NULL, - ' at line 2

After patch installation completes normally. I also checked
that tables ratings and pending_offline_operations were
created correctly.

Note: This is Marc Veron's first patch for Koha - congratulations!
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7831 : Sort budgets for selection in new order new/bug_7831
Colin Campbell [Tue, 27 Mar 2012 15:04:12 +0000 (16:04 +0100)]
Bug 7831 : Sort budgets for selection in new order

The select budget dropdown list should be presented in
an ordered fashion. To achieve this sort the budget array
by the visible text.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_7876'
Paul Poulain [Thu, 12 Apr 2012 16:11:05 +0000 (18:11 +0200)]
Merge remote-tracking branch 'origin/new/bug_7876'

8 years agoBug 7876 - Followup - Fix span tag position, add fine amount spans. new/bug_7876
Kyle M Hall [Tue, 10 Apr 2012 16:51:23 +0000 (12:51 -0400)]
Bug 7876 - Followup - Fix span tag position, add fine amount spans.

Span was outside, the if statement, could possible cause problems
with jQuery customizations, moved span to inside the conditional.

Also added span for the fine amount itself, so that it may be
re-used for jQuery customizations.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Passed tests, spans appear to be correct.

8 years agoBug 2034: Removing unused scripts billig.pl/billing.tt new/bug_2034
Katrin Fischer [Sun, 8 Apr 2012 09:26:24 +0000 (11:26 +0200)]
Bug 2034: Removing unused scripts billig.pl/billing.tt

- Scripts are currently not linked from anywhere in the templates
- Functionality can also be achieved with a custom report
- There are unresolved problems with the sql in the existig scripts

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7940 - Placing a hold on a single item from the staff cart causes errors new/bug_7940
Kyle M Hall [Tue, 10 Apr 2012 15:36:36 +0000 (11:36 -0400)]
Bug 7940 - Placing a hold on a single item from the staff cart causes errors

This is caused by the javascript function placeHold() in basket.pl
The cause of this error is thus: when a staff member uses the cart
to place holds on multiple items at once, the cart redirects to
reserver/request.pl with the params 'biblionumbers' ( a string of
biblionumbers separated by slashes ( e.g. '5/4/3/' ) and the param
multi_hold with a value of 1.

When multi_hold is enabled, request.pl splits the string 'biblionumbers'
on those slashes and works on that list.

In placeHold(), when only one item is checked, the system passes
the param biblionumbers with a single biblionumber ( e.g. '5/' )
and does *not* pass the multi_hold param. This causes request.pl
to not parse the biblionumbers param, and thus reserve.pl has
no biblionumber to work on ( hence our error here ).

There are two options to resolve this:
A) Add the multi_hold param even for a single hold from the cart.
B) In the event of a single hold being placed from the cart,
   switch to the standard single hold url ( i.e. request.pl?biblionumber=234 )

This commit resolves the situation using option B, as it seems more
logical than using the multi-holds system for a single hold.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, works as advertised. Good catch!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7838 - Add sort-string-utf.chr for Ukrainian and Russian new/bug_7838
Serhij Dubyk {Сергій Дубик} [Tue, 27 Mar 2012 23:46:09 +0000 (02:46 +0300)]
Bug 7838 - Add sort-string-utf.chr for Ukrainian and Russian

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7834: order search at the top of acq does nothing new/bug_7834
Katrin Fischer [Mon, 9 Apr 2012 07:48:46 +0000 (09:48 +0200)]
Bug 7834: order search at the top of acq does nothing

Entering a search term for 'title' or 'vendor' at the top search
form in acq (tab 'Orders search') did redirect to the advanced
search form, but didn't start the search.

After applying the patch the search will bring back results immediately
or redirect to the form, when there are no results.

To test:
- Check all searches still work as expected by searching for title,
vendor, order name and invoice number
- Check advanced search still has the search terms prepopulated
- Check searches with and without results are ok

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7756: FIX send email for late orders new/bug_7756
Jonathan Druart [Tue, 10 Apr 2012 08:06:59 +0000 (10:06 +0200)]
Bug 7756: FIX send email for late orders

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
- sending claim mails works now
- claim counter is not increased when vendor has no email address

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agomissing \n in updatedatabase that causes some ugly display
Paul Poulain [Wed, 11 Apr 2012 13:18:40 +0000 (15:18 +0200)]
missing \n in updatedatabase that causes some ugly display

8 years agoMerge remote-tracking branch 'origin/new/bug_2780'
Paul Poulain [Wed, 11 Apr 2012 07:34:48 +0000 (09:34 +0200)]
Merge remote-tracking branch 'origin/new/bug_2780'

8 years agoBug 2780 [FOLLOW-UP] Capitalize strings consistently new/bug_2780
Owen Leonard [Tue, 10 Apr 2012 19:43:48 +0000 (15:43 -0400)]
Bug 2780 [FOLLOW-UP] Capitalize strings consistently

Changes to the case of some hidden input values prevented
the user from being able to save a new SQL report.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, can now save sql reports.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agomembers now passes perlcritic, but not misc. removing testing of misc
Paul Poulain [Tue, 10 Apr 2012 16:03:55 +0000 (18:03 +0200)]
members now passes perlcritic, but not misc. removing testing of misc

8 years agoUpdating euskara and french translation teams
Paul Poulain [Tue, 10 Apr 2012 14:13:37 +0000 (16:13 +0200)]
Updating euskara and french translation teams

8 years agoBug 7935 follow-up: DBRev number new/bug_7935
Paul Poulain [Tue, 10 Apr 2012 13:26:55 +0000 (15:26 +0200)]
Bug 7935 follow-up: DBRev number

8 years agoBug 7935: Introduce sys pref to control 'browse results' in OPAC
Katrin Fischer [Mon, 9 Apr 2012 19:27:16 +0000 (21:27 +0200)]
Bug 7935: Introduce sys pref to control 'browse results' in OPAC

Patch introduces a new system preference "OpacBrowseResults" to control
the feature for browsing and paging through results shown on top of the
left menu on detail pages in OPAC.

Preference is activated by default and can be deactivated using the
system preference.

To test:
 - Check database update works correctly
 - Check that browsing and paging still works with after database update
 - Deactivate the feature by setting 'OpacBrowseResults' to 'Disable'
 - Check the feature does no longer show up in OPAC
 - Check that a new installation also has the system preference with correct default

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 2505 follow-up: C4::Ris not ready for use strict;use warnings;
Paul Poulain [Tue, 10 Apr 2012 13:08:47 +0000 (15:08 +0200)]
Bug 2505 follow-up: C4::Ris not ready for use strict;use warnings;

The patch pushed a few hours ago is a good 1st step in the right direction.
however, many things are still to do to have the script OK with strict/warning, so commenting them

Errors if you have them:

Global symbol "$utf" requires explicit package name at C4/Ris.pm line 111.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 350.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 350.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 353.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 363.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 389.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 431.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 438.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 439.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 440.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 441.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 442.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 443.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 464.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 465.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 466.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 479.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 480.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 483.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 484.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 485.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 501.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 505.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 527.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 530.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 539.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 540.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 556.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 557.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 561.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 562.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 578.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 579.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 583.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 584.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 613.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 614.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 629.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 630.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 645.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 646.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 674.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 706.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 707.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 707.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 710.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 715.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 721.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 725.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 729.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 730.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 730.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 731.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 734.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 735.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 738.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 772.
Global symbol "@kwsubfields" requires explicit package name at C4/Ris.pm line 776.
Global symbol "@kwsubfields" requires explicit package name at C4/Ris.pm line 779.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 789.
Global symbol "@notesubfields" requires explicit package name at C4/Ris.pm line 892.
Global symbol "@notesubfields" requires explicit package name at C4/Ris.pm line 895.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 901.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 935.
Global symbol "$utf" requires explicit package name at C4/Ris.pm line 962.
Global symbol "$uniout" requires explicit package name at C4/Ris.pm line 966.
C4/Ris.pm had compilation errors.

8 years agoBug 5668 follow-up: removing empty lines in opac.pref
Paul Poulain [Tue, 10 Apr 2012 12:58:32 +0000 (14:58 +0200)]
Bug 5668 follow-up: removing empty lines in opac.pref

Those lines where introduced by this patch

8 years agoBug 5668 follow-up: DBRev number
Paul Poulain [Tue, 10 Apr 2012 12:57:55 +0000 (14:57 +0200)]
Bug 5668 follow-up: DBRev number

8 years agoBug 5668 - Star ratings in the opac
Mason James [Fri, 30 Mar 2012 03:35:29 +0000 (16:35 +1300)]
Bug 5668 - Star ratings in the opac

patch applied to commit eb3dc448d2378e01a524d082fc6389484b0cc7d8

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Turned on star ratings in the opac on details and results
Searched for titles - saw the stars
Clicked on a title
Clicked on the stars
Clicked on the stars to change my rating
Logged out
Tried to click on stars
Logged in as different user
Rated items that were rated already and saw average change
Changed preference to show only on detail and repeated tests
Changed preference to now show stars

All above tests passed. Signing off.

Rebased 3-19-12 by Ian Walls

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7743 follow up fixing syntax to so templates pass test
Chris Cormack [Mon, 9 Apr 2012 08:04:20 +0000 (20:04 +1200)]
Bug 7743 follow up fixing syntax to so templates pass test

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Failing test was: xt/author/valid-templates.t

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 :[SIGNED-OFF] Fixing some perlcritic violations in the opac
Chris Cormack [Thu, 5 Apr 2012 03:40:46 +0000 (15:40 +1200)]
Bug 6679 :[SIGNED-OFF] Fixing some perlcritic violations in the opac

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

8 years agoBug 6679 :[SIGNED-OFF] members dir now passes perlcritic tests
Chris Cormack [Thu, 5 Apr 2012 02:43:20 +0000 (14:43 +1200)]
Bug 6679 :[SIGNED-OFF] members dir now passes perlcritic tests

signed-off-by Jonathan Druart <jonathan.druart@biblibre.com>

8 years agoBug 7816 :[SIGNED-OFF] Encode output as utf-8 dont just flag it as such new/bug_7816
Colin Campbell [Fri, 23 Mar 2012 12:17:58 +0000 (12:17 +0000)]
Bug 7816 :[SIGNED-OFF] Encode output as utf-8 dont just flag it as such

Intention of code is that data is output in utf-8 requires an
encoding layer to ensure that. ':utf-8' flags the stream as utf-8
but does not ensure output characters are correctly encoded

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7871: prevents crash when suggestion linked to erased budget new/bug_7871
Adrien Saurat [Tue, 3 Apr 2012 07:56:46 +0000 (09:56 +0200)]
Bug 7871: prevents crash when suggestion linked to erased budget

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7807: [SIGNED-OFF] Fix call to GetSuggestionFromBiblionumber new/bug_7807
Julian Maurice [Thu, 22 Mar 2012 16:20:01 +0000 (17:20 +0100)]
Bug 7807: [SIGNED-OFF] Fix call to GetSuggestionFromBiblionumber

This sub only takes one parameter

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7886 follow-up DBRev number new/bug_7886
Paul Poulain [Tue, 10 Apr 2012 09:53:15 +0000 (11:53 +0200)]
Bug 7886 follow-up DBRev number

8 years agoBug 7886 - C4/ShelfBrowser slow SQL performance
Dobrica Pavlinusic [Wed, 4 Apr 2012 23:03:30 +0000 (01:03 +0200)]
Bug 7886 - C4/ShelfBrowser slow SQL performance

ShelfBrowser uses two SQL queries with syntax

WHERE ((cn_sort = ? AND itemnumber < ?) OR cn_sort < ?)
AND homebranch = ? AND location = ? AND ccode = ?

homebranch already has index, and adding indexes on ccode and location
improves performance by 30% for each query since MySQL is able to use
index_merge intersect(items_ccode,homebranch,items_location)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7900: Link to vendor from subscription detail is broken new/bug_7900
Katrin Fischer [Fri, 6 Apr 2012 15:09:30 +0000 (17:09 +0200)]
Bug 7900: Link to vendor from subscription detail is broken

To test:
- Add a serial subscription with a link to a vendor
- Check the subscription detail page for the name and link to the vendor
- Check that the link works correctly

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 2505 : Switch on warnings in circ/returns.pl
Colin Campbell [Wed, 15 Jun 2011 11:15:14 +0000 (12:15 +0100)]
Bug 2505 : Switch on warnings in circ/returns.pl

Removed a compile time warning caused by a void context
in a bit of too clever obscure code

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 2505 : use warnings in smart_rules.pl
Colin Campbell [Tue, 7 Jun 2011 13:34:18 +0000 (14:34 +0100)]
Bug 2505 : use warnings in smart_rules.pl

Fix some careless code redeclaring a variable
declaring a variable in a condition
so that these don't generate errors

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 2505 - enable Perl warnings in all modules and scripts
Mason James [Thu, 15 Mar 2012 08:06:22 +0000 (21:06 +1300)]
Bug 2505 - enable Perl warnings in all modules and scripts

enable warnings, and correct perlcritic's 'Loop iterator is not lexical' errors in C4/Ris.pm

modified:   C4/Ris.pm

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7893 - add package dependencies new/bug_7893
Robin Sheat [Wed, 4 Apr 2012 11:10:59 +0000 (23:10 +1200)]
Bug 7893 - add package dependencies

This adds some dependencies to the control file that are required.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 2780 - Capitalize strings consistently (home, about, login)
Katrin Fischer [Sun, 8 Apr 2012 21:42:36 +0000 (23:42 +0200)]
Bug 2780 - Capitalize strings consistently (home, about, login)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_2780'
Paul Poulain [Tue, 10 Apr 2012 08:32:48 +0000 (10:32 +0200)]
Merge remote-tracking branch 'origin/new/bug_2780'

8 years ago[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (tools)
Katrin Fischer [Sun, 8 Apr 2012 21:31:33 +0000 (23:31 +0200)]
[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (tools)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch also fixes some strings:
* itemcallnumber => item call number
* Profile marcfields=> Profile MARC fields

8 years ago[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (virtualshelves)
Katrin Fischer [Sun, 8 Apr 2012 20:50:10 +0000 (22:50 +0200)]
[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (virtualshelves)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch also fixes some vocabulary replacing "shelf" by "list"

8 years ago[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (reports)
Katrin Fischer [Sun, 8 Apr 2012 19:29:39 +0000 (21:29 +0200)]
[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (reports)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years ago[SIGNED-OFF]Bug 2780: Capitalize strings consistently
Katrin Fischer [Sun, 8 Apr 2012 17:39:00 +0000 (19:39 +0200)]
[SIGNED-OFF]Bug 2780: Capitalize strings consistently

Fixes some more strings.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years ago[SIGNED-OFF]Bug 2780: Capitalize strings consistently
Katrin Fischer [Fri, 6 Apr 2012 22:26:23 +0000 (00:26 +0200)]
[SIGNED-OFF]Bug 2780: Capitalize strings consistently

Some missing strings.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_2780'
Paul Poulain [Tue, 10 Apr 2012 08:04:51 +0000 (10:04 +0200)]
Merge remote-tracking branch 'origin/new/bug_2780'

8 years agoBug 2780 - Capitalize strings consistently - various
Katrin Fischer [Sun, 8 Apr 2012 20:35:26 +0000 (22:35 +0200)]
Bug 2780 - Capitalize strings consistently - various

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 2780 - Capitalize strings consistently (serials)
Katrin Fischer [Sun, 8 Apr 2012 20:17:24 +0000 (22:17 +0200)]
Bug 2780 - Capitalize strings consistently (serials)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 2780 - Capitalize strings consistently (reserve, review, rotating collections)
Katrin Fischer [Sun, 8 Apr 2012 19:44:56 +0000 (21:44 +0200)]
Bug 2780 - Capitalize strings consistently (reserve, review, rotating collections)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 2780 - Capitalize strings consistently (patron cards)
Katrin Fischer [Sun, 8 Apr 2012 18:44:38 +0000 (20:44 +0200)]
Bug 2780 - Capitalize strings consistently (patron cards)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 2780 - Capitalize strings consistently (offline circulation)
Katrin Fischer [Sun, 8 Apr 2012 18:22:41 +0000 (20:22 +0200)]
Bug 2780 - Capitalize strings consistently (offline circulation)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 2780 - Capitalize strings consistently (members)
Katrin Fischer [Sun, 8 Apr 2012 17:49:57 +0000 (19:49 +0200)]
Bug 2780 - Capitalize strings consistently (members)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 2780 - Follow up - Capitalize strings consistently (Staff client cart)
Katrin Fischer [Fri, 6 Apr 2012 17:52:41 +0000 (19:52 +0200)]
Bug 2780 - Follow up - Capitalize strings consistently (Staff client cart)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 2780 - Follow up - Capitalize strings consistently (Admin pages)
Katrin Fischer [Fri, 6 Apr 2012 17:43:29 +0000 (19:43 +0200)]
Bug 2780 - Follow up - Capitalize strings consistently (Admin pages)

Fixes some missed strings.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 2780 - Capitalize strings consistently (Labels templates)
Owen Leonard [Fri, 6 Apr 2012 19:50:10 +0000 (15:50 -0400)]
Bug 2780 - Capitalize strings consistently (Labels templates)

Correcting capitalization in Labels templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
8 years agoBug 2780 - Capitalize strings consistently (Labels help)
Owen Leonard [Fri, 6 Apr 2012 19:11:44 +0000 (15:11 -0400)]
Bug 2780 - Capitalize strings consistently (Labels help)

Correcting capitalization in Labels help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
8 years agoBug 2780 - Capitalize strings consistently (Misc. help pages)
Owen Leonard [Fri, 6 Apr 2012 18:06:37 +0000 (14:06 -0400)]
Bug 2780 - Capitalize strings consistently (Misc. help pages)

Correcting capitalization in various help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
8 years agoBug 2780 - Capitalize strings consistently (Circulation help)
Owen Leonard [Fri, 6 Apr 2012 13:35:18 +0000 (09:35 -0400)]
Bug 2780 - Capitalize strings consistently (Circulation help)

Correcting capitalization in Circulation help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
8 years agoBug 2780 - Capitalize strings consistently (Authorities and Cataloging help)
Owen Leonard [Fri, 6 Apr 2012 13:20:42 +0000 (09:20 -0400)]
Bug 2780 - Capitalize strings consistently (Authorities and Cataloging help)

Correcting capitalization in Authorities and Cataloging help pages

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
8 years agoBug 2780 - Capitalize strings consistently (Admin help)
Owen Leonard [Thu, 5 Apr 2012 16:33:37 +0000 (12:33 -0400)]
Bug 2780 - Capitalize strings consistently (Admin help)

Correcting capitalization in Administration help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
8 years agoBug 2780 - Capitalize strings consistently (Acqui help)
Owen Leonard [Thu, 5 Apr 2012 15:46:12 +0000 (11:46 -0400)]
Bug 2780 - Capitalize strings consistently (Acqui help)

Correcting capitalization in Acquisitions help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
8 years agoBug 2780 - Capitalize strings consistently (Installer)
Owen Leonard [Fri, 6 Apr 2012 19:42:02 +0000 (15:42 -0400)]
Bug 2780 - Capitalize strings consistently (Installer)

Correcting capitalization in Installer templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>