Bug 12827: NewOrder should not return basketno
authorJonathan Druart <jonathan.druart@biblibre.com>
Tue, 26 Aug 2014 14:06:10 +0000 (16:06 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Thu, 18 Sep 2014 00:22:26 +0000 (21:22 -0300)
commit2217f98b7cf1da89ed3e4bcc2cc497fe01df724c
tree589f5191ef133d57069850bc34a48b0d1e704485
parent55e5c82ab593c180e0b73f1cd13bbc71ee7a39c6
Bug 12827: NewOrder should not return basketno

Since the basketno parameter is needed to insert an order, it is useless
to return it.

This patch changes the prototype for the C4::Acquisition::NewOrder
subroutine. The return value is now a scalar containing the ordernumber
created.

Test plan:
Verify there is no regression on an acquisition workflow:
1/ Create an order with several items
2/ Modify the order
3/ Receive some items
4/ Cancel the receipt
4/ Receive some items
5/ Receive all remaining items
6/ Cancel the receipt

Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
13 files changed:
C4/Acquisition.pm
acqui/addorder.pl
acqui/addorderiso2709.pl
t/db_dependent/Acquisition.t
t/db_dependent/Acquisition/CancelReceipt.t
t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t
t/db_dependent/Acquisition/GetOrdersByBiblionumber.t
t/db_dependent/Acquisition/Invoices.t
t/db_dependent/Acquisition/OrderFromSubscription.t
t/db_dependent/Acquisition/TransferOrder.t
t/db_dependent/Acquisition/close_reopen_basket.t
t/db_dependent/Bookseller.t
t/db_dependent/Budgets.t