Bug 23034: Remove uninitialized value warning in Mana KB settings
authorJoonas Kylmälä <joonas.kylmala@helsinki.fi>
Mon, 3 Jun 2019 14:58:34 +0000 (14:58 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 16 Jul 2019 06:47:55 +0000 (08:47 +0200)
commit70349c437f48b0b4b75adc144c64c16f0e66a74d
treedbe45804f629a2d23a374b534de0ecd830ae96d5
parent574e7dc490bc2e0cc2a742d43cbca7c0e5eb331e
Bug 23034: Remove uninitialized value warning in Mana KB settings

This gets rid of the warning "Use of uninitialized value $auto_share
in string ne at [...]" by initializing the variable with empty string.

Test plan:
1) Go to page cgi-bin/koha/admin/share_content.pl and unselect "Auto
   subscription sharing". Click "Save".
2) Check plack-error.log and notice the warning "Use of uninitialized
   value $auto_share [...]"
3) Apply the patch and repeat the previous steps but now this time the
   warning is gone in plack-error.log.
4) Make sure the AutoShareWithMana syspref with and without the patch
   is in unselected state after clicking "Save".

Sponsored-by: The National Library of Finland
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 0df3fc3dae575ceb16b85de6c201f5e82d01059c)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
admin/share_content.pl