koha.git
7 years agoMerge remote-tracking branch 'origin/new/bug_7805'
Paul Poulain [Mon, 3 Sep 2012 13:58:45 +0000 (15:58 +0200)]
Merge remote-tracking branch 'origin/new/bug_7805'

7 years agoBug 7805 Followup for perlcritic messages
Marcel de Rooy [Thu, 14 Jun 2012 10:40:08 +0000 (12:40 +0200)]
Bug 7805 Followup for perlcritic messages

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Tested by going to Lists and doubleclicking a list to see
its contents (in opac or staff). It works. No warnings
in the log. I am ready to sign off.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8569: Paying for lost item overwrites nonpublic notes.
D Ruth Bavousett [Fri, 3 Aug 2012 14:53:23 +0000 (07:53 -0700)]
Bug 8569: Paying for lost item overwrites nonpublic notes.

This patch modifies C4::Circulation::ReturnLostItem to append the Paid-for note
to existing data, rather than overwriting it.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
7 years agoBug 4064 - Uninitialized variable errors in opac-search.pl Merely optimized two if...
Mark Tompsett [Sat, 30 Jun 2012 05:45:25 +0000 (13:45 +0800)]
Bug 4064 - Uninitialized variable errors in opac-search.pl Merely optimized two if statements, already fixed in 

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8391: prevent error when viewing circ history with bad dates
Robin Sheat [Fri, 27 Jul 2012 09:34:17 +0000 (11:34 +0200)]
Bug 8391: prevent error when viewing circ history with bad dates

Sometime the circ history will contain "0000-00-00" as a returndate when
an item was lost rather than returned. This currently causes an error
when attempting to parse the dates, this patch causes an empty string to
be returned instead.

Note: a future enhancement should distinguish between "no date provided"
and "invalid date provided" to allow distinctions to be made.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 3374 - Display patron attributes in the same format as other patron data
Owen Leonard [Fri, 27 Jul 2012 14:32:47 +0000 (10:32 -0400)]
Bug 3374 - Display patron attributes in the same format as other patron data

This patch revises the interface for displaying and editing
patron attributes so that it is consistent with other
similar interfaces.

Display of patron attributes should match the display of other
kinds of patron data, and codes should be omitted in favor of
descriptions.

Entry of patron attributes should match other patron entry
forms and should also omit codes in favor of descriptions.

To test, view and edit patron attributes. Special functions
like "Clear" and "New" should function as before.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Tested by viewing patrons with attributes, editing those attributes
and editing the entire patron record. In all places the editing/adding
works and the display is improved.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8586: Small bug in die if no mapping in framework for biblioitems.biblioitemnumber
Fridolyn SOMERS [Tue, 7 Aug 2012 12:42:17 +0000 (14:42 +0200)]
Bug 8586: Small bug in die if no mapping in framework for biblioitems.biblioitemnumber

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8012: default values for defaultSortField/defaultSortOrder NULL on install
D Ruth Bavousett [Fri, 17 Aug 2012 12:42:12 +0000 (08:42 -0400)]
Bug 8012: default values for defaultSortField/defaultSortOrder NULL on install

...which *looks* like "relevance/ascending" in the staff client, which doesn't make sense.
This patch initializes the values at "relevance/descending", which is a functional
combination.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoMerge remote-tracking branch 'origin/new/bug_8332'
Paul Poulain [Mon, 3 Sep 2012 10:53:07 +0000 (12:53 +0200)]
Merge remote-tracking branch 'origin/new/bug_8332'

7 years agoBug 8332 follow-up: make strings translatable
Jared Camins-Esakov [Mon, 20 Aug 2012 12:30:17 +0000 (08:30 -0400)]
Bug 8332 follow-up: make strings translatable

I made a silly mistake on the original patch and made the options
untranslatable. This follow-up restores their translatability.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8332: Add relationships to auth_finder for authority links
Jared Camins-Esakov [Thu, 28 Jun 2012 22:25:55 +0000 (18:25 -0400)]
Bug 8332: Add relationships to auth_finder for authority links

In addition to the work in bug 8207 that enables auth_finder use, it
would be very useful when creating authorities to have the auth_finder
plugin automatically fill out the relationship information in $w (in
MARC21).

To test (note that you must either apply the patch for bug 8207 or
manually add a thesaurus to a 5xx linking field in one of the authority
type frameworks):
1. Create a new authority record.
2. Go to the 5xx tab.
3. Click the authority control plugin ellipsis.
4. Do a search for an authority.
5. Select a relationship type.
6. Note that after you choose an authority, that the $w control field
   is automatically populated with the relationship type.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
After applying patch for bug 8207, I had been able to follow the test plan step
by step, and get the expected result.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on master 1 August 2012

7 years agoBug 8207 follow-up: correct typo in authority types
Jared Camins-Esakov [Thu, 23 Aug 2012 13:23:50 +0000 (09:23 -0400)]
Bug 8207 follow-up: correct typo in authority types

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8207 follow-up: correct typo in authority types
Jared Camins-Esakov [Thu, 23 Aug 2012 13:23:50 +0000 (09:23 -0400)]
Bug 8207 follow-up: correct typo in authority types

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8492 follow-up DBRev number
Paul Poulain [Mon, 3 Sep 2012 09:58:46 +0000 (11:58 +0200)]
Bug 8492 follow-up DBRev number

7 years agoBug 8492 [ENH] Restrict OpacSuppression to IP adresses outside of an IP range
Mirko Tietgen [Mon, 23 Jul 2012 23:31:28 +0000 (01:31 +0200)]
Bug 8492 [ENH] Restrict OpacSuppression to IP adresses outside of an IP range

This enhancement extends the OpacSuppression feature with an optional IP address range within which results are _not_ suppressed.

To test

* turn on OpacSuppression (Administration->System preferences->Cataloging) and enter an IP address range in the OpacSuppressionByIPRange field.
* set at least one bibliographic record to suppress=1 (enter '1' in 942$n)
* fully reindex your data
* do an OPAC search that should bring up your suppressed record
* try with IP ranges that match your IP and ranges that don't

Signed-off-by: Marc Veron <veron@veron.ch>
Tested following the scenario above. Works as expected.

7 years agoBug 8525: Followup Don't reset the hz scrollbar to the top
Jonathan Druart [Fri, 3 Aug 2012 13:37:03 +0000 (15:37 +0200)]
Bug 8525: Followup Don't reset the hz scrollbar to the top

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8525: highlight matches on OPAC detail page
Jared Camins-Esakov [Mon, 30 Jul 2012 21:16:07 +0000 (17:16 -0400)]
Bug 8525: highlight matches on OPAC detail page

After doing a search and going to the details page, it can sometimes
be difficult to see exactly *why* a record was returned by a search.
By highlighting matches on the detail page as well as the results
page, we make it much easier to figure that out.

This patch uses a query_desc CGI parameter which is inserted into links
from the results page with javascript. This serves to avoid the
potential privacy implications of a cookie, and ensures that users
without javascript enabled see no change whatsoever.

To test:
1) Do a search (or two) in the OPAC with OpacHighlightedWords on.
2) View a record or two of the results, and ensure that the correct
   words are highlighted.
3) Disable OpacHighlightedWords and do another search (or two),
   this time ensuring that no words are highlighted.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
7 years agoBug 8593 - Follow-up - Add unique IDs to pending approval markup on staff client...
Owen Leonard [Wed, 8 Aug 2012 12:39:10 +0000 (08:39 -0400)]
Bug 8593 - Follow-up - Add unique IDs to pending approval markup on staff client home page

This patch adds similar IDs to the tags and comments <div>

Signed-off-by: jorgia <jorgia_m_kelsey@hotmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8593 - Add unique IDs to pending approval markup on staff client home page
Jorgia Kelsey [Wed, 8 Aug 2012 07:55:29 +0000 (20:40 +1245)]
Bug 8593 - Add unique IDs to pending approval markup on staff client home page

edited the intranet main-tt file. updated "suggestions pending". (w box)

http://bugs.koha-community.org/show_bug.cgi?id=8593
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
7 years agoBug 8646 - prevent the highlighter from going infinite loop
Robin Sheat [Thu, 16 Aug 2012 14:57:29 +0000 (16:57 +0200)]
Bug 8646 - prevent the highlighter from going infinite loop

On certain search queries, for example
http://koha-intra/cgi-bin/koha/catalogue/search.pl?kw=idx&q=ti:book%20
the highlighter starts going into an infinite loop until the browser
decides to kill it.

This patch prevents the bad input going to the highlighter.

It also includes the fix on the OPAC, even though the issue doesn't come
up there. Better to be safe...

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8573 - Translation difficult in picture-upload.tt due to nested sentence in if...
Marc Veron [Fri, 10 Aug 2012 04:20:55 +0000 (06:20 +0200)]
Bug 8573 - Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction

Text could not be correctly translated due to poor parsing of nested sentences in Pootle.

*Sentences de-nested to have whole sentence in each if /elsif branch
*Cleaned up <li></li> handling: moved closing </li> outside the for each loop to prevent orphaned closing </li>s.
*Changed indentation for better readibility
*Changed WARNING to ERROR because it is an *Error* during upload.
*Wording simplified (for translation).
*In one case added hint to refer to online help (size).

This way text should be easier to be translated in Pootle.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8498 - can't specify an hour when specifying due date
Kyle M Hall [Tue, 24 Jul 2012 17:36:09 +0000 (13:36 -0400)]
Bug 8498 - can't specify an hour when specifying due date

With hourly loans Koha can make items due specific hours,
but if you have the specify due date box on the checkout
screen you can't enter an hour/minute. It will always default
to 23:59.

* Add jquery timepicker plugin
* Update jquery ui to include timepicker prerequisite slider
* Set timepicker's default time to 23:59, remove the hard
  coded 23:59 setting from circulation.pl
* Resize input fields such that the entire date and time are
  visible.

Signed-off-by: Marc Veron <veron@veron.ch>
Works as expected, input field displays entire date and time.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8479 Calculate rank irrespective of display option
Colin Campbell [Fri, 20 Jul 2012 09:45:16 +0000 (10:45 +0100)]
Bug 8479 Calculate rank irrespective of display option

Calculation of rank was being skipped based on display
option but it is used in calculating the rank passed
to AddReserve resulting in reserves being created with
null priorities causing them to be skipped in subsequent
processing

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8556 - "Mark seen and continue" not translatable in inventory.tt
Marc Veron [Thu, 2 Aug 2012 09:25:15 +0000 (11:25 +0200)]
Bug 8556 - "Mark seen and continue" not translatable in inventory.tt

Added missing _(...) wrapper in JavaScript in inventory.tt
Additionaly added two blanks to separate buttons (were sticked together without white space)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8357: UNIMARCslim2OPACDetail.xsl, title without class and too links to views
Fridolyn SOMERS [Fri, 27 Jul 2012 09:27:40 +0000 (11:27 +0200)]
Bug 8357: UNIMARCslim2OPACDetail.xsl, title without class and too links to views

Signed-off-by: Zeno Tajoli <tajoli@cilea.it>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8522 - Markup errors cause problems with customized CSS
Owen Leonard [Mon, 30 Jul 2012 14:43:55 +0000 (10:43 -0400)]
Bug 8522 - Markup errors cause problems with customized CSS

Some includes and templates contained duplicate "header" ids in
the markup. The problem should have come up in routine page
validation, but was obvious when custom CSS was applied.

To test, load any of the affected pages and validate the
generated HTML. There should be no errors about 'ID "header"
already defined." Or, add custom CSS to intranetusercss:

...and confirm that only the topmost menu background is affected.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8550: Z39.50 searches for ISBN/ISSN problematic
Jared Camins-Esakov [Wed, 1 Aug 2012 17:34:33 +0000 (13:34 -0400)]
Bug 8550: Z39.50 searches for ISBN/ISSN problematic

Rather than treating ISBN and ISSN as the same, this patch breaks
them out into separate parts of the query, as well as changing
the truncation attribute to enable right truncation (the correct
behavior for the ISBN field in MARC21, and valid behavior in
UNIMARC).

Signed-off-by: Joseph Alway <jbalway@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8533 - Non-numeric cardnumbers screw up autoMemberNum
Kyle M Hall [Tue, 31 Jul 2012 12:14:19 +0000 (08:14 -0400)]
Bug 8533 - Non-numeric cardnumbers screw up autoMemberNum

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Removes a warning from mysql:
    Truncated incorrect INTEGER value: 'P13000'

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8575: Expected items count should not include cancelled orders
Julian Maurice [Mon, 6 Aug 2012 12:20:25 +0000 (14:20 +0200)]
Bug 8575: Expected items count should not include cancelled orders

To test:
  1/ create a new basket with 2 orders, one with 1 item, another with 2
     items
  2/ look at booksellers.pl page, you should see that 3 items are
     expected
  3/ cancel the order with 1 item
  4/ refresh booksellers.pl page, it should remains 2 expected items

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Works exactly as designed

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8419 - Suspended holds appear on the daily holds queue
Kyle M Hall [Wed, 11 Jul 2012 14:16:35 +0000 (10:16 -0400)]
Bug 8419 - Suspended holds appear on the daily holds queue

Suspended holds are showing up in both the holds queue and holds to pull reports.

This patch adds to the sql queries such that any hold that is suspended
is not selected.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8413 Space in barcodes breaks GET request in benchmark_staff.pl
Mirko Tietgen [Wed, 11 Jul 2012 11:08:10 +0000 (13:08 +0200)]
Bug 8413 Space in barcodes breaks GET request in benchmark_staff.pl

GET requests in benchmark_staff.pl test 6 do not work if a space character is part of the barcode. That seems highly unlikely to happen in barcodes, but is possible if no real barcodes are used but a substitute, like a copy of the call number. Space character needs to be changed to %20 for the request to work.

Also fixes a typo.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8524 follow-up: fix Javascript syntax error
Jared Camins-Esakov [Thu, 9 Aug 2012 12:39:10 +0000 (08:39 -0400)]
Bug 8524 follow-up: fix Javascript syntax error

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
7 years agoBug 8524: Followup FIX an undeclared variable $query
Jonathan Druart [Thu, 9 Aug 2012 12:07:35 +0000 (14:07 +0200)]
Bug 8524: Followup FIX an undeclared variable $query

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
7 years agoBug 8524 follow-up: fix broken test
Jared Camins-Esakov [Thu, 9 Aug 2012 11:45:05 +0000 (07:45 -0400)]
Bug 8524 follow-up: fix broken test

The t/Barcodes_ValueBuilder.t test had the wrong number of tests
declared, and rather than checking that a variable was undefined I was
checking that it had a length of zero. Fixed both issues.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
7 years agoBug 8524: Add a non-automatic barcode plugin
Jared Camins-Esakov [Wed, 1 Aug 2012 15:54:55 +0000 (11:54 -0400)]
Bug 8524: Add a non-automatic barcode plugin

In addition to adding a new barcode plugin, this commit begins
refactoring the barcode generation code using a new module,
C4::Barcodes::ValueBuilder. From the POD:
    This module is intended as a shim to ease the eventual transition
    from having all barcode-related code in the value builder plugin
    barcode.pl file to using C4::Barcodes. Since the shift will require
    a rather significant amount of refactoring, this module will return
    value builder-formatted results, at first by merely running the
    code that was formerly in the barcodes.pl value builder, but later
    by using C4::Barcodes.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
7 years agoBug 8485 - Make koha_perl_deps.pl batch friendly Added a -b flag for brief which...
Mark Tompsett [Tue, 31 Jul 2012 15:09:27 +0000 (23:09 +0800)]
Bug 8485 - Make koha_perl_deps.pl batch friendly Added a -b flag for brief which outputs only the perl library name (Foo::BaR), and added a -r flag for required which filters the list to required=Yes perl libraries.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8532 - improve robustness when converting dates
Robin Sheat [Tue, 31 Jul 2012 11:22:48 +0000 (13:22 +0200)]
Bug 8532 - improve robustness when converting dates

If undef is passed to the date format conversion function, it dies. This
can happen when you have old data in the database. Better to handle it
in some fashion rather than die, so now it just returns undef too.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I replace "return undef" with just "return" to pass perlcritic

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8293: Software error when clicking on first or last result of each page on OPAC
Fridolyn SOMERS [Wed, 8 Aug 2012 14:34:32 +0000 (16:34 +0200)]
Bug 8293: Software error when clicking on first or last result of each page on OPAC

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8520: fix authority display in autocomplete
Jared Camins-Esakov [Tue, 7 Aug 2012 14:49:44 +0000 (10:49 -0400)]
Bug 8520: fix authority display in autocomplete

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8637: Lack of control on mandatory in orderreveive.tt
Christophe Croullebois [Mon, 13 Aug 2012 15:09:30 +0000 (17:09 +0200)]
Bug 8637: Lack of control on mandatory in orderreveive.tt

Just add a check in Jscript when the form is submited, the same as in additem.tt
On Owen's suggestion I have added the red color and 'Required', the same as in additem.
On Jonathan's suggestion I have used the CSS class for red and italic and I have changed a variable's name (alertString2).
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Mandatory fields are now correctly checked on saving.

On other Jonathan's suggestion I have created a new class "missing" and I have added the background to staff-global.css.
The same for additem.tt.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Retested because of minor CSS change. Works nicely.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8588 - Duplicate field IDs cause problems with SQL report parameter entry
Owen Leonard [Tue, 7 Aug 2012 19:09:35 +0000 (15:09 -0400)]
Bug 8588 - Duplicate field IDs cause problems with SQL report parameter entry

Changes to markup and script to enable unique ids on form
fields. These changes allow for working label+input pairs
on one or more text and select inputs and multiple working
datepickers.

To test, create a report with more than one date parameter,
at least one text parameter, and one or more authorised
value parameters. The datepickers should each work properly,
and labels should by clickable.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8590 - checked out from missing on patron detail
Owen Leonard [Tue, 7 Aug 2012 20:08:46 +0000 (16:08 -0400)]
Bug 8590 - checked out from missing on patron detail

Adding back the line in the script which pulls the name
of the branch where the item was checked out.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8596 - Reports interface date picker doesn't force ISO formatted dates
Owen Leonard [Tue, 14 Aug 2012 14:02:38 +0000 (10:02 -0400)]
Bug 8596 - Reports interface date picker doesn't force ISO formatted dates

Datepickers follow Koha's preference for date format, but the
guided reports system doesn't intelligently handle different date
formats. ISO is required. This patch adds some additional
configuration to override the date format.

To test, create a guided or SQL report which takes a date
parameter. The datepicker fields should return an ISO-formatted
date.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Works as advertised.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8621: Alternative template for cart email
Katrin Fischer [Sun, 12 Aug 2012 20:33:24 +0000 (22:33 +0200)]
Bug 8621: Alternative template for cart email

- uses less list elements, in favour of paragraphs and line breaks
- reimplements a link to the opac for each record

Note: In order for the URLs to be correct this needs to be tested
together with the patch for bug 8626.

To test:
- Add several records to the cart, add items with and without items
- Send yourself the cart as email and check formatting
- Update po files for any language, translate the po file for OPAC
  and install language
- Send yourself the cart email again from the translated templates,
  check formatting

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8626: Fix encoding in cart emails for use of quoted-printable
Katrin Fischer [Tue, 14 Aug 2012 06:02:59 +0000 (08:02 +0200)]
Bug 8626: Fix encoding in cart emails for use of quoted-printable

When using quoted-printable data needs to be encoded accordingly.

Content-Transfer-Encoding: quoted-printable

Without the patch = in URLs or data will be interpreted as the beginning
of a special character resulting in broken URLs.

To test:
- Check diacritics in records display correctly
- Check various URLs with = to make sure they all work correctly

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
This is only a partial fix, as the subject line is not encoded,
but it is a huge improvement over what it was before.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8640 - GetHardDueDate functions incorrectly
Kyle M Hall [Tue, 14 Aug 2012 17:17:38 +0000 (13:17 -0400)]
Bug 8640 - GetHardDueDate functions incorrectly

GetHardDueDate works just like GetIssuingRule, but it not only tests for having
found an row of results before returning, but checks for the existence of a
hard due date as well. That means that even if it finds a matching rule, unless
that rule has a hardduedate set it will toss it and keep looking!

So, for example, even though there is a matching rule for say "STAFF / VIDEO / *",
but it has no hardduedate. So it gets tossed and the subroutine keeps looking.
If the next match, "STAFF / * / *" *has* a hardduedate, it is the one returned.

This means that if a more specific rule has no hard due date,
it is overridden by a less specific rule that does have a hard due date.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8648: searchResults uses SQL query rather than GetMarcFromKohaField
Jared Camins-Esakov [Wed, 15 Aug 2012 19:48:05 +0000 (15:48 -0400)]
Bug 8648: searchResults uses SQL query rather than GetMarcFromKohaField

Around line 1470-something:

    my $sth =
    $dbh->prepare(
            "SELECT tagfield FROM marc_subfield_structure WHERE kohafield LIKE
            'items.itemnumber'"
            );
    $sth->execute;

This patch replaces that with a call to GetMarcFromKohaField.

To test:
1) Apply patch.
2) Do a search that returns both available and unavailable items.
   You'll know if the patch isn't working.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8655 - Re-order items on administration page to better match configuration priority
Owen Leonard [Fri, 17 Aug 2012 17:59:47 +0000 (13:59 -0400)]
Bug 8655 - Re-order items on administration page to better match configuration priority

Circulation and Fine Rules should have a higher priority than
cities and road types.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Tested on main admin page and the menu on the left of all of the
other admin pages. Looks a-ok to me.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8657 follow-up DBRev number
Paul Poulain [Wed, 29 Aug 2012 15:57:53 +0000 (17:57 +0200)]
Bug 8657 follow-up DBRev number

7 years agoBug 8657 - Default sort by call number does not work
Owen Leonard [Mon, 20 Aug 2012 14:59:26 +0000 (10:59 -0400)]
Bug 8657 - Default sort by call number does not work

If you choose to sort search results in the OPAC or staff
client by call number by default, the wrong value will
be saved by the system preferences editor. It should be
"call_number" instead of "callnumber." This patch
corrects the pref file and updates the database in cases
where defaultSortField or OPACdefaultSortField are
set to the incorrect value for call number sort.

To test: Set defaultSortField and/or OPACdefaultSortField
to "call number" and perform a search. Results will be
sorted by relevance. Apply the patch, update the database,
and search again. Results should now be sorted by call number.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
with the caveat that this will not fix the issue unless the sort order is first set to descending and back to ascending per bug 8012.

However, with the sort order set to a proper sort value, this patch does fix the issue.

7 years agoBug 8670 follow-up DBRev number
Paul Poulain [Wed, 29 Aug 2012 15:46:14 +0000 (17:46 +0200)]
Bug 8670 follow-up DBRev number

7 years agoBug 8679 [REVISED] Remove usage of Amazon API
Owen Leonard [Mon, 27 Aug 2012 20:04:48 +0000 (16:04 -0400)]
Bug 8679 [REVISED] Remove usage of Amazon API

This patch removes the AmazonReviews and AmazonSimilarItems
features from the OPAC and staff client. With on Amazon
feature remaining, cover images, the *AmazonEnabled preference
is also removed in favor of checking the *AmazonCoverImages
preference. Two other system preferences, AWSAccessKeyID and
AWSPrivateKey are removed as they were required only by the
removed features.

Handling of book cover images from Amazon is unchanged.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Turned on amazon covers in opac and staff client and all
worked as expected. Then tested to make sure other cover image
services still worked and they do.

Signing off.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8172: Followup: Removes useless empty params
Jonathan Druart [Mon, 2 Jul 2012 14:14:35 +0000 (16:14 +0200)]
Bug 8172: Followup: Removes useless empty params

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8172 - Missing dereference marker for buildQuery parameter in addbooks.pl Added...
Mark Tompsett [Fri, 29 Jun 2012 14:24:50 +0000 (22:24 +0800)]
Bug 8172 - Missing dereference marker for buildQuery parameter in addbooks.pl Added a dereference to an array parameter of buildQuery.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
7 years agoBug 8329 - GetLostItems in C4::Items.pm has a SELECT * Provided a smaller list based...
Mark Tompsett [Fri, 29 Jun 2012 14:40:24 +0000 (22:40 +0800)]
Bug 8329 - GetLostItems in C4::Items.pm has a SELECT * Provided a smaller list based on reports/itemlost.tt

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8395: Fix sort order in parcel.tt (summary)
Jonathan Druart [Mon, 23 Jul 2012 09:46:01 +0000 (11:46 +0200)]
Bug 8395: Fix sort order in parcel.tt (summary)

Signed-off-by: Marc Veron <veron@veron.ch>
Patch behaves as expected.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8513: OPAC detail page broken with XSLT
Fridolyn SOMERS [Mon, 30 Jul 2012 12:36:33 +0000 (14:36 +0200)]
Bug 8513: OPAC detail page broken with XSLT

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8547 - JS error in star ratings breaks IE
Robin Sheat [Wed, 1 Aug 2012 12:23:14 +0000 (14:23 +0200)]
Bug 8547 - JS error in star ratings breaks IE

Writing code with best practices in mind breaks IE. Thanks Internet
Explorer. Now go DiaF.

Signed-off-by: Marc Veron <veron@veron.ch>
Tested with with IE 7.0.5730.13 on Windows XP, no JS errors, stars display and behave as expected

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(Aslo tested it does not break FF)

7 years agoBug 8572: invalid auth shouldn't cause error
Jared Camins-Esakov [Sat, 4 Aug 2012 17:48:00 +0000 (13:48 -0400)]
Bug 8572: invalid auth shouldn't cause error

Prior to this patch, attempting to view an invalid authority in the
OPAC gave a system error instead of a 404. With this patch, the user
will just get a 404, as is the case with invalid bibs.

To test:
1) Try to view an invalid authority by going to:
   /cgi-bin/koha/opac-authoritiesdetail.pl?authid=999999999999
   (presuming that you don't have an authority with authid 999999999999
   in your database) before and after applying this patch

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8636: Add missing dependencies
Jared Camins-Esakov [Mon, 13 Aug 2012 22:16:27 +0000 (18:16 -0400)]
Bug 8636: Add missing dependencies

Cache::Memcached::Fast is used for caching
Test::YAML::Valid is used for tests
Signed-off-by: Marc Veron <veron@veron.ch>
Dependencies appear as expected...
...and I see that they are not instaled yet on my server  :-)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8162: allow packages to work on Ubuntu Precise
Robin Sheat [Fri, 20 Jul 2012 10:20:47 +0000 (12:20 +0200)]
Bug 8162: allow packages to work on Ubuntu Precise

The newer version of MySQL in Ubuntu 12.04 installs a default
'localhost' user with no username. Due to the way that MySQL looks up
user details when you connect, if you connect from localhost and the
user was only created with a wildcard host (%), the anonymous localhost
user will be found instead. This means that your username is lost for
the connection, and you have no privileges.

This patch creates a second user with a hostname of 'localhost'. This
will not work if your database is on a remote server, but you probably
know what you are doing if that's the case. Patches to determine this
server's name relative to the MySQL server are welcome (or even ideas on
how to do it.)

It also fixes up a couple of other small things:
* make koha-remove stop zebra properly
* stop the warning that the password file is missing on create

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Works as promised.

7 years agoMerge remote-tracking branch 'origin/new/bug_8268'
Paul Poulain [Tue, 28 Aug 2012 16:03:34 +0000 (18:03 +0200)]
Merge remote-tracking branch 'origin/new/bug_8268'

7 years agoBug 8268: improve error checking
Jared Camins-Esakov [Wed, 1 Aug 2012 14:30:45 +0000 (16:30 +0200)]
Bug 8268: improve error checking

Valid download attempts were being denied thanks to an incorrect
regular expression. This patch fixes that, and makes it easier to
understand what's going on in the code.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8268 follow-up: rewrite config correctly
Jared Camins-Esakov [Sat, 28 Jul 2012 01:45:47 +0000 (21:45 -0400)]
Bug 8268 follow-up: rewrite config correctly

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Problem fixed.

7 years agoBug 8576: Software error on authority edition when using merge
Fridolyn SOMERS [Mon, 6 Aug 2012 13:01:09 +0000 (15:01 +0200)]
Bug 8576: Software error on authority edition when using merge

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8495: Fix JS error when creating a new order
Julian Maurice [Tue, 24 Jul 2012 10:24:11 +0000 (12:24 +0200)]
Bug 8495: Fix JS error when creating a new order

bug introduced by bug 7178
(http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8607: FIX overdues_notices script: $date is not replaced
Jonathan Druart [Thu, 9 Aug 2012 13:40:53 +0000 (15:40 +0200)]
Bug 8607: FIX overdues_notices script: $date is not replaced

The script is unusable.
The variable $date is not replaced with its content.

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 5600: very tiny follow-up to pass perlcritic
Julian Maurice [Fri, 3 Aug 2012 15:00:06 +0000 (17:00 +0200)]
Bug 5600: very tiny follow-up to pass perlcritic

open was called with 2 arguments instead of 3

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 5600 follow-up: Fix commandline check in order to work under Plack
Julian Maurice [Fri, 3 Aug 2012 14:26:34 +0000 (16:26 +0200)]
Bug 5600 follow-up: Fix commandline check in order to work under Plack

With plackup, @ARGV can contains elements so we can't check the size of
@ARGV to tell whether we are in command line mode or not.
Instead we check environment variable GATEWAY_INTERFACE.

Also fix the use of a global variable in a subroutine

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 5600: Command line interface for tools/export.pl
Julian Maurice [Wed, 6 Jun 2012 13:28:18 +0000 (15:28 +0200)]
Bug 5600: Command line interface for tools/export.pl

export.pl [--format=format] [--date=date] [--dont_export_items]
  [--deleted_barcodes] [--clean] --filename=outputfile

    * format is either 'xml' or 'marc' (default)
    * date should be entered as the 'dateformat' syspref is set
      (dd/mm/yyyy for metric, yyyy-mm-dd for iso, mm/dd/yyyy for us)
    * records exported are the ones that have been modified since 'date'
    * if --deleted_barcodes is used, a list of barcodes of items deleted
      since 'date' is produced (or from all deleted items if no date is
      specified)
    * --clean removes NSE/NSB

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 3383 - Followup - Switch from GetMemberDetails to GetMember
Kyle M Hall [Mon, 2 Jul 2012 16:19:23 +0000 (12:19 -0400)]
Bug 3383 - Followup - Switch from GetMemberDetails to GetMember

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 3383 - Item due reminder digests - cannot display title information
Kyle M Hall [Wed, 4 Apr 2012 13:56:11 +0000 (09:56 -0400)]
Bug 3383 - Item due reminder digests - cannot display title information

Adds the ability to use branches.* fields in digest notices and
have them be parsed correctly. Also adds a warning to the notices
editor for digests.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I like the idea to show a warning, but I would perhaps move
it under the message body label to be more obvious.

Patch works nicely, branch data of my user's home library
is displayed in the notice.

7 years agoBug 7628: Escape '+' characters for categorycode
Jonathan Druart [Fri, 20 Jul 2012 08:48:27 +0000 (10:48 +0200)]
Bug 7628: Escape '+' characters for categorycode

uri escape the following characters:
    &, @, /, ;, :, =, +, ? and $

Signed-off-by: Marc Veron <veron@veron.ch>
Test and sign off second patch (independently from first patch).

Added categories like '+zwoelf' or '? Test' before applying the patch.
Deletion was not possible.

After applying patch deletion is possible, patch works as expected.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 7628 - Required format is not enforced for Patron Categories
Marc Veron [Wed, 18 Jul 2012 05:57:36 +0000 (07:57 +0200)]
Bug 7628 - Required format is not enforced for Patron Categories

Enforces category code with allowed characters only.

Test plan:

- Before applying patch, create a category code like Test+

- Try to delete category with this code -> does not work

- Apply patch

- Try to create category with code containg other characters than letters, numbers, - and _

- Result: You are not allowed to do so, appropriate message pops up

Signed-off-by: David Cook <dcook@prosentient.com.au>
7 years agoBug 8263 follow-up DBRev number
Paul Poulain [Fri, 3 Aug 2012 10:30:04 +0000 (12:30 +0200)]
Bug 8263 follow-up DBRev number

7 years ago8263 Consistent stylesheet prefs
Marcel de Rooy [Mon, 18 Jun 2012 09:42:50 +0000 (11:42 +0200)]
8263 Consistent stylesheet prefs

This patch makes the use of opaccolorstylesheet and opaclayoutstylesheet more consistent. They may be: 1) just a file name, 2) a complete local path or 3) a full URL starting with http: for a remote css file.
This makes the syspref opacstylesheet that was only used for a remote css file obsolete.

June 20, 2012 Rebased.
July 18, 2012: Regex allows https too (thanks to Owen Leonard).

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years ago8263 Make OPAC stylesheet preferences more consistent (dbrev)
Marcel de Rooy [Mon, 18 Jun 2012 11:53:59 +0000 (13:53 +0200)]
8263 Make OPAC stylesheet preferences more consistent (dbrev)

This patch handles the dbrev for this report. It optionally saves the value of the former opacstylesheet pref into opaclayoutstylesheet.

June 21, 2012 & July 4, 2012: Rebased.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
7 years agoBug 8544 - make the RSS icon CSS-changeable
Robin Sheat [Tue, 31 Jul 2012 20:58:50 +0000 (22:58 +0200)]
Bug 8544 - make the RSS icon CSS-changeable

This gives the RSS bits on the search results some CSS classes so it can
be modified with CSS or javascript.

Updated: added also to the RSS icon shown when no results are found.
Signed-off-by: Marc Veron <veron@veron.ch>
Patch behaves as expected.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8385: Dirty patch to make tt_valid.t happy
Jonathan Druart [Wed, 1 Aug 2012 13:35:21 +0000 (15:35 +0200)]
Bug 8385: Dirty patch to make tt_valid.t happy

A problem in routine text_replace_tag (tmpl_process3.pl) have to be
fixed to prevent this kind of patch :)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 6448 follow-up, DBrev number
Paul Poulain [Thu, 2 Aug 2012 16:49:59 +0000 (18:49 +0200)]
Bug 6448 follow-up, DBrev number

7 years agoBug 6448 [2/3] Barcodes::EAN13 autoBarcode
Dobrica Pavlinusic [Wed, 28 Mar 2012 12:43:35 +0000 (14:43 +0200)]
Bug 6448 [2/3] Barcodes::EAN13 autoBarcode

Implement auto-incrementing EAN-13 barcodes

To make this work, C4::Barcodes::next was modified to call process_tail with
new incremented value so that process_tail can generate correct checksum.
Since process_tail is currenlty not used by any barcodes, this change is safe.

C4::Barcodes is used by addbiblio.pl when adding multiple records, while value_builder
is used in all other cases.

Test scenario:

1. prove t/Barcodes_EAN13.t

2. KOHA_CONF=/etc/koha/sites/fer/koha-conf.xml prove t/db_dependent/Barcodes.t
   this will check C4::Barcode implementataion

3. in systempreference change autoBarcode to incremental EAN-13 barcode

4. edit two items of any biblio assigning barcodes and verify that numbers
   are increasing. Have in mind that last digit is check digit, and it
   doesn't increment, but is calculated from barcode itself. Example with
   checksum in brackets: 000000086275[2], 000000086276[9], 000000086277[6]

5. Add Item and verify that it gets assigned next barcode

6. Add & Duplicate item and verify barcode increase

7. Add Multiple Copies and verify that barcode increase for each copy

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 6448 [1/3] EAN-13/UPC-A itemBarcodeInputFilter
Dobrica Pavlinusic [Tue, 27 Mar 2012 22:38:34 +0000 (00:38 +0200)]
Bug 6448 [1/3] EAN-13/UPC-A itemBarcodeInputFilter

This filter which check validity of EAN-13 barcode and padd it with zeros
up to full 13 digit number. This will also expand 12 digit UPC-A barcodes
to EAN-13 automatically which is useful for older barcode readers which tend
to ignore first zero in EAN-13 if they have just UPC-A support.

It should be noted that EAN-13 or UPC-A product codes printed on books are not
good choice for barcodes in Koha since each item has to have unique barcode.

Test scenario:

1. prove t/Circulation_barcodedecode.t
   this checks expansion of 12 digit UPC-A to 13 digit EAN-13 and zero padding

2. in systempreferences search for itemBarcodeInputFilter and select EAN-13

3. edit one item and assign it valid EAN-13 barcode, eg. 0000000695152, check it out

4. test checkin with just 695152 to test leading zero expansion

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
7 years agoBug 6448 [3/3] EAN-13 barcode labels
Dobrica Pavlinusic [Sat, 4 Jun 2011 12:23:20 +0000 (14:23 +0200)]
Bug 6448 [3/3] EAN-13 barcode labels

Current implementation doesn't scale barcodes because low-price
CCD barcode readers are very sensitive about size

Test scenario:

1. in Tools > Labels create or edit Layout and select EAN13 as barcode
   type

2. export one of existing batches using EAN13 layout and verify that
   generated pdf file contains barcodes

3. print pdf file and test it with barcode reader

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
7 years agobug 8477 follow-up for [HTML4] coding guideline
Paul Poulain [Thu, 2 Aug 2012 15:40:07 +0000 (17:40 +0200)]
bug 8477 follow-up for [HTML4] coding guideline

7 years agoBug 8477: Displays home/holding branches on return page
Adrien Saurat [Thu, 19 Jul 2012 13:39:41 +0000 (15:39 +0200)]
Bug 8477: Displays home/holding branches on return page

Signed-off-by: Mirko Tietgen <5p4m@gmx.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8455 - Followup - perltidy renewscript.pl
Kyle M Hall [Wed, 18 Jul 2012 14:10:59 +0000 (10:10 -0400)]
Bug 8455 - Followup - perltidy renewscript.pl

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8455 - Check ins processed through "Check Out" tab of the Patron Record ignore...
David Cook [Tue, 17 Jul 2012 08:30:13 +0000 (18:30 +1000)]
Bug 8455 - Check ins processed through "Check Out" tab of the Patron Record ignore Circulation System Preferences

If you check-in an item through the "Check Out" tab of the Patron Record, the return/check-in ignores the "InProcessingToShelvingCart" and "ReturnToShelvingCart" circulation system preferences. Or rather, there just isn't any logic to handle them in the renewscript.pl file.

I'm pretty much just bringing the code straight across from returns.pl, although some minor changes need to be made due to context.

Both system preferences are important to include, since you can check-out an in processing item to a patron. While a regular check-in will clear the in processing status, a check-in through the Patron module will cause the item to have its status returned to "In Processing" rather than going to "Shelving Cart", if the preference is set, of course.

To test the scenario, turn on one of (or both of) these settings and try checking books in through the Circulation module and the Patron module.

Before the patch, you will see that only the Circulation module will change the shelving location.

After the patch, you should see identical behaviour.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
http://bugs.koha-community.org/show_bug.cgi?id=7189

7 years agoBug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test
Mason James [Wed, 18 Jul 2012 02:04:50 +0000 (14:04 +1200)]
Bug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test

modified:   Koha/SearchEngine/Solr/Search.pm

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 4198 - Followup - PerlTidy authorities-home.pl
Kyle M Hall [Thu, 5 Jul 2012 14:36:39 +0000 (10:36 -0400)]
Bug 4198 - Followup - PerlTidy authorities-home.pl

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 4198 - deleting an authority refreshes the page
Kyle M Hall [Thu, 5 Jul 2012 14:33:40 +0000 (10:33 -0400)]
Bug 4198 - deleting an authority refreshes the page

Makes clicking a Delete link refresh the search that
was performed so that the results are still on the screen.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Works as advertised. Very usefull. Still the issue that indexing being
not in real time, the search result displays the just deleted authority.
But there is no way to do better.

7 years agoMerge remote-tracking branch 'origin/new/bug_6720'
Paul Poulain [Thu, 2 Aug 2012 13:40:31 +0000 (15:40 +0200)]
Merge remote-tracking branch 'origin/new/bug_6720'

7 years agoBug 6720 follow-up: fix error when auth has been deleted
Jared Camins-Esakov [Thu, 2 Aug 2012 13:18:39 +0000 (09:18 -0400)]
Bug 6720 follow-up: fix error when auth has been deleted

Thanks to Paul Poulain for finding the problem and proposing a solution.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8520: fix authority display in staff client
Jared Camins-Esakov [Mon, 30 Jul 2012 13:25:30 +0000 (09:25 -0400)]
Bug 8520: fix authority display in staff client

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoAdded a URI filter to encode a cardnumber for borrowers as to not break patronimage.pl
Elliott Davis [Wed, 11 Jul 2012 10:52:53 +0000 (05:52 -0500)]
Added a URI filter to encode a cardnumber for borrowers as to not break patronimage.pl

To Test:

Add a + (or any char that would need to be encoded) to a card number of a patron with an image attached.
Go to member/moremember.pl.
If the patrons image is there, you are golden.

http://bugs.koha-community.org/show_bug.cgi?id=8421
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 7470: Followup: Changes mailto links
Jonathan Druart [Fri, 30 Mar 2012 13:50:03 +0000 (15:50 +0200)]
Bug 7470: Followup: Changes mailto links

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 7470 follow-up: adding comments to avoid removal of this file
Paul Poulain [Thu, 2 Aug 2012 12:14:26 +0000 (14:14 +0200)]
Bug 7470 follow-up: adding comments to avoid removal of this file

it is unused by Koha itself, but must be here for babeltheque customers !

7 years agoBug 7470: Followup Move Babeltheque css into a specific file
Jonathan Druart [Mon, 23 Apr 2012 07:30:48 +0000 (09:30 +0200)]
Bug 7470: Followup Move Babeltheque css into a specific file

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8427 - Patron search results not consistent
Kyle M Hall [Thu, 12 Jul 2012 11:55:06 +0000 (07:55 -0400)]
Bug 8427 - Patron search results not consistent

Simple fix, removed the directive to order by surname, and the system
now orders by surname, then firstname.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
7 years agoBug 8432 follow-up, fixing error in T::T variable scope
Paul Poulain [Thu, 2 Aug 2012 11:25:24 +0000 (13:25 +0200)]
Bug 8432 follow-up, fixing error in T::T variable scope

7 years agoBug 8432: Change serials results display
Jonathan Druart [Fri, 13 Jul 2012 09:26:36 +0000 (11:26 +0200)]
Bug 8432: Change serials results display

The original author of this patch is : Julian Maurice

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>