koha.git
22 months agoBug 20663: Remove dead code related to compound reports
Mark Tompsett [Thu, 26 Apr 2018 04:17:51 +0000 (04:17 +0000)]
Bug 20663: Remove dead code related to compound reports

TEST PLAN
---------
git grep "Create Compound Report"
-- only one file
git grep compound | grep 1
-- this is the only setting of the compound tt variable
less koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
-- There is an TT IF statement for compound.
-- In that statement it would trigger 'Save Compound'
git grep save_compound
-- only the template and the guided report perl
git grep create_compound
-- only triggered by the save code in the guided report perl
-- in the export for the C4/Reports/Guided.pm
git grep run_compound
-- left over in export

apply the patch
look around and see the pieces are cleaned up.

run koha qa test tools

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 19171: Attempt to make "no holds possible" messages less confusing
Katrin Fischer [Sun, 22 Apr 2018 22:00:17 +0000 (22:00 +0000)]
Bug 19171: Attempt to make "no holds possible" messages less confusing

At the moment, when no holds are possible, the OPAC reads something
like:

Sorry, none of these items can be placed on hold.
No items available.

This is confusing to the patrons, because the records have items,
but they are not showing. The record also may have available items,
they are just not permitted to place holds on them.

Changes:
- Only display the first message, when somoene tried unsuccessfully
  to place holds on multiple records.
- Change first message to: Sorry, none of these titles can be placed on hold.
- Change the second message to read:
  No items available to be placed on hold.
- Remove <strong> around Sorry for better translatability.

To test:
- Try to place a hold on single record, where no hold is possible.
- Try to place a hold on a single record, where a hold is possible.
- Try to place holds on multiple records where no hold is possible.
- Try to place holds on multiple records where at least one hold
  is possible.

  Verify the screen messages make sense in all cases.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Fixed stray </strong> during signoff.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
For consistency with staff, I renamed multi_holds to multi_hold.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 20685: Escape letter template content in textarea
Jonathan Druart [Thu, 3 May 2018 18:40:11 +0000 (15:40 -0300)]
Bug 20685: Escape letter template content in textarea

Test plan:
enter the following text into the Email template for 'HOLD_SLIP'
in Home › Tools › Notices & Slips › Modify notice

<div style='max-width: 4in;'>
<h3><<borrowers.surname>>, <<borrowers.firstname>></h3><br />
<<borrowers.streetnumber>> <<borrowers.address>><br />
<<borrowers.address2>><br />
<<borrowers.city>>, <<borrowers.state>> <<borrowers.zipcode>><br />
<br />
<br />
<img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5&notext=1">

Edit it again
Without this patch you will get:
<img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5¬ext=1">

Signed-off-by: Barton Chittenden <barton@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 11317: Add id and class attributes to body
Jonathan Druart [Thu, 3 May 2018 17:30:00 +0000 (14:30 -0300)]
Bug 11317: Add id and class attributes to body

This fixes xt/tt_valid.t
 #   Failed test '<body> tag with id and class attributes'
 #   at xt/tt_valid.t line 91
 # Files list:
 # intranet-tmpl/prog/en/modules/tools/access_files.tt: 8
 # Looks like you failed 1 test of 3.
 [16:44:56] xt/tt_valid.t
 Dubious, test returned 1 (wstat 256, 0x100)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 11317: DBRev 17.12.00.041
Jonathan Druart [Thu, 3 May 2018 16:39:53 +0000 (13:39 -0300)]
Bug 11317: DBRev 17.12.00.041

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 11317: (QA follow-up) Change tool name to be more general
Katrin Fischer [Sat, 28 Apr 2018 00:30:55 +0000 (02:30 +0200)]
Bug 11317: (QA follow-up) Change tool name to be more general

I think this tool could be used in multiple ways, for all kinds
of files that you want to protect by login in Koha. So a more
general name might work better.

This is a suggestion, not mandatory.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 11317: (QA follow-up) Fix merge error and punctuation
Katrin Fischer [Fri, 27 Apr 2018 22:29:06 +0000 (00:29 +0200)]
Bug 11317: (QA follow-up) Fix merge error and punctuation

2 tiny fixes:
- Remove space before : as this is not correct in English
- Remove an errorenous commented line that probably snuck back
  in from a merge

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 11317: (follow-up) Add two-level entry to koha-conf and remove unwanted characters
Roch D'Amour [Mon, 23 Apr 2018 13:20:35 +0000 (09:20 -0400)]
Bug 11317: (follow-up) Add two-level entry to koha-conf and remove unwanted characters

- Removed merge marker
- Changed include path in favor of using the Asset tt plugin (bug 20538)
- Changed access_dir to a two-level entry for clarity

Test plans stay the same, just make sure that the two-level configuration entry
work properly and everything pass QA.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 11317: Add a way to access files from the intranet
Roch D'Amour [Tue, 17 Apr 2018 18:24:07 +0000 (14:24 -0400)]
Bug 11317: Add a way to access files from the intranet

This squash contains all of these commits:
- Adds a page to access log files on the server from the intranet
- Update ID to allow for permalinking
- Rename config to "'accessdir' and fix qa
- Allows for multiple directories to be accessible
- Update the link under reports
- (Follow-up) Fixing merge error and cosmetic changes
- (Follow-up) Fix tab chars and move javascript to the footer
- (QA Follow-up) Fix datatable
- Make filename unicode-proof, renamed accessdir to access_dir and fix update

Test plans:
- Apply patch, update database
- Add to koha-conf:
<access_dir>/tmp/koha-public/one</access_dir>
<access_dir>/tmp/koha-public/two</access_dir>
<access_dir>/tmp/koha-public</access_dir>
- Create these directories ( mkdir /tmp/koha-public , etc...)
- Create these files:
echo "hello world!" > /tmp/koha-public/❤
echo "test" > /tmp/koha-public/one/samename.txt
echo "this is not the same" > /tmp/koha-public/two/samename.txt
- Login as Superadmin, go to tools > reports files
    - Click on ❤, make sure it's downloadable and readable
    - Click on both samename.txt, look inside and make sure the file is different
- Login as NON-superadmin. Go under tools, see no Report/Log under the third column
    - Go to add tools/access_file permission to user
    - See new entry under tools third column.
    - validate link is ok.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 20103: Readonly::XS is completely bogus post perl 5.8
Mark Tompsett [Wed, 28 Mar 2018 22:40:09 +0000 (22:40 +0000)]
Bug 20103: Readonly::XS is completely bogus post perl 5.8

A ha! Lie about who we are, and the module will return a version.

./koha_perl_deps.pl -a
-- before patch Readonly::XS is 0
-- after patch it has a version number.
run koha qa test tools

Signed-off-by: Victor Grousset <victor.grousset@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 20444: Remove sub GetAttributes
Josef Moravec [Mon, 19 Mar 2018 09:33:50 +0000 (09:33 +0000)]
Bug 20444: Remove sub GetAttributes

0) Apply this patch
1) git grep GetAttributes should return no occurencies

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 20444: Update test
Josef Moravec [Mon, 19 Mar 2018 09:33:07 +0000 (09:33 +0000)]
Bug 20444: Update test

0) Apply this patch
1) prove t/db_dependent/Members/Attributes.t
should return green

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 20444: Use Koha::Patron::Attribute::Types object for getting patron attributes...
Josef Moravec [Mon, 19 Mar 2018 09:27:07 +0000 (09:27 +0000)]
Bug 20444: Use Koha::Patron::Attribute::Types object for getting patron attributes in letter.pl

Test plan:
0) Apply the patch
1) Do not have any patron attribute types defined
2) Go to Tools -> Notices and slips
3) Edit any slip/letter which uses table borrower
4) Confirm the editing works, and the slip/letter itself works
5) Add some patron attributes types and define them a value for any
patron
6) Go to Tools -> Notices and slips and edit any slip/letter which uses
table borrower
7) Confirm, the attributes are listed in available fields
8) Confirm the slip/letter is working when you add a attribute to it

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 19752: offline_circ/service.pl - Return HTTP status 401 when authentication faile...
Alex Arnaud [Tue, 5 Dec 2017 10:43:05 +0000 (10:43 +0000)]
Bug 19752: offline_circ/service.pl - Return HTTP status 401 when authentication failed and add option nocookie

Test plan:

- Apply this patch,
- log in to Koha,
- go to cgi-bin/koha/offline_circ/service.pl with no valid user
  and password as parameters and nocookie set to 1. i.e:
  cgi-bin/koha/offline_circ/service.pl?userid=alex&password=wrongpass&nocookie=1,
- auth should fail
- check that the response code is 401

Signed-off-by: Maksim Sen <maksim.sen@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 19972: (QA follow-up) Fix id name
Katrin Fischer [Sun, 22 Apr 2018 18:37:11 +0000 (18:37 +0000)]
Bug 19972: (QA follow-up) Fix id name

Renames #type-filter to #itemtype-filter

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 19972: Make holds to pull list honors item-level_itypes syspref
Victor Grousset [Tue, 16 Jan 2018 09:06:20 +0000 (10:06 +0100)]
Bug 19972: Make holds to pull list honors item-level_itypes syspref

And reflect that in the UI strings + variable names

Test plan:
1. Set syspref "item-level_itypes" to "specific item"
2. Create a hold on a record with one item
3. Change the document type of the item
4. Check that the item edition page and the record page show 2 different
     types.
5. Go to /cgi-bin/koha/circ/pendingreserves.pl
6. Check that the displayed type is the item one
7. Set syspref "item-level_itypes" to "biblio record"
8. Go to /cgi-bin/koha/circ/pendingreserves.pl
9. See that the displayed type is the item one. When the sysopref says
     "record"
     This is the bug.
10. Apply this patch
11. Go to /cgi-bin/koha/circ/pendingreserves.pl
12. See that the displayed type now follows the syspref
13. Set syspref "item-level_itypes" to "specific item"
14. Go to /cgi-bin/koha/circ/pendingreserves.pl
15. See that the displayed type still follows the syspref

Signed-off-by: Lucie Gay <lucie.gay@ens-paris-saclay.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 20666: Correct permissions on opac-routing-lists.pl
Mark Tompsett [Thu, 26 Apr 2018 16:57:47 +0000 (16:57 +0000)]
Bug 20666: Correct permissions on opac-routing-lists.pl

You will need to have the 'Your routing lists' appear
in the opac-user page in order to trigger the error.

Make sure plack is off, and you will an error 500 page.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 20666: Correct executable permissions
Mark Tompsett [Thu, 26 Apr 2018 16:22:16 +0000 (16:22 +0000)]
Bug 20666: Correct executable permissions

TEST PLAN
---------
On a kohadevbox:
 1) sudo koha-plack --enable kohadev
 2) restart_all
 3) Enter fines for a patron in the staff client
 4) Go to the 'Fines' tab (left pane)
 5) Go to the 'Account' tab (below the row of buttons)
 6) Click 'Details'
    -- no issues
 7) sudo koha-plack --disable kohadev
 8) restart_all
 9) refresh page
    -- Error 500
10) apply patch
11) restart_all
12) refresh page
    -- no issues
13) sudo koha-plack --enable kohadev
14) restart_all
15) refresh page
    -- no issues

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 20637: Fix filters content on the holds to pull screen
Jonathan Druart [Tue, 24 Apr 2018 18:21:36 +0000 (15:21 -0300)]
Bug 20637: Fix filters content on the holds to pull screen

libraries and locations are separated by <br> whereas itypes are using
\n
This patch standardized the separator to generate correctly the filters
pulldown

Test plan:
- Place a hold on a biblio record which has several items
- Define different locations and itypes for these items
- Display the holds on the "Holds to pull" screen and make sure the
filters are working correctly (focus on the dropdown list)

Signed-off-by: Victor Grousset <victor.grousset@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 20329: Text input fields are wider than the fieldset class they are inside of
Owen Leonard [Wed, 25 Apr 2018 12:38:25 +0000 (12:38 +0000)]
Bug 20329: Text input fields are wider than the fieldset class they are inside of

This alternate patch defines a width of 100% for text inputs and selects
inside sidebar fieldsets. The scope of this style is limited to the
sidebar by unsetting the width for fieldsets within "#yui-main," the
main body of the page.

This patch also removes inline styles from two templates which are now
unnecessary.

To test, apply the patch and clear your cache if necessary.

View various pages which have a sidebar search form: acqui/invoices.pl,
members/members-home.pl, circ/overdue.pl, acqui/parcel.pl. Confirm that
form fields in the sidebar look correct.

Confirm that other forms styled with the "brief" class aren't
unintentionally affected by this patch. For example:
circ/request-article.pl, members/member-password.pl,
reports/reports-home.pl, reserve/request.pl

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 20329: Shorten the width of text input fields
Alex Buckley [Sun, 4 Mar 2018 05:31:15 +0000 (05:31 +0000)]
Bug 20329: Shorten the width of text input fields

This makes the text input fields fit tidily within the border of the
fieldset class elements they are within.

Test plan:
1. Go to the acqui/invoices.pl, members/members-home.pl,
circ/overdue.pl, acqui/parcel.pl and notice that the text input fields
on the fieldset element on the left hand side of the screen for
filtering search results are too wide and go over the border of the
fieldset element

2. Apply patch

3. Refresh the aforementioned pages and notice the text inputs have a
shortened width and now fit within the fielset class element

Sponsored-By: Catalyst IT
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 20546: Display shelving location on checkin
Magnus Enger [Mon, 9 Apr 2018 10:39:23 +0000 (12:39 +0200)]
Bug 20546: Display shelving location on checkin

Currently, the sehlving location is not being displayed in the table
of checked in items on <intranet>/cgi-bin/koha/circ/returns.pl

To test:
- Make sure you have a couple of books with a value for shelving location (952$c)
- Check the books out
- Check the books in
- Verify nothing is displayed in the "Shelving location" column
- Apply this patch
- Check the books out and in again
- Verify the shelving location is now being displayed

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 20304: (QA follow-up) Remove unwanted 'my'
Julian Maurice [Thu, 26 Apr 2018 11:48:58 +0000 (13:48 +0200)]
Bug 20304: (QA follow-up) Remove unwanted 'my'

'my' creates a new '$value' variable, and prevented the '$value' in
outer scope to be modified

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 20304: Remove warnings from cataloguing scripts
Jonathan Druart [Tue, 27 Feb 2018 16:36:21 +0000 (13:36 -0300)]
Bug 20304: Remove warnings from cataloguing scripts

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 18342: Mark Cache::Memcached as mandatory
Jonathan Druart [Fri, 23 Mar 2018 18:03:52 +0000 (15:03 -0300)]
Bug 18342: Mark Cache::Memcached as mandatory

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 18342: Enable memcached by default for new installs
Jonathan Druart [Wed, 27 Sep 2017 19:19:07 +0000 (16:19 -0300)]
Bug 18342: Enable memcached by default for new installs

Note that there is no way to create an install without memcached.
As it is now considered as stable, there is no point to not use it.

Test plan:
Create a new Koha install and make sure memcached is enabled by default

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 20665: Reset MySQL connection time zone in the OAI-PMH Provider
Ere Maijala [Thu, 26 Apr 2018 13:08:25 +0000 (13:08 +0000)]
Bug 20665: Reset MySQL connection time zone in the OAI-PMH Provider

TEST PLAN
---------
apply unit test patch
prove t/db_dependent/OAI/Server.t
-- should fail
apply this patch
prove t/db_dependent/OAI/Server.t
-- should pass
run koha qa test tools

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 20665: Units tests for testing MySQL connection time zone
Ere Maijala [Thu, 26 Apr 2018 13:05:51 +0000 (13:05 +0000)]
Bug 20665: Units tests for testing MySQL connection time zone

TEST PLAN
---------
apply this test patch
prove t/db_dependent/OAI/Server.t
-- should fail
apply the other patch
prove t/db_dependent/OAI/Server.t
-- should pass
run koha qa test tools

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
22 months agoBug 19466: Turn AutoCalc off for new installs
David Bourgault [Tue, 1 May 2018 19:09:53 +0000 (15:09 -0400)]
Bug 19466: Turn AutoCalc off for new installs

Default value of AutoMemberNum is now 0.

TEST PLAN:
0. Do a fresh install of Koha
1. In system preferences AutoMemberNum should be off
2. No warning should be shown next to the cardnumber field in the patron creation form.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20531: Set the timestamps to the same value to get a correct order
Jonathan Druart [Wed, 25 Apr 2018 20:38:38 +0000 (17:38 -0300)]
Bug 20531: Set the timestamps to the same value to get a correct order

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20659: Fix blocking errors display
Jonathan Druart [Wed, 25 Apr 2018 19:52:07 +0000 (16:52 -0300)]
Bug 20659: Fix blocking errors display

The include file blocking-errors.inc has been created to by-pass regular
processing and display an error that should block the elements of the
view.

For instance you call a patron's page with invalid borrowernumber => we
do not want the app to crash (500) or the page to display with broken
elements.

It worked well on bug 18403 but it's now broken, a blank page is
displayed instead.
It may be caused by the move of the JS to the bottom of the page.

Test plan:
hit /cgi-bin/koha/members/moremember.pl?borrowernumber=45432
Without this patch a blank page is displayed.
With this patch you see the blocking error

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20531: Add diag to help debug next failure
Jonathan Druart [Wed, 25 Apr 2018 15:17:19 +0000 (12:17 -0300)]
Bug 20531: Add diag to help debug next failure

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19204: Add tests for new days_mode parameter
Jonathan Druart [Mon, 23 Apr 2018 13:37:48 +0000 (10:37 -0300)]
Bug 19204: Add tests for new days_mode parameter

Sponsored-by: Goethe-Institut
Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19204: Add a test: holiday is expiration date
Jonathan Druart [Mon, 23 Apr 2018 21:52:00 +0000 (18:52 -0300)]
Bug 19204: Add a test: holiday is expiration date

Sponsored-by: Goethe-Institut
Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19204: Clean the tests a bit to reuse the same pattern
Jonathan Druart [Mon, 23 Apr 2018 21:12:00 +0000 (18:12 -0300)]
Bug 19204: Clean the tests a bit to reuse the same pattern

The same pattern is used several times in test:
checkout, checkin, get the debarment, compare the dates and remove the
debarment.
Let's move that to a separate subroutine

Sponsored-by: Goethe-Institut
Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19204: Make the debarment date calculation depends on finesCalendar
Jonathan Druart [Mon, 23 Apr 2018 18:23:00 +0000 (15:23 -0300)]
Bug 19204: Make the debarment date calculation depends on finesCalendar

This patchs adds the ability to calculate the end of the suspension date
(debarment date) using the finesCalendar syspref.
Prior to this patch it was never calculating without taking into account
the calendar.

calculated without taking holidays into account.
This was a problem because the restriction could end in the middle of a
period the library is closed.

Test plan:
- Set finescalendar to 'not including days the library is closed'
- Set a circulation condition with no fine/maxfine, but fine days and
max fine days instead
- Check out an item with a due date in the past
- Check the item in and verify the restriction date
- Clean the restriction

- Add holidays to your calendar on the calculated restriction date
- Check the item out again with the same due date in the past
- Check in the item again
- Verify the calculated restriction end date has changed, it's set to the day
after the holiday.

Fines in days restriction calculation is correctly taking calendar
into account.

Sponsored-by: Goethe-Institut
Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20100: DBRev 17.12.00.040
Jonathan Druart [Wed, 25 Apr 2018 13:37:08 +0000 (10:37 -0300)]
Bug 20100: DBRev 17.12.00.040

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20100: Set ProtectSuperlibrarianPrivileges by default
Jonathan Druart [Wed, 25 Apr 2018 13:46:11 +0000 (10:46 -0300)]
Bug 20100: Set ProtectSuperlibrarianPrivileges by default

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20100: Explain why the checkbox is disabled
Jonathan Druart [Wed, 25 Apr 2018 13:34:59 +0000 (10:34 -0300)]
Bug 20100: Explain why the checkbox is disabled

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20100: (QA follow-up) Pref description and improve code in member-flags
Marcel de Rooy [Wed, 25 Apr 2018 11:33:05 +0000 (13:33 +0200)]
Bug 20100: (QA follow-up) Pref description and improve code in member-flags

Two points as mentioned on Bugzilla comment29.
[1] Improve pref description. Feedback from comment30 incorporated.
[2] Improve code in member-flags. Check if we change librarian flag first.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested the die with "disable_superlibrarian_privs => 0" in member-flags.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20100: (QA follow-up) Change syspref name to full version
Marcel de Rooy [Wed, 25 Apr 2018 11:09:05 +0000 (13:09 +0200)]
Bug 20100: (QA follow-up) Change syspref name to full version

As per RM request, changing the shorter name to its full form.
Result of a git grep | sed.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
No occurrences to be found anymore with git grep -i.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20100: (QA follow-up) Use template logic instead of js to disable superlib box
Nick Clemens [Fri, 20 Apr 2018 11:52:17 +0000 (11:52 +0000)]
Bug 20100: (QA follow-up) Use template logic instead of js to disable superlib box

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20100: Disallow access to superlibrarian privileges at client side
Marcel de Rooy [Wed, 31 Jan 2018 15:47:23 +0000 (16:47 +0100)]
Bug 20100: Disallow access to superlibrarian privileges at client side

This last patch activates the check at client side.
If the pref ProtectSuperlibPrivs is enabled, non-superlibs should not be
able to change superlibrarian privileges via the interface.

Test plan:
[1] Enable the pref.
[2] Login as superlib and add/remove superlib privs to a staff user.
[3] Login as another user (no superlib, but having borrowers, permissions
    and staff_access). Verify that you cannot add or remove superlib
    privs.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: JM Broust <jean-manuel.broust@univ-lyon2.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20100: Disallow access to superlib privileges at server side
Marcel de Rooy [Wed, 31 Jan 2018 14:02:36 +0000 (15:02 +0100)]
Bug 20100: Disallow access to superlib privileges at server side

Depends on pref ProtectSuperlibPrivs.
If enabled, script member-flags.pl will not allow you to add or remove
superlib privs when you are no superlibrarian.
The follow-up patch will enable the check at client side.

Test plan:
[1] Enable the pref. Do not apply the third patch (client side).
[2] Login as superlib and add/remove superlib privs to a staff user.
[3] Login as another user (no superlib, but having borrowers, permissions
    and staff_access). Verify that you have an internal server error when
    you add or remove superlib privs. The log contains a warning.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: JM Broust <jean-manuel.broust@univ-lyon2.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20100: Introduce preference ProtectSuperlibPrivs
Marcel de Rooy [Wed, 31 Jan 2018 15:23:18 +0000 (16:23 +0100)]
Bug 20100: Introduce preference ProtectSuperlibPrivs

This pref allows you to block changes to superlibrarian privileges at
client and server side for non-superlibrarians.
This patch only contains the db rev and the preference description.

Test plan:
Run dbrev or new install. Check pref value.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: JM Broust <jean-manuel.broust@univ-lyon2.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20538: Prevent warnings in xt/author/valid-templates.t
Julian Maurice [Wed, 25 Apr 2018 07:21:30 +0000 (09:21 +0200)]
Bug 20538: Prevent warnings in xt/author/valid-templates.t

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 2696: (QA follow-up) Add more test, move to subtest
Kyle M Hall [Tue, 24 Apr 2018 16:43:25 +0000 (16:43 +0000)]
Bug 2696: (QA follow-up) Add more test, move to subtest

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 2696: (QA follow-up) Fix POD, results sorting, permissions
Kyle M Hall [Mon, 23 Apr 2018 18:23:00 +0000 (14:23 -0400)]
Bug 2696: (QA follow-up) Fix POD, results sorting, permissions

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 2696: (QA follow-up) Several fixes to template variables
Katrin Fischer [Sat, 21 Apr 2018 00:40:15 +0000 (00:40 +0000)]
Bug 2696: (QA follow-up) Several fixes to template variables

- Fix link to patron account in breadcrumbs
- Fix includes for accounttype.inc to display type correctly
  - in Details for fee
  - in Payments list
- Fix use CGI qw ( -utf8 );
- Remove <br> from within a string for better translation

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 2696: Fine payments should show what was paid for
Kyle M Hall [Thu, 21 Dec 2017 14:15:52 +0000 (14:15 +0000)]
Bug 2696: Fine payments should show what was paid for

Test Plan:
1) Apply this patch and its' dependencies
2) Create and pay some various fees and fines
3) View the payments for fees, and fees paid by payments by
   using the new 'Details' button available on boraccount.pl

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Running updatedatabase.pl after patch application makes dependencies
happy. Passes QA Tools and works as intended.

Rebased (2017-12-21): Alex Arnaud <alex.arnaud@biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Bug 2696: (QA follow-up) - Remove use of GetMember

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 7910: Add the ability to renew several subscriptions at once
Jonathan Druart [Wed, 18 Apr 2018 17:01:18 +0000 (14:01 -0300)]
Bug 7910: Add the ability to renew several subscriptions at once

This patch adds a "Renew all selected subscriptions" action link on top
of the table of the "Check expiration" page.

It will allow to auto-renew several subscriptions.

Test plan:
Make sure this new link renew the selected subscriptions as expected.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20614: Use GET instead of POST for subscription renewing
Jonathan Druart [Wed, 18 Apr 2018 17:56:13 +0000 (14:56 -0300)]
Bug 20614: Use GET instead of POST for subscription renewing

It will prevent Firefox (and certainly other browsers) to block the form
resubmit:

"To display this page, Firefox must send information that will repeat
any action (such as a search or order confirmation) that was performed
earlier."

Test plan:
Renew a subscription and save

=> You should not longer see the browser warning

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20482: DBRev 17.12.00.039
Jonathan Druart [Tue, 24 Apr 2018 15:04:29 +0000 (12:04 -0300)]
Bug 20482: DBRev 17.12.00.039

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20482: (QA follow-up) Correct code in atomic update
Nick Clemens [Fri, 20 Apr 2018 17:36:15 +0000 (17:36 +0000)]
Bug 20482: (QA follow-up) Correct code in atomic update

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20482: Correct Terminology codes to Bibliographic ones
Mark Tompsett [Wed, 28 Mar 2018 02:47:18 +0000 (02:47 +0000)]
Bug 20482: Correct Terminology codes to Bibliographic ones

"RELATIONSHIP TO ISO 639-2
ISO 639-2 (Codes for the representation of names of
languages-- Part 2: alpha-3 code) was based on the MARC
Code List for Languages and published in 1998. In the 22
cases where the ISO 639-2 list has two alternative codes,
the bibliographic code is the same as the MARC code."
(http://www.loc.gov/marc/languages/introduction.pdf)

This leads me to believe that eus, mri, and sqi are
incorrect. The slk code was corrected on an earlier bug.

TEST PLAN
----------
Apply patch
Do a database upgrade
-- Are eus, mri, and sqi fixed?
reset_all
-- Are eus, mri, and sqi never there in the first place?
koha qa test tools only check perl code.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20245: DBRev 17.12.00.038
Jonathan Druart [Tue, 24 Apr 2018 15:00:36 +0000 (12:00 -0300)]
Bug 20245: DBRev 17.12.00.038

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20245: Wrong language code for Slovak
Radek Šiman [Thu, 8 Mar 2018 21:28:37 +0000 (22:28 +0100)]
Bug 20245: Wrong language code for Slovak

This patch updates iso639_2_code value for Slovak language

Test plan:
1) Obtain a biblio record having 'slo' value in its language
   code (marc field 041a)
2) Try to find it through Advanced search + more options
   with language set to Slovak
3) Nothing is found
4) Apply this patch
5) Repeat steps 1 and 2
6) Record is found now

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20616: (QA follow-up) Make alert translatable
Katrin Fischer [Mon, 23 Apr 2018 04:15:56 +0000 (04:15 +0000)]
Bug 20616: (QA follow-up) Make alert translatable

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20616: Prevent "edit serials" form submission if no serial is selected
Jonathan Druart [Mon, 23 Apr 2018 19:19:50 +0000 (16:19 -0300)]
Bug 20616: Prevent "edit serials" form submission if no serial is selected

In order to prevent the form to submit and gives an ugly error if no
issues are selected we will make sure at least one is checked otherwise
an alert will be displayed.

Test plan:
- create a subscrpition
- go to the serials collection page
- don't check any checkboxes for serials
- click 'Edit serials'

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20625: Handle non existing of active currency
Jonathan Druart [Mon, 23 Apr 2018 15:07:58 +0000 (12:07 -0300)]
Bug 20625: Handle non existing of active currency

This patch avoid the explosion in the air when creating a new patron
category and no active currency is defined.

Test plan:
Remove the currencies, create a new patron category
Without this patch applied you will get
  Can't call method "p_sep_by_space" on an undefined value

With this patch the form will be displayed correctly and you will be
able to create the patron category

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20625: Add tests
Jonathan Druart [Mon, 23 Apr 2018 15:03:48 +0000 (12:03 -0300)]
Bug 20625: Add tests

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20073: Remove perlcritic error
Jonathan Druart [Mon, 23 Apr 2018 18:12:20 +0000 (15:12 -0300)]
Bug 20073: Remove perlcritic error

"return" statement with explicit "undef" at line 245, column 5.  See
page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20617: Add 'Search Engine configuration' link to administration menu
Owen Leonard [Fri, 20 Apr 2018 18:35:14 +0000 (18:35 +0000)]
Bug 20617: Add 'Search Engine configuration' link to administration menu

This patch adds a link to the Elasticsearch configuration page in the
administration sidebar menu when Elasticsearch is enabled.

This patch also corrects the title of the Elasticsearch page to match
the page heading. "Search engine configuration" instead of
"Elasticsearch mappings."

To test, apply the patch and set the SearchEngine system preference to
"Elasticsearch."

  - View any page in the administration module which shows the
    left-hand sidebar menu. The link to search engine configuration
    should be there.
  - View the search engine configuration page and confirm that the page
    title is correct.
  - Set the SearchEngine system preferenc to "Zebra."
  - The search engine configuration link should no longer appear in the
    administration sidebar menu.

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20363: (bug 16966 follow-up) better messages handling
Jonathan Druart [Fri, 23 Mar 2018 16:58:24 +0000 (13:58 -0300)]
Bug 20363: (bug 16966 follow-up) better messages handling

User views the "Your privacy" -page, it shows "No reading history to
delete", even when the user has history.

Test plan:
- Turn OPACPrivacy on
- Go to opac-privacy.pl
- Click the "Immediate deletion button" to delete the reading history
=> If the patron has reading history you must get "Your reading history has been deleted."
Otherwise "No reading history to delete"

Note that this patch reintroduce the "something went wrong" message if
the deletion failed for whatever reason.

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 13445: Remove URL option from scheduled reports, add Text option
phette23 [Fri, 6 Apr 2018 21:15:26 +0000 (14:15 -0700)]
Bug 13445: Remove URL option from scheduled reports, add Text option

Remove the non-functional 'URL' format
Offer the (functional) CSV & HTML formats

testing plan:
- visit the task scheduler tool at cgi-bin/koha/tools/scheduler.pl
- 'Output format' select list should offer Text (TSV), CSV, & HTML
- scheduled reports for each of the above types should run & send emails correctly

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Maksim Sen <maksim.sen@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20073: DBRev 17.12.00.037
Jonathan Druart [Mon, 23 Apr 2018 17:21:43 +0000 (14:21 -0300)]
Bug 20073: DBRev 17.12.00.037

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20073: Move Elasticsearch configs to yaml files and improve the default settings.
Ere Maijala [Tue, 23 Jan 2018 13:21:31 +0000 (15:21 +0200)]
Bug 20073: Move Elasticsearch configs to yaml files and improve the default settings.

Improvements:
1) Index settings moved from code to etc/searchengine/elasticsearch/index_config.yaml. An alternative can be specified in koha-conf.xml.
2) Field settings moved from code to etc/searchengine/elasticsearch/field_config.yaml. An alternative can be specified in koha-conf.xml.
3) mappings.yaml has been moved from admin/searchengine/elasticsearch to etc/searchengine/elasticsearch. An alternative can be specified in koha-conf.xml.
4) Default settings have been improved to remove punctuation from phrases used for sorting etc.
5) State variables are used for storing configuration to avoid parsing it multiple times.
6) A possibility to reset the fields too has been added to the reset operation of mappings administration.
7) mappings.yaml has been moved from admin/searchengine/elasticsearch to etc/searchengine/elasticsearch.
8) An stdno field type has been added for standard identifiers.

To test:
1) Run tests in t/Koha/SearchEngine/Elasticsearch.t
2) Clear tables search_fields and search_marc_map
3) Go to admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1
4) Verify that admin/searchengine/elasticsearch/mappings.pl displays the mappings properly, including ISBN and other standard number fields.
5) Index some records using the -d parameter with misc/search_tools/rebuild_elastic_search.pl to recreate the index
6) Verify that you can find the records
7) Put <elasticsearch_index_mappings>non_existent</elasticsearch_index_mappings> to koha-conf.xml
8) Verify that admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 fails because it can't find non_existent.
9) Copy etc/searchengine/elasticsearch/mappings.yaml to a new location and make elasticsearch_index_mappings setting in koha-conf.xml point to it.
10) Make a change in the new mappings.yaml.
11) Clear table search_fields (mappings reset doesn't do it yet, see bug 20248)
12) Go to admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1
13) Verify that the changes you made are now visible in the mappings UI

Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19855: Use patron-title to display patron's info
Jonathan Druart [Mon, 23 Apr 2018 16:07:48 +0000 (13:07 -0300)]
Bug 19855: Use patron-title to display patron's info

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19855: Move getalert, addalert and delalert to Koha::Subscription
Jonathan Druart [Wed, 20 Dec 2017 20:01:08 +0000 (17:01 -0300)]
Bug 19855: Move getalert, addalert and delalert to Koha::Subscription

This patch removes 3 subroutines from C4::Letters:
- getalert
- addalert
- delalert

And add 3 methods to Koha::Subscription:
- subscribers
- add_subscriber
- remove_subscriber

It makes the code cleaner for future cleanup.
TODO - we should remove alert.alertid and alert.type, and rename
alert.externalid with alert.subscriptionid
That way alert will be renamed borrowers_subscriptions (or similar) and
will become a simple join table between borrowers and subscriptions.
We will need to deal with FK that could not be satisfied.
Let's do that after this patch is pushed.

Test plan:
Subscribe and unsubscribe to email notifications sent when a new issues
is available.
Make sure everything works as before and you receive the emails.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19855: Remove $type from the alerts
Jonathan Druart [Wed, 20 Dec 2017 17:26:39 +0000 (14:26 -0300)]
Bug 19855: Remove $type from the alerts

It looks like this feature has never been finished. It has been
developed with more flexibility in mind, but only 'issue' is used for
this parameter. Apparently it could have been 'virtual', for virtual shelves.

Let remove this parameter and clean the code a bit.
TODO: Remove the DB column

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19855: Remove C4::Letters::findrelatedto
Jonathan Druart [Wed, 20 Dec 2017 17:14:57 +0000 (14:14 -0300)]
Bug 19855: Remove C4::Letters::findrelatedto

This subroutine is called only once. It only concat firstname and
surname for subscribers.
It can be easily replaced with Koha::Patron

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19855: Remove getalert from opac-user.pl
Jonathan Druart [Wed, 20 Dec 2017 17:12:01 +0000 (14:12 -0300)]
Bug 19855: Remove getalert from opac-user.pl

This is not used later and seems unused since:
commit e61173aa8eb23c111a707eba2cfbd2003df709bf
Date:   Sun May 21 02:29:09 2006 +0000
    syncing dev-week and HEAD

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19855: Remove getalert from moremember.pl
Jonathan Druart [Wed, 20 Dec 2017 17:10:44 +0000 (14:10 -0300)]
Bug 19855: Remove getalert from moremember.pl

This is not used later and seems unused since:
commit b38997925f603dc9784c25d3db3501644c19e068
Date:   Wed Oct 26 09:11:02 2005 +0000
    big commit, still breaking things...

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 18426: Replace 'Modify' with 'Edit'
Jonathan Druart [Thu, 19 Apr 2018 10:27:07 +0000 (07:27 -0300)]
Bug 18426: Replace 'Modify' with 'Edit'

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 18426: Make sure the logged in user can edit the subscriptions
Jonathan Druart [Thu, 19 Apr 2018 10:25:29 +0000 (07:25 -0300)]
Bug 18426: Make sure the logged in user can edit the subscriptions

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 18426: Address QA issues
Jonathan Druart [Tue, 17 Apr 2018 21:14:22 +0000 (18:14 -0300)]
Bug 18426: Address QA issues

- Replaced with the "action" links we already have on the biblio detail
page and the items lost report.
- Display all the editable values in the table
- Add a 'Cancel' link

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 18426: Fix datepicker
Jonathan Druart [Tue, 17 Apr 2018 19:24:43 +0000 (16:24 -0300)]
Bug 18426: Fix datepicker

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 18426: Allow to edit subscriptions in batch
Julian Maurice [Tue, 11 Apr 2017 16:07:47 +0000 (18:07 +0200)]
Bug 18426: Allow to edit subscriptions in batch

This adds a checkbox column in serials-search.pl tables that allow to edit
selected subscriptions.
The following fields can be modified:
 - Bookseller
 - Location
 - Library
 - Item type
 - Public note
 - Nonpublic note
 - "Create item when receiving" flag
 - Expiration date
+ the additional fields defined in serials/add_fields.pl

Test plan:

1. Go to Serials module
2. If there is no additional fields defined, define some (at least one with an
   authorized value and one without)
3. Start a subscription search
4. Select some results using the checkboxes and click the "Edit" button above
   the table
5. Select values for some fields (not all) and click "Start batch edit"
6. Verify you are being redirected to the previous search results
7. Verify that the fields for which you selected a value were modified and that
   the others fields weren't
8. Repeat steps 4 to 7 but this time, modify the other fields.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 18426: Refactor subscriptions tables code in a BLOCK
Julian Maurice [Tue, 11 Apr 2017 09:26:36 +0000 (11:26 +0200)]
Bug 18426: Refactor subscriptions tables code in a BLOCK

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20622: Add some color to bootstrap modal headers and footers
Owen Leonard [Fri, 20 Apr 2018 10:07:19 +0000 (06:07 -0400)]
Bug 20622: Add some color to bootstrap modal headers and footers

Right now the bootstrap modal header, body and footer are all white. It would be nice to give them a bit of color.

Test Plan:
1) Apply this patch
2) Find a patron, click the 'add message' button
3) Note the modal header and footer now have a background color

Signed-off-by: Kyle M Hall <kyle@bywatetsolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19287: DBRev 17.12.00.036
Jonathan Druart [Mon, 23 Apr 2018 17:20:14 +0000 (14:20 -0300)]
Bug 19287: DBRev 17.12.00.036

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19287: (QA follow-up) Fix preference description
Katrin Fischer [Sun, 22 Apr 2018 16:05:03 +0000 (16:05 +0000)]
Bug 19287: (QA follow-up) Fix preference description

The last part of the preference description didn't show.
Moved behind the other text and rephrased.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19287: Shorten button text
Jonathan Druart [Mon, 9 Apr 2018 18:09:34 +0000 (15:09 -0300)]
Bug 19287: Shorten button text

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19287: Do not display buttons for biblio level holds
Jonathan Druart [Mon, 9 Apr 2018 18:08:42 +0000 (15:08 -0300)]
Bug 19287: Do not display buttons for biblio level holds

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19287: Update UpdateItemWhenLostFromHoldList description
Jonathan Druart [Mon, 9 Apr 2018 18:08:18 +0000 (15:08 -0300)]
Bug 19287: Update UpdateItemWhenLostFromHoldList description

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19287: Add column action to columns settings
Jonathan Druart [Mon, 9 Apr 2018 16:16:30 +0000 (13:16 -0300)]
Bug 19287: Add column action to columns settings

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19287: Add CANCEL_HOLD_ON_LOST to installer files for all languages
Jonathan Druart [Mon, 9 Apr 2018 16:09:21 +0000 (13:09 -0300)]
Bug 19287: Add CANCEL_HOLD_ON_LOST to installer files for all languages

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19287: Use the notice defined for the homebranch of the patron
Jonathan Druart [Mon, 9 Apr 2018 16:03:47 +0000 (13:03 -0300)]
Bug 19287: Use the notice defined for the homebranch of the patron

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19287: Fix conflict with bug 19974
Jonathan Druart [Mon, 9 Apr 2018 15:59:26 +0000 (12:59 -0300)]
Bug 19287: Fix conflict with bug 19974

Note that these patches should be pushed along with bug 19984 to avoid
regressions (if the syspref is changed between the 2 update DB entries)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19287: Fix conflict with bug 19304
Jonathan Druart [Fri, 19 Jan 2018 16:41:20 +0000 (13:41 -0300)]
Bug 19287: Fix conflict with bug 19304

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19287: Add ability to mark an item 'Lost' from 'Holds to pull' list
Jonathan Druart [Tue, 12 Dec 2017 17:14:56 +0000 (14:14 -0300)]
Bug 19287: Add ability to mark an item 'Lost' from 'Holds to pull' list

The goal to this enhancement is to add the ability to cancel a hold and
mark items as lost from the 'Holds to pull' page.
A new pref is added to control the behaviour, default is off

To mark items as lost you need to set the new pref CanMarkHoldsToPullAsLost to one of these two values:
- "Allow to mark items as lost"
=> The item will be marked as lost and the hold will be cancelled
- "Allow to mark items as lost and notify the patron"
=> Same as previously but the patron will be notified as well.

The notification is done using a new notice template (code=CANCEL_HOLD_ON_LOST).
Feel free to suggest another default wording.

To update the values of the items when one of these 2 buttons are used, you need to
fill the UpdateItemWhenLostFromHoldList with something like: 'itemlost: 1'

Test plan:
1/ Place holds on some items
2/ Go to Home > Circulation > Holds to pull
From here you can cancel the hold or
3/ Mark the items as lost
=> You will receive feedback messages depending on different situations:
* The CANCEL_HOLD_ON_LOST does not exist
* The patron does not have an email address (but the notice has been
enqueued! It is the current behaviour with other notices)
* The notice has been enqueued
* The hold has been cancelled

QA Notes:
From which library do we want to pick the notice? This patch use
reserves.branchcode

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 19479: Display price in basket group formatted according to CurrencyFormat syspre...
Jon Knight [Wed, 28 Mar 2018 16:29:43 +0000 (16:29 +0000)]
Bug 19479: Display price in basket group formatted according to CurrencyFormat syspref using templates.

On the page acqui/basketgroup.pl the prices of baskets should be shown
formatted according to the selected CurrencyFormat syspref, with no
currency symbol or code.

Test plan:

1) Create a basket with items in it worth more than 1000 currency units.
2) Close the basket.
3) Go to acqui/basketgroup.pl page and check that the price format matches
   the current CurrencyFormat syspref.
4) Go to Administration and change CurrencyFormat syspref to one of the
   other available options and recheck step 3.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Fixed some tabs.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20400: Fix get_routing_lists tests
Jonathan Druart [Fri, 20 Apr 2018 22:00:35 +0000 (19:00 -0300)]
Bug 20400: Fix get_routing_lists tests

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20400: (follow-up) Several fixes from RM review
Katrin Fischer [Fri, 20 Apr 2018 20:25:08 +0000 (22:25 +0200)]
Bug 20400: (follow-up) Several fixes from RM review

- "your routing lists" tab is now highlighted when active
- get_routinglists was renamed to get_routing_lists
- Koha::Patron->get_routing_lists returns the ->search result
  directly
- Koha::Subscription::RoutingList->subscription uses DBIC
  relationship
- Undo changes to C4/Auth.pm

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20400: Fix number of tests
Jonathan Druart [Fri, 20 Apr 2018 17:06:33 +0000 (14:06 -0300)]
Bug 20400: Fix number of tests

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 20400: Add routing list tab in OPAC
Katrin Fischer [Thu, 15 Mar 2018 08:40:12 +0000 (08:40 +0000)]
Bug 20400: Add routing list tab in OPAC

This patch adds the base for the new feature:
Show a list of the serial titles a patron is on routing
lists for in the OPAC.

Test plan applies to the complete patch set:

To test:
- Apply all patches
- Make sure RoutingSerials is not activated
- Check patron account in OPAC - no tab should appear
- Activate RoutingSerials
- Create subscriptions and different routing lists, test with:
  - Patron with no routing list entries = no tab
  - Patron with one or more routing list entries = tab appears

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Bug 20400: Rewrite using Koha::Objects

Adds
- Koha::Subscription::Routinglist
- Koha::Subscription::Routinglists

Adds 2 methods
- Koha::Patron::get_routinglists
- Koha::Routinglist::subscription

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Bug 20400: Add unit tests

prove t/db_dependent/Koha/Subscription/Routinglists.t
prove t/db_dependent/Koha/Patrons.t

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Bug 20400: Display new tab in OPAC only for patrons with routing lists

The visibility of the routing list tab in the OPAC depends
on the system preference RoutingSerials and the existence
of routing list entries for the patron.

Some libraries only offer routing lists to certain user groups and
would not want it generally visible. As there are currently no
actions you can perform from the list, this appears to be a
reasonable behaviour.

See test plan in first patch.

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Bug 20400: (follow-up) Use Asset TT plugin on opac-routing-lists.tt

Patch applies and functions as described.
Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Bug 20400: (QA follow-up) Redirect to 404 if routing is disabled

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 9302: Add error message if keeper patron is invalid
Kyle M Hall [Fri, 20 Apr 2018 15:47:51 +0000 (15:47 +0000)]
Bug 9302: Add error message if keeper patron is invalid

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 9302: Add error messages, correct number of unit tests in subtest 'Test Koha...
Kyle M Hall [Thu, 19 Apr 2018 19:02:31 +0000 (15:02 -0400)]
Bug 9302: Add error messages, correct number of unit tests in subtest 'Test Koha::Patrons::merge'

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 9302: Update div classes
Kyle M Hall [Wed, 18 Apr 2018 15:24:42 +0000 (11:24 -0400)]
Bug 9302: Update div classes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
23 months agoBug 9302: Wrap display_names block line with a span tag
Kyle M Hall [Wed, 18 Apr 2018 15:20:33 +0000 (11:20 -0400)]
Bug 9302: Wrap display_names block line with a span tag

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>