koha.git
8 years agoMerge branch 'new/enh/bug_4877'
Paul Poulain [Thu, 24 Nov 2011 09:48:14 +0000 (10:48 +0100)]
Merge branch 'new/enh/bug_4877'

8 years agoBug 4877 - Add DocBook for missing manual pages
Magnus Enger [Mon, 17 Oct 2011 10:23:09 +0000 (12:23 +0200)]
Bug 4877 - Add DocBook for missing manual pages

Add DocBook manual pages for commands that do not have a manual page yet. Also
add a page for koha-common itself, listing all the available commands.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Minor change: I fixed a typo I spotted

8 years agoBug 7242 : Fixing typo in a div
Chris Cormack [Thu, 17 Nov 2011 23:12:29 +0000 (12:12 +1300)]
Bug 7242 : Fixing typo in a div

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6799 rebuild_zebra.pl -x produces invalid XML records
Frédéric Demians [Sat, 27 Aug 2011 11:32:08 +0000 (13:32 +0200)]
Bug 6799 rebuild_zebra.pl -x produces invalid XML records

This patch allow to handle properly items containing extended characters and
send valid XML records to zebraidx

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoJoy nelson was already in history.txt, removing the entry
Paul Poulain [Fri, 18 Nov 2011 22:28:38 +0000 (23:28 +0100)]
Joy nelson was already in history.txt, removing the entry

8 years agoIncremental fix for Bug 2847, Use HTML escape in templates where appropriate
Owen Leonard [Fri, 11 Nov 2011 17:34:44 +0000 (12:34 -0500)]
Incremental fix for Bug 2847, Use HTML escape in templates where appropriate

Fixes for output in a couple of acquisitions templates where
user-generated data should be escaped. This instances were found
by creating a vendor name like "Baker & Taylor" and finding
that the ampersand was not escaped, causing validation errors.

This patch also consolidates multiple <script> blocks which
do not need to be separate and corrects a couple of unclosed
<input> tags.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7134: patron records getting corrupted birthdates
Ian Walls [Thu, 17 Nov 2011 15:27:47 +0000 (10:27 -0500)]
Bug 7134: patron records getting corrupted birthdates

If no date of birth is provided in a new member form, the borrower gets the birthdate of "00/02/0", which
is obviously incorrect (the result of passing 0 to the database directly)

The fix is to remove a conditional check buried deep in C4::SQLHelper.  This is in a helper subroutine that was changed
for the Unified Member Search dev (bug 6253).  Reverting this small change to the conditional does not seem to break
search, but testing will be required.

To test:
1. apply patch, and create a new patron with blank birthdate.  The new patron should now have a blank birthdate instead of '00/02/0'
2. search for a borrower by 1 part surname, confirm search works
3. search for a borrower by 2 part surname, confirm search works
4. search for a borrower across firstname AND surname; confirm
5. search for a borrower and include categorycode/branchcode filters

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
I confirm all working tests 1-5
1. Created patron with blank birthdate - birthdate was blank
2. Searched for patron "henry james acevedo III" by using "acevedo" - result was correct
3. Searched for mr. acevedo using "Acevedo III" - result was correct
4. Searched for Henry James Acevedo III, Henry Acevedo and James Acevedo - results were correct
5. Searched for Mr Acevedo with the branch he was not in, with the branch he is in, with a category he was not, and a category he was. All results were correct.

also noted: inner searching seems to be working now? Example: Henry James (firstname) Acevedo III (surname) - searching James Acevedo brings back the correct patron.
Not complaining, just noting. :)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7095: Fixing cut and paste error and removing the use of diag() as this does...
Chris Nighswonger [Wed, 26 Oct 2011 15:14:05 +0000 (11:14 -0400)]
Bug 7095: Fixing cut and paste error and removing the use of diag() as this does not produce output when the test is run in a harness

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6977: Follow-up patch : catch CloneSubfield errors
Frédérick Capovilla [Fri, 21 Oct 2011 16:04:03 +0000 (12:04 -0400)]
Bug 6977: Follow-up patch : catch CloneSubfield errors

A javascript error could occur if the CloneSubfield function failed for
any reason. This would prevent the popup from disappearing.

Example : Importing informations of a UNIF_TITLE authority with multiple
$x subfields in the biblio's 440 field. 440$x isn't repeatable, so an
error occurs when trying to clone it.

http://bugs.koha-community.org/show_bug.cgi?id=6977
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6475 - Edit it's not possible in subfield "0" in MARC framework
Salvador Zaragoza Rubio [Wed, 22 Jun 2011 16:18:40 +0000 (18:18 +0200)]
Bug 6475 - Edit it's not possible in subfield "0" in MARC framework

When trying to modify the subfield "0" on a field in the
MARC subfield structure admin -> Tag xxx Subfield Constraints,
the boolean condition on liblibrarian fails for the initial "0" value.
Modified condition to allow the value "0"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7084 - Re-arranging results_summary for tags so that it applies where it is suppo...
Liz Rea [Mon, 24 Oct 2011 20:26:32 +0000 (15:26 -0500)]
Bug 7084 - Re-arranging results_summary for tags so that it applies where it is supposed to

To test:
Verify that New Tag text is the same size as all of the other surrounding text.
Verify that it is consistent in size with results that have existing tags.

See screenshot for what it looked like before:
http://screencast.com/t/hnt15kpS7SH9
Notice that the Add button and New tag text were slightly larger than the
similar constructions for results with existing tags. This patch should fix
that.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
I made sure I had a results list with on record with tags and one without.
Before applying the patch the "New tag" text and "Add" button were
inconsistent for the two records, after applying it they look the same. Nice!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7079: [SIGNED-OFF] Default values for German system preferences
Katrin Fischer [Mon, 24 Oct 2011 12:57:52 +0000 (14:57 +0200)]
Bug 7079: [SIGNED-OFF] Default values for German system preferences

Patch adds updates for system preferences to the sql file
in the installer directory:

- New: AmazonLocale: DE
- borrowerRelationship: Vater|Mutter
- BorrowersTitles: Herr|Frau
- New: CurrencyFormat: FR
- New: dateformat: metric
- New: DefaultClassificationSource: z
- New: OpacMainUserBlock: translated content
- New: OpacNav: translated content
- New: OpacNavBottom: translated content
- New: OPACSearchForTitleIn: translated content

To test:
A) Do a full installation with German sample files
B) Run the sql file 'system_preferences.sql' against your database

Verfy values of system preferences have been changed.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Patch applied cleanly. I ran through the webinstaller in German on an empty
database, and made sure system_preferences were loaded. No complaints from
the database and the systprefs are set to the right values when I check in the
staff client.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMake all strings translatable in marc21_field_007.tt
Frédérick Capovilla [Fri, 14 Oct 2011 19:52:30 +0000 (15:52 -0400)]
Make all strings translatable in marc21_field_007.tt

http://bugs.koha-community.org/show_bug.cgi?id=7033

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test plan:
- apply patch
- update po files using 'perl translate update <language-code>
- check po files for new strings from 007 plugin
- translate some / all of them
- update templates with changed po files 'perl translate install <language-code>
- verify 007 still works and got translated

8 years agoBug 6916 - item's acq date now takes you to its invoice
Robin Sheat [Fri, 16 Jul 2010 02:45:58 +0000 (14:45 +1200)]
Bug 6916 - item's acq date now takes you to its invoice

When viewing an item's details, selecting the accession date for it now
takes you to the invoice for that item.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
This works as advertised.
1) Order and receive an item in acquisition
2) Search for it in staff and go to the 'items' tab
3) Click on the 'receive date' link

Fixed conflict in moredetail.pl.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA. This patch does only work when AcqCreateItem==placing an order. This is caused by an existing bug. See Bugzilla for more details.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6321 Add a 1/4 months frequency
Frédéric Demians [Fri, 13 May 2011 10:33:58 +0000 (11:33 +0100)]
Bug 6321 Add a 1/4 months frequency

Thanks Stefano Bargioni for the typo fix

[2011.09.16] Thanks Paul for catching the display error.
[2011.10.11] Thanks Katrin for finding display error on OPAC.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested prediction pattern and display in OPAC.
No problems found.

8 years agoupdating history.txt : 3.6.0 & 3.4.6 & KohaCon11 & Joy Nelson 160th
Paul Poulain [Thu, 17 Nov 2011 15:50:54 +0000 (16:50 +0100)]
updating history.txt : 3.6.0 & 3.4.6 & KohaCon11 & Joy Nelson 160th

8 years agoBug 7221: C4/Biblio.pm documentation is incorrect.
Joy Nelson [Mon, 14 Nov 2011 22:23:49 +0000 (17:23 -0500)]
Bug 7221: C4/Biblio.pm documentation is incorrect.

$dbh is not a valid first parameter.  Removed $dbh from line 392 to show correct syntax.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
8 years agoBug 7207 - Reverting a portion of commit 607b5449bd5cb which breaks the label export...
Chris Nighswonger [Wed, 9 Nov 2011 19:51:01 +0000 (14:51 -0500)]
Bug 7207 - Reverting a portion of commit 607b5449bd5cb which breaks the label export script.

squashed chris_n's two patches. Label export works again. Also changed the pattern for the item_number to the known working, critic friendly pattern.

Don't change $_ in a list context

Changed the 3rd bit to the critic friendly pattern chris_n suggests in the previous two lines.

Signed-off-by: Brendan <brendan@bywatersolutions.com>
8 years agoFollow-up fix for Bug 5150 - Issuing should read Circulation
Owen Leonard [Thu, 10 Nov 2011 21:28:53 +0000 (16:28 -0500)]
Follow-up fix for Bug 5150 - Issuing should read Circulation

Really just a typo, but I found it when trying to chase
down instances of this bug, so here you go.

8 years ago(bug #4518) enhance 2.2 to 3.0 scripts
Nahuel ANGELINETTI [Mon, 17 May 2010 13:43:37 +0000 (15:43 +0200)]
(bug #4518) enhance 2.2 to 3.0 scripts

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 4161: Preselect active currency for new vendors
Katrin Fischer [Mon, 24 Oct 2011 15:48:29 +0000 (17:48 +0200)]
Bug 4161: Preselect active currency for new vendors

Currently when creating a new vendor in acquisitions the alphabetical first
currency will be preselected. For better usability and less mistakes the
active curency should be preselected.

To test:
Check your currency settings in administration.
Your active currency should not be the first in the list.

1) Create a new vendor
Verify the active currency is selected for list and invoice prices.

2) Check vendor summary page
Verify the correct currencies from the vendor record are shown here.

3) Edit vendor
Verify the correct currencies from the vendor record  are shown here.

Signed-off-by: Liz Rea <lrea@nekls.org>
Verified with tests 1, 2, and 3.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 2629: Add diacritic support for Ů (U with ring)
Ian Walls [Mon, 26 Sep 2011 20:38:39 +0000 (16:38 -0400)]
Bug 2629: Add diacritic support for Ů (U with ring)

Adds Ů and ů support to word-phrase-utf.chr.  These characters are used in
Czech, for example the author Martinů, Bohuslav (1890-1959)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoRevert "Bug 6015 : Improving load_testing"
Paul Poulain [Wed, 9 Nov 2011 16:29:17 +0000 (17:29 +0100)]
Revert "Bug 6015 : Improving load_testing"

sorry, was not supposed to be pushed (follow-up needed)

This reverts commit 47d74bb3fb4b564a73c6bfb9e4404a1567b5b8fc.

8 years agoBug 5945: email not searchable in patron search
Ian Walls [Fri, 4 Nov 2011 10:26:01 +0000 (06:26 -0400)]
Bug 5945: email not searchable in patron search

Adds 'email' to valid search parameters in members/member.pl

To test:
1. give a patron a unique email address in your test database
2. search on the full email; should work
3. search on the part of the email before the domain; should work

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
8 years agoBug 7138: Can't print basket group order pdf
Katrin Fischer [Wed, 2 Nov 2011 23:44:36 +0000 (00:44 +0100)]
Bug 7138: Can't print basket group order pdf

PDF print of basket groups is broken.

To test:

1) Make sure OrderPdfFormat is set to pdfformat::layout2pages or pdfformat::layout3pages
2) Create a basket with orders
3) Close the basket and create a basket group checking the checkbox
4) Print the basket group as PDF

Before patch the file is broken and when opened in an editor contains an error message.
After the patch the PDF should be generated correctly again.

Thx to Chris for helping me to fix the problem.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6015 : Improving load_testing
Henri-Damien LAURENT [Thu, 25 Mar 2010 10:37:19 +0000 (11:37 +0100)]
Bug 6015 : Improving load_testing

Adding a benchmark for OPAC
it tests :
 - mainpage
 - search page
 - detail page

Staff :
Adding a test on member searches

8 years agoBug 6679: Fixing admin/aqplain :encoding(UTF-8) gives strict validation
Chris Cormack [Mon, 31 Oct 2011 07:57:19 +0000 (20:57 +1300)]
Bug 6679: Fixing admin/aqplain :encoding(UTF-8) gives strict validation

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
tested with diacritics, no changes before and after the patch

8 years agoBug 6679 : Tidying changed parts of file
Chris Cormack [Wed, 2 Nov 2011 03:27:48 +0000 (16:27 +1300)]
Bug 6679 : Tidying changed parts of file

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 : Don't declare variables in conditionals
Chris Cormack [Wed, 2 Nov 2011 03:24:05 +0000 (16:24 +1300)]
Bug 6679 : Don't declare variables in conditionals

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 : Not using strict .. bad script, no cookie for you!
Chris Cormack [Wed, 2 Nov 2011 03:19:36 +0000 (16:19 +1300)]
Bug 6679 : Not using strict .. bad script, no cookie for you!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 : Don't declare variables in conditionals Don't change $_ in a list context...
Chris Cormack [Wed, 2 Nov 2011 03:13:20 +0000 (16:13 +1300)]
Bug 6679 : Don't declare variables in conditionals Don't change $_ in a list context search.cpan.org/~elliotjs/Perl-Critic-1.116/lib/Perl/Critic/Policy/ControlStructures/ProhibitMutatingListFunctions.pm

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 : Declare variables outside of conditionals
Chris Cormack [Wed, 2 Nov 2011 03:00:01 +0000 (16:00 +1300)]
Bug 6679 : Declare variables outside of conditionals

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_6390'
Paul Poulain [Sun, 6 Nov 2011 16:56:36 +0000 (17:56 +0100)]
Merge remote-tracking branch 'origin/new/bug_6390'

8 years agoBug 6390 Followup: Basket's authorisedby might not be a borrowernumber
Ian Walls [Tue, 18 Oct 2011 20:13:15 +0000 (16:13 -0400)]
Bug 6390 Followup: Basket's authorisedby might not be a borrowernumber

aqbasket.authorisedby is not foreign key constrainted to borrowers.borrowernumber,
so if it's anything other than that, vendor search breaks by using an undefined value
(GetMember() on an invalid borrowernumber) as a HASH ref.

This patch sets the branchcode (the desired value from GetMember) to a blank value, then only
changes it if GetMember is defined.  In the case where the authorisedby librarian has been deleted,
or the value is otherwise invalid, and AcqViewBaskets is set to 'branch', the basket will not appear
except to superlibrarians

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Invalid borrowernumber in aqbasket.authorisedby no longer breaks search.

8 years agoBug 7188: C4::Context::db_scheme2dbi does case-insensitive grep
Paul Poulain [Fri, 16 Sep 2011 22:58:41 +0000 (00:58 +0200)]
Bug 7188: C4::Context::db_scheme2dbi does case-insensitive grep

Checking NYTProf in C4::Context, it appears that the /i flag is highly time-consumming
As we don't support anything outside from mysql, returning directly mysql directly

If in a future version PostgresSQL works, then we will have to update this sub. But if an ORM is introduced, this code will be removed completly anyway

Testing note:
Drops execution time of the line from 300ms to 20 microseconds (in my testing).

8 years agoBug 7185: Fix updatedatabase message for 3.6.0 release
Julian Maurice [Sun, 6 Nov 2011 08:44:40 +0000 (14:14 +0530)]
Bug 7185: Fix updatedatabase message for 3.6.0 release

Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com>
8 years agoBug 7184 raise mySQL error if debug is set
Paul Poulain [Sun, 6 Nov 2011 08:36:52 +0000 (09:36 +0100)]
Bug 7184 raise mySQL error if debug is set

Before this patch, if a mySQL occured in Koha (any error), then the user was seeing nothing.
With this patch, if DEBUG is set in Koha VirtualHost, any mySQL error will make Koha die and display the SQL error

Step to test:
=== BEFORE PATCH ===
go anywhere, and change a mySQL statement to make it invalid.
Launch a page using the SQL you've made wrong, you'll see nothing, except you won't see the expected results

=== AFTER PATCH ===
Modify koha-httpd.conf, and add the following line, in the virtualhost (if it does not already exist)
SetEnv DEBUG 1
restart/reload Apache
Launch the same page, you'll get a Perl statement saying something like:

DBD::mysql::st execute failed: <<blablabla SQL error>> at <<where the error was raised line <<error line>>

8 years agoMerge remote-tracking branch 'origin/new/bug_7146'
Paul Poulain [Sun, 6 Nov 2011 11:04:43 +0000 (12:04 +0100)]
Merge remote-tracking branch 'origin/new/bug_7146'

8 years agoBug 7128 - adding some ID's to make styling opac-main.tt a bit easier
Liz Rea [Tue, 1 Nov 2011 19:01:17 +0000 (14:01 -0500)]
Bug 7128 - adding some ID's to make styling opac-main.tt a bit easier

To test:
verify that the loggedin id is added when user is logged in
verify that the notloggedin id is evident when no user is logged in.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Bug 7128 : Follow up, adding the id to the case when a user is not logged in

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_7117'
Paul Poulain [Sun, 6 Nov 2011 10:54:53 +0000 (11:54 +0100)]
Merge remote-tracking branch 'origin/new/bug_7117'

8 years agoBug 6994: Wrong 'no budget defined' alert
Katrin Fischer [Mon, 24 Oct 2011 18:59:57 +0000 (20:59 +0200)]
Bug 6994: Wrong 'no budget defined' alert

When ordering from an existing record the 'no budgets and funds defined' error
message was shown below the result list.

To test:
A) No budgets defined for this user and library
Basket summary page shows a warning instead of the link for creation
of orders.

B) Budgets and funds are properly defined for this user and library
Basket summary page shows links for order creation.
Before patch: A search for an existing record had the alert at the bottom
of the search result list.
After patch: The links for creation of orders are shown instead.

Signed-off-by: Liz Rea <lrea@nekls.org>
Verified A and B.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoNotify the user on his account page when his account is almost expired
Frédérick Capovilla [Wed, 5 Oct 2011 19:12:04 +0000 (15:12 -0400)]
Notify the user on his account page when his account is almost expired

New feature : If the "NotifyBorrowerDeparture" system preference is defined, a
notification appears in the user's account page if his subscription is almost
expired.

http://bugs.koha-community.org/show_bug.cgi?id=6978
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
works perfectly with date formatted DD/MM/YYYY as well

8 years agoBug 6471: add tablesorter to Holds Queue
Ian Walls [Tue, 20 Sep 2011 13:22:46 +0000 (09:22 -0400)]
Bug 6471: add tablesorter to Holds Queue

This patch adds the table sorter to Holds Queue.  Sponsored by Farmington Public Library.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoFix for Bug 7085 - Problems with searching for orders in acquisitions
Owen Leonard [Tue, 25 Oct 2011 14:16:02 +0000 (10:16 -0400)]
Fix for Bug 7085 - Problems with searching for orders in acquisitions

Changing "if ( defined $input )" to "if ( $input )" in the section
of the script which builds the order search query seems to give
successful searches where they didn't exist before. Searches from
the advanced order search screen work with title, author, vendor,
basket number, date, etc.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Searches for date ranges, title and author keywords give
me the correct results now.

8 years agoBug 7117: Bug 7117 - Small display problems when organising suggestion tabs by name
Katrin Fischer [Mon, 31 Oct 2011 00:06:17 +0000 (01:06 +0100)]
Bug 7117: Bug 7117 - Small display problems when organising suggestion tabs by name

To test:
1) Add some suggestions
2) Go to suggestions in staff
3) Choose from filters 'suggested by' or 'managed by'
4) Compare names shown on tabs with names in list of suggestions

Before patch: tab name has the wrong order, while list name is correct.
After patch: all names should be consistent and correct.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years ago7146 (Update timestamps when deleting a biblio)
Marcel de Rooy [Thu, 3 Nov 2011 12:41:24 +0000 (13:41 +0100)]
7146 (Update timestamps when deleting a biblio)

Currently, when you delete an item, the timestamp column in deleteditems is
updated with current time. (This comes from an [unintentional] additional
update statement in DelItem.) It makes deletion time visible.
In the past, the marcxml was updated too at that moment, resulting in an
updated timestamp in biblioitems too. The timestamp in biblio was not touched.

If you delete a biblio however, the timestamps in deletedbiblio and
deletedbiblioitems do not reflect time of deletion. They still show the time of
last update before the record was deleted. This last update can be extracted
from MARC field 005 too.

This behavior is not consistent nor logical. I would suggest to add a statement
in DelBiblio to force updating the timestamp in deletedbiblio(items) too. It
makes the time of deletion visible in the record too. The time of deletion of a
biblio can be very useful for e.g. synchronizing purposes.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoFollow-up fix for Bug 3958, Standardize vendor/supplier/bookseller terminology
Owen Leonard [Fri, 4 Nov 2011 18:56:50 +0000 (14:56 -0400)]
Follow-up fix for Bug 3958, Standardize vendor/supplier/bookseller terminology

Fixing two stray instances of "supplier."

8 years agoBug 7061: unnecessary global variables declared in C4::SQLHelper
Ian Walls [Wed, 19 Oct 2011 00:17:17 +0000 (20:17 -0400)]
Bug 7061: unnecessary global variables declared in C4::SQLHelper

Removes $tablename and $hash from global scope of C4/SQLHelper.pm.  They are never used;
all instances of $table are locally scoped to the subroutines, and $hash is never used.

This may help with persistance; if not, it's at least a bit of trivial cleanup.

To test:

1.  Search for a patron
2.  Create a Contract in Acquisitions
3.  Modify that Contract
4.  Delete that Contract

All instances should return error free.  This checks the subroutines of SQLHelper

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6989 Patron categories not properly displayed if not pure ASCII
Frédéric Demians [Sat, 8 Oct 2011 13:30:59 +0000 (15:30 +0200)]
Bug 6989 Patron categories not properly displayed if not pure ASCII

C4::Category module returns badly encoded patron categories when they are
containing non pure-ASCII characters.

To reproduce this bug:

  - Go in Administration > Patron Categories
  - Add a new category. Give it this code for example:
    Café
  - Click on Patrons link on top menu
  - Click on New button

    => You get 'Café' displayed without accent

Signed-off-by: Piotr Wejman <ropuch@bagno.be>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 5885 : UNIMARC XSLT changes
Paul Poulain [Wed, 15 Dec 2010 13:05:04 +0000 (14:05 +0100)]
Bug 5885 : UNIMARC XSLT changes

dealing with some BNF/SUDOC invalid utf-8 (in title, the removed fields are used to mark non-sorted words)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
I can't test this works ok for UNIMARC, but it does not cause any
problems with the translation scripts or MARC21 so signing off

8 years agoBug 7076: Lists render OPAC XSLT on staff side
Ian Walls [Fri, 21 Oct 2011 15:43:17 +0000 (11:43 -0400)]
Bug 7076: Lists render OPAC XSLT on staff side

Adds a small check in C4::VirtualShelves::Page::shelfpage to only render
OPACResultsXSLT if the $type is 'opac'.  Since parsing the XML is such an expensive
thing, and the resulting XSLTBloc is not used on the staff side, this will increase
performance for Lists in the intranet

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoFollow-up patch : use the subfield associated with items.barcode
Frédérick Capovilla [Mon, 17 Oct 2011 20:01:29 +0000 (16:01 -0400)]
Follow-up patch : use the subfield associated with items.barcode

Instead of using the 'p' subfield directly, use the subfield letter
associated with the items.barcode column.

http://bugs.koha-community.org/show_bug.cgi?id=6963
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test cases tested:
- 1 item, barcode empty
- 2 items, barcodes both empty
- 1 item, existing barcode
- 1 item, new barcode
- 2 items, one barcode empty, one existing

All test cases worked nicely and gave correct error messages.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6963: Corrects a problem when a new order is created with a duplicate barcode.
Frédérick Capovilla [Mon, 3 Oct 2011 19:00:05 +0000 (15:00 -0400)]
Bug 6963: Corrects a problem when a new order is created with a duplicate barcode.

If the AcqCreateItem preference is set to "ordering" and the barcode for
the new item is already in use, no error is returned, but an invalid
itemnumber is saved in the aqorders_items table and the item is never
created.

This patch adds a duplicate barcode verification in neworderempty.pl
_koha_add_item is also modified so it won't return an invalid ID when
an item can't be added.

http://bugs.koha-community.org/show_bug.cgi?id=6963
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test plan on second patch.

8 years agoBug 6895 : First attempt at fixing the diacritics bug
Chris Cormack [Wed, 5 Oct 2011 03:39:08 +0000 (16:39 +1300)]
Bug 6895 : First attempt at fixing the diacritics bug

This is a fairly hacky solution, a counter patch would be more than
welcome

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Updated, translated and installed German po files after applying this patch.
No problems found.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7069: Put strings in "" instead of '' to fix the javascript not working when...
Maxime Pelletier [Wed, 19 Oct 2011 19:28:16 +0000 (15:28 -0400)]
Bug 7069: Put strings in "" instead of '' to fix the javascript not working when the translated string has a ' in it.

http://bugs.koha-community.org/show_bug.cgi?id=7069

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch changes '' to "" to make it work for strings which contain '.
Patch does NOT add new strings to the po files.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoFix for Bug 6955, Toolbar on reading history broken
Owen Leonard [Mon, 3 Oct 2011 12:59:18 +0000 (08:59 -0400)]
Fix for Bug 6955, Toolbar on reading history broken

Table sorter script causes error if there is no <tbody> to sort.
JS errors cause the YUI toolbar js to abort, causing the problem
observed. When there are no results the whole table should be
omitted and a message displayed in its place.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
To test:
- check toolbar on top of patron reading history with no entries
- check toolbar on top of patron reading history after a few checkouts

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoUse unitprice in neworder so that the value is saved in the database and so it will...
Maxime Pelletier [Wed, 21 Sep 2011 18:15:39 +0000 (14:15 -0400)]
Use unitprice in neworder so that the value is saved in the database and so it will be the same field used as to receive shipments

http://bugs.koha-community.org/show_bug.cgi?id=6414
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed off with a note: this doesn't fix everything mentioned in the bug.
It also might clash with bug 4831 and should be tested with that patch.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoSorry pushed this by mistake when trying to fix Pauls permissions
Chris Cormack [Fri, 4 Nov 2011 06:46:45 +0000 (19:46 +1300)]
Sorry pushed this by mistake when trying to fix Pauls permissions

Revert "Fix for Bug 5974 - Bogus auth check for "StaffMember" role"

This reverts commit a867bfcff7201a7fa3b56bee4dd484a49ece35e3.

8 years agoFix for Bug 5974 - Bogus auth check for "StaffMember" role
Owen Leonard [Mon, 28 Mar 2011 18:08:00 +0000 (14:08 -0400)]
Fix for Bug 5974 - Bogus auth check for "StaffMember" role

Also removing some YAHOO.widget.Button declarations which
are redundant.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoUpdating version number for release v3.06.00
Chris Cormack [Fri, 21 Oct 2011 21:26:13 +0000 (10:26 +1300)]
Updating version number for release

8 years agoRelease notes for 3.6.0
Chris Cormack [Fri, 21 Oct 2011 21:24:05 +0000 (10:24 +1300)]
Release notes for 3.6.0

8 years agoUpdating distro specific install files
Chris Cormack [Fri, 21 Oct 2011 20:12:15 +0000 (09:12 +1300)]
Updating distro specific install files

8 years agoUpdating main INSTALL instructions
Chris Cormack [Fri, 21 Oct 2011 20:04:19 +0000 (09:04 +1300)]
Updating main INSTALL instructions

8 years agoBug 7078: Remove HTML::Template::Pro from Koha perl dependencies list
Ian Walls [Fri, 21 Oct 2011 18:41:03 +0000 (14:41 -0400)]
Bug 7078: Remove HTML::Template::Pro from Koha perl dependencies list

Removes HTML::Template::Pro as a requirement (since we're now on Template::Toolkit).

To test:

On a system without, HTML::Template::Pro installed, run perl koha_perl_deps.pl -m -u

Shouldn't return anything about HTML::Template::Pro

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7063: add available perl packages for Debian in install_misc/debian.packages
Ian Walls [Fri, 21 Oct 2011 18:16:51 +0000 (14:16 -0400)]
Bug 7063: add available perl packages for Debian in install_misc/debian.packages

Takes work done by Eduardo Trápani, alphabetizes, and adds two other packages:

libuniversal-require-perl
libgravatar-url-perl

From my testing, only CGI::Session::Driver::memcached remains missing; it is only
packaged for sid and wheezy at this time

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoMerge remote-tracking branch 'kc/new/bug_5995' into kcmaster
Chris Cormack [Fri, 21 Oct 2011 17:36:36 +0000 (06:36 +1300)]
Merge remote-tracking branch 'kc/new/bug_5995' into kcmaster

Conflicts:
opac/sco/sco-main.pl

8 years agoBug 5995 Follow up: variable scope in koha/sco/sco-main.pl
Ian Walls [Tue, 18 Oct 2011 14:18:14 +0000 (10:18 -0400)]
Bug 5995 Follow up: variable scope in koha/sco/sco-main.pl

The patronid value (cardnumber) set by checkpw in the case of SelfCheckoutByLogin
was improperly scoped with 'my' inside a conditional.  The changes followup to 5995
made this more apparent, causing logins to fail.

Also added "parts copyright" statement to the script, since ByWater Solutions did make some
significant contributions to the operations of the page

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoMoving po files to 3.6.0 filenames
Chris Cormack [Fri, 21 Oct 2011 16:33:40 +0000 (05:33 +1300)]
Moving po files to 3.6.0 filenames

8 years agoMerge remote-tracking branch 'tamil/3.6.0-translation' into new_po
Chris Cormack [Fri, 21 Oct 2011 15:54:00 +0000 (04:54 +1300)]
Merge remote-tracking branch 'tamil/3.6.0-translation' into new_po

8 years agoMerge remote-tracking branch 'kc/new/bug_7060' into kcmaster
Chris Cormack [Fri, 21 Oct 2011 15:09:49 +0000 (04:09 +1300)]
Merge remote-tracking branch 'kc/new/bug_7060' into kcmaster

8 years agoBug 7060 Followup: AddReturn needs GetMemberDetails
Ian Walls [Fri, 21 Oct 2011 14:49:58 +0000 (10:49 -0400)]
Bug 7060 Followup: AddReturn needs GetMemberDetails

In my haste, I overlooked circ/returns.pl's need for borrower flags.  This patch
changes back the call in AddReturn from GetMember to GetMemberDetails

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years ago3.6.0 Translations update
Frédéric Demians [Fri, 21 Oct 2011 10:53:57 +0000 (12:53 +0200)]
3.6.0 Translations update

8 years agoBug 6483 - Paging in opac-detail when coming from a search
Salvador Zaragoza Rubio [Fri, 27 May 2011 09:12:52 +0000 (11:12 +0200)]
Bug 6483 - Paging in opac-detail when coming from a search

Add paging in opac-detail when coming from a search to be
able to continue viewing the previous and next register
from the detail without returning to the results.
The partial list pagination can be showed to increase forwarding
or rewinding in the pagination.
It's implemented for Zebra search and not build_grouped_results.

The param busc with all the information from the search is stored
on the session when running opac-search and opac-detail, outside these
pages the busc param is removed from the session.

A list of the biblionumbers inside the OPACnumSearchResults range
is passed to avoid repeating the searching everytime we see the
previous or next biblio. The searching will be run again when
we are going to exceed the list and a new one will be calculated
from the new search.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6854: Correct a double password encryption problem in import_borrowers.pl
Frédérick Capovilla [Wed, 7 Sep 2011 18:15:35 +0000 (14:15 -0400)]
Bug 6854: Correct a double password encryption problem in import_borrowers.pl

When the CSV file has no password column and no default value was set for
the password :
If we try to modify an existing user, the password from the BD is sent
to ModMember, which then encrypts the already-encrypted password a
second time.

http://bugs.koha-community.org/show_bug.cgi?id=6854

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Confirmed bug on current master.
1) Import new patron with password provided
> OPAC login works
2) Overwrite patron record, password provided
> OPAC login works
3) Overwrite patron record, password not provided
Before patch: OPAC login broken, password in database changed
After patch: OPC login works with same password as before

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years ago7042 Improving cleanup_database.pl: handling quotes in a_session and interpreting...
Marcel de Rooy [Mon, 17 Oct 2011 09:32:50 +0000 (11:32 +0200)]
7042 Improving cleanup_database.pl: handling quotes in a_session and interpreting sessdays parameter

Improving the cleanup_database.pl script in two aspects:
1) In some cases CGI::Session seems to place quotes around the atime and ctime
data in the a_session field. Two regexps now take this into account.
2) If the --sessdays parameter is used, the --sessions parameter is now
implicitly enabled too.

With thanks to Ian Bays and Tom Hanstra.

Signed-off-by: Ian Bays <ian.bays@ptfs-europe.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoMerge remote-tracking branch 'kc/new/bug_6094' into kcmaster
Chris Cormack [Thu, 20 Oct 2011 15:32:31 +0000 (04:32 +1300)]
Merge remote-tracking branch 'kc/new/bug_6094' into kcmaster

8 years ago6094 Follow up for cleanup_database
Marcel de Rooy [Thu, 20 Oct 2011 07:57:12 +0000 (09:57 +0200)]
6094 Follow up for cleanup_database

Adds purging completed entries from need_merge_authorities table.
If you set dontmerge to ON, you need to periodically remove records.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7060: GetMemberDetails unnecessary in C4::Circulation
Ian Walls [Tue, 18 Oct 2011 23:55:22 +0000 (19:55 -0400)]
Bug 7060: GetMemberDetails unnecessary in C4::Circulation

Replaces all instances of GetMemberDetails with the more efficient GetMember.  Since
no hash values other than the borrowers table's fields are used in this module, the
transition is safe.

To test:

1.  Checkout a material; the page should load without error
2.  Renew a material: the page should load without error
3.  Return a material: the page should load without error

The above test plan invokes all the subroutines affected by this patch; any call to an undefined
value in a hashref should give a warning

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7059: Remove GetMemberDetails from reserve/request.pl
Ian Walls [Tue, 18 Oct 2011 22:31:00 +0000 (18:31 -0400)]
Bug 7059: Remove GetMemberDetails from reserve/request.pl

Replaces all four usages of GetMemberDetails with GetMember, since none of the
hashref fields used were anything other than those in borrower table, which GetMember
returns.

To Test:
1.  Apply patch
2.  Go to reserve/request.pl; the page should load without error
3.  Search for a cardnumber: the page should load without error

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7057: CheckReserves uses GetMemberDetails unnecessarily
Ian Walls [Tue, 18 Oct 2011 21:56:18 +0000 (17:56 -0400)]
Bug 7057: CheckReserves uses GetMemberDetails unnecessarily

Replaces call to GetMemberDetails with a call to GetMember.  Much more efficient,
and since only branchcode is used, no required data is lost.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6572: Script batch anonymisation wrapper
D Ruth Bavousett [Sat, 9 Jul 2011 16:50:06 +0000 (12:50 -0400)]
Bug 6572: Script batch anonymisation wrapper

This little script, given a --days numeric parameter, will anonymise checkouts
before that many days ago.  Useful for sites that want to automatically do this on
a periodic (cronnable) basis.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBumping database version
Chris Cormack [Wed, 19 Oct 2011 23:16:30 +0000 (12:16 +1300)]
Bumping database version

8 years agoFollow-up fix for Bug 4473 - Recent comments view for the OPAC
Owen Leonard [Tue, 4 Oct 2011 14:20:52 +0000 (10:20 -0400)]
Follow-up fix for Bug 4473 - Recent comments view for the OPAC

This follow-up adds a system preference which controls display
of a link to recent comments in the OPAC masthead alongside
"Advanced search," "Tag cloud," etc.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7049: [SIGNED-OFF] Item form on order receive has lots of blank space
Katrin Fischer [Mon, 17 Oct 2011 20:04:53 +0000 (22:04 +0200)]
Bug 7049: [SIGNED-OFF] Item form on order receive has lots of blank space

The item form on the order receive page (AcqCreateItem = on receive) contains a
lot of blank space which makes it hard to read and fill out.

To test:
- set AcqCreateItem = on receive
- create basket, order something, receive shipment
- check item form is nicely formatted and doesn't include lots of blank space

Note: It will be easier to test if you have an ACQ framework created to hide some
unnecessary subfields, because the hidden fields create the blank space.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Created an ACQ framework and hid some of the fields (hidden = 5). Before the
patch there were gaps between the fields as shown in the screenshot from
Katrin. After the patch fields line up nicely, with no extra space between
them.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7016: CanBookBeReserved uses GetItemsInfo unnecessarily
Ian Walls [Wed, 12 Oct 2011 19:35:31 +0000 (15:35 -0400)]
Bug 7016: CanBookBeReserved uses GetItemsInfo unnecessarily

CanBookBeReserved uses the very heavy-weight function GetItemsInfo to simply retrieve
the itemnumbers attached to a given biblio.  The function get_itemnumbers_of() is much
lighter-weight and returns the required information; switching to it will reduce the overall
system resource cost of placing a hold.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7027: [SIGNED-OFF] Corrections to German web installer txt files
Katrin Fischer [Thu, 13 Oct 2011 21:47:16 +0000 (23:47 +0200)]
Bug 7027: [SIGNED-OFF] Corrections to German web installer txt files

Rephrasing, correcting typos, removing blank lines

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Does not break the web-installer and I'm assuming
Katrin is doing the right thing when it comes to
the German text, so signing off!

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoFix for Bug 6980, Patron attributes are shown when ExtendedPatronAttributes is disabled
Owen Leonard [Thu, 6 Oct 2011 18:27:16 +0000 (14:27 -0400)]
Fix for Bug 6980, Patron attributes are shown when ExtendedPatronAttributes is disabled

This patch adds a check for the value of the ExtendedPatronAttributes
preference to the scripts and corresponding logic to the templates
controlling the sidebar menu.

The patch also corrects a duplication of attributes code in moremember.pl

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
1) Added extended patron attributes in configuration, turned ExtendedPatronAttributes on
2) Altered patron details, added values for patron attributes
> Verified patron attributes show show correctly
3) Turned off ExtendedPatronAttributes
> Verified patron attributes were hidden everywhere

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoFix for Bug 6957, authors disappearing when emailing lists
Owen Leonard [Mon, 3 Oct 2011 14:43:35 +0000 (10:43 -0400)]
Fix for Bug 6957, authors disappearing when emailing lists

Standard author information wasn't even in the template markup, only
"additional author." Added standard author and improved output of
additional authors (hiding label when empty).

Also added subtitle via GetRecordValue (see bug 3550).

Also added check for and output of OPACBaseURL in order
to make OPAC links in the email clickable.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA revision:  renamed OPACBaseurl to OPACBaseURL for consistency

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBumping database version
Chris Cormack [Wed, 19 Oct 2011 22:32:26 +0000 (11:32 +1300)]
Bumping database version

8 years ago6094 Fixing ModAuthority problems
Marcel de Rooy [Mon, 25 Jul 2011 09:33:23 +0000 (11:33 +0200)]
6094 Fixing ModAuthority problems

Only contains db revision to insert new table need_merge_authorities.
You can apply the revision by running
cgi-bin/koha/installer/install.pl?step=3&op=updatestructure. (Will not change
your version while testing.)

Oct 19, 2011: Rebased after functionality patch signoff.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years ago6094 Fixing ModAuthority problems
Marcel de Rooy [Thu, 7 Apr 2011 08:14:08 +0000 (10:14 +0200)]
6094 Fixing ModAuthority problems

Pref MergeAuthoritiesOnUpdate does not exist; should be dontmerge
(AuthoritiesMarc.pm).

Instead of folder modified_authorities, now introducing a table for this
purpose: need_merge_authorities. This eliminates several permissions and
security issues. This change applies to AuthoritiesMarc.pm and
merge_authority.pl.

POD lines added for ModAuthority. Deprecated parameter $merge removed.

Test this patch by applying the db revision first from the second patch.

August 4, 2011: Rebased.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Thanks Marcel. It works as advertised. Both modes are functionnal
(back):

- Immediate with dontmerge=0: After modifying an authority record, its
  linked biblios are immediately modified. This isn't the case in 3.4.5.
- Delayed with dontmerge=1: After modifying an authority record, its
  linked biblios are not modified. But an entry is added to
  need_merge_authority new table and 'merge_authorities.pl -b' script
  updates biblios.

Comment: need_merge_authority, like zebraqueue, should be cleared
from time to time.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6553: parentheses in authors break tracings
Ian Walls [Mon, 3 Oct 2011 15:22:30 +0000 (11:22 -0400)]
Bug 6553: parentheses in authors break tracings

If an author's name includes parentheses or other escape-characters, the tracing links
produced in the OPAC and staff client fail in XSLT mode.  This patch wraps the author names
in double-quotes, providing the necessary escapement.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test plan:
- Create a new framework, delete Thesaurus from 700 and other fields
- Create a new record in this framework
- Add 700$a - use parentheses
- Check the search links in OPAC and staff detail pages
> before patch link was broken, after it works

Note: Links are only broken when no authorities are being used.
When using authorities the link uses the auth number instead of the text
for linking, so the parentheses don't matter for search.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoMerge remote-tracking branch 'kc/new/bug_6253' into kcmaster
Chris Cormack [Wed, 19 Oct 2011 20:23:36 +0000 (09:23 +1300)]
Merge remote-tracking branch 'kc/new/bug_6253' into kcmaster

8 years agoBug 6253 followup: explicitly check ref value for ARRAY before casting
Ian Walls [Wed, 19 Oct 2011 15:46:21 +0000 (11:46 -0400)]
Bug 6253 followup: explicitly check ref value for ARRAY before casting

in C4::SQLHelper::_Process_Operands, $operand has been modified to be cast as an array ref
if the incoming $operand is not a ref.  However, the incoming $operand could be some other
kind of ref (hashref for example), which would case the dereferencing in line 419 to fail and exit.

Adding an explicit test for whether the ref is ARRAY seems to clear up this issue.

To test, run t/db_dependent/Members.t.  Before, it fails after test 3.  After, it completes all tests.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBumping db version
Chris Cormack [Wed, 19 Oct 2011 14:20:57 +0000 (03:20 +1300)]
Bumping db version

8 years agoBug 5436, adding updatedatabase.pl
Chris Cormack [Wed, 19 Oct 2011 14:19:02 +0000 (03:19 +1300)]
Bug 5436, adding updatedatabase.pl

8 years agoBug 6972 : Followup fixing bad indentation
Chris Cormack [Wed, 19 Oct 2011 12:52:52 +0000 (01:52 +1300)]
Bug 6972 : Followup fixing bad indentation

8 years agoBug 6972: Hardcoded template paths to en in showmarc
Maxime Pelletier [Tue, 4 Oct 2011 18:32:08 +0000 (14:32 -0400)]
Bug 6972: Hardcoded template paths to en in showmarc

Couldn't help but reformat the indentation a bit.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Card view works correctly in cataloguing search.
Plain view/labelled show correctly in OPAC.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Fixing merge conflict.

8 years agoBug 6883 Update userpermisions.sql fr-FR file
Frédéric Demians [Mon, 19 Sep 2011 05:25:17 +0000 (07:25 +0200)]
Bug 6883 Update userpermisions.sql fr-FR file

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I verified that the new files works with the web installer, permissions
can be set and removed.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 5680: Follow Up for Order cancelling improvement : the same for parcel.pl
Christophe Croullebois [Sat, 15 Oct 2011 19:21:35 +0000 (21:21 +0200)]
Bug 5680: Follow Up for Order cancelling improvement : the same for parcel.pl

The same scope than in basket.pl

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Detailed information about possible deletion of orders on parcel page.

1) Delete order for record with 1 other item and item level hold
OK. Record, item and hold remain, only on order item is deleted.

2) Delete order for ordered record with 1 item and title level hold
OK. Deletion is not possible, before hold is cancelled.

3) Delete order for new record with only items connected to this order
OK. Cancelling the order deletes record and item or only order,
depending on link used.

4) Delete order for record with subscription.
OK. Subscription remains untouched, item is deleted.

Also checked:
AcqCreateItem = on receive / in cataloging
Links show and it's possible to delete the order or only the record
using different links.

Comments:
There is a table sorter option for the last column with the delete links.
I am not sure it is useful here, but it does work.

Before patch is applied, the links use 'cancel' instead of 'delete'.
I am not sure which is better and if it should be different on
basket summary and order receive or the same on both.

QA Comment:
Made a small change to template language; blocking deletion because of items referred to
holds instead.  Changed text to refer to items.
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>