koha.git
5 months agoBug 20434: Add missing fields
Julian Maurice [Thu, 3 Oct 2019 15:34:56 +0000 (17:34 +0200)]
Bug 20434: Add missing fields

018 - [Reserved for other International Standard Numbers]
033 - Other System Persistent Record Identifier
183 - Coded Data Field: Type of Carrier
203 - Content Form and Media Type
231 - Digital File Characteristics
283 - Carrier Type
338 - Funding Information Note

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Add missing authority types
Julian Maurice [Thu, 3 Oct 2019 13:58:03 +0000 (15:58 +0200)]
Bug 20434: Add missing authority types

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Add UNIMARC field 214 and its subfields
Julian Maurice [Wed, 2 Oct 2019 12:40:56 +0000 (14:40 +0200)]
Bug 20434: Add UNIMARC field 214 and its subfields

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - script
Julian Maurice [Wed, 2 Oct 2019 11:45:32 +0000 (13:45 +0200)]
Bug 20434: Update UNIMARC framework - script

Test plan:
1. Take a look at files in misc/migration_tools/ifla/data. It
   contains all data that will be inserted into Koha. Its content is
   based on the previous patches.
2. Run the script misc/migration_tools/ifla/update.pl and verify
   that it effectively added the new fields, subfields, authorised
   values and authority types.
3. Run the script again and see that it doesn't update existing fields
4. Run with --force and verify that it update existing fields (you can
   modify unimarc_ifla.yml to see changes)
5. Run with --force --po-file misc/migration_tools/ifla/language/fr.po
   and verify that the labels are now in french

There is a POT file in misc/migration_tools/ifla/language/template.pot,
use it to create PO files for other languages.

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - translations
Julian Maurice [Wed, 2 Oct 2019 11:45:18 +0000 (13:45 +0200)]
Bug 20434: Update UNIMARC framework - translations

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (WORK)
Julian Maurice [Wed, 2 Oct 2019 11:44:37 +0000 (13:44 +0200)]
Bug 20434: Update UNIMARC framework - auth (WORK)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (TU)
Julian Maurice [Wed, 2 Oct 2019 11:44:31 +0000 (13:44 +0200)]
Bug 20434: Update UNIMARC framework - auth (TU)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (TM)
Julian Maurice [Wed, 2 Oct 2019 11:44:23 +0000 (13:44 +0200)]
Bug 20434: Update UNIMARC framework - auth (TM)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (SNG)
Julian Maurice [Wed, 2 Oct 2019 11:44:15 +0000 (13:44 +0200)]
Bug 20434: Update UNIMARC framework - auth (SNG)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (SNC)
Julian Maurice [Wed, 2 Oct 2019 11:44:10 +0000 (13:44 +0200)]
Bug 20434: Update UNIMARC framework - auth (SNC)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (SAUTTIT)
Julian Maurice [Wed, 2 Oct 2019 11:44:01 +0000 (13:44 +0200)]
Bug 20434: Update UNIMARC framework - auth (SAUTTIT)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (PUB)
Julian Maurice [Wed, 2 Oct 2019 11:43:27 +0000 (13:43 +0200)]
Bug 20434: Update UNIMARC framework - auth (PUB)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (PERS)
Julian Maurice [Wed, 2 Oct 2019 11:43:16 +0000 (13:43 +0200)]
Bug 20434: Update UNIMARC framework - auth (PERS)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (PA)
Julian Maurice [Wed, 2 Oct 2019 11:43:08 +0000 (13:43 +0200)]
Bug 20434: Update UNIMARC framework - auth (PA)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (NTWORK)
Julian Maurice [Wed, 2 Oct 2019 11:43:01 +0000 (13:43 +0200)]
Bug 20434: Update UNIMARC framework - auth (NTWORK)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (NTEXP)
Julian Maurice [Wed, 2 Oct 2019 11:42:52 +0000 (13:42 +0200)]
Bug 20434: Update UNIMARC framework - auth (NTEXP)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (NP)
Julian Maurice [Wed, 2 Oct 2019 11:42:33 +0000 (13:42 +0200)]
Bug 20434: Update UNIMARC framework - auth (NP)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (GENRE/FORM)
Julian Maurice [Wed, 2 Oct 2019 11:42:23 +0000 (13:42 +0200)]
Bug 20434: Update UNIMARC framework - auth (GENRE/FORM)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (FAM)
Julian Maurice [Wed, 2 Oct 2019 11:42:08 +0000 (13:42 +0200)]
Bug 20434: Update UNIMARC framework - auth (FAM)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (EXP)
Julian Maurice [Wed, 2 Oct 2019 11:42:00 +0000 (13:42 +0200)]
Bug 20434: Update UNIMARC framework - auth (EXP)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (CO)
Julian Maurice [Wed, 2 Oct 2019 11:41:53 +0000 (13:41 +0200)]
Bug 20434: Update UNIMARC framework - auth (CO)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (CLASS)
Julian Maurice [Wed, 2 Oct 2019 11:41:44 +0000 (13:41 +0200)]
Bug 20434: Update UNIMARC framework - auth (CLASS)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - auth (default)
Julian Maurice [Wed, 2 Oct 2019 11:41:29 +0000 (13:41 +0200)]
Bug 20434: Update UNIMARC framework - auth (default)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - authtypes
Julian Maurice [Wed, 2 Oct 2019 11:44:56 +0000 (13:44 +0200)]
Bug 20434: Update UNIMARC framework - authtypes

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - biblio
Julian Maurice [Wed, 2 Oct 2019 11:41:08 +0000 (13:41 +0200)]
Bug 20434: Update UNIMARC framework - biblio

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - authorised values
Julian Maurice [Wed, 2 Oct 2019 11:38:31 +0000 (13:38 +0200)]
Bug 20434: Update UNIMARC framework - authorised values

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20434: Update UNIMARC framework - defaults
Julian Maurice [Wed, 2 Oct 2019 11:40:05 +0000 (13:40 +0200)]
Bug 20434: Update UNIMARC framework - defaults

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23435: Add multiple copies of an item when receiving in serials
Aleisha Amohia [Fri, 9 Aug 2019 03:34:45 +0000 (03:34 +0000)]
Bug 23435: Add multiple copies of an item when receiving in serials

This feature allows you to add multiple item records when receiving a
serial, if the subscription is set to 'create item record when receiving
serials'. Please note this is not the same as multi-receiving, more like
multi-adding!

To test:
1) Create a subscription, ensure the 'Create an item record when
receiving this serial' option is selected
2) Receive a serial
3) Expand the item form by selecting 'click to add item'
4) Fill in details, including a barcode. Leave 'number of copies' as 1
and Save.
5) Confirm the serial is received as expected.
6) In another tab, open the bibliographic record attached to this
subscription
7) Confirm the item record was created upon receiving the serial
8) Go back to the serial collection and receive next serial
9) Expand the item form by selecting 'click to add item'
10) Fill in details again, this time change 'number of copies' to a
different number e.g. 3, and Save
11) Confirm the serial is received as expected.
12) Check back at the biblio record that 3 item records were created and
the barcode was incremented for each additional item.

Sponsored-by: Brimbank City Council
Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23812: Download icon is an upload icon
Lucas Gass [Wed, 16 Oct 2019 21:49:34 +0000 (21:49 +0000)]
Bug 23812: Download icon is an upload icon

Signed-off-by: cori <corilynn.arnold@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23826: Correction for missing "F" -> "OVERDUE" change
Martin Renvoize [Wed, 16 Oct 2019 15:21:46 +0000 (16:21 +0100)]
Bug 23826: Correction for missing "F" -> "OVERDUE" change

When replacing F and FU with 'OVERDUE' + status in bug 22521 I missed
the cases inside the maninvoice template. This patch should correct
that mistake.

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23821: Remove new occurrence of create_helper_biblio
Jonathan Druart [Wed, 16 Oct 2019 10:25:42 +0000 (12:25 +0200)]
Bug 23821: Remove new occurrence of create_helper_biblio

create_helper_biblio subroutines have been remove from bug 21798, but
one occurrence have been reintroduced by bug 7614. We must use
build_sample_biblio instead.

Test plan:
  prove t/db_dependent/Koha/Libraries.t
should return green.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23704: Typo in itemtypes.tt
Owen Leonard [Tue, 15 Oct 2019 17:28:13 +0000 (17:28 +0000)]
Bug 23704: Typo in itemtypes.tt

This patch corrects a typo:

"for loans specifie in hours."

corrected to "for loans specified in hours."

To test, apply the patch and edit an existing item type. The description
of the "Hourly rental charge" field should be correct.

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 8260: user rank order instead of absolute rank to set dropdowns on routing.pl
Nick Clemens [Thu, 6 Jun 2019 19:18:19 +0000 (19:18 +0000)]
Bug 8260: user rank order instead of absolute rank to set dropdowns on routing.pl

When deleting a borrower on a routing list we leave a gap in the numbering. It appears to only be a problem when viewing
or editing the list in the staff client.

Rather than use the rank in the DB to set the values, we use the implicit order

To test:
 1 - Create a subscription (or find one)
 2 - Add a routing list
 3 - Add five patrons
 4 - Delete the patron who is third in the list
 5 - Edit the routing list
 6 - Note the priority for the last patron is 1
 7 - Apply patch
 8 - Reload the page
 9 - Values look correct
10 - Confirm reordering works as expected

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23804: Correctly catch remote itemtype images
Martin Renvoize [Fri, 11 Oct 2019 13:18:58 +0000 (14:18 +0100)]
Bug 23804: Correctly catch remote itemtype images

Bug 20216 missed the mark and although it did start display a URL for
the itemtype image in use, it was not limited to remote urls and as such
broke the checked handling for displaying which local image was
selected.

Test plan:
1) Select a local image for an itemtype.
2) Check the correct image is displayed in the admin table.
3) Edit the itemtype checking that the correct image is checked.
4) Change to a remote image for the itemtype
5) Check the correct image is displayed in the admin table.
6) Edit the itemtype again and check that the URL still displays and is
   checked in the 'Remote image' tab.
7) Signoff

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23551: Fix AddRenewal call in circ/renew.pl
Martin Renvoize [Fri, 4 Oct 2019 13:06:27 +0000 (14:06 +0100)]
Bug 23551: Fix AddRenewal call in circ/renew.pl

Without the patch, renewing from the renewal tab/page
led to wrong renewal/due dates.

To test:
- Check an item out to your patron account
- Renew it from the patron account
- Note the due date
- Return the item
- Check the item out again
- Renew it using the renewal tab
- Verify a different due date was calculated
- Apply patch
- Repeat test - due dates now should be the same

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23129: (RM follow-up) Fix failing test
Martin Renvoize [Tue, 15 Oct 2019 15:49:07 +0000 (16:49 +0100)]
Bug 23129: (RM follow-up) Fix failing test

This patch corrects a test that was testing for the oposite behaviour to
that introduced in this patchset.  We have agreed on the bug that the
new behaviour is desired and so I have updated the test to follow.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23528: Show 'log in to add tags' link on all search result entries
Owen Leonard [Fri, 11 Oct 2019 14:53:24 +0000 (14:53 +0000)]
Bug 23528: Show 'log in to add tags' link on all search result entries

This patch modifies the OPAC search result template so that each result
shows the "Log in to add tags" link instead of just the first.

To test, apply the patch and make sure TagsEnabled and TagsInputOnList
are both enabled.

Perform a search in the OPAC while not logged in. In the list of
results, the "Log in to add tags" link should appear with every result.

Log in to the OPAC and confirm that the "Add tag" link appears as
expected.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23038: Remove unused stderr vars
Jonathan Druart [Mon, 14 Oct 2019 07:47:01 +0000 (09:47 +0200)]
Bug 23038: Remove unused stderr vars

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23038: Hide expected warnings from tests
Jonathan Druart [Mon, 3 Jun 2019 16:40:31 +0000 (11:40 -0500)]
Bug 23038: Hide expected warnings from tests

When tests are ran, there are 2 warnings that are expected and raised by
DBI.
As they are expected they must be correctly caught and not displayed.

We could have reconnect with PrintError turned off, but then reconnect
with it on.

Test plan:
% prove t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Suggestions.t
Must not display DBI warnings

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23129: Set holdingbranch to library that initiates transfer
Nick Clemens [Fri, 14 Jun 2019 18:18:03 +0000 (18:18 +0000)]
Bug 23129: Set holdingbranch to library that initiates transfer

To test:
1 - Find an item
2 - Check it in at anothe rbranch and initiate a transfer
3 - View the item details or check db - note that holdingbranch is set as the destination library
4 - Complete or cancel the transfer
5 - Apply patch
6 - Initiate a new transfer
7 - Note the holdingbranch is set to the initiating library

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23129: Unit test
Nick Clemens [Fri, 14 Jun 2019 18:17:54 +0000 (18:17 +0000)]
Bug 23129: Unit test

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 17247: (follow-up) Terminology fix: Use Restricted instead of debarred
Katrin Fischer [Wed, 9 Oct 2019 12:39:28 +0000 (12:39 +0000)]
Bug 17247: (follow-up) Terminology fix: Use Restricted instead of debarred

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 17247: Check if patron is restricted in HoldItem and HoldTitle
Arthur Suzuki [Mon, 13 May 2019 09:29:50 +0000 (11:29 +0200)]
Bug 17247: Check if patron is restricted in HoldItem and HoldTitle

Test plan:
Make sure a restricted patron cannot hold a title or item through ILS-DI.
Response from the WebService should be "PatronDebarred".

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23772: Revert to passing itemtype objects to the template
Martin Renvoize [Fri, 11 Oct 2019 12:36:54 +0000 (13:36 +0100)]
Bug 23772: Revert to passing itemtype objects to the template

This patch restores the methodology prior to bug 23602 of passing the
full Koha::ItemType objects to the template and thus giving us the
ability to use all the methods present within them.

Test plan:
1) Ensure you have at least one itemtype with an assigned icon and the
   images enabled.
2) View the itemtypes admin page and note the icons display again
3) Ensure you have at least one itemtype with library limitations
   defined.
4) View the itemtypes admin page and note the library limitations still
   display.
5) Signoff

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 13937: (RM follow-up) Set working directory for daemon mode.
Martin Renvoize [Tue, 15 Oct 2019 12:45:13 +0000 (13:45 +0100)]
Bug 13937: (RM follow-up) Set working directory for daemon mode.

When running as a daemon under Net::Z3950::SimpleServer YAZ requires a
little help to know where it's "working directory" is located so
relative paths in config files may resolve correctly.

This patch passes the working directory as prescribed on
https://software.indexdata.com/yaz/doc/server.invocation.html such that
the resolution of the cql2rpn filepath works as expected in tests.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 13937: (QA follow-up) Make tests work with YAZ 4 and 5.
Ere Maijala [Tue, 15 Oct 2019 06:39:42 +0000 (09:39 +0300)]
Bug 13937: (QA follow-up) Make tests work with YAZ 4 and 5.

Also makes add_item_status tests more robust by clearing the cache after modifying authorised values.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 13937: (follow-up) Add missing entry to koha-common.install
Tomas Cohen Arazi [Mon, 14 Oct 2019 12:36:10 +0000 (09:36 -0300)]
Bug 13937: (follow-up) Add missing entry to koha-common.install

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 13937: (QA follow-up) Fix tests.
Ere Maijala [Wed, 9 Oct 2019 11:15:39 +0000 (14:15 +0300)]
Bug 13937: (QA follow-up) Fix tests.

Checking result set size is enough to verify that proper results were returned. The check for non-existing record could have caused a range error depending of library versions.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23809: Correction to selectall_arrayref call.
Martin Renvoize [Mon, 14 Oct 2019 08:56:18 +0000 (09:56 +0100)]
Bug 23809: Correction to selectall_arrayref call.

This patch adds the missing `{ Slice => {} }` attribute to the database
call introduced in bug 23265 to fix the use of Koha::Objects introduced
originally in bug 12063.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23803: Compiled CSS
Martin Renvoize [Fri, 11 Oct 2019 13:36:22 +0000 (14:36 +0100)]
Bug 23803: Compiled CSS

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23803: (follow-up) Remove additional references and file
Owen Leonard [Fri, 11 Oct 2019 12:40:32 +0000 (12:40 +0000)]
Bug 23803: (follow-up) Remove additional references and file

This patch removes the cart-small.gif file and a couple other references
to the file.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23803: Add Font Awesome icon to cart in staff interface
Claire Gravely [Fri, 11 Oct 2019 12:23:09 +0000 (12:23 +0000)]
Bug 23803: Add Font Awesome icon to cart in staff interface

This patch adds the font awesome icon to the cart in the staff
interface.

To test:

1. Apply patch and run yarn build (see:
 https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

2. Check that the old cart icon no longer displays and the new font
   awesome icon is positioned correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23771: Don't look for patrons if we don't have a userid
Nick [Mon, 7 Oct 2019 20:09:04 +0000 (20:09 +0000)]
Bug 23771: Don't look for patrons if we don't have a userid

While the code requires external auth to test, the change is simple enough I
think a good read would suffice

To test:
1 - You either need Shib or CAS enabled and setup
2 - Add two users with blank.null cardnumbers
3 - Lock those user accounts
    Set failedloginattempts to 1
    Try a bad login with the userid
    Or set via the DB
4 - Try a good login via the external auth
5 - Note it fails
6 - Apply patch
7 - Login now succeeds

Signed-off-by: Mike Somers - Bridgewater State University <msomers@bridgew.edu>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 17140: DBRev 19.06.00.040
Martin Renvoize [Fri, 11 Oct 2019 09:57:30 +0000 (10:57 +0100)]
Bug 17140: DBRev 19.06.00.040

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23484: (follow-up) add parenthesis in JOIN
Fridolin Somers [Fri, 4 Oct 2019 10:02:59 +0000 (12:02 +0200)]
Bug 23484: (follow-up) add parenthesis in JOIN

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23484: Update pendingreserves.pl to use circulation_rules
Nick Clemens [Wed, 21 Aug 2019 13:39:14 +0000 (13:39 +0000)]
Bug 23484: Update pendingreserves.pl to use circulation_rules

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 17140: Atomic update file
Nick [Fri, 4 Oct 2019 08:15:43 +0000 (08:15 +0000)]
Bug 17140: Atomic update file

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 17140: Make rounding syspref controlled
Nick [Thu, 3 Oct 2019 11:06:47 +0000 (11:06 +0000)]
Bug 17140: Make rounding syspref controlled

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 17140: fix rounding errors when paying fines
Blou [Fri, 21 Dec 2018 15:33:29 +0000 (10:33 -0500)]
Bug 17140: fix rounding errors when paying fines

Whenever a fine (accountlines in DB) has a precision longer than two floating points, it becomes very hard for a user to clear it.
Ex: 1.035 will be displayed as 1.04 or 1.03 depending on the screen.  But entering any of those value in Pay Fine will not clear it.
The user has no way to know the exact value to enter.

This fix makes sure that the intent of the user is met, by matching the EXACT needed sum when the difference is less than 0.01.

TEST
1) Create a 1.035 fine
  - Go to a Patron screen
  - Fines tab on the left
  - Create manual invoice
2) go to Pay fines, click Pay amount on bottom left.
3) It will show 1.03 as Total, and as Collect from patron.  Click confirm.
4) An error message will appear.
5) Apply patch, do again.

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23626: (follow-up) Fix JS when not viewing results
Nick [Thu, 10 Oct 2019 16:40:55 +0000 (16:40 +0000)]
Bug 23626: (follow-up) Fix JS when not viewing results

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20780: (follow-up) Use Koha::Object
Martin Renvoize [Wed, 31 Oct 2018 14:41:12 +0000 (14:41 +0000)]
Bug 20780: (follow-up) Use Koha::Object

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20780: Add handling for AcqItemSetSubfieldsWhenRecieved in EDI
Martin Renvoize [Fri, 18 May 2018 15:56:26 +0000 (16:56 +0100)]
Bug 20780: Add handling for AcqItemSetSubfieldsWhenRecieved in EDI

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 21580: Pass buyer_ean to create_edi_order
Colin Campbell [Tue, 16 Oct 2018 15:27:17 +0000 (16:27 +0100)]
Bug 21580: Pass buyer_ean to create_edi_order

create_edi_order requires two parameters to be passed
but if vendor was set to auto_order the subroutine
was called with basketno only resulting in the error
'no basket or ean passed' - pass the buyer_ean as
passed in the quotes message

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 21580: Add test for message buyer_ean method
Colin Campbell [Tue, 16 Oct 2018 15:21:49 +0000 (16:21 +0100)]
Bug 21580: Add test for message buyer_ean method

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20334: (RM follow-up) Fix test for case insensative filesystems 2
Martin Renvoize [Wed, 9 Oct 2019 14:03:06 +0000 (15:03 +0100)]
Bug 20334: (RM follow-up) Fix test for case insensative filesystems 2

This patch moves the Elasticsearch/Indexer.t to ElasticSearch/Indexer.t
and thus removes the case directory name collision introduced.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 20334: (RM follow-up) Fix test for case insensative filesystems
Martin Renvoize [Wed, 9 Oct 2019 14:03:06 +0000 (15:03 +0100)]
Bug 20334: (RM follow-up) Fix test for case insensative filesystems

This patch moved the tests created in Elasticsearch/QueryBuilder.t into
ElasticSearch/QueryBuilder.t and thus removes the case directory name
collision introduced.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 17179: DBRev 19.06.00.039
Martin Renvoize [Wed, 9 Oct 2019 13:37:39 +0000 (14:37 +0100)]
Bug 17179: DBRev 19.06.00.039

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 17179: (follow-up) Add to keyboard_shortcuts.sql
Nick [Mon, 7 Oct 2019 23:25:38 +0000 (23:25 +0000)]
Bug 17179: (follow-up) Add to keyboard_shortcuts.sql

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 17179: (follow-up) Correct typos, add default select.
Alex Sassmannshausen [Thu, 3 Oct 2019 13:36:26 +0000 (15:36 +0200)]
Bug 17179: (follow-up) Correct typos, add default select.

Correct error whereby object curCursor was invoked as a function.

Added action whereby the most recent entry in the clipboard is
selected after all copy and cut operations.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text
Nick Clemens [Wed, 20 Feb 2019 17:30:36 +0000 (17:30 +0000)]
Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text

This patchset introduces an internal clipboard to the advanced editor
and provides some new functionality to make use of this, default shortcuts are provided
but can be edited per bug 21411

The default shortcuts for new/changed functions are:

Changed:
Ctrl-X:       Now cuts a line into the clipboard area
Shift-Ctrl-X: Now cuts current subfield into clipboard area

Added:
Ctrl-C:       Copies a line into the clipboard area
Shift-Ctrl-C: Copies current subfield into clipboard area
Ctrl-P:       Pastes the selected item from the clipboard at cursor
Ctrl-I:       Copies the current line and inserts onto a new line below

To test:
Verify all functionality above and confirm it behaves as expected

Note:
Ctrl-v pastes from the system clipboard - codemirror does not have
access and this is why we use our "Clipboard"

For browser cut/paste please use mouse right click or context menus

Ctrl-P can be accessed as print by focusing outside the editor window

Signed-off-by: Alex Sassmannshausen <alex@komputilo.eu>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23626: Add missing TT failure
Kyle M Hall [Wed, 9 Oct 2019 12:28:32 +0000 (08:28 -0400)]
Bug 23626: Add missing TT failure

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23626: [alternate] Default to including all rows
Kyle M Hall [Mon, 7 Oct 2019 16:34:07 +0000 (12:34 -0400)]
Bug 23626: [alternate] Default to including all rows

If a person is fetching all data, it seems most likely that that person wants
to see all the data in the chart. We should default to that behavior.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23626: Only fetch full chart data if requested
Nick [Wed, 2 Oct 2019 09:58:59 +0000 (09:58 +0000)]
Bug 23626: Only fetch full chart data if requested

This patchset prevents the full return of report data unless explicitly requested by the user for charting purposes
Additionally the user is warned if requesting more than 1000 rows of data

To test:
 1 - Create a report that returns over 1000 rows of data
 2 - Run the report
 3 - Note you have two buttons now 'Chart data' and 'Fetch all data for chart'
 4 - Click chart data
 5 - Note the note that you are only charting visible data
 6 - Create the chart and confirm it works
 7 - Close the chart
 8 - Click 'Fetch all data'
 9 - Note the confirm window
10 - Click 'cancel', note there is no change
11 - Repeat and click ok
12 - Fetch all data button is gone
13 - Page to next data, note fetch all does not return
14 - Click 'Chart data'
15 - Note you now have checkbox option to use all data in report
16 - Click it
17 - Create chart
18 - Confirm it works as expected

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23778: Regression: Guarantor entry section no longer has a unique id
Owen Leonard [Tue, 8 Oct 2019 14:18:01 +0000 (14:18 +0000)]
Bug 23778: Regression: Guarantor entry section no longer has a unique id

This patch adds back a fieldset ID which was accidentally removed by Bug
14570:

<fieldset id="memberentry_guarantor" class="rows">

This ID is important if libraries want to customize the patron entry
page to hide the guarantor section.

To test, apply the patch and go to Patrons -> New patron.

Inspect the markup and look at the fieldset labeled "Guarantor
information." It should have the correct ID attribute.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 22927: Do not check an already lost item when marked as withdrawn or damaged
Jonathan Druart [Sat, 8 Jun 2019 20:34:24 +0000 (15:34 -0500)]
Bug 22927: Do not check an already lost item when marked as withdrawn or damaged

Due to how moredetail.pl was written it was hard to know which action
was triggered.

Test plan:
- Set MarkLostItemsAsReturned to "from the items tab of the catalog
module."
- Check an item out to a patron
- Use additem.pl to set that item to a lost status without returning it
- go to moredetail.pl for that item
- mark item as either damaged or withdrawn without interacting with the
lost dropdown
- note that item has not been returned

Note for QA: Maybe we could have just tested if exists $item_changes->{'itemlost'}
to call LostItem

Signed-off-by: Claudie Trégouët <claudie.tregouet@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 22997: Unit test
Fridolin Somers [Fri, 9 Aug 2019 11:51:46 +0000 (13:51 +0200)]
Bug 22997: Unit test

Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 22997: Searching gives no results in auth_finder.pl
Fridolin Somers [Tue, 28 May 2019 13:48:54 +0000 (15:48 +0200)]
Bug 22997: Searching gives no results in auth_finder.pl

During cataloguing of an existing biblio, on an heading field,
the use of tag editor fills authorities finder with existing value :
  Search main heading ($a only)
  Search main heading
Default operator beeing 'contains'.

Actually with Elasticsearch those search give no results.

Example with heading :
200
  $a Casaubon
  $b Isaac
  $f 1559-1614

Call to Elasticsearch :
    "query" : {
        "bool" : {
           "must" : [
              {
             "query_string" : {
                  "query" : "Casaubon*",
                  "default_field" : "heading-main",
                   }
              },
              {
             "query_string" : {
                  "query" : "(Isaac*) AND (1559-1614*)",
                  "default_field" : "heading"
                   }
              }
            ]
         }
      },
    "sort" : [
       {
      "heading__sort.phrase" : "asc"
       }
     ]
  }

Patch adds to "query_string" :
  analyze_wildcard : true.

Test plan :
1) Use Elasticsearch
2) Edit an existing biblio record
3) Use tag editor on a heading
4) Click search => You get correct results
5) Check also search in authorities-home.pl

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 14669: (RM follow-up) Ensure updated include compiles
Martin Renvoize [Wed, 9 Oct 2019 06:28:50 +0000 (07:28 +0100)]
Bug 14669: (RM follow-up) Ensure updated include compiles

The introduction of `options_for_libraries` in the filter-orders include
template requires that we process 'html_helpers' within the file to
ensure it always compiles.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23720: Add div wrapper to search results to make moving cover images easier
Lucas Gass [Wed, 2 Oct 2019 23:54:21 +0000 (23:54 +0000)]
Bug 23720: Add div wrapper to search results to make moving cover images easier

TEST PLAN:

1. Apply this patch and turn on some cover images.
2. Add this CSS: '.bibliocol {display: flex;}.coverimages
   {padding-right:20px;}' to the OPACUserCSS.
3. Notice covers on left.
4. Remove CSS and notice covers should look normal on the right side.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23731: Give staff detail/OPAC detail option to display LOC classification
Lucas Gass [Thu, 3 Oct 2019 06:27:27 +0000 (06:27 +0000)]
Bug 23731: Give staff detail/OPAC detail option to display LOC classification

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23694: (QA follow-up) Add new class for 'by' to intranet XSLT
Katrin Fischer [Mon, 7 Oct 2019 19:27:03 +0000 (21:27 +0200)]
Bug 23694: (QA follow-up) Add new class for 'by' to intranet XSLT

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23694: Author "By" should have its own class
Lucas Gass [Mon, 30 Sep 2019 15:29:05 +0000 (15:29 +0000)]
Bug 23694: Author "By" should have its own class

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23697: DBRev 19.06.00.038
Martin Renvoize [Tue, 8 Oct 2019 13:52:33 +0000 (14:52 +0100)]
Bug 23697: DBRev 19.06.00.038

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23697: (QA follow-up) Fix quotes in database update statement
Katrin Fischer [Mon, 7 Oct 2019 18:59:57 +0000 (18:59 +0000)]
Bug 23697: (QA follow-up) Fix quotes in database update statement

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23697: (QA follow-up) Rename PatronAutocompletion to PatronAutoComplete
Katrin Fischer [Mon, 7 Oct 2019 18:54:29 +0000 (20:54 +0200)]
Bug 23697: (QA follow-up) Rename PatronAutocompletion to PatronAutoComplete

Just a find and replace on the changed system preference name.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23697: (follow-up) Add autocompletion search in patron module
Matthias Meusburger [Fri, 4 Oct 2019 09:16:08 +0000 (11:16 +0200)]
Bug 23697: (follow-up) Add autocompletion search in patron module

 - Rename CircAutocompl system preference to PatronAutocompletion
 - Take this system preference into consideration for patron search

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23697: Add autocompletion search in patron module
Matthias Meusburger [Wed, 2 Oct 2019 12:21:00 +0000 (14:21 +0200)]
Bug 23697: Add autocompletion search in patron module

 Test plan:

  - Apply the patch
  - Go to "Patrons" (members/members-home.pl)
  - Check that autocomplete is enabled for patron search

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 23507: Add ability to show change given on auto-popup fee receipt from FinePaymen...
Kyle M Hall [Mon, 26 Aug 2019 18:33:29 +0000 (14:33 -0400)]
Bug 23507: Add ability to show change given on auto-popup fee receipt from FinePaymentAutoPopup

Some libraries would like to show the amount of change given on print reciepts triggered by FinePaymentAutoPopup
so the patron can verify he or she has recieved the correct amount of change.

1) Apply this patch
2) Edit ACCOUNT_CREDIT slip and add "[% IF change_given %]<h1>CHANGE: [% change_given %]</h1>[% END %]" at the top
3) Enable FinePaymentAutoPopup
4) Make a payment
5) Note the change given is shown on the popup receipt
6) Note the change given is *not* shown on subsequent prints of the same receipt using the "print" button for the payment

Signed-off-by: Kyle Hall <kyle@bywatersolutions.com>
Signed-off-by: Hasina Akhte <hasinaa@pascolibraries.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 21701: DBRev 19.06.00.037
Martin Renvoize [Tue, 8 Oct 2019 13:45:03 +0000 (14:45 +0100)]
Bug 21701: DBRev 19.06.00.037

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 21701: Fix up db update
Kyle M Hall [Mon, 7 Oct 2019 13:22:03 +0000 (09:22 -0400)]
Bug 21701: Fix up db update

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 21701: Have PayPal optionally return to originating OPAC url rather than OPACBaseURL
David Kuhn [Thu, 8 Nov 2018 16:58:37 +0000 (08:58 -0800)]
Bug 21701: Have PayPal optionally return to originating OPAC url rather than OPACBaseURL

This enhancement will allow a library to choose whether to use the alias of the
current OPAC or the value of OPACBaseURL as the return url when making payments
via PayPal.

To test:
Note: you need to have PayPal enabled on your system (either Sandbox mode or
Live) and be using an alias URL for your OPAC.

1. Apply the patch.
2. With the option "PayPalReturnURL" set to "OPACBaseURL", log into a card via
the OPAC and start the process to pay in PayPal (you can either complete the
payment or cancel from the PayPal page). When you are returned to the OPAC, the
domain will be the value of OPACBaseURL.
3. With the option "PayPalReturnURL" set to "OPAC's alias", repeat the above
sequence to make a payment in PayPal. When you are returned to the OPAC, the
domain will be your current alias.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 13937: Add SRU tests
Ere Maijala [Tue, 23 Jul 2019 12:14:51 +0000 (15:14 +0300)]
Bug 13937: Add SRU tests

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 13937: Switch from GetItem() to Koha::Items->find()
Ere Maijala [Fri, 8 Mar 2019 09:40:54 +0000 (11:40 +0200)]
Bug 13937: Switch from GetItem() to Koha::Items->find()

Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 13937: Fix the daemon log path.
Olli-Antti Kivilahti [Thu, 14 Feb 2019 13:08:54 +0000 (15:08 +0200)]
Bug 13937: Fix the daemon log path.

directory _LOG_DIR_/logs does't exists.

All other log4perl -logs are out to _LOG_DIR_

Thank you for the good work Ere!

Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 13937: Add support for Z39.50 responder to the Debian scripts
Ere Maijala [Fri, 11 Jan 2019 09:27:56 +0000 (11:27 +0200)]
Bug 13937: Add support for Z39.50 responder to the Debian scripts

Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 13937: Fix RPN conversion
Ere Maijala [Tue, 15 Jan 2019 11:54:17 +0000 (13:54 +0200)]
Bug 13937: Fix RPN conversion

Fixes handling of parenthesis and removes unused quote handling.

Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 13937: Add tests for search and retrieval
Ere Maijala [Tue, 27 Nov 2018 11:40:44 +0000 (13:40 +0200)]
Bug 13937: Add tests for search and retrieval

Sponsored-by: National Library of Finland
Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 13937: Add support for SRU and Elasticsearch
Ere Maijala [Thu, 22 Nov 2018 09:20:01 +0000 (11:20 +0200)]
Bug 13937: Add support for SRU and Elasticsearch

Splits Session to GenericSession and ZebraSession where Generic supports any
search backend via the SearchEngine classes and Zebra maintains the direct
channel to the Zebra server.

Adds config files required for mapping BIB-1 attributes to Koha search fields
and SRU indexes to BIB-1 attributes.

Adds PODs.

Sponsored-by: National Library of Finland
Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 13937: Fix issues found in QA
Ere Maijala [Wed, 21 Nov 2018 14:20:33 +0000 (16:20 +0200)]
Bug 13937: Fix issues found in QA

Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 months agoBug 13937: (follow-up) Pass through yaz switches and don't ignore case
Nick Clemens [Tue, 14 Nov 2017 12:29:52 +0000 (12:29 +0000)]
Bug 13937: (follow-up) Pass through yaz switches and don't ignore case

Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>