Bug 15256: Fix items table display on the detail page
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 25 Nov 2015 17:08:43 +0000 (17:08 +0000)
committerFrédéric Demians <f.demians@tamil.fr>
Mon, 7 Dec 2015 12:52:29 +0000 (13:52 +0100)
commita6d5c091df0b15e00719d5a14f42ac7fd4f61e5b
tree8b091961034b979c958644fe173db7fa22177665
parent774746597678bf176f4d067e90e5d40db4e942b8
Bug 15256: Fix items table display on the detail page

Bug 14966 fixed a bug but introduced another one: With
IndependentBranches set to 'prevent', if the librarian (without the
superlibrarian permission) can edit items but not all, the table is
broken.  DataTables raises the following warning: "DataTables warning:
table id=DataTables_Table_1 - Requested unknown parameter '8' for row0."
And does not display correctly.

Test plan:
1/ Create a biblio record with 1+ items located in different places.
2/ Create/use a patron with the permission to edit items
3/ Set the IndependentBranches pref to 'prevent'
4/ With this patron logged in, go on the record detail page.
Without this patch, the display is broken (only 1 edit link and 1 td
missing, DataTables raises a warning).
With this patch, the display is correct.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  See the warning, and the broken table. Solved by this patch.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit d456acc7bfd2507ac7eaaf32bd6da1f023655886)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit ed13f4fe200352460b62376b01ba48d3ba51ae80)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt