wip/koha-catalyst.git
8 years agobug 7821 follow-up: escaping {} in regexp master
Paul Poulain [Thu, 29 Mar 2012 15:23:50 +0000 (17:23 +0200)]
bug 7821 follow-up: escaping {} in regexp

8 years agoBug 7821 - {langcode} will be replaced with current interface language
Dobrica Pavlinusic [Sat, 24 Mar 2012 16:47:57 +0000 (17:47 +0100)]
Bug 7821 - {langcode} will be replaced with current interface language

This makes bug 4032 support multi-language Koha installation which is important
for some of Koha users.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
1) After update XSLT system preferences are set to 'default'. All views
(OPAC and staff, results and detail page) work and switching languages
selects the correct translated file.

2) Leaving empty works and normal views are used.

3) Putting in a single URL without placeholder works.

4) Putting in a URL with placeholder works. Created local directories
have to match the language codes.

NOTE: In order to make the URLs and patchs work, the Utils file needs to be
copied too.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 4032 follow-up: removing ` in syspref
Paul Poulain [Thu, 29 Mar 2012 14:59:34 +0000 (16:59 +0200)]
Bug 4032 follow-up: removing ` in syspref

8 years agoBug 4032 follow-up: DBRev number
Paul Poulain [Thu, 29 Mar 2012 14:59:13 +0000 (16:59 +0200)]
Bug 4032 follow-up: DBRev number

8 years agoBug 4032 XSLT systempreference takes a path to file rather than YesNo
Stéphane Delaune [Wed, 8 Feb 2012 11:12:16 +0000 (12:12 +0100)]
Bug 4032 XSLT systempreference takes a path to file rather than YesNo

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
I am signing it off because it doesn't break anything and I will report
another bug for language issues described in my previous comment.

Removed MySQLism backquotes

8 years agoBug 7729 : svc/bib: support appending ?items=1 to the URL to fetch or modify items
MJ Ray [Thu, 22 Mar 2012 16:40:39 +0000 (16:40 +0000)]
Bug 7729 : svc/bib: support appending ?items=1 to the URL to fetch or modify items

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7835 - submit and cancel buttons on diff lines on notices
Owen Leonard [Wed, 28 Mar 2012 14:00:18 +0000 (10:00 -0400)]
Bug 7835 - submit and cancel buttons on diff lines on notices

Changing markup of cancel button to match standard Koha pattern.
Also correcting some invalid markup:
 - unescaped ampersands
 - invalid form action attributes
 - improperly nested elements in <ol>
 - invalid "for" on label

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agobug 7641 follow-up: remove some unconditionnal warns
Paul Poulain [Thu, 29 Mar 2012 13:10:34 +0000 (15:10 +0200)]
bug 7641 follow-up: remove some unconditionnal warns

8 years agobug 7641 follow-up: activate use strict (see coding guidelines)
Paul Poulain [Thu, 29 Mar 2012 13:10:16 +0000 (15:10 +0200)]
bug 7641 follow-up: activate use strict (see coding guidelines)

8 years agobug 7641 follow-up DBRev number
Paul Poulain [Thu, 29 Mar 2012 13:09:43 +0000 (15:09 +0200)]
bug 7641 follow-up DBRev number

8 years agoBug 7641: Suspend Reserves
Kyle M Hall [Thu, 1 Mar 2012 16:57:58 +0000 (11:57 -0500)]
Bug 7641: Suspend Reserves

Adds the ability to suspend reserves. The new system preference
AutoResumeSuspendedHolds enables the ability to set a date for
a suspended hold to automatically be resumed.

When a hold is suspended, it will continue to increase in priority
as the holds above it are fulfilled. If the first holds in line
to be filled are suspended, the first non-suspened hold in line
will be used when an item can fulfill a hold that has been placed.

http://bugs.koha-community.org/show_bug.cgi?id=7641
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Tested with the preference on and off:
1. placed several holds in the staff client
2. suspended some with a date
3. suspended some without a date
4. triggered hold message by checking in for hold with suspensions
5. the suspended hold was skipped as it should be
6. tested suspending holds in the OPAC w and w/out dates
7. ran the cron to clear suspensions with dates

All the above tests worked as expected. Signing off.

8 years agoBug 7701: Error when sending serial alerts
Jared Camins-Esakov [Sun, 11 Mar 2012 16:13:15 +0000 (12:13 -0400)]
Bug 7701: Error when sending serial alerts

Probably due to bug 6875, C4::Letters is no longer used by C4::Serials, so that
when SendAlerts is called (exactly when this happens is a mystery to me), you
will get an error. Adding a "require C4::Letters;" and prefixing SendAlerts to
C4::Letters:: should fix it.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch fixes the perl error. Steps to reproduce:

1) Create a subscription and set patron notification to "Routling list" -
this is necessary, so that a link to email notifications shows up in the OPAC.
2) Search for the serial record in the OPAC and click on the more details
view from the subscriptions tab. Subscribe to email notifications.
3) Go back into the serials module and receive and issue for the serial.
Before the patch a nasty perl error will be shown, after the patch
receiving works.

I couldn't confirm that the email was sent out with my setup, but this patch
certainly fixes serial receive.

[Update 2011-02-29] Fixed the typo and retested. Looks good, but couldn't check
if the mail was actually sent.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7617: Sort authority results by authid
Jared Camins-Esakov [Sun, 11 Mar 2012 17:48:43 +0000 (13:48 -0400)]
Bug 7617: Sort authority results by authid

Add the option of sorting authority search results by authid, and instruct the
FirstMatch and LastMatch linkers to use that sort order rather than the default
search order.

To test:
1. Install new Zebra authorities config
    etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml,
    etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl,
    etc/zebradb/marc_defs/marc21/authorities/record.abs, and
    etc/zebradb/marc_defs/unimarc/authorities/record.abs
2. Reindex authorities in Zebra
3. Set LinkerModule to FirstMatch or LastMatch
4. Add two identical authority records, and a bib record with a heading that
   matches them
5. Run misc/link_bibs_to_authorities.pl on that record
6. Confirm that the authid that's been inserted into subfield $9 of that
   heading is the first, if you selected FirstMatch, or last if you selected
   LastMatch

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I followed the test plan and checked that for "Last match" and "First match"
the correct authority was selected and linked to the record.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7537 - Implement TraceCompleteSubfields, TraceSubjectSubdivisions and UseICU...
Magnus Enger [Thu, 16 Feb 2012 11:07:35 +0000 (12:07 +0100)]
Bug 7537 - Implement TraceCompleteSubfields, TraceSubjectSubdivisions and UseICU for NORMARC XSLT

IMPORTANT! This patch relies on the patch for Bug 7092, which is now pushed to
master.

As the title says, this patch implements TraceCompleteSubfields,
TraceSubjectSubdivisions and UseICU for NORMARC XSLT, both for the OPAC
and the Intranet. This affects how clickable subject-links are constructed.

To make this work the indexing of MARC fields in the 600 range is changed
to include "Subject:p" in several new places.

To test:

Find a record with a "complex" subject, like "Internet -- Law and legislation".
MARC21 and NORMARC are very similar in how they handle subjects, so testing
on a MARC21 database should be OK. (Changes in indexing reflect changes already
made to the MARC21 indexing.)

Make sure you have these syspref settings:
- marcflavour = NORMARC
- XSLTDetailsDisplay = using XSLT stylesheets
- OPACXSLTDetailsDisplay = using XSLT stylesheets

(Ideally, testing should be done on a real NORMARC setup, but since the changes
to indexing only reflect how it's already done in MARC21, I think testing
on a MARC21 installation with marcflavour = NORMARC should be OK.)

Now try the different combinations of TraceCompleteSubfields,
TraceSubjectSubdivisions and UseICU, and check the format of the
clickable links, both in the OPAC and staff client. Here's what you should
be seeing:

1.
TraceCompleteSubfields   = Don't force
TraceSubjectSubdivisions = Don't include
UseICU = Not using
  opac-search.pl?q=su:"Internet"
UseICU = Using
  opac-search.pl?q=su:{Internet}

2.
TraceCompleteSubfields   = Force
TraceSubjectSubdivisions = Don't include
UseICU = Not using
  opac-search.pl?q=su,complete-subfield:"Internet"
UseICU = Using
  opac-search.pl?q=su,complete-subfield:{Internet}

3.
TraceCompleteSubfields   = Don't force
TraceSubjectSubdivisions = Include
UseICU = Not using
  opac-search.pl?q=(su:"Internet") AND (su:"Law and legislation.")
UseICU = Using
  opac-search.pl?q=(su:{Internet}) AND (su:{Law and legislation.})

4.
TraceCompleteSubfields   = Force
TraceSubjectSubdivisions = Include
UseICU = Not using
  opac-search.pl?q=(su,complete-subfield:"Internet") AND (su,complete-subfield:"Law and legislation.")
UseICU = Using
  opac-search.pl?q=(su,complete-subfield:{Internet}) AND (su,complete-subfield:{Law and legislation.})

UPDATE 2012-03-23
- Change the syspref TracingQuotes to UseICU, see bug 7092
- Change boolean operator from "and" to "AND", see bug 7695

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Note: UseControlnumber must be turned off.

1) Works.
2) Works.
3) Works.
4) Works.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7436 - Set itemtypes.rentalcharge = 0 in sample data for nb-NO and de-DE
Magnus Enger [Mon, 26 Mar 2012 20:05:45 +0000 (22:05 +0200)]
Bug 7436 - Set itemtypes.rentalcharge = 0 in sample data for nb-NO and de-DE

Set the rentalcharge = 0 for sample itemtypes (except Music for nb-NO).

To test:
Run through the web-installer for nb-NO and de-DE, and check that
itemtypes are displayed correctly for each language.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>.
Note: You have to install the language first in order to be able
to select it in the web installer. There was a problem
in the po files for nb-NO that kept all files from being created
correctly. I fixed the po file and did an installation with all sample
files. There is a problem with z3950servers.sql that is not caused
by this patch:
z3950servers.sql
ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 1

Web installer for de-DE ran without problems on the sample files.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 4819: Add ids to OPAC detail page
Katrin Fischer [Thu, 22 Mar 2012 15:34:28 +0000 (16:34 +0100)]
Bug 4819: Add ids to OPAC detail page

Patch adds an unique id to every item tab and
to every column in the items table on the holdings tab.

http://bugs.koha-community.org/show_bug.cgi?id=4819
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7485 - Cannot edit barcode on Fast Add
Kyle M Hall [Tue, 27 Mar 2012 16:01:33 +0000 (12:01 -0400)]
Bug 7485 - Cannot edit barcode on Fast Add

Simple fix, a special case was added for the fast add framework
in the case that an item was being checked out that had not been
catalogued. In that case, the barcode was being passed as a parameter
through addbiblio.pl to additem.pl.

This barcode param was used to overwrite the existing value, so if
no barcode param was passed ( which is only the case with fast adds
from the circ screen ), the barcode field would appear empty in the
items editor.

This commit causes that special case code to check for an existing
barcode value first, and only use the cgi parameter 'branch' in the
case that there is no existing barcode value.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Editing barcode of fast added item now works. Passes t xt

Recommend this for 3.6 release.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agobug 6858 follow-up indenting with spaces
Paul Poulain [Wed, 28 Mar 2012 16:10:40 +0000 (18:10 +0200)]
bug 6858 follow-up indenting with spaces

8 years agoBug 6858: Adds staticfines.pl for static fines processing
Matthias Meusburger [Wed, 23 Mar 2011 15:19:07 +0000 (16:19 +0100)]
Bug 6858: Adds staticfines.pl for static fines processing

Add a tool to calculate static fine. For example, 7 days left = 1€ fixed fine

Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_6199'
Paul Poulain [Wed, 28 Mar 2012 15:54:55 +0000 (17:54 +0200)]
Merge remote-tracking branch 'origin/new/bug_6199'

8 years agoBug 6199 - allow bulkmarkimport.pl to remove duplicate barcodes
Robin Sheat [Mon, 18 Apr 2011 07:42:58 +0000 (19:42 +1200)]
Bug 6199 - allow bulkmarkimport.pl to remove duplicate barcodes

This adds the -dedupbarcode option that allows bulkmarkimport to erase
a barcode but keep the item of any items it finds with duplicate
barcodes.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7829 - reports/ remove all exit(1) for plack
Dobrica Pavlinusic [Mon, 26 Mar 2012 14:49:12 +0000 (16:49 +0200)]
Bug 7829 - reports/ remove all exit(1) for plack

In Bug 7772 Ian correctly noted that reports have exit(1) all over the place.
This is left over from old code, and this patch changes them to exit(0).

I decided to use plain exit as opposed to explicit exit(0) since it produces
cleaner code, but I'm welcoming suggestion on this.

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7823: [SIGNED-OFF] Ergonomy improvements: Rename button to "New patron"
Katrin Fischer [Sat, 24 Mar 2012 10:40:16 +0000 (11:40 +0100)]
Bug 7823: [SIGNED-OFF] Ergonomy improvements: Rename button to "New patron"

"New" for adding new patrons is hard to translate and is not consistent
with the naming of similar buttons in other parts of Koha.

Patch changes "New" to "New patron".

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Patch does what it says and ii makes sense to change the wording.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7695 - Change boolean operator from "and" to "AND"
Magnus Enger [Tue, 20 Mar 2012 12:45:48 +0000 (13:45 +0100)]
Bug 7695 - Change boolean operator from "and" to "AND"

When XSLTDetailsDisplay/OPACXSLTDetailsDisplay = on and
TraceSubjectSubdivisions = Include, subject sudivisions are
combined with the boolean operator "and". Currently, this word is
translated along with other occurrences of the same word, resulting
in a false "no records found" for users of non-English templates.

This patch replaces "and" with "AND" which should have no effect on
searching (since Zebra is case-insensitive in this regard) but will
make the boolean operator stand out from other uses of "and" in
translations.

TraceSubjectSubdivisions is currently only implemented in MARC21,
so UNIMARC and NORMARC is not affected.

To test:

XSLTDetailsDisplay/OPACXSLTDetailsDisplay = using XSLT
TraceSubjectSubdivisions = Include
marcflavour = MARC21

Find a record with a clickable subject that includes one or more
subdivisions and check that the subdivisions are combined with
"AND", not "and". Check that you get the expected result when
clicking on the subject.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Easy to test and works as advertised.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7837 - nb-NO z3950servers.sql misses column names
Magnus Enger [Tue, 27 Mar 2012 20:35:35 +0000 (22:35 +0200)]
Bug 7837 - nb-NO z3950servers.sql misses column names

Fix installer/data/mysql/nb-NO/2-Valgfritt/z3950servers.sql so it
includes column names.

To test:
- Install the nb-NO language
- Run through the web installer, and make sure to select the optional
  ("Valgfritt") z3950servers.sql file
- Check there are no errors
- Check that the Z39.50 errors are displayed OK in
  Home › Administration › Z39.50 Servers

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Web installer runs without any errors now and I checked that
the Z39.50 servers were imported correctly and can be edited.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7727 - NORMARC XSLT OPAC detail view shows double tabs
Magnus Enger [Fri, 23 Mar 2012 14:59:59 +0000 (15:59 +0100)]
Bug 7727 - NORMARC XSLT OPAC detail view shows double tabs

With marcflavour = NORMARC and OPACXSLTDetailsDisplay = Using XSLT,
the detail view displays a double set of tabs for Normal/MARC/ISBD
views, one above the title and one below.

To test:
marcflavour = NORMARC
OPACXSLTDetailsDisplay = Using XSLT

Since the contents of the recaords do not matter here, the patch
can be tested on MARC records of any flavour.

- Check that double tabs are shown
- Apply the patch
- Check that only the set of tabs at the top is shown

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 5354 follow-up : dealing with a wrong regexp
Paul Poulain [Wed, 28 Mar 2012 14:17:45 +0000 (16:17 +0200)]
Bug 5354 follow-up : dealing with a wrong regexp

I could not reproduce the working behaviour when I found that the tiny follow-up introduced a bug
| being a reserved char in regexp, split '|' is not splitting on '|' ! we must write '\|' !

8 years agobug 5354 follow-up DBRev number
Paul Poulain [Wed, 28 Mar 2012 14:15:34 +0000 (16:15 +0200)]
bug 5354 follow-up DBRev number

8 years agoBug 5354: Followup. Change separator
Jonathan Druart [Fri, 23 Mar 2012 16:05:46 +0000 (17:05 +0100)]
Bug 5354: Followup. Change separator

8 years agoBug 5354: Partial duplication of a subscription
Jonathan Druart [Thu, 8 Mar 2012 09:45:32 +0000 (10:45 +0100)]
Bug 5354: Partial duplication of a subscription

A new syspref (SubscriptionDuplicateDroppedInput) contains the list of fields to
duplicate when duplicating a subscription. The library will be able to
define that, for example, the internal note should not be duplicated

Test plan:
On the detail subscription page, click Edit > Edit as New (Duplicate):
All the information must be copied from the original subscription.

Fill the syspref SubscriptionDuplicateDroppedInput with a list of fields
you don't want to be duplicated (e.g. location;notes;branchcode).

Repeat the duplicate action. Normally, information for these fields are
not copied.

Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>
8 years agoBug 7786 Adding More Lists-option to the Add-to combo of staff search results
Marcel de Rooy [Thu, 22 Mar 2012 06:35:37 +0000 (07:35 +0100)]
Bug 7786 Adding More Lists-option to the Add-to combo of staff search results

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 5549 : Fixing the test to only run if the test data exists
Chris Cormack [Thu, 22 Mar 2012 19:32:38 +0000 (08:32 +1300)]
Bug 5549 : Fixing the test to only run if the test data exists

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
test passes after the patch. Win.

8 years agoBug 7775 - tools/upload-file.pl: scoping for plack
Dobrica Pavlinusic [Wed, 21 Mar 2012 10:47:49 +0000 (11:47 +0100)]
Bug 7775 - tools/upload-file.pl: scoping for plack

$uploaded_file is now scoped with our, and we set correct filename

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7799 - admin/marctagstructure.pl plack scoping
Dobrica Pavlinusic [Thu, 22 Mar 2012 13:05:22 +0000 (14:05 +0100)]
Bug 7799 - admin/marctagstructure.pl plack scoping

duplicate_framework needs $dbh so we get it from C4::Context

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7773 - serials/subscription-add.pl scope for plack
Dobrica Pavlinusic [Wed, 21 Mar 2012 10:28:54 +0000 (11:28 +0100)]
Bug 7773 - serials/subscription-add.pl scope for plack

This fixes scope of $query and $nextexpected

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7801 - admin/patron-attr-types.pl plack scoping
Dobrica Pavlinusic [Thu, 22 Mar 2012 13:13:21 +0000 (14:13 +0100)]
Bug 7801 - admin/patron-attr-types.pl plack scoping

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7800 - admin/matching-rules.pl plack scoping
Dobrica Pavlinusic [Thu, 22 Mar 2012 13:08:47 +0000 (14:08 +0100)]
Bug 7800 - admin/matching-rules.pl plack scoping

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7790 - tools/manage-marc-import.pl breaks with plack
Dobrica Pavlinusic [Thu, 22 Mar 2012 10:26:56 +0000 (11:26 +0100)]
Bug 7790 - tools/manage-marc-import.pl breaks with plack

transfer $template to add_matcher_list for correct scoping
and score $dbh and $runinbackground with our

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7798 - admin/item_circulation_alerts.pl plack scoping
Dobrica Pavlinusic [Thu, 22 Mar 2012 12:58:29 +0000 (13:58 +0100)]
Bug 7798 - admin/item_circulation_alerts.pl plack scoping

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7795 - admin/authorised_values.pl breaks with plack
Dobrica Pavlinusic [Thu, 22 Mar 2012 11:01:06 +0000 (12:01 +0100)]
Bug 7795 - admin/authorised_values.pl breaks with plack

scoping fixes for Variable "*" is not available errors

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agobug 7470 follow-up, fix POD doc
Paul Poulain [Mon, 26 Mar 2012 15:53:28 +0000 (17:53 +0200)]
bug 7470 follow-up, fix POD doc

8 years agoBug 7797 - admin/currency.pl needs scoping for plack
Dobrica Pavlinusic [Thu, 22 Mar 2012 11:53:13 +0000 (12:53 +0100)]
Bug 7797 - admin/currency.pl needs scoping for plack

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7772 - reports/bor_issues_top.pl: we need to exit(0) for plack
Dobrica Pavlinusic [Wed, 21 Mar 2012 10:23:20 +0000 (11:23 +0100)]
Bug 7772 - reports/bor_issues_top.pl: we need to exit(0) for plack

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7743 followup: fix use of removed formattedwaitingdate param in opac-user.tt
Ian Walls [Sun, 25 Mar 2012 22:20:58 +0000 (18:20 -0400)]
Bug 7743 followup: fix use of removed formattedwaitingdate param in opac-user.tt

Replaces formattedwaitingdate with just waitingdate, since no longer create and export
that template variable

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7743: Update opac-readingrecord.pl to use KohaDates TT plugin
Julian Maurice [Mon, 19 Mar 2012 14:18:27 +0000 (15:18 +0100)]
Bug 7743: Update opac-readingrecord.pl to use KohaDates TT plugin

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
fixed conflict

8 years agoBug 7743: Update opac-showreviews.pl to use KohaDates TT plugin
Julian Maurice [Mon, 19 Mar 2012 14:05:24 +0000 (15:05 +0100)]
Bug 7743: Update opac-showreviews.pl to use KohaDates TT plugin

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
8 years agoBug 7743: Update opac-userupdate.pl to use KohaDates TT plugin
Julian Maurice [Mon, 19 Mar 2012 13:57:51 +0000 (14:57 +0100)]
Bug 7743: Update opac-userupdate.pl to use KohaDates TT plugin

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
8 years agoBug 7743: Update sco/sco-main.pl to use KohaDates TT plugin
Julian Maurice [Mon, 19 Mar 2012 13:49:36 +0000 (14:49 +0100)]
Bug 7743: Update sco/sco-main.pl to use KohaDates TT plugin

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
8 years agoBug 7743: Update opac-detail.pl to use KohaDates TT plugin
Julian Maurice [Mon, 19 Mar 2012 13:43:47 +0000 (14:43 +0100)]
Bug 7743: Update opac-detail.pl to use KohaDates TT plugin

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
fixed conflict

8 years agoBug 7743: Update opac-user.pl to use KohaDates TT plugin
Julian Maurice [Mon, 19 Mar 2012 13:28:03 +0000 (14:28 +0100)]
Bug 7743: Update opac-user.pl to use KohaDates TT plugin

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
fixed conflict

8 years agoBug 7743: Update opac-tags.pl to use KohaDates TT plugin
Julian Maurice [Mon, 19 Mar 2012 13:01:14 +0000 (14:01 +0100)]
Bug 7743: Update opac-tags.pl to use KohaDates TT plugin

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
8 years agoBug 7743: Update opac-account.pl to use KohaDates TT plugin
Julian Maurice [Mon, 19 Mar 2012 11:35:41 +0000 (12:35 +0100)]
Bug 7743: Update opac-account.pl to use KohaDates TT plugin

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
8 years agoMerge remote-tracking branch 'origin/new/bug_7760'
Paul Poulain [Mon, 26 Mar 2012 14:21:31 +0000 (16:21 +0200)]
Merge remote-tracking branch 'origin/new/bug_7760'

8 years agoBug 7760: More ids and classes for the staff interface
Katrin Fischer [Fri, 23 Mar 2012 08:59:19 +0000 (09:59 +0100)]
Bug 7760: More ids and classes for the staff interface

Owen pointed out that I missed 3 files - this corrects my omission.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 7761 - cleaning up empty declarations from staff-global.css
Gaetan Boisson [Tue, 20 Mar 2012 16:03:14 +0000 (17:03 +0100)]
Bug 7761 - cleaning up empty declarations from staff-global.css

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7451 - PrepareItemrecordDisplay missing $subfield_data{id} which breaks AJAX...
Dobrica Pavlinusic [Thu, 22 Mar 2012 09:04:50 +0000 (10:04 +0100)]
Bug 7451 - PrepareItemrecordDisplay missing $subfield_data{id} which breaks AJAX value_builders

In current version of code, it gets initialized too late, so it produces
unitialized warnings for hidden fields (which is non-fatal) and breaks
generated JavaScript for AJAX value_builders (which is fatal)

This bug was introduced in ticket 6106 which is modification of 5955
which didn't have this particular problem.

Since then, this code moved to C4::Items because of de-nesting patches.

Test scenario:
1. define 952$i plugin: stocknumberam123.pl (this is ajax value_builder)
2. go to one of following pages and verify that plugin works:
acqui/addorderiso2709.pl
acqui/neworderempty.pl
acqui/orderreceive.pl
serials/serials-edit.pl

For stocknumberam123.pl plugin to work, you have to have at least
one item with stocknumber in format which this plugin expects:
capital letters, space, some number

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, thanks for the great test plan.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7783: Show private shelves in opac when deleting non-empty private list from...
Marcel de Rooy [Wed, 21 Mar 2012 15:29:57 +0000 (16:29 +0100)]
Bug 7783: Show private shelves in opac when deleting non-empty private list from shelf view
Signed-off-by: Mathilde Formery <mathilde.formery@ville-nimes.fr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7702: [SIGNED-OFF] MARC21 heading tests should not run under UNIMARC
Jared Camins-Esakov [Sun, 11 Mar 2012 16:57:11 +0000 (12:57 -0400)]
Bug 7702: [SIGNED-OFF] MARC21 heading tests should not run under UNIMARC

Skip the MARC21-specific tests in t/Heading_MARC21.t if the marcflavour is
UNIMARC.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
I set marcflavour = UNIMARC for testing this.
Before the patch, t/Heading_MARC21.t fails. After the patch it
succeeds.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7470 follow-up
Paul Poulain [Mon, 26 Mar 2012 13:00:47 +0000 (15:00 +0200)]
Bug 7470 follow-up

(patch from Jonathan, I don't understand why it doesn't apply cleanly, so I've rewritten it)

8 years agoBug 7470 follow-up DBRev + removing `
Paul Poulain [Mon, 26 Mar 2012 12:51:43 +0000 (14:51 +0200)]
Bug 7470 follow-up DBRev + removing `

8 years agoBug 7470: Babeltheque integration
Jonathan Druart [Fri, 2 Mar 2012 12:59:44 +0000 (13:59 +0100)]
Bug 7470: Babeltheque integration

3 features:
- adds social network information in search results
- adds babeltheque data in opac-detail
- adds social network links in opac-detail too (google+, twitter, mail
  and co.)

8 years agobug 7178 follow-up: typo fix
Paul Poulain [Mon, 26 Mar 2012 12:15:14 +0000 (14:15 +0200)]
bug 7178 follow-up: typo fix

* words lower cased
* removed a space before :

8 years agoBug 7178 follow-up DBRev number
Paul Poulain [Mon, 26 Mar 2012 12:14:31 +0000 (14:14 +0200)]
Bug 7178 follow-up DBRev number

8 years agoBug 7178: Acquisition item creation improvement
Julian Maurice [Thu, 19 Jan 2012 15:59:58 +0000 (16:59 +0100)]
Bug 7178: Acquisition item creation improvement

- Display a unique item block at once

On orderreceive.pl when AcqCreateItem is 'receiving', and on
neworderempty.pl when AcqCreateItem is 'ordering' it displays an
item block with item infos to fill, and a '+' button.
When user clicks on '+', the block is hidden and a list shows up with
the items that will be received. User can then edit or delete items in
the list and click 'Save' to receive items.

- PrepareItemrecordDisplay is now used for cloning block

Previous cloning function was duplicating ids, the side effect is that
plugins didn't work when several items were displayed.
PrepareItemrecordDisplay regenerate the form with new ids

- New system preference UniqueItemFields

Contains a space-separated list of sql column names (of items table).
This syspref is used in two ways:
 - Values corresponding to fields in syspref are not duplicated when
   adding a new item (button 'Add')
 - When saving the form, a check is made on fields in syspref for
   detecting duplicate (in DB and in the form)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests done are noted on the bug report.

2012-03-23: Fixed conflict in updatedatabase.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7780: make silent/verbose flag for translation installing
Paul Poulain [Wed, 21 Mar 2012 15:18:29 +0000 (16:18 +0100)]
Bug 7780: make silent/verbose flag for translation installing

This patch deal with the -v flag that you can put on translate script.
If you run without -v, the process should be silent
if you run with -v, the process should be verbose

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
I've refactored your patch to handle verbosity directly via a translator
attribute, rather than with parameter which has to be send to each object call
method.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agobig 7263 follow-up: DBRev number
Paul Poulain [Mon, 26 Mar 2012 09:00:34 +0000 (11:00 +0200)]
big 7263 follow-up: DBRev number

8 years agoBug 7263 - Determine maximum length of some fields or subfields when cataloguing...
Juan Romay Sieira [Tue, 20 Mar 2012 15:17:27 +0000 (16:17 +0100)]
Bug 7263 - Determine maximum length of some fields or subfields when cataloguing a biblio or an item.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agotiny follow-up: removing ` that are mysqlism
Paul Poulain [Fri, 23 Mar 2012 16:16:55 +0000 (17:16 +0100)]
tiny follow-up: removing ` that are mysqlism

8 years agoBug 6679 : Fixing perlcritic violation
Chris Cormack [Thu, 22 Mar 2012 20:03:43 +0000 (09:03 +1300)]
Bug 6679 : Fixing perlcritic violation

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_7548'
Paul Poulain [Fri, 23 Mar 2012 09:24:19 +0000 (10:24 +0100)]
Merge remote-tracking branch 'origin/new/bug_7548'

8 years agoBug 7548 Fix variable scoping in the template - Rebased
koha [Wed, 29 Feb 2012 22:05:21 +0000 (17:05 -0500)]
Bug 7548 Fix variable scoping in the template - Rebased

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agobug 6140 follow-up: DBRev number
Paul Poulain [Thu, 22 Mar 2012 17:27:02 +0000 (18:27 +0100)]
bug 6140 follow-up: DBRev number

8 years agoBug 6140 - Set a timeout to z3950 servers that could have network problems occasionally
Juan Romay Sieira [Wed, 21 Mar 2012 13:56:54 +0000 (14:56 +0100)]
Bug 6140 - Set a timeout to z3950 servers that could have network problems occasionally

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
8 years agoBug 7779 - tools/letter.pl: scope vars for plack
Dobrica Pavlinusic [Wed, 21 Mar 2012 13:26:02 +0000 (14:26 +0100)]
Bug 7779 - tools/letter.pl: scope vars for plack

Signed-off-by: Alex Arnaud <alex@stephane-E5420>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7760 - Add ids and classes to every staff page to help with customization (report...
Katrin Fischer [Thu, 22 Mar 2012 11:09:59 +0000 (12:09 +0100)]
Bug 7760 - Add ids and classes to every staff page to help with customization (reports, ...)

This is the last one - adding the classes and ids to the report module and
some template files for smaller moduls/functions.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7760 - Add ids and classes to every staff page to help with customization (patron...
Katrin Fischer [Thu, 22 Mar 2012 10:53:48 +0000 (11:53 +0100)]
Bug 7760 - Add ids and classes to every staff page to help with customization (patroncard, labels)

After talking to Owen we decided to use 2 classes for those modules. I decided on:

patroncard: tools, pcard
labels: tools, labels
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 7760 - Add ids and classes to every staff page to help with customization (tools)
Katrin Fischer [Thu, 22 Mar 2012 10:40:09 +0000 (11:40 +0100)]
Bug 7760 - Add ids and classes to every staff page to help with customization (tools)

Prefix for ids and class is 'tools'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoAdd ids and classes to every staff page to help with customization (serials)
Katrin Fischer [Thu, 22 Mar 2012 10:19:45 +0000 (11:19 +0100)]
Add ids and classes to every staff page to help with customization (serials)

http://bugs.koha-community.org/show_bug.cgi?id=7760
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 7760 - Add ids and classes to every staff page to help with customization (patrons)
Katrin Fischer [Thu, 22 Mar 2012 10:12:12 +0000 (11:12 +0100)]
Bug 7760 - Add ids and classes to every staff page to help with customization (patrons)

Class is 'pat' and ids start with 'pat_'.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 7760 - Add ids and classes to every staff page to help with customizaton (lists...
Katrin Fischer [Thu, 22 Mar 2012 10:00:54 +0000 (11:00 +0100)]
Bug 7760 - Add ids and classes to every staff page to help with customizaton (lists, suggestion, z39.50)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 7760 - Add ids and classes to every staff page to help with customizaton (circula...
Katrin Fischer [Wed, 21 Mar 2012 21:45:09 +0000 (22:45 +0100)]
Bug 7760 - Add ids and classes to every staff page to help with customizaton (circulation)

New id: circ_<filename>
New class: circ

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 7760 - Add ids and classes to every staff page to help with customizaton (catalog...
Katrin Fischer [Wed, 21 Mar 2012 21:07:33 +0000 (22:07 +0100)]
Bug 7760 - Add ids and classes to every staff page to help with customizaton (cataloguing)

New ids: cat_<filename>
New class: cat

Exceptions:
moveitem and linkitem are accessible from the catalog pages, so have
been made 'catalog' for styling.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 7760 - Add ids and classes to every staff page to help with customizaton (catalog)
Katrin Fischer [Wed, 21 Mar 2012 15:54:47 +0000 (16:54 +0100)]
Bug 7760 - Add ids and classes to every staff page to help with customizaton (catalog)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 7760: Add ids and classes to every staff page to help with customizaton (batch...
Katrin Fischer [Wed, 21 Mar 2012 15:25:10 +0000 (16:25 +0100)]
Bug 7760: Add ids and classes to every staff page to help with customizaton (batch, error)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 7760: Add ids and classes to every staff page to help with customizaton (cart)
Katrin Fischer [Wed, 21 Mar 2012 15:19:00 +0000 (16:19 +0100)]
Bug 7760: Add ids and classes to every staff page to help with customizaton (cart)

id = cart_<filename>
class = cart

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 7760: Add unique ids and a module class to all administration pages
Katrin Fischer [Tue, 20 Mar 2012 17:00:32 +0000 (18:00 +0100)]
Bug 7760: Add unique ids and a module class to all administration pages

This is the first patch for bug 7760 and touches all pages in administration.
This adds a unique id "admin_<filename>" and a class "admin" to the body tag of
each page in administration.

Note: aqcontract can only be accessed from the acquisition module, so I made it acq
instead of admin.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 7760: Add unique ids and a module class to all authorities pages
Katrin Fischer [Tue, 20 Mar 2012 16:02:41 +0000 (17:02 +0100)]
Bug 7760: Add unique ids and a module class to all authorities pages

This is the first patch for bug 7760 and touches all pages in authorities.
This adds a unique id "auth_<filename>" and a class "auth" to the body tag of
each page in the authorities module.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 7760: Add unique ids and a module class to all acquisitions pages
Katrin Fischer [Tue, 20 Mar 2012 15:41:17 +0000 (16:41 +0100)]
Bug 7760: Add unique ids and a module class to all acquisitions pages

This is the first patch for bug 7760 and touches all pages in acquisitions.
This adds a unique id "acq_<filename>" and a class "acq" to the body tag of
each page in acquisitions.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoSIGNED-OFF Bug 7590 Cataloging authorities search result page is broken
Frédéric Demians [Fri, 24 Feb 2012 07:50:16 +0000 (08:50 +0100)]
SIGNED-OFF Bug 7590 Cataloging authorities search result page is broken

This bug occurs on UNIMARC DB with authorities linked together with TS/TG
relations. To reproduce it:

- Add a new biblio record
- On 610 field, click on the tag editor button to search an authority
- In the Authority search window, enter a large search
- On the result page, for authorities having relations with other terms, in the
  Get it! column, you get a mess of TS/TG relations and not more Choose link.

Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7765 - labels/label-edit-layout.pl: plack $layout scoping
Dobrica Pavlinusic [Tue, 20 Mar 2012 13:24:44 +0000 (14:24 +0100)]
Bug 7765 - labels/label-edit-layout.pl: plack $layout scoping

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7767 - acqui/basketgroup.pl: our $template scoping for plack
Dobrica Pavlinusic [Tue, 20 Mar 2012 13:50:05 +0000 (14:50 +0100)]
Bug 7767 - acqui/basketgroup.pl: our $template scoping for plack

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_7768'
Paul Poulain [Thu, 22 Mar 2012 16:51:14 +0000 (17:51 +0100)]
Merge remote-tracking branch 'origin/new/bug_7768'

8 years agoBug 7768 - acqui/z3950_search.pl: remove sub displayresults to fix plack scoping
Dobrica Pavlinusic [Wed, 21 Mar 2012 09:43:31 +0000 (10:43 +0100)]
Bug 7768 - acqui/z3950_search.pl: remove sub displayresults to fix plack scoping

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agobug 5549: follow-up DBRev number
Paul Poulain [Thu, 22 Mar 2012 16:47:52 +0000 (17:47 +0100)]
bug 5549: follow-up DBRev number

8 years agoMerge remote-tracking branch 'catalyst/merged_5549' into new/bug_5549
Paul Poulain [Thu, 22 Mar 2012 16:34:26 +0000 (17:34 +0100)]
Merge remote-tracking branch 'catalyst/merged_5549' into new/bug_5549

Conflicts:
installer/data/mysql/updatedatabase.pl
members/moremember.pl

8 years agoBug 7737: applies date filters on vendor pages
Adrien Saurat [Thu, 22 Mar 2012 09:20:14 +0000 (10:20 +0100)]
Bug 7737: applies date filters on vendor pages

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7310 follow-up : typo fix lt instead of < in DB version comparison
Paul Poulain [Thu, 22 Mar 2012 15:55:56 +0000 (16:55 +0100)]
Bug 7310 follow-up : typo fix lt instead of < in DB version comparison

8 years agoBug 7769 - members/pay.pl: $template scoping for plack
Dobrica Pavlinusic [Wed, 21 Mar 2012 10:01:39 +0000 (11:01 +0100)]
Bug 7769 - members/pay.pl: $template scoping for plack

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 5841: Routing slip not displaying publication date
Katrin Fischer [Tue, 21 Feb 2012 06:19:54 +0000 (07:19 +0100)]
Bug 5841: Routing slip not displaying publication date

To test:
Compare output of the 2 different links for  printing routing lists.

1) Links in the table of issues on the serial collection page
2) Link following the steps from editing and saving a routing list

Both previews should show the date now.

Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6125: repairs dateaccessioned plugin
Adrien Saurat [Tue, 20 Mar 2012 12:56:56 +0000 (13:56 +0100)]
Bug 6125: repairs dateaccessioned plugin

1/ It now works with neworderempty.pl
2/ The set_to_today function was moved from
additem.tt to dateaccessioned.pl (so it's
available to all pages using the plugin)

Signed-off-by: Julien Sicot <julien.sicot@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>