wip/koha-chris_n.git
11 years agofix for #2440 : acquisition recieve & item creation
Paul POULAIN [Thu, 31 Jul 2008 12:19:51 +0000 (14:19 +0200)]
fix for #2440 : acquisition recieve & item creation

It has to be reintroduced, as some (most in France) libraries don't create
items on recieve, but after "equipment" step.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agobug 2496: add 'edit' link to authority search results
Galen Charlton [Fri, 8 Aug 2008 19:22:59 +0000 (14:22 -0500)]
bug 2496: add 'edit' link to authority search results

When search for an authority record from the bib
record editor, a new link is added to each
authority result to edit the authority record.  This
allows a cataloger to do the following:

1. Start editing a bib record
2. Click on the '...' to select an authorized heading
   for an authority-controlled field.
3. Look at the results in the pop-up window and
   see that an authority record needs correction.
4. Click on the 'edit authority' link.  This allows
   the authority to be revised.  Note that this
   takes place in the popup window, not the originally
   bib editing window.
5. Save the authority record, then close the popup
   window and redo the heading search.

For various reasons, this not a perfect workflow; this
patch is designed to satisfy an immediate requirement
but needs to be reworked in 3.2.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoRemove <br /> from syspref descriptions.
Joe Atzberger [Thu, 7 Aug 2008 16:02:19 +0000 (11:02 -0500)]
Remove <br /> from syspref descriptions.

The template HTML-escapes the descriptions now (as it should).
So we can't make them prettier w/ HTML inserted.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoLink correction (affected only non-js users).
Owen Leonard [Fri, 8 Aug 2008 18:21:06 +0000 (13:21 -0500)]
Link correction (affected only non-js users).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoAdd help text indicating that one should not use stopwords with Zebra.
Ryan Higgins [Fri, 8 Aug 2008 17:28:48 +0000 (12:28 -0500)]
Add help text indicating that one should not use stopwords with Zebra.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoPartial fix for 2446: single word queries that were stopwords
Joshua Ferraro [Fri, 8 Aug 2008 19:09:52 +0000 (14:09 -0500)]
Partial fix for 2446: single word queries that were stopwords
weren't being striped out of the query

11 years agoFix to prevent crash on null dateexpiry.
Joe Atzberger [Fri, 8 Aug 2008 17:15:10 +0000 (12:15 -0500)]
Fix to prevent crash on null dateexpiry.

Error was:
    Usage: Date::Calc::Date_to_Days(year, month, day)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoAdding "New Item" menu option. Jumps to anchor for Add Item form.
Owen Leonard [Fri, 8 Aug 2008 16:06:47 +0000 (11:06 -0500)]
Adding "New Item" menu option. Jumps to anchor for Add Item form.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoChanging tabindex="-1" to tabindex="0". Fixes 2493.
Owen Leonard [Fri, 8 Aug 2008 14:43:44 +0000 (09:43 -0500)]
Changing tabindex="-1" to tabindex="0". Fixes 2493.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoMinor markup correction.
Owen Leonard [Fri, 8 Aug 2008 14:43:34 +0000 (09:43 -0500)]
Minor markup correction.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agokohabug 2458 Disallowing non-SELECT SQL in reports module
Chris Nighswonger [Fri, 8 Aug 2008 13:22:49 +0000 (08:22 -0500)]
kohabug 2458 Disallowing non-SELECT SQL in reports module

This patch enforces SELECT-only SQL in the reports module.
It introduces code to check SQL in two places. The first is
when a save is attempted on a user constructed SQL statement.
If a non-SELECT SQL statement is entered, the user will be
presented with an error message and a button giving the
option of editing the SQL. The second is when any SQL is
executed. If execution of a non-SELECT SQL statement is
attempted, the user is presented with an error message and
instructed to delete that report as the SQL is invalid.

The second check is intended as a safety net as no non-SELECT
SQL should ever be saved.

It may be well to document the proper usage of the direct SQL
entry type report.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoRevert "Add missing to and from email addresses to user and admin EnqueueLetter calls...
Joshua Ferraro [Fri, 8 Aug 2008 15:51:45 +0000 (10:51 -0500)]
Revert "Add missing to and from email addresses to user and admin EnqueueLetter calls, respectively. Add extra level to verbosity."

This reverts commit 67f229cba7395485a22fc0effa67ca4f592408f4.

11 years agoAdd missing to and from email addresses to user and admin EnqueueLetter calls, respec...
Southeastern University [Fri, 8 Aug 2008 01:38:06 +0000 (21:38 -0400)]
Add missing to and from email addresses to user and admin EnqueueLetter calls, respectively. Add extra level to verbosity.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoaddbiblio - HTML validation fix, add type to link
Joe Atzberger [Thu, 7 Aug 2008 22:18:25 +0000 (17:18 -0500)]
addbiblio - HTML validation fix, add type to link

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoauth_finder - HTML validation fixes
Joe Atzberger [Thu, 7 Aug 2008 22:06:41 +0000 (17:06 -0500)]
auth_finder - HTML validation fixes

Missing </tr> and extra </select>

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agokohabug 2427 Correcting C4::Items:: _koha_new_item to populate items.copynumber
Chris Nighswonger [Thu, 7 Aug 2008 21:05:41 +0000 (16:05 -0500)]
kohabug 2427 Correcting C4::Items:: _koha_new_item to populate items.copynumber

The INSERT was missing the copynumber parameter. moredetail.pl was also not setting
the copyvol template variable. This patch corrects these issues so that the copynumber
is both inserted when a new item is created (including during a bulkmarcimport.pl run)
and displayed properly on moredetail.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agokohabug 2448 Correcting Alignment of Column Headers
Chris Nighswonger [Wed, 6 Aug 2008 20:43:51 +0000 (15:43 -0500)]
kohabug 2448 Correcting Alignment of Column Headers

This patch corrects the alignment of the column headers in the overdues list
on the 'Overdue' tab on opac-user.pl It also corrects the template to display
the item type rather than the Koha collection type.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoAdd missing </td> to opac-user.tmpl
Joe Atzberger [Wed, 6 Aug 2008 20:17:51 +0000 (15:17 -0500)]
Add missing </td> to opac-user.tmpl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoMinor change to correct offset problem for Cart popup. Libraries with opacheader...
Owen Leonard [Wed, 6 Aug 2008 19:49:30 +0000 (14:49 -0500)]
Minor change to correct offset problem for Cart popup. Libraries with opacheader markup specified were finding their Cart popup appearing out of place.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBug 2084 [2/2]: Database version 3.00.00.107: adding warnings to three system preferences
Andrew Moore [Wed, 6 Aug 2008 16:14:26 +0000 (11:14 -0500)]
Bug 2084 [2/2]: Database version 3.00.00.107: adding warnings to three system preferences

This patch adds warnings to the OPACShelfBrowser, CataloguingLog, and NoZebra system preferences. Using
them on busy koha installations has proven to be rather resource intensive.

This is considered a stopgap solution. Making these features less resource using to run
would be preferred.

Note to documentation writers: screenshots of these system preferences could be updated, but
no functionality has changed.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBug 2084 [1/2]: adding warning to overdues report
Andrew Moore [Wed, 6 Aug 2008 16:14:25 +0000 (11:14 -0500)]
Bug 2084 [1/2]: adding warning to overdues report

This patch adds a warning to the staff interface on the circulation page
to indicate that the overdues report is resource intensive on large installations.

This is considered a stopgap solution. Ideally, this report should be changed in order
to make it usable even for large installations.

Documentation note: Although no functionality has changed, any screenshots of the
circulation page on the staff interface should be updated.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agobug 2479: allow MARC21 bib 440 to link to authorities
Galen Charlton [Wed, 6 Aug 2008 16:32:15 +0000 (11:32 -0500)]
bug 2479: allow MARC21 bib 440 to link to authorities

Fixed overly-strict interpretation of OCLC practice
that prevented 440 series statement/added entries
from linking to the appropriate series authority
record.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agopartial fix for #2471, (overdue notice sent twice)
Paul POULAIN [Tue, 5 Aug 2008 16:53:29 +0000 (18:53 +0200)]
partial fix for #2471, (overdue notice sent twice)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoReformatting serials item edit screen to eliminate label truncation and give it addit...
Owen Leonard [Wed, 6 Aug 2008 15:35:05 +0000 (10:35 -0500)]
Reformatting serials item edit screen to eliminate label truncation and give it additem-like layout. Also correcting some markup errors, both in the template and in markup generated by Biblio.pm. HDL: I assume this will be superceded at some point by an include, but wasn't sure if that would be in time for 3.0.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agobug 1433: use same bib when adding new subscription from details page
Galen Charlton [Wed, 6 Aug 2008 14:54:42 +0000 (09:54 -0500)]
bug 1433: use same bib when adding new subscription from details page

When viewing the subscription details page of a bib that already
has at least one subscription, clicking on the 'New Subscription'
button in the toolbar will fill in the biblionumber and title
in the new subscription form.

Clicking on the 'New Subscription' button in other context (e.g.,
when viewing the results of a search) will leave the biblionumber
and title fields unpopulated, as there is no specific bib to
use.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoPatron import reform - bug 2287 - expanded error catching and feedback
Joe Atzberger [Wed, 6 Aug 2008 08:44:46 +0000 (03:44 -0500)]
Patron import reform - bug 2287 - expanded error catching and feedback

This incorporates and extends the patch from MJ Ray attached to bug 2287.
Added feedback of up to 25 lines, including for errors at the Text::CSV
parsing level.  This allows feedback for problems than involve encoding.
Added link to download "starter" CSV file (with all the columns).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBug fixing : 2470 Serials forgetting library
Henri-Damien LAURENT [Tue, 5 Aug 2008 14:27:14 +0000 (16:27 +0200)]
Bug fixing : 2470 Serials forgetting library

Using default values for PrepareItemrecordDisplay
It changes Biblio.pm
Adding a hash with default values to PrepareItemrecordDisplay
Usunf that API in Serials.pm and serials-edit.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBug fix : 2361 Location was lost on subscription update
Henri-Damien LAURENT [Wed, 6 Aug 2008 12:59:58 +0000 (14:59 +0200)]
Bug fix : 2361 Location was lost on subscription update

Location is now defaulted to the location of the librarian
When updating subscription, subscription branchcode is taken into account.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agobugfix for #2472
Paul POULAIN [Tue, 5 Aug 2008 16:53:30 +0000 (18:53 +0200)]
bugfix for #2472

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoAdding Email::Date dependancy, requested by MIME::Lite
Paul POULAIN [Tue, 5 Aug 2008 16:53:28 +0000 (18:53 +0200)]
Adding Email::Date dependancy, requested by MIME::Lite

(no bugzilla entry)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agouse alphabetical order to popup the cities
Marc Chantreux [Wed, 6 Aug 2008 09:23:36 +0000 (11:23 +0200)]
use alphabetical order to popup the cities

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agobug 2317: avoid crash when auto-creating authority
Galen Charlton [Wed, 6 Aug 2008 02:16:09 +0000 (21:16 -0500)]
bug 2317: avoid crash when auto-creating authority

If BiblioAddsAuthorities is ON, saving a MARC bib record
in the cataloging editor can create new authority records.
When using MARC21, if one of those authority records
has diacritics in its heading, the save crashes with the
following error:

Wide character in null operation at
/usr/local/share/perl/5.8.8/MARC/Charset/Table.pm line 96

To prevent this, new MARC21 authorities created by
BiblioAddsAuthorities have the Leader/09 set to 'a'.  Note
that this is not currently required for UNIMARC authorities,
as MARC::File::XML->as_xml_record() does not attempt
to transcode UNIMARC records from MARC-8 to UTF-8.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agobug 2473: correct display of items.content
Galen Charlton [Tue, 5 Aug 2008 20:01:42 +0000 (15:01 -0500)]
bug 2473: correct display of items.content

Correct bug in output of overdue notices that has
items.content displaying only the number of columns
in each items.content structure (currently, 4).

Patch inspired by patch submitted by Paul Poulain.

[LL bug 31]

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agobugfix for 2451 : serial recieve & barcode does exist complaint
Paul POULAIN [Tue, 5 Aug 2008 13:10:01 +0000 (15:10 +0200)]
bugfix for 2451 : serial recieve & barcode does exist complaint

If barcode already exists, then return an error.
making some checks on values passed through the code.
Duplicated serialid and subscriptionid are displayed only once.

This manage multiple errors on barcode and displays them.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoRevert "bugfix for 2451 : serial recieve & barcode does exist complaint"
Joshua Ferraro [Tue, 5 Aug 2008 13:12:49 +0000 (08:12 -0500)]
Revert "bugfix for 2451 : serial recieve & barcode does exist complaint"

This reverts commit 23b8da277b0a1aa67f0686aa65a9e0d527a3b26b.

11 years agobug 2411: fix adding new tag to authority framework
Galen Charlton [Mon, 4 Aug 2008 23:50:37 +0000 (18:50 -0500)]
bug 2411: fix adding new tag to authority framework

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoFinal patch for serials planning bugs
Ryan Higgins [Tue, 5 Aug 2008 03:50:01 +0000 (22:50 -0500)]
Final patch for serials planning bugs

This patch resolves bug 1580 and addresses the modification of firstacquidate as per hdl's comments.
I have also removed some useless javascript from subscription-detail, and just reported the number of
irregular issues there (previously  was reporting nothing since the js was broken).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoRename crontab.example
Joe Atzberger [Mon, 4 Aug 2008 14:09:41 +0000 (09:09 -0500)]
Rename crontab.example

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoCorrecting markup for validity.
Owen Leonard [Mon, 4 Aug 2008 18:21:06 +0000 (13:21 -0500)]
Correcting markup for validity.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agobug 2459: fix module depedency error blocking SIP2
Galen Charlton [Mon, 4 Aug 2008 15:15:23 +0000 (10:15 -0500)]
bug 2459: fix module depedency error blocking SIP2

Ror a poorly understood (by me) reason, use of 'use
UNIVERSAL' and 'use C4::Auth' in the SIP2 code is resulting
in a compilation error, thus blocking SIP2 from working.

The error (prior to this patch) could be reproduced as follows:

cd C4/SIP
perl -I. -wc Sip/MsgType.pm
"get_session" is not exported by the C4::Auth module
Can't continue after import errors at /home/gmc/koha/dev/C4/VirtualShelves.pm
line 51
BEGIN failed--compilation aborted at /home/gmc/koha/dev/C4/VirtualShelves.pm
line 51.
Compilation failed in require at /home/gmc/koha/dev/C4/Auth.pm line 34.
BEGIN failed--compilation aborted at /home/gmc/koha/dev/C4/Auth.pm line 34.
Compilation failed in require at Sip/MsgType.pm line 21.
BEGIN failed--compilation aborted at Sip/MsgType.pm line 21.

or more minimally

perl -ce 'use UNIVERSAL; use C4::Auth;'

This patch works around the problem by making C4::Auth
and C4::VirtualShelves not import any symbols
from each other.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agokohabug 2457 Minor patch to correct GD
Chris Nighswonger [Mon, 4 Aug 2008 15:15:22 +0000 (10:15 -0500)]
kohabug 2457 Minor patch to correct GD

version number

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agokohabug 2456 Moving certain C4::VirtualShelves.pm subs from EXPORT
Chris Nighswonger [Mon, 4 Aug 2008 15:15:21 +0000 (10:15 -0500)]
kohabug 2456 Moving certain C4::VirtualShelves.pm subs from EXPORT

to EXPORT_OK and correcting associated syntax

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agokohabug 2437 Corrects LIMIT offset algorithm
Chris Nighswonger [Mon, 4 Aug 2008 15:15:20 +0000 (10:15 -0500)]
kohabug 2437 Corrects LIMIT offset algorithm

Because of a miscalculation in the offset algorithm, the LIMIT offset creeps
backwards by a magnitude for every page beyond page two. This patch corrects
the algorithm to behave as expected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agokohabug 2417 Removing hardcoded query limit from reports
Chris Nighswonger [Mon, 4 Aug 2008 15:15:19 +0000 (10:15 -0500)]
kohabug 2417 Removing hardcoded query limit from reports

This patch removes a hardcoded 'LIMIT 20' which was added to all report queries
thus limiting all reports to only the first twenty rows of applicable data. In
its place this patch introduces code to paginate through all applicable data,
regardless of how many rows are available. The code will also honor any user
defined 'LIMIT' in reports based on SQL entered directly by the user.

This patch also adds column labels to 'tab' and 'csv' files generated by reports.
NOTE: Only user defined 'LIMIT's apply to 'tab,' 'csv,' and 'text' files.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agokohabug 1679 & 1680 Fixes date formatting in guided reports wizard
Chris Nighswonger [Mon, 4 Aug 2008 15:15:18 +0000 (10:15 -0500)]
kohabug 1679 & 1680 Fixes date formatting in guided reports wizard

This patch corrects date formatting when defining dictionary definitions in the
guided reports wizard so that dates display according to syspref.

Date formating is also corrected in the report creation section of the guided
reports wizard.

It also corrects a javascript bug which caused some of the calander widgets not
to function properly.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agobugfix for 2451 : serial recieve & barcode does exist complaint
Paul POULAIN [Mon, 4 Aug 2008 13:31:07 +0000 (15:31 +0200)]
bugfix for 2451 : serial recieve & barcode does exist complaint

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoHelp file updates
Nicole Engard [Mon, 4 Aug 2008 13:34:45 +0000 (09:34 -0400)]
Help file updates

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoPutting the db revision from 105 into 106 as it wasn't
Joshua Ferraro [Mon, 4 Aug 2008 13:32:55 +0000 (08:32 -0500)]
Putting the db revision from 105 into 106 as it wasn't
applied in 105

11 years agovery small french translation fix
Paul POULAIN [Sat, 2 Aug 2008 17:22:03 +0000 (19:22 +0200)]
very small french translation fix

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agobump to 106, bug 2452, subscriptionhistory.enddate can be 0000-00-00
Paul POULAIN [Sat, 2 Aug 2008 17:22:02 +0000 (19:22 +0200)]
bump to 106, bug 2452, subscriptionhistory.enddate can be 0000-00-00

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agodealing with L' and D' in french
Paul POULAIN [Sat, 2 Aug 2008 17:22:01 +0000 (19:22 +0200)]
dealing with L' and D' in french

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agounimarc plugin fix, suggested by Zeno Tajoli
Paul POULAIN [Sat, 2 Aug 2008 14:53:14 +0000 (16:53 +0200)]
unimarc plugin fix, suggested by Zeno Tajoli

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoSerials planning: Update subscription edit to properly deal with date changes. (...
Ryan Higgins [Mon, 4 Aug 2008 01:37:51 +0000 (20:37 -0500)]
Serials planning: Update subscription edit to properly deal with date changes. ( patch 3 / 3 )

Previously subscription-add.pl allowed modification of 'firstacquidate', which changed
the subscription definition, but did not affect prediction.  This patch adds two fuctions
to Serials.pm to get/set the current expected issue date (note that all date calculations
in prediction patterns are based on the current expected date, and there's only one serial
issue per subscription in the 'expected' status at any time).  Subscription editing
now allows you to edit the next expected date, but not the first acqui date (unless you
haven't received any issues yet), thus allowing for adjustments in the prediction pattern.
This patch also updates fixes some discrepancies in irregularities / prediction display.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoUpdate serials planning javascript to properly deal with 3-level periodicity. ( Seria...
Ryan Higgins [Mon, 4 Aug 2008 01:10:15 +0000 (20:10 -0500)]
Update serials planning javascript to properly deal with 3-level periodicity. ( Serials patch 2/3 )

Minor changes to dom object names and id's to allow for proper calculation of the
base planning table from the simplified table.
Prior to this patch, the base table was populated with the incorrect value, so patterns like
Vol{X} No{Y} Issue{Z} incremented the Vol value incorrectly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoSerials planning updates patch 1/3
Ryan Higgins [Mon, 4 Aug 2008 01:05:55 +0000 (20:05 -0500)]
Serials planning updates patch 1/3

This patch addresses usability and interface bugs in the javascript irregularity checks by
adding extra controls: 'test pattern' button (always visible) replaces the 'irregularity' link
that was previously only sometimes visible.  A 'show advanced pattern' button will display/hide the
base prediction table at any time.  A 'reset pattern' button is added.  The form may now also be submitted
even if it fails the irregularity test, as there are cases when this will result in the desired behavior.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoFixing markup error in previous commit.
Owen Leonard [Fri, 1 Aug 2008 20:24:35 +0000 (15:24 -0500)]
Fixing markup error in previous commit.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agobug 2450: expanded size of cardnumber input field
Danny Bouman [Fri, 1 Aug 2008 20:08:51 +0000 (16:08 -0400)]
bug 2450: expanded size of cardnumber input field

Expanded the size of the cardnumber input field to 20 instead of 10. This allows the full 14-digit barcode to be viewed at a glance without having to
scroll.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBugfix #2414
Frederic Demians [Tue, 29 Jul 2008 09:05:37 +0000 (11:05 +0200)]
Bugfix #2414

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBUGFIX fix on 2380 fix, dump to 102
Paul POULAIN [Wed, 30 Jul 2008 15:03:05 +0000 (17:03 +0200)]
BUGFIX fix on 2380 fix, dump to 102

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoCorrecting structure and markup.
Owen Leonard [Fri, 1 Aug 2008 16:33:11 +0000 (11:33 -0500)]
Correcting structure and markup.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoComplete sweep of help files in order to correct invalid markup and fix Bug 2444...
Owen Leonard [Fri, 1 Aug 2008 14:00:00 +0000 (09:00 -0500)]
Complete sweep of help files in order to correct invalid markup and fix Bug 2444(break up long lines in templates).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agosmall typo/html fixes as suggested by Zeno Tajoli
Paul POULAIN [Thu, 31 Jul 2008 11:21:31 +0000 (13:21 +0200)]
small typo/html fixes as suggested by Zeno Tajoli

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agobug 2335: adding SMSSendDriver system preference - DB update to version 3.00.00.105
Andrew Moore [Wed, 30 Jul 2008 16:18:02 +0000 (11:18 -0500)]
bug 2335: adding SMSSendDriver system preference - DB update to version 3.00.00.105

Previously, the SMSSendDriver system preference was set as a local use system
preference. This patch makes it an official system preference under the "Patron" tab.
This system preference determines which SMS::Send driver is used to send SMS messages.

I have attempted to take care to not overwrite this system preference if it has already
been set.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoCleaning up tags display a little bit, adding tablesorter to user tags table.
Owen Leonard [Thu, 31 Jul 2008 17:03:52 +0000 (12:03 -0500)]
Cleaning up tags display a little bit, adding tablesorter to user tags table.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoMinor markup corrections.
Owen Leonard [Thu, 31 Jul 2008 17:03:43 +0000 (12:03 -0500)]
Minor markup corrections.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBug 1953: updating bad unit test for C4::Items::GetItemsForInventory
Andrew Moore [Thu, 31 Jul 2008 13:58:43 +0000 (08:58 -0500)]
Bug 1953: updating bad unit test for C4::Items::GetItemsForInventory

The tests I wrote for C4::Items::GetItemsForInventory confused the differences
between biblionumber and itemnumber. That wasn't uncovered on my limited test
database, but I uncovered it later.

This fixes that problem by populating a $self->{'items'} list with details of any items
added by KohaTest::add_biblios. Then, tests can probe there for the details of items
they should expect to find when searching.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoNeed to pass dateformat pref to the template so tablesorter js knows how to handle...
Owen Leonard [Thu, 31 Jul 2008 13:52:53 +0000 (08:52 -0500)]
Need to pass dateformat pref to the template so tablesorter js knows how to handle sorting date column.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoDisplay publicationdate if available, else copyrightdate.
Owen Leonard [Thu, 31 Jul 2008 13:52:44 +0000 (08:52 -0500)]
Display publicationdate if available, else copyrightdate.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoReorganizing this display for better usability and to fix bug 2290 ("Claims Should...
Owen Leonard [Thu, 31 Jul 2008 13:43:11 +0000 (08:43 -0500)]
Reorganizing this display for better usability and to fix bug 2290 ("Claims Should not Have Send Button if nothing to claim"). Adding jquery tablesorter. This also adds a message to ask the user to select a supplier if none is selected (see Bug 2338).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agobug 2423: actually ignore already-imported records
Galen Charlton [Wed, 30 Jul 2008 23:08:02 +0000 (18:08 -0500)]
bug 2423: actually ignore already-imported records

When recommiting a partially completed MARC
record batch, records that were already imported
(or had an error status) were being processed
again, leading to duplicate bibs.  Corrected
so that these records are actually ignored.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoPartial fix for Bug 2420 ("OPAC shows broken image for some Google Jackets"). This...
Owen Leonard [Wed, 30 Jul 2008 17:45:45 +0000 (12:45 -0500)]
Partial fix for Bug 2420 ("OPAC shows broken image for some Google Jackets"). This fix only corrects for undefined img src, not for well-formed but broken img src.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agofrench updated
Paul POULAIN [Wed, 30 Jul 2008 15:03:06 +0000 (17:03 +0200)]
french updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agofrench updated
Paul POULAIN [Wed, 30 Jul 2008 15:03:04 +0000 (17:03 +0200)]
french updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoTweak to results display to correct punctuation and add ISBN.
Owen Leonard [Wed, 30 Jul 2008 14:27:12 +0000 (09:27 -0500)]
Tweak to results display to correct punctuation and add ISBN.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoC4::Context::import reloaded
Marc Chantreux [Wed, 30 Jul 2008 11:27:57 +0000 (13:27 +0200)]
C4::Context::import reloaded

the problem was a context was stored every time C4::Context was called.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoRemoving Billing.pl link, will not even slightly work with InnoDB tables as there...
Darrell Ulm [Mon, 28 Jul 2008 17:05:22 +0000 (13:05 -0400)]
Removing Billing.pl link, will not even slightly work with InnoDB tables as there is no fast count, will work on later

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoTag cloud implementation in jquery.
Joe Atzberger [Wed, 30 Jul 2008 01:23:33 +0000 (20:23 -0500)]
Tag cloud implementation in jquery.

Initial implementation of "cloud" display on opac-tags.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBug 1953 [6/6]: adding pod documentation for C4::Koha::displayServers
Andrew Moore [Tue, 29 Jul 2008 16:42:50 +0000 (11:42 -0500)]
Bug 1953 [6/6]: adding pod documentation for C4::Koha::displayServers

This method was not documented. I added some POD to it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBug 1953 [5/6]: whitespace changes: perltidy.
Andrew Moore [Tue, 29 Jul 2008 16:42:49 +0000 (11:42 -0500)]
Bug 1953 [5/6]: whitespace changes: perltidy.

ran perltidy on the whole method since I've rewritten most of it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBug 1953 [4/6]: removing dead code from C4::Koha::displayServers
Andrew Moore [Tue, 29 Jul 2008 16:42:48 +0000 (11:42 -0500)]
Bug 1953 [4/6]: removing dead code from C4::Koha::displayServers

displayServers appears to have had old code in it that was no longer used. I'm removing it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBug 1953 [3/6]: refactoring to remove superfluous where clause.
Andrew Moore [Tue, 29 Jul 2008 16:42:47 +0000 (11:42 -0500)]
Bug 1953 [3/6]: refactoring to remove superfluous where clause.

refactored the SQL query to remove a confusing and superfluous 'WHERE 1' clause.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBug 1953 [2/6]: refactoring SQL in C4::Koha::displayServers to use placeholders.
Andrew Moore [Tue, 29 Jul 2008 16:42:46 +0000 (11:42 -0500)]
Bug 1953 [2/6]: refactoring SQL in C4::Koha::displayServers to use placeholders.

The SQL call in displayServers was not using placeholders, leaving itself open
to potential SQL injection attacks. I've rewritten it to use placeholders.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBug 1953 [1/6]: adding test module for C4::Koha::displayServers
Andrew Moore [Tue, 29 Jul 2008 16:42:45 +0000 (11:42 -0500)]
Bug 1953 [1/6]: adding test module for C4::Koha::displayServers

This test suite tests the several different ways that we can call C4::Koha::displayServers.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agobug 2413: remove noOPACHolds syspref (DB rev 104)
Galen Charlton [Mon, 28 Jul 2008 21:05:42 +0000 (16:05 -0500)]
bug 2413: remove noOPACHolds syspref (DB rev 104)

Preference was removed in patch for bug 2234; completing
removal in existing 3.0 installations via DB rev 104.

No documentation changes (deprecation of noOPACHolds
done in an earlier patch)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agokohabug 2404 This patch removes Image::Magick and adds GD
Chris Nighswonger [Mon, 28 Jul 2008 16:35:46 +0000 (11:35 -0500)]
kohabug 2404 This patch removes Image::Magick and adds GD

This patch removes Image::Magick as a dependency and replaces it with
the (much) lighter GD. Functionality of patronimage code has not changed with
this conversion.

Adding errorhandling for corrupted image file and link to return to moremember.pl when called from there

Added notes about supported image mime types.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoA couple more corrections that should have been in previous commit.
Owen Leonard [Mon, 28 Jul 2008 13:15:45 +0000 (08:15 -0500)]
A couple more corrections that should have been in previous commit.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoFix for Bug 2408 ("Note: separated from content in cgi-bin/koha/serials/subscription...
Owen Leonard [Mon, 28 Jul 2008 12:50:14 +0000 (07:50 -0500)]
Fix for Bug 2408 ("Note: separated from content in cgi-bin/koha/serials/subscription-add.pl") and other markup corrections.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoUpdate to help file
Nicole Engard [Thu, 24 Jul 2008 15:53:22 +0000 (11:53 -0400)]
Update to help file

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoSmall patch again to fix repeated col in reserveratios.tmpl
root [Fri, 25 Jul 2008 14:39:36 +0000 (10:39 -0400)]
Small patch again to fix repeated col in reserveratios.tmpl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBug fixing : the link between serial and item wasnot used when editing an issue
Henri-Damien LAURENT [Fri, 4 Jul 2008 06:20:50 +0000 (08:20 +0200)]
Bug fixing : the link between serial and item wasnot used when editing an issue

table serialitems was not used when getting serialinformation.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBug 1953: refactoring C4::Koha::get_itemtypeinfos_of to eliminate potential SQL injection
Andrew Moore [Fri, 25 Jul 2008 20:31:11 +0000 (15:31 -0500)]
Bug 1953: refactoring C4::Koha::get_itemtypeinfos_of to eliminate potential SQL injection

C4::Koha::get_itemtypeinfos_of was not using plceholders, opening itself up to
potential SQL injection attacks. This patch refactors it to use placeholders to
bind parameters.
I also had to extend C4::koha::get_infos_of to allow us to pass bind parameters into it.
I'm including a test module for C4::Koha::get_itemtypeinfos_of.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agokohabug 2345: bad comparisons pervade reports
Jesse Weaver [Fri, 25 Jul 2008 17:32:05 +0000 (12:32 -0500)]
kohabug 2345: bad comparisons pervade reports

This patch changes all $foo eq undef's to !defined($foo). It also makes misc/spellcheck_suggest/build_spellcheck_suggest.pl have proper syntax.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBug 1953 [3/3]: documentation changes for C4::items::GetItemsForInventory
Andrew Moore [Fri, 25 Jul 2008 16:55:13 +0000 (11:55 -0500)]
Bug 1953 [3/3]: documentation changes for C4::items::GetItemsForInventory

This patch corrects what appears to me to be a few defficiencies in the documentation
for C4::items::GetItemsForInventory. I noticed them while writing test methods for this sub.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBug 1953 [2/3]: refactoring SQL in C4::Items::GetItemsForInventory to use placeholders
Andrew Moore [Fri, 25 Jul 2008 16:55:12 +0000 (11:55 -0500)]
Bug 1953 [2/3]: refactoring SQL in C4::Items::GetItemsForInventory to use placeholders

The SQL in C4::Items::GetItemsForInventory wasn't using placeholders and
bind parameters, possibly leaving itself open ot SQL injection attacks. This
patch changes that.
I've also incliuded a test module for C4::items::GetItemsForInventory.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agoBug 1953 [1/3]: test suite improvements
Andrew Moore [Fri, 25 Jul 2008 16:55:11 +0000 (11:55 -0500)]
Bug 1953 [1/3]: test suite improvements

Here are a few improvments to the test suite to make it easier to write some tests
for C4::Items

I extracted "tomorrow" and "yesterday" methods from a test module into the base class
so that they could be used by multiple test modules

Adding callnumber to items added in the test suite.

I recatored KohaTest::add_biblios a bit to remove the manual count of the number of
MARC::Fields that were added.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agokohabug 2379 When a borrower is added manually in Koha...
Jesse Weaver [Fri, 25 Jul 2008 16:51:34 +0000 (11:51 -0500)]
kohabug 2379 When a borrower is added manually in Koha...

This checks that the enrolmentfee for a category both exists, and is greater than 0, avoiding a spurious charge.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agokohabug 2224 Third installment: Further corrections for NULL fields
Chris Nighswonger [Fri, 25 Jul 2008 15:37:51 +0000 (10:37 -0500)]
kohabug 2224 Third installment: Further corrections for NULL fields

This patch adds code to clean out any NULL fields in rows returned
since NULL fields do not truly meet the filter criteria

It also corrects a bad db field reference.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agokohabug 2390 Setting default fund for new orders
Chris Nighswonger [Fri, 25 Jul 2008 15:37:49 +0000 (10:37 -0500)]
kohabug 2390 Setting default fund for new orders

If a new order was created and no fund selected, a db error was thrown due to the
'bookfundid' field being set to NULL. This patch sets the first fund retrieved from
available funds as the default selection in the scrolling list.

A further enhancement might be to allow the library to choose which fund is the
default fund.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agokohabug 2219 Corrects inconsistent use of subscription.serialsadditems column
Chris Nighswonger [Fri, 25 Jul 2008 15:37:50 +0000 (10:37 -0500)]
kohabug 2219 Corrects inconsistent use of subscription.serialsadditems column

From the bug report:

The serialsadditems syspref was ostensibly removed in DB rev 071
(http://git.koha.org/cgi-bin/gitweb.cgi?p=Koha;a=commit;h=5c41ae54e68866f9661e853376537059f4d83f70)
in favor of a new serialsadditems column in the subscription table.

However, this removal was incomplete.  It is still created for new installations by:

installer/data/mysql/en/mandatory/sysprefs.sql
installer/data/mysql/fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql

and is used in

serials/serials-recieve.pl
serials/serials-edit.pl
admin/systempreferences.pl

Since the system preference was not removed from the sample data scripts, it
is necessary to add another DB rev to remove it - a user may have made a
fresh install of Koha after DB rev 071.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
11 years agokohabug 2380 Correcting serialitems table structure and fixing duplicate barcode...
Chris Nighswonger [Fri, 25 Jul 2008 15:44:30 +0000 (10:44 -0500)]
kohabug 2380 Correcting serialitems table structure and fixing duplicate barcode check

The current serialitems table structure does not provide for a *:1 relationship with
the serial table. This causes a problem when attempting to add multiple items to a given
serial. The db throws an error when attempting to INSERT in  serialitems due to serialid.serialitems
being a unique key. A further side effect is that the marc record is updated with the
item inspite of the error. The mods to the serialitems table structure in this patch
drop serialid.serialitems as a key and make itemnumber.serialitems the primary key
creating a *:1 relationship with the serial table. This patch also makes serialid.serialitems
a foreign key referencing serialid.serial to maintain referential integrity.

Fix for duplicate barcode check

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>