wip/koha-chris_n.git
12 years agobypass corrupt bibs when linking headings
Galen Charlton [Mon, 16 Jun 2008 13:45:55 +0000 (08:45 -0500)]
bypass corrupt bibs when linking headings

During link_bibs_to_authorities.pl run, a bib was
observed that had both biblioitems.marc and biblioitems.marcxml
set to blank or NULL.  Added check to verify that a
defined value is returned from GetMarcBiblio(); may follow
up with additional patches once it's determined how
the corrupt bib came to be loaded.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobug 2247: don't crash linking bib heading with invalid subfield
Galen Charlton [Mon, 16 Jun 2008 13:15:03 +0000 (08:15 -0500)]
bug 2247: don't crash linking bib heading with invalid subfield

Prevent following crash when linking a bib heading to an
authority record if the bib heading has a subfield whose code
is ')' or any other regular expression metacharacter:

Unmatched ) in regex; marked by <-- HERE in m/) <-- HERE / at
/home/koha-pro/kohaclone/C4/Heading/MARC21.pm line 186.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSpelling correction in template.
Ryan Higgins [Fri, 13 Jun 2008 16:41:09 +0000 (11:41 -0500)]
Spelling correction in template.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix upgrade-child: could not update child unless guarantor was defined. Also, limit...
Ryan Higgins [Thu, 12 Jun 2008 21:23:32 +0000 (16:23 -0500)]
Fix upgrade-child: could not update child unless guarantor was defined. Also, limit upgrade path to C -> A .

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoChange order of checks, and avoid warnings if args undef (i.e. anonymous login).
Joe Atzberger [Wed, 11 Jun 2008 21:28:44 +0000 (16:28 -0500)]
Change order of checks, and avoid warnings if args undef (i.e. anonymous login).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years ago(UNIMARC) index only 101$a as language
Paul POULAIN [Wed, 11 Jun 2008 16:27:25 +0000 (18:27 +0200)]
(UNIMARC) index only 101$a as language

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2112 - add indicators to MARC display
Galen Charlton [Wed, 11 Jun 2008 21:43:22 +0000 (16:43 -0500)]
kohabug 2112 - add indicators to MARC display

In any MARC record display in the OPAC or staff client
that displays the MARC tag numbers, the indicators are
now displayed as well, following the tag number.  If an
indicator is a blank, it is displayed as '#'.

Add a function to C4::Koha, display_marc_indicators(), to
generate this display form of the indicators.

Refactoring note: the four scripts changed in this commit
have a lot of duplicate code that could be merged into
a MARC displayer class.

Documentation notes: screenshots of tagged MARC record
displays should be updated.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2207 - improve indicator input in MARC editor
Galen Charlton [Wed, 11 Jun 2008 21:38:15 +0000 (16:38 -0500)]
kohabug 2207 - improve indicator input in MARC editor

Instead of having one input field for both indicators
of a variable field, the bib and authority MARC editor
now has an input field for each indicator.  This has
two main advantages:

* it is easier to tell what the indicator values are,
  even when the first indicator is a space
* it is easier to set the first indicator to blank
  and the second indicator to non-blank.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agocode cleanup - remove unused find_values() copy and paste
Galen Charlton [Wed, 11 Jun 2008 21:38:14 +0000 (16:38 -0500)]
code cleanup - remove unused find_values() copy and paste

The find_values() function in authorities/authorities.pl
and authorities/detail.pl is not used; appears to be copied
from additem.pl.

No documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix column misalignment in opac-reserve .
Ryan Higgins [Tue, 10 Jun 2008 17:48:58 +0000 (12:48 -0500)]
Fix column misalignment in opac-reserve .

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobug 2235: fix various data-corrupting bugs in MARC editor
Galen Charlton [Tue, 10 Jun 2008 16:05:48 +0000 (11:05 -0500)]
bug 2235: fix various data-corrupting bugs in MARC editor

1. Non-ASCII characters in the 942$h (biblioitems.cn_class)
   would cause an edit to fail and lead to a corrupt MARC record in
   biblioitems.marc and biblioitems.marcxml.  Fixed by
   turning on Perl's UTF-8 flag for MARC tag parameters
   processed by C4::Biblio::TransformHtmlToMarc

2. Do not add empty 006 and 007 fields if the corresponding
   input fields are blank.

3. Make it possible to save '0' as a valid subfield
   value.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFixes bug #2229
Frederic Demians [Sun, 8 Jun 2008 18:58:41 +0000 (20:58 +0200)]
Fixes bug #2229

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTypo bugfix: sterling is GBP not GPB
MJ Ray [Mon, 9 Jun 2008 11:54:42 +0000 (12:54 +0100)]
Typo bugfix: sterling is GBP not GPB

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoReverts AnonSuggestions syspref to correct type, and translates into FR
Frederic Demians [Mon, 9 Jun 2008 19:47:21 +0000 (21:47 +0200)]
Reverts AnonSuggestions syspref to correct type, and translates into FR

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFixes bug #2231
Frederic Demians [Tue, 10 Jun 2008 09:23:09 +0000 (11:23 +0200)]
Fixes bug #2231

In OPAC, when cart is sent by email, the email contains an attachement:
an ISO2709 file with cart biblio records. Most users don't have a clue
what to do with this file.

This patch modifies opac-sendbasket.tmpl to clarify what the attachment is.
It also fix a bug in opac-sendbasket.pl which wasn't reading the template
section containing information about the basket:

  Here is your cart, sent from the Koha Online Catalog... foo

It may be necessary to verify that template text is in 'valid' English...

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix authentication problem in previous commit; userenv->{} should not be used before...
Ryan Higgins [Mon, 9 Jun 2008 22:04:23 +0000 (17:04 -0500)]
Fix authentication problem in previous commit; userenv->{} should not be used before check_auth is called.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBugfix: show (cleaned) comment back on detail page.
Joe Atzberger [Mon, 9 Jun 2008 18:52:41 +0000 (13:52 -0500)]
Bugfix: show (cleaned) comment back on detail page.

Also added minor debug feedback to review page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobug 2098: do not apply stemming if search term has digits
Galen Charlton [Mon, 9 Jun 2008 16:33:04 +0000 (11:33 -0500)]
bug 2098: do not apply stemming if search term has digits

If a search contains a digit, it is almost certainly an identifier, and should
not be stemmed.  This is particularly relevant for ISBNs and ISSNs, which
can contain the letter "X" - for example, C4::Search::_build_stemmend_operand
would reduce "014100018X" to "x ", which for a MARC21 database would bring
up irrelevant results (e.g., "23 x 29 cm." from the 300$c).

With this patch, supplying a search term that contains one or more digits
followed by "X" will no longer retrieve irrelevant results.  This applies
to catalogs using Zebra and query stemming.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRevert "Gives a type YesNo to AnonSuggestions syspref"
Joshua Ferraro [Tue, 10 Jun 2008 13:14:13 +0000 (08:14 -0500)]
Revert "Gives a type YesNo to AnonSuggestions syspref"
As pointed out by Joe, this wasn't correct, it's not supposed
to be a YesNo type.
This reverts commit 0c512c7dd41599a18543b3791c89c4c03b5352aa.

12 years agoRevert "Bug fixing : get_user_permissions SQL Fixing"
Joshua Ferraro [Mon, 9 Jun 2008 14:53:23 +0000 (09:53 -0500)]
Revert "Bug fixing : get_user_permissions SQL Fixing"
From Galen: because code is part of the join, there is in fact no ambiguity

This reverts commit 3a05ae40f6d03a8399e4653da1761f5dde7e23ea.

12 years agoBug fixing : get_user_permissions SQL Fixing
Henri-Damien LAURENT [Wed, 4 Jun 2008 09:58:17 +0000 (11:58 +0200)]
Bug fixing : get_user_permissions SQL Fixing

user_sub_permissions join introduced ambivalence for permissions field

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBugfix : generating session id on some systems was not defined
Henri-Damien LAURENT [Wed, 4 Jun 2008 09:53:46 +0000 (11:53 +0200)]
Bugfix : generating session id on some systems was not defined

Explicitly naming the method to generate id is required on some systems
(SUN 4)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdd | separator between authors repetitions in OPAC detail page
Frederic Demians [Sun, 8 Jun 2008 19:57:02 +0000 (21:57 +0200)]
Add | separator between authors repetitions in OPAC detail page

Without this patch authors display on OPAC is weird.
You get for example:
  Author: Freud--Sigmund Lacan--Jacques
And you finish to read an author 'Simund Lacan'

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSmall script to identify syspref differences between languages (3). See
Frederic Demians [Mon, 9 Jun 2008 08:32:20 +0000 (10:32 +0200)]
Small script to identify syspref differences between languages (3). See

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdd missing variables to default fr-FR systempreferences
Frederic Demians [Sun, 8 Jun 2008 12:50:14 +0000 (14:50 +0200)]
Add missing variables to default fr-FR systempreferences

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoGives a type YesNo to AnonSuggestions syspref
Frederic Demians [Sat, 7 Jun 2008 17:07:51 +0000 (19:07 +0200)]
Gives a type YesNo to AnonSuggestions syspref

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2225 - fix resource leak in SimpleSearch
Galen Charlton [Fri, 6 Jun 2008 23:15:23 +0000 (18:15 -0500)]
kohabug 2225 - fix resource leak in SimpleSearch

Explicitly destroy ZOOM Query and ResultSet objects created
in C4::Search::SimpleSearch() - for long-running users
of SimpleSearch, such as link_bibs_to_authorities.pl or
the matcher used by the staging MARC import, the failure
to do this causes a memory leak in both the client Perl
script and (in the case of ZOOM ResultSet objects) a
corresponding resource leak in zebrasrv for the life
of the Z39.50 connection.

With this change, link_bibs_to_authorities.pl will be
be able to process large bib datasets without leaking
memory due to the Z39.50 lookups it does.

Similar changes are indicated for all uses of
ZOOM that could last longer than a single CGI
query.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoDisplay only approved tags, change simple form to GET, supply "strata" for eventual...
Joe Atzberger [Fri, 6 Jun 2008 21:39:59 +0000 (16:39 -0500)]
Display only approved tags, change simple form to GET, supply "strata" for eventual cloud building.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 1993 - task scheduler improvements
Galen Charlton [Fri, 6 Jun 2008 17:41:41 +0000 (12:41 -0500)]
kohabug 1993 - task scheduler improvements

[1] Removed hardcoded path to original developer's
    Koha configuration file; now checks KOHA_CONF.
[2] Now attempts to figure out if a task was successfully
    added to the task queue; if it wasn't, the failure
    is now reported in the  task scheduler page.
[3] When traveling to the task scheduler page from a
    saved report, the report in question is now
    selected by default.
[4] Removed the button to edit a queued task; this is
    not supported.

This patch is essentially a bandage; I've added a BUGS
section and some FIXMEs to the POD for C4::Scheduler
detailing some issues - a refactoring of the task
scheduler is in order at some point.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 1874 Adding variable assignment so that the confirm button is properly displa...
Chris Nighswonger [Fri, 6 Jun 2008 04:27:35 +0000 (23:27 -0500)]
kohabug 1874 Adding variable assignment so that the confirm button is properly displayed in both Staff and OPAC

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrecting "Open" to read "Free" on shelves.pl in order to match pull-down selections
Chris Nighswonger [Fri, 6 Jun 2008 02:48:03 +0000 (21:48 -0500)]
Correcting "Open" to read "Free" on shelves.pl in order to match pull-down selections

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBUGFIX 2106 - repeatable holidays always on sunday. Also removing an old, unused...
Ryan Higgins [Thu, 5 Jun 2008 21:44:52 +0000 (16:44 -0500)]
BUGFIX 2106 - repeatable holidays always on sunday. Also removing an old, unused syspref, and correcting a branch limitation for ind.branches.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoreplace #!/usr/bin/perl, lost on a recent commit.
Ryan Higgins [Thu, 5 Jun 2008 19:12:13 +0000 (14:12 -0500)]
replace #!/usr/bin/perl, lost on a recent commit.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agodefault results per page for OPAC authority search now 20
Galen Charlton [Thu, 5 Jun 2008 17:26:41 +0000 (12:26 -0500)]
default results per page for OPAC authority search now 20

Previously was 19, which is an odd number.  20
is consistent with the staff authority search.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoremoved 'AddStatement' op from authorities search
Galen Charlton [Thu, 5 Jun 2008 17:26:40 +0000 (12:26 -0500)]
removed 'AddStatement' op from authorities search

The AddStatement op is an archaism from 2.2 that
has not been used in the templates for at least a
year.

No documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobugfix - don't allow deletion of authority records from OPAC
Galen Charlton [Thu, 5 Jun 2008 17:26:39 +0000 (12:26 -0500)]
bugfix - don't allow deletion of authority records from OPAC

Because of some copy-and-paste work, it was possible to
construct an OPAC URL that would attempt to call DelAuthority
on a selected authority record.  This is perhaps taking
patron contributations to library metadata a bit too far.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2205 - fix 404 when traversing pagination link in OPAC authorities search
Galen Charlton [Thu, 5 Jun 2008 17:26:38 +0000 (12:26 -0500)]
kohabug 2205 - fix 404 when traversing pagination link in OPAC authorities search

Currently, the heading sort order is a required parameter, but was
not supplied to the template or used in the search results.  As
a result of this patch, clicking a link to view another page
of the authority search results will now work.

Outstanding issue not addressed by this patch: when searching
authorities in both the staff interface and the OPAC, choosing
sort order "none" results in a crash.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix date filter on issues_stats.
Ryan Higgins [Thu, 5 Jun 2008 17:16:30 +0000 (12:16 -0500)]
Fix date filter on issues_stats.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRemove vestigial checkbox for label-batch creation on MARC import
Ryan Higgins [Thu, 5 Jun 2008 17:16:08 +0000 (12:16 -0500)]
Remove vestigial checkbox for label-batch creation on MARC import

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUpdate issues_stats to use authorised_values instead of distinct(sortn); add col...
Ryan Higgins [Thu, 5 Jun 2008 17:15:52 +0000 (12:15 -0500)]
Update issues_stats to use authorised_values instead of distinct(sortn); add col/row headers as Descriptions instead of codes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUpdate issues_stats to show auth_vals as row & column headers
Ryan Higgins [Thu, 5 Jun 2008 17:15:23 +0000 (12:15 -0500)]
Update issues_stats to show auth_vals as row & column headers

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdd Collection code limit to issues_stats report.
Ryan Higgins [Thu, 5 Jun 2008 17:15:06 +0000 (12:15 -0500)]
Add Collection code limit to issues_stats report.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUpdate issues_stats: add shelving location limit, replace cgi::scrolling_list, update...
Ryan Higgins [Thu, 5 Jun 2008 17:14:40 +0000 (12:14 -0500)]
Update issues_stats: add shelving location limit, replace cgi::scrolling_list, update terminology.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2192 - set tabs for four system preferences
Galen Charlton [Thu, 5 Jun 2008 16:23:33 +0000 (11:23 -0500)]
kohabug 2192 - set tabs for four system preferences

OPACItemHolds => OPAC
AutoEmailOpacUser => Patrons
AutoEmailPrimaryAddress => Patrons
serialsadditems => Acquisitions

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobugfix - HTML escape syspref explanation
Galen Charlton [Thu, 5 Jun 2008 16:23:32 +0000 (11:23 -0500)]
bugfix - HTML escape syspref explanation

This applies to the list of system preferences in
the syspref editor - the OPACUserCSS syspref had
angle brackets in its description.

Used template change to accomplish this.  Note that
syspref value is escaped by the script, note the template.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofix to display itemcallnumber on opac brief display
Paul POULAIN [Thu, 5 Jun 2008 15:08:53 +0000 (17:08 +0200)]
fix to display itemcallnumber on opac brief display

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadding some missing packages to about.pl
Paul POULAIN [Thu, 5 Jun 2008 15:08:52 +0000 (17:08 +0200)]
adding some missing packages to about.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofew changes in UNIMARC record.abs
Paul POULAIN [Thu, 5 Jun 2008 15:08:51 +0000 (17:08 +0200)]
few changes in UNIMARC record.abs

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBUGFIX: the language list was calculated on opaclanguage, whatever the interface
Paul POULAIN [Thu, 5 Jun 2008 15:08:50 +0000 (17:08 +0200)]
BUGFIX: the language list was calculated on opaclanguage, whatever the interface

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoInteractive debugging aides for SIP abstraction layer.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:56 +0000 (18:14 -0500)]
Interactive debugging aides for SIP abstraction layer.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMajor SIP components reworked.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:55 +0000 (18:14 -0500)]
Major SIP components reworked.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoExpanded SIP config file.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:54 +0000 (18:14 -0500)]
Expanded SIP config file.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoObject oriented module is not an Exporter.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:53 +0000 (18:14 -0500)]
Object oriented module is not an Exporter.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdd debugging around readline.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:52 +0000 (18:14 -0500)]
Add debugging around readline.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSIP tests for renew and renew_all.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:51 +0000 (18:14 -0500)]
SIP tests for renew and renew_all.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoDebugging util. script for SIP config XML.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:50 +0000 (18:14 -0500)]
Debugging util. script for SIP config XML.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTweak verify_cksum.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:49 +0000 (18:14 -0500)]
Tweak verify_cksum.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSIP abstraction layer implementation for ILS, Items and Patrons.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:48 +0000 (18:14 -0500)]
SIP abstraction layer implementation for ILS, Items and Patrons.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAbstraction layer implementation for Transactions.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:47 +0000 (18:14 -0500)]
Abstraction layer implementation for Transactions.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdd check to resensitize sub.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:46 +0000 (18:14 -0500)]
Add check to resensitize sub.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoObject oriented module is not an Exporter. 2 subs added, also.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:45 +0000 (18:14 -0500)]
Object oriented module is not an Exporter. 2 subs added, also.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrect package name.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:44 +0000 (18:14 -0500)]
Correct package name.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoObject Oriented module is not an Exporter.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:43 +0000 (18:14 -0500)]
Object Oriented module is not an Exporter.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdd do_renew_all function, necessary for implementation.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:42 +0000 (18:14 -0500)]
Add do_renew_all function, necessary for implementation.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoWhitespace cleanup and one commented-out function added.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:41 +0000 (18:14 -0500)]
Whitespace cleanup and one commented-out function added.

Verify with: git diff -w  C4/SIP/Sip/Configuration.pm

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTrivial POD revision.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:40 +0000 (18:14 -0500)]
Trivial POD revision.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSIP/t - test files adapted, supplemented, expanded. Note: requires matching data...
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:39 +0000 (18:14 -0500)]
SIP/t - test files adapted, supplemented, expanded. Note: requires matching data to be loaded.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSIP/koha_test - remove duplicative tests
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:38 +0000 (18:14 -0500)]
SIP/koha_test - remove duplicative tests

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoConvert to using loop_context_vars for rows instead of highlight/toggle/whatever.
Joe Atzberger [Wed, 4 Jun 2008 20:21:41 +0000 (15:21 -0500)]
Convert to using loop_context_vars for rows instead of highlight/toggle/whatever.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRemove bad use of map in void context, exclusively for side effects!
Joe Atzberger [Wed, 4 Jun 2008 20:21:40 +0000 (15:21 -0500)]
Remove bad use of map in void context, exclusively for side effects!

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdd Debug for warns and remove unnecessary middleman variables from returns.
Joe Atzberger [Wed, 4 Jun 2008 20:21:39 +0000 (15:21 -0500)]
Add Debug for warns and remove unnecessary middleman variables from returns.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoShow copy/volume info on STAFF detail page.
Joe Atzberger [Tue, 3 Jun 2008 17:40:18 +0000 (12:40 -0500)]
Show copy/volume info on STAFF detail page.

This change helps the staff side catch up w/ the OPAC display and be
more useful to librarians dealing with serials.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBugfix is_approved() to handle the 3-state nature of approval.
Joe Atzberger [Tue, 3 Jun 2008 14:27:15 +0000 (09:27 -0500)]
Bugfix is_approved() to handle the 3-state nature of approval.

That is, a term is either approved, or rejected, or neither.
Without an external dictionary, most terms will fall into the
latter category.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agominor changes in french translation
Paul POULAIN [Mon, 2 Jun 2008 13:39:18 +0000 (15:39 +0200)]
minor changes in french translation

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofrench translation updated
Paul POULAIN [Mon, 2 Jun 2008 13:39:15 +0000 (15:39 +0200)]
french translation updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agore fixing opac-suggestion < misplaced
Paul POULAIN [Mon, 2 Jun 2008 13:39:14 +0000 (15:39 +0200)]
re fixing opac-suggestion < misplaced

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agohtml fix (detected by translator)
Paul POULAIN [Mon, 2 Jun 2008 13:39:12 +0000 (15:39 +0200)]
html fix (detected by translator)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agosmall fixes in french translation
Paul POULAIN [Mon, 2 Jun 2008 13:39:11 +0000 (15:39 +0200)]
small fixes in french translation

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofix to have the branch search on OPAC being really a branch search, not kw
Paul POULAIN [Mon, 2 Jun 2008 13:39:10 +0000 (15:39 +0200)]
fix to have the branch search on OPAC being really a branch search, not kw

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agodisplay itemnote on check-out (added, was not here) & check-in (red-ed, was already...
Paul POULAIN [Mon, 2 Jun 2008 13:39:09 +0000 (15:39 +0200)]
display itemnote on check-out (added, was not here) & check-in (red-ed, was already here)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdd MARC preview to cataloguing search, and add a link to add holdings. Once the...
Ryan Higgins [Mon, 2 Jun 2008 23:23:25 +0000 (18:23 -0500)]
Add MARC preview to cataloguing search, and add a link to add holdings. Once the edititems permission patch is accepted, this page should be updated to require edititems instead of editcatalogue.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadd single-transaction flag to mysqldump in example backup script.
Ryan Higgins [Mon, 2 Jun 2008 23:23:09 +0000 (18:23 -0500)]
add single-transaction flag to mysqldump in example backup script.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRestrict OPAC tags display to approved=>1.
Joe Atzberger [Mon, 2 Jun 2008 18:16:32 +0000 (13:16 -0500)]
Restrict OPAC tags display to approved=>1.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrection to: Comment out confirmation popups (on successful events).
Joe Atzberger [Mon, 2 Jun 2008 17:43:22 +0000 (12:43 -0500)]
Correction to: Comment out confirmation popups (on successful events).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoComment out confirmation popups (on successful events).
Joe Atzberger [Mon, 2 Jun 2008 17:33:33 +0000 (12:33 -0500)]
Comment out confirmation popups (on successful events).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2078 - settle on application/xml Content-type for feeds
Galen Charlton [Mon, 2 Jun 2008 15:53:38 +0000 (10:53 -0500)]
kohabug 2078 - settle on application/xml Content-type for feeds

Required by IE6 to at least get a feed to display as XML
in the browser instead of being downloaded.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2078 - send correct Content-type for search feeds
Galen Charlton [Mon, 2 Jun 2008 14:05:04 +0000 (09:05 -0500)]
kohabug 2078 - send correct Content-type for search feeds

OPAC search RSS and ATOM feeds now have the correct
Content-type sent - "application/rss+xml" and "application/atom+xml",
respectively.

As part of this patch, added an optional fourth parameter
to C4::Output::output_html_with_http_headers to specify
the content type.  If that parameter is now supplied, or if
the value of the parameter does not contain at least a "/",
the default type of "text/html" is returned.

No documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2078 - removed ersatz ESCAPE="html" added in prior patch
Galen Charlton [Mon, 2 Jun 2008 14:05:03 +0000 (09:05 -0500)]
kohabug 2078 - removed ersatz ESCAPE="html" added in prior patch

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2078 - fixed channel links in Atom and RSS
Galen Charlton [Mon, 2 Jun 2008 13:13:35 +0000 (08:13 -0500)]
kohabug 2078 - fixed channel links in Atom and RSS

query_cgi already includes the "q=" bit.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoOPACBaseURL - do not tack on :443 if using SSL
Galen Charlton [Mon, 2 Jun 2008 13:13:34 +0000 (08:13 -0500)]
OPACBaseURL - do not tack on :443 if using SSL

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2078 - fix feed validation errors
Galen Charlton [Mon, 2 Jun 2008 02:43:31 +0000 (21:43 -0500)]
kohabug 2078 - fix feed validation errors

Fix several validation errors in RSS and Atom feeds
generated from the OPAC:

- add missing guid to RSS elements
- add missing feed ID and element ID to Atom elements
- reflect OPACBaseURL changes
- fix atom:link self links
- add HTML escaping to fields comming from bib record
- set default timestamp for Atom updated elements

Issues identified but not solved in this patch:

- setting Atom updated element for each bib (presumably
  from biblio.timestamp)
- possible problems performing paging of Atom feed

Based on successful validation of feeds by feedvalidatory.org,
it is expected that feeds should now work in IE7 and IE6.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agocalculate OPACBaseURL instead of using syspref
Galen Charlton [Mon, 2 Jun 2008 02:43:30 +0000 (21:43 -0500)]
calculate OPACBaseURL instead of using syspref

Calculate OPACBaseURL from the
CGI environment variables instead of using the
system preference.  As a result of this patch,
it should be possible to change the hostname,
protocol, or port of the OPAC without having to
reset a system preference.

Also added a FIXME to opac/unapi - the URL of
the SRU/W server has no necessary relationship
to the URL of the OPAC.

Once this patch is confirmed, the syspref can
be removed.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2180 - improve display when fines block checkouts
Galen Charlton [Mon, 2 Jun 2008 02:43:28 +0000 (21:43 -0500)]
kohabug 2180 - improve display when fines block checkouts

If a patron's fine balance is over the limit set by the
noissuecharges syspref, checkouts are blocked.  However,
this was not made very clear in the interface.

Improved the display by doing the following:

[1] If the fine balance is over the noissuecharges limit, use the "blocker"
styling (i.e., make all of the text red).
[2] Add wording to explicitly signal whether or not the fine balance is
blocking charges.

Documentation changes: new screenshots of blocked checkouts.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoApply item-level_itypes syspref to MARC export.
Ryan Higgins [Sun, 1 Jun 2008 17:48:54 +0000 (12:48 -0500)]
Apply item-level_itypes syspref to MARC export.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoIndependent-branchify MARC export. Add option to remove all holdings except your...
Ryan Higgins [Sun, 1 Jun 2008 17:25:17 +0000 (12:25 -0500)]
Independent-branchify MARC export. Add option to remove all holdings except your own, and force that behavior for independent branches. Also add accession date limit to export.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSort dropdowns for libraries by name instead of branchcode in several staff-side...
Ryan Higgins [Sun, 1 Jun 2008 14:56:49 +0000 (09:56 -0500)]
Sort dropdowns for libraries by name instead of branchcode in several staff-side interfaces.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRemove commented deprecated code and a useless query on items.
Ryan Higgins [Sun, 1 Jun 2008 14:56:30 +0000 (09:56 -0500)]
Remove commented deprecated code and a useless query on items.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRemove a couple of warns.
Ryan Higgins [Sun, 1 Jun 2008 14:56:15 +0000 (09:56 -0500)]
Remove a couple of warns.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoItems from Bug 2167 ("URL handling in staff client inconsistent"): Removing display...
Owen Leonard [Sat, 31 May 2008 19:31:05 +0000 (14:31 -0500)]
Items from Bug 2167 ("URL handling in staff client inconsistent"): Removing display of URL from moredetail.pl. URLs are now displayed on detail.pl just as they are in the OPAC. Also removing display of biblio-level call number. Item level call number is displayed already.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix for bug 2183, "Account tab needs spacing between description and stadard text...
Owen Leonard [Sat, 31 May 2008 19:08:57 +0000 (14:08 -0500)]
Fix for bug 2183, "Account tab needs spacing between description and stadard text" Please note that this is a band-aid for a larger issue, described in Bug 2188

Signed-off-by: Joshua Ferraro <jmf@liblime.com>