wip/koha-chris_n.git
9 years agoFix for Bug 3659, Add place hold option from patron checkout tab
Owen Leonard [Tue, 15 Mar 2011 02:08:57 +0000 (21:08 -0500)]
Fix for Bug 3659, Add place hold option from patron checkout tab

Adds a button on patron-related pages, "Search to hold"
Clicking search to hold sets a cookie with the patron's
borrowernumber and sends the user to the search page.

On subsequent search results pages the user will have
the option to place holds specifically for the remembered
patron. This works on the search results page (single
and multiple hold) and on the detail page.

The saved cookie will time out after 10 minutes or
be erased when a new patron is loaded by circulation.pl

New jQuery plugin added: jquery.cookie.min.js

Revision fixes some markup and corrects an error that would lead
to the hold being initiated for the remembered patron when this
was not intended.

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoRevert "Fix for Bug 3659, Add place hold option from patron checkout tab"
Chris Cormack [Mon, 24 Jan 2011 17:24:32 +0000 (06:24 +1300)]
Revert "Fix for Bug 3659, Add place hold option from patron checkout tab"

This reverts commit da2040634ed4f589c5f6b188ab3a3fac83d99a9b.

Wrong patch was applied

9 years agoFix for Bug 3659, Add place hold option from patron checkout tab
Owen Leonard [Mon, 17 Jan 2011 13:28:47 +0000 (08:28 -0500)]
Fix for Bug 3659, Add place hold option from patron checkout tab

Adds a button on patron-related pages, "Search to hold"
Clicking search to hold sets a cookie with the patron's
borrowernumber and sends the user to the search page.

On subsequent search results pages the user will have
the option to place holds specifically for the remembered
patron. This works on the search results page (single
and multiple hold) and on the detail page.

The saved cookie will time out after 10 minutes or
be erased when a new patron is loaded by circulation.pl

New jQuery plugin added: jquery.cookie.min.js

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 4309 Do not throw error on auth search of multiple fields
Colin Campbell [Thu, 6 Jan 2011 17:49:22 +0000 (17:49 +0000)]
Bug 4309 Do not throw error on auth search of multiple fields

Ensures the multiple search does not throw a 500 error but
allows a single search to be used as well

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5618: Adding missing system preferences
Chris Cormack [Sun, 23 Jan 2011 19:19:11 +0000 (08:19 +1300)]
Bug 5618: Adding missing system preferences

9 years agoBug 5618: Multiple renewals in the opac
Chris Cormack [Thu, 20 Jan 2011 17:16:43 +0000 (12:16 -0500)]
Bug 5618: Multiple renewals in the opac

Enables logged-in OPAC patrons to renew multiple items at once using checkboxes.

Errors are now handled better (for example, when item is on reserve)

Sponsored by Los Gatos Public Library

Squashed commit of the following:

commit 020d9904ddb22af238c8a90c1f7447ead5a6d0e7
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Thu Jan 20 08:57:01 2011 +1300

    Bug 5618: typo fix

commit 147cfd91dbe88fd58c5d404db9bf06a21310e2ef
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Thu Jan 20 08:47:39 2011 +1300

    Bug 5618: Adding better error handling for reserves, and always redirecting instead of exploding

commit 2dfb6c687d0d38c240e22d41f2aef6e3a9e53f02
Author: Chris Cormack <chrisc@koha.(none)>
Date:   Fri Jan 14 15:39:20 2011 +1300

    Bug 5618: Is mostly working now, needs some prettying up

commit f8d260a4dcde144c9ed487521a79ee687ff8feb3
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Fri Jan 14 15:03:45 2011 +1300

    bug 5618: Initial commit to set up checkboxes for choosing multiple items

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_5551' into kcmaster
Chris Cormack [Sun, 23 Jan 2011 18:24:40 +0000 (07:24 +1300)]
Merge remote branch 'kc/new/enh/bug_5551' into kcmaster

9 years agoMerge remote branch 'kc/new/bug_5586' into kcmaster
Chris Cormack [Sun, 23 Jan 2011 18:21:47 +0000 (07:21 +1300)]
Merge remote branch 'kc/new/bug_5586' into kcmaster

9 years agoMerge remote branch 'kc/new/enh/bug_4289' into kcmaster
Chris Cormack [Sun, 23 Jan 2011 18:21:20 +0000 (07:21 +1300)]
Merge remote branch 'kc/new/enh/bug_4289' into kcmaster

9 years agoBug 4289: OpacPublic prevents login into OPAC
Ian Walls [Fri, 21 Jan 2011 22:11:51 +0000 (17:11 -0500)]
Bug 4289: OpacPublic prevents login into OPAC

If OpacPublic is set to Public, opac-user.pl does not ask for authentication, and takes the patron to a
null OPAC summary page.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5327 fixing missing number of tests
Chris Cormack [Thu, 20 Jan 2011 22:28:58 +0000 (11:28 +1300)]
Bug 5327 fixing missing number of tests

9 years agoBumping Koha version
Chris Cormack [Thu, 20 Jan 2011 22:12:16 +0000 (11:12 +1300)]
Bumping Koha version

9 years agoBug 5551 - allow shelf browser filters to be changed
Robin Sheat [Fri, 14 Jan 2011 02:22:14 +0000 (15:22 +1300)]
Bug 5551 - allow shelf browser filters to be changed

This adds three system preferences: ShelfBrowserUsesLocation,
ShelfBrowserUsesHomeBranch, and ShelfBrowserUsesCcode. These can be
toggled to determine whether the shelf browser will ensure that the
items being show will match against location, homebranch, or collection
code, respectively.

Note that this also involves a bit of a refactor to clean up the shelf
browser code.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoAdded more unit tests to check when JSONStream should fail.
Zach Sim [Thu, 20 Jan 2011 21:46:09 +0000 (10:46 +1300)]
Added more unit tests to check when JSONStream should fail.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5327: Added unit tests to Output_JSONStream.t
Zach Sim [Thu, 20 Jan 2011 20:16:28 +0000 (09:16 +1300)]
Bug 5327: Added unit tests to Output_JSONStream.t

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_5628' into kcmaster
Chris Cormack [Thu, 20 Jan 2011 20:20:41 +0000 (09:20 +1300)]
Merge remote branch 'kc/new/enh/bug_5628' into kcmaster

9 years agoBug 5268: Combining icons with liblime-kids
Chris Cormack [Thu, 20 Jan 2011 19:51:09 +0000 (08:51 +1300)]
Bug 5268: Combining icons with liblime-kids

9 years agoMerge remote branch 'kc/new/enh/bug_5640' into kcmaster
Chris Cormack [Thu, 20 Jan 2011 08:06:23 +0000 (21:06 +1300)]
Merge remote branch 'kc/new/enh/bug_5640' into kcmaster

9 years agoBug 5640: Adding the icons to the opac also
Chris Cormack [Thu, 20 Jan 2011 08:03:56 +0000 (21:03 +1300)]
Bug 5640: Adding the icons to the opac also

9 years agoBug 5327: small typo in the Members.t test
Chris Cormack [Thu, 20 Jan 2011 07:14:04 +0000 (20:14 +1300)]
Bug 5327: small typo in the Members.t test

9 years agoBug 5327 Made test file for Accounts.pm
johnboy [Wed, 19 Jan 2011 22:17:35 +0000 (11:17 +1300)]
Bug 5327 Made test file for Accounts.pm

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5634: BZ5634 order branch list alphabetically, without taking care of uc/lc
Paul Poulain [Tue, 18 Jan 2011 16:19:18 +0000 (11:19 -0500)]
Bug 5634: BZ5634 order branch list alphabetically, without taking care of uc/lc

Perl separates uc & lc in cmp. So we just uc() to have list properly ordered

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug5640: BZ5640 (MT3584): Nimes icon set
Paul Poulain [Tue, 18 Jan 2011 15:56:59 +0000 (10:56 -0500)]
Bug5640: BZ5640 (MT3584): Nimes icon set

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug5640: BZ5640 (MT3584): Nimes icon set
Paul Poulain [Tue, 18 Jan 2011 15:56:59 +0000 (10:56 -0500)]
Bug5640: BZ5640 (MT3584): Nimes icon set

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5327: Shifting and little tidy up of the members tests
Chris Cormack [Wed, 19 Jan 2011 22:52:19 +0000 (11:52 +1300)]
Bug 5327: Shifting and little tidy up of the members tests

9 years agoBug 5327 Some tests added
johnboy [Wed, 19 Jan 2011 21:32:58 +0000 (10:32 +1300)]
Bug 5327 Some tests added

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 4289: Updating other sysprefs until we change the installer, we need to do this
Chris Cormack [Wed, 19 Jan 2011 07:55:33 +0000 (20:55 +1300)]
Bug 4289: Updating other sysprefs until we change the installer, we need to do this

9 years agoNew icon set, renaming and making files in the intranet too
Chris Cormack [Tue, 18 Jan 2011 23:35:57 +0000 (12:35 +1300)]
New icon set, renaming and making files in the intranet too

9 years agoNew icon set for kids, has ben rezided to 48 by 48px
claudia [Tue, 18 Jan 2011 21:11:12 +0000 (10:11 +1300)]
New icon set for kids, has ben rezided to 48 by 48px

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 4289: Bumping version number up
Chris Cormack [Wed, 19 Jan 2011 01:31:58 +0000 (14:31 +1300)]
Bug 4289: Bumping version number up

9 years agoBug 4289 Followup: Add syspref default value and in opac.pref
Frédéric Demians [Tue, 7 Dec 2010 16:33:13 +0000 (17:33 +0100)]
Bug 4289 Followup: Add syspref default value and in opac.pref

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 4289: 'OpacPublic' feature
Mason James [Tue, 7 Dec 2010 16:33:12 +0000 (17:33 +0100)]
Bug 4289: 'OpacPublic' feature

applied to git tag 'v3.02.00-rc'

Frédéric Demians:

  - Rebased this patch to HEAD
  - Solved a merge conflict
  - The patch works as described here:
    http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4289

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5327 - Now we are doing db calls, we need to shift this to t/db_dependent
Chris Cormack [Wed, 19 Jan 2011 00:38:52 +0000 (13:38 +1300)]
Bug 5327 - Now we are doing db calls, we need to shift this to t/db_dependent

9 years agoAdded unit tests to test all of get_amazon_tld in Amazon.pm.
Zach Sim [Tue, 18 Jan 2011 23:07:25 +0000 (12:07 +1300)]
Added unit tests to test all of get_amazon_tld in Amazon.pm.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Tue, 18 Jan 2011 22:26:18 +0000 (11:26 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

9 years agoBug 5327: Little change to Record.t
Chris Cormack [Tue, 18 Jan 2011 22:09:28 +0000 (11:09 +1300)]
Bug 5327: Little change to Record.t

9 years agoBug 5327 1 more test added.
johnboy [Tue, 18 Jan 2011 21:44:11 +0000 (10:44 +1300)]
Bug 5327 1 more test added.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoAdded unit tests for Biblio and moved it to db_dependent as it requires the database.
Zach Sim [Tue, 18 Jan 2011 21:52:23 +0000 (10:52 +1300)]
Added unit tests for Biblio and moved it to db_dependent as it requires the database.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Tue, 18 Jan 2011 09:54:06 +0000 (22:54 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

9 years agoBug 5327 Cleaning up XISBN.t a bit
Chris Cormack [Tue, 18 Jan 2011 09:52:02 +0000 (22:52 +1300)]
Bug 5327 Cleaning up XISBN.t a bit

9 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Tue, 18 Jan 2011 06:55:12 +0000 (19:55 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

9 years agoBug 5327 - Fixing a path issue with XISBN.t
Chris Cormack [Tue, 18 Jan 2011 06:53:58 +0000 (19:53 +1300)]
Bug 5327 - Fixing a path issue with XISBN.t

9 years agoBug 5327 litte fix for Background tests
Chris Cormack [Tue, 18 Jan 2011 03:35:08 +0000 (16:35 +1300)]
Bug 5327 litte fix for Background tests

9 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Tue, 18 Jan 2011 03:25:58 +0000 (16:25 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

9 years agoBug 5327 shifting database dependent modules and scripts to t/db_dependent
Chris Cormack [Tue, 18 Jan 2011 03:18:37 +0000 (16:18 +1300)]
Bug 5327 shifting database dependent modules and scripts to t/db_dependent

9 years agobug 5327 updated test file
johnboy [Tue, 18 Jan 2011 02:56:38 +0000 (15:56 +1300)]
bug 5327 updated test file

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoAdded unit tests using a test database for XISBN.
Zach Sim [Tue, 18 Jan 2011 02:54:49 +0000 (15:54 +1300)]
Added unit tests using a test database for XISBN.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoCreated unit testing using the testdatabase for XISBN.
Zach Sim [Tue, 18 Jan 2011 02:25:22 +0000 (15:25 +1300)]
Created unit testing using the testdatabase for XISBN.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Mon, 17 Jan 2011 23:01:04 +0000 (12:01 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

9 years agoAdded extra unit tests to Debug.t
Zach Sim [Mon, 17 Jan 2011 22:14:21 +0000 (11:14 +1300)]
Added extra unit tests to Debug.t

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5327 started testing
johnboy [Mon, 17 Jan 2011 22:34:39 +0000 (11:34 +1300)]
bug 5327 started testing

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5327 Starting tests for BackgroundJob
johnboy [Mon, 17 Jan 2011 22:06:05 +0000 (11:06 +1300)]
Bug 5327 Starting tests for BackgroundJob

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Mon, 17 Jan 2011 22:35:15 +0000 (11:35 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

9 years agoBug 5327 Starting Unit Tests for Auth.pm
spartaness [Mon, 17 Jan 2011 21:57:31 +0000 (10:57 +1300)]
Bug 5327 Starting Unit Tests for Auth.pm

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Mon, 17 Jan 2011 20:41:53 +0000 (09:41 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

9 years agoBug 5327 removing uneeded tests
claudia [Mon, 17 Jan 2011 19:56:33 +0000 (08:56 +1300)]
Bug 5327 removing uneeded tests

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5399: Follow up style patch, moving exits out of subroutine
Chris Cormack [Mon, 17 Jan 2011 09:53:28 +0000 (22:53 +1300)]
Bug 5399: Follow up style patch, moving exits out of subroutine

9 years agoBug 5399: remove useless eval 'use C4::Foo'
Galen Charlton [Mon, 17 Jan 2011 09:45:41 +0000 (09:45 +0000)]
Bug 5399: remove useless eval 'use C4::Foo'

Also add a couple FIXMEs

Marcel: Signed and updated for current master

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5026 Undefined dates formatted poorly in serials-edit
Colin Campbell [Mon, 17 Jan 2011 08:17:40 +0000 (08:17 +0000)]
Bug 5026 Undefined dates formatted poorly in serials-edit

Don't display junk in empty fields
Don't generate errors

Merged some changes to make variable names moremeaningful in loops ( within loops)

Thanks to M De Rooy for spotting a couple of issues in the original patch

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoAdding a new developer to the history
Chris Cormack [Mon, 17 Jan 2011 07:59:11 +0000 (20:59 +1300)]
Adding a new developer to the history

9 years agoBug 4920 - neworderempty.tmpl shouldn't call calcNeworderTotal() onload
Dobrica Pavlinusic [Mon, 20 Dec 2010 12:08:23 +0000 (12:08 +0000)]
Bug 4920 - neworderempty.tmpl shouldn't call calcNeworderTotal() onload

Currently, modifying existing orders will recalculate values if exchange rate
has changed, which destroys previous data (our use case is just to modify
Planning value fields).

Since fields also have onChange event which also triggers caclNeworderTotal,
onload event seems redundant.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5403 Remove DisplayISBN and GetPublisherNameFromIsbn
Colin Campbell [Tue, 14 Dec 2010 09:28:53 +0000 (09:28 +0000)]
Bug 5403 Remove DisplayISBN and GetPublisherNameFromIsbn

These two subroutines were no longer being used by any other code
removed them from their respective modules
If we need any ISBN in future we should use Business::ISBN directly

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5327 - Adding UNIT Tests.
Zach Sim [Mon, 17 Jan 2011 03:14:22 +0000 (16:14 +1300)]
Bug 5327 - Adding UNIT Tests.

Squashed commit of the following:

commit 146d14665c52edaa85e38b70aabc9d52be5d64b6
Author: Zach Sim <joseph.zachariah.sim@gmail.com>
Date:   Mon Jan 17 16:07:24 2011 +1300

    Edited DisplayISBN to cleanup the ISBN using _isbn_cleanup if it is not 13 or 10 digits long.

commit ba97b26d9a25470b0717cdd60a3d4f7a5c459ca9
Author: Zach Sim <joseph.zachariah.sim@gmail.com>
Date:   Mon Jan 17 16:06:14 2011 +1300

    Added extra unit tests to test C4::Koha::DisplayISBN.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 3459, topissues doesn't take care of ccode
Owen Leonard [Thu, 13 Jan 2011 21:53:51 +0000 (22:53 +0100)]
Fix for Bug 3459, topissues doesn't take care of ccode

- Change conditional to display filter in sidebar without EXPR
- Enhance switch between ccode default and itemtype default searches
- Enable preselect of submitted collection code in filter form,
  stealing code from opac-search.pl

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 4885 - Only 1 ISBN shows in non-XSL detail view
Owen Leonard [Thu, 13 Jan 2011 21:31:09 +0000 (22:31 +0100)]
Fix for Bug 4885 - Only 1 ISBN shows in non-XSL detail view

Fixed by doing a pretty dumb copy of GetMarcNotes. Functional,
but it could be there is a more efficient way to do it given
we want one repeating tag rather than a range of tags?

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
- fixed small typo in opac-detail
- corrected isbd punctuation in opac-detail
- tested with 0, 1, 2, 3 isbns in 020, MARC21
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 4438: incorrect "Budget total exceeds period allocation" error when editing fund
Henri-Damien LAURENT [Thu, 13 Jan 2011 14:04:19 +0000 (09:04 -0500)]
Bug 4438: incorrect "Budget total exceeds period allocation" error when editing fund

The process in check_parent_total for period allocation was not good.
It took all the children of a period.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years ago(bug #3743) fix acquisition stats ordering
Nahuel ANGELINETTI [Wed, 12 Jan 2011 15:08:46 +0000 (10:08 -0500)]
(bug #3743) fix acquisition stats ordering

This patch fix ordering in acquisition stats to order by month number.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_5611' into kcmaster
Chris Cormack [Wed, 12 Jan 2011 19:19:46 +0000 (08:19 +1300)]
Merge remote branch 'kc/new/bug_5611' into kcmaster

9 years agoBug 5611: Simple typo fix in the comments
Chris Cormack [Wed, 12 Jan 2011 19:17:27 +0000 (08:17 +1300)]
Bug 5611: Simple typo fix in the comments

9 years agoTypo fix for history file
Chris Cormack [Wed, 12 Jan 2011 18:23:08 +0000 (07:23 +1300)]
Typo fix for history file

9 years agoAdding release info, and missing meetings to the history
Chris Cormack [Wed, 12 Jan 2011 17:56:58 +0000 (06:56 +1300)]
Adding release info, and missing meetings to the history

9 years agoAdding new developers to the history
Chris Cormack [Wed, 12 Jan 2011 17:52:06 +0000 (06:52 +1300)]
Adding new developers to the history

9 years agoBug 5611 Tidy up C4::Scrubber
Colin Campbell [Wed, 12 Jan 2011 16:53:22 +0000 (16:53 +0000)]
Bug 5611 Tidy up C4::Scrubber

Remove the unneeded package variables
Remove unnecessary variables
Removed some cargo-cult programming
Tidied the indentation from mix of tabs & spaces
Add a Test that we actually return the required class
of object

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5611 INIT block causes failure with mod perl
Bryce Sanchez [Wed, 12 Jan 2011 16:53:21 +0000 (16:53 +0000)]
Bug 5611 INIT block causes failure with mod perl

Per module INIT Blocks are not run in mod_perl so their
variables are not visible. A lexical var is adequate
for this purpose

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5601 :: Add tests for bugfix
Colin Campbell [Wed, 12 Jan 2011 06:34:22 +0000 (07:34 +0100)]
Bug 5601 :: Add tests for bugfix

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5601 Fix processing of DueDate return
Colin Campbell [Wed, 12 Jan 2011 06:34:21 +0000 (07:34 +0100)]
Bug 5601 Fix processing of DueDate return

item duedate is not a datetime entity but a string retrieved
direct from the db that only needs restructuring
checkout was doing so but item_info was pretending it was in secs
(actually Item.pm manipulated then overwrote it!!)
assume the date in the db is correct (otherwise madness ensues)
dont try to second guess it
As duedates do not yet include a time element assume end of day
as a safety first

[F. Demians] I confirm Joe Atzberger diagnostic. That's a bug reported by a
library. I've tested Colin Campell solution. It fixes the bug.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5055 Use standard file paths in crontab.example
Magnus Enger [Wed, 5 Jan 2011 21:06:54 +0000 (22:06 +0100)]
Bug 5055 Use standard file paths in crontab.example

This is a revised patch, removing the lines pertaining to logrotate.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 4131 have subscription so edit routing if one exists
Nicole Engard [Tue, 11 Jan 2011 07:33:51 +0000 (02:33 -0500)]
bug 4131 have subscription so edit routing if one exists

Changes the template variable checked in serials-menu.inc for determining where to
show 'Create Routing List' or 'Edit Routing List' to hasRouting.

Also adds the $hasRouting variable to serials/routing.pl and serials/routing-preview.pl,
for completeness.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5486 remove note about HomeOrHoldingBranch being removed soon
Nicole Engard [Tue, 11 Jan 2011 06:55:21 +0000 (01:55 -0500)]
bug 5486 remove note about HomeOrHoldingBranch being removed soon

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5603: advance_notice.pl uninitialized element in hash
Ian Walls [Sat, 8 Jan 2011 22:25:56 +0000 (17:25 -0500)]
Bug 5603: advance_notice.pl uninitialized element in hash

Changings one of the LEFT JOINS in C4::Members::Messaging::GetMessagingPreferences
to a JOIN to prevent NULL message_transport_types from being returned

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 2142 : Bumping database version
Chris Cormack [Tue, 11 Jan 2011 19:47:57 +0000 (08:47 +1300)]
Bug 2142 : Bumping database version

9 years agoBug 2142: reinstate maxItemInSearchResults systempreference
Ian Walls [Sat, 8 Jan 2011 22:24:41 +0000 (17:24 -0500)]
Bug 2142: reinstate maxItemInSearchResults systempreference

Reinstates the deleted maxItemsInSearchResults system preference, which was erroneously thought to no longer be utilized.
It's removal has led to bug 4430

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5492 update import patrons page title
Nicole Engard [Tue, 11 Jan 2011 06:52:56 +0000 (01:52 -0500)]
bug 5492 update import patrons page title

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5604 additional icons in the Seshat icon set
Nicole Engard [Tue, 11 Jan 2011 06:36:40 +0000 (01:36 -0500)]
bug 5604 additional icons in the Seshat icon set

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 4945 - Patron search is limited by default to the currently logged-in...
Owen Leonard [Tue, 4 Jan 2011 14:04:41 +0000 (09:04 -0500)]
Fix for Bug 4945 - Patron search is limited by default to the currently logged-in library

I couldn't figure out how (or whether) GetBranchesLoop could be
convinced to return a list of branches without selecting one, so
I swapped GetBranchesLoop with GetBranches. This will preselect
a branch only if a branch has been submitted as part of a query.

This does NOT preselect the correct branch when IndependantBranches
is turned on.

I also added a template variable which is true if a query has
been submitted with a branch or a category so that the extra
form fields can be displayed, reminding the user that they
added limiters to their query.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years ago(bug #3737) fix title search in order history
Nahuel ANGELINETTI [Mon, 10 Jan 2011 16:37:02 +0000 (16:37 +0000)]
(bug #3737) fix title search in order history

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBumping database number to 011
Chris Cormack [Mon, 10 Jan 2011 19:12:59 +0000 (08:12 +1300)]
Bumping database number to 011

9 years agoMerge remote branch 'kc/new/bug_5186' into kcmaster
Chris Cormack [Mon, 10 Jan 2011 19:10:52 +0000 (08:10 +1300)]
Merge remote branch 'kc/new/bug_5186' into kcmaster

9 years agoBug 5186: Follow-up - Fixing wrong database number
Katrin Fischer [Thu, 23 Sep 2010 23:24:19 +0000 (01:24 +0200)]
Bug 5186: Follow-up - Fixing wrong database number

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_5240' into kcmaster
Chris Cormack [Sun, 9 Jan 2011 20:16:50 +0000 (09:16 +1300)]
Merge remote branch 'kc/new/bug_5240' into kcmaster

9 years agoMerge remote branch 'kc/new/bug_5186' into kcmaster
Chris Cormack [Sun, 9 Jan 2011 20:14:22 +0000 (09:14 +1300)]
Merge remote branch 'kc/new/bug_5186' into kcmaster

9 years agoMerge remote branch 'kc/new/bug_4838' into kcmaster
Chris Cormack [Sun, 9 Jan 2011 20:13:17 +0000 (09:13 +1300)]
Merge remote branch 'kc/new/bug_4838' into kcmaster

9 years agoMerge remote branch 'kc/new/enh/bug_5560' into kcmaster
Chris Cormack [Sun, 9 Jan 2011 20:11:50 +0000 (09:11 +1300)]
Merge remote branch 'kc/new/enh/bug_5560' into kcmaster

9 years agoBug 5589: Remove duplicated Exports in Suggestions.pm
Colin Campbell [Fri, 7 Jan 2011 11:44:03 +0000 (11:44 +0000)]
Bug 5589: Remove duplicated Exports in Suggestions.pm

Rather bizarrely Suggestions.pm was setting up @EXPORT, @ISA
and $VERSION twice. Have removed one invocation

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 4984, Invalid XHTML in staff client search results
Owen Leonard [Wed, 5 Jan 2011 08:24:53 +0000 (03:24 -0500)]
Fix for Bug 4984, Invalid XHTML in staff client search results

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoAdditional fix for Bug 3550, Use GetRecordValue to get the subtitle
Owen Leonard [Fri, 7 Jan 2011 10:34:11 +0000 (05:34 -0500)]
Additional fix for Bug 3550, Use GetRecordValue to get the subtitle

- Adding subtitle to Hold Ratio report output
- Sorting by default on ratio, descending
- Adding author
- Removing description

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5480 Some usual UNIMARC cataloguing plugins doesn't work anymore
Frédéric Demians [Mon, 20 Dec 2010 13:13:41 +0000 (14:13 +0100)]
Bug 5480 Some usual UNIMARC cataloguing plugins doesn't work anymore

[3.2] To be applied

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_4820' into kcmaster
Chris Cormack [Fri, 7 Jan 2011 01:27:06 +0000 (14:27 +1300)]
Merge remote branch 'kc/new/enh/bug_4820' into kcmaster

9 years agoFollow-up on fix for Bug 4820, Alter layout of Circulation and fines rules page
Owen Leonard [Thu, 6 Jan 2011 21:03:07 +0000 (16:03 -0500)]
Follow-up on fix for Bug 4820, Alter layout of Circulation and fines rules page

One instance of "default" usage missed in the original update

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFollow up on fix for Bug 5570, item types not showing on other editions
Owen Leonard [Thu, 6 Jan 2011 21:31:00 +0000 (16:31 -0500)]
Follow up on fix for Bug 5570, item types not showing on other editions

Fix for the staff client.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>