wip/koha-chris_n.git
12 years agoRemove string processing (redundant to new pagination_bar)
Joe Atzberger [Tue, 27 May 2008 23:05:59 +0000 (18:05 -0500)]
Remove string processing (redundant to new pagination_bar)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSingle FIXME comment inserted.
Joe Atzberger [Tue, 27 May 2008 23:05:58 +0000 (18:05 -0500)]
Single FIXME comment inserted.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCommented out fixaccounts (not used anywhere). Also improved getnextacctno.
Joe Atzberger [Tue, 27 May 2008 23:05:57 +0000 (18:05 -0500)]
Commented out fixaccounts (not used anywhere). Also improved getnextacctno.

You can test getnextacctno like:
perl -e 'use C4::Accounts; print getnextacctno(33), "\n";'
where 33 is a borrowernumber out of the accountlines table.  Get that number like:
mysql> select borrowernumber,accountno from accountlines LIMIT 100;

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrect number of args to getnextacctno.
Joe Atzberger [Tue, 27 May 2008 23:04:13 +0000 (18:04 -0500)]
Correct number of args to getnextacctno.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrected wrong number of arguments to getnextacctno.
Joe Atzberger [Tue, 27 May 2008 23:04:12 +0000 (18:04 -0500)]
Corrected wrong number of arguments to getnextacctno.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBugfix 2026 - Comments handling overhauled. Scrubber and Error feedback added.
Joe Atzberger [Thu, 22 May 2008 20:10:22 +0000 (15:10 -0500)]
Bugfix 2026 - Comments handling overhauled. Scrubber and Error feedback added.

Note: we CANNOT rely on window.close in onSubmit or $().submit to close our popups.
On a relatively slow connection with a relatively large POST, commonly the close finishes
*before* the POST completes, as reported with our New Zealand clients.  Despite success in
trivial cases, this should be obvious, since the event is necessarily before the submission.
It also assumes success and prevents any kind of error feedback.  Other popups are likely
to exhibit this same defective behavior.

Some FIXME's outstanding: need to allow users to delete their own comments,
need to enforce and feedback on max comment length.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBugfix 1978 - if invalid duedate specified, return error, do not issue.
Joe Atzberger [Thu, 22 May 2008 15:24:09 +0000 (10:24 -0500)]
Bugfix 1978 - if invalid duedate specified, return error, do not issue.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofixed session cookie name in opac-logout.pl
Michael Hafen [Tue, 27 May 2008 18:11:21 +0000 (12:11 -0600)]
fixed session cookie name in opac-logout.pl

Session Cookie name is CGISESSID in Auth.pm

Signed-off-by: Michael Hafen <mdhafen@washk12.org>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUnescape Comment, now that we trust Scrubber to block bad markup.
Joe Atzberger [Fri, 23 May 2008 07:40:49 +0000 (02:40 -0500)]
Unescape Comment, now that we trust Scrubber to block bad markup.

Obviously if we are going to allow good markup, we can't then escape it.
Documentation reference: allowed tags for comments are:
br b i em big small strong

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTags AJAX and JSON for OPAC side.
Joe Atzberger [Wed, 21 May 2008 06:36:05 +0000 (01:36 -0500)]
Tags AJAX and JSON for OPAC side.

Note, all Tags js will live under KOHA.Tags namespace.
See opac-tags.pl perldoc for AJAX/JSON examples.  The capability is already
there to be very web-servicey, even moreso than the current OPAC implementation
will utilize.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSingle slash added in test text string.
Joe Atzberger [Mon, 19 May 2008 22:03:11 +0000 (17:03 -0500)]
Single slash added in test text string.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdd error feedback and Scrubber to OPAC tags page. Beginnings of ajax code.
Joe Atzberger [Mon, 19 May 2008 21:23:38 +0000 (16:23 -0500)]
Add error feedback and Scrubber to OPAC tags page. Beginnings of ajax code.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoInitial commit for Tags back-end moderation. Requires AJAX functions from Output.
Joe Atzberger [Mon, 19 May 2008 21:23:37 +0000 (16:23 -0500)]
Initial commit for Tags back-end moderation. Requires AJAX functions from Output.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoNew subs for moderation, fixed bug to allow multiple sort fields, added POD.
Joe Atzberger [Mon, 19 May 2008 21:23:36 +0000 (16:23 -0500)]
New subs for moderation, fixed bug to allow multiple sort fields, added POD.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdd AJAX output sub, EXPORT_TAGS and enable loop_context_vars for HTML::Template...
Joe Atzberger [Mon, 19 May 2008 21:23:35 +0000 (16:23 -0500)]
Add AJAX output sub, EXPORT_TAGS and enable loop_context_vars for HTML::Template::Pro.

The loop_context_vars will be very useful in display.  They are:
__first__, __last__, __inner__, __odd__, __counter__.
Note: apparently __even__ does not exist, so instead use something like:
<!-- TMPL_UNLESS NAME="__odd__" -->

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdd cn_source to authorised values dropdown in marc structure editor.
Ryan Higgins [Sun, 25 May 2008 06:21:42 +0000 (01:21 -0500)]
Add cn_source to authorised values dropdown in marc structure editor.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agosmall update to french translation
Paul POULAIN [Thu, 22 May 2008 20:47:25 +0000 (22:47 +0200)]
small update to french translation

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofixing the css property for tablesorter js
Paul POULAIN [Thu, 22 May 2008 20:47:23 +0000 (22:47 +0200)]
fixing the css property for tablesorter js

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBUGFIXING authority link in detail.pl
Paul POULAIN [Thu, 22 May 2008 20:47:21 +0000 (22:47 +0200)]
BUGFIXING authority link in detail.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agosmall fix for UNIMARC 600$a that is also subject
Paul POULAIN [Thu, 22 May 2008 20:47:20 +0000 (22:47 +0200)]
small fix for UNIMARC 600$a that is also subject

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding Image::Magick version info
Paul POULAIN [Thu, 22 May 2008 20:47:19 +0000 (22:47 +0200)]
Adding Image::Magick version info

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUpdate Catalog Stats report: / Remove lccn/loc filter, which seems to conflate marc21...
Ryan Higgins [Sun, 25 May 2008 20:54:21 +0000 (15:54 -0500)]
Update Catalog Stats report: / Remove lccn/loc filter, which seems to conflate marc21 010 and 050. / Update labels to reflect 3.0 terminology.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFill statistics table properly for renewals; and issue->checkout, return->checkin
Ryan Higgins [Sun, 25 May 2008 07:54:18 +0000 (02:54 -0500)]
Fill statistics table properly for renewals; and issue->checkout, return->checkin

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdd ANSCR to default cn_source list.
Ryan Higgins [Sun, 25 May 2008 06:21:56 +0000 (01:21 -0500)]
Add ANSCR to default cn_source list.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix pagination error on subfield structure editor
Ryan Higgins [Sun, 25 May 2008 06:21:17 +0000 (01:21 -0500)]
Fix pagination error on subfield structure editor

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadd URLLinkText syspref to opac detail, and add some extra handling for MARC 21 urls.
Ryan Higgins [Sat, 24 May 2008 19:35:08 +0000 (14:35 -0500)]
add URLLinkText syspref to opac detail, and add some extra handling for MARC 21 urls.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoShow 856$3 (materials specified) by default in MARC21 .
Ryan Higgins [Sat, 24 May 2008 19:35:07 +0000 (14:35 -0500)]
Show 856$3 (materials specified) by default in MARC21 .

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUpdate MARC21 simple frameworks with biblio.serial and items.enumchron
Ryan Higgins [Thu, 22 May 2008 14:26:56 +0000 (09:26 -0500)]
Update MARC21 simple frameworks with biblio.serial and items.enumchron

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTranslatable facets in librarian interface
Frederic Demians [Tue, 20 May 2008 20:30:41 +0000 (22:30 +0200)]
Translatable facets in librarian interface

Pushes modified facets display from OPAC to librarian interface.
Corrects also OPAC version which were omitting Titles facet.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFacets (current) translatable via template
Frederic Demians [Tue, 20 May 2008 20:06:58 +0000 (22:06 +0200)]
Facets (current) translatable via template

This patch allows to translate facets label with standart
templates / PO files. Facets are still hard coded in Koha.pm.
Template wait those hard coded facets: Topics, Places, Titles,
Autors and Libraries.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoremoving warnings from C4::Members::GetMember
Andrew Moore [Fri, 23 May 2008 18:35:33 +0000 (13:35 -0500)]
removing warnings from C4::Members::GetMember

C4::Members::GetMember emitted a few unnecessary warnings when no $type was passed in. This patch prevents that.

No functional or documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug 2047: some tests for C4::Biblio::get_biblio_authorised_values
Andrew Moore [Fri, 23 May 2008 17:36:30 +0000 (12:36 -0500)]
Bug 2047: some tests for C4::Biblio::get_biblio_authorised_values

I had these tests laying around for a while. I just forgot to commit them.

No functional or documentation changes needed.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding bookfund search to aqbudget.tmpl
Owen Leonard [Fri, 23 May 2008 20:49:14 +0000 (15:49 -0500)]
Adding bookfund search to aqbudget.tmpl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding routing list link to table of information about each subscription (Bug 2059...
Owen Leonard [Fri, 23 May 2008 20:49:01 +0000 (15:49 -0500)]
Adding routing list link to table of information about each subscription (Bug 2059, "Link to Serial Collection routing list missing on menu")

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix for bug 2130, "Patron Image Missing on Permissions Screen"; Correction to allow...
Owen Leonard [Fri, 23 May 2008 20:48:48 +0000 (15:48 -0500)]
Fix for bug 2130, "Patron Image Missing on Permissions Screen"; Correction to allow proper tab highlighting when viewing patron log.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix for Bug 2120, "
Owen Leonard [Thu, 22 May 2008 14:50:19 +0000 (09:50 -0500)]
Fix for Bug 2120, "

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAuthorities detail page was missing toolbar, breadcrumbs.
Owen Leonard [Thu, 22 May 2008 14:50:10 +0000 (09:50 -0500)]
Authorities detail page was missing toolbar, breadcrumbs.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMarkup error caused layout problems.
Owen Leonard [Thu, 22 May 2008 14:49:58 +0000 (09:49 -0500)]
Markup error caused layout problems.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoStructural changes to staff client main page to better handle layout changes with...
Owen Leonard [Thu, 22 May 2008 14:49:51 +0000 (09:49 -0500)]
Structural changes to staff client main page to better handle layout changes with addition/subtraction of news and intranetmainuserblock markup.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTerminology correction: cancelled -> withdrawn. Also adding dateformat variable to...
Owen Leonard [Thu, 22 May 2008 14:49:40 +0000 (09:49 -0500)]
Terminology correction: cancelled -> withdrawn. Also adding dateformat variable to new holds queue script to allow correct table sorting with metric dates.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding breadcrumbs to advanced search screen to get us a Home link.
Owen Leonard [Thu, 22 May 2008 14:49:27 +0000 (09:49 -0500)]
Adding breadcrumbs to advanced search screen to get us a Home link.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding table sorter to holds queue report
Owen Leonard [Thu, 22 May 2008 14:48:40 +0000 (09:48 -0500)]
Adding table sorter to holds queue report

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTweak to OPAC search bar to help prevent wrapping.
Owen Leonard [Thu, 22 May 2008 14:48:31 +0000 (09:48 -0500)]
Tweak to OPAC search bar to help prevent wrapping.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMinor change to improve layout at lower resolutions.
Owen Leonard [Tue, 20 May 2008 19:28:04 +0000 (14:28 -0500)]
Minor change to improve layout at lower resolutions.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoInterface improvements to Holds Queue report and changes to the script provided by jmf
Owen Leonard [Tue, 20 May 2008 19:27:55 +0000 (14:27 -0500)]
Interface improvements to Holds Queue report and changes to the script provided by jmf

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix for Bug 2147, "Search Results aligned top on staff side."
Owen Leonard [Tue, 20 May 2008 19:27:47 +0000 (14:27 -0500)]
Fix for Bug 2147, "Search Results aligned top on staff side."

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix an encoding issue on circulation autocompletion
Frederic Demians [Tue, 20 May 2008 16:41:35 +0000 (18:41 +0200)]
Fix an encoding issue on circulation autocompletion

ysearch.pl returns a list of borrower details for circulation
autocomplete widget. Accented characters wasn't displayed
correctly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofix for #1788 : Locations do not sort alphabetically by name in list on "Set" location
Paul POULAIN [Tue, 20 May 2008 16:21:11 +0000 (18:21 +0200)]
fix for #1788 : Locations do not sort alphabetically by name in list on "Set" location

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobugfixing batchupdateISBN.pl
Paul POULAIN [Tue, 20 May 2008 16:21:10 +0000 (18:21 +0200)]
bugfixing batchupdateISBN.pl

pls, someone from MARC21 confirm.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agovarious bugfixes for MARC21 Z39.50 targets
Galen Charlton [Tue, 20 May 2008 16:09:16 +0000 (11:09 -0500)]
various bugfixes for MARC21 Z39.50 targets

[1] Added MARC-8 as an encoding choice on the target
    administration page.
[2] Fixed TMPL coding errors.
[3] Set the correct encoding (as it happens, 'MARC-8')
    for all of the English sample Z39.50 targets.

Documentation note: due to this patch and the ones from
Frederic, screenshots of the page for editing a Z39.50
target should be redone.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2048 - improve zebraqueue_daemon performance
Galen Charlton [Tue, 20 May 2008 15:48:00 +0000 (10:48 -0500)]
kohabug 2048 - improve zebraqueue_daemon performance

[1] Increase sleep interval between checks of zebraqueue
    from 0.01 seconds to 0.50.
[2] Batch up commits of changes to the zebraqueue table
[3] If the same record appears multiple times in the queue,
    handle only once.
[4] Properly postpone failures to process record deletes to
    avoid spinning.
[5] Correct how queue entries are marked done - avoid skipping
    an authority record update, e.g., if it has the same
    ID number as a bib that was updated.
[6] Added a FIXME about a possible later enhancement to
    batch up updates so that Zebra isn't told to commit
    after each record.

No documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAllowing delete-biblio menu item to trigger javascript warning. Style now mimicsa...
Owen Leonard [Tue, 20 May 2008 12:50:22 +0000 (07:50 -0500)]
Allowing delete-biblio menu item to trigger javascript warning. Style now mimicsa disabled menu item. Addresses Bug 2135, "Cannot Delete MARC Records."

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFinal update to holds queue work: adds link to holds queue
Joshua Ferraro [Tue, 20 May 2008 17:36:40 +0000 (12:36 -0500)]
Final update to holds queue work: adds link to holds queue
from circulation dashboard, creates new sysprefs, assigns
the sysprefs to the proper tab in sysprefs (Circulation),
updatedatabase changes to do the previous, and fixing one
redundent limit in the query for build_holds_queue.pl

Note: still need to address item-level holds

12 years agoAdds a cron script to be run periodically that populates
Joshua Ferraro [Tue, 20 May 2008 15:58:24 +0000 (10:58 -0500)]
Adds a cron script to be run periodically that populates
the tmp_holdsqueue table. This is an alternative holds
targeting workflow that is more suitable for multi-location
libraries than the default holds picklist report.

Note to documentation writers: this summary should be
added to any holds documentation as an overview of
the avaialable methods for holds fulfillment.

This alternative holds workflow assumes an
expectation that the system should target a specific
item for a given hold request, attempt to fulfill the
hold with that item, and if unable to fulfill, select
an available item at another location to fulfill the
hold.

This is quite different than the default Koha behavior
which uses a 'broadcast' method of hold fulfillment.

How it works:

This script weights available locations for holds based
on options specified in two system preferences:

StaticHoldsQueueWeight
Allows the library to specify a list of library
location codes -- if used alone, it will rank the
list statically, selecting the top-ranking available
location to be added to the picklist.

RandomizeHoldsQueueWeight
If RandomizeHoldsQueueWeight and StaticHoldsQueueWeight
are set, the list of library codes in the
StaticHoldsQueueWeight syspref are randomized rather
than statically ranked. If RandomizeHoldsQueueWeight
alone is set, the list of all available library codes
is used to randomize the weight.

If neither syspref is set, the list is statically
ranked according to how they are pulled out of the system
database.

NOTE: This has not yet been tested with item-level holds

12 years agoDB Update .086: adding new table tmp_holdsqueue,
Joshua Ferraro [Tue, 20 May 2008 14:36:26 +0000 (09:36 -0500)]
DB Update .086: adding new table tmp_holdsqueue,
used for reporting picklist for holds in multi-location
libraries. This is a temporary workaround to a longer-term
post-3.0 cleanup of the holds process.

Following this will be a cron job for managing the
holds picklist queue as well as a report for viewing
the list of items from circulation

12 years agoFix for Bug 1955: Remove noOPACUserLogin system preference
Joshua Ferraro [Tue, 20 May 2008 00:11:19 +0000 (19:11 -0500)]
Fix for Bug 1955: Remove noOPACUserLogin system preference

12 years agoFix for bug 1952: OPACUserCSS preference has incorrect description
Joshua Ferraro [Tue, 20 May 2008 00:05:44 +0000 (19:05 -0500)]
Fix for bug 1952: OPACUserCSS preference has incorrect description

12 years agocorrect path to 404.pl in opac-details.pl
Galen Charlton [Mon, 19 May 2008 19:28:37 +0000 (14:28 -0500)]
correct path to 404.pl in opac-details.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2141 - avoid carp on display of details of deleted bib
Galen Charlton [Mon, 19 May 2008 19:28:36 +0000 (14:28 -0500)]
kohabug 2141 - avoid carp on display of details of deleted bib

When displaying details of bib in staff interface, check
that bib actually exists and display 404 page if not.  Avoids
following fatal error:

Can't call method "field" on an undefined value at /home/gmc/koha/dev/C4/Biblio.pm line 944.

This situtation can arise when running Zebra; if a bib is deleted,
Zebra will not necessarily be reindexed instantly, allowing a link
from a search result list to point to a missing record.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agominor POD improvement
Galen Charlton [Mon, 19 May 2008 19:28:35 +0000 (14:28 -0500)]
minor POD improvement

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBUGFIX - pagination bar was not in template, so only the first 20 hits were
Joe Atzberger [Mon, 19 May 2008 20:36:37 +0000 (15:36 -0500)]
BUGFIX - pagination bar was not in template, so only the first 20 hits were

 pagination bar was not in template, so only the first 20 hits were
 visible.  Probably it wasn't included because the script referenced a bogus base URL.
 Also debugified warn statement in script.  Note FIXME for bogus template reference.
 We probably don't need that template or the related selector lines for it.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding RenewSerialAddsSuggestion syspref to Acquisitions tab
Joshua Ferraro [Mon, 19 May 2008 20:27:21 +0000 (15:27 -0500)]
Adding RenewSerialAddsSuggestion syspref to Acquisitions tab

12 years agotest suite: allow skipping of expensive tests
Galen Charlton [Mon, 19 May 2008 14:59:02 +0000 (09:59 -0500)]
test suite: allow skipping of expensive tests

Defined a function attribute for KohaTest and subclasses
called 'Expensive'.  When a test method has that attribute,
it is skipped unless the RUN_EXPENSIVE_TESTS environment
variable is true.

To mark a test method, expensive, do this:

sub test_foo : Tests(4) Expensive { ... }

To mark a whole class and its subclasses expensive,
define a SKIP_CLASS sub (with empty body) with the
Expensive attribute:

sub SKIP_CLASS : Expensive { }

Updated the t/Makefile so that 'make test' runs
nonexpensive tests, while 'make fulltest' runs both
cheap and expensive tests.

Marked KohaTest::Installer test class expensive.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCSS fix for Internet Explorer display problem caused by previous commit.
Owen Leonard [Mon, 19 May 2008 15:05:04 +0000 (10:05 -0500)]
CSS fix for Internet Explorer display problem caused by previous commit.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTemplate restructuring to allow option of styling OPAC with fixed-width layout. This...
Owen Leonard [Mon, 19 May 2008 14:34:59 +0000 (09:34 -0500)]
Template restructuring to allow option of styling OPAC with fixed-width layout. This commit doesn't change the default OPAC appearance.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding padding to <p> to improve some readability issues; Correcting terminology...
Owen Leonard [Mon, 19 May 2008 14:34:46 +0000 (09:34 -0500)]
Adding padding to <p> to improve some readability issues; Correcting terminology in the cart (shelf -> list); Minor punctuation change in results.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoA couple of fixes: Logs tab was not highlighted when chosen; Serials checkexpiration...
Owen Leonard [Mon, 19 May 2008 14:34:16 +0000 (09:34 -0500)]
A couple of fixes: Logs tab was not highlighted when chosen; Serials checkexpiration.pl linked to biblio detail rather than subscription detail. Also adding 'edit' and 'renew' links to those results.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTrying again to fix tab issues in Internet Explorer.
Owen Leonard [Mon, 19 May 2008 14:34:04 +0000 (09:34 -0500)]
Trying again to fix tab issues in Internet Explorer.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMinor updates to XSL display
Joshua Ferraro [Mon, 19 May 2008 18:05:49 +0000 (14:05 -0400)]
Minor updates to XSL display

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoEnhancement Jacket Covers in Shelf Browser should link to bib record, not to source...
Joshua Ferraro [Sun, 18 May 2008 12:02:11 +0000 (08:02 -0400)]
Enhancement Jacket Covers in Shelf Browser should link to bib record, not to source of image

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFixing isbn regex to not match unless isbn is valid
Joshua Ferraro [Sun, 18 May 2008 11:37:59 +0000 (07:37 -0400)]
Fixing isbn regex to not match unless isbn is valid

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoDon't display Acquisitions and Serials links if the user
Joshua Ferraro [Mon, 19 May 2008 18:01:04 +0000 (13:01 -0500)]
Don't display Acquisitions and Serials links if the user
doesn't have permission to view them

12 years agoAdding pipe (|) as delimitor option
Joshua Ferraro [Mon, 19 May 2008 16:34:12 +0000 (11:34 -0500)]
Adding pipe (|) as delimitor option

12 years agoFix links for web resources to display a 'Click here to access online' when no label...
Koha Production [Sun, 18 May 2008 03:39:26 +0000 (23:39 -0400)]
Fix links for web resources to display a 'Click here to access online' when no label is specified (XSLT only). Note that on the results screen, the links now show up in place of the Availability: section

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFixing Literary Form: display for Sound records
Koha Production [Sun, 18 May 2008 01:56:29 +0000 (21:56 -0400)]
Fixing Literary Form: display for Sound records

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRemoving bib-level Call Number from display -- can be added to XSL based on library...
hcpl test [Sun, 18 May 2008 01:42:32 +0000 (21:42 -0400)]
Removing bib-level Call Number from display -- can be added to XSL based on library preferences if desired

Signed-off-by: Koha Production <koha-pro@koha-01.hclibrary.org>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFixing Amazon.com Similar Items and Editions features
Joshua Ferraro [Sun, 18 May 2008 01:35:48 +0000 (21:35 -0400)]
Fixing Amazon.com Similar Items and Editions features

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding wrapping container around OpacMainUserBlock syspref
Joshua Ferraro [Sat, 17 May 2008 23:49:26 +0000 (18:49 -0500)]
Adding wrapping container around OpacMainUserBlock syspref

12 years agoFix bug in /admin/z3950servers.pl
Frederic Demians [Sat, 17 May 2008 21:23:12 +0000 (23:23 +0200)]
Fix bug in /admin/z3950servers.pl

Third attempt to correct a bug affecting this page.
Combo lists wasn't reflecting DB content in modification.
To Joshua: You have to apply patch 2 first (patch 1 isn't required)
since I applied this quick fix without rolling back to original state!

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix bug in /admin/z3950servers.pl
Frederic Demians [Sat, 17 May 2008 20:08:35 +0000 (22:08 +0200)]
Fix bug in /admin/z3950servers.pl

Improve previous patch which was badly coded as pointed out by
Henri-Damien. <TMPL_IF> clauses were included in HTML tags:
it fails translator tool.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix a bug in /admin/z3950servers.pl page
Frederic Demians [Sat, 17 May 2008 10:55:24 +0000 (12:55 +0200)]
Fix a bug in /admin/z3950servers.pl page

On /admin/z3950servers.pl page, modifying a z3950 host wasn't working
properly. Selected values in Syntax and Encoding combo boxes were hard
coded rather than selected based on record values.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agochanging defaults for french system preferences.
Marc Chantreux [Fri, 16 May 2008 11:25:27 +0000 (13:25 +0200)]
changing defaults for french system preferences.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug Fixing : ModMember and memberentrygen.tmpl
Henri-Damien LAURENT [Fri, 16 May 2008 08:03:16 +0000 (10:03 +0200)]
Bug Fixing : ModMember and memberentrygen.tmpl

Problem with ModMember : parameters were not passed safely
memberentrygen.tmpl deleted guarantorid for a children if step2 or step3 used fore edition.
Changeing TMPL_IF EXPR into TMPL_IF Name

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAltering CSS to make holding table on opac MARC view more compact. Adding "new" link...
Owen Leonard [Thu, 15 May 2008 19:40:26 +0000 (14:40 -0500)]
Altering CSS to make holding table on opac MARC view more compact. Adding "new" link to opac suggestions screen for display when there are no suggestions (Bug 2110 Can't place suggestion from my suggestions tab in OPAC)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix for problem introduced by previous attempt to fix Internet Explorer issues. Previ...
Owen Leonard [Thu, 15 May 2008 19:40:18 +0000 (14:40 -0500)]
Fix for problem introduced by previous attempt to fix Internet Explorer issues. Previous fix caused drop-down menu to appear behind circ search form.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobugfix - fix 'not' operator in NoZebra
Galen Charlton [Wed, 14 May 2008 22:09:43 +0000 (17:09 -0500)]
bugfix - fix 'not' operator in NoZebra

Corrected bug that prevented the 'not' operator
from working consistently - i.e., a search of
'mice not men' would not always work.

Also added test cases for NoZebra, so far focusing on
NZanalyse and adding and deleting bibs.  A couple of
the test cases are currently known to fail and
therefore are marked TODO.  The tests in question
are to verify that rows in nozebra are removed if
no bib is linked to the relevant word.  However, it
looks like such rows are retained, just with
nozebra.biblionubmers set to ''.  Is there any
reason to keep these rows?

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2020 - fix infinite loop in NoZebra on Perl 5.10
Galen Charlton [Wed, 14 May 2008 22:09:42 +0000 (17:09 -0500)]
kohabug 2020 - fix infinite loop in NoZebra on Perl 5.10

When running Koha in NoZebra mode under Perl 5.10, a search
containing a operator (e.g., "mice and men") could cause
a bib search to enter into an infinite loop in NZanalyse.

This possibility arises from the fact that NZanalyse used
to use capture variables from regular expressions without
verifying whether the regular expressions actually matched.
It was compounded by the fact that NZanalyse is recursive;
however, because $1, $2, etc. are dynamically scoped,
*they are not automatically cleared when NZanalyse calls
itself*.

Consequently, if the search string contains a boolean
operator, it would be split into

left = mice
operator = and
right = men

Then NZanalyse would be called recursively on the search
string 'mice'.  However, because $1, $2, and $3 are not
automatically cleared when the function is called again,
and because they are not cleared if a match fails, the code
would fail to recognize that 'mice' is leaf, and would
call NZanalyse('mice') repeatedly, to the promotion of
warm server rooms.

The wrinkle in this is that because of a bug in Perl 5.8, a
failing matches can sometimes alter the capture variables, thus
avoiding the infinite recursion.  However,  this bug was fixed in
Perl 5.10, leading to the NZanalyse bug becoming evident.

The Perl bug is described at http://rt.perl.org/rt3/Public/Bug/Display.html?id=19049
and the fix http://public.activestate.com/cgi-bin/perlbrowse/p/29279.

The fix to the Koha code is to check whether each regexp
that uses capture variables matches or fails, then act
accordingly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2100 - allow deletion of non-default MARC framework
Galen Charlton [Wed, 14 May 2008 22:09:41 +0000 (17:09 -0500)]
kohabug 2100 - allow deletion of non-default MARC framework

An earlier attempt to prevent deletion of default framework
by passing a suitably constructured URL actually had
the opposite effect - the default framework could be deleted,
but ia hon-default one could not.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdd HTML::Scrubber dependency to Makefile.PL
Joe Atzberger [Wed, 14 May 2008 16:07:39 +0000 (11:07 -0500)]
Add HTML::Scrubber dependency to Makefile.PL

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBugfix ShelfBrowser using unsanitized ISBNs. Owen reported the
Joe Atzberger [Wed, 14 May 2008 16:07:38 +0000 (11:07 -0500)]
Bugfix ShelfBrowser using unsanitized ISBNs. Owen reported the

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agounimarc_complet framework: put 801$a in tab 8
Galen Charlton [Mon, 12 May 2008 21:59:32 +0000 (16:59 -0500)]
unimarc_complet framework: put 801$a in tab 8

Put the 801$a in tab 8, not 0, so that a valid 801
does not get split by the bib editor.

Signoff from Paul or Henri-Damien requested before
committing this patch.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug 1953: removing potential SQL injections from C4::Calendar::_init
Andrew Moore [Tue, 13 May 2008 17:00:55 +0000 (12:00 -0500)]
Bug 1953: removing potential SQL injections from C4::Calendar::_init

This patch changes the 4 select statements in C4::Calendar::_init.
tests for this method were included in a previous patch.

There are more potential problems in C4::Calendar::delete_holiday, but that
method seems to have deeper bugs than just these. I'll open another bug for
them if I can figure out how it's supposed to work.

No documentation changes necessary.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug 1953: adding tests and 2 corrections for C4::Calendar
Andrew Moore [Tue, 13 May 2008 17:00:54 +0000 (12:00 -0500)]
Bug 1953: adding tests and 2 corrections for C4::Calendar

In the course of writing tests for C4::Calendar, I found two bugs and am fixing them here.
One is a documentation bug.
The other prevented C4::Calendar::insert_exception_holiday from working. I was unable
to find anywhere else in the code that depended on the broken behaviour.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2105: prevent crash on IE7
Galen Charlton [Tue, 13 May 2008 21:40:15 +0000 (16:40 -0500)]
kohabug 2105: prevent crash on IE7

Three scripts were incorrect setting the HTTP type
header to 'utf-8' instead of something appropriate
like 'text/html' - Firefox evidentally can ignore that
mistake, but IE7 does not.

Fixed by replacing an invalid print of the HTTP header
and template output with a call to
C4::Output::output_html_with_http_headers.

Also corrected POD in C4::Auth and InstallAuth to
reflect correct use of output_html_with_http_headers.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 1621 - add subtitle to main results and details pages
Galen Charlton [Tue, 13 May 2008 17:32:06 +0000 (12:32 -0500)]
kohabug 1621 - add subtitle to main results and details pages

Including the subtitle in search results and OPAC and staff
details templates.  The subtitle is expected to be in the
MARC subfield that is mapped to the (now nonexistant) column
bibliosubtitle.subtitle.

This is a fairly hackish patch that is meant to be minimally
disruptive while allowing subtitles to be displayed for those
not using the experimental XSLT bib display feature.  It
does *not* cover all cases where you have a MARC
record and want to display its subtitle.

UNIMARC notes: at the moment, none of the fr-FR UNIMARC
frameworks appear to be map any subfields to bibliosubtitle.subtitle.
This could be changed, but caveat programmer: the UNIMARC 200$e
is repeatable (meaning that get_koha_field_from_marc will put in ' | '
between multiple subtitles) and one may want to also include the
200$d (parallel title).  A GetMarcSubtitle routine may be in order
if absolutely necessary.

This points to a long-term need to make display of MARC (and later, hopefully,
non-MARC) bib records more flexible - the XSLT feature is one approach;
there may be others.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agopatron cleaning - do not delete staff borrowers
Galen Charlton [Tue, 13 May 2008 15:56:49 +0000 (10:56 -0500)]
patron cleaning - do not delete staff borrowers

Adjusted C4::Members::GetBorrowersWhoHaveNotBorrowedSince so
that staff member records are not selected for deletion.

This functionality change is motivated by the consideration
that a staff member who is authorized to operate Koha is
not necessarily a prolific user of the library's services.
If a batch purge job for inactive staff records is really need,
it should be a separate tool.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 1573 - properly count patrons to delete
Galen Charlton [Tue, 13 May 2008 15:56:48 +0000 (10:56 -0500)]
kohabug 1573 - properly count patrons to delete

When both the patron delete and patron anonymize checkboxes
were selected, the patron cleaning tool would not
properly register the number of patrons to delete.  Fixed
by correcting form input handling.

Also, count of patrons to delete or anonymous now correct
when running with IndependentBranches = ON.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRecent changes to YUI path preference require local OPAC copies of YUI library files.
Owen Leonard [Tue, 13 May 2008 13:51:28 +0000 (08:51 -0500)]
Recent changes to YUI path preference require local OPAC copies of YUI library files.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobugfixing pending reserves
Paul POULAIN [Tue, 13 May 2008 13:17:23 +0000 (15:17 +0200)]
bugfixing pending reserves

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding COinS markup to shelves and results.
Owen Leonard [Tue, 13 May 2008 12:41:40 +0000 (07:41 -0500)]
Adding COinS markup to shelves and results.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>