wip/koha-chris_n.git
12 years agoPatch from Joe Atzberger to remove $Id$ and $Log$ from scripts
Chris Cormack [Thu, 18 Oct 2007 09:05:39 +0000 (04:05 -0500)]
Patch from Joe Atzberger to remove $Id$ and $Log$ from scripts

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTotal Test Overhaul! Most of these were stubs, and still are.
Joe Atzberger [Thu, 18 Oct 2007 08:46:20 +0000 (03:46 -0500)]
Total Test Overhaul! Most of these were stubs, and still are.

Input.t was replaced because it tested a now obsolete function.
Input.pm has that function commented out.
Several files were renamed to match their counterparts or
correct misspellingz.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRenamed file to match module. Trivial change.
Joe Atzberger [Thu, 18 Oct 2007 03:19:08 +0000 (22:19 -0500)]
Renamed file to match module. Trivial change.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding new circulation-home, what we ultimately hope to be a "dashboard" interface...
Owen Leonard [Thu, 18 Oct 2007 03:08:06 +0000 (22:08 -0500)]
Adding new circulation-home, what we ultimately hope to be a "dashboard" interface for circulation functions. circulation-home.pl was created by copy-and-paste, so it should be reviewed. Circulation sub-pages' breadcrumb links have been updated to point to circulation-home.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFormatting admin entry forms, improving breadcrumb navigation.
Owen Leonard [Thu, 18 Oct 2007 02:54:19 +0000 (21:54 -0500)]
Formatting admin entry forms, improving breadcrumb navigation.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug-Fix : Display ISBN was not correct for ISBN-13
Henri-Damien LAURENT [Wed, 17 Oct 2007 20:20:38 +0000 (15:20 -0500)]
Bug-Fix : Display ISBN was not correct for ISBN-13

Copy/Pasting formulas errors.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofines management (bugfixes & minor improvement)
Paul POULAIN [Wed, 17 Oct 2007 20:20:37 +0000 (15:20 -0500)]
fines management (bugfixes & minor improvement)

- pay.pl fixed, the librarian can see patron fines & mark them paid
- fines2.pl fixed, the script now calculate the fines correctly from the finerules :
  * itemtype / patron category if it exist
  * itemtype / default if needed
- renamed misc/fines.pl as fines-sanop.pl
- added 2 systempreferences:
  * MaxFine: the max amount a patron can be charged for an item
  * NoReturnSetLost: how many days of late before a non returned item is marked lost & the patron charged for the full cost of replacement
(those values where hardcoded in fines2.pl
- C4/Circulation/Fines.pm has been removed (unused duplicate of C4/Overdues)

Note that SANOP feature about notify levels have NOT been ported here. I think they are too specific now, and the code is poorly written
I've renammed fines.pl to fines-sanop.pl to point that it is specific.
Thus, all notify_id related features are not used by anything (and always 0)
Can be interesting to reintroduce them, but that will probably be a large work...

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMinor bug fix : all Branches option was not translatable
Henri-Damien LAURENT [Wed, 17 Oct 2007 20:20:36 +0000 (15:20 -0500)]
Minor bug fix : all Branches option was not translatable

Removing blank branch from search.pl to add it in template.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug Fix : 1484
Henri-Damien LAURENT [Wed, 17 Oct 2007 20:20:35 +0000 (15:20 -0500)]
Bug Fix : 1484

guarantor is now automatically filled in when coming from add Child.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobugfix for top issues, for branch selector
Paul POULAIN [Tue, 16 Oct 2007 21:02:46 +0000 (16:02 -0500)]
bugfix for top issues, for branch selector

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSearchMyLibraryFirst : reintroducing behaviour (from 2.2)
Paul POULAIN [Tue, 16 Oct 2007 21:02:45 +0000 (16:02 -0500)]
SearchMyLibraryFirst : reintroducing behaviour (from 2.2)

If the SearchMyLibraryFirst is set, then a logged user will automatically limit the search
to it's own library.

I also did some code cleaning

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoopac-logout fixed
Paul POULAIN [Tue, 16 Oct 2007 21:02:44 +0000 (16:02 -0500)]
opac-logout fixed

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoauthorities : Adding sorting option to opac & sorting mainentry asc by default
Paul POULAIN [Tue, 16 Oct 2007 21:02:43 +0000 (16:02 -0500)]
authorities : Adding sorting option to opac & sorting mainentry asc by default

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoInsecure should not be set to 'NO'
Paul POULAIN [Tue, 16 Oct 2007 21:02:42 +0000 (16:02 -0500)]
Insecure should not be set to 'NO'

but to '0'. No is 'true' for Perl.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadding YUI tabs support to authority detail
Paul POULAIN [Tue, 16 Oct 2007 21:02:41 +0000 (16:02 -0500)]
adding YUI tabs support to authority detail

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadding YUI tabs support to MARCdetail.pl
Paul POULAIN [Tue, 16 Oct 2007 21:02:40 +0000 (16:02 -0500)]
adding YUI tabs support to MARCdetail.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBUGfixing authorities editor
Paul POULAIN [Tue, 16 Oct 2007 21:02:39 +0000 (16:02 -0500)]
BUGfixing authorities editor

With the YUI tabs, the SINGLETAB feature (that hides tabs when there is only 1) was bugguy
This commit fixes the problem, and solve some other ones :
- order the fields
- resize the input size (see previous commit in addbiblio.pl)
- remove some unused code
- reindent

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoreintroducing size for fields in addbiblio
Paul POULAIN [Tue, 16 Oct 2007 21:02:38 +0000 (16:02 -0500)]
reintroducing size for fields in addbiblio

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofix for bug 1499 - normalize ISBN before dupe check
Galen Charlton [Tue, 16 Oct 2007 21:02:37 +0000 (16:02 -0500)]
fix for bug 1499 - normalize ISBN before dupe check

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBugFixing : viewlog.pl was broken (comma missing)
Henri-Damien LAURENT [Tue, 16 Oct 2007 21:02:36 +0000 (16:02 -0500)]
BugFixing : viewlog.pl was broken (comma missing)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding Biblionumber to template param list
Henri-Damien LAURENT [Tue, 16 Oct 2007 21:02:35 +0000 (16:02 -0500)]
Adding Biblionumber to template param list

This enables navigating on MARC/ISBD/Normal View

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRemoving connexion informations from basket page.
Henri-Damien LAURENT [Tue, 16 Oct 2007 21:02:34 +0000 (16:02 -0500)]
Removing connexion informations from basket page.

It masked biblio information.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug Fixing ISBD parser had problems with commas
Henri-Damien LAURENT [Tue, 16 Oct 2007 21:02:33 +0000 (16:02 -0500)]
Bug Fixing ISBD parser had problems with commas

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug Fixing : userid was blanked out in partial edit.
Henri-Damien LAURENT [Tue, 16 Oct 2007 21:02:32 +0000 (16:02 -0500)]
Bug Fixing : userid was blanked out in partial edit.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agopatches for members and resultlists.
Henri-Damien LAURENT [Tue, 16 Oct 2007 21:02:31 +0000 (16:02 -0500)]
patches for members and resultlists.

--
Henri Damien LAURENT et Paul POULAIN
Consultants indépendants
en logiciels libres et bibliothéconomie (http://www.koha-fr.org)

>From 616f0a385848b9a1fee7c76ff7b1f3be090ccb66 Mon Sep 17 00:00:00 2001
From: Henri-Damien LAURENT <henridamien@koha-fr.org>
Date: Tue, 16 Oct 2007 15:20:45 +0200
Subject: [PATCH] Bug Fixing : userid was blanked out in partial edit.
Adding some checks on branch presence for independant branches

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoDates.pm: perl test to accompany Dates.pm functions.
Joe Atzberger [Tue, 16 Oct 2007 21:02:29 +0000 (16:02 -0500)]
Dates.pm: perl test to accompany Dates.pm functions.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoDates.pm: Added functions format_date and format_date_in_iso as possible drop-in...
Joe Atzberger [Tue, 16 Oct 2007 21:02:28 +0000 (16:02 -0500)]
Dates.pm: Added functions format_date and format_date_in_iso as possible drop-in replacements for

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRevert "Minor overhaul of installer WITHOUT thorough testing. Steps broken out into"
Joshua Ferraro [Wed, 17 Oct 2007 11:58:48 +0000 (06:58 -0500)]
Revert "Minor overhaul of installer WITHOUT thorough testing. Steps broken out into"

This reverts commit b9f141a592b15339fc36f07d6350c991defaf585.

12 years agoMinor overhaul of installer WITHOUT thorough testing. Steps broken out into
Joe Atzberger [Tue, 16 Oct 2007 21:02:27 +0000 (16:02 -0500)]
Minor overhaul of installer WITHOUT thorough testing. Steps broken out into

More revision is required: CVS variables, bad use of map in void context,
overuse of multiple index lines instead of one RegExp, etc.  Koha GPL
statement at top needed.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug Fixing : Memberentry was broken.
Henri-Damien LAURENT [Mon, 15 Oct 2007 21:01:57 +0000 (16:01 -0500)]
Bug Fixing : Memberentry was broken.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoChanging the way resident search form is displayed; Reformatting admin-home.tmpl...
Owen Leonard [Mon, 15 Oct 2007 21:01:56 +0000 (16:01 -0500)]
Changing the way resident search form is displayed; Reformatting admin-home.tmpl; Updating entry form display on admin pages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBUGfixes in availability management
Paul POULAIN [Sun, 14 Oct 2007 21:20:51 +0000 (16:20 -0500)]
BUGfixes in availability management

- the availability status was not available on result list. This patch reintroduces that
- notforloan as itemtype was not properly managed : an itemtype that was notforloan resulted in nothing in detail. Not, the user can't place a reserve anymore, and the status is correctly displayed

the fix is for OPAC as well as staff

(owen, pls, validate cat-toolbar.inc & catalogue/detail.tmpl)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoChange to address Bug 1471
Owen Leonard [Fri, 12 Oct 2007 22:35:32 +0000 (17:35 -0500)]
Change to address Bug 1471

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFixes for Bug 1444. Trimming whitespace and correcting javascript form submit.
Owen Leonard [Fri, 12 Oct 2007 22:35:31 +0000 (17:35 -0500)]
Fixes for Bug 1444. Trimming whitespace and correcting javascript form submit.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix for Bug 1480 (added items link to biblio-view-menu.inc). Cleaned up display in...
Owen Leonard [Fri, 12 Oct 2007 22:35:30 +0000 (17:35 -0500)]
Fix for Bug 1480 (added items link to biblio-view-menu.inc). Cleaned up display in moredetail.tmpl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoA couple of forgotten markup corrections.
Owen Leonard [Fri, 12 Oct 2007 22:35:29 +0000 (17:35 -0500)]
A couple of forgotten markup corrections.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMore refinements to MARC structure pages navigation
Owen Leonard [Fri, 12 Oct 2007 22:35:28 +0000 (17:35 -0500)]
More refinements to MARC structure pages navigation

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years ago#1485 (issuing rules improvement) continued
Paul POULAIN [Fri, 12 Oct 2007 22:35:27 +0000 (17:35 -0500)]
#1485 (issuing rules improvement) continued

updating fines rules management :
- replacing '*' by default
- removing bottom line (*) that means nothing
- dealing correctly with .0000 fine values
- fixing fine storage

still fines.pl to do

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years ago#1485 (issuing rules improvement) continued
Paul POULAIN [Fri, 12 Oct 2007 22:35:26 +0000 (17:35 -0500)]
#1485 (issuing rules improvement) continued

issuing rules are working as expeced with this commit.
working on finesrules now

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years ago#1485 (issuing rules improvement) continued
Paul POULAIN [Fri, 12 Oct 2007 22:35:25 +0000 (17:35 -0500)]
#1485 (issuing rules improvement) continued

IMPORTANT NOTE : all existing test database for 3.0 must manually delete ALL constraints on issuingrules table
(the update22to30.pl don't contain the constraints anymore, as kohastructure.sql, so are concerned only the existing 3.0 tests databases)

Filling issuingrules table :
- the issuingrules table can't have a constraint on categorycode, as we have a '*' categorycode (=default issuingrule)
- reintroducing the "default" issuingrule column
- changing some text ('*' replaced by something more explanatory)
- handling correctly the '0' (that is different from 'undefined'

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadding . as word separator for french. Why was it not here ?
Paul POULAIN [Fri, 12 Oct 2007 22:35:24 +0000 (17:35 -0500)]
adding . as word separator for french. Why was it not here ?

nobody probably ever enter "." on search term, but just in case...

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBugfix for empty words
Paul POULAIN [Fri, 12 Oct 2007 22:35:23 +0000 (17:35 -0500)]
Bugfix for empty words

The \b consider only ASCCI as letter. So diacritics are considered as non word.
and a word like leçon is splitted in 2, "le" is empty word, and the search is done
on çon (which is not french [1], so has no result)

[1] con (without the cedilla) is a french word, but I won't tell you what it means...
anyway, there are probably no "con" in most catalogues ;-)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobugfix: parenthesis at wrong place
Paul POULAIN [Fri, 12 Oct 2007 22:35:21 +0000 (17:35 -0500)]
bugfix: parenthesis at wrong place

authorities could not be open in MARC editor

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoContext.pm fatalsToBrowser now dependent on $ENV{USER_AGENT}.
Joe Atzberger [Fri, 12 Oct 2007 22:35:20 +0000 (17:35 -0500)]
Context.pm fatalsToBrowser now dependent on $ENV{USER_AGENT}.

Minor adjustments to Dates.pm and associated test.  You should be able to run a
perl test that uses Context w/o getting fatalsToBrowser output.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadding GetMarcUrls() fcn to display 856's - adding also output to opac-detail.
Ryan Higgins [Fri, 12 Oct 2007 08:05:34 +0000 (03:05 -0500)]
adding GetMarcUrls() fcn to display 856's - adding also output to opac-detail.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years ago#1255 : flagged patron can't renew
Paul POULAIN [Fri, 12 Oct 2007 08:05:33 +0000 (03:05 -0500)]
#1255 : flagged patron can't renew

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoDelbiblio no longer deletes items.
Chris Cormack [Fri, 12 Oct 2007 00:11:06 +0000 (19:11 -0500)]
Delbiblio no longer deletes items.

It will only delete biblios that have no items attached.
You must delete the items first then delete the biblio

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoWorking on a fix for 1176
Chris Cormack [Thu, 11 Oct 2007 22:21:12 +0000 (17:21 -0500)]
Working on a fix for 1176

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadding missing column to biblio table
Joshua Ferraro [Thu, 11 Oct 2007 20:52:24 +0000 (15:52 -0500)]
adding missing column to biblio table

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFixing tabs display.
Owen Leonard [Thu, 11 Oct 2007 20:52:23 +0000 (15:52 -0500)]
Fixing tabs display.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTweaking holds screen, trying to get additional patron information to show up in...
Owen Leonard [Thu, 11 Oct 2007 20:52:22 +0000 (15:52 -0500)]
Tweaking holds screen, trying to get additional patron information to show up in holds sidebar; Tweaks to serials interface, including overhaul of subscription-add screen

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoReporting guarantor informations on guarantees.
Henri-Damien LAURENT [Thu, 11 Oct 2007 20:52:21 +0000 (15:52 -0500)]
Reporting guarantor informations on guarantees.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoReintroducing overdue filters.
Henri-Damien LAURENT [Thu, 11 Oct 2007 20:52:20 +0000 (15:52 -0500)]
Reintroducing overdue filters.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug fixing 1360 : It was a bug when no authoritytype was defined.
Henri-Damien LAURENT [Thu, 11 Oct 2007 20:52:19 +0000 (15:52 -0500)]
Bug fixing 1360 : It was a bug when no authoritytype was defined.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobug fixing : 1459 + fixing a jserror in basket.tmpl
Henri-Damien LAURENT [Thu, 11 Oct 2007 20:52:18 +0000 (15:52 -0500)]
bug fixing : 1459 + fixing a jserror in basket.tmpl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFiltering cancelled orders on History Search.
Henri-Damien LAURENT [Thu, 11 Oct 2007 20:52:17 +0000 (15:52 -0500)]
Filtering cancelled orders on History Search.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years ago#1474 : Bulkmarcimport croaks when Log is ON
Paul POULAIN [Thu, 11 Oct 2007 19:52:56 +0000 (14:52 -0500)]
#1474 : Bulkmarcimport croaks when Log is ON

set to 0 and restore at the end of the import

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRevert "IMPROVEMENT (for #1416 : Available items marked waiting as soon as hold is...
Joshua Ferraro [Thu, 11 Oct 2007 18:24:40 +0000 (13:24 -0500)]
Revert "IMPROVEMENT (for #1416 : Available items marked waiting as soon as hold is placed)"

This reverts commit 8d269c3dbc66294add3b665b2585f6365324c50f.

Conflicts:

.dotest/0001
.dotest/final-commit
.dotest/info
.dotest/msg
.dotest/msg-clean
.dotest/patch

12 years agoremoving .dotest, not sure how it got in here
Joshua Ferraro [Thu, 11 Oct 2007 17:55:53 +0000 (12:55 -0500)]
removing .dotest, not sure how it got in here

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUnnecessary "use" statements commented out.
Joe Atzberger [Thu, 11 Oct 2007 07:20:03 +0000 (02:20 -0500)]
Unnecessary "use" statements commented out.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoChange to the way the duplicate warning works and displays. Streamlines not-a-duplica...
Owen Leonard [Thu, 11 Oct 2007 07:20:02 +0000 (02:20 -0500)]
Change to the way the duplicate warning works and displays. Streamlines not-a-duplicate confirmation process and hopefully fixes Bug 1447.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRevert "Changing innerjoin to left join for mysql5"
Henri-Damien LAURENT [Thu, 11 Oct 2007 07:20:01 +0000 (02:20 -0500)]
Revert "Changing innerjoin to left join for mysql5"

This reverts commit c0dbeb8a3f4f9ab99109d42ea194b53a46235c00.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRecommitting left join for mysql5
Henri-Damien LAURENT [Tue, 9 Oct 2007 21:46:37 +0000 (16:46 -0500)]
Recommitting left join for mysql5

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRevert "Changing innerjoin to left join for mysql5"
Henri-Damien LAURENT [Tue, 9 Oct 2007 21:46:36 +0000 (16:46 -0500)]
Revert "Changing innerjoin to left join for mysql5"

This reverts commit c0dbeb8a3f4f9ab99109d42ea194b53a46235c00.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSorting Branches by Branchcode on display.
Paul POULAIN [Tue, 9 Oct 2007 21:46:34 +0000 (16:46 -0500)]
Sorting Branches by Branchcode on display.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoIMPROVEMENT (for #1416 : Available items marked waiting as soon as hold is placed)
Paul POULAIN [Tue, 9 Oct 2007 21:46:26 +0000 (16:46 -0500)]
IMPROVEMENT (for #1416 : Available items marked waiting as soon as hold is placed)

In fact, #1416 is not a bug, it's a feature : SAN-OP librarians place the reserve "book in hand", and confirm on phone that it's available
NPL save the reserve, but pick them from the shelves once a day only. So the item must be "to pull"

This commit improves the behaviour :
- document Reserves.pm a little, it was needed !
- add a systempreference ReservesNeedReturns, that let the library choose it's behaviour
- define the systempref in english & french systempreferences files
- add the systempref through the web installer (bumping to 3.00.00.003)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years ago#1485 saving issuingrules
Paul POULAIN [Mon, 8 Oct 2007 19:24:32 +0000 (14:24 -0500)]
#1485 saving issuingrules

lot of bugs to fix...
- a foreign key on patron category is stupid as we have a wildcard
- having a wildcard on itemtype is useless, removing it in template
- reindenting & removing some commented lines
- fixing some SQL bugs (insert/update lines)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFIX for Date calculation
paul [Thu, 4 Oct 2007 05:16:39 +0000 (07:16 +0200)]
FIX for Date calculation

Rule :
- always format_date() before sending date to template
- always format_date_in_iso immediatly after reading a date coming from a parameter
- deal internally only with dates in iso

Note that :
- I could not test things related to issues stats due to the my DB -issues.issuedate not filled, see commit about 3.00.00.006
- acquisitions_stats does not work when you filter on date

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrections to addbiblio.pl and addbiblio.tmpl for XHTML compliance; Formatting addbi...
Owen Leonard [Wed, 10 Oct 2007 19:42:18 +0000 (14:42 -0500)]
Corrections to addbiblio.pl and addbiblio.tmpl for XHTML compliance; Formatting addbilbio.tmpl tabs.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFixing tab display on authorities.tmpl, correcting invalid markup generated by author...
Owen Leonard [Wed, 10 Oct 2007 19:42:17 +0000 (14:42 -0500)]
Fixing tab display on authorities.tmpl, correcting invalid markup generated by authorities.pl; Change to circulation.tmpl for more generalized tab formatting.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrections to bring into XHTML compliance
Owen Leonard [Wed, 10 Oct 2007 19:42:16 +0000 (14:42 -0500)]
Corrections to bring into XHTML compliance

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years ago#1475
Frédéric DEMIANS [Wed, 10 Oct 2007 19:42:15 +0000 (14:42 -0500)]
#1475

Not sure whereas this patch's reached you...

Thanks.

--
Frédéric DEMIANS
http://www.tamil.fr/u/fdemians.html

>From 4c1efe7c79d8ac6eb6f275823d9a0ea948d1315c Mon Sep 17 00:00:00 2001
From: Frederic Demians <f.demians@tamil.fr>
Date: Sun, 7 Oct 2007 01:54:56 +0200
Subject: [PATCH] Correct a bug preventing from modifying member records

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAnother tweak to the toolbar. Some toolbar buttons were not showing up on initial...
Owen Leonard [Tue, 9 Oct 2007 21:46:54 +0000 (16:46 -0500)]
Another tweak to the toolbar. Some toolbar buttons were not showing up on initial page load.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrections to bring into XHTML compliance
Owen Leonard [Tue, 9 Oct 2007 21:46:53 +0000 (16:46 -0500)]
Corrections to bring into XHTML compliance

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAfter seeing Paul's commits re: gettext javascript, correcting detail.tmpl. Also...
Owen Leonard [Tue, 9 Oct 2007 21:46:52 +0000 (16:46 -0500)]
After seeing Paul's commits re: gettext javascript, correcting detail.tmpl. Also moving the function from doc-head-close.inc to staff-global.js.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRefining navigation in MARC Framework pages; Fixing unfinished YUI-based toolbar...
Owen Leonard [Tue, 9 Oct 2007 21:46:51 +0000 (16:46 -0500)]
Refining navigation in MARC Framework pages; Fixing unfinished YUI-based toolbar on catalogue detail page: functional now, with some tweaks yet to be done.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug Fixing : 217 (Suivi.paulpoulain.com : use ecost for actual cost rather than repla...
Henri-Damien LAURENT [Tue, 9 Oct 2007 21:46:50 +0000 (16:46 -0500)]
Bug Fixing : 217 (Suivi.paulpoulain.com : use ecost for actual cost rather than replacement price)

+ another bug fixing.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoskipping wrong XMLs when rebuilding nozebra indexes
Paul POULAIN [Tue, 9 Oct 2007 21:46:49 +0000 (16:46 -0500)]
skipping wrong XMLs when rebuilding nozebra indexes

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years ago(minor) bugfixing topissues (no limit query)
Paul POULAIN [Tue, 9 Oct 2007 21:46:48 +0000 (16:46 -0500)]
(minor) bugfixing topissues (no limit query)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBumping to 3.00.00.008 : adding biblio.datecreated
Paul POULAIN [Tue, 9 Oct 2007 21:46:47 +0000 (16:46 -0500)]
Bumping to 3.00.00.008 : adding biblio.datecreated

The top issue was based on a timestamp field, that was updated everytime a biblio is modified

This commit add a datecreated field, that is filled only when a biblio is ADDED
it is used by opac-topissues & can be useful at other places i'm sure

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoIMPORTANT : biblioitems.editionresponsibility field was sometimes spelled with a 'a'
Paul POULAIN [Tue, 9 Oct 2007 21:46:46 +0000 (16:46 -0500)]
IMPORTANT : biblioitems.editionresponsibility field was sometimes spelled with a 'a'

editionserponsability.
This commit fixes all editionresponsAbibility. However, that won't change the biblioitems
column name if you have a wrong one in your DB (if you install a new one, or try a migration from 2.2, that should be OK)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofixing some french files for installer
Paul POULAIN [Tue, 9 Oct 2007 21:46:45 +0000 (16:46 -0500)]
fixing some french files for installer

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding a new option to rebuildzebra : noxml
Paul POULAIN [Tue, 9 Oct 2007 21:46:44 +0000 (16:46 -0500)]
Adding a new option to rebuildzebra : noxml

This option uses the iso2709 version of the MARC record instead of the XML one
(biblioitems.marc vs biblioitems.marcxml)
No change if the parameter is not set.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBugFix in MARCdetail.pl : getauthorisedvaluedesc contained itemtype. + Rewriting...
Henri-Damien LAURENT [Tue, 9 Oct 2007 21:46:43 +0000 (16:46 -0500)]
BugFix in MARCdetail.pl : getauthorisedvaluedesc contained itemtype. + Rewriting ModBiblios (now can take in itemnumbers or biblionumbers + allow modification for tags <010)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFrench installation files
Paul POULAIN [Tue, 9 Oct 2007 21:46:42 +0000 (16:46 -0500)]
French installation files

- removing old & useless files
- renaming directories
- adding some Public & Research specific files

(copying some LibLime ideas)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoThe kohafield in authorities can't be NOT NULL (as it is always null in fact...)
Paul POULAIN [Tue, 9 Oct 2007 21:46:41 +0000 (16:46 -0500)]
The kohafield in authorities can't be NOT NULL (as it is always null in fact...)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoremoving comment
Paul POULAIN [Tue, 9 Oct 2007 21:46:40 +0000 (16:46 -0500)]
removing comment

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSorting the install directory
Paul POULAIN [Tue, 9 Oct 2007 21:46:39 +0000 (16:46 -0500)]
Sorting the install directory

previously, the order was "random". With this patch, you can choose the order
of the file that are shown for adding during install.
Just name the directories: for example 1-Mandatory, 2-Optional, 3-whateveryouwant

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years ago#1444: Porting marcEditor to authorities (tab management)
Paul POULAIN [Tue, 9 Oct 2007 21:46:38 +0000 (16:46 -0500)]
#1444: Porting marcEditor to authorities (tab management)

+ reindenting some code

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoParenthesis mistakenly removed.
Henri-Damien LAURENT [Tue, 9 Oct 2007 21:46:35 +0000 (16:46 -0500)]
Parenthesis mistakenly removed.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoChanging innerjoin to left join for mysql5
Henri-Damien LAURENT [Tue, 9 Oct 2007 21:46:33 +0000 (16:46 -0500)]
Changing innerjoin to left join for mysql5

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBugFixing unimarc_field_210c.pl was badly broken. It allows searches.
Henri-Damien LAURENT [Tue, 9 Oct 2007 21:46:32 +0000 (16:46 -0500)]
BugFixing unimarc_field_210c.pl was badly broken. It allows searches.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoModifying ModMember so that if there were a flag parameter on page it would not write...
Henri-Damien LAURENT [Tue, 9 Oct 2007 21:46:31 +0000 (16:46 -0500)]
Modifying ModMember so that if there were a flag parameter on page it would not write borrower flags

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding dates for display to circulation.pl Minor bug fixes.
Paul POULAIN [Tue, 9 Oct 2007 21:46:30 +0000 (16:46 -0500)]
Adding dates for display to circulation.pl Minor bug fixes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofrench templates
Paul POULAIN [Fri, 5 Oct 2007 07:33:34 +0000 (09:33 +0200)]
french templates

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoOne can search on only one limit (for instance : Get ALL Documents from ONE branch)
Henri-Damien LAURENT [Tue, 9 Oct 2007 21:46:29 +0000 (16:46 -0500)]
One can search on only one limit (for instance : Get ALL Documents from ONE branch)

Sorting branches for results.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoIMPROVEMENT (for #1416 : Available items marked waiting as soon as hold is placed)
Paul POULAIN [Tue, 9 Oct 2007 21:46:26 +0000 (16:46 -0500)]
IMPROVEMENT (for #1416 : Available items marked waiting as soon as hold is placed)

In fact, #1416 is not a bug, it's a feature : SAN-OP librarians place the reserve "book in hand", and confirm on phone that it's available
NPL save the reserve, but pick them from the shelves once a day only. So the item must be "to pull"

This commit improves the behaviour :
- document Reserves.pm a little, it was needed !
- add a systempreference ReservesNeedReturns, that let the library choose it's behaviour
- define the systempref in english & french systempreferences files
- add the systempref through the web installer (bumping to 3.00.00.003)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRevert "#1485 saving issuingrules"
Joshua Ferraro [Mon, 8 Oct 2007 21:20:47 +0000 (16:20 -0500)]
Revert "#1485 saving issuingrules"

This reverts commit 31eaffcb04ab1cf2100b3b387b82eb3b1e2ac9e8.

12 years agoNew object-oriented date module to soon replace Date.pm.
Joe Atzberger [Mon, 8 Oct 2007 20:36:11 +0000 (15:36 -0500)]
New object-oriented date module to soon replace Date.pm.

Also included is a traditional perl (t/Dates.t) test script.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years ago#1456, automatically suggest user branch as pickup branch
Paul POULAIN [Mon, 8 Oct 2007 19:24:35 +0000 (14:24 -0500)]
#1456, automatically suggest user branch as pickup branch

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>