wip/koha-chris_n.git
10 years agoAdd instructions to INSTALL and README.robots about robots.txt
Michael Hafen [Fri, 19 Feb 2010 16:34:10 +0000 (09:34 -0700)]
Add instructions to INSTALL and README.robots about robots.txt

Instructions are given in INSTALL and README.robots about adding a robots.txt
file to the opac to prevent search engines from indexing Koha.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3609 Fix fr-FR user permissions
Frédéric Demians [Sat, 20 Feb 2010 07:49:52 +0000 (08:49 +0100)]
Bug 3609 Fix fr-FR user permissions

- Translation
- Add missing permissions: execute_reports, create_reports
- Rename properly: batchmod and batchdel

This has to be done for other languages.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdd pl-PL to syspref test
Frédéric Demians [Sat, 20 Feb 2010 07:49:51 +0000 (08:49 +0100)]
Add pl-PL to syspref test

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3609 Test for user permissions translated values
Frédéric Demians [Sat, 20 Feb 2010 07:49:50 +0000 (08:49 +0100)]
Bug 3609 Test for user permissions translated values

This new test identifies incoherences between 'en' user permissions and
translated versions.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoRemoving bogus style declaration
Owen Leonard [Fri, 19 Feb 2010 21:13:05 +0000 (16:13 -0500)]
Removing bogus style declaration

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agomove ReservesMaxPickUpDelay to Holds Policy on Circ Prefs
Nicole Engard [Wed, 17 Feb 2010 12:12:55 +0000 (07:12 -0500)]
move ReservesMaxPickUpDelay to Holds Policy on Circ Prefs

This preference didn't make sense in Interface - it's a holds
policy related preference and so I've moved it to that area.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 3242 follow-up: fix crash when emailLibrarianWhenHoldIsPlaced is ON
Galen Charlton [Fri, 19 Feb 2010 10:55:05 +0000 (05:55 -0500)]
bug 3242 follow-up: fix crash when emailLibrarianWhenHoldIsPlaced is ON

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4182: add emailLibrarianWhenHoldIsPlaced to preferences editor
Galen Charlton [Fri, 19 Feb 2010 10:51:47 +0000 (05:51 -0500)]
bug 4182: add emailLibrarianWhenHoldIsPlaced to preferences editor

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 3242: insert new HOLDPLACED letter template (DBrev 124)
Galen Charlton [Fri, 19 Feb 2010 10:47:50 +0000 (05:47 -0500)]
bug 3242: insert new HOLDPLACED letter template (DBrev 124)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(bug #3242) send email when hold is placed
Nahuel ANGELINETTI [Fri, 28 Aug 2009 13:19:26 +0000 (15:19 +0200)]
(bug #3242) send email when hold is placed

[cherry-picked from 3.0.x]

This add a new letter in database, and each time a new hold is placed, a new mail is enqueued.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
10 years agobug 2970: extend new hold priority change permission
Galen Charlton [Fri, 19 Feb 2010 10:21:11 +0000 (05:21 -0500)]
bug 2970: extend new hold priority change permission

Now covers the new hold request priority buttons.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobump to DBrev 123
Galen Charlton [Fri, 19 Feb 2010 10:13:45 +0000 (05:13 -0500)]
bump to DBrev 123

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 2970, Create a permission for modifying holds priority
Owen Leonard [Wed, 10 Feb 2010 21:18:58 +0000 (16:18 -0500)]
Fix for Bug 2970, Create a permission for modifying holds priority

Adding two new granular permissions under 'reserveforothers,' place_holds
and modify_holds_priority. If a user does not have modify_holds_priority
permission, the option to change the priority of a hold is hidden.
Revised patch includes changes to mandatory data files including
properly translated fr-FR version.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoWhoops missed Magnus Enger
Chris Cormack [Fri, 19 Feb 2010 08:51:35 +0000 (21:51 +1300)]
Whoops missed Magnus Enger

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobump DBrev to 122
Galen Charlton [Fri, 19 Feb 2010 04:05:28 +0000 (23:05 -0500)]
bump DBrev to 122

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoDBRev 122 — OAI Server fixes
Frédéric Demians [Thu, 18 Feb 2010 20:46:18 +0000 (21:46 +0100)]
DBRev 122 — OAI Server fixes

- Add OAI-PMH:ConfFile.
- Suppress OAI-PMH:Subset which isn't is .pref file and was never used
  by OAI Server.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 1532: various code cleanup
Galen Charlton [Fri, 19 Feb 2010 03:42:53 +0000 (22:42 -0500)]
bug 1532: various code cleanup

* export C4::Reserves::CancelExpiredReserves
* rename  misc/cronjobs/cancel_expired_reserves.pl
  to misc/cronjobs/holds/cancel_expired_holds.pl
* added cancel_expired_holds.pl to example crontab
* fix staff crash if AllowHoldDateInFuture is on
* expirationdate is now nullable instead of relying
  on 0000-00-00

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 1532: fix XHTML validation errors
Galen Charlton [Fri, 19 Feb 2010 03:15:06 +0000 (22:15 -0500)]
bug 1532: fix XHTML validation errors

Also changed some titles to use "hold" instead of "reserve"
for display purposes.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 1532: tweak new reserves columns and add to init SQL (DB rev 121)
Galen Charlton [Fri, 19 Feb 2010 02:45:56 +0000 (21:45 -0500)]
bug 1532: tweak new reserves columns and add to init SQL (DB rev 121)

Changed type of lowestpriority from BOOL to tinyint(1) - BOOL was likely
OK, but made it tinyint(1) to match the rest of the flag columns.  We
should look into converting those to BOOL en masse in 3.4.

Also made expirationdate nullable.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(bug 1532) Reserves Updates Ported From Dev_Week
Kyle M Hall [Wed, 23 Sep 2009 16:10:23 +0000 (16:10 +0000)]
(bug 1532) Reserves Updates Ported From Dev_Week

This is a much improved re-implementation of the reserves updates from dev_week.
Less new code has been added, and more existing functions are used instead of adding new ones.

The 'Lock Hold' function has been removed due to it not working as intended.

[RM note for documentation: this adds the following features:

* ability to specify an expiration date for a hold request
  when placing it via the staff interface or OPAC
* daily batch job to cancel expired holds
* nice interface to change the priority of hold
  requests for a bib in the staff interface]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdding some clarity to the acquistion called off line in the history
Chris Cormack [Thu, 18 Feb 2010 21:46:37 +0000 (10:46 +1300)]
Adding some clarity to the acquistion called off line in the history

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoUpdating credits and history document
Chris Cormack [Thu, 18 Feb 2010 21:19:30 +0000 (10:19 +1300)]
Updating credits and history document

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 2505: Enabled warnings in opac-userdetails.pl.
Garry Collum [Fri, 19 Feb 2010 00:30:56 +0000 (19:30 -0500)]
Bug 2505: Enabled warnings in opac-userdetails.pl.

No warnings generated.

The only files left in koha/opac are changelanguage.pl and opac-user.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4227: Removes unused opac-logout.pl.
Garry Collum [Fri, 19 Feb 2010 01:21:11 +0000 (20:21 -0500)]
Bug 4227: Removes unused opac-logout.pl.

Performed a recursive grep on the entire file structure to confirm.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 3825 followup: fix errors in template
Galen Charlton [Thu, 18 Feb 2010 21:34:43 +0000 (16:34 -0500)]
bug 3825 followup: fix errors in template

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(bug #3825) improve waiting holds
Nahuel ANGELINETTI [Wed, 2 Dec 2009 10:44:43 +0000 (11:44 +0100)]
(bug #3825) improve waiting holds

[cherry-pick from 3.0.x]

This patch :
 * fix indentation
 * Separate waiting holds from holds over with tabs
 * Select only holds for librarian library

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4219, strange artifacts showing on lists in the staff client
Owen Leonard [Thu, 18 Feb 2010 20:06:44 +0000 (15:06 -0500)]
Fix for Bug 4219, strange artifacts showing on lists in the staff client

Recent change to C4/VirtualShelves/Page.pm caused display of subtitles
to break in the staff client display of lists

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoRevert "bug 3765: move road type after address"
Galen Charlton [Thu, 18 Feb 2010 19:02:56 +0000 (14:02 -0500)]
Revert "bug 3765: move road type after address"

Reverted at patch submitter's request - see bug 3765
for details.

This reverts commit 3b8542bbfe698fedde9f822ac96a45cb8a19122b.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobugfix Guided Reports - allow user specified limit in sql
Michael Hafen [Wed, 4 Nov 2009 21:31:48 +0000 (14:31 -0700)]
bugfix Guided Reports - allow user specified limit in sql

Tweak the regular expression in strip_limit to work.
Tweak execute_query to use the user limit if it's lower than the hard coded one.
Also total is calculated somewhere else now.

This helps most with the csv export of a report so the user can set their own
limit instead of having the hard coded limit of 9999.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoadd memcached questions to koha-install-log
Michael Hafen [Wed, 18 Nov 2009 15:37:40 +0000 (08:37 -0700)]
add memcached questions to koha-install-log

Add the use_memcached question to rewrite-config.pl and all three questions
to koha-install-log.  So that we don't have to keep answering these questions
when we upgrade/install with the --prev-install-log option.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agohave Makefile.PL check for dollar signs
Michael Hafen [Wed, 18 Nov 2009 21:38:49 +0000 (14:38 -0700)]
have Makefile.PL check for dollar signs

Make treats any $ as an internal variable except $$.  So have Makefile.PL when
getting values turn any $ into $$.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoRevert "Add basic restrictive robots.txt file to opac"
Galen Charlton [Thu, 18 Feb 2010 18:22:46 +0000 (13:22 -0500)]
Revert "Add basic restrictive robots.txt file to opac"

Per discussion on 12/9/2009, reverting.  I agree with Nicole Engard
that a restrictive robots.txt for the OPAC should *not* be the
default.  A patch for a README on how to do it would be nice, though.

This reverts commit 6822d69d955627302abe3f78bcbc5bf2c8db2a36.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdded Locale::PO dependency in Makefile.PL
Ricardo Dias Marques [Wed, 21 Oct 2009 00:34:15 +0000 (00:34 +0000)]
Added Locale::PO dependency in Makefile.PL

In one of my setups, "install-code.pl pt-PT" complained
about a missing "Locale::PO". So, I'm adding it to
Makefile.PL. I'm using the version 0.17 as minimum
required because it's the one that's available in
Debian 5.0.2. ("lenny").

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 3651 followup: updated for new GetMember() parameter style
Galen Charlton [Thu, 18 Feb 2010 17:59:46 +0000 (12:59 -0500)]
bug 3651 followup: updated for new GetMember() parameter style

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(bug #3651) sending baskets and shelves
Nahuel ANGELINETTI [Mon, 21 Sep 2009 13:08:27 +0000 (15:08 +0200)]
(bug #3651) sending baskets and shelves

this patch restrict the send of baskets and shelves to authenticated users only, and show their surname/firstname in the e-mail, so the receiver will know who sent the list.
(cherry picked from commit f87b75522801ee6d08291bb0eeb6bc38a5b785d5)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoSome new and altered itemtype images for the NPL set
Owen Leonard [Mon, 25 Jan 2010 21:09:29 +0000 (16:09 -0500)]
Some new and altered itemtype images for the NPL set

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4047 - Add a link to branch URL if available on holdings in OPAC
Frédéric Demians [Fri, 15 Jan 2010 19:49:34 +0000 (20:49 +0100)]
Bug 4047 - Add a link to branch URL if available on holdings in OPAC

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoDisplay amount of credit patron has, not just that they have credit.
Will Stokes [Wed, 17 Feb 2010 01:34:07 +0000 (14:34 +1300)]
Display amount of credit patron has, not just that they have credit.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4215 OPAC "Search for title in" can fail with trailing slashes in title
Jane Wagner [Thu, 18 Feb 2010 16:45:50 +0000 (11:45 -0500)]
Bug 4215 OPAC "Search for title in" can fail with trailing slashes in title

While configuring Search for Title In links, I found that some target sites
can't process an incoming title search if the title being sent has a trailing
slash.  If the same search is sent without the trailing slash, it works fine.  I
modified opac-detail.pl to strip off the trailing slash (and space) for titles
being sent to other sites.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 1080 follow-up: make sure 'sound' isn't listed as a language
Galen Charlton [Thu, 18 Feb 2010 17:02:06 +0000 (12:02 -0500)]
bug 1080 follow-up: make sure 'sound' isn't listed as a language

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoupdate RM notes for new translation wrapper script
Galen Charlton [Thu, 18 Feb 2010 17:06:06 +0000 (12:06 -0500)]
update RM notes for new translation wrapper script

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFollow up for new translation wrapper
Frédéric Demians [Wed, 17 Feb 2010 11:31:38 +0000 (12:31 +0100)]
Follow up for new translation wrapper
(cherry picked from commit 17bdeb66e041f295214d1406620669c090b4e4de)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoNew wrapper script for handling translation process
Frédéric Demians [Wed, 17 Feb 2010 07:16:43 +0000 (20:16 +1300)]
New wrapper script for handling translation process

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3070: Fixes RSS feed for single result search.
Garry Collum [Thu, 18 Feb 2010 01:19:50 +0000 (20:19 -0500)]
Bug 3070: Fixes RSS feed for single result search.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 2505: Add warnings to opac/maintenance.pl
Garry Collum [Wed, 17 Feb 2010 23:16:57 +0000 (18:16 -0500)]
Bug 2505: Add warnings to opac/maintenance.pl

Added a FIXME for warning generated from C4/Context.pm.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4212: Adds license statement to opac-search.pl
Garry Collum [Wed, 17 Feb 2010 23:36:36 +0000 (18:36 -0500)]
Bug 4212: Adds license statement to opac-search.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobookseller is returned as a scalar hashref not an array
Colin Campbell [Thu, 18 Feb 2010 12:34:50 +0000 (12:34 +0000)]
bookseller is returned as a scalar hashref not an array

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMake GetBooksellerFromId error return consistent
Colin Campbell [Thu, 18 Feb 2010 12:35:28 +0000 (12:35 +0000)]
Make GetBooksellerFromId error return consistent

return undef or empty array in error cases
hopefully if we're consistent someone may start checking it
removed unnecessary ()s

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4155 followup: fix indication of when checkbox syspref is modified
Galen Charlton [Thu, 18 Feb 2010 15:26:31 +0000 (10:26 -0500)]
bug 4155 followup: fix indication of when checkbox syspref is modified

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4155 Can't change the language of the staff client in prefs
Frédéric Demians [Wed, 17 Feb 2010 21:21:15 +0000 (22:21 +0100)]
Bug 4155 Can't change the language of the staff client in prefs

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoOAI server fixes
Frédéric Demians [Wed, 17 Feb 2010 14:05:47 +0000 (15:05 +0100)]
OAI server fixes

- Add preference OAI-PMH:ConfFile. I just add it in web-services.pref
  and not in DB. It's enough. It's not an end-user preference. Without
  this pref, OAI server operates as previously. And preferences editor
  allow to add a new value to the DB if necessary.
- Fix response to ListMetadataFormats which was empty in extended mode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 1080: finish work for soundon syspref (DBrev 120)
Galen Charlton [Thu, 18 Feb 2010 14:23:26 +0000 (09:23 -0500)]
bug 1080: finish work for soundon syspref (DBrev 120)

Tweaked wording of the soundon syspref, added it to the non-English
SQL scripts, and created a DBrev.  Thanks to Nahuel and Eric
for the French translation.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 1080: XHTML-ify audio tags
Galen Charlton [Thu, 18 Feb 2010 14:21:13 +0000 (09:21 -0500)]
bug 1080: XHTML-ify audio tags

This doesn't actually do much, since the <audio> tag is still
not defined in XHTML1, but it makes it consistent with the rest of the
markup.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugzilla 1080 to add enhancement for sound. Only changed circulation.tmpl/pl and...
root [Wed, 17 Feb 2010 18:24:46 +0000 (13:24 -0500)]
Bugzilla 1080 to add enhancement for sound. Only changed circulation.tmpl/pl and returns.tmpl/pl and added a single syspref (set to off) along with very compressed OGG files for sound which are on the open source "artistic" licence.

Works for HTML5 because it loads smoothly and no plugins required but *at
  this time* this update will only work with staff clients which are Firefox
  version >=3.5 (std for Koha) but other browsers will soon be adding support.

  Additional sounds are included for people to modify and play with, but this
  is such a simple upgrade I doubt at this time Koha needs another complex
  selector so users can add their own sounds. It could be a nice enhancement
  later, of course.

  Suggest we stick with HTML5 <audio tag because it is a standard and no
  plug-ins.

  This simple update has been running live for SMFPL.org for almost 2 weeks

  -Darrell Ulm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3775: Accounts::chargelostitem uses title, but title not available to it
J. David Bavousett [Wed, 17 Feb 2010 16:19:09 +0000 (11:19 -0500)]
Bug 3775: Accounts::chargelostitem uses title, but title not available to it

This patch fixes the SELECT so that title is available when it is used
later on, which will prevent 'Use of uninitialized value' errors.

It also uses JOIN properly, which the original query and my initial
patches for this did not.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMT2116 : CSV Exports : add 'new line' as separator
Matthias Meusburger [Tue, 16 Feb 2010 20:46:57 +0000 (21:46 +0100)]
MT2116 : CSV Exports : add 'new line' as separator

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMT 2116: Addons to the CSV export
Matthias Meusburger [Tue, 16 Feb 2010 20:46:56 +0000 (21:46 +0100)]
MT 2116: Addons to the CSV export

Fix encoding selection

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMT2116: Addons to the CSV export
Matthias Meusburger [Thu, 28 Jan 2010 14:05:54 +0000 (15:05 +0100)]
MT2116:   Addons to the CSV export

Adds the ability to customize CSV exports through the use of a YAML file.

The following customizations are available :
  - Preprocessing
  - Postprocessing
  - Field-by-field processing

The YAML field should be stored in the tools/csv-profiles/ directory and
named after the id of the CSV profile you want to customize.
An example file is provided in that directory.
(cherry picked from commit 76655b5b941f6f6094f705a296f7b68e64d148df)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMT2716: fixing finishreceive.pl Software Error
Paul Poulain [Tue, 16 Feb 2010 20:46:54 +0000 (21:46 +0100)]
MT2716: fixing finishreceive.pl Software Error

finishreceive.pl was buggy when AcqCreateItem was set to recieve (wrong API)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMT1203: don't display menus if the user don't has the permission
Paul Poulain [Tue, 16 Feb 2010 20:46:55 +0000 (21:46 +0100)]
MT1203: don't display menus if the user don't has the permission

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMT 2348 : acqui-home minor improvements
Paul Poulain [Tue, 16 Feb 2010 20:46:52 +0000 (21:46 +0100)]
MT 2348 : acqui-home minor improvements

- moving some links to the left part of koha (currencies and suggestions)
- removed currency table
- changing supplier display

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(bug #4062) add item index in zebra conf
Nahuel ANGELINETTI [Tue, 16 Feb 2010 15:30:02 +0000 (16:30 +0100)]
(bug #4062) add item index in zebra conf

This add the "item" index.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoupdated install instructions to include Locale::Currency::Format
Galen Charlton [Wed, 17 Feb 2010 11:45:04 +0000 (06:45 -0500)]
updated install instructions to include Locale::Currency::Format

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoset Locale::Currency::Format dep test as DBrev 119
Galen Charlton [Wed, 17 Feb 2010 11:39:22 +0000 (06:39 -0500)]
set Locale::Currency::Format dep test as DBrev 119

Also fixed bug that prevented updatedatabase.pl
from compiling if Locale::Currency::Format wasn't
already installed.  To test to see if module is present,
do

eval{require Locale::Currency::Format};

not

eval{use Locale::Currency::Format};

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix: Moving sample_notices.sql to mandatory subdir
Chris Nighswonger [Tue, 16 Feb 2010 15:40:05 +0000 (10:40 -0500)]
Bugfix: Moving sample_notices.sql to mandatory subdir

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix: [3/3] [TRANSLATION NEEDED] overdue_notices.pl does not process all advertised...
Chris Nighswonger [Tue, 16 Feb 2010 15:43:26 +0000 (10:43 -0500)]
Bugfix: [3/3] [TRANSLATION NEEDED] overdue_notices.pl does not process all advertised fields

Updating mandatory sample notices sql files

NOTE TO TRANSLATORS: Some of these will require new translations

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix: [2/3] overdue_notices.pl does not process all advertised fields
Chris Nighswonger [Tue, 16 Feb 2010 15:56:03 +0000 (10:56 -0500)]
Bugfix: [2/3] overdue_notices.pl does not process all advertised fields

This patch adds a dependency requirement for Locale::Currency::Format

NOTE: It does not adjust kohaversion.pl and sets the dev version to XXX.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix: [1/3] overdue_notices.pl does not process all advertised fields
Chris Nighswonger [Tue, 16 Feb 2010 15:56:02 +0000 (10:56 -0500)]
Bugfix: [1/3] overdue_notices.pl does not process all advertised fields

Note: overdue_notices.pl really needs to be completely re-written.

The script does not process all fields advertised in tools/letter.pl
This patch adds code to process all fields advertised as well as any
from the items table.

It also adds two additional tags for use in the letter templates:

<item></item> which should enclose all fields from the biblio, biblioitems,
and items tables.

<fine></fine> which should be enclosed by the item tag and should
enclose a currency identifier per ISO 4217. If this tag is present with
a proper identifier, the fine for that item will be displayed in the
proper currency format. Note: ISO 4217 changes from time to time therefore
all currencies may not be supported. If you find one that is not
supported, please file a bug with the Locale::Currency::Format author
Tan D Nguyen <tnguyen at cpan doe org>.

An example of the implimentation of these two tags in a notice template
might be like:

The following item(s) is/are currently overdue:

<item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>> Fine: <fine>GBP</fine></item>

Which, assuming two items were overdue, would result in a notice like:

The following item(s) is/are currently overdue:

"A Short History of Western Civilization" by Harrison, John B, 909.09821 H2451, Barcode: 08030003 Fine: £3.50
"History of Western Civilization" by Hayes, Carlton Joseph Huntley, 909.09821 H3261 v.1, Barcode: 08030004 Fine: £3.50

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4197 fix opac patron update
Nicole Engard [Tue, 16 Feb 2010 11:16:01 +0000 (06:16 -0500)]
bug 4197 fix opac patron update

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 3973: make auto-fill button work on budget planning form
Galen Charlton [Wed, 17 Feb 2010 11:17:31 +0000 (06:17 -0500)]
bug 3973: make auto-fill button work on budget planning form

Also fixed a variety of XHTML validation errors.

Programming note: it is invalid XHTML and can break Javascript
to use element IDs and class names that start with digits.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4203: add display column to aqbudgets_planning if needed (DBrev 118)
Galen Charlton [Wed, 17 Feb 2010 10:31:13 +0000 (05:31 -0500)]
bug 4203: add display column to aqbudgets_planning if needed (DBrev 118)

Had not been included in kohastructure.sql

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(bug #4135) fix aqplan form
Henri-Damien LAURENT [Tue, 16 Feb 2010 15:30:00 +0000 (16:30 +0100)]
(bug #4135) fix aqplan form

This fix the form to have always the submit button, and fix security issue in aqplan.pl(authnotrequired set to 1)

Conflicts solved:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3654 Fix sql syntax error in earlier patch
Colin Campbell [Tue, 16 Feb 2010 13:10:49 +0000 (13:10 +0000)]
Bug 3654 Fix sql syntax error in earlier patch

mysql comments require a space after the --

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4151: replace dep on YAML::XS with YAML::Syck
Galen Charlton [Wed, 17 Feb 2010 10:02:42 +0000 (05:02 -0500)]
bug 4151: replace dep on YAML::XS with YAML::Syck

YAML::Syck is also fast, and dropped YAML::XS means
we don't have to add a formal dependency on it.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(bug #4195) fix OAI repository
Nahuel ANGELINETTI [Tue, 16 Feb 2010 13:34:58 +0000 (14:34 +0100)]
(bug #4195) fix OAI repository

this fix the OAI repository, to don't return resumptionToken if there is no more record.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 2959 - Add a timeout parameter to the URL checker
Frédéric Demians [Mon, 15 Feb 2010 07:14:25 +0000 (08:14 +0100)]
Bug 2959 - Add a timeout parameter to the URL checker

Could improve performances for DB containing URLs which can't be fetched
(good or bad) quickly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3652: Fixes XSS vulnerabilities and XTHML errors in opac-search-history.tmpl
Garry Collum [Tue, 16 Feb 2010 00:17:01 +0000 (19:17 -0500)]
Bug 3652: Fixes XSS vulnerabilities and XTHML errors in opac-search-history.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 2505: fix warnings in opac-MARCdetail.pl
Galen Charlton [Tue, 16 Feb 2010 11:31:16 +0000 (06:31 -0500)]
bug 2505: fix warnings in opac-MARCdetail.pl

Also indulged in a little code cleanup.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3449: Fixes the perpetual error message that pops up when filtering by tag reviewer.
Garry Collum [Mon, 15 Feb 2010 15:43:23 +0000 (10:43 -0500)]
Bug 3449: Fixes the perpetual error message that pops up when filtering by tag reviewer.

Duplicates the code for searching by reviewer in the form that is used in searching via a link.

It looks like it was the intention of the original writer to filter by borrower number or by name.  Filtering by name was not implemented.  Added a FIXME reference to indicate this.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3090: Adds the report ID field to the saved reports page in the guided reports.
Garry Collum [Mon, 15 Feb 2010 16:55:24 +0000 (11:55 -0500)]
Bug 3090: Adds the report ID field to the saved reports page in the guided reports.

Adds an ID field to the save reports table in guided reports to make running runreport.pl easier for users.

Also adds zebra striping to the data table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 2505: Enables warnings in opac-MARCdetail.pl and opac-authoritiesdetail.pl
Garry Collum [Mon, 15 Feb 2010 22:20:17 +0000 (17:20 -0500)]
Bug 2505: Enables warnings in opac-MARCdetail.pl and opac-authoritiesdetail.pl

No resulting warnings after warnings were turned on.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4192: Fixes warnings generated by opac-account.pl.
Garry Collum [Mon, 15 Feb 2010 22:44:47 +0000 (17:44 -0500)]
Bug 4192: Fixes warnings generated by opac-account.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoUpdate fr-FR preferences
Frédéric Demians [Mon, 15 Feb 2010 11:46:42 +0000 (12:46 +0100)]
Update fr-FR preferences

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agotweak description of OpacBrowser syspref
Galen Charlton [Tue, 16 Feb 2010 11:08:25 +0000 (06:08 -0500)]
tweak description of OpacBrowser syspref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdd OpacBrowser preference to opac.pref
Frédéric Demians [Tue, 16 Feb 2010 09:52:21 +0000 (10:52 +0100)]
Add OpacBrowser preference to opac.pref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 2885: attempting to add library with existing code now gives error message
Galen Charlton [Mon, 15 Feb 2010 02:10:25 +0000 (21:10 -0500)]
bug 2885: attempting to add library with existing code now gives error message

If one attempts to add a new library with a code already in use,
an error message is shown.  The main library data input by the user
is preserved, allowing the user to try a new code.

This also corrects a glitch in the previous patch concerning
adding a branch category whose code is already in use.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for bug 2885, now an error message is thrown instead of a silent fail
Chris Cormack [Sat, 26 Dec 2009 09:23:05 +0000 (22:23 +1300)]
Fix for bug 2885, now an error message is thrown instead of a silent fail

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix in errors/*.pl and opac/errors/*.pl
Sébastien Hinderer [Sun, 1 Nov 2009 00:04:19 +0000 (01:04 +0100)]
Bugfix in errors/*.pl and opac/errors/*.pl

The scripts did not define the status printed on the first line of
HTTP headers correctly: they were sending 200 OK,
which was confusing for browsers.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoChange default AUTH_INDEX_MODE to dom
Colin Campbell [Fri, 12 Feb 2010 12:38:46 +0000 (12:38 +0000)]
Change default AUTH_INDEX_MODE to dom

[RM note: DOM is recommended for MARC21 authorities.  As of
 now, GRS-1 is the only mode supported for UNIMARC authorities.]

dom is the recommended authorities indexing mode in external docs
making it default accepts what appears to be the de facto preference
see Indexdata's documentation for more details on the options

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 2959 - Cache already failed URLs to speedup check-url.pl
Frédéric Demians [Fri, 12 Feb 2010 22:06:02 +0000 (23:06 +0100)]
Bug 2959 - Cache already failed URLs to speedup check-url.pl

Based on David Schuster improvement patch.

For David:

- To send the output into an HTML file, there is no need to add a
  paramater to this script, just redirect to a file:

  check-url --html --host-prot=http://koha-pro.mylib.org \\
    > /usr/local/koha/koha-tmpl/badurls.html

- If you want as a result a table with alternate rows, use CSS and
  JavaScript. For example, with jQuery (found with google):

  <style type="text/css">
  table {width:400px; border:1px solid blue;}
  .oddrow {background-color:#E5E5E5;}
  </style>
  <script type="text/javascript"
   src="http://code.jquery.com/jquery-latest.min.js"></script>
  <script type="text/javascript">
  $(function(){
    $("table.tiger-stripe tr:even").addClass("oddrow");
  });

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug #2162: Step 2, add pagination. Splits results into blocks of 250 results and...
Will Stokes [Sun, 14 Feb 2010 20:31:08 +0000 (09:31 +1300)]
Bug #2162: Step 2, add pagination. Splits results into blocks of 250 results and adds Previous and Next buttons. Achieved using forms, hidden search variables and submit buttons.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug #2162: Step 1, prevent running of report upon entry to page. Add name run_report...
Will Stokes [Sun, 14 Feb 2010 20:31:07 +0000 (09:31 +1300)]
Bug #2162: Step 1, prevent running of report upon entry to page. Add name run_report to submit button and checks in template.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4181: Fixes XHTML in viewlog.tmpl.
Garry Collum [Sun, 14 Feb 2010 23:34:43 +0000 (18:34 -0500)]
Bug 4181: Fixes XHTML in viewlog.tmpl.

Also adds zebra striping to the data table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofixed errors in previous patch
Galen Charlton [Mon, 15 Feb 2010 00:07:45 +0000 (19:07 -0500)]
fixed errors in previous patch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFixing some small XSS vulnerabilities
Chris Cormack [Sun, 14 Feb 2010 23:25:42 +0000 (12:25 +1300)]
Fixing some small XSS vulnerabilities

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 1542: remove now unneeded parameter
Galen Charlton [Sun, 14 Feb 2010 23:31:58 +0000 (18:31 -0500)]
bug 1542: remove now unneeded parameter

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 1542 followup - tweak to keep handling the UI selected value out of C4
Galen Charlton [Sun, 14 Feb 2010 23:30:08 +0000 (18:30 -0500)]
bug 1542 followup - tweak to keep handling the UI selected value out of C4

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 1542, followup patch to tidy up some messy dropdown behaviour
Chris Cormack [Sun, 14 Feb 2010 20:23:46 +0000 (09:23 +1300)]
Bug 1542, followup patch to tidy up some messy dropdown behaviour

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agonew test script to help debug template errors
Galen Charlton [Sun, 14 Feb 2010 23:05:45 +0000 (18:05 -0500)]
new test script to help debug template errors

From the POD:

NAME

show-template-structure.pl

DESCRIPTION

This script displays the structure of loops and conditional statements in
an HTML::Template::Pro template, and is an aid for debugging errors
reported by the xt/author/valid-templates.t test.  It also identifies the
following errors:

* TMPL_IF/TMPL_UNLESS/TMPL_LOOP with no closing tag
* TMPL_ELSE with no initial TMPL_IF or TMPL_UNLESS
* extra closing tags
* HTML comment of the form <!-- TMPL_FOO ..., where TMPL_FOO is not a valid HTML::Template::Pro tag

USAGE

xt/author/show-template-structure.pl path/to/template.tmpl

Output is sent to STDOUT.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoremove extra /TMPL_IF
Galen Charlton [Sun, 14 Feb 2010 23:05:14 +0000 (18:05 -0500)]
remove extra /TMPL_IF

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>