wip/koha-chris_n.git
9 years agoBug 5738 Display 856u As Image
Doug Dearden [Thu, 31 Mar 2011 21:22:26 +0000 (15:22 -0600)]
Bug 5738 Display 856u As Image

Add an option to the OPAC to display the URI that is stored in the 856u field
as an image instead of a text link.  This would be implemented in the OPAC XSLT
style sheets for the Results and Details pages, and would require that the
corresponding OPAC XSLT option be set.

This enhancement is designed to enable the staff to catalog images, then have
them appear on the resulting pages in the OPAC when searching.  Clicking on the
image would open it full size.  If the image option is in use, then the default
link text would be disabled.  Custom text would still appear if entered in the
"URLLinkText" option.

Add system preference "Display856uAsImage" with options of Results page,
Details page, Both Results and Details pages, Neither Results or Details page.

Notes for documentation manager:
There are two system preferences added for this enhancement:
OPACDisplay856uAsImage and Display856uAsImage.  These appear on the OPAC and
Staff Client screens under the System Preferences.

The preference can be set to one of four options:

Both Details and Results pages
Details page only
Neither Details or Results pages
Results page only

In addition to this option being set, the corresponding XSLT option must be
turned on. Also, the corresponding 856q field must have a valid MIME image
extension (e.g., "jpg") or MIME image type (i.e. starting with "image/"), or the
generic indicator "img" entered in the field.

As of 14 March 2011 the UNIMARC xslt display files also require a "0" in the
second indicator location of the 856u field for the links to be activated.  This
is not true for the MARC21 display files.

When all of the requirements are met, an image file will be displayed instead of
the standard link text. Clicking on the image will open it in the same way as
clicking on the link text.

Rebased and three original patches squashed into one on 30 March 2011 by Jared
Camins-Esakov.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Doug Dearden <dearden@sarsf.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_6003' into kcmaster
Chris Cormack [Fri, 1 Apr 2011 00:31:53 +0000 (13:31 +1300)]
Merge remote branch 'kc/new/enh/bug_6003' into kcmaster

9 years agoBug 6003 Display call number on return
Magnus Enger [Thu, 31 Mar 2011 03:09:24 +0000 (23:09 -0400)]
Bug 6003 Display call number on return

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5965 : Follow up patch, cleaned for style
Chris Cormack [Wed, 30 Mar 2011 10:24:20 +0000 (12:24 +0200)]
Bug 5965 : Follow up patch, cleaned for style

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5965 : Normalizing opac-detail.pl
Paul Poulain [Wed, 30 Mar 2011 10:24:19 +0000 (12:24 +0200)]
Bug 5965 : Normalizing opac-detail.pl

NFC on opac-detail

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5996 : MT2926: Fix default values for patron import
Matthias Meusburger [Wed, 30 Mar 2011 14:07:07 +0000 (16:07 +0200)]
Bug 5996 : MT2926: Fix default values for patron import

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5990: Lists and Cart show LOC code not Location Authorized value
Ian Walls [Wed, 30 Mar 2011 17:39:53 +0000 (13:39 -0400)]
Bug 5990: Lists and Cart show LOC code not Location Authorized value

Lists in the OPAC, and Cart on both sides, show the LOC code for items, rather
than the appropriate Description from Authorised Values.  This is because the
code uses GetItemInfo, which is a very heavy-weight call to only retrieve some
of the desired information.

This patch introduces a new subroutine in C4::Items, GetItemsLocationInfo, which
returns the branch names for both home- and holdingbranches, the location code,
both opac and intranet location descriptions, itemcallnumber and cn_sort. This
should be used instead of GetItemsInfo in any case where the locational
information is all that's required, as it's much more streamlined and efficient.

In the OPAC Lists, this only applies if OPACXSLTResultsDisplay is 'off' (set to
'normal').

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBumping database version number
Chris Cormack [Thu, 31 Mar 2011 23:06:20 +0000 (12:06 +1300)]
Bumping database version number

9 years agoBug 5957: Making COiNS in OPAC search results optional
Ian Walls [Wed, 30 Mar 2011 16:01:34 +0000 (12:01 -0400)]
Bug 5957: Making COiNS in OPAC search results optional

Adds a new system preference, COinSinOPACResults, which toggles the inclusion of
COiNS/OpenURL/Z39.88 in the search results display.  Default is 'on', continuing
the current behaviour.

Disabling this feature will result in a significant increase in search speed, since
each call to GetCOinSBiblio requires a separate parsing of the MARC record, and there are
<OPACnumSearchResults> calls to this routine with each search.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 4943: Search history cookie size limit
Matthias Meusburger [Wed, 30 Mar 2011 10:03:23 +0000 (12:03 +0200)]
Bug 4943: Search history cookie size limit

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5828 - notes for purchase suggestions not showing in the staff client
Owen Leonard [Thu, 31 Mar 2011 01:39:52 +0000 (21:39 -0400)]
Fix for Bug 5828 - notes for purchase suggestions not showing in the staff client

- Correcting the markup error that prevented the note from appearing
- Adding a little icon to set the note off from the other data

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_5548' into kcmaster
Chris Cormack [Thu, 31 Mar 2011 20:12:58 +0000 (09:12 +1300)]
Merge remote branch 'kc/new/enh/bug_5548' into kcmaster

9 years agoBug 5578 Followup: Hard Due Dates break hard-coded default circ rule
Ian Walls [Thu, 31 Mar 2011 19:33:17 +0000 (15:33 -0400)]
Bug 5578 Followup: Hard Due Dates break hard-coded default circ rule

If you do not have an applicable circulation rule for a combination of branch,
item type and patron category defined in your Circulation and Fines rules,
the Hard Due Dates development prevents circulation by introducing an error:

Can't call method "output" on an undefined value at /home/magnus/kohahead/C4/Circulation.pm line 2713

This is because the $hardduedate variable is not defined.  Changing the conditional
to check it, rather that it's output, fixes the issue.  That's what this patch does.

Is this the longest commit message for a single line fix?  Maybe.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6005: Fixes Transit slips cause FF4 to display "prevent this page from opening...
root [Wed, 30 Mar 2011 14:44:59 +0000 (10:44 -0400)]
Bug 6005: Fixes Transit slips cause FF4 to display "prevent this page from opening additional dialogs"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6004/3270: Sending things "home"
ruth@bywatersolutions.com [Wed, 30 Mar 2011 15:52:27 +0000 (10:52 -0500)]
Bug 6004/3270: Sending things "home"

This patch addresses two problems:

Bug 6004:

If an item is returned at other than its' home library, and there is a hold for
it--at any library other than the return library--two prompts come up: one
telling the user to send the item home, and the other, to confirm and transfer
for the hold.  Only the latter should be displayed.

Bug 3270:

Cancelling a hold request after transfer initiated orphans item.

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5305: CCL query, then resort, loses reults.
ruth@bywatersolutions.com [Wed, 30 Mar 2011 16:11:51 +0000 (11:11 -0500)]
Bug 5305: CCL query, then resort, loses reults.

If you did a CCL query, then attempted resort, you would get the advanced-search page,
because of wonky URL escaping of the q= clause.  This patch fixes that.

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5988 - SearchMyLibraryFirst preference appears twice in preferences
Owen Leonard [Wed, 30 Mar 2011 13:06:44 +0000 (09:06 -0400)]
Fix for Bug 5988 - SearchMyLibraryFirst preference appears twice in preferences

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 3523 - Menu of existing lists limited to 10
Owen Leonard [Wed, 30 Mar 2011 13:34:25 +0000 (15:34 +0200)]
Fix for Bug 3523 - Menu of existing lists limited to 10

- adding "more" option to the search results dropdown
- offering a scrolling list on the add-to-list popup
- lists add popup shows the full list of all
  the patron's lists, divided into groups of private and
  public lists.

Can be improved by a fix for Bug 5529

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/master' into new/bug_5940
Chris Cormack [Thu, 31 Mar 2011 07:45:52 +0000 (20:45 +1300)]
Merge remote branch 'kc/master' into new/bug_5940

9 years agoBug 5940: Offline Circ & Patron Card Help Files for 3.4
Nicole C. Engard [Wed, 30 Mar 2011 20:47:13 +0000 (16:47 -0400)]
Bug 5940: Offline Circ & Patron Card Help Files for 3.4

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug5940: Authority, Labels, Circ help files for 3.4
Nicole C. Engard [Wed, 30 Mar 2011 19:48:04 +0000 (15:48 -0400)]
Bug5940: Authority, Labels, Circ help files for 3.4

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5940: Admin Help Files for 3.4
Nicole C. Engard [Tue, 29 Mar 2011 21:35:41 +0000 (17:35 -0400)]
Bug 5940: Admin Help Files for 3.4

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMT3289 : check_sysprefs.pl case sensitive variable names
Henri-Damien LAURENT [Sun, 11 Apr 2010 18:40:57 +0000 (20:40 +0200)]
MT3289 : check_sysprefs.pl case sensitive variable names

Variable names for systempreferences are now case sensitive.
Changing check_sysprefs in relation with this change

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoTypo in kohastructured.sql thanks to Marcel de Rooy for the catch
Chris Cormack [Wed, 30 Mar 2011 22:41:48 +0000 (11:41 +1300)]
Typo in kohastructured.sql thanks to Marcel de Rooy for the catch

9 years agoBug 5548 bumping db version number
Chris Cormack [Wed, 30 Mar 2011 07:37:49 +0000 (20:37 +1300)]
Bug 5548 bumping db version number

9 years agoBug 5548: Hard Due Dates Circ Rule
Ian Walls [Mon, 28 Mar 2011 21:17:09 +0000 (17:17 -0400)]
Bug 5548: Hard Due Dates Circ Rule

Implements the RFC found at http://wiki.koha-community.org/wiki/Hard_Due_Dates_Circ_Rule_RFC.  See squashed commits
messages below for details of implementation.

Squashed commit of the following:

commit 871b91af00871146eb1216ebf5ce673dda2c5925
Author: Ian Walls <ian.walls@bywatersolutions.com>
Date:   Tue Dec 28 15:09:49 2010 -0500

    Hard Due Dates dev part 3: implementing the due dates in circ

    CalcDateDue now calls GetLoanLength, rather than each invocation running separately one after another.  Therefore, instead of
    the 'loanlength' param, CalcDateDue now takes 'itype', and uses the info to get both the issuelength and the hardduedate info (if it exists)

    Global Due Date no longer populates in the sticky due date field in Circ, since it can't be determined before the item is scanned.  Any specified
    due date still overrides the circulation rules, if allowed.

    Hard Due Dates in the past will return an error message, but can be manually specified if truly desired.

    Also, a small fix to updatedatabase.pl to allow the old data to populate if possible.

commit 14d5505f3c01287a2464a759f0076c1d4b665c49
Author: Ian Walls <ian.walls@bywatersolutions.com>
Date:   Mon Dec 27 18:28:11 2010 -0500

    HardDueDates dev part 2:  adding admin interface

    Adds columns to Smart Rules page, including calendar for easy date selection.

    Removes globalDueDate and ceilingDueDates from system preferences editors

commit 76e3e3d86a7a54c6ce4253e7f68278b4dc75a0bb
Author: Ian Walls <ian.walls@bywatersolutions.com>
Date:   Mon Dec 27 15:58:05 2010 -0500

    HardDueDates dev part 1: database changes

    Adds two new columns to issuingrules, a hardduedate and a hardduedatecompare.  If globalduedate is set, use that as the universal value
    for all circ rules.  Else, if ceilingduedate is set, use that as the universal value.  Adjust the comparison accordingly (-1 before, 0
    exact, 1 after).  the old system preferences globalDueDate and ceilingDueDate are then removed.

    Rebased onto 3.03.00.032

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5547 : Bumping db version
Chris Cormack [Wed, 30 Mar 2011 07:21:50 +0000 (20:21 +1300)]
Bug 5547 : Bumping db version

9 years agoBug 5547: Hide Lost Items dev
Ian Walls [Mon, 28 Mar 2011 14:21:02 +0000 (10:21 -0400)]
Bug 5547: Hide Lost Items dev

Adds a Hide Lost Items option to the staff client, as detailed in the enhancement request
at http://wiki.koha-community.org/wiki/Hidelostitems_option_for_the_staff_client_RFC

Minor edits: Whitespace

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5708 : Get Correct Discount when levying rentalcharge
Colin Campbell [Tue, 29 Mar 2011 13:57:41 +0000 (09:57 -0400)]
Bug 5708 : Get Correct Discount when levying rentalcharge

Branch can be a parameter so it should be included in the rule retrieval
Need to select the most appropriate rule from those returned
(was defaulting to first returned!)
Try to make what's happening a bit less opaque
null fields are returned as undefined not 'NULL' by DBI

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5982 : OPAC Serials Minor change in description
Paul POULAIN [Sat, 26 Mar 2011 22:17:58 +0000 (18:17 -0400)]
Bug 5982 : OPAC Serials Minor change in description

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5972 - DisplayClearScreenButton preference introduces invalid markup
Owen Leonard [Sat, 26 Mar 2011 15:06:51 +0000 (11:06 -0400)]
Fix for Bug 5972 - DisplayClearScreenButton preference introduces invalid markup

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5971, Minor markup error in holds queue report
Owen Leonard [Sat, 26 Mar 2011 18:26:47 +0000 (14:26 -0400)]
Fix for Bug 5971, Minor markup error in holds queue report

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 4393: Scan Indexes results cannot be sorted
Jared Camins-Esakov [Sat, 26 Mar 2011 10:01:51 +0000 (06:01 -0400)]
Bug 4393: Scan Indexes results cannot be sorted

Because of the way Scan Indexes works, the results cannot be sorted. Previously
when any sort other than relevance (or in some cases popularity) was used, the
search failed. This patch disables sorting on Scan results. This patch also
fixes the index selection dropdown on the results page, which was not being
populated correctly from the Advanced Search screen.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5964 : Translation problem on aqbudgets.tmpl
Henri-Damien LAURENT [Tue, 29 Mar 2011 16:04:21 +0000 (12:04 -0400)]
Bug 5964 : Translation problem on aqbudgets.tmpl

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_5940' into kcmaster
Chris Cormack [Wed, 30 Mar 2011 06:40:47 +0000 (19:40 +1300)]
Merge remote branch 'kc/new/bug_5940' into kcmaster

9 years agoBug 5940: Acq and Suggestion Help Files for 3.4
Nicole C. Engard [Tue, 29 Mar 2011 14:21:15 +0000 (10:21 -0400)]
Bug 5940: Acq and Suggestion Help Files for 3.4

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5687 : Bumping database version
Chris Cormack [Wed, 30 Mar 2011 06:36:20 +0000 (19:36 +1300)]
Bug 5687 : Bumping database version

9 years agoBug 5687: Add pref StaffAuthorisedValueImages for staff search results (install)
Marcel de Rooy [Tue, 29 Mar 2011 22:31:24 +0000 (18:31 -0400)]
Bug 5687: Add pref StaffAuthorisedValueImages for staff search results (install)

This patch contains only the install stuff. (Functionality in previous patch.)

Rebased on March 28.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5687: Add pref StaffAuthorisedValueImages for staff search results
Marcel de Rooy [Tue, 29 Mar 2011 22:30:13 +0000 (18:30 -0400)]
Bug 5687: Add pref StaffAuthorisedValueImages for staff search results

This patch contains the functionality, not the install stuff.

Revised: with input of Ian Walls: populate authorised_value_images only if needed; no changes anymore for template and search.pl.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 3629 : search limit by group is not OK
Paul POULAIN [Sat, 26 Mar 2011 22:24:19 +0000 (18:24 -0400)]
Bug 3629 : search limit by group is not OK

MT4491 : limitation by library group

- the group list was not displayed in OPAC (even if everything else was here
- the group limit was not working due to a missing ()

author=jean et group=droit" resulted in:
author=jean and branch=b1 or branch=b2 or branch=b3
that is wrong (executed from left to right)

the fix add () to have :
author=jean and (branch=b1 or branch=b2 or branch=b3)
that is OK

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5253: Add options to runreport.pl
Jared Camins-Esakov [Tue, 29 Mar 2011 01:16:02 +0000 (21:16 -0400)]
Bug 5253: Add options to runreport.pl

This makes sending reports via e-mail with runreport.pl work properly. It also
adds a --format option to allow the user to select between text, html, csv, and
tsv. At the moment text is not implemented, and falls back to tsv, but that is
still more readable than the HTML that used to be produced.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5833, opacstylesheet not loading on all pages
Owen Leonard [Sat, 26 Mar 2011 15:08:43 +0000 (11:08 -0400)]
Fix for Bug 5833, opacstylesheet not loading on all pages

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 4265: Fix padding of short callnumbers and Bib-1 attribute for sorting
Magnus Enger [Mon, 28 Mar 2011 15:42:57 +0000 (11:42 -0400)]
Bug 4265: Fix padding of short callnumbers and Bib-1 attribute for sorting

1. The current C4::ClassSortRoutine::Dewey turns "306 Les" into "306_Les" for items.cn_sort and MARC-field 952$6, which results in "306.46 Les" being sorted before "306 Les" in the OPAC. With this patch, "306 Les" is turned into "306_000000000000000_Les".

2. Currently, call_number_asc and call_number_desc are set up to sort by 1=20, but this is mapped to Local-classification in ccl.properties, which is mapped to 952$o in record.abs.

This patch changes these sorts to use 1=8007, which is mapped to cn-sort and 952$6.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5900: GetAllIssues performance issues
Jared Camins-Esakov [Sat, 26 Mar 2011 14:53:42 +0000 (10:53 -0400)]
Bug 5900: GetAllIssues performance issues

Previously GetAllIssues was called before authenticating. Given how expensive
GetAllIssues is, this is problematic and could be used for used for DOSing the
server. There should be no functional change from this patch.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 4366: Improve COinS support for MARC21
Jared CAMINS-ESAKOV [Sat, 26 Mar 2011 10:04:39 +0000 (06:04 -0400)]
Bug 4366: Improve COinS support for MARC21

This patch begins the process of improving the COinS support in Koha to take
advantage of all the metadata available in the MARC format. COinS still doesn't
work quite right, but at least it seems to be following the standard now. The
COinS exported by C4::Biblio::GetCOinSBiblio now correctly identifies articles
from journals and books as such.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_3326' into kcmaster
Chris Cormack [Mon, 28 Mar 2011 23:14:59 +0000 (12:14 +1300)]
Merge remote branch 'kc/new/bug_3326' into kcmaster

9 years agoBug 3326: Staff results still displayed &amp;
Jared Camins-Esakov [Sat, 26 Mar 2011 09:58:54 +0000 (05:58 -0400)]
Bug 3326: Staff results still displayed &amp;

In certain circumstances, ampersands would not be displayed properly in the
Staff client search results. This patch fixes that by ensuring that all the
doubled ampersands that Zebra inserts in XML indexing mode are replaced by the
correct single ampersand entity.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5838: Format sql outout on guided reports
Katrin Fischer [Sun, 27 Mar 2011 17:33:36 +0000 (13:33 -0400)]
Bug 5838: Format sql outout on guided reports

New suggestion: wrapping the sql output in <pre> with an unique id.

- sql can be formatted to be better readable
- sql can be hidden using css and the unique id
- pagination is pushed to its own line and better visible

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5817: Follow-up fixing callnum: on staff results
Jared Camins-Esakov [Sat, 26 Mar 2011 15:03:31 +0000 (11:03 -0400)]
Bug 5817: Follow-up fixing callnum: on staff results

This patch changes the call number links on the staff results page so that
searching will work. The underlying problem described by bug 5274 remains an
issue, but this fixes some of the more problematic symptoms.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/master' into new/bug_5817
Chris Cormack [Mon, 28 Mar 2011 19:44:48 +0000 (08:44 +1300)]
Merge remote branch 'kc/master' into new/bug_5817

9 years agoBug 5966 : MT 3010: Adds waiting date for holds in opac-user
Matthias Meusburger [Mon, 28 Mar 2011 08:29:46 +0000 (10:29 +0200)]
Bug 5966 : MT 3010: Adds waiting date for holds in opac-user

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 3203: ACCTDETAIL notices don't parse branches or borrowers tokens
Ian Walls [Sun, 27 Mar 2011 17:05:48 +0000 (13:05 -0400)]
Bug 3203: ACCTDETAIL notices don't parse branches or borrowers tokens

This patch enables the ACCTDETAIL notices (and any branch-specific derivatives) to use
<<branches.*>> and <<borrowers.*>> tokens

This patch also attempts to send the email from the branch email first, falling back to
KohaAdminEmailAddress if no branch email exists.

To test:

1. Enable AutoEmailOpacUser system preference
2. Add <<branches.*>> tokens to the ACCTDETAIL notice
3. Create a new patron, including:
   a. test email address in the field matching your AutoEmailPrimaryAddress syspref value
   b. username and password (required to send a notice)
   c. any other required fields to save the record
4. Check you inbox.  Notice should send instantly (no need to run process_message_queue.pl)

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5960 : Itemtype icons not showing correctly in staff search results
Chris Cormack [Mon, 28 Mar 2011 01:13:13 +0000 (21:13 -0400)]
Bug 5960 : Itemtype icons not showing correctly in staff search results

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBumping database version
Chris Cormack [Sun, 27 Mar 2011 20:55:51 +0000 (09:55 +1300)]
Bumping database version

9 years agoBug 4276: XSLT subject tracings only use subfield a
Jared Camins-Esakov [Wed, 16 Mar 2011 18:57:26 +0000 (14:57 -0400)]
Bug 4276: XSLT subject tracings only use subfield a

When XSLT is enabled, the subject tracings on the details view (both OPAC and
Intranet) previously only searched on the subfield 'a'. In addition, searches
failed when the tracing included parentheses, and the XSLT display did not
include subfields other than abcdvxyz, even for those 6xx tags that have other
subfields.

This patch adds a syspref: TraceSubjectSubdivisons. When
TraceSubjectSubdivisions is set to "Don't include" (default), the subject
tracings in the XSLT details view will only search on subfield 'a'. When
TraceSubjectSubdivisions is set to "Include", the subject tracings will search
on all subfields, not just subfield 'a'.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_3670' into kcmaster
Chris Cormack [Sun, 27 Mar 2011 08:19:24 +0000 (21:19 +1300)]
Merge remote branch 'kc/new/bug_3670' into kcmaster

Conflicts:
koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc

9 years agoBug 3670 Followup: fixes message preference form
Ian Walls [Thu, 24 Mar 2011 21:32:04 +0000 (17:32 -0400)]
Bug 3670 Followup: fixes message preference form

Changing the database value from "Item DUE" to "Item Due" broke the matching performed in the
messaging-preferences-form.inc file, resulting it the notice being labeled as "Unknown".

This patch changes both the matching, and the display, to "Item Due"

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_1962' into kcmaster
Chris Cormack [Sun, 27 Mar 2011 08:12:40 +0000 (21:12 +1300)]
Merge remote branch 'kc/new/enh/bug_1962' into kcmaster

Conflicts:
circ/returns.pl
installer/data/mysql/fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql
installer/data/mysql/it-IT/necessari/sysprefs.sql
installer/data/mysql/pl-PL/mandatory/sysprefs.sql
installer/data/mysql/ru-RU/mandatory/system_preferences_full_optimal_for_install_only.sql
installer/data/mysql/uk-UA/mandatory/system_preferences_full_optimal_for_install_only.sql
installer/data/mysql/updatedatabase.pl
kohaversion.pl

9 years agoBug 1962: Add new syspref FineNotifyAtCheckin
Katrin Fischer [Fri, 25 Mar 2011 23:27:15 +0000 (19:27 -0400)]
Bug 1962: Add new syspref FineNotifyAtCheckin

This patch adds a new syspref FineNotifyAtCheckin.

With syspref ON there will be a message when checking in books from
a patron with outstanding fines.

With syspref OFF (default) no message will be shown.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5954: 490$a not used to create search link in XSLT
ruth@bywatersolutions.com [Fri, 25 Mar 2011 17:44:36 +0000 (13:44 -0400)]
Bug 5954: 490$a not used to create search link in XSLT

This bug corrects a minor XSLT bug that is causing 490$t (which is not defined) to create
search links when XSLT is enabled

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5940: Catalog and Cataloging Help Files for 3.4
Nicole C. Engard [Sat, 26 Mar 2011 00:10:08 +0000 (20:10 -0400)]
Bug 5940: Catalog and Cataloging Help Files for 3.4

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5940: Update Patron Help Files
Nicole C. Engard [Thu, 24 Mar 2011 20:27:03 +0000 (16:27 -0400)]
Bug 5940: Update Patron Help Files

This patch updates the help files in the patron area of Koha.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5930 : improving/modifying authority display on OPAC
Paul Poulain [Tue, 22 Mar 2011 14:58:01 +0000 (15:58 +0100)]
Bug 5930 : improving/modifying authority display on OPAC

- changing some terms that are unclear for a patron
- removing tag & subfields values & indicators
- removing UNIMARC coded fields
- changing the search page (removing options useless for a patron)

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5926 : Fixing Hierarchies : taking any heading subfield
Henri-Damien LAURENT [Tue, 22 Mar 2011 14:34:53 +0000 (15:34 +0100)]
Bug 5926 : Fixing Hierarchies : taking any heading subfield

Conflicts solved:

C4/AuthoritiesMarc.pm

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5932 Remove itemdata sub from C4::Serials
Colin Campbell [Thu, 24 Mar 2011 09:44:29 +0000 (10:44 +0100)]
Bug 5932 Remove itemdata sub from C4::Serials

C4/Serials does not need to retrieve full item data
just to check if barcode is unique. Replace with
a lighter weight subroutine make code logic clearer and
cleaner

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5944 : (MT #3000) new cronjob script to delete old suggestions
Henri-Damien LAURENT [Thu, 24 Mar 2011 08:58:12 +0000 (09:58 +0100)]
Bug 5944 : (MT #3000) new cronjob script to delete old suggestions

This patch is a new script that delete suggestion that have be processed by librarians.
It take on argument, it's a number of days to keep suggestions. Suggestions olders than TODAY - $days will be deleted.
This script should be used to purge suggestions and clean the table in intranet.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_5880' into kcmaster
Chris Cormack [Thu, 24 Mar 2011 09:09:50 +0000 (22:09 +1300)]
Merge remote branch 'kc/new/enh/bug_5880' into kcmaster

9 years agoBug 5880: Correct misleading pod in new subroutine
Colin Campbell [Tue, 22 Mar 2011 15:24:06 +0000 (15:24 +0000)]
Bug 5880: Correct misleading pod in new subroutine

Also remove some whitespace noise from prev commit

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5919: Display MARC21 fields 583, 586, 530
Jared Camins-Esakov [Sun, 22 May 2011 21:32:07 +0000 (17:32 -0400)]
Bug 5919: Display MARC21 fields 583, 586, 530

This patch adds the MARC21 fields 583 (Action note), 586 (Awards note), and
530 (Additional physical form available note) to the OPAC details display in the
XSLT-controlled portion of the page. In order to allow libraries to hide these
notes if they do not want them added, the notes have been given CSS classes.

Depends on patch for Bug 3098.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 3098 follow-up: Clean up formatting
Jared Camins-Esakov [Sun, 22 May 2011 21:31:47 +0000 (17:31 -0400)]
Bug 3098 follow-up: Clean up formatting

This patch cleans up the formatting of the 856 display code in
MARC21slim2OPACDetail.xsl. Tabstops are correct, and the OPACURLOpenInNewWindow
syspref check is moved to control the use of a 'target="_blank"' attribute,
rather than having two blocks of almost-identical code.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5939: "Save and edit items" button broken
Jared Camins-Esakov [Mon, 23 May 2011 07:34:07 +0000 (03:34 -0400)]
Bug 5939: "Save and edit items" button broken

When modifying an existing biblio, the "Save and edit items" option in the
"Save" menu did not redirect to the edit items screen. Instead, it redirected to
the regular details screen.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5921: Add enumchron to the items detail page
Jared Camins-Esakov [Sun, 22 May 2011 21:36:43 +0000 (17:36 -0400)]
Bug 5921: Add enumchron to the items detail page

This patch adds the Serial enumeration/chronology field to the items display in
moredetail.pl.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5883 : Prevent re-encoding the items if they are already in UTF-8 in ModBiblio.
Frédérick Capovilla [Wed, 23 Mar 2011 14:19:57 +0000 (15:19 +0100)]
Bug 5883 : Prevent re-encoding the items if they are already in UTF-8 in ModBiblio.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBumping database number
Chris Cormack [Wed, 23 Mar 2011 09:11:54 +0000 (22:11 +1300)]
Bumping database number

9 years agoBug 5641: Replace Favicon through staff client
Jared Camins-Esakov [Thu, 17 Mar 2011 23:58:54 +0000 (19:58 -0400)]
Bug 5641: Replace Favicon through staff client

This patch adds two sysprefs:
OpacFavicon
IntranetFavicon

The two sysprefs take full URLs to an alternate favicon.ico file for the OPAC
and Staff Client, respectively. Leaving them blank will use the favicon.ico file
that is included with Koha.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5902: additem.pl should default to set library
Jared Camins-Esakov [Fri, 18 Mar 2011 00:48:33 +0000 (20:48 -0400)]
Bug 5902: additem.pl should default to set library

This patch makes the additem screen default to selecting the currently set
library. If the library is unset, it will default to the first branch
alphabetically.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 3382: Add CSS classes to OPAC XSLT <img> tags
Jared Camins-Esakov [Fri, 18 Mar 2011 00:54:15 +0000 (20:54 -0400)]
Bug 3382: Add CSS classes to OPAC XSLT <img> tags

This patch adds materialtype, format, and natureofcontents CSS classes to the
<img> tags produced by the OPAC XSLT stylesheets for use with CSS and jQuery.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5913 : Remove broken link from authorities search results
Matthias Meusburger [Tue, 22 Mar 2011 10:49:50 +0000 (11:49 +0100)]
Bug 5913 : Remove broken link from authorities search results

BibLibre bug #2949

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5909 : SetUTF8Flag on any incoming data
Henri-Damien LAURENT [Tue, 22 Mar 2011 09:59:52 +0000 (10:59 +0100)]
Bug 5909 : SetUTF8Flag on any incoming data

This prompts NFC normalization on adding record
Therefore, any saved record will be NFC normalized

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5907 : MT 2538 : Using default authtypecode for authority display
Matthias Meusburger [Tue, 22 Mar 2011 09:13:12 +0000 (10:13 +0100)]
Bug 5907 : MT 2538 : Using default authtypecode for authority display

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5931 Paging and sorting saved reports table
Frédéric Demians [Tue, 22 Mar 2011 14:00:13 +0000 (09:00 -0500)]
Bug 5931 Paging and sorting saved reports table

On Reports > Saved reports page, a table shows all saved reports.
Table's rows are sorted by report IDs. When there are a lot reports,
this table is difficult to read.

This enhancement add to Saved report page a paging bar and sort options on
column names, like in the framework table.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFixed another template error thanks Jared
Chris Cormack [Tue, 22 Mar 2011 22:02:53 +0000 (11:02 +1300)]
Fixed another template error thanks Jared

9 years agoFixing template bug, once again unit tests rule!
Chris Cormack [Tue, 22 Mar 2011 21:51:54 +0000 (10:51 +1300)]
Fixing template bug, once again unit tests rule!

9 years agoBumping database version
Chris Cormack [Tue, 22 Mar 2011 21:42:38 +0000 (10:42 +1300)]
Bumping database version

9 years agoBug 5928 follow up patch catching missing sysprefs
Chris Cormack [Tue, 22 Mar 2011 21:41:25 +0000 (10:41 +1300)]
Bug 5928 follow up patch catching missing sysprefs

9 years agoBug 5928 follow up remove branchcode label
Nicole C. Engard [Fri, 18 Mar 2011 02:18:39 +0000 (22:18 -0400)]
Bug 5928 follow up remove branchcode label

Under Acq info it said 'Branchcode,' I've changed this to 'Library'
to match the style used in other places.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5928 :wr77152 : AllowPurchaseSuggestionBranchChoice sys pref
Srdjan Jankovic [Fri, 18 Mar 2011 02:18:17 +0000 (22:18 -0400)]
Bug 5928 :wr77152 : AllowPurchaseSuggestionBranchChoice sys pref

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFixing missing syspref
Chris Cormack [Tue, 22 Mar 2011 08:57:23 +0000 (21:57 +1300)]
Fixing missing syspref

9 years agoBumping database version
Chris Cormack [Tue, 22 Mar 2011 08:13:21 +0000 (21:13 +1300)]
Bumping database version

9 years agoBug 5755: DB Update, add new syspref
Frédéric Demians [Wed, 16 Mar 2011 19:17:55 +0000 (15:17 -0400)]
Bug 5755: DB Update, add new syspref

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5755: Syspref to control facets truncation
Frédéric Demians [Wed, 16 Mar 2011 19:21:17 +0000 (15:21 -0400)]
Bug 5755: Syspref to control facets truncation

On OPAC/staff result page facets are truncated to 20 characters. On some OPAC
layout, it's not enough. A new syspref FacetLabelTruncationLength defines the
length to cut facets if necessary.

This patch add the syspref to searching.pref and add it to syspref various
language default values loaded into DB during installation process. It's not
necessary to update DB since length is fixed to 20 (as before) when this
syspref isn't defined in systemprefercences table.

Rebased to last HEAD: 2011.03.18

[Documentation] FacetLabelTruncationLength syspref in Searching tab

[3.2] It doesn't apply.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBumping database version
Chris Cormack [Tue, 22 Mar 2011 07:58:18 +0000 (20:58 +1300)]
Bumping database version

9 years ago3154 Preferences for building facets (install)
Marcel de Rooy [Wed, 16 Mar 2011 19:06:55 +0000 (15:06 -0400)]
3154 Preferences for building facets (install)

Adds prefs for facets in sql install files and updatedatabase script.

Rebased on March 17.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years ago3154 Preferences for building facets (functionality)
Marcel de Rooy [Wed, 16 Mar 2011 19:06:36 +0000 (15:06 -0400)]
3154 Preferences for building facets (functionality)

Based on patch from Fridolyn Somers with input of Frederic Demians.
Added new Searching preference maxRecordsForFacets.
This pref contains number of result records used in facet building.
Also added pref displayFacetCount (with thanks to Frederic).
Follow up patch takes care of install issues; functionality can already be tested with this patch only.

Updated on March 17 for changes in include files.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5390: OPAC loses library selection
Jared Camins-Esakov [Mon, 21 Mar 2011 21:36:20 +0000 (16:36 -0500)]
Bug 5390: OPAC loses library selection

This patch ensures that the OPAC library selection masthead will always default
to the branch that is currently being searched. This only applies to systems
with multiple branches and OpacAddMastheadLibraryPulldown turned on.

To test: do a search in the OPAC, limiting by branch. The search results will
still have that branch selected in the masthead dropdown.

This patch also fixes bug 5852 and bug 3778.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoRemove errant Makefile and pm_to_blib from repo
Jared Camins-Esakov [Mon, 21 Mar 2011 16:36:47 +0000 (12:36 -0400)]
Remove errant Makefile and pm_to_blib from repo

Makefile and pm_to_blib were added to the git repository by commit
ddbedbfc2f17bff016736afb5beae39a768a298a. Having those files in the repository
causes problems with updating to Master in dev-mode installs. This patch removes
those two files, since they shouldn't be tracked anyway.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5610: Add --since for setting messaging to default
Jared Camins-Esakov [Thu, 17 Mar 2011 01:02:30 +0000 (21:02 -0400)]
Bug 5610: Add --since for setting messaging to default

It is now possible to specify a command line argument --since so that the
borrowers-force-messaging-defaults script only changes patrons created starting
on a certain day. If the optional argument is not specified, the script applies
to all borrowers.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5610 Script to force borr transport defaults messaging
Frédéric Demians [Thu, 17 Mar 2011 01:02:09 +0000 (21:02 -0400)]
Bug 5610 Script to force borr transport defaults messaging

If the EnhancedMessagingPreferences syspref is enabled after borrowers
have been created in the DB, those borrowers won't have messaging
transport preferences default values as defined for their borrower
category, even no transport preferences at all. So you would have to
modify each borrower one by one if you would like to send them 'Hold
Filled' notice for example.

I propose this script to create transport preferences for all existing
borrowers and set them to default values defined for the category they
belong to.

[DOC] Should be documented somewhere.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5834: Holds link missing when 942$c is not for loan
Katrin Fischer [Sat, 19 Mar 2011 21:14:33 +0000 (17:14 -0400)]
Bug 5834: Holds link missing when 942$c is not for loan

Adds a check for item-level_itypes system preference. Note that this only
applies to the search results screens.

To test:
1) Set item-level_itypes to 'specific item'
2) Create record and set 942$c to an itype that is marked not for loan
3) Create item with itype not marked 'not for loan'
Current behaviour: Holds link is not shown, sys pref setting doesn't matter

After patch: Holds link is shown
- when item-level_itype is 'specific item'
- when item-level_itype is 'biblio record' and 942$c itype is for loan

Holds link is not shown
- when item-level_itype is 'biblio record' and 942$c is not for loan

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5065 Add ability to choose framework on import
Frédéric Demians [Wed, 16 Mar 2011 19:25:54 +0000 (15:25 -0400)]
Bug 5065 Add ability to choose framework on import

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>