wip/koha-chris_n.git
10 years agoFix for Bug 4884, opac-showmarc.pl can't find compact.xsl
Owen Leonard [Thu, 10 Jun 2010 17:09:14 +0000 (13:09 -0400)]
Fix for Bug 4884, opac-showmarc.pl can't find compact.xsl

This patch implements Fridolyn SOMERS' suggested change
to the .xsl file path but copies compact.xsl from the
intranet template dir and points to that instead.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4859, Formatting cleanup for merge biblio record interface
Owen Leonard [Tue, 8 Jun 2010 19:43:35 +0000 (15:43 -0400)]
Fix for Bug 4859, Formatting cleanup for merge biblio record interface

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4869 - Non-staff patrons logging into the OPAC don't have option to place...
Owen Leonard [Thu, 10 Jun 2010 18:14:26 +0000 (14:14 -0400)]
Fix for Bug 4869 - Non-staff patrons logging into the OPAC don't have option to place holds from Public Lists

The template was originally designed so that form controls were
hidden from users who didn't have permission to modify a particular
shelf  because the form controls were only used for deleting from
lists. Now that users can place holds and add tags via the check-
boxes, the controls must be available to all users.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug3916 : Batch Modify tool overwrites branches fields
Henri-Damien LAURENT [Wed, 23 Jun 2010 16:15:49 +0000 (18:15 +0200)]
Bug3916 : Batch Modify tool overwrites branches fields

This was owed to the Item modification construction and the change in GetBranchesLoop behaviour which selects the user branch by default.
Adding a void branch selected
Changing default value to ""

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4474 swap options for sys pref singleBranchMode
Katrin Fischer [Tue, 22 Jun 2010 05:22:54 +0000 (07:22 +0200)]
Bug 4474 swap options for sys pref singleBranchMode

Resend with corrected spelling.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4902: Add missing b_phone and b_email to borrower details
Katrin Fischer [Mon, 21 Jun 2010 21:09:41 +0000 (23:09 +0200)]
Bug 4902: Add missing b_phone and b_email to borrower details

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4900: add in missing value for usedaysmode pref
Nicole Engard [Mon, 21 Jun 2010 14:32:21 +0000 (10:32 -0400)]
bug 4900: add in missing value for usedaysmode pref

The usedaysmode preference was missing the option to
calculate due date by finding the next open date on the
calendar instead of ignoring all days the library is
closed.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4897: Invalid XHTML in opac-userupdate.tmpl.
Garry Collum [Mon, 21 Jun 2010 01:50:50 +0000 (21:50 -0400)]
Bug 4897: Invalid XHTML in opac-userupdate.tmpl.

Removes several duplicate name tags.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofixes to xt/sysprefs.t test case
Galen Charlton [Sat, 19 Jun 2010 19:56:07 +0000 (15:56 -0400)]
fixes to xt/sysprefs.t test case

* use root of source tree as base directory
* ignore case when comparing system preference codes;
  at present this is also case-insenstive in the database
* added German sysprefs file
* corrected paths to Russian and Ukrainian system preference files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofixed permissions for item batch deletion and modification for French
Galen Charlton [Sat, 19 Jun 2010 19:51:25 +0000 (15:51 -0400)]
fixed permissions for item batch deletion and modification for French

Solves bug where granular permissions for batch deletion and modification
would not work correction for a fresh installation using the French
translation.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofixed problems in xt/permissions.t test case
Galen Charlton [Sat, 19 Jun 2010 19:48:28 +0000 (15:48 -0400)]
fixed problems in xt/permissions.t test case

* now looks for permissions SQL files in the current
  source tree, not in intranetdir; tests in xt/ and
  t/ are meant to be run without requiring a full Koha
  installation
* added path to German
* fixed paths to permissions SQL for Russian and Ukrainian
* handles case where SQL script contains more than just
  inserts into to permissions

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4895: Add missing granular permissions
Katrin Fischer [Sat, 19 Jun 2010 13:20:15 +0000 (15:20 +0200)]
Bug 4895: Add missing granular permissions

Add missing granular permissions for serials to userpermissons.sql
de-DE, pl-PL

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoset DBversion to 139
Galen Charlton [Sat, 19 Jun 2010 13:03:45 +0000 (09:03 -0400)]
set DBversion to 139

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3682: change message_attributes.message_name from varchar(20) to varchar(40)
Katrin Fischer [Thu, 17 Jun 2010 21:51:40 +0000 (23:51 +0200)]
Bug 3682: change message_attributes.message_name from varchar(20) to varchar(40)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4868 - Improve controls for cloning and deleting MARC subfields
Owen Leonard [Wed, 9 Jun 2010 18:46:37 +0000 (14:46 -0400)]
Fix for Bug 4868 - Improve controls for cloning and deleting MARC subfields

Changes "+" and "-" controls to actively linked images giving
better feedback about their clickability and an increased click
target area.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoPage structure correction, helps Bug 3850 (Page Need Design Work)
Owen Leonard [Tue, 8 Jun 2010 16:03:00 +0000 (12:03 -0400)]
Page structure correction, helps Bug 3850 (Page Need Design Work)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFixes bug 3619: _send_message_by_email not respecting AutoEmailPrimaryAddress = ...
Ian Walls [Mon, 14 Jun 2010 14:26:09 +0000 (14:26 +0000)]
Fixes bug 3619: _send_message_by_email not respecting AutoEmailPrimaryAddress = 'OFF'

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBUG 4883: Staff - remove \n from strings for translation
Katrin Fischer [Thu, 17 Jun 2010 19:51:22 +0000 (21:51 +0200)]
BUG 4883: Staff - remove \n from strings for translation

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4833: OPAC - remove \n from strings for translation
Katrin Fischer [Thu, 17 Jun 2010 19:51:21 +0000 (21:51 +0200)]
Bug 4833: OPAC - remove \n from strings for translation

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4895: Add missing granular permissions to ru-RU, uk-UA
Katrin Fischer [Thu, 17 Jun 2010 20:46:47 +0000 (22:46 +0200)]
Bug 4895: Add missing granular permissions to ru-RU, uk-UA

Files are different from en files, combining userpermissions.sql and userflags.sql.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4895: Add missing granular permissions to de-DE, pl-PL
Katrin Fischer [Thu, 17 Jun 2010 20:46:46 +0000 (22:46 +0200)]
Bug 4895: Add missing granular permissions to de-DE, pl-PL

Added missing permissions, files are translations of en.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBut 4890: Fixes invalid XHTML in basket.tmpl
Garry Collum [Sat, 12 Jun 2010 15:50:38 +0000 (11:50 -0400)]
But 4890: Fixes invalid XHTML in basket.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4889: Fixes minor XHTML error in booksellers.tmpl.
Garry Collum [Sat, 12 Jun 2010 03:02:17 +0000 (23:02 -0400)]
Bug 4889: Fixes minor XHTML error in booksellers.tmpl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4827: Fixes library drop-down list in aqbudgets.tmpl
Garry Collum [Fri, 11 Jun 2010 01:53:56 +0000 (21:53 -0400)]
Bug 4827: Fixes library drop-down list in aqbudgets.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4896: granular permissions now always on (DB rev 138)
Galen Charlton [Sat, 19 Jun 2010 11:53:59 +0000 (07:53 -0400)]
bug 4896: granular permissions now always on (DB rev 138)

Per the following koha-devel thread, the use of
staff user subpermissions, AKA granular permissions, is
now the default behavior in Koha.  This patch removes
the GranularPermissions system preference.

[1] http://lists.koha-community.org/pipermail/koha-devel/2010-February/033670.html

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFollow up patch, removing missed conflict marker
Chris Cormack [Wed, 16 Jun 2010 04:42:14 +0000 (16:42 +1200)]
Follow up patch, removing missed conflict marker

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoCherry-picked onto master, fixing conflicts: MT 1816: Granular permissions for the...
Chris Cormack [Wed, 16 Jun 2010 04:38:31 +0000 (16:38 +1200)]
Cherry-picked onto master, fixing conflicts: MT 1816: Granular permissions for the serials module

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Conflicts:

installer/data/mysql/en/mandatory/userpermissions.sql
installer/data/mysql/fr-FR/1-Obligatoire/userpermissions.sql
installer/data/mysql/updatedatabase30.pl
koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tmpl
serials/member-search.pl
serials/serials-edit.pl
serials/subscription-add.pl
serials/subscription-bib-search.pl
serials/subscription-detail.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMissing indexes and a missing column
Chris Cormack [Sat, 19 Jun 2010 08:14:22 +0000 (20:14 +1200)]
Missing indexes and a missing column

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMissing tables in the kohastructure.sql table.
Chris Cormack [Sat, 19 Jun 2010 08:02:29 +0000 (20:02 +1200)]
Missing tables in the kohastructure.sql table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoChanging <p> to <span> per gmcharlt's suggestion re: Adding <p class="noholdstext...
Liz Rea [Wed, 9 Jun 2010 18:27:35 +0000 (13:27 -0500)]
Changing <p> to <span> per gmcharlt's suggestion re: Adding <p class="noholdstext"> tag around the "No Holds Allowed" text to allow for jquery selection/replacement of the text.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdding <p class="noholdstext"> tag around the "No Holds Allowed" text to allow for...
Liz Rea [Wed, 26 May 2010 19:28:47 +0000 (14:28 -0500)]
Adding <p class="noholdstext"> tag around the "No Holds Allowed" text to allow for jquery selection/replacement of the text.

A later patch might come that changes the text entirely, as it does not match the OPAC, and is often confusing for staff.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4472 - Missing / in img tags breaking xslt (and other img tags)
Chris Cormack [Mon, 14 Jun 2010 22:01:54 +0000 (10:01 +1200)]
Bug 4472 - Missing / in img tags breaking xslt (and other img tags)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoUpdated history file, 2 more committers
Chris Cormack [Tue, 15 Jun 2010 05:25:32 +0000 (17:25 +1200)]
Updated history file, 2 more committers

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix depreciation warnings in acqui/z3950_search.pl
Colin Campbell [Tue, 15 Jun 2010 17:42:18 +0000 (18:42 +0100)]
Fix depreciation warnings in acqui/z3950_search.pl

Perl generates depreciation warnings on compilation
caused by use of ambiguous syntax. Seemed that an
underlying confusion as to row's type

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 2789 Fix UNIMAC leader plugin
Frédéric Demians [Fri, 4 Jun 2010 15:04:18 +0000 (17:04 +0200)]
Bug 2789 Fix UNIMAC leader plugin

The plugin was returning a 25 characters length leader rather than 24
characters. So leader was recreated automatically, removing user update,
before writing biblio record.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(bug #4853) change rights needed to renew loans
Nahuel ANGELINETTI [Mon, 7 Jun 2010 09:09:19 +0000 (11:09 +0200)]
(bug #4853) change rights needed to renew loans

Use "circulate" right, instead of "borrower".

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 2505: Enabled warnings in patron-attr-types.pl
Garry Collum [Sat, 5 Jun 2010 22:29:40 +0000 (18:29 -0400)]
Bug 2505: Enabled warnings in patron-attr-types.pl

Fixed all resulting  errors.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFinal batch of POD cleanups.
Andrew Elwell [Mon, 7 Jun 2010 14:12:18 +0000 (16:12 +0200)]
Final batch of POD cleanups.

Should fix any remaining warnings with 'podchecker'

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoPOD Cleanups
Andrew Elwell [Mon, 7 Jun 2010 10:06:44 +0000 (12:06 +0200)]
POD Cleanups

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMore POD cleanups
Andrew Elwell [Sun, 6 Jun 2010 17:47:14 +0000 (19:47 +0200)]
More POD cleanups

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoPOD Cleanups - Few minor ones this time
Andrew Elwell [Sat, 5 Jun 2010 21:17:11 +0000 (23:17 +0200)]
POD Cleanups - Few minor ones this time

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAnother batch of POD cleanups
Andrew Elwell [Sat, 5 Jun 2010 21:17:10 +0000 (23:17 +0200)]
Another batch of POD cleanups

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoThe start of some POD cleanups in C4/*.pm
Andrew Elwell [Sat, 5 Jun 2010 11:16:51 +0000 (13:16 +0200)]
The start of some POD cleanups in C4/*.pm

If these are acceptable I'll continue - target is to get rid of all warnings
and errors with podcheck and make sure that any man and html formatted pod
docs look 'OK'

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoapplied paranoia
Galen Charlton [Wed, 9 Jun 2010 12:33:19 +0000 (08:33 -0400)]
applied paranoia

RM note: we've had our fun; next patch will be to trim
the comment to something that makes sense in context.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBuild with pdebuild, not debuild.
Lars Wirzenius [Tue, 8 Jun 2010 02:37:38 +0000 (14:37 +1200)]
Build with pdebuild, not debuild.

This checks build dependency declarations more thoroughly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoRemove dependencies on perl-base.
Lars Wirzenius [Fri, 4 Jun 2010 02:52:44 +0000 (14:52 +1200)]
Remove dependencies on perl-base.

perl-base is a required package, so it is always installed on a Debian
system, and Debian packages should not depend on it, unless they need
it a specific version, and I don't think we do.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug #4864 Add SIPServer Perl Module Dependencies
Colin Campbell [Wed, 9 Jun 2010 11:14:15 +0000 (12:14 +0100)]
Bug #4864 Add SIPServer Perl Module Dependencies

SIPServer requires Net::Server and UNIVERSAL::require

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoset DBrev to 136 for previous patch to add edit_items
Galen Charlton [Fri, 4 Jun 2010 01:04:17 +0000 (21:04 -0400)]
set DBrev to 136 for previous patch to add edit_items

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMT2938 : Adds a permission for editing items
Henri-Damien LAURENT [Thu, 27 May 2010 20:03:36 +0000 (22:03 +0200)]
MT2938 : Adds a permission for editing items

This patch adds a permission on edit_items

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 3081, Url's contain spaces
Owen Leonard [Fri, 28 May 2010 14:49:46 +0000 (10:49 -0400)]
Fix for Bug 3081, Url's contain spaces

My investigation finds that the problem in Internet
Explorer was not with the spaces in the URL but
with the spaces in the "name" attribute of the pop-up
window. Converting spaces to underscores allows
the plugin links to work correctly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 3770, 'Add to list' page only allows adding to private lists
Owen Leonard [Thu, 3 Jun 2010 17:54:21 +0000 (13:54 -0400)]
Fix for Bug 3770, 'Add to list' page only allows adding to private lists

This patch is a reformat of chad@pennmanor.net's submission to
the bug report on 2010-02-16.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 3722 - Branch deletion results in incorrect message
Owen Leonard [Thu, 3 Jun 2010 17:37:33 +0000 (13:37 -0400)]
Fix for Bug 3722 - Branch deletion results in incorrect message

A fix was submitted by Nahuel on 23 Nov 2009 and pushed, but
it combined messages for existing patrons and existing items.
This patch defines separate messages for the various cases and
corrects a typo in the original fix which left existing patrons
unreported.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 3926, inadvertantly resurrected by me.
Owen Leonard [Thu, 3 Jun 2010 15:12:50 +0000 (11:12 -0400)]
Fix for Bug 3926, inadvertantly resurrected by me.

The template-side fix for Bug 3926 was overwritten by
another template change I submitted later. My bad.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 3992 - New Sys Prefs Branch - Local Use Tab not Highlighted
Owen Leonard [Wed, 2 Jun 2010 18:45:18 +0000 (14:45 -0400)]
Fix for Bug 3992 - New Sys Prefs Branch - Local Use Tab not Highlighted

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4205 remove extra 'plan by' option
Nicole Engard [Mon, 31 May 2010 23:56:23 +0000 (19:56 -0400)]
bug 4205 remove extra 'plan by' option

There wasn't a conditional in place to stop the planning
pull down from showing a blank 'plan by' option.

This patch also makes the other 'plan by' options look
cleaner by removing the all caps.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4844 Remove a circular dependency in koha_perl_deps.pl
Colin Campbell [Tue, 1 Jun 2010 16:52:12 +0000 (17:52 +0100)]
Bug 4844 Remove a circular dependency in koha_perl_deps.pl

Remove 'use Installer' which had external dependencies we're trying to
report on. Instead call Installer::PerlModules directly

added use warnings and strict
updated FSF address in License statement

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4504, Confirmation messages in opac account not translated
Owen Leonard [Wed, 2 Jun 2010 16:55:53 +0000 (12:55 -0400)]
Fix for Bug 4504, Confirmation messages in opac account not translated

Strings within JavaScript onclick attributes are not getting picked
up by the translator:

onclick="return confirmDelete(_('Are you sure you want to cancel this
hold?'));"

This patch converts those to use variables defined in the main
script block:

onclick="return confirmDelete(MSG_CONFIRM_DELETE_HOLD);"

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4845 change language from reserves to holds
Nicole Engard [Mon, 31 May 2010 04:56:00 +0000 (00:56 -0400)]
bug 4845 change language from reserves to holds

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoGerman web installer files, including translation of MARC21 frameworks
Katrin Fischer [Wed, 26 May 2010 20:11:47 +0000 (22:11 +0200)]
German web installer files, including translation of MARC21 frameworks

Translation of MARC21 frameworks according to http://www.d-nb.de/standardisierung/formate/marc21.htm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4445: Upping the daily limit for XISBN
Chris Cormack [Fri, 30 Apr 2010 21:45:56 +0000 (09:45 +1200)]
bug 4445: Upping the daily limit for XISBN

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4445 update OCLC text tips on preferences
Nicole Engard [Mon, 31 May 2010 23:40:06 +0000 (19:40 -0400)]
bug 4445 update OCLC text tips on preferences

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4834 split joined preferences
Nicole Engard [Thu, 27 May 2010 03:55:52 +0000 (23:55 -0400)]
bug 4834 split joined preferences

these prefs : FilterBeforeOverdueReport & DisplayClearScreenButton shouldn't be
lumped together - they do two very different things and have nothing to do with
each other.

this patch splits them into two individual preferences.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4027 fix testStatus typo to textStatus
Nicole Engard [Tue, 1 Jun 2010 00:36:38 +0000 (20:36 -0400)]
bug 4027 fix testStatus typo to textStatus

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoDisable a new site created with --request-db.
Lars Wirzenius [Thu, 3 Jun 2010 03:45:45 +0000 (15:45 +1200)]
Disable a new site created with --request-db.

This way, the various cron jobs will not try to do things to it.
They can't, since it is not yet really created.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoUpdate FSF address in debian/copyright.
Lars Wirzenius [Wed, 2 Jun 2010 05:51:38 +0000 (17:51 +1200)]
Update FSF address in debian/copyright.

This makes lintian be a bit more quiet.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoUpgrade Koha instance database schema when package is upgraded.
Lars Wirzenius [Wed, 2 Jun 2010 05:34:24 +0000 (17:34 +1200)]
Upgrade Koha instance database schema when package is upgraded.

If the new version of Koha requires a newer version of the database
schema, the Koha instances will work immediately after the package
is upgraded, rather than after the sysadmin has run koha-upgrade-schema
manually.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix bug 4818: Add note to koha README.Debian to maybe disable default vhost.
Lars Wirzenius [Wed, 2 Jun 2010 04:56:47 +0000 (16:56 +1200)]
Fix bug 4818: Add note to koha README.Debian to maybe disable default vhost.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdd YAML as a dependency, since C4/Record.pm uses it.
Lars Wirzenius [Wed, 2 Jun 2010 04:42:43 +0000 (16:42 +1200)]
Add YAML as a dependency, since C4/Record.pm uses it.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdd missing build-dependencies (python, python-debian).
Lars Wirzenius [Wed, 2 Jun 2010 04:42:44 +0000 (16:42 +1200)]
Add missing build-dependencies (python, python-debian).

Also, debian/control gets re-generated, from debian/control.in and
PerlDependencies.pm.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdd tools to update debian/control's build dependencies.
Lars Wirzenius [Fri, 28 May 2010 04:29:48 +0000 (16:29 +1200)]
Add tools to update debian/control's build dependencies.

The canonical list of Perl module dependencies are in
C4::Installer::PerlDependencies::PERL_DEPS now. Add a script
(debian/list-deps) to turn that into a list of Debian package names.

Because that is a slow process, and the output rarely changes, do
not do that at build time. Also, doing it at build time would require
modifying debian/control in evil ways.

Instead, add another tool, debian/update-control, which reads the
new file debian/control.in, and adds the output of debian/list-deps to
Build-Depends and creates a new debian/control.

debian/control.in is the master file. If changes are needed, that should
be edited. For performance and convenience reasons, the output is also kept
in git, but don't edit debian/control directly, please. Such changes
might get lost by the next commit by someone else.

Whenever PERL_DEPS changes, debian/update-control should be run as well
and the result committed to git.

This is not quite as automatic as it might be, but should be good enough.
It avoids keeping the list of Perl modules in two places.

Note that since it seems impossible to automatically figure out the Debian
package version that corresponds to a Perl module version, I have not
tried to do that at all.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMerge branch 'translation' of git://git.workbuffer.org/git/koha into to-push
Galen Charlton [Wed, 2 Jun 2010 11:05:23 +0000 (07:05 -0400)]
Merge branch 'translation' of git://git.workbuffer.org/git/koha into to-push

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoSystem Preference updates
Chris Cormack [Mon, 31 May 2010 10:11:40 +0000 (22:11 +1200)]
System Preference updates

10 years agoRaft of language updates
Chris Cormack [Mon, 31 May 2010 10:10:17 +0000 (22:10 +1200)]
Raft of language updates

10 years agoLanguage updates
Chris Cormack [Tue, 30 Mar 2010 03:50:08 +0000 (16:50 +1300)]
Language updates

10 years agoBug 4817: Point to README.Debian in koha package description, postinst output.
Lars Wirzenius [Thu, 27 May 2010 04:42:41 +0000 (16:42 +1200)]
Bug 4817: Point to README.Debian in koha package description, postinst output.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoWhitespace removal, removal of U+FEFF character
Owen Leonard [Wed, 26 May 2010 18:32:41 +0000 (14:32 -0400)]
Whitespace removal, removal of U+FEFF character

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdded "dialog alert" class to "No Results Found" message on the patron
Cindy Murdock Ames [Wed, 26 May 2010 16:56:26 +0000 (12:56 -0400)]
Added "dialog alert" class to "No Results Found" message on the patron
search so the alert stands out.  Previously no css was applied to it so
it was just plain text.  Librarians weren't noticing it.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(MT #2565) fix aqplan csv export, and turn off debug
Nahuel ANGELINETTI [Wed, 26 May 2010 14:06:45 +0000 (16:06 +0200)]
(MT #2565) fix aqplan csv export, and turn off debug

This fix the csv export that doesn't export correctly the budget name, it's empty column.
And it turn off some SQL debug that slow down the result of the page and the csv export.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4508: fix crash when editing patron attributes or message prefs
Galen Charlton [Wed, 26 May 2010 14:51:09 +0000 (10:51 -0400)]
bug 4508: fix crash when editing patron attributes or message prefs

When editing patron attributes or messaging preferences on the
patron editor, Koha would crash with the following error:

Software error:
Can't use an undefined value as an ARRAY reference at
/home/koha/kohaclone/C4/SQLHelper.pm line 186.

This would occur only when editing the specific attribute
or message preferences section, not when editing the entire
patron record.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoSet upload target to squeeze-dev.
Lars Wirzenius [Wed, 26 May 2010 06:52:58 +0000 (18:52 +1200)]
Set upload target to squeeze-dev.

Since we're uploading a git snapshot, this is not meant for
production, and thus it should not be uploaded to squeeze,
but for squeeze-dev.

Documentation for the pockets will appear in the apt
repository or the wiki once it is ready.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoUpdate README.Debian for koha-common with post-install setup.
Lars Wirzenius [Wed, 26 May 2010 06:53:00 +0000 (18:53 +1200)]
Update README.Debian for koha-common with post-install setup.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoUpdate README.Debian for koha.deb package.
Lars Wirzenius [Wed, 26 May 2010 06:53:01 +0000 (18:53 +1200)]
Update README.Debian for koha.deb package.

One bug fix (three steps, not two, are automated in koha-post-install-setup).
Also add a note about the need to possibly edit ports.conf.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoUse a native Debian package.
Lars Wirzenius [Wed, 26 May 2010 06:52:57 +0000 (18:52 +1200)]
Use a native Debian package.

Since the packaging is part of the upstream source, there's no point
in having a Debian version.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdd dependency on apache2-mpm-itk for koha-common.
Lars Wirzenius [Wed, 26 May 2010 06:52:59 +0000 (18:52 +1200)]
Add dependency on apache2-mpm-itk for koha-common.

The way things are set up, each Koha instance runs under its own
user account. At least for now, this requires apache2-mpm-itk.
Later we can investigate other possibilities.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMake sure the temporary version number comes before 3.2.
Lars Wirzenius [Wed, 26 May 2010 04:18:34 +0000 (16:18 +1200)]
Make sure the temporary version number comes before 3.2.

This way, upgrades from the temporary ones to the final release
will happen automatically.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4816: require authentication for placerequest.pl
Galen Charlton [Wed, 26 May 2010 03:27:20 +0000 (23:27 -0400)]
bug 4816: require authentication for placerequest.pl

Otherwise, it was possible to construct a URL to place
hold requests without authorization.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4386: fix email hold filled notifications
Galen Charlton [Wed, 26 May 2010 03:27:21 +0000 (23:27 -0400)]
bug 4386: fix email hold filled notifications

Call to GetMembers() was using the old parameter style.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoremoved needless imports of the YAML module
Galen Charlton [Tue, 25 May 2010 21:32:19 +0000 (17:32 -0400)]
removed needless imports of the YAML module

Removed instances of 'use YAML' that were either completely
unnecessary or which were used only in debug code.  Also
removed a needless import of Data::Dumper.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4199: Adds ability to print routing slip. Patch 2.
Garry Collum [Sat, 22 May 2010 19:01:20 +0000 (15:01 -0400)]
Bug 4199: Adds ability to print routing slip. Patch 2.

Previous patch added an invalid XHTML element.  This patch fixes it.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4199: Adds ability to print routing slip from serials-collection.
Garry Collum [Sat, 22 May 2010 18:54:46 +0000 (14:54 -0400)]
Bug 4199: Adds ability to print routing slip from serials-collection.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4805: Fixes multiple subscriptionid's being passed to serials-collection.
Garry Collum [Sun, 23 May 2010 23:55:26 +0000 (19:55 -0400)]
Bug 4805: Fixes multiple subscriptionid's being passed to serials-collection.

This is a replacement patch for my previous patch.

This patch insures that only unique subscriptionids are defined in the serials-edit form.  Multiple ids are passed to serials-collection, but not multiple copies of the same id.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofix another link to koha-community.org
Galen Charlton [Tue, 25 May 2010 19:23:49 +0000 (15:23 -0400)]
fix another link to koha-community.org

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofix a common "developement" typo
Galen Charlton [Tue, 25 May 2010 18:38:38 +0000 (14:38 -0400)]
fix a common "developement" typo

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4377: ensure HOLD_PRINT letter added during installation and upgrade (DBrev 135)
Galen Charlton [Tue, 25 May 2010 16:36:03 +0000 (12:36 -0400)]
bug 4377: ensure HOLD_PRINT letter added during installation and upgrade (DBrev 135)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4311: respect OPACXSLTResultsDisplay
Galen Charlton [Tue, 25 May 2010 15:00:29 +0000 (11:00 -0400)]
bug 4311: respect OPACXSLTResultsDisplay

Check OPACXSLTResultsDisplay instead of XSLTResultsDisplay when
determining whether to use the XSLT bib results stylesheet for
OPAC search results.

In the process, added a new $search_context parameter to
C4::Search::searchResults() to specify whether results
are to be served up for the staff interface or for the
OPAC.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4018: remove duplicate unAPI link when XSLT bib details display on
Galen Charlton [Tue, 25 May 2010 13:21:24 +0000 (09:21 -0400)]
bug 4018: remove duplicate unAPI link when XSLT bib details display on

The unAPI link is now added only in opac-detail.tmpl.  More than
one unAPI link in the same page was causing a bit of indigestion
for Zotero, which interprets multiple unAPI links as specifying
more than one resource on a given page.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoInstall the admin scripts.
Lars Wirzenius [Tue, 25 May 2010 01:44:27 +0000 (13:44 +1200)]
Install the admin scripts.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMake koha-create be able to handle manual database creation.
Lars Wirzenius [Tue, 25 May 2010 01:44:26 +0000 (13:44 +1200)]
Make koha-create be able to handle manual database creation.

This is necessary if we do not have access to DB server with sufficient
permissions. The DB server is used for other things, that may well be
the case.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdd support for a remote mysql server.
Lars Wirzenius [Tue, 25 May 2010 01:44:25 +0000 (13:44 +1200)]
Add support for a remote mysql server.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoUse /etc/mysql/koha-common.cnf instead of the Debian one.
Lars Wirzenius [Tue, 25 May 2010 01:44:24 +0000 (13:44 +1200)]
Use /etc/mysql/koha-common.cnf instead of the Debian one.

koha-common.postinst now creates a symlink to the Debian one.
The sysadmin may replace that manually with something that allows
Koha to access a remote mysql server.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>