wip/koha-chris_n.git
8 years agoMerge remote-tracking branch 'kc/new/bug_6476' into kcmaster
Chris Cormack [Sun, 14 Aug 2011 07:55:46 +0000 (19:55 +1200)]
Merge remote-tracking branch 'kc/new/bug_6476' into kcmaster

8 years agoBug 6476: Baker & Taylor Content Cafe link not showing
Ian Walls [Thu, 4 Aug 2011 15:21:01 +0000 (11:21 -0400)]
Bug 6476: Baker & Taylor Content Cafe link not showing

Another T:T issue.  Patch replaces 'BakerTaylorContenturl' with 'BakerTaylorContentURL'
universally in all occurences in the templates (only opac-detail.tt)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6692: Small template change: Set > Set library
Katrin Fischer [Fri, 5 Aug 2011 11:28:27 +0000 (13:28 +0200)]
Bug 6692: Small template change: Set > Set library

Changes the link to change the library from 'Set' to 'Set library'
in the grey toolbar in staff.

8 years agobug 6702 update typo in BiblioAddsAuthorities preference
Nicole C. Engard [Tue, 9 Aug 2011 23:56:26 +0000 (19:56 -0400)]
bug 6702 update typo in BiblioAddsAuthorities preference

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: MJ Ray <mjr@phonecoop.coop>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6626 - add sudo as a package dependency
Robin Sheat [Mon, 25 Jul 2011 02:16:30 +0000 (14:16 +1200)]
Bug 6626 - add sudo as a package dependency

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6150 UNIMARC field 225 plugin: allow $a value data entry
Frédéric Demians [Fri, 8 Apr 2011 17:49:33 +0000 (19:49 +0200)]
Bug 6150 UNIMARC field 225 plugin: allow $a value data entry

The current UNIMARC 225 plugin behavior forces cataloguer to select a
collection name in a combo box. The content of this combo box comes from
special EDITORS authorities list which is constructed by a script. So
there is no way to add a new collection directly in biblio data entry
form.

A input box can be added to the plugin form in order to enter by hand a
new collection.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6713, editing matching rules broken
Chris Cormack [Thu, 11 Aug 2011 22:23:59 +0000 (10:23 +1200)]
Bug 6713, editing matching rules broken

Was a template error, but also a bug that had been in there for a
while fixed too

Please test by editing a matching rule, match sure no new match checks
are added, and that the matchpoint components survive.

Then try importing some marc records using that match rule

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years ago5663: Show control number without organization code in staff URLs
Marcel de Rooy [Thu, 14 Jul 2011 09:46:42 +0000 (11:46 +0200)]
5663: Show control number without organization code in staff URLs

Intranet detail xsl adjusted at 4 places: 773 when leader19=c, 775, 780, 785.

Enable the pref UseControlNumber when testing this patch. And set pref XSLTDetailsDisplay to using XSLT stylesheets.
Test by adding a control number ($w) in abovementioned fields.
Go to staff detail and check if the links work.
Add some orgcode between parentheses or brackets in front of the control number.
Test again in staff detail if the links still work.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6550 - update values for OpacRenewalBranch preference
Nicole C. Engard [Fri, 1 Jul 2011 06:02:04 +0000 (02:02 -0400)]
Bug 6550 - update values for OpacRenewalBranch preference

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6553 : Follow up adding license statements
Chris Cormack [Mon, 1 Aug 2011 09:26:28 +0000 (21:26 +1200)]
Bug 6553 : Follow up adding license statements

http://bugs.koha-community.org/show_bug.cgi?id=6653

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Patch only adds license text.

8 years agoBug 6553 : Fixing authentication issue, there is no reason we should be able to use...
Chris Cormack [Mon, 1 Aug 2011 09:23:45 +0000 (21:23 +1200)]
Bug 6553 : Fixing authentication issue, there is no reason we should be able to use these without authentication

http://bugs.koha-community.org/show_bug.cgi?id=6653

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
8 years agobug 6701 - change timeout to say milliseconds
Nicole C. Engard [Wed, 10 Aug 2011 00:34:08 +0000 (20:34 -0400)]
bug 6701 - change timeout to say milliseconds

Signed-off-by: MJ Ray <mjr@phonecoop.coop>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6468 - Authorities browsing error in OPAC
Janusz Kaczmarek [Mon, 6 Jun 2011 13:43:19 +0000 (16:43 +0300)]
Bug 6468 - Authorities browsing error in OPAC

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6461 - BiblioDefaultView has no impact on how record are displayed when going...
Janusz Kaczmarek [Sat, 4 Jun 2011 23:55:30 +0000 (02:55 +0300)]
Bug 6461 - BiblioDefaultView has no impact on how record are displayed when going from results list

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agobug_6410: correct borrowernumber template var name
Srdjan Jankovic [Wed, 25 May 2011 23:22:03 +0000 (11:22 +1200)]
bug_6410: correct borrowernumber template var name

Conflicts:

koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tmpl

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6373 : Corrects a validation problem on addbiblio.pl on IE8
Frédérick Capovilla [Thu, 19 May 2011 14:46:29 +0000 (10:46 -0400)]
Bug 6373 : Corrects a validation problem on addbiblio.pl on IE8

The mandatory fields popup didn't appear when some mandatory fields
weren't filled on IE8. Replacing the "focus" with its JQuery equivalent
corrected the problem.

[EDIT by Owen Leonard] Removed commented line

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Follow-up by owen, that he forgot to upload on bugzilla:

Signed-off patch includes one minor edit: I removed the commented-out line

which the jQuery line replaces. We have git to track changes for us, we don't
have to leave old code in.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6369 Correct a formatting problem in the pdf generation of basketgroup.pl
Frédérick Capovilla [Wed, 18 May 2011 20:27:20 +0000 (16:27 -0400)]
Bug 6369 Correct a formatting problem in the pdf generation of basketgroup.pl

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoFix for Bug 6346 - Patron search results should be valigned top
Owen Leonard [Thu, 19 May 2011 19:11:56 +0000 (15:11 -0400)]
Fix for Bug 6346 - Patron search results should be valigned top

I'm going for the nuclear option: Let's valign-top all table cells.
Having vertical-align : middle really only works well if your
table cells have the same height.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoFix for Bug 6686, Can't delete messages
Owen Leonard [Tue, 9 Aug 2011 20:10:47 +0000 (16:10 -0400)]
Fix for Bug 6686, Can't delete messages

T:T variable scope error which only affected systems
with the AllowAllMessageDeletion preference ON

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agobug 6682: split openlibrary in to two words 'open library'
Nicole C. Engard [Mon, 8 Aug 2011 17:48:49 +0000 (13:48 -0400)]
bug 6682: split openlibrary in to two words 'open library'

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoFix for Bug 6291, Cart printing truncated in Firefox
Owen Leonard [Mon, 2 May 2011 19:27:54 +0000 (15:27 -0400)]
Fix for Bug 6291, Cart printing truncated in Firefox

Implementing 100% width and height on <table>,<td>, and <th>
as suggested by this post:

http://www.piglets.org/serendipity/archives/45-Fixing-truncated-printing-with-Firefox.html

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years ago6290: Fix warning on XSLT.pm
Marcel de Rooy [Mon, 2 May 2011 07:49:49 +0000 (09:49 +0200)]
6290: Fix warning on XSLT.pm

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
8 years agoBug 6280 : Don't generate invalid SQL in GetPendingIssues
Colin Campbell [Thu, 28 Apr 2011 13:39:45 +0000 (14:39 +0100)]
Bug 6280 : Don't generate invalid SQL in GetPendingIssues

Change to parameter list in GetPendingIssues made it
callable by an empty list resulting in invalid sql being
sent to server. As this was occuring on most issues error log
was filling up. Put safeguard in the routine
Also don't bother calling when you have no need

Some of the processing was needlessly obscure

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoAdding the 149th developer to the history
Chris Cormack [Thu, 11 Aug 2011 00:50:04 +0000 (12:50 +1200)]
Adding the 149th developer to the history

8 years agoBug 6277 : CustomLog by default
Nuño López Ansótegui [Tue, 3 May 2011 09:56:08 +0000 (11:56 +0200)]
Bug 6277 : CustomLog by default

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6275 - allow automated backups for packages
Robin Sheat [Thu, 28 Apr 2011 03:21:04 +0000 (15:21 +1200)]
Bug 6275 - allow automated backups for packages

This causes backups for the last two days to be stored by default. The
backups will go into /var/spool/koha.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoFix for Bug 6260 - Missing space in availability information of OPAC XSLT results
Owen Leonard [Mon, 8 Aug 2011 16:58:51 +0000 (12:58 -0400)]
Fix for Bug 6260 - Missing space in availability information of OPAC XSLT results

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6235 : Corrects the behaviour of the humanmsg box on IE8 and IE7.
Frédérick Capovilla [Thu, 21 Apr 2011 18:09:54 +0000 (14:09 -0400)]
Bug 6235 : Corrects the behaviour of the humanmsg box on IE8 and IE7.

Without this fix, the black box that appears when you save system
preferences doesn't disappear on IE.

Fix from http://code.google.com/p/humanmsg/issues/detail?id=1
(Thanks Owen Leonard)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoUpdating history
Chris Cormack [Thu, 11 Aug 2011 00:07:09 +0000 (12:07 +1200)]
Updating history

8 years agoBug 6144 - Cant hide constraints when showed at subfield edition
Juan Romay Sieira [Mon, 16 May 2011 22:09:37 +0000 (10:09 +1200)]
Bug 6144 - Cant hide constraints when showed at subfield edition

Reformatted for Template::Toolkit

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6078: Request to find borrowers without issues overload the server
Sophie Meynieux [Mon, 28 Feb 2011 15:25:23 +0000 (16:25 +0100)]
Bug 6078: Request to find borrowers without issues overload the server

Optimization of the SQL request using NOT EXISTS instead of NOT IN

BibLibre MT5946

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 5630 CAS improvements
Chris Cormack [Wed, 30 Mar 2011 21:06:46 +0000 (10:06 +1300)]
Bug 5630 CAS improvements

Squashed commit of the following:

commit 0e13a5278e11b288e48190dc26f31e96d06598dd
Author: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Date:   Wed Jan 19 21:24:39 2011 +0100

    Bug 5630 : fixing C4/Auth.pm

commit b55abc7a0dc1ca43b2610a27246293e9a9346e18
Author: Matthias Meusburger <matthias.meusburger@biblibre.com>
Date:   Wed Jan 19 21:24:38 2011 +0100

    Bug 5630 : Adds CAS documentation

commit df0098a6a65465e6e734f99f65fb453dd3fa11d1
Author: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Date:   Wed Jan 19 21:24:37 2011 +0100

    Bug 5630 : ilsdi service AuthenticatePatron doesn't with CAS syspref on

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
commit 31c8f0c0facfafae011ad24c9d458c50f2fad296
Author: Matthias Meusburger <matthias.meusburger@biblibre.com>
Date:   Wed Jan 19 21:24:36 2011 +0100

    Bug 5630 : Adds the ability to authenticate against multiple CAS servers

commit 9d0def826135d5756533dc0dcf8e0a107d1ac8fc
Author: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Date:   Wed Jan 19 21:24:34 2011 +0100

    Auth_with_cas : removing a warning

    $sth was defined twice in a function
    Removing the second definition

commit 5ee550e9a2bb7ab6bc09f14fced6ce0df8011eb0
Author: Matthias Meusburger <matthias.meusburger@biblibre.com>
Date:   Wed Jan 19 21:24:33 2011 +0100

    Bug 6012 : MT 2270: CAS proxy

    CAS Proxy
    Examples included are now really usable

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6034 - Shelving cart feature can wipe permanent shelving location in certain...
Jane Wagner [Fri, 1 Apr 2011 14:28:04 +0000 (10:28 -0400)]
Bug 6034 - Shelving cart feature can wipe permanent shelving location in certain circumstances

Bugfix for problems when shelving cart used without In Processing settings

To test, with InProcessingToShelvingCart off, NewItemsDefaultLocation blank,
and ReturnToShelvingCart on, create a new item.  Check the contents of the
location and permanent_location fields in its item record -- the same value
should be in both.  Then run the item through checkin, and look at those fields
again.  The location field should now be set to CART while permanent_location
should still have the original value.  After the cart_to_shelf cron job runs
with the proper timing, check the item record again.  Both location and
permanent_location should again be identical.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBZ6073: string misses to be translatable
Paul Poulain [Tue, 5 Apr 2011 16:03:19 +0000 (18:03 +0200)]
BZ6073: string misses to be translatable

Signed-off-by: Frederic Demians <frederic@tamil.fr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6683 - (es-ES) translate SQL scripts description
Tomas Cohen Arazi [Mon, 8 Aug 2011 20:11:44 +0000 (17:11 -0300)]
Bug 6683 - (es-ES) translate SQL scripts description

Signed-off-by: Federico Rinaudo <frinaudo@infocpt.com.ar>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoFix for Bug 6534 - Duplicate opac renew buttons at the top of the checkouts list
Owen Leonard [Thu, 7 Jul 2011 16:46:58 +0000 (12:46 -0400)]
Fix for Bug 6534 - Duplicate opac renew buttons at the top of the checkouts list

This patch uses JS to add two links to the top of the checkouts
table: renew selected and renew all. Clicking each one submits
the respective form.

Also added is a small validation routine to warn the user if
they try to "renew selected" without having checked any boxes.

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years ago5660 Webinstaller should check if KohaOpacLanguage exists in staff
Marcel de Rooy [Thu, 7 Apr 2011 12:10:40 +0000 (14:10 +0200)]
5660 Webinstaller should check if KohaOpacLanguage exists in staff

Rebased on April 27 for master (3.05.00.001).

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signing off on the whitespace changes made by Paul

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6527 - Table striping not working on cataloguing search
Liz Rea [Thu, 23 Jun 2011 14:49:19 +0000 (09:49 -0500)]
Bug 6527 - Table striping not working on cataloguing search

Resolves TT issue causing the results list in cataloguing search (addbooks.pl) to not be
striped.

To test:
More -> Cataloging
do a search

Without patch:
results will not alternate striping as originally intended.

With patch:
Results will be alternating white/grey.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
8 years agoFix for Bug 6669 - If a patron search returns one result, redirect to patron details...
Henri-Damien LAURENT [Thu, 4 Aug 2011 06:57:28 +0000 (02:57 -0400)]
Fix for Bug 6669 - If a patron search returns one result, redirect to patron details page

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoMerge remote-tracking branch 'kc/new/awaiting_qa/bug_6316' into kcmaster
Chris Cormack [Thu, 4 Aug 2011 22:21:20 +0000 (10:21 +1200)]
Merge remote-tracking branch 'kc/new/awaiting_qa/bug_6316' into kcmaster

8 years agoBug 6316 - es-ES inclusion - Last fixes
Tomas Cohen Arazi [Thu, 4 Aug 2011 21:53:41 +0000 (18:53 -0300)]
Bug 6316 - es-ES inclusion - Last fixes

Added diverged sysprefs, and added es-ES to the test list in xt/syspref.t

Yay!
To+

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoMerge remote-tracking branch 'kc/new/awaiting_qa/bug_6316' into kcmaster
Chris Cormack [Thu, 4 Aug 2011 21:37:49 +0000 (09:37 +1200)]
Merge remote-tracking branch 'kc/new/awaiting_qa/bug_6316' into kcmaster

8 years agoBug 5639 (MT #3605) Fix escaping in ILSDI
Jean-André Santoni [Wed, 26 May 2010 13:49:34 +0000 (15:49 +0200)]
Bug 5639 (MT #3605) Fix escaping in ILSDI

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoFix for a typo I made in the build script
Chris Cormack [Thu, 4 Aug 2011 20:46:09 +0000 (08:46 +1200)]
Fix for a typo I made in the build script

8 years agoBumping database version
Chris Cormack [Thu, 4 Aug 2011 08:57:56 +0000 (20:57 +1200)]
Bumping database version

8 years agoBug 5433 follow up - kohastructure.sql missing
Paul Poulain [Wed, 3 Aug 2011 14:43:47 +0000 (16:43 +0200)]
Bug 5433 follow up - kohastructure.sql missing

The 2 fields added by the updatedatabase were not in the kohastructure.sql

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoFix for Bug 5433 - Separate state field for cities
Owen Leonard [Fri, 22 Jul 2011 18:58:43 +0000 (14:58 -0400)]
Fix for Bug 5433 - Separate state field for cities

- Updates cities management (admin/cities.pl) to record a separate
  state and country field.
- Updates the cities table with these new columns
- Modifies the patron entry form to populate city, state, zip
  and country when the user chooses a prepopulated city entry

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 5072 - prevent creating new orders if there are no valid budgets
Robin Sheat [Thu, 29 Jul 2010 04:10:52 +0000 (16:10 +1200)]
Bug 5072 - prevent creating new orders if there are no valid budgets

On the basket editing screen, the links to add orders to a basket are
hidden unless a valid fund is available.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 5072 : Template changes
Chris Cormack [Mon, 1 Aug 2011 21:49:59 +0000 (09:49 +1200)]
Bug 5072 : Template changes

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 5468: removin apt-get-debian-lenny and updating INSTALL.debian
MJ Ray [Sun, 19 Jun 2011 16:51:53 +0000 (17:51 +0100)]
Bug 5468: removin apt-get-debian-lenny and updating INSTALL.debian

install_misc/apt-get-debian-lenny.sh: obsolete, causing problems and a questionable practice, so deleted INSTALL.debian: updated to use debian.packages instead and cite more related docs

Amended following feedback comment #6 from Robin Sheat <robin@catalyst.net.nz>

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBumping database version
Chris Cormack [Thu, 4 Aug 2011 01:33:00 +0000 (13:33 +1200)]
Bumping database version

8 years agoBug 5429 : Covers for detail page and database update
Chris Cormack [Sat, 23 Jul 2011 08:09:08 +0000 (20:09 +1200)]
Bug 5429 : Covers for detail page and database update

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 5429 : Open Library book covers
Chris Cormack [Sat, 23 Jul 2011 07:56:33 +0000 (19:56 +1200)]
Bug 5429 : Open Library book covers

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 5131 :restrict use of sort_by value to allowed values
Frère Sébastien Marie [Wed, 27 Jul 2011 09:48:29 +0000 (11:48 +0200)]
Bug 5131 :restrict use of sort_by value to allowed values

The user input for sort_by value was used without care, resulting the possibility for user to set any Template Variable to 1.

This patch restrict the values to sort field.
The list of allowd_sortby was taken from 'includes/resort_form.inc'.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoFixing a little style edit, so Perl::Critic won't complain
Chris Cormack [Thu, 4 Aug 2011 01:10:19 +0000 (13:10 +1200)]
Fixing a little style edit, so Perl::Critic won't complain

8 years agoBug 5602: Changes to account for the version update.
Robin Sheat [Thu, 2 Jun 2011 04:27:33 +0000 (16:27 +1200)]
Bug 5602: Changes to account for the version update.

This is intended to apply on top of the previous 5602 patch.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
8 years agobug 5602: Rewriting the package making script Now it is a perl script. Various pdebui...
Srdjan Jankovic [Wed, 27 Apr 2011 07:23:59 +0000 (19:23 +1200)]
bug 5602: Rewriting the package making script Now it is a perl script. Various pdebuild flexibility.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
8 years agoBumping database version
Chris Cormack [Wed, 3 Aug 2011 22:24:08 +0000 (10:24 +1200)]
Bumping database version

8 years agoBug 4839: Follow-up patch for installing pref
Marcel de Rooy [Thu, 17 Mar 2011 12:15:26 +0000 (13:15 +0100)]
Bug 4839: Follow-up patch for installing pref

Installs syspref MARCAuthorityControlField008.

Rebased June 1, 2011 for master.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 4839: Adjust default values for MARC21 authority Fixed-Length Data Elements
Marcel de Rooy [Mon, 29 Nov 2010 13:29:34 +0000 (14:29 +0100)]
Bug 4839: Adjust default values for MARC21 authority Fixed-Length Data Elements

Currently, the default for this MARC control field is hardcoded in the plugin code of marc21_field_008_authorities.pl (two occurrences).
This patch moves it into a new syspref. If this pref should not exist, the old hardcoded value is used. Authorities preference file is updated too.
A warning is generated if the length of the field is not correct.

Furthermore, the default for position 14 (heading use: main or added entry)
should be dependent on the authority type. For CHRON_TERM, GENRE/FORM and
TOPIC_TERM, it should be b (not appropriate) instead of a (appropriate).

Rebased on March 17. Follow-up patch added for installation pref.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
8 years agoBumping database version
Chris Cormack [Wed, 3 Aug 2011 21:55:18 +0000 (09:55 +1200)]
Bumping database version

8 years ago4959: Language inconsistencies on basket groups; skip confirmation when closing basket.
Marcel de Rooy [Thu, 12 May 2011 06:46:00 +0000 (18:46 +1200)]
4959: Language inconsistencies on basket groups; skip confirmation when closing basket.

Follow up patch for installing pref BasketConfirmations.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
8 years agoBug 4959 (Language inconsistencies on basket groups; skip confirmation when closing...
Marcel de Rooy [Tue, 12 Apr 2011 16:00:45 +0000 (17:00 +0100)]
Bug 4959 (Language inconsistencies on basket groups; skip confirmation when closing basket)

This patch adds a new pref BasketConfirmations. This adds the option to skip
confirmations on closing and reopening a basket. If you skip the confirmation,
you do not create a new basket group.
The confusing line Create a purchase order (when closing a basket) is replaced
by Attach basket to a new basket group with the same name.
A warning for a null value on basketgroupid is fixed.

Rebased April 11.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agobug_4415: Copy parent contact details to child when adding Let child details be manag...
Srdjan Jankovic [Wed, 3 Aug 2011 10:04:21 +0000 (12:04 +0200)]
bug_4415: Copy parent contact details to child when adding Let child details be managed separately

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 5737: Modified the merge subroutine in AuthoritiesMarc.pm so it won't destroy...
Frédérick Capovilla [Thu, 10 Feb 2011 15:50:12 +0000 (10:50 -0500)]
Bug 5737: Modified the merge subroutine in AuthoritiesMarc.pm so it won't destroy the connection to the biblioserver.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
8 years agoBug 5418: Follow up fix for translated sys pref sql files
Katrin Fischer [Mon, 30 May 2011 18:37:41 +0000 (20:37 +0200)]
Bug 5418: Follow up fix for translated sys pref sql files

Add 'libsuite8' as new option to system preference 'itemBarcodeInputFilter'

en and nb-NO files are already correct.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 5263 - Add support for including fields from the ISSUES table in advanced due...
Chris Nighswonger [Wed, 29 Sep 2010 13:27:30 +0000 (09:27 -0400)]
Bug 5263 - Add support for including fields from the ISSUES table in advanced due notices

Adding support for including fields from the Issues table in advanced due notices.
This is primarily to allow the inclusion of the due date for each item in the
advanced due notice, but will allow the inclusion of any field from the ISSUES
table.

This also adds code to exclude timestamp fields as these are irrelevant to the
end user in this context.

Note: Documentation should be updated to reflect the availability of the additional
fields in all circulation notices.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 5009 : Turning off autocomplete
Chris Cormack [Thu, 7 Jul 2011 22:02:27 +0000 (10:02 +1200)]
Bug 5009 : Turning off autocomplete

Files affected
koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc
koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc
koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoFix for Bug 6635, Can't page through results in label batch
Owen Leonard [Mon, 1 Aug 2011 03:05:09 +0000 (23:05 -0400)]
Fix for Bug 6635, Can't page through results in label batch

- Fixing T:T scope issue
- Correcting footer include for pop-up windows.
- Markup correction for validity.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6643 -- Able to download patron card batches as an unauthorized user
Liz Rea [Thu, 28 Jul 2011 20:59:15 +0000 (15:59 -0500)]
Bug 6643 -- Able to download patron card batches as an unauthorized user

Making sure permissions are checked on label creator

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6641 -- Specially crafted URL can allow unauthorized download of MARC files from...
Liz Rea [Thu, 28 Jul 2011 21:14:05 +0000 (16:14 -0500)]
Bug 6641 -- Specially crafted URL can allow unauthorized download of MARC files from staff client

Making sure permissions are checked on download of MARC files from staff client

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6642 : Making sure permissions are checked on label creator
Chris Cormack [Thu, 28 Jul 2011 21:03:25 +0000 (09:03 +1200)]
Bug 6642 : Making sure permissions are checked on label creator

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6135: insert fields ordered in C4::biblio:ModBiblioMarc
Stéphane Delaune [Fri, 13 May 2011 14:19:10 +0000 (16:19 +0200)]
Bug 6135: insert fields ordered in C4::biblio:ModBiblioMarc

Fixing order subfields for biblionumber and biblioitemnumber

BibLibre MT5951

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6311 check_inst_id was being passed non-existent value
Colin Campbell [Thu, 5 May 2011 14:32:08 +0000 (15:32 +0100)]
Bug 6311 check_inst_id was being passed non-existent value

Due to a typo in the hash key check_inst_id in the
handle_end_patron_session was always logging an error
as the actual field contents were not being checked
unlike in other messages

Signed-off-by: Frederic Demains <frederic@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6325 Bib detail - z39.50 button functionality should be under "Edit" menu
Liz Rea [Wed, 11 May 2011 05:55:33 +0000 (01:55 -0400)]
Bug 6325 Bib detail - z39.50 button functionality should be under "Edit" menu

Moves the button functionality under the "Edit" drop down, as "Replace Record via Z39.50"

To test:
Click Edit -> Replace Record via Z39.50 and attempt to replace the record.

Signed-off-by: D Ruth Bavousett <ruth@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years ago5662: Show control number without organization code in OPAC URLs
Marcel de Rooy [Thu, 14 Jul 2011 08:06:07 +0000 (10:06 +0200)]
5662: Show control number without organization code in OPAC URLs

OPAC detail xsl adjusted at four places: 773 when leader19=c, 775, 780, 785.

Enable the pref UseControlNumber when testing this patch. And set pref OPACXSLTDetailsDisplay to using XSLT stylesheets.
Test by adding a control number ($w) in abovementioned fields.
Go to opac detail and check if the links work.
Add some orgcode between parentheses or brackets in front of the control number.
Test again in opac detail if the links still work.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works with and without orgCode in front of $w now.
No change to current behaviour, but closer to MARC21 standard.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 4433: Small display problem for topical subjects
Katrin Fischer [Sun, 17 Jul 2011 20:43:31 +0000 (22:43 +0200)]
Bug 4433: Small display problem for topical subjects

This removes the subfield codes shown for topical subject authorities only.

To test:
- Add different authority records and at least one for a topical subject.
- Use search in intranet and opac (turn on opacauthorities) to serch for your subjects.
- All headings will show without the subfield codes (at least $a in front), except the
topical subject.

This patch removes the subfield codes for the topical headings.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Works as advertised in opac and staff. (July 18, 2011)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6598 : ensure OPACFineRenewals can prevent opac renewals
Colin Campbell [Thu, 14 Jul 2011 10:58:59 +0000 (06:58 -0400)]
Bug 6598 : ensure OPACFineRenewals can prevent opac renewals

patron_flagged was being passed at global scope to the template
but being checked as an element in other structures
Also although items could not be selected the Renew Selected
button was displayed, it too should check the flag
Amended the preference text which incorrectly suggested the
option could be turned off. (leading to the opposite to what
the user might expect)
In the script have explicitly assigned the value to a inumeric
variable rather than making an implicit conversion as it may be
that readers were missing that sleight of hand

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 4497: Make tabs for managing suggestions translatable
Katrin Fischer [Sun, 17 Jul 2011 18:53:29 +0000 (20:53 +0200)]
Bug 4497: Make tabs for managing suggestions translatable

This patch makes the tabs on the manage suggestion page translatable.

To test:
- Create some suggestions in intranet or opac and manage them to make the
different status tabs appear: accecpted, pending, checked, rejected
- Apply patch, run 'perl translate update <languagecode>'
- Check po file for string '%s %sPending %sAccepted %sChecked %sRejected %sAvailable %sOrdered%s %s%s %sNo name%s (%s)'
- Translate it, save and run 'perl translate install <languagecode>'

Tabs should now appear translated.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBZ6412 : spaces in note
Paul Poulain [Mon, 18 Jul 2011 22:06:00 +0000 (18:06 -0400)]
BZ6412 : spaces in note

There was an improper T::T <input> construction: the note value contained spaces.

This patch fixes the problem by using a correct [% IF %] construction

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoMerge remote-tracking branch 'kc/new/enh/bug_5922' into kcmaster
Chris Cormack [Mon, 1 Aug 2011 01:03:34 +0000 (13:03 +1200)]
Merge remote-tracking branch 'kc/new/enh/bug_5922' into kcmaster

8 years agoAdditional change for bug 5922 - Show waiting items for patron on return
Owen Leonard [Thu, 21 Jul 2011 15:44:32 +0000 (11:44 -0400)]
Additional change for bug 5922 - Show waiting items for patron on return

- Adding patron name to dialog
- Styling dialog as a message rather than an alert since it's
  informational rather than a warning

8 years agoBZ5719: unimarc plugin fixes
Paul Poulain [Wed, 29 Jun 2011 20:54:30 +0000 (22:54 +0200)]
BZ5719: unimarc plugin fixes

* 010 now don't care of - or no - in the isbn
* 225a window now higher to have all buttons displayed

Signed-off-by: Sophie Meynieux <sophie.meynieux@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6474 Barcode not incrementing properly in format HBYYMMINCR if HB contains -
Sophie Meynieux [Tue, 7 Jun 2011 10:33:38 +0000 (12:33 +0200)]
Bug 6474 Barcode not incrementing properly in format HBYYMMINCR if HB contains -

Adding - to regexp for matching branch code. Wondering if other characters should not be added too.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug #6057 - Improve finding next stock number
Alex Arnaud [Tue, 5 Apr 2011 12:10:19 +0000 (14:10 +0200)]
Bug #6057 - Improve finding next stock number

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoMerge remote-tracking branch 'kc/new/bug_6521' into kcmaster
Chris Cormack [Sun, 31 Jul 2011 23:32:43 +0000 (11:32 +1200)]
Merge remote-tracking branch 'kc/new/bug_6521' into kcmaster

8 years agoBug 6521 Follow up: previous patch breaks autoMemberNum functionality
Ian Walls [Wed, 20 Jul 2011 17:11:12 +0000 (13:11 -0400)]
Bug 6521 Follow up: previous patch breaks autoMemberNum functionality

The previous patch broke the autoMemberNum feature by adding a line to fixup_cardnumber
that returned 'undef' for cardnumber in all usages of the subroutine (limited to members/memberentry.pl
and tools/import_borrowers.pl.  This prevented the automatic number from being calculated in all cases.

This patch removes the offending line.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6080: Add id to total line in funds table
Katrin Fischer [Wed, 27 Jul 2011 21:01:02 +0000 (23:01 +0200)]
Bug 6080: Add id to total line in funds table

Alternate patch for bug 6080.

Instead of removing the line altogether make it possible to hide it
easily by adding an id.

To test:
- apply patch
- check your funds table for the last line labelled 'Total'
- add to IntranetUserCss: #funds_total {display:none;}
- check again, line should be hidden now

Reason:
The totals is only confusing for multi-level funds, but not wrong.
If you are using only 1 level of funds, it works all ok.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoFix for Bug 6638, Columns misaligned on serials claims
Owen Leonard [Thu, 28 Jul 2011 20:14:03 +0000 (16:14 -0400)]
Fix for Bug 6638, Columns misaligned on serials claims

T:T variable scope error. Also correcting placement of calendar
include in the source to avoid JavaScript error.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
8 years agoBug 6540 - [SIGNED-OFF] fix some command-line args issues
Robin Sheat [Thu, 21 Jul 2011 05:32:09 +0000 (17:32 +1200)]
Bug 6540 - [SIGNED-OFF] fix some command-line args issues

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6540 - Add config file as command line option for koha-create
Magnus Enger [Wed, 20 Jul 2011 17:01:19 +0000 (19:01 +0200)]
Bug 6540 - Add config file as command line option for koha-create

Order of precedence for config options, from lowest to highest:

1. The defaults set in koha-create itself
2. /etc/koha/koha-sites.conf
3. Config file specified with --configfile
4. Individual options set with --marcflavor, --zebralang, --defaultsql

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6540 - Add defaultsql command line option
Magnus Enger [Wed, 20 Jul 2011 14:08:51 +0000 (16:08 +0200)]
Bug 6540 - Add defaultsql command line option

This will override the setting in /etc/koha/koha-sites.conf.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6540 - Followup patch adding command line options
Magnus Enger [Mon, 18 Jul 2011 13:35:27 +0000 (15:35 +0200)]
Bug 6540 - Followup patch adding command line options

This adds the --marcflavor and --zebralang commandline options, as
well as short versions of all options.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6540 - Make ZEBRA_MARC_FORMAT and ZEBRA_LANGUAGE configurable for koha-create
Magnus Enger [Sat, 16 Jul 2011 18:58:34 +0000 (20:58 +0200)]
Bug 6540 - Make ZEBRA_MARC_FORMAT and ZEBRA_LANGUAGE configurable for koha-create

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6350: History update
Chris Cormack [Thu, 28 Jul 2011 02:12:21 +0000 (14:12 +1200)]
Bug 6350: History update

8 years agoBug 4873 - Ensure that the required directories exist on init
John Seymour [Fri, 22 Jul 2011 03:08:40 +0000 (15:08 +1200)]
Bug 4873 - Ensure that the required directories exist on init

As systems (Ubuntu already, Debian testing is doing it too) move to
ramdisking /var/run and /var/lock, or otherwise clearing them on boot,
we need to ensure that they're there when we need them. This patch
autocreates any directories that are missing when the init script runs.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years ago[SIGNED-OFF} Fix for Bug 6623 - Nicer style for "clear screen" button
Owen Leonard [Thu, 21 Jul 2011 15:16:08 +0000 (11:16 -0400)]
[SIGNED-OFF} Fix for Bug 6623 - Nicer style for "clear screen" button

This patch replaces the <button> element with an "X" link
styled to appear fixed to the upper right corner of the box
containing the barcode input field. A title attribute
shows "Clear screen" on hover.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6547: Add id attributes to messages in opac-reserve.tt
Ian Walls [Fri, 22 Jul 2011 12:08:20 +0000 (08:08 -0400)]
Bug 6547: Add id attributes to messages in opac-reserve.tt

In order to allow easier styling with JQuery, including text substitution,
this patch adds id attributes to each div tag containing a holds message.
The following ids are added, corresponding to the template variables of the
same names:

too_much_oweing
too_many_reserves
bad_biblionumber
no_items_selected
no_branch_selected
no_biblionumber
bad_data
none_available

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6632 [Signed Off] add html filter to prevent XSS
Frère Sébastien Marie [Wed, 27 Jul 2011 19:04:11 +0000 (14:04 -0500)]
Bug 6632 [Signed Off] add html filter to prevent XSS

The filter 'html' have been added on all occurences of shelvename, which come from user input.

http://bugs.koha-community.org/show_bug.cgi?id=6632

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6614: Remove newlines from order notes when exporting to CSV
Ian Walls [Tue, 26 Jul 2011 18:22:53 +0000 (14:22 -0400)]
Bug 6614: Remove newlines from order notes when exporting to CSV

Newline is not a valid character to Text::CSV's combine() subroutine.  If an order
contained a note with a newline in it, that line would come out as a blank entry in
the exported CSV.  This patch strips such characters, globally.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>