wip/koha-chris_n.git
9 years agoMerge remote-tracking branch 'kc/new/bug_5449' into kcmaster
Chris Cormack [Sun, 8 May 2011 20:25:36 +0000 (08:25 +1200)]
Merge remote-tracking branch 'kc/new/bug_5449' into kcmaster

9 years agoBug 6294: {BIBLIONUMBER} parsing for SearchForTitleIn
Ian Walls [Tue, 3 May 2011 15:37:46 +0000 (11:37 -0400)]
Bug 6294: {BIBLIONUMBER} parsing for SearchForTitleIn

Adds support for parsing of the biblionumber into the SearchForTitleIn system preference, allowing
external sites with APIs (like Facebook or Twitter) to do link-backs to the details page for the
title.

Sample code for implementing Facebook "like" links and Twitter "tweet this" are included on the bug report

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6031 : Fix for syntax (bashism crept into a pure sh script)
Chris Cormack [Mon, 2 May 2011 00:39:35 +0000 (12:39 +1200)]
Bug 6031 : Fix for syntax (bashism crept into a pure sh script)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6282: HomeOrHoldingBranchReturn missing from pref file
Colin Campbell [Thu, 28 Apr 2011 15:47:07 +0000 (16:47 +0100)]
Bug 6282: HomeOrHoldingBranchReturn missing from pref file

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFixing a template error
Chris Cormack [Thu, 28 Apr 2011 23:39:18 +0000 (11:39 +1200)]
Fixing a template error

9 years agoRewriting the valid templates test to test template toolkit
Chris Cormack [Thu, 28 Apr 2011 23:33:19 +0000 (11:33 +1200)]
Rewriting the valid templates test to test template toolkit

9 years agoMerge remote branch 'kc/new/enh/bug_6033' into kcmaster
Chris Cormack [Thu, 28 Apr 2011 21:34:58 +0000 (09:34 +1200)]
Merge remote branch 'kc/new/enh/bug_6033' into kcmaster

9 years agoBug 6033 : Follow up fix for bug that crept in with conversion to template toolkit
Chris Cormack [Thu, 28 Apr 2011 21:33:35 +0000 (09:33 +1200)]
Bug 6033 : Follow up fix for bug that crept in with conversion to template toolkit

9 years agoBug 6265: Authority search in OPAC not exact
Katrin Fischer [Mon, 25 Apr 2011 19:55:40 +0000 (21:55 +0200)]
Bug 6265: Authority search in OPAC not exact

The search for linked records from the full heading page was not exact.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6001 : batchRebuildBiblioTables.pl doesn't crash anymore when GetMarcBiblio fails...
Matthias Meusburger [Thu, 1 Apr 2010 14:07:25 +0000 (16:07 +0200)]
Bug 6001 : batchRebuildBiblioTables.pl doesn't crash anymore when GetMarcBiblio fails. Unprocessed biblionumbers are displayed at the end of the execution instead.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_6143' into kcmaster
Chris Cormack [Thu, 28 Apr 2011 20:55:19 +0000 (08:55 +1200)]
Merge remote branch 'kc/new/enh/bug_6143' into kcmaster

9 years agoFollow Up for Bug 6143: New numSearchRSSResults preferences
Nicole C. Engard [Thu, 28 Apr 2011 16:31:06 +0000 (12:31 -0400)]
Follow Up for Bug 6143: New numSearchRSSResults preferences

This patch updates the language in the pref file to match the format
used in other areas of the preferences by making the preference value
part of a sentence.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5509 - use an XML parser to get values from config
Robin Sheat [Thu, 16 Dec 2010 05:05:43 +0000 (18:05 +1300)]
Bug 5509 - use an XML parser to get values from config

Using sed and regex was causing issues when LDAP connection details were
added.

See
http://stackoverflow.com/questions/1732348/regex-match-open-tags-except-xhtml-self-contained-tags/1732454#1732454
for more information.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6033 : Template changes
Chris Cormack [Wed, 27 Apr 2011 23:26:42 +0000 (11:26 +1200)]
Bug 6033 : Template changes

9 years agoBug 6033 : wr77488 : report selection filter
Srdjan Jankovic [Wed, 6 Apr 2011 02:56:45 +0000 (14:56 +1200)]
Bug 6033 : wr77488 : report selection filter

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 3543: split NLM call numbers in label creator
Jared Camins-Esakov [Wed, 13 Apr 2011 14:03:03 +0000 (10:03 -0400)]
Bug 3543: split NLM call numbers in label creator

Split NLM call numbers using the same rules as those used for Library of
Congress call numbers.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6259: AllowHoldPolicyOverride causes every hold to need override
Ian Walls [Mon, 25 Apr 2011 22:30:22 +0000 (18:30 -0400)]
Bug 6259: AllowHoldPolicyOverride causes every hold to need override

Adds a check to make sure that the item is actually unavailable before requiring the override

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5445: Nicer breadcrumbs when ordering from different sources
Katrin Fischer [Mon, 25 Apr 2011 22:27:34 +0000 (18:27 -0400)]
Bug 5445: Nicer breadcrumbs when ordering from different sources

Replaces previous patch. Also fixes ordering from existing records.

While it was possible to go back to vendor and basket page when ordering
from a new suggestion the other odering options missed those 'crumbs'.

This patch makes the breadcrumbs for all orderings options consistent and
makes it possible to navigate back to the vendor or basket from all
pages.

- from existing record
- from staged record
- from external source
- from empty record

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6143 : Fixing missing sysprefs
Chris Cormack [Tue, 26 Apr 2011 10:28:09 +0000 (22:28 +1200)]
Bug 6143 : Fixing missing sysprefs

9 years agoBumping the database number
Chris Cormack [Tue, 26 Apr 2011 08:51:37 +0000 (20:51 +1200)]
Bumping the database number

9 years agoBug #6143 - New feature: capability to limit the RSS results
Stéphane Delaune [Mon, 11 Apr 2011 12:04:36 +0000 (14:04 +0200)]
Bug #6143 - New feature: capability to limit the RSS results

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 3202: creating new 'child' categorytype patrons doesn't set branch properly
Ian Walls [Thu, 21 Apr 2011 04:46:34 +0000 (00:46 -0400)]
Bug 3202: creating new 'child' categorytype patrons doesn't set branch properly

If a guarantor search is not being performed, the creation of any Child category_type patron will
not default to the currently logged in branch, but rather the first branch alphabetically.

Adding a test for the existence of any guarantor branch data before assigning it clears up this problem

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6153: Display imprint subfields in order
Jared Camins-Esakov [Sun, 10 Apr 2011 21:32:26 +0000 (17:32 -0400)]
Bug 6153: Display imprint subfields in order

Prior to this patch, the imprint (field 260) was displayed out-of-order on the
MARC21 XSLT record detail page. For example, the following data:
=260  \\$aNew York :$bHarper,$c2003$g(2005 printing)
Displayed as:
Harper, New York : 2003 (2005 printing)
Instead of:
New York : Harper, 2003 (2005 printing)

Even more problematically, the following data:
=260  \\$a[S.l. :$bs.n.],$c1860.
Displayed as:
s.n.], [S.l. : 1860
Instead of:
[S.l. : s.n.], 1860.

This patch changes the MARC21 OPAC Details display to display the imprint
subfields in the proper order (as the Results display already does).

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6194 Suppress punctuation when no location
Colin Campbell [Mon, 18 Apr 2011 03:35:21 +0000 (23:35 -0400)]
Bug 6194 Suppress punctuation when no location

Template was showing empty parentheses when no location
data was present. Punctuation should be dependent on
the variable being set

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6257: Fix broken MARC documentation links
Katrin Fischer [Sun, 24 Apr 2011 15:58:45 +0000 (17:58 +0200)]
Bug 6257: Fix broken MARC documentation links

Another TT issue.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6263: shelf browser broken in 3.4
Katrin Fischer [Mon, 25 Apr 2011 16:35:28 +0000 (12:35 -0400)]
Bug 6263: shelf browser broken in 3.4

Another problem with TT.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMove nb-NO-i-staff-prog-v-3002000.po -> nb-NO-i-staff-t-prog-v-3002000.po
Magnus Enger [Mon, 25 Apr 2011 09:34:04 +0000 (11:34 +0200)]
Move nb-NO-i-staff-prog-v-3002000.po -> nb-NO-i-staff-t-prog-v-3002000.po

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6228: Show active currency in system preferences
Katrin Fischer [Mon, 25 Apr 2011 09:25:13 +0000 (11:25 +0200)]
Bug 6228: Show active currency in system preferences

Some system preferences like maxoutstanding should show the
active currency behind the value. The code for this was not
translated to Template Toolkit.

Will change strings, so probably for 3.4.1

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 2941 Transfers cannot be canceled once initiated
Owen Leonard [Fri, 22 Apr 2011 20:57:38 +0000 (16:57 -0400)]
Fix for Bug 2941 Transfers cannot be canceled once initiated

This patch includes the changes by Catalyst found at
http://git.catalyst.net.nz/gw?p=koha.git;a=shortlog;h=refs/heads/bug_2941
and adds a "cancel transfer" link to the transferstoreceive
script, including a redirect check to send the user back to
that report.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agohistory.txt updates for April 2011 releases
Galen Charlton [Fri, 22 Apr 2011 14:23:05 +0000 (10:23 -0400)]
history.txt updates for April 2011 releases

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoAdd missing library to release notes
Nicole C. Engard [Fri, 22 Apr 2011 14:20:08 +0000 (10:20 -0400)]
Add missing library to release notes

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoUpdate ALL Koha translation files
Frédéric Demians [Fri, 22 Apr 2011 08:37:54 +0000 (10:37 +0200)]
Update ALL Koha translation files

9 years agotextual improvements to release notes
Galen Charlton [Fri, 22 Apr 2011 02:42:42 +0000 (22:42 -0400)]
textual improvements to release notes

* typo and usage improvements
* alphabetize sponsoring libraries

Thanks to Brendan Gallagher for suggestions.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBumping version number for release
Chris Cormack [Fri, 22 Apr 2011 01:27:37 +0000 (13:27 +1200)]
Bumping version number for release

9 years agoFixing typo in the release notes
Chris Cormack [Thu, 21 Apr 2011 23:31:44 +0000 (11:31 +1200)]
Fixing typo in the release notes

9 years agoBug 6251: Acq: receiving orders
Katrin Fischer [Thu, 21 Apr 2011 22:48:19 +0000 (00:48 +0200)]
Bug 6251: Acq: receiving orders

- numbered pagination links are broken, previous and next work
- link to order line missing supplier id

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6250: Link to order in uncertain prices list broken
Katrin Fischer [Thu, 21 Apr 2011 22:06:08 +0000 (00:06 +0200)]
Bug 6250: Link to order in uncertain prices list broken

Missing URL parameter.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6249: Can't order accepted suggestions
Katrin Fischer [Thu, 21 Apr 2011 21:55:56 +0000 (23:55 +0200)]
Bug 6249: Can't order accepted suggestions

Order link was missing URL parameters.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6248: Acq: order from staged marc file broken
Katrin Fischer [Thu, 21 Apr 2011 21:10:26 +0000 (23:10 +0200)]
Bug 6248: Acq: order from staged marc file broken

Corrects missing parameters in urls for
- single order from staged marc file
- bulk order from staged marc file

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6247: Acq: order already existing record broken
Katrin Fischer [Thu, 21 Apr 2011 20:44:16 +0000 (22:44 +0200)]
Bug 6247: Acq: order already existing record broken

Another URL missing parameters.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6246: Modify/Delete links were missing from basket lines
Katrin Fischer [Thu, 21 Apr 2011 20:26:22 +0000 (22:26 +0200)]
Bug 6246: Modify/Delete links were missing from basket lines

Another TT problem.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6245: Can't order from z39.50 search in acq
Katrin Fischer [Thu, 21 Apr 2011 20:08:39 +0000 (22:08 +0200)]
Bug 6245: Can't order from z39.50 search in acq

Fixing missing url parameters in z39.50 search in acquisitions.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 6244, Javascript error on circulation home page
Owen Leonard [Thu, 21 Apr 2011 19:11:48 +0000 (15:11 -0400)]
Fix for Bug 6244, Javascript error on circulation home page

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6240 : pass a hash to template not a scalar
Colin Campbell [Thu, 21 Apr 2011 19:32:34 +0000 (20:32 +0100)]
Bug 6240 : pass a hash to template not a scalar

As subscription info was passed as a scalar hashref
template could not access any of the data contained therein
esp Bib and Vendor ids

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFollow-up fix for Bug 6168, Can't delete holds from circulation page
Owen Leonard [Wed, 20 Apr 2011 17:12:13 +0000 (13:12 -0400)]
Follow-up fix for Bug 6168, Can't delete holds from circulation page

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6236 : When checking for expiry don't try to process 0 dates
Colin Campbell [Wed, 20 Apr 2011 16:45:38 +0000 (12:45 -0400)]
Bug 6236 : When checking for expiry don't try to process 0 dates

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6237: remove compile time warning
Colin Campbell [Thu, 21 Apr 2011 15:13:47 +0000 (16:13 +0100)]
Bug 6237: remove compile time warning

Remove a 'variable in void context' warning from
C4::Auth which shows up as a compile warning in all users of
the module and generates log noise

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6237: Remove redeclarations of global vars in same scope
Colin Campbell [Thu, 21 Apr 2011 15:13:46 +0000 (16:13 +0100)]
Bug 6237: Remove redeclarations of global vars in same scope

Scripts should be able to compile without warnings as a minimal test
a couple of variables are redeclared in the same scope generating
warnings. Remove the redeclations

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6232: Impossible to link authorities to bibliographic records
Katrin Fischer [Wed, 20 Apr 2011 02:35:55 +0000 (04:35 +0200)]
Bug 6232: Impossible to link authorities to bibliographic records

Another fix for TT.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6231: some system preferences in XSLT broken
Katrin Fischer [Thu, 21 Apr 2011 14:31:02 +0000 (10:31 -0400)]
Bug 6231: some system preferences in XSLT broken

URL was accidently changed to url, breaking the case sensitive system preference
variables in XSLT.

- URLLinkText
- OPACurlOpenInNewWindow
- OPACBaseURL

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 6238 - Checkboxes in staff's list view are missing
Owen Leonard [Wed, 20 Apr 2011 17:41:34 +0000 (13:41 -0400)]
Fix for Bug 6238 - Checkboxes in staff's list view are missing

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6234: Fixing missing biblionumber for links using biblio-default-view.inc
Katrin Fischer [Thu, 21 Apr 2011 18:36:11 +0000 (14:36 -0400)]
Bug 6234: Fixing missing biblionumber for links using biblio-default-view.inc

Fixes various pages where the biblionumber was missing in links to the detail page of a record.
Should also fix 6241.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I made the changes Owen suggested
- added the class="ratiolimit" back
- fixed additional link in waitingreserve.tt
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 6239, Merging records broken
Owen Leonard [Wed, 20 Apr 2011 19:11:40 +0000 (15:11 -0400)]
Fix for Bug 6239, Merging records broken

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for bug 6243 - Link to fast cataloging missing from circulation home page
Owen Leonard [Wed, 20 Apr 2011 19:23:02 +0000 (15:23 -0400)]
Fix for bug 6243 - Link to fast cataloging missing from circulation home page

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6230: Search to hold links on titles in result list were missing
Katrin Fischer [Wed, 20 Apr 2011 00:18:09 +0000 (02:18 +0200)]
Bug 6230: Search to hold links on titles in result list were missing

Another TT fix.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6229: Message preferences on patron details tab broken
Katrin Fischer [Tue, 19 Apr 2011 23:48:39 +0000 (01:48 +0200)]
Bug 6229: Message preferences on patron details tab broken

TT scoping problems fixed.

Table now greyed out on the details tab and last column 'Don't notify'
shows correctly.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6224 : Revert "3.0.x: ce353e7 bug #3674 allow users creation with disabled password"
Chris Cormack [Thu, 21 Apr 2011 02:45:37 +0000 (14:45 +1200)]
Bug 6224 : Revert "3.0.x: ce353e7 bug #3674 allow users creation with disabled password"

This reverts commit 87b792b2b61c8232c2facecf6feb2ce5f3fa2b9e.

9 years agobug 6227: tweak release notes
Galen Charlton [Wed, 20 Apr 2011 22:37:08 +0000 (18:37 -0400)]
bug 6227: tweak release notes

NoZebra is deprecated

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 6227: adjust description of NoZebra syspref
Galen Charlton [Wed, 20 Apr 2011 22:37:07 +0000 (18:37 -0400)]
bug 6227: adjust description of NoZebra syspref

NoZebra mode is deprecated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 6227: remove search engine question from installer
Galen Charlton [Wed, 20 Apr 2011 22:37:06 +0000 (18:37 -0400)]
bug 6227: remove search engine question from installer

NoZebra mode is deprecated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoUpdating updatedatabase.pl to try to stop duplicate upgrades being run
Chris Cormack [Thu, 21 Apr 2011 01:36:58 +0000 (13:36 +1200)]
Updating updatedatabase.pl to try to stop duplicate upgrades being run
for people coming from 3.2.x

9 years agoUpdating upgrade instructions
Chris Cormack [Thu, 21 Apr 2011 00:53:00 +0000 (12:53 +1200)]
Updating upgrade instructions

9 years agoMerge branch 'new/enh/bug_5579' into kcmaster
Chris Cormack [Wed, 20 Apr 2011 23:48:11 +0000 (11:48 +1200)]
Merge branch 'new/enh/bug_5579' into kcmaster

Conflicts:
C4/Biblio.pm

9 years agoBug 6215 : Fixing a bug with virtuallists
Chris Cormack [Wed, 20 Apr 2011 23:37:44 +0000 (11:37 +1200)]
Bug 6215 : Fixing a bug with virtuallists

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5579: tweaks to bulkmarcimport.pl
Galen Charlton [Wed, 20 Apr 2011 21:34:47 +0000 (17:34 -0400)]
bug 5579: tweaks to bulkmarcimport.pl

Fixes bug where a bib record imported by bulkmarcimport.pl
could become unindexable by ensuring that ModBiblioMarc()
is always called by bulkmarcimport.pl to finalize saving the
bib record (as it was initially created by AddBiblio with the
defer_marc_save option).

Also introduces a utility routine, C4::Biblio::_strip_item_fields.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5579: remove a now-unecessary vestigal variable
Galen Charlton [Wed, 20 Apr 2011 21:34:46 +0000 (17:34 -0400)]
bug 5579: remove a now-unecessary vestigal variable

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5579: add line removed during patch review
Galen Charlton [Wed, 20 Apr 2011 21:34:45 +0000 (17:34 -0400)]
bug 5579: add line removed during patch review

Had effect of breaking item record changes when the
CatalogingLog system preference is on.

(Note to people reviewing patches - please do not modify the content
 of patches that you are signing off on unless you are *sure* you
 know *exactly* what you doing.  The process of patch review should
 not be introducing yet more bugs.)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6212 : Fix for tags label showing with no tags
Chris Cormack [Wed, 20 Apr 2011 21:39:38 +0000 (09:39 +1200)]
Bug 6212 : Fix for tags label showing with no tags

9 years agoFix for Bug 6213, Koha News template error
Owen Leonard [Wed, 20 Apr 2011 13:01:45 +0000 (09:01 -0400)]
Fix for Bug 6213, Koha News template error

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 6216, Search results pagination links broken
Owen Leonard [Wed, 20 Apr 2011 14:09:59 +0000 (10:09 -0400)]
Fix for Bug 6216, Search results pagination links broken

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 6221, Modifying patron doesn't show "Patron Account Flags" group
Owen Leonard [Wed, 20 Apr 2011 06:59:11 +0000 (02:59 -0400)]
Fix for Bug 6221, Modifying patron doesn't show "Patron Account Flags" group

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6211: Set default correctly for SubscriptionHistory syspref
Colin Campbell [Wed, 20 Apr 2011 02:16:13 +0000 (22:16 -0400)]
Bug 6211: Set default correctly for SubscriptionHistory syspref

Was being set to an invalid value ';'
resulting in weird behaviour where it looked set but was not
in practice

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_5917' into kcmaster
Chris Cormack [Wed, 20 Apr 2011 08:44:36 +0000 (20:44 +1200)]
Merge remote branch 'kc/new/enh/bug_5917' into kcmaster

9 years agoBug 5917 : Testing fixing utf8 for preferences po file
Chris Cormack [Wed, 20 Apr 2011 08:42:05 +0000 (20:42 +1200)]
Bug 5917 : Testing fixing utf8 for preferences po file

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFixing bug in the french sys pref file, duplicate sys prefs plus l'OPAC not l\'OPAC
Chris Cormack [Wed, 20 Apr 2011 04:44:04 +0000 (16:44 +1200)]
Fixing bug in the french sys pref file, duplicate sys prefs plus l'OPAC not l\'OPAC

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_5897' into kcmaster
Chris Cormack [Wed, 20 Apr 2011 04:19:44 +0000 (16:19 +1200)]
Merge remote branch 'kc/new/enh/bug_5897' into kcmaster

9 years agoFollow-up fix for Bug 5897 - Hide name of comment writer in OPAC
Owen Leonard [Wed, 20 Apr 2011 00:48:33 +0000 (20:48 -0400)]
Follow-up fix for Bug 5897 - Hide name of comment writer in OPAC

Correcting 'recent comments' view to obey ShowReviewer pref

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_5917' into kcmaster
Chris Cormack [Wed, 20 Apr 2011 04:12:53 +0000 (16:12 +1200)]
Merge remote branch 'kc/new/enh/bug_5917' into kcmaster

9 years agoBug 5917 : Fixes for innerhtml -> innerHTML
Chris Cormack [Wed, 20 Apr 2011 04:02:24 +0000 (16:02 +1200)]
Bug 5917 : Fixes for innerhtml -> innerHTML

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6184 : Plugin for 007 broken
Chris Cormack [Wed, 20 Apr 2011 03:49:07 +0000 (15:49 +1200)]
Bug 6184 : Plugin for 007 broken

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6202 : Fix for showing subscription details
Chris Cormack [Wed, 20 Apr 2011 03:28:44 +0000 (15:28 +1200)]
Bug 6202 : Fix for showing subscription details

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6208 : Cant add funds to a budget
Chris Cormack [Wed, 20 Apr 2011 02:33:29 +0000 (14:33 +1200)]
Bug 6208 : Cant add funds to a budget

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6203 : Fix for numbering pattern not showing
Chris Cormack [Wed, 20 Apr 2011 02:02:31 +0000 (14:02 +1200)]
Bug 6203 : Fix for numbering pattern not showing

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5791 - Robust handling of deleted/non-existent biblios and authority records
Tomas Cohen Arazi [Mon, 18 Apr 2011 20:59:32 +0000 (16:59 -0400)]
Bug 5791 - Robust handling of deleted/non-existent biblios and authority records

Patch reworked for master using Template::Toolkit.

To+

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5671 Links on My Summary - followup patch
Magnus Enger [Mon, 18 Apr 2011 20:16:17 +0000 (16:16 -0400)]
Bug 5671 Links on My Summary - followup patch

- OPACMySummaryhtml and MySummaryhtml should have HTML at the end
- MySummaryHTML is different for each issue, so it needs to be
  ISSUE.MySummaryHTML, not MySummaryhtml

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/master' into new/enh/bug_5579
Chris Cormack [Tue, 19 Apr 2011 18:44:09 +0000 (06:44 +1200)]
Merge remote branch 'kc/master' into new/enh/bug_5579

9 years agoBug 6207 : Template scoping error
Chris Cormack [Tue, 19 Apr 2011 18:41:58 +0000 (06:41 +1200)]
Bug 6207 : Template scoping error

9 years agoAdding another sponsoring library to the credits in the release notes
Chris Cormack [Tue, 19 Apr 2011 18:31:21 +0000 (06:31 +1200)]
Adding another sponsoring library to the credits in the release notes

9 years agobug 5579 : Fixes ISBD display
Matthias Meusburger [Thu, 7 Apr 2011 14:08:11 +0000 (16:08 +0200)]
bug 5579 : Fixes ISBD display

Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5579 : Fixes several exports to embed items
Matthias Meusburger [Thu, 7 Apr 2011 10:04:43 +0000 (12:04 +0200)]
bug 5579 : Fixes several exports to embed items

  - The following export pages used to embed items when exporting,
    this was no longer the case, so they were fixed :
      Intranet :
        - basket/downloadcart.pl,
        - virtualshelves/downloadshelf.pl
        - catalogue/export.pl
      Opac :
        - opac/opac-downloadcart.pl
        - opac/opac-downloadshelf.pl
        - opac/opac-export.pl

  - Notes :
     - GetMarcBiblio used to embed items data, this was no longer the case,
       so an optional parameter was added to choose if items should be embedded or not.
       This way, previous work on this bug is not broken, and this is a pretty usefull
       feature, imho.
     - An optional parameter has been added to SetUTF8Flag, to be able to use NFD during
       normalization. This was required to make Unicode/UTF-8 export work again.

Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5579: teach MARC export to embed items when needed
Galen Charlton [Sun, 3 Apr 2011 02:19:39 +0000 (22:19 -0400)]
bug 5579: teach MARC export to embed items when needed

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5579: remove unused routines
Galen Charlton [Sun, 3 Apr 2011 01:22:02 +0000 (21:22 -0400)]
bug 5579: remove unused routines

Remove the following routines which used to
handle embedding item data in the bibliographic record:

C4::Items::_replace_item_field_in_biblio
C4::Items::_add_item_field_to_biblio

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5579: remove sync_items_in_marc_bib.pl
Galen Charlton [Sun, 3 Apr 2011 00:48:40 +0000 (20:48 -0400)]
bug 5579: remove sync_items_in_marc_bib.pl

Now that item data is inserted into the MARC bib record
at the point of indexing, sync_items_in_marc_bib.pl is
no longer needed.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5579: reduce processing to log item changes
Galen Charlton [Fri, 4 Mar 2011 00:09:35 +0000 (19:09 -0500)]
bug 5579: reduce processing to log item changes

* no need to record full bib MARC when logging
  change to an item record
* IDEA: set up a separate ItemLog syspref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5579: new routine to embed items in bib
Galen Charlton [Thu, 3 Mar 2011 23:41:42 +0000 (18:41 -0500)]
bug 5579: new routine to embed items in bib

Adds a new routine, C4::Biblio::EmbedItemsInMarcBiblio, to
embed the items in the bib record when necessary:

* cataloging/additem.pl
* rebuild_zebra.pl

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5579: correctly signal when to reindex bibs
Galen Charlton [Thu, 3 Mar 2011 23:29:32 +0000 (18:29 -0500)]
bug 5579: correctly signal when to reindex bibs

* when item changes
* when new item is added

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5579: fix moving items from bib to another
Galen Charlton [Thu, 3 Mar 2011 23:24:19 +0000 (18:24 -0500)]
bug 5579: fix moving items from bib to another

* Must signal both bibs to be reindexed

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5579: improvements to remove_items_from_biblioitems.pl
Galen Charlton [Sun, 3 Apr 2011 01:09:59 +0000 (21:09 -0400)]
bug 5579: improvements to remove_items_from_biblioitems.pl

* add copyright statement
* make --run switch work; this is now required to cause
  the update to run
* improve help text
* make remove_items_from_biblioitems.pl executable

Signed-off-by: Galen Charlton <gmcharlt@esilibrary.com>
Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5579: remove items from MARC bib
Henri-Damien LAURENT [Fri, 3 Sep 2010 10:16:52 +0000 (12:16 +0200)]
Bug 5579: remove items from MARC bib

This is a squash of four patches by Henri-Damien Laurent
starting work on removing the copy of item record information
in the 9XX field of bibliographic records.  The reason
for doing this is primarily to improve performance, in particular,
the expense of having to add/modify the bib record whenever an
item changes.  Now, whenever an item changes, the bib record is
put in the queue to be reindexed; when the bib is indexed, the 9XX
fields are inserted into the version of the bib that Zebra indexes.
Since rebuild_zebra.pl runs in a separate process, the processing of the
bib record will not delay (e.g.) circulation.

As part of upgrading to 3.4, the following batch script should be run:

misc/maintenance/remove_items_from_biblioitems.pl --run

This should be followed by a complete reindexing of the bib records, e.g.,

misc/migration_tools/rebuild_zebra.pl -b -r

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6205 : Fix for the installer, falling back to english
Chris Cormack [Tue, 19 Apr 2011 10:05:53 +0000 (22:05 +1200)]
Bug 6205 : Fix for the installer, falling back to english