wip/koha-chris_n.git
12 years agoSMS - widespread cleanup and moving code away from Cyprus/Turkey-specific implementat...
Joe Atzberger [Sun, 3 Feb 2008 19:10:20 +0000 (13:10 -0600)]
SMS - widespread cleanup and moving code away from Cyprus/Turkey-specific implementation. Much more needed.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMakefile.PL - trivial perldoc correction
Joe Atzberger [Sun, 3 Feb 2008 19:10:19 +0000 (13:10 -0600)]
Makefile.PL - trivial perldoc correction

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFixes bug #1808
Frederic DEMIANS [Sat, 2 Feb 2008 05:23:57 +0000 (23:23 -0600)]
Fixes bug #1808

  OPAC:   $8 - Koha collection, decoded with ccode authorised
          values
  Staff:  $c - Shelving location

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agotemplates - HTML validation tweaks, FIXME's added
Joe Atzberger [Sat, 2 Feb 2008 05:23:56 +0000 (23:23 -0600)]
templates - HTML validation tweaks, FIXME's added

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoContext.pm - file size test (-s) is subset of file exists test (-e), so testing both...
Joe Atzberger [Sat, 2 Feb 2008 05:23:55 +0000 (23:23 -0600)]
Context.pm - file size test (-s) is subset of file exists test (-e), so testing both is same as testing -s.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agomasthead.inc - several validation fixes (no div inside <a>, unpaired closing tags)
Joe Atzberger [Sat, 2 Feb 2008 05:23:54 +0000 (23:23 -0600)]
masthead.inc - several validation fixes (no div inside <a>, unpaired closing tags)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoopac.css - button background fix for input.icon
Joe Atzberger [Sat, 2 Feb 2008 05:23:53 +0000 (23:23 -0600)]
opac.css - button background fix for input.icon

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoshelves - corrections and HTML validation changes
Joe Atzberger [Sat, 2 Feb 2008 05:23:52 +0000 (23:23 -0600)]
shelves - corrections and HTML validation changes

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agocharset: fixed bug that prevented ISO-5426 conversion
Galen Charlton [Sat, 2 Feb 2008 05:23:51 +0000 (23:23 -0600)]
charset: fixed bug that prevented ISO-5426 conversion

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoModified viewlog.pl to discern where it was called from and display the appropriate...
Chris Nighswonger [Sat, 2 Feb 2008 05:23:50 +0000 (23:23 -0600)]
Modified viewlog.pl to discern where it was called from and display the appropriate menu.

If viewlog.pl is called from the circulation menu, then the circulation menu is displayed.
If viewlog.pl is called otherwise, the tools menu is displayed.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdd MARC21 to USMARC label
MJ Ray [Sat, 2 Feb 2008 05:23:49 +0000 (23:23 -0600)]
Add MARC21 to USMARC label

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMore fixes for patron images
Chris Nighswonger [Sat, 2 Feb 2008 05:23:48 +0000 (23:23 -0600)]
More fixes for patron images

Added GetPatronImage function to Members.pm
Added code to circulation.pl, boraccount.pl, readingrec.pl, and moremember.pl to grab patron image and pass it off to the template
Corrected code in circ-menu.inc to properly display patron image.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMore work on picture-upload.tmpl
Chris Nighswonger [Sat, 2 Feb 2008 05:23:47 +0000 (23:23 -0600)]
More work on picture-upload.tmpl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug Fixing : Could not add new undefined tag if searchfield>0
Henri-Damien LAURENT [Sat, 2 Feb 2008 05:23:46 +0000 (23:23 -0600)]
Bug Fixing : Could not add new undefined tag if searchfield>0

For instance, search for tag 290
cannot find.
Click on addTag
Save
Then wouldnot add tag 290 because used UPDATE.
Now, if tag is not found then Add tag is done.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSecond installment on Patron Images fixes
Chris Nighswonger [Sat, 2 Feb 2008 05:23:45 +0000 (23:23 -0600)]
Second installment on Patron Images fixes

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agotemp bugfix -- restore file upload functionality
Galen Charlton [Fri, 1 Feb 2008 00:27:05 +0000 (18:27 -0600)]
temp bugfix -- restore file upload functionality

CGI->new() should not be used in any C4 module -
it has a side-effect that breaks the AJAX
file upload script.  Specifically, any file upload
field is slurped when a new CGI object is created, and
is not available to a second object created by CGI->new().

Consequently, C4::Debug should not be instantiating
a CGI object in its BEGIN block.  It can use other CGI::* modules
to parse QUERY_STRING to get the value of the debug
parameter (note that this means that the debug param
can be reliably set only in a GET, not as part of a
form submission).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoIMPORTANT - refactor MARC character set handling
Galen Charlton [Fri, 1 Feb 2008 00:27:04 +0000 (18:27 -0600)]
IMPORTANT - refactor MARC character set handling

* IsStringUTF8ish - determine if scalar contains a string in UTF8
* MarcToUTF8Record - convert MARC blob or MARC::Record to UTF8
* SetMarcUnicodeFlag - set appropriate MARC21 or UNIMARC field to
  indicate that record is in UTF-8.

Design points of this module include:

* No dependencies on other C4 modules, making it easier to add
  more test cases
* All character conversion code in one place
* Single entry point for doing a character conversion on a
  MARC record
* Capture of errors and warnings produced by Text::Iconv
  and MARC::Charset
* Start of support for guessing the source character set of
  a MARC record.

Several functions were moved from other scripts
or modules to C4::Charset:

* C4::Koha->FixEncoding (expanded and renamed
  MarcToUTF8Record)
* C4::Koha->char_decode5426
* fMARC8ToUTF8 from bulkmarcimport.pl (renamed
  _marc_marc8_to_utf8)

Several batch jobs were adjusted to use MarcToUTF8Record instead of
FixEncoding.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMarkup correction, formatting for translator
Owen Leonard [Fri, 1 Feb 2008 00:27:03 +0000 (18:27 -0600)]
Markup correction, formatting for translator

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrecting DEBUG var
Chris Nighswonger [Fri, 1 Feb 2008 00:27:02 +0000 (18:27 -0600)]
Correcting DEBUG var

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBugfix for Bug 1618: First Installment
Chris [Fri, 1 Feb 2008 00:27:01 +0000 (18:27 -0600)]
Bugfix for Bug 1618: First Installment

This corrects the major template issues once files are uploaded.
The changes need dressing up a bit still.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRemoving extra warn
Chris [Fri, 1 Feb 2008 00:27:00 +0000 (18:27 -0600)]
Removing extra warn

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoQuick fix to bug 1809
Frederic DEMIANS [Thu, 31 Jan 2008 19:43:25 +0000 (13:43 -0600)]
Quick fix to bug 1809

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix a bug in authorised values admin
Frederic DEMIANS [Thu, 31 Jan 2008 19:43:24 +0000 (13:43 -0600)]
Fix a bug in authorised values admin

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoPrevious change hid global search on results page too, fixing.
Owen Leonard [Thu, 31 Jan 2008 19:43:23 +0000 (13:43 -0600)]
Previous change hid global search on results page too, fixing.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRemoving some unused include files; Correcting nomenclature for cart; hiding quick...
Owen Leonard [Thu, 31 Jan 2008 19:43:22 +0000 (13:43 -0600)]
Removing some unused include files; Correcting nomenclature for cart; hiding quick search form on advanced search page; Styling user menu links as sidebar tabs.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMinor style tweak to lists menu; Trying to show public lists to non-logged-in users...
Owen Leonard [Thu, 31 Jan 2008 19:43:21 +0000 (13:43 -0600)]
Minor style tweak to lists menu; Trying to show public lists to non-logged-in users. Calling for help from atz.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMarkup tweak for login; Link correction for facets.
Owen Leonard [Thu, 31 Jan 2008 19:43:20 +0000 (13:43 -0600)]
Markup tweak for login; Link correction for facets.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofrench translation updated
Paul POULAIN [Thu, 31 Jan 2008 19:43:19 +0000 (13:43 -0600)]
french translation updated

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agostaged MARC import: handle non-ASCII characters in items
Galen Charlton [Thu, 31 Jan 2008 19:43:17 +0000 (13:43 -0600)]
staged MARC import: handle non-ASCII characters in items

The problem occured during the population of
import_items.marcxml -- the MARC::Record object
created to store the item did not have the Leader/09
set to 'a', which means that MARC::File::XML
tried to transcode code the item from MARC-8 to UTF-8, which
breaks since the MARC data is already in UTF-8 at that point.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoauthorities: changed extension of authority-zebra-indexdefs.xml
Galen Charlton [Thu, 31 Jan 2008 19:43:16 +0000 (13:43 -0600)]
authorities: changed extension of authority-zebra-indexdefs.xml

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoauthorities: start of work on reindexing
Galen Charlton [Thu, 31 Jan 2008 19:43:15 +0000 (13:43 -0600)]
authorities: start of work on reindexing

Currently, MARC authorities are indexed (assuming Zebra
is used) with Zebra's GRS-1 module.  However, it does
not appear to be possible to index phrases that cross
subfield boundaries using the GRS-1 module's records.abs
config file's melm, elm, and xelm directives.

Since it is necessary to be able to efficiently search
an entire authority heading (e.g., to see if a given
bib heading is authorized), I'm proposing a switch
to Zebra's DOM XML filter module, which uses XSLT
to generate the words and phrases to be indexed from the
original MARC XML (or ISO2709) record.

The file authority-zebra-indexdefs.xml is an XSLT stylesheet
to implement the new indexing regime.  It is based on the
MARC21 authority record.abs with the following changes:

  * addition of 148/448/548
  * changed name of "see" indexes to "see-from"
  * changed name of "see-also" indexes to "see-also-from"
  * added index on the subject thesaurus based on
    the 008/11 and 040$f
  * added indexes on the full heading

authority-zebra-indexdefs.xml was generated from
authority-koha-indexdefs.xml via the XSL transform
koha-indexdefs-to-zebra.xsl.  authority-koha-indexdefs.xml
is the actual master version of the indexing definitions,
and was created to provide a much more compact syntax
over the raw XSLT that is to be passed to Zebra.

An experimental schema for Koha indexing definitions is
under way; my aim is to propose a simple format that can
be readily worked with, and perhaps even generated as
a serialization of indexing definitions that are set up
via administration settings in the Koha database itself.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoWorking version of cart and lists buttons, with some style changes to cart and lists...
Owen Leonard [Wed, 30 Jan 2008 07:20:55 +0000 (01:20 -0600)]
Working version of cart and lists buttons, with some style changes to cart and lists popups. Bug: cart contents indicator conflicts with button-style js. Also adding new default button style.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMore button tweaks
Owen Leonard [Wed, 30 Jan 2008 07:20:54 +0000 (01:20 -0600)]
More button tweaks

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMore unfinished button style testing
Owen Leonard [Wed, 30 Jan 2008 07:20:53 +0000 (01:20 -0600)]
More unfinished button style testing

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMore button style tests
Owen Leonard [Wed, 30 Jan 2008 07:20:52 +0000 (01:20 -0600)]
More button style tests

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBugfix for Bug 1790 - Correcting sysprefs opacthemes explanation to reflect current...
Chris [Tue, 29 Jan 2008 20:31:06 +0000 (14:31 -0600)]
Bugfix for Bug 1790 - Correcting sysprefs opacthemes explanation to reflect current functionality

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix for bug #1806
Frederic DEMIANS [Tue, 29 Jan 2008 18:37:21 +0000 (12:37 -0600)]
Fix for bug #1806

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBugfix for Bug 1790: Theme defaults to prog if other themes fail.
Chris [Tue, 29 Jan 2008 18:37:20 +0000 (12:37 -0600)]
Bugfix for Bug 1790: Theme defaults to prog if other themes fail.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoA couple of minor style tweaks.
Owen Leonard [Tue, 29 Jan 2008 06:13:39 +0000 (00:13 -0600)]
A couple of minor style tweaks.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoChanging the way items are added to the cart and and lists from the searchresults...
Owen Leonard [Tue, 29 Jan 2008 06:13:38 +0000 (00:13 -0600)]
Changing the way items are added to the cart and and lists from the searchresults page: Users now check items and choose from an 'add to...' dropdown which is populated with the logged-in user's lists. The add-to-shelf popup has been modified to accept a shelfnumber so that a users can add straight to the selected list.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMaking the images show at admin/itemtype.spl
Chris Cormack [Mon, 28 Jan 2008 19:06:03 +0000 (13:06 -0600)]
Making the images show at admin/itemtype.spl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoOPAC bug fix: use correct index to limit by format
Galen Charlton [Mon, 28 Jan 2008 19:06:02 +0000 (13:06 -0600)]
OPAC bug fix: use correct index to limit by format

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobug fixing : encoding with texts in opac-sendbasket.pl
Henri-Damien LAURENT [Mon, 28 Jan 2008 19:06:01 +0000 (13:06 -0600)]
bug fixing : encoding with texts in opac-sendbasket.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoremove hardcoded link to opacsmallimage
Ryan Higgins [Sun, 27 Jan 2008 21:00:06 +0000 (15:00 -0600)]
remove hardcoded link to opacsmallimage

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFixes for cart functionality, including additions to update cart toolip window
Owen Leonard [Sun, 27 Jan 2008 19:17:33 +0000 (13:17 -0600)]
Fixes for cart functionality, including additions to update cart toolip window

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFixing "check all" function in search results; Using javascript to generate book...
Owen Leonard [Sun, 27 Jan 2008 19:17:32 +0000 (13:17 -0600)]
Fixing "check all" function in search results; Using javascript to generate book bag and list buttons, since those functions depend on javascript being enabled.Also adding help.css, missing from yesterday's help file commits.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBugfix to correct C4:Koha behavior which caused admin/itemtypes.pl to try to
Chris Cormack [Sun, 27 Jan 2008 19:17:31 +0000 (13:17 -0600)]
Bugfix to correct C4:Koha behavior which caused admin/itemtypes.pl to try to

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix for bug in updatedatabase (extra comma) (fixed by Chris Nighswonger)
Chris Cormack [Sun, 27 Jan 2008 19:17:30 +0000 (13:17 -0600)]
Fix for bug in updatedatabase (extra comma) (fixed by Chris Nighswonger)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agominor db update changes for 2.2->3.0 script
Ryan Higgins [Sun, 27 Jan 2008 19:17:29 +0000 (13:17 -0600)]
minor db update changes for 2.2->3.0 script

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agosyspref update to update22to30 script
Ryan Higgins [Sun, 27 Jan 2008 19:17:28 +0000 (13:17 -0600)]
syspref update to update22to30 script

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding manual datedue for renewals on moremember pages.
Henri-Damien LAURENT [Fri, 25 Jan 2008 21:04:31 +0000 (15:04 -0600)]
Adding manual datedue for renewals on moremember pages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoDisplaying functions for UNIMARC authors instead of function code
Henri-Damien LAURENT [Fri, 25 Jan 2008 21:04:30 +0000 (15:04 -0600)]
Displaying functions for UNIMARC authors instead of function code

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding OpacHighlightedWords system preference
Henri-Damien LAURENT [Fri, 25 Jan 2008 21:04:29 +0000 (15:04 -0600)]
Adding OpacHighlightedWords system preference

Disable or Enable the display of query terms in the biblio.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoButton styling in masthead.inc is still conflicting with the js load() functions...
Owen Leonard [Fri, 25 Jan 2008 21:04:28 +0000 (15:04 -0600)]
Button styling in masthead.inc is still conflicting with the js load() functions and the menu popup, so buttons are unstyled at the moment. Still need to integrate cart (basket/bookbag) functions.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMore incremental changes to the OPAC masthead
Owen Leonard [Fri, 25 Jan 2008 21:04:27 +0000 (15:04 -0600)]
More incremental changes to the OPAC masthead

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUpdating yui/button.css to latest version, adding back in changes that eliminate...
Owen Leonard [Fri, 25 Jan 2008 21:04:26 +0000 (15:04 -0600)]
Updating yui/button.css to latest version, adding back in changes that eliminate the "body class="yui-skin-sam"" requirement

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoStyling facets; correcting markup error in search results; removing language picker...
Owen Leonard [Fri, 25 Jan 2008 21:04:25 +0000 (15:04 -0600)]
Styling facets; correcting markup error in search results; removing language picker from opac-main (is now in the footer); continuing unfinished work on cart/lists buttons

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoEnabling replacement of Koha logo with another image via opacsmallimage system pref...
Owen Leonard [Fri, 25 Jan 2008 21:04:24 +0000 (15:04 -0600)]
Enabling replacement of Koha logo with another image via opacsmallimage system pref; Adding some YUI files required by menus and popups

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoWorking on the language-picker menu in the footer
Owen Leonard [Fri, 25 Jan 2008 21:04:23 +0000 (15:04 -0600)]
Working on the language-picker menu in the footer

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUnfinished: enabling language chooser in footer
Owen Leonard [Fri, 25 Jan 2008 21:04:22 +0000 (15:04 -0600)]
Unfinished: enabling language chooser in footer

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUnstable changes to cart/list button interface in the OPAC
Owen Leonard [Fri, 25 Jan 2008 21:04:21 +0000 (15:04 -0600)]
Unstable changes to cart/list button interface in the OPAC

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoExperimenting with styles for OPAC cart and lists button. Unfinished.
Owen Leonard [Fri, 25 Jan 2008 21:04:20 +0000 (15:04 -0600)]
Experimenting with styles for OPAC cart and lists button. Unfinished.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBeginning some design changes to the OPAC: put login info at the top, move cart and...
Owen Leonard [Fri, 25 Jan 2008 21:04:19 +0000 (15:04 -0600)]
Beginning some design changes to the OPAC: put login info at the top, move cart and list buttons alongside main search form. Putting alternate search methods below the search form. These changes will eliminate the left-hand column from most OPAC screens.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoPartial fix for Bug 1578: detect material type and don't load COinS unless the materi...
Joshua Ferraro [Thu, 24 Jan 2008 14:02:51 +0000 (09:02 -0500)]
Partial fix for Bug 1578: detect material type and don't load COinS unless the material type is known.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoretab, 4 chars, spaces
Joshua Ferraro [Thu, 24 Jan 2008 13:25:01 +0000 (08:25 -0500)]
retab, 4 chars, spaces

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agocleanup of opac-search.pl, synch with search.pl, etc.
Joshua Ferraro [Wed, 23 Jan 2008 13:20:34 +0000 (08:20 -0500)]
cleanup of opac-search.pl, synch with search.pl, etc.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agomapping recordIdentifier to Koha internal ID
Joshua Ferraro [Wed, 23 Jan 2008 13:20:12 +0000 (08:20 -0500)]
mapping recordIdentifier to Koha internal ID

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBackend for "Session" Shelves in toolbar. Affects Auth and Context, so please test.
Joe Atzberger [Thu, 24 Jan 2008 03:16:18 +0000 (21:16 -0600)]
Backend for "Session" Shelves in toolbar. Affects Auth and Context, so please test.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAuth.pm - Clarify logout conditionals, debug messages. Die on failure of get_session...
Joe Atzberger [Thu, 24 Jan 2008 03:16:17 +0000 (21:16 -0600)]
Auth.pm - Clarify logout conditionals, debug messages. Die on failure of get_session("").

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoholidays.tmpl - format cleanup, CSS-ification, English corrections
Joe Atzberger [Thu, 24 Jan 2008 03:16:16 +0000 (21:16 -0600)]
holidays.tmpl - format cleanup, CSS-ification, English corrections

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAuth.pm - _session_log calls moved before undef of vars logged, LibraryName double...
Joe Atzberger [Thu, 24 Jan 2008 03:16:15 +0000 (21:16 -0600)]
Auth.pm - _session_log calls moved before undef of vars logged, LibraryName double => removed

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRemoving replace statement as per bug 1546
Chris Cormack [Wed, 23 Jan 2008 22:37:27 +0000 (16:37 -0600)]
Removing replace statement as per bug 1546

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTidying up formatting
Chris Cormack [Wed, 23 Jan 2008 21:55:48 +0000 (15:55 -0600)]
Tidying up formatting

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix for bug 1790 Thanks to Chris Nighswonger
Chris Cormack [Wed, 23 Jan 2008 21:55:47 +0000 (15:55 -0600)]
Fix for bug 1790 Thanks to Chris Nighswonger

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix for bug 1791
Chris Cormack [Wed, 23 Jan 2008 21:04:24 +0000 (15:04 -0600)]
Fix for bug 1791

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug Fixing : Encoding in Z3950 searches
Henri-Damien LAURENT [Wed, 23 Jan 2008 21:04:23 +0000 (15:04 -0600)]
Bug Fixing : Encoding in Z3950 searches

encoding is now defaulted to MARC8
encoding is now supported for USMARC and UNIMARC flavours.
Adding Encoding field to updatedatabase.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix for bug 1772, thanks for the bug report Arona
Chris Cormack [Wed, 23 Jan 2008 01:40:20 +0000 (19:40 -0600)]
Fix for bug 1772, thanks for the bug report Arona

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobasket.pl - bugfix 1714, GST pre-inclusion checked. FIXME's added.
Joe Atzberger [Wed, 23 Jan 2008 00:22:48 +0000 (18:22 -0600)]
basket.pl - bugfix 1714, GST pre-inclusion checked. FIXME's added.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoHelp for tools-home.pl added by Brooke
Chris Cormack [Tue, 22 Jan 2008 23:16:59 +0000 (17:16 -0600)]
Help for tools-home.pl added by Brooke

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix for bug 1560
Chris Cormack [Tue, 22 Jan 2008 22:31:17 +0000 (16:31 -0600)]
Fix for bug 1560

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix bug #1789 part 1
Frederic DEMIANS [Tue, 22 Jan 2008 21:50:53 +0000 (15:50 -0600)]
Fix bug #1789 part 1

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrecting path to linked css and js
Owen Leonard [Tue, 22 Jan 2008 21:50:52 +0000 (15:50 -0600)]
Correcting path to linked css and js

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoOne more search button correction
Owen Leonard [Tue, 22 Jan 2008 21:50:51 +0000 (15:50 -0600)]
One more search button correction

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTweaking display of search button in resident search form to address an issue describ...
Owen Leonard [Tue, 22 Jan 2008 21:50:50 +0000 (15:50 -0600)]
Tweaking display of search button in resident search form to address an issue described in Bug 1780.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding noItemTypeImages syspref to Auth.pm; Beginning the process of adding support...
Owen Leonard [Tue, 22 Jan 2008 21:50:49 +0000 (15:50 -0600)]
Adding noItemTypeImages syspref to Auth.pm; Beginning the process of adding support for noItemTypeImages preference to intranet templtes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug, using branchcode instead of branch
Chris Cormack [Tue, 22 Jan 2008 21:49:04 +0000 (15:49 -0600)]
Bug, using branchcode instead of branch

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix for bug 1784,
Chris Cormack [Tue, 22 Jan 2008 21:47:18 +0000 (15:47 -0600)]
Fix for bug 1784,

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoC4::Debug - Centralized debug switches module, test and proof conversion (in Dates.pm)
Joe Atzberger [Tue, 22 Jan 2008 19:43:03 +0000 (13:43 -0600)]
C4::Debug - Centralized debug switches module, test and proof conversion (in Dates.pm)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoDisplaying mobile or phonepro if no phone number.
Henri-Damien LAURENT [Tue, 22 Jan 2008 19:43:02 +0000 (13:43 -0600)]
Displaying mobile or phonepro if no phone number.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding back the HomeorHoldingBranch syspref ... Dont Delete this is used by
Chris Cormack [Tue, 22 Jan 2008 19:40:21 +0000 (13:40 -0600)]
Adding back the HomeorHoldingBranch syspref ... Dont Delete this is used by

Circulation

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoShifting HomeOrHoldingBranch to the circulation tab
Chris Cormack [Mon, 21 Jan 2008 20:37:31 +0000 (14:37 -0600)]
Shifting HomeOrHoldingBranch to the circulation tab

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofixed permissions for updateitem
Galen Charlton [Mon, 21 Jan 2008 20:20:46 +0000 (14:20 -0600)]
fixed permissions for updateitem

Per new bug 1783, it would be nice if editcatalogue would
work as well, but a change to the public API of C4::Auth
is needed for that to work.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agomore items work; handle unlinked subfields (DB rev => 048)
Galen Charlton [Mon, 21 Jan 2008 20:14:42 +0000 (14:14 -0600)]
more items work; handle unlinked subfields (DB rev => 048)

As a consequence, the items table now remains authoritative
for all item information: any subfields not explicitly mapped
in the framework are still stored.

In addition, the additional unlinked subfields are now retained
during a call to ModItem.

Two additional points of note:

* an upgrade script from 2.2 and earlier 3.0 instllations is needed
  to populate items.marc_subfields_xml; I am working on this.
* A behavour of bulkmarcimport.pl has now changed; any item subfields
  not explicitly mapped to a Koha items field were dropped; they are
  now retained and are stored in items.more_subfields_xml.  This can
  affect data migrations.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadded caching of results of GetMarcStructure
Galen Charlton [Mon, 21 Jan 2008 20:14:41 +0000 (14:14 -0600)]
added caching of results of GetMarcStructure

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoC4::Items -- removed two warns
Galen Charlton [Mon, 21 Jan 2008 20:14:40 +0000 (14:14 -0600)]
C4::Items -- removed two warns

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoeditorial changes to C4/Items.pm
Galen Charlton [Mon, 21 Jan 2008 20:14:39 +0000 (14:14 -0600)]
editorial changes to C4/Items.pm

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoprevent AddItem death if no marcrecord is given.
Henri-Damien LAURENT [Mon, 21 Jan 2008 20:14:38 +0000 (14:14 -0600)]
prevent AddItem death if no marcrecord is given.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoImportant Commit For UNIMARC Items.
Henri-Damien LAURENT [Mon, 21 Jan 2008 20:14:37 +0000 (14:14 -0600)]
Important Commit For UNIMARC Items.

Nonetheless, you are right to consider items table as the reference.
We need one, and we agree on this principle.

What is done with this commit is :
- adding support for marc subfields not linked to items table.

+ removing some $dbh parameters in some function signature.
I think this is rel2_2 style programming and may be avoided using C4::Context->dbh.
Or there is a reason using dbh parameter that you know and not me.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobulkauthimport fix
Daniel BÃ\83¼nzli [Mon, 21 Jan 2008 14:54:05 +0000 (08:54 -0600)]
bulkauthimport fix

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agocorrectly caluclate default template path for OPAC
Paul POULAIN [Mon, 21 Jan 2008 09:16:03 +0000 (03:16 -0600)]
correctly caluclate default template path for OPAC

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>