wip/koha-chris_n.git
10 years agoUpdating INSTALL documents
Chris Nighswonger [Thu, 20 May 2010 01:35:53 +0000 (21:35 -0400)]
Updating INSTALL documents

This provides the following updates to the INSTALL documents:

- Links updated to reflect currently available community resources at their new locations
- Removes depreciated zebraqueue instructions
- Adds notes regarding the proper usage of rebuild_zebra.pl

NOTE: Remaining links will be updated as these resources are moved over and available

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4464: properly check if a subfield is populated if it is in a textarea
Galen Charlton [Fri, 21 May 2010 17:00:58 +0000 (13:00 -0400)]
bug 4464: properly check if a subfield is populated if it is in a textarea

Subfields whose contents are longer than 100 characters are represented on the
bib form using a <textarea> instead of a text <input>.  The check on whether
at least one subfield for a mandatory field is populated wasn't not
checking for <textarea> subfields.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 2889: Adds highlighting to serials-collection.tmpl
Garry Collum [Sat, 22 May 2010 17:41:52 +0000 (13:41 -0400)]
Bug 2889: Adds highlighting to serials-collection.tmpl

Also fixes inconsistencies in the capitalization in the headings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3910: Removes an erroneous heading from the serials search results.
Garry Collum [Sat, 22 May 2010 14:50:31 +0000 (10:50 -0400)]
Bug 3910: Removes an erroneous heading from the serials search results.

Removes the 'Search for Serial Routing' heading from the serials search result screen.

There is no code in the template that performs a routing search, and links to the routing tables are provided in the serials search results.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4505: updated release notes
Galen Charlton [Mon, 24 May 2010 11:51:19 +0000 (07:51 -0400)]
bug 4505: updated release notes

Minimum version of Perl required to run Koha is
now 5.8.8.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4505 - Bumping the perl version to 5.8.8 or greater
Chris Cormack [Sat, 22 May 2010 08:15:59 +0000 (20:15 +1200)]
Bug 4505 - Bumping the perl version to 5.8.8 or greater

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4802 - fix swapped files in acq help
Nicole Engard [Fri, 21 May 2010 10:48:36 +0000 (06:48 -0400)]
bug 4802 - fix swapped files in acq help

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4802 add missing order search help file
Nicole Engard [Fri, 21 May 2010 10:16:04 +0000 (06:16 -0400)]
bug 4802 add missing order search help file

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4801: fix paging in display of staged bibs and import batches
Galen Charlton [Fri, 21 May 2010 13:34:42 +0000 (09:34 -0400)]
bug 4801: fix paging in display of staged bibs and import batches

Fixed glitch where the first page of bibs in a batch (or the first
page of import batches) was displaying the entire list instead
of the correct number of records per page.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4802 add new acq help files
Nicole Engard [Fri, 21 May 2010 09:24:30 +0000 (05:24 -0400)]
bug 4802 add new acq help files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoupdate main page help file
Nicole Engard [Fri, 21 May 2010 09:08:31 +0000 (05:08 -0400)]
update main page help file

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofix XHTML error in bib details print page
Galen Charlton [Wed, 19 May 2010 15:38:56 +0000 (11:38 -0400)]
fix XHTML error in bib details print page

"&nbsp;" is not subtitutable for a table row

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(bug #4519) fix record printing
Nahuel ANGELINETTI [Mon, 17 May 2010 14:18:51 +0000 (16:18 +0200)]
(bug #4519) fix record printing

this add a js that print a record

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4525: Invalid XHTML in currency.tmpl.
Garry Collum [Tue, 18 May 2010 19:51:54 +0000 (15:51 -0400)]
Bug 4525: Invalid XHTML in currency.tmpl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4151: fix migration_tools typo
Galen Charlton [Mon, 17 May 2010 14:50:07 +0000 (10:50 -0400)]
bug 4151: fix migration_tools typo

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4516 (Character shift in MARC21 Field 008)
Marcel de Rooy [Mon, 17 May 2010 12:17:59 +0000 (14:17 +0200)]
Bug 4516 (Character shift in MARC21 Field 008)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBacking down the required version of Graphics::Magick
Chris Nighswonger [Mon, 17 May 2010 14:23:47 +0000 (10:23 -0400)]
Backing down the required version of Graphics::Magick

This brings the required version into line with the latest version available in the Debian and Ubuntu repos.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoEnhancement Bug 4444: Centralize Code Handling Perl Dependencies
Chris Nighswonger [Sat, 15 May 2010 22:13:13 +0000 (18:13 -0400)]
Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

Porting about.pl over to use C4::Installer::PerlModules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoEnhancement Bug 4444: Centralize Code Handling Perl Dependencies
Chris Nighswonger [Sat, 15 May 2010 22:13:14 +0000 (18:13 -0400)]
Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

Porting install.pl over to use C4::Installer::PerlModules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoEnhancement Bug 4444: Centralize Code Handling Perl Dependencies
Chris Nighswonger [Sat, 15 May 2010 22:13:15 +0000 (18:13 -0400)]
Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

This patch adds a script to allow checking the status of Koha's Perl dependencies from the
command line interface at any time. Run '$ ./koha_perl_deps.pl --help' for available options.
'$ ./koha_perl_deps.pl -c' is recommended if you like color.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoEnhancement Bug 4444: Centralize Code Handling Perl Dependencies
Chris Nighswonger [Sat, 15 May 2010 22:13:12 +0000 (18:13 -0400)]
Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

Porting Makefile.PL over to use C4::Installer::PerlModules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoEnhancement Bug 4444: Centralize Code Handling Perl Dependencies
Chris Nighswonger [Sat, 15 May 2010 22:13:11 +0000 (18:13 -0400)]
Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

This patch adds two modules: C4::Installer::PerlModule and C4::Installer::PerlDependencies. The latter provides a single point
of reference for cataloging Koha Perl dependencies. The former provides an OO style interface to the dependency catalog.

The format of C4::Installer::PerlDependencies is very simply an anonymous hash of hashes. Each second level hash takes this form:

'Foo::Bar' => {
  'usage'    => 'FooBar Feature',
  'required' => '1', # 0 if optional
  'min_ver'  => '0.01',
},

New modules can be appended to C4::Installer::PerlDependencies as needed and will be picked up by every piece of code which needs
this information.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4509: remove references to PINESISBN system preference
Galen Charlton [Fri, 14 May 2010 20:10:52 +0000 (16:10 -0400)]
bug 4509: remove references to PINESISBN system preference

This system preference never worked; also, as far as I can tell,
the PINES oISBN service was experimental, not meant for production
use, and is not currently advertised.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4507 Don't return null vendor to claims processing
Colin Campbell [Fri, 14 May 2010 16:24:13 +0000 (17:24 +0100)]
Bug 4507 Don't return null vendor to claims processing

The empty vendor created by the select if any subscriptions
have no associated vendor generates a 'wrong-looking' display
and selecting it gives no options

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 2505 enable warnings in serials/reorder_members.pl
Colin Campbell [Sat, 15 May 2010 12:40:18 +0000 (13:40 +0100)]
Bug 2505 enable warnings in serials/reorder_members.pl

The only serials routine without warnings enabled was a
script with the least code to generate them
removed the numerous Module use declarations that were not
required
aligned the parameters for a more aesthetically pleasing effect

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3768 (Bibliographic Framework Test)
Marcel de Rooy [Mon, 17 May 2010 09:16:02 +0000 (11:16 +0200)]
Bug 3768 (Bibliographic Framework Test)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofix XHTML error in about.tmpl
Galen Charlton [Fri, 14 May 2010 12:40:56 +0000 (08:40 -0400)]
fix XHTML error in about.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoRevert "Bug 4450 Use more consistent error returns in C4/Creators/*"
Galen Charlton [Fri, 14 May 2010 00:20:02 +0000 (20:20 -0400)]
Revert "Bug 4450 Use more consistent error returns in C4/Creators/*"

This reverts commit 1f56a04cadc60f26b36f5599f24d0f380bc23828.

[RM note: I confirm Chris Nighswonger's testing that shows that
 the patch causes regressions, including breaking creating new
 label layouts.]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBUG 4499: Javascript error messages not translatable
Katrin Fischer [Thu, 13 May 2010 21:30:22 +0000 (23:30 +0200)]
BUG 4499: Javascript error messages not translatable

- Administration > Patron categories > New Category (category.tmpl)
- Circulation > Checkouts > Toolbar (all tabs except Check out) (members-toolbar.inc)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBUG 4499: Javascript error messages not translatable
Katrin Fischer [Fri, 23 Apr 2010 16:37:01 +0000 (18:37 +0200)]
BUG 4499: Javascript error messages not translatable

- Cataloging > New Record (addbiblio.tmpl)
- Administration > Currencies > New Currency (currency.tmpl)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4141 Reconcile 3.0.x and HEAD database updates for 3.2.0
Chris Nighswonger [Wed, 12 May 2010 12:00:50 +0000 (08:00 -0400)]
Bug 4141 Reconcile 3.0.x and HEAD database updates for 3.2.0

This is a partial fix addressing this error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 at /home/koha/koha.prod/installer/data/mysql/updatedatabase.pl line 2916., referer: http://koha-staff.foobar.org/cgi-bin/koha/installer/install.pl

If there are no records in aqbudgets the result is an empty array which causes the sql to attempt to set AUTOINCREMENT to null.

This patch is being submitted on behalf of the Mapua Community Library.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoCorrect URL for Baker & Taylor ContentCafe
J. David Bavousett [Tue, 11 May 2010 17:55:09 +0000 (13:55 -0400)]
Correct URL for Baker & Taylor ContentCafe

This patch updates the URL for image links in ContentCafe

Sponsored by Plano Independent School District, Plano, TX, USA

[RM note: the previous book cover URL was for a varient of Baker
 and Taylor's service that has to do with 'bookstore integration',
 and if I remember correctly, the main difference is that the
 book jacket image had "buy now" text.  The version supplied
 in this patch should work for normal use of ContentCafe.]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(MT3318) RSS OPAC: Adding CDATA term in title and description tags.
Paul Poulain [Wed, 12 May 2010 09:17:56 +0000 (11:17 +0200)]
(MT3318) RSS OPAC: Adding CDATA term in title and description tags.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoHousekeeping in errors scripts
Colin Campbell [Wed, 12 May 2010 11:25:41 +0000 (12:25 +0100)]
Housekeeping in errors scripts

Enable warnings - remove Bug 2505 FIXME messages
Correct FSF address in License statement
To aid code analysis tools:
Call new unambiguously with arrow syntax
use noninterpolating quotes on noninterpolating strings

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4485, System preferences page uses non-standard warning style
Owen Leonard [Tue, 11 May 2010 14:14:25 +0000 (10:14 -0400)]
Fix for Bug 4485, System preferences page uses non-standard warning style

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoA couple of CSS and markup corrections
Owen Leonard [Tue, 11 May 2010 14:10:02 +0000 (10:10 -0400)]
A couple of CSS and markup corrections

- moving inline style declaration to the default stylesheet
- correcting markup structure on advanced search screen to allow
  consistent custom styling

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4300 Display 866z summary holdings public note in OPAC
Jane Wagner [Thu, 4 Mar 2010 19:32:29 +0000 (14:32 -0500)]
Bug 4300 Display 866z summary holdings public note in OPAC

Added the 866z to the MARC21slim2OPACDetail.xsl file so that it displays
just above the 780 and 785 fields.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agostocknumber not saved properly
Paul Poulain [Fri, 26 Mar 2010 10:25:39 +0000 (11:25 +0100)]
stocknumber not saved properly

if you have a marc field, mapped to items.stocknumber, it's not saved properly in items.stocknumber

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMT2582: Fix user deletion without permission
Matthias Meusburger [Wed, 10 Mar 2010 21:26:04 +0000 (22:26 +0100)]
MT2582: Fix user deletion without permission

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agowr-70205 Rental discount not being respected
Chris Cormack [Thu, 6 May 2010 23:24:23 +0000 (11:24 +1200)]
wr-70205 Rental discount not being respected

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoDB rev 134: DisplayMultiPlaceHold syspref
Galen Charlton [Tue, 11 May 2010 11:45:28 +0000 (07:45 -0400)]
DB rev 134: DisplayMultiPlaceHold syspref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFollow up to bug3093 patch
Chris Cormack [Tue, 11 May 2010 05:13:59 +0000 (17:13 +1200)]
Follow up to bug3093 patch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3093 add syspref to turn off multiholds button
Jane Wagner [Tue, 11 May 2010 05:13:58 +0000 (17:13 +1200)]
Bug 3093 add syspref to turn off multiholds button

Having the place multiple holds button at the top of the OPAC and staff search results has caused problems for some sites with tight holds policies; this syspref allows those sites to turn off the button.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3928: Modified date should follow syspref
Colin Campbell [Tue, 11 May 2010 10:24:41 +0000 (11:24 +0100)]
Bug 3928: Modified date should follow syspref

Changed arriveddate format to follow syspref
Fixed a whitespace error

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3928: Modification of date for serials.
J. David Bavousett [Tue, 11 May 2010 08:10:58 +0000 (20:10 +1200)]
Bug 3928: Modification of date for serials.

When a serial status is changed to "Arrived" or "Claimed", the "Expected on"
date is changed to the current date.

A bit of rewriting to get it to apply on master - chris@bigballowax.co.nz

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoDisplay current selected category when editing lists.
Matthew Hunt [Sun, 9 May 2010 21:20:10 +0000 (09:20 +1200)]
Display current selected category when editing lists.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4475, AmazonLocale not used consistently
Owen Leonard [Mon, 10 May 2010 16:21:58 +0000 (12:21 -0400)]
Fix for Bug 4475, AmazonLocale not used consistently

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMarkup corrections for validity and to eliminate horizontal scrollbar
Owen Leonard [Mon, 10 May 2010 13:32:44 +0000 (09:32 -0400)]
Markup corrections for validity and to eliminate horizontal scrollbar

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4400, BIBTEX export from OPAC results in empty file
Owen Leonard [Mon, 10 May 2010 19:24:47 +0000 (15:24 -0400)]
Fix for Bug 4400, BIBTEX export from OPAC results in empty file

opac-export.pl tries to get two variables from marc2bibtex(),
but it only returns one.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4470 Patron search result pagination bar
Frédéric Demians [Sat, 8 May 2010 06:27:51 +0000 (08:27 +0200)]
Bug 4470 Patron search result pagination bar

Obviously, Koha global pagination function could be improved. This patch
do something which belongs to this function. A CPAN module like
Data::Page could help or be an inspiration... 3.4?

There is also room for improvement in they way resultset are
constructed. The whole set is retrieved and just a subset is displayed.
It impacts performances for libraries with a great number of patrons.
The right solution would be:

  - to find the resultset size with SELECT COUNT(*)
  - to retrieved the exact subset with LIMIT and OFFSET SQL arguments

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoDo not declare variables within (bogus) conditionals
Colin Campbell [Sun, 9 May 2010 14:58:52 +0000 (15:58 +0100)]
Do not declare variables within (bogus) conditionals

if $index is unnecessary as we have made this true 5 lines above
variables should not be declared in conditionals if used outside of them
set $struct_attr to a sensible default to avoid generating warnings
in this assigment and elsewhere

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoReserve and onloan were reporting the same cardnumber, due to a little bug in detail...
Chris Cormack [Mon, 10 May 2010 04:23:17 +0000 (16:23 +1200)]
Reserve and onloan were reporting the same cardnumber, due to a little bug in detail.pl fixed by this patch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 3666, Overriding renewal limit means negative count in OPAC
Owen Leonard [Fri, 7 May 2010 17:31:37 +0000 (13:31 -0400)]
Fix for Bug 3666, Overriding renewal limit means negative count in OPAC

Setting "renewalsleft" variable to zero if it comes out negative.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix template errors introduced in my last patch for Bug 4208
Owen Leonard [Fri, 7 May 2010 19:14:57 +0000 (15:14 -0400)]
Fix template errors introduced in my last patch for Bug 4208

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3671 Workaround for font display problem
Jane Wagner [Wed, 7 Oct 2009 13:52:02 +0000 (09:52 -0400)]
Bug 3671 Workaround for font display problem

If there is no 007 field, parts of the OPAC results data display in a
much smaller font than normal.  Adding a blank space in the span section
fixes it.
(cherry picked from commit 2ff55ef2a2443933881186323f5dec3fe40842dd)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4403: look in appropriate theme/lang for bib display XSL
Galen Charlton [Sat, 8 May 2010 22:59:41 +0000 (18:59 -0400)]
bug 4403: look in appropriate theme/lang for bib display XSL

Note: approach used can be described as a hack at best; the current
language should probably become a session attribute.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofix disappearance of language chooser introduced in recent patch
Galen Charlton [Sat, 8 May 2010 22:58:36 +0000 (18:58 -0400)]
fix disappearance of language chooser introduced in recent patch

Note that xt/author/valid-templates.t did *not* catch the
missing /TMPL_IF

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoquell 'non-initialized variable defaulttab' warning
Galen Charlton [Sat, 8 May 2010 22:57:41 +0000 (18:57 -0400)]
quell 'non-initialized variable defaulttab' warning

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofix malformed call of XSLTParse4Display
Galen Charlton [Sat, 8 May 2010 22:05:23 +0000 (18:05 -0400)]
fix malformed call of XSLTParse4Display

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFurther corrections for Bug 4244, Use "checkouts" instead of "issues"
Owen Leonard [Wed, 5 May 2010 19:38:27 +0000 (15:38 -0400)]
Further corrections for Bug 4244, Use "checkouts" instead of "issues"

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoStyle changes to cart popup window more compact display: - compact holdings list...
Owen Leonard [Tue, 4 May 2010 15:24:28 +0000 (11:24 -0400)]
Style changes to cart popup window more compact display: - compact holdings list - adds list bullet image from the staff client

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(MT #2966) fix opac-user.pl function problem
Nahuel ANGELINETTI [Wed, 10 Mar 2010 21:26:30 +0000 (22:26 +0100)]
(MT #2966) fix opac-user.pl function problem

This uncomment a uselessly commented function that is needed by opac-user. And fix this function that doesn't work properly.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4450 Use more consistent error returns in C4/Creators/*
Colin Campbell [Thu, 6 May 2010 17:13:36 +0000 (13:13 -0400)]
Bug 4450 Use more consistent error returns in C4/Creators/*

A lot of routines were defaulting to return -1 in error conditions
but calling code was expecting a ref or object
use return with explicit undef (or emptyness in array context)
for these cases. Extended this to cases where return was not tested
( -1 might in some cases be legit data).

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit 5cf2b78b6ffa401bc82b3f913c89828c38b8e4ed)
[RM note: ... thereby undoing the revert]

10 years agoBug 4465 Fixes translated boolean syspref inversion
Frédéric Demians [Fri, 7 May 2010 05:37:17 +0000 (07:37 +0200)]
Bug 4465 Fixes translated boolean syspref inversion

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoanother FSF address fix
Galen Charlton [Fri, 7 May 2010 00:31:04 +0000 (20:31 -0400)]
another FSF address fix

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofix two more instances of old FSF address
Galen Charlton [Fri, 7 May 2010 00:28:29 +0000 (20:28 -0400)]
fix two more instances of old FSF address

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdding new developers to the about page, need to do libraries next
Chris Cormack [Thu, 6 May 2010 22:03:10 +0000 (10:03 +1200)]
Adding new developers to the about page, need to do libraries next

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdding a new developer plus 2 new meetings to the history doc
Chris Cormack [Thu, 6 May 2010 22:03:09 +0000 (10:03 +1200)]
Adding a new developer plus 2 new meetings to the history doc

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoexclude TinyMCE from non-UTF8 file checks
Galen Charlton [Thu, 6 May 2010 23:55:44 +0000 (19:55 -0400)]
exclude TinyMCE from non-UTF8 file checks

Since Koha otherwise had made no modifications to the TinyMCE,
we'll leave it alone.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agomove misc source file test and fix scripts to xt/
Galen Charlton [Thu, 6 May 2010 23:46:51 +0000 (19:46 -0400)]
move misc source file test and fix scripts to xt/

The license and non-UTF8 file checks are closer to
author tests and don't really belong at the top level of the
Koha source tree.  Follow-up might be to converted them
to test cases in xt/author that can be run by prove(1).

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdd script to find source files that are not in UTF-8.
Lars Wirzenius [Thu, 25 Mar 2010 22:11:05 +0000 (11:11 +1300)]
Add script to find source files that are not in UTF-8.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoConvert to UTF-8.
Lars Wirzenius [Thu, 25 Mar 2010 22:11:11 +0000 (11:11 +1300)]
Convert to UTF-8.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoConvert to UTF-8.
Lars Wirzenius [Thu, 25 Mar 2010 22:11:06 +0000 (11:11 +1300)]
Convert to UTF-8.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoConvert to UTF-8.
Lars Wirzenius [Thu, 25 Mar 2010 22:11:07 +0000 (11:11 +1300)]
Convert to UTF-8.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoConvert to UTF-8.
Lars Wirzenius [Thu, 25 Mar 2010 22:11:12 +0000 (11:11 +1300)]
Convert to UTF-8.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoConvert to UTF-8.
Lars Wirzenius [Thu, 25 Mar 2010 22:11:08 +0000 (11:11 +1300)]
Convert to UTF-8.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoRevert "Bug 4450 Use more consistent error returns in C4/Creators/*"
Galen Charlton [Thu, 6 May 2010 18:41:45 +0000 (14:41 -0400)]
Revert "Bug 4450 Use more consistent error returns in C4/Creators/*"

[Reverted per request of Chris Nighswonger - callers of the affected
 methods need to be updated.]

This reverts commit 5cf2b78b6ffa401bc82b3f913c89828c38b8e4ed.

10 years agoBug 4450 Use more consistent error returns in C4/Creators/*
Colin Campbell [Thu, 6 May 2010 17:13:36 +0000 (13:13 -0400)]
Bug 4450 Use more consistent error returns in C4/Creators/*

A lot of routines were defaulting to return -1 in error conditions
but calling code was expecting a ref or object
use return with explicit undef (or emptyness in array context)
for these cases. Extended this to cases where return was not tested
( -1 might in some cases be legit data).

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFurther fixes for Bug 4208, Many submit buttons are not translatable in 3.2
Owen Leonard [Wed, 5 May 2010 18:25:58 +0000 (14:25 -0400)]
Further fixes for Bug 4208, Many submit buttons are not translatable in 3.2

Again, not a fix for a submit button problem, but for a problem with
TMPL_IFs nested inside tags, a practice which will break the
translation script.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofixed Syndetics breakage
Galen Charlton [Wed, 5 May 2010 16:11:30 +0000 (12:11 -0400)]
fixed Syndetics breakage

Reverts part of commit 7b12e07 that removed references
to the Syndetics sysprefs in C4::Auth for no apparent reason.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFixes bug 4448: &'s in itemcallnumber
Ian Walls [Wed, 5 May 2010 15:14:54 +0000 (15:14 +0000)]
Fixes bug 4448: &'s in itemcallnumber

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4416, renew all and return all buttons too close together
Owen Leonard [Wed, 5 May 2010 14:50:38 +0000 (10:50 -0400)]
Fix for Bug 4416, renew all and return all buttons too close together

This patch removes the "return all" button altogether. Returning all items
is a step which one wouldn't take lightly or even regularly. Since the
interface has a means of selecting all checkboxes in the "Check in" column,
removing the "Return all" button wouldn't eliminate the means of doing so, it
would just require more deliberation.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4453, Improve formatting of batch item operations
Owen Leonard [Wed, 5 May 2010 14:09:40 +0000 (10:09 -0400)]
Fix for Bug 4453, Improve formatting of batch item operations

- includes fix for Bug 4443
- includes some string changes, could resubmit without if these
  changes block inclusion in 3.2

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 2375, Serials holdings data does not display in opac-detail
Owen Leonard [Wed, 5 May 2010 14:15:49 +0000 (10:15 -0400)]
Fix for Bug 2375, Serials holdings data does not display in opac-detail

- Removing markup to display serial data in the holdings table
  This functionality (if it worked) would seem to duplicate
  the data displayed under the 'Subscriptions' tab
- Revised again to merge item status display changes

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFixes bug 4452: CircControl syspref listed as ItemHomeBranch rather than ItemHomeLibrayr
Ian Walls [Wed, 5 May 2010 14:04:17 +0000 (14:04 +0000)]
Fixes bug 4452: CircControl syspref listed as ItemHomeBranch rather than ItemHomeLibrayr

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoChanges to kohastructure.sql to add some missing drop if exists + change in install...
Koustubha Kale [Fri, 19 Mar 2010 07:26:06 +0000 (12:56 +0530)]
Changes to kohastructure.sql to add some missing drop if exists + change in install.pl mysql show tables

[RM note: bug 4323]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoWeb Installer -> Step 3 --> ERROR 1050 (42S01) at line 301: Table 'branch_item_rules...
Koustubha Kale [Thu, 18 Mar 2010 16:16:02 +0000 (21:46 +0530)]
Web Installer -> Step 3 --> ERROR 1050 (42S01) at line 301: Table 'branch_item_rules' already exists

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofix template translation issues
Galen Charlton [Wed, 5 May 2010 13:27:20 +0000 (09:27 -0400)]
fix template translation issues

Alternative to Henri-Damien's patch that does not
require putting CSS style information in the Perl code.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFixed Patron Search Results
Kyle M Hall [Tue, 4 May 2010 16:33:46 +0000 (16:33 +0000)]
Fixed Patron Search Results

By default, the patron search was pulling results in *Descending* order,
then reordering the results on the page using javascript in *Ascending* order.

This was causing screwy results where the entire list of results of multiple
pages was not in complete alphabetical order.

Fixed by changing the SQL to pull in Ascending order.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoUse CSS3 box-shadow property for Cart tooltip
Owen Leonard [Thu, 25 Feb 2010 14:43:15 +0000 (09:43 -0500)]
Use CSS3 box-shadow property for Cart tooltip

The OPAC Cart tooltip ("Your cart is empty," "1 item(s) added to your
Cart") currently uses a jQuery plugin to generate a drop shadow.
This works cross-browser, but has a high failure rate with regard
to hiding the shadow consistently, resulting in an orphan shadow
after the tooltip has been hidden. I propose to instead use the
new CSS3 property "box-shadow" (-moz-box-shadow and -webkit-box-
shadow for FireFox and Safari/Chrome). Currently Internet Explorer
does not support this property. I think this is an
acceptable tradeoff for more stable functionality.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agorelease notes updates suggested by Nicole Engard
Galen Charlton [Tue, 4 May 2010 15:13:22 +0000 (11:13 -0400)]
release notes updates suggested by Nicole Engard

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agostart of release notes for 3.2
Galen Charlton [Tue, 4 May 2010 13:29:08 +0000 (09:29 -0400)]
start of release notes for 3.2

NOTE: this is not exhaustive; please send me additions for
features you have written.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofix various errors reported by xt/author/translatable-templates.t
Galen Charlton [Tue, 4 May 2010 12:36:21 +0000 (08:36 -0400)]
fix various errors reported by xt/author/translatable-templates.t

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agocopy new NPL icons from OPAC to staff
Galen Charlton [Tue, 4 May 2010 11:57:51 +0000 (07:57 -0400)]
copy new NPL icons from OPAC to staff

Fixes problem found by xt/author/icondirectories.t

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofix template structure error found by xt/author/valid-templates.t
Galen Charlton [Tue, 4 May 2010 11:50:34 +0000 (07:50 -0400)]
fix template structure error found by xt/author/valid-templates.t

Also fixed XHTML validity error

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4442 rename batch edit tools
Nicole Engard [Sat, 1 May 2010 20:38:48 +0000 (16:38 -0400)]
bug 4442 rename batch edit tools

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4151 - Add DateTime to Perl dependencies
Colin Campbell [Mon, 3 May 2010 16:33:37 +0000 (17:33 +0100)]
Bug 4151 - Add DateTime to Perl dependencies

Used in Sip.pm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4436, reserve should say 'hold'
Owen Leonard [Mon, 3 May 2010 13:58:20 +0000 (09:58 -0400)]
Fix for Bug 4436, reserve should say 'hold'

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 2889: Added zebra striping to the table in dictionary.tmpl.
Garry Collum [Tue, 13 Oct 2009 00:29:53 +0000 (20:29 -0400)]
Bug 2889: Added zebra striping to the table in dictionary.tmpl.

Also fixed a couple of minor XHTML errors.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 2889 Remove toggle in boraccount display
Colin Campbell [Fri, 26 Mar 2010 16:41:28 +0000 (16:41 +0000)]
Bug 2889 Remove toggle in boraccount display

Also remove the reverse column if no contents to be displayed
( otherwise looks like a markup error )
Rationalize the main loop now toggle not required

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>