wip/koha-chris_n.git
12 years agoRemove extraneous code. Note: this is another example of unchecked input, yet unfixed.
Joe Atzberger [Mon, 21 Apr 2008 21:22:42 +0000 (16:22 -0500)]
Remove extraneous code. Note: this is another example of unchecked input, yet unfixed.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRemove redundant zip file.
Joe Atzberger [Mon, 21 Apr 2008 21:22:41 +0000 (16:22 -0500)]
Remove redundant zip file.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCleanup code formatting for readability. No functional change.
Joe Atzberger [Mon, 21 Apr 2008 21:22:40 +0000 (16:22 -0500)]
Cleanup code formatting for readability. No functional change.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoopac-search - CORRECTION: remove diagnostic Dumper lines
Joe Atzberger [Mon, 21 Apr 2008 21:22:39 +0000 (16:22 -0500)]
opac-search - CORRECTION: remove diagnostic Dumper lines

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agostats.screen.pl - cleanup, conditionalize warns w/ Debug
Joe Atzberger [Mon, 21 Apr 2008 21:22:38 +0000 (16:22 -0500)]
stats.screen.pl - cleanup, conditionalize warns w/ Debug

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agosmart-rules.pl - tighten regexp, Debug for warn statements, readable layout.
Joe Atzberger [Mon, 21 Apr 2008 21:22:37 +0000 (16:22 -0500)]
smart-rules.pl - tighten regexp, Debug for warn statements, readable layout.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agosmart-rules.tmpl - cleanup display, remove units for zero/empty values
Joe Atzberger [Mon, 21 Apr 2008 21:22:36 +0000 (16:22 -0500)]
smart-rules.tmpl - cleanup display, remove units for zero/empty values

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoDB and syspref update for Tags and BakerTaylor
Joe Atzberger [Mon, 21 Apr 2008 21:22:35 +0000 (16:22 -0500)]
DB and syspref update for Tags and BakerTaylor

Feel free to apply this before the other related Tags/B&T patches.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTags - module, script and template support for user tagging in OPAC.
Joe Atzberger [Mon, 21 Apr 2008 21:22:34 +0000 (16:22 -0500)]
Tags - module, script and template support for user tagging in OPAC.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBaker and Taylor OPAC integration, plus some logic for Tags
Joe Atzberger [Mon, 21 Apr 2008 21:22:33 +0000 (16:22 -0500)]
Baker and Taylor OPAC integration, plus some logic for Tags

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoC4::Search - just cleanup, 1 FIXME added
Joe Atzberger [Mon, 21 Apr 2008 21:22:32 +0000 (16:22 -0500)]
C4::Search - just cleanup, 1 FIXME added

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoC4/External/BakerTaylor.pm - Back end for B&T content.
Joe Atzberger [Mon, 21 Apr 2008 21:22:31 +0000 (16:22 -0500)]
C4/External/BakerTaylor.pm - Back end for B&T content.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoopac.css - add styling for tag classes
Joe Atzberger [Mon, 21 Apr 2008 21:22:30 +0000 (16:22 -0500)]
opac.css - add styling for tag classes

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoopac-tags_subject.pl - touch up: this script is does not require Exporter.
Joe Atzberger [Mon, 21 Apr 2008 21:22:29 +0000 (16:22 -0500)]
opac-tags_subject.pl - touch up: this script is does not require Exporter.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBakerTaylor.pm - Initial implementation of B+T jacket cover and bookstore links.
Joe Atzberger [Mon, 21 Apr 2008 21:22:28 +0000 (16:22 -0500)]
BakerTaylor.pm - Initial implementation of B+T jacket cover and bookstore links.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTagging - add basic template slot in search for tags and script responsiveness to...
Joe Atzberger [Mon, 21 Apr 2008 21:22:27 +0000 (16:22 -0500)]
Tagging - add basic template slot in search for tags and script responsiveness to tagging sysprefs

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 1776 - try to locate Zebra during install
Galen Charlton [Tue, 22 Apr 2008 15:22:24 +0000 (10:22 -0500)]
kohabug 1776 - try to locate Zebra during install

If running Zebra, try to locate zebrasrv and zebraidx
so that koha-zebra-ctl.sh can point to a functioning
zebrasrv.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadded RUN_DATABASE_TESTS to install log
Galen Charlton [Tue, 22 Apr 2008 15:22:23 +0000 (10:22 -0500)]
added RUN_DATABASE_TESTS to install log

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofixing version numbering from 71 to 72
Joshua Ferraro [Tue, 22 Apr 2008 22:55:31 +0000 (17:55 -0500)]
fixing version numbering from 71 to 72

12 years agoAdd dropbox mode to return.pl. Small API change to allow setting
Ryan Higgins [Tue, 22 Apr 2008 22:46:50 +0000 (17:46 -0500)]
Add dropbox mode to return.pl. Small API change to allow setting

returndate other than now().  Overdues will be handled in a forthcoming commit.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSmall template cleanup: display library name and cat description instead of codes
Ryan Higgins [Tue, 22 Apr 2008 22:46:22 +0000 (17:46 -0500)]
Small template cleanup: display library name and cat description instead of codes

in circ-menu include.  Also, change 'Default' on main login page to 'My Library'.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoDB BUMP 71 : add formatstring to labels_conf for specifying labels content
Ryan Higgins [Tue, 22 Apr 2008 22:46:00 +0000 (17:46 -0500)]
DB BUMP 71 : add formatstring to labels_conf for specifying labels content

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoLabels update- print any marc field and add csv output.
Ryan Higgins [Tue, 22 Apr 2008 22:45:47 +0000 (17:45 -0500)]
Labels update- print any marc field and add csv output.

Make any MARC data available to labels module;
Also add a csv output option, allowing export of relevant
biblio data do a 3rd party label layout application.
Note: This patch REQUIRES a forthcoming updatedatabase patch !

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding breadcrumbs (fixes Bug 2031, "No way back home from about page")
Owen Leonard [Tue, 22 Apr 2008 15:05:36 +0000 (10:05 -0500)]
Adding breadcrumbs (fixes Bug 2031, "No way back home from about page")

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMore cleanup and corrections for circulation reports.
Owen Leonard [Tue, 22 Apr 2008 14:54:55 +0000 (09:54 -0500)]
More cleanup and corrections for circulation reports.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix for Bug 2018 ("Incorrect focus")
Owen Leonard [Tue, 22 Apr 2008 14:54:38 +0000 (09:54 -0500)]
Fix for Bug 2018 ("Incorrect focus")

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRefining some circ reports interfaces, adding table sorting.
Owen Leonard [Tue, 22 Apr 2008 14:54:17 +0000 (09:54 -0500)]
Refining some circ reports interfaces, adding table sorting.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix for Bug 2016, navigation bar in moredetail.pl not the same as in detail.pl
Owen Leonard [Tue, 22 Apr 2008 14:54:02 +0000 (09:54 -0500)]
Fix for Bug 2016, navigation bar in moredetail.pl not the same as in detail.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoLanguage corrections (partially fixes Bug 2027)
Owen Leonard [Tue, 22 Apr 2008 14:53:55 +0000 (09:53 -0500)]
Language corrections (partially fixes Bug 2027)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoLanguage corrections (mostly fixes Bug 2025)
Owen Leonard [Tue, 22 Apr 2008 14:53:48 +0000 (09:53 -0500)]
Language corrections (mostly fixes Bug 2025)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoLanguage corrections (fixes Bug 2024)
Owen Leonard [Tue, 22 Apr 2008 14:53:35 +0000 (09:53 -0500)]
Language corrections (fixes Bug 2024)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoLanguage corrections (fixes Bug 2023)
Owen Leonard [Tue, 22 Apr 2008 14:53:30 +0000 (09:53 -0500)]
Language corrections (fixes Bug 2023)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix for Bug 2015 ("subscription-renew button is disabled"), other markup corrections...
Owen Leonard [Fri, 18 Apr 2008 20:04:31 +0000 (15:04 -0500)]
Fix for Bug 2015 ("subscription-renew button is disabled"), other markup corrections; Removing unused popup css declaration from doc-head-close; removing unused popup include file.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMinor change to fix button appearance.
Owen Leonard [Fri, 18 Apr 2008 20:04:16 +0000 (15:04 -0500)]
Minor change to fix button appearance.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoShowing "OPAC (lang)" to further clarify location information. Adding calendar button...
Owen Leonard [Fri, 18 Apr 2008 20:04:05 +0000 (15:04 -0500)]
Showing "OPAC (lang)" to further clarify location information. Adding calendar button to conform with other date entry form fields.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUNIMARC specific rebuild items correctly
Paul POULAIN [Thu, 17 Apr 2008 17:53:01 +0000 (19:53 +0200)]
UNIMARC specific rebuild items correctly

note 995 for items is hardcoded, so it's really for UNIMARC only. The script exit if you're not UNIMARCflavour

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoremoving <h1> for ISBD view
Paul POULAIN [Thu, 17 Apr 2008 17:53:00 +0000 (19:53 +0200)]
removing <h1> for ISBD view

Also updating the breadcrumb (the title is not available, displaying the number)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agolook change for 2 radio buttons
Paul POULAIN [Thu, 17 Apr 2008 17:52:59 +0000 (19:52 +0200)]
look change for 2 radio buttons

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoreindenting + (very) small change in design
Paul POULAIN [Thu, 17 Apr 2008 17:52:58 +0000 (19:52 +0200)]
reindenting + (very) small change in design

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoremoving the wrong itemcallnumber link
Paul POULAIN [Thu, 17 Apr 2008 17:52:57 +0000 (19:52 +0200)]
removing the wrong itemcallnumber link

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoIMPROVEMENT : serialsadditems at subscription level (bump 071)
paul [Thu, 17 Apr 2008 17:52:56 +0000 (19:52 +0200)]
IMPROVEMENT : serialsadditems at subscription level (bump 071)

The patch update the DB by adding a row in the subscription table (serialsadditems), that is filled with the value of the syspref.
then, the syspref is deleted.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUpdating french installation
paul [Thu, 17 Apr 2008 17:52:55 +0000 (19:52 +0200)]
Updating french installation

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agotesting framework: adding more warnings about possible data loss
Andrew Moore [Tue, 22 Apr 2008 14:00:42 +0000 (09:00 -0500)]
testing framework: adding more warnings about possible data loss

I'm adding some more warnings in Makefile.PL to indicate that you WILL lose the data
in your testing database.

I've also relaxed the requirement that the teting database have "test" in its name.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agotesting framework: replacing PERL5LIB in order to more conidently find libraries
Andrew Moore [Tue, 22 Apr 2008 13:38:16 +0000 (08:38 -0500)]
testing framework: replacing PERL5LIB in order to more conidently find libraries

This patch makes the test suite work even when $PERL5LIB isn't set to the install directory.
It replaces $PERL5LIB with '..' in order to help ensure that we're loading the C4 libraries
out of the installation directory.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix obvious error in 500.pl script. Please push up immediately.
Joe Atzberger [Tue, 22 Apr 2008 06:21:10 +0000 (01:21 -0500)]
Fix obvious error in 500.pl script. Please push up immediately.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 1776 - disable mergeserver if not installing PazPar2
Galen Charlton [Mon, 21 Apr 2008 23:00:52 +0000 (18:00 -0500)]
kohabug 1776 - disable mergeserver if not installing PazPar2

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 1776 - enable daemon controls scripts for 'dev' mode
Galen Charlton [Mon, 21 Apr 2008 21:35:57 +0000 (16:35 -0500)]
kohabug 1776 - enable daemon controls scripts for 'dev' mode

The daemon control scripts (koha-zebra-ctl.sh, koha-zebraqueue-ctl.sh,
and koha-pazpar2-ctl.sh) are now copied and installed in a
runnable fashion for a 'dev'-mode install.  By default
they are installed in the bin subdirectory of the runtime
directory.

Also:

* the control scripts now work if the EUID is other
  than root (as would be expected for a 'dev' or 'single'
  install).
* Split the SCRIPT_DIR installation target into
  SCRIPT_DIR (scripts to copy regardless of install mode)
  and SCRIPT_NONDEV_DIR (scripts to copy to SCRIPT_DIR
  unless the install mode is 'dev').

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadded labels to field selection page (koha2marclinks)
Galen Charlton [Mon, 21 Apr 2008 21:35:56 +0000 (16:35 -0500)]
added labels to field selection page (koha2marclinks)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agozebra conf: add reference to password file
Galen Charlton [Mon, 21 Apr 2008 21:35:55 +0000 (16:35 -0500)]
zebra conf: add reference to password file

Note: currently only zebraqueue_daemon.pl is known
to use the extended services that require the
Zebra r/w password.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2019 - display entire subfield label
Galen Charlton [Mon, 21 Apr 2008 18:42:41 +0000 (13:42 -0500)]
kohabug 2019 - display entire subfield label

Don't truncate subfield label at 22 characters; instead
display whole label and wrap

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agotest suite - various changes
Galen Charlton [Fri, 18 Apr 2008 16:01:13 +0000 (11:01 -0500)]
test suite - various changes

* All configuration and run-time files created during
  a test suite run now live under t/run
* made sure scripts copied to t/run/bin are executable
* added t/run and t/test-config.txt to .gitignore

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agotest suite: removed dep on 'acm' user
Galen Charlton [Fri, 18 Apr 2008 16:01:12 +0000 (11:01 -0500)]
test suite: removed dep on 'acm' user

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadding database-dependent test libs.
Andrew Moore [Fri, 18 Apr 2008 15:58:31 +0000 (10:58 -0500)]
adding database-dependent test libs.

These test libs should have been included in the previous patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoimprovements to automated tests, including a testing database
Andrew Moore [Fri, 18 Apr 2008 15:58:30 +0000 (10:58 -0500)]
improvements to automated tests, including a testing database

I'm adding a bunch of additions to the test suite. There is now a test
database that is created, and a test instance of the zebra server and
daemon that are run before the tests in t/database-dependent.pl are
run. This means that you can test things that insert (or destroy)
things in the database.

To use these tests, after you 'make' your koha installation, you can
change to the 't' directory and 'make test' there.

There is now an additional question asked during installation. It asks
whether you would like to run the data-dependent tests. If so, It asks
you for some login information to a test database. I recommend that
you do not not use your production database here. It will delete all
of the data in it.

Things that need improvement:
* I suspect that there are large parts that are not very platform
  independent, so they will need to be improved.
* There are some parts of the installer that will probably be
  refactored to let this work a little bit better, including being run
  directly from a main-level 'make' target at some point.
* Lots more tests to add. Be bold! (see the t/lib directory)
* other tests in t/*.t can possibly benefit from being included in here.

There are two required perl modules for this part of the test suite. I
use:
'Test::Class' => 0.028,
'Test::Class::Load' => 0.02,
They are not listed as requirements in the top-level Makefile.PL
because they're not actually required to install or use Koha, but if
you want to run the test suite, you can install them from CPAN.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agorefactor web installer code to created C4::Installer
Galen Charlton [Fri, 18 Apr 2008 15:58:29 +0000 (10:58 -0500)]
refactor web installer code to created C4::Installer

Created a new module, C4::Installer, which embodies
most of the code from installer/install.pl that handles
identifying and loading SQL scripts and setting the
Version, marcflavour, FrameworksLoad, and NoZebra
system preferences.

With C4::Installer, it is now easier to automate
initializing and populating a Koha database.  This will
help allow the test suite to set up a test database
in order to run DB-dependent tests, as well as write
a command-line installer which may be of use to hosts
that need to support multiple Koha databases.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadded another check to MARC framework test
Galen Charlton [Fri, 18 Apr 2008 22:11:42 +0000 (17:11 -0500)]
added another check to MARC framework test

Check verifies that all subfields for each tag
are assigned to the same editor tab (or are ignored).

This situation can lead to data corruption, because
if an incoming MARC record has a field whose subfields
are assigned to different tabs, the first time that
record is saved in the bib editor, the field
will be split into multiple versions, each containing
the subfields assigned to a given tab.

Errors identified by this test known
in the MARC21 frameworks - I'm working on a patch to
correct those.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agodep change: Data::Dumper 2.121_08 => 2.121
Galen Charlton [Mon, 21 Apr 2008 13:51:10 +0000 (08:51 -0500)]
dep change: Data::Dumper 2.121_08 => 2.121

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofix crash when saving MARC21 bib with NoZebra and BiblioAddsAuthority ON
Galen Charlton [Fri, 18 Apr 2008 22:11:41 +0000 (17:11 -0500)]
fix crash when saving MARC21 bib with NoZebra and BiblioAddsAuthority ON

Needed to identify correct subfield for retrieving
the authority type.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agokohabug 2022 - fixed fine and issuing rules editors
Galen Charlton [Fri, 18 Apr 2008 18:09:19 +0000 (13:09 -0500)]
kohabug 2022 - fixed fine and issuing rules editors

Because of the way that the older fine and issuing
rule editors generate the HTML form, if a branch code,
patron category code, or item type code happened to have a
'-' or '.', the HTML form would not be parsed properly, thus
adding an implicit (rather than explicit) limit on the
characters allowed in one of those codes.

This fix removes this limitation by Base64-encoding the codes
when constructing the names for the <input> elements.

Two functions are added to C4::Koha:

  str_to_base64() - UTF-8 string to Base64
  base64_to_str() - reverse

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUpdate yuipath syspref
Frederic Demians [Fri, 18 Apr 2008 17:53:43 +0000 (19:53 +0200)]
Update yuipath syspref

If syspref points to online 2.3.1 YUI version, edit it to 2.5.1.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoXHTML correction - readonly attribute can contain only "readonly"
Galen Charlton [Fri, 18 Apr 2008 17:03:42 +0000 (12:03 -0500)]
XHTML correction - readonly attribute can contain only "readonly"

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agorebuild_zebra.pl - add -y option
Galen Charlton [Fri, 18 Apr 2008 15:53:38 +0000 (10:53 -0500)]
rebuild_zebra.pl - add -y option

rebuild_zebra.pl will now mark all zebraqueue entries
of the affected record type(s) done when run in
normal mode to index all records (as opposed to running
it with -z to just process the zebraqueue).  This prevents
any running zebraqueue_daemon processes from attempting
to reindex the same records, redundantly.

The new -y swtich overrides this new behavior; in other words, if
running rebuild_zebra.pl without -z, you can specify
-y to *not* mark zebraqueue done.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCompleteing port of changes in DrawSpineText API
Chris Nighswonger [Fri, 18 Apr 2008 11:15:18 +0000 (07:15 -0400)]
Completeing port of changes in DrawSpineText API

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding back text wrap funcionality for lines exceeding $text_wrap_cols; also adding...
Chris Nighswonger [Fri, 18 Apr 2008 11:06:23 +0000 (07:06 -0400)]
Adding back text wrap funcionality for lines exceeding $text_wrap_cols; also adding use of C4::Debug

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding trinaries to handle unpopulated itemcallnumber and/or barcode fields
Chris Nighswonger [Thu, 17 Apr 2008 14:48:18 +0000 (10:48 -0400)]
Adding trinaries to handle unpopulated itemcallnumber and/or barcode fields

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUpdate 'yuipath' syspref to accomodate YUI 2.5.1 use rather than 2.3.1
Frederic Demians [Thu, 17 Apr 2008 12:45:22 +0000 (14:45 +0200)]
Update 'yuipath' syspref to accomodate YUI 2.5.1 use rather than 2.3.1

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding missing <!-- /TMPL_IF -->
Chris Nighswonger [Thu, 17 Apr 2008 10:46:27 +0000 (06:46 -0400)]
Adding missing <!-- /TMPL_IF -->

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug Fix : Blocker 2017
Henri-Damien LAURENT [Thu, 17 Apr 2008 08:04:17 +0000 (10:04 +0200)]
Bug Fix : Blocker 2017

disabled values are not passed to CGI.
So that if you disable entry, values and subfield codes are mixed up.
I changed disabled=tru to readonly and it fixes the bug.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTweak bullmarcimport.pl
Frederic Demians [Wed, 16 Apr 2008 16:51:17 +0000 (18:51 +0200)]
Tweak bullmarcimport.pl

* Add a new parameter -o to begin importing input file after skiping
  n records.
* Enclose input file reading in an eval directive to avoid abording
  import if few records are corrupted: they are now skipped.
* Help formating.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUpdates to go with upgrade to YUI 2.5.1
Owen Leonard [Tue, 15 Apr 2008 18:49:48 +0000 (13:49 -0500)]
Updates to go with upgrade to YUI 2.5.1

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUpgrading YUI library to 2.5.1
Owen Leonard [Tue, 15 Apr 2008 18:49:37 +0000 (13:49 -0500)]
Upgrading YUI library to 2.5.1

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrection to cat-search.inc to avoid focus-stealing problem; Change to detail.tmpl...
Owen Leonard [Tue, 15 Apr 2008 18:49:29 +0000 (13:49 -0500)]
Correction to cat-search.inc to avoid focus-stealing problem; Change to detail.tmpl to play nice with moredetail.tmpl; Minor changes to search pages to allow greater flexibility with background customizations.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAccept or reject : Bug Fix and improvements.
Henri-Damien LAURENT [Tue, 15 Apr 2008 17:19:18 +0000 (19:19 +0200)]
Accept or reject : Bug Fix and improvements.

Improving workflow : A suggestion can be edited and status can be changed if mistaken as soon as it is not deleted or acquired.
Adding dates display.
Adding deletion of suggestions.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTwo fixes to speed up (a little bit) installation process
Frederic Demians [Tue, 15 Apr 2008 16:10:24 +0000 (18:10 +0200)]
Two fixes to speed up (a little bit) installation process

Add a explanation on DBD::mysql installation without test suite.
Add /misc/translator/install-code.pl script that creates templates
for specified language codes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoPorting SimpleSearch return changes to all code calling it.
Chris Nighswonger [Tue, 15 Apr 2008 12:41:56 +0000 (08:41 -0400)]
Porting SimpleSearch return changes to all code calling it.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMore work on SimpleSearch
Chris Nighswonger [Tue, 15 Apr 2008 09:24:31 +0000 (05:24 -0400)]
More work on SimpleSearch

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoEnabling SimpleSearch to return the total number of hits to caller
Chris Nighswonger [Tue, 15 Apr 2008 09:03:31 +0000 (05:03 -0400)]
Enabling SimpleSearch to return the total number of hits to caller

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadded preview MARC links to manage staged import
Galen Charlton [Mon, 14 Apr 2008 21:42:12 +0000 (16:42 -0500)]
added preview MARC links to manage staged import

In the list of bibs for an import batch, the sequence
number is now a link to a preview of the original
MARC record - uses the same JavaScript widget as the
preview for Z39.50 search results.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years ago/TMPL_ELSE is invalid, should be TMPL_ELSE
Paul POULAIN [Mon, 14 Apr 2008 16:55:54 +0000 (18:55 +0200)]
/TMPL_ELSE is invalid, should be TMPL_ELSE

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBUGFIX (blocking) : AddSubscription was bugguy
Paul POULAIN [Mon, 14 Apr 2008 16:55:53 +0000 (18:55 +0200)]
BUGFIX (blocking) : AddSubscription was bugguy

making the creation of a subscription silently fail, but modif is impossible.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBUGFIX : highlighting term fixes
Paul POULAIN [Mon, 14 Apr 2008 16:55:52 +0000 (18:55 +0200)]
BUGFIX : highlighting term fixes

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrecting code to pass total number of hits returned to the template.
Chris Nighswonger [Mon, 14 Apr 2008 12:33:08 +0000 (08:33 -0400)]
Correcting code to pass total number of hits returned to the template.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoremoving some spaces in record.abs, that make the file invalid for Zebra
Paul POULAIN [Mon, 14 Apr 2008 09:59:07 +0000 (11:59 +0200)]
removing some spaces in record.abs, that make the file invalid for Zebra

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agomy .gitignore, to avoid having files suggested to be commited.
Paul POULAIN [Mon, 14 Apr 2008 09:59:06 +0000 (11:59 +0200)]
my .gitignore, to avoid having files suggested to be commited.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBUGFIX : don't displayt "Place Hold" when RequestOnOpac is OFF
Paul POULAIN [Mon, 14 Apr 2008 09:59:05 +0000 (11:59 +0200)]
BUGFIX : don't displayt "Place Hold" when RequestOnOpac is OFF

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBUGFIX : encoding problem & security problem
Paul POULAIN [Mon, 14 Apr 2008 09:59:04 +0000 (11:59 +0200)]
BUGFIX : encoding problem & security problem

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrect bad encoding of fr-FR data loaded by web installer
Frederic Demians [Sun, 13 Apr 2008 18:23:53 +0000 (20:23 +0200)]
Correct bad encoding of fr-FR data loaded by web installer

Some informations imported into MySQL DB by web installer
were wrongly encoded. It was the case for example with
opac_news table.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadding license tab to about page
Joshua Ferraro [Mon, 14 Apr 2008 21:48:12 +0000 (17:48 -0400)]
adding license tab to about page

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoDisplays Languages selector on opac-main.pl page
Frederic Demians [Sat, 12 Apr 2008 11:32:26 +0000 (13:32 +0200)]
Displays Languages selector on opac-main.pl page

On bottom of each OPAC pages, a languages selector is displayed
(depending of syspref). But this selector wasn't available
on OPAC home page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTotal overhaul of bor_issues_top report, removal from CGI::scolling_list.
Joe Atzberger [Fri, 11 Apr 2008 23:23:45 +0000 (18:23 -0500)]
Total overhaul of bor_issues_top report, removal from CGI::scolling_list.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdd authorised values descriptions to selector for "location".
Joe Atzberger [Fri, 11 Apr 2008 16:44:24 +0000 (11:44 -0500)]
Add authorised values descriptions to selector for "location".

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobug 1953: removing possible SQL injections from C4::Acquisition::GetHistory
Andrew Moore [Fri, 11 Apr 2008 16:32:58 +0000 (11:32 -0500)]
bug 1953: removing possible SQL injections from C4::Acquisition::GetHistory

I think this is the last sub in this module that needs to be changed.
there should be no functionality or no documentation changes with this patch.
http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1953

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRemove redundant name from breadrumbs, make casing consistent in patron edit
Ryan Higgins [Fri, 11 Apr 2008 14:34:40 +0000 (09:34 -0500)]
Remove redundant name from breadrumbs, make casing consistent in patron edit

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoshow zipcode with address in patron search results list
Ryan Higgins [Fri, 11 Apr 2008 14:24:15 +0000 (09:24 -0500)]
show zipcode with address in patron search results list

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug #1855
Frederic Demians [Fri, 11 Apr 2008 13:55:30 +0000 (15:55 +0200)]
Bug #1855

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrecting class.labels_conf to be classification.labels_conf
Chris Nighswonger [Fri, 11 Apr 2008 13:32:40 +0000 (09:32 -0400)]
Correcting class.labels_conf to be classification.labels_conf

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug Fixing : Forcing USMARC format for xml
Henri-Damien LAURENT [Fri, 11 Apr 2008 13:09:59 +0000 (15:09 +0200)]
Bug Fixing : Forcing USMARC format for xml

using as_xml uses default MARC::File::XML format which is UNIMARC for marcflavour UNIMARC
And thus, causing a problem when encoding simple items marc records.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoItem-level_itypes fix, addition of ccode vector and filter.
Joe Atzberger [Fri, 11 Apr 2008 04:07:40 +0000 (23:07 -0500)]
Item-level_itypes fix, addition of ccode vector and filter.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobug 1953: removing possible SQL injections from C4::Acquisition::GetLateOrders
Andrew Moore [Thu, 10 Apr 2008 19:49:39 +0000 (14:49 -0500)]
bug 1953: removing possible SQL injections from C4::Acquisition::GetLateOrders

I decided to not make chagnes the the query that's executed on databases other than MySQL as I have no good way to test that.
This change provides no functinality change and requires no documentation change.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBUGFIX : encoding problem & security problem
Paul POULAIN [Thu, 10 Apr 2008 08:41:16 +0000 (10:41 +0200)]
BUGFIX : encoding problem & security problem

Signed-off-by: Joshua Ferraro <jmf@liblime.com>