wip/koha-chris_n.git
10 years agoNew framework for AJAX services
Pianohacker [Sun, 5 Apr 2009 22:40:13 +0000 (17:40 -0500)]
New framework for AJAX services

This adds two new C4 modules, C4::Service and ::Output::JSONStream, and
makes important modifications to C4::Output. The first two are a basic
framework for JSON-based AJAX services and a simple JSON output wrapper,
respectively. C4::Output has been slightly refactored, with a new
function, output_with_http_headers, that supports different
content-types. output_html_with_http_headers still exists, and the three
pages affected by this change have been refactored to support it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agobug 3223: add 500 and 590 to MARC21 bib Note index (Zebra)
Galen Charlton [Thu, 14 May 2009 00:37:17 +0000 (19:37 -0500)]
bug 3223: add 500 and 590 to MARC21 bib Note index (Zebra)

Note: to completely apply this change, ensure that the working
copy of record.abs is updated and rebuild the bib indexes
using rebuild_zebra.pl -b -x -r

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug 1542, fixing filter by area in reports dictionary
Chris Cormack [Thu, 14 May 2009 06:46:56 +0000 (18:46 +1200)]
Bug 1542, fixing filter by area in reports dictionary

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug 3224 : inventory tool fails on DOS newlines
Ryan Higgins [Thu, 14 May 2009 07:46:45 +0000 (00:46 -0700)]
Bug 3224 : inventory tool fails on DOS newlines

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug 1440: Show a list of holidays. Second patch.
Garry Collum [Tue, 12 May 2009 20:53:15 +0000 (16:53 -0400)]
Bug 1440: Show a list of holidays. Second patch.

Fixed XHTML error that was introduced in the first patch. Added zebra striping to the tables. Removed an erroneous line with a date experiment that had no affect on the dates.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug 3169 - Comply with new Google Book branding guidelines
Frédéric Demians [Tue, 12 May 2009 12:28:27 +0000 (14:28 +0200)]
Bug 3169 - Comply with new Google Book branding guidelines

It adds pretty huge image 'Google Preview' on google
book jacket.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug 2505 adding use warnings and fixing warnings in opac-basket.pl
Chris Cormack [Tue, 12 May 2009 10:28:19 +0000 (22:28 +1200)]
Bug 2505 adding use warnings and fixing warnings in opac-basket.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoWhoops extra } crept in when fixing a merge conflict, removing it
Chris Cormack [Tue, 12 May 2009 10:13:10 +0000 (22:13 +1200)]
Whoops extra } crept in when fixing a merge conflict, removing it

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years ago(bug #3079) show summary in opac results
Nahuel ANGELINETTI [Tue, 12 May 2009 09:09:49 +0000 (11:09 +0200)]
(bug #3079) show summary in opac results

This add the summary in opac search results

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoFixing more warnings
Chris Cormack [Tue, 12 May 2009 07:30:56 +0000 (19:30 +1200)]
Fixing more warnings

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug 1440: Show a list of holidays
Garry Collum [Tue, 12 May 2009 02:51:07 +0000 (22:51 -0400)]
Bug 1440: Show a list of holidays

This patch adds displays for holidays. A table for each type of holiday.  It could be improved by adding a link for a holiday listed in one of the tables to the edit panel.  The date formats could also be changed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug 1907 partial fix: prevent warnings on undefined params.
Chris Catalfo [Tue, 12 May 2009 00:35:13 +0000 (00:35 +0000)]
Bug 1907 partial fix: prevent warnings on undefined params.

This patch adds default blank values for a couple of params the script might receive which were producing warns in the error log. Also wraps GetMarcBiblio in an eval.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoScript to check for corruption of marcxml, and optionally to attempt fix.
Joe Atzberger [Mon, 11 May 2009 21:44:29 +0000 (16:44 -0500)]
Script to check for corruption of marcxml, and optionally to attempt fix.

When marcxml cannot be parsed into a MARC::Record object, the biblio is
undisplayable and it obviously breaks many features in Koha.  This script
can test to parse every marcxml, and alert on failures.  Optionally, the
marcxml can be replaced from the marc field.

See extensive perldoc for details.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years ago(bug #1578) change the shelf COinS support
Nahuel ANGELINETTI [Fri, 9 Jan 2009 10:36:47 +0000 (11:36 +0100)]
(bug #1578) change the shelf COinS support

this change the old COinS support, and now use C4::Biblio::GetCOinSBiblio().

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoadd subtitle to COinS for MARC21
Galen Charlton [Tue, 12 May 2009 00:03:50 +0000 (19:03 -0500)]
add subtitle to COinS for MARC21

Preserves change added in the LTFL integration
while also switching to Nahuel's COinS implementation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years ago(bug #1578) fix a little error in code
Nahuel ANGELINETTI [Mon, 9 Mar 2009 13:34:27 +0000 (14:34 +0100)]
(bug #1578) fix a little error in code

This one, fix the use of "or" instead of "||", else a warning is raised.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years ago(bug #1578) Add the (quasi)full COinS(Zotero) support
Nahuel ANGELINETTI [Thu, 8 Jan 2009 10:41:57 +0000 (11:41 +0100)]
(bug #1578) Add the (quasi)full COinS(Zotero) support

this patch do a lot of things :
 * Add the function GetCOinSBiblio in C4::Biblio, return the COinS value that must be put in a span title
   This will be usefull for OpenURL support.

 * Replace the span in opac-detail, and put the var get from GetCOinSBiblio
 * Fix an <img> tag that wasn't autoclosed
 * Add the COinS in search result
 * Full COinS support of UNIMARC, the MARC21 support should be improved to provide all kind of document types

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoPrevent fines failure on NULL borrowernumber.
Joe Atzberger [Fri, 23 Jan 2009 22:22:40 +0000 (16:22 -0600)]
Prevent fines failure on NULL borrowernumber.

The problem is that we do not ensure that the issues table has valid
borrowernumber in each line.  This is exacerbated by Getoverdues()
returning data sorted BY borrowernumber.  So one NULL borrowernumber
in issues prevented ALL fines from being assessed.  The actual error
from fines.pl cron log is:
  No branchcode argument to new.  Should be C4::Calendar->new(branchcode => $branchcode)
  at /home/user/kohaclone/misc/cronjobs/fines.pl line 98

This patch deals only with getting fines to avoid crashing.  It does
not fix the underlying data integrity problem.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoexcised hard-coded reference to HLT
Galen Charlton [Mon, 11 May 2009 21:22:04 +0000 (16:22 -0500)]
excised hard-coded reference to HLT

Note to Chris Cormack: I suspect the current ability
to override most circulation conditions is sufficient,
but if HLT still needs to establish a patron category
that can ignore issuingimpossible limitations, needs
to be done in a more flexible way.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agofix references to $session in circ/circulation.pl
Galen Charlton [Mon, 11 May 2009 21:19:20 +0000 (16:19 -0500)]
fix references to $session in circ/circulation.pl

Now that sticky due date processing uses the session,
script will always need it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoMake stickyduedate remember for session a little more permanent
Michael Hafen [Mon, 11 May 2009 20:52:35 +0000 (14:52 -0600)]
Make stickyduedate remember for session a little more permanent

Store the stickyduedate in the session.  So "Remember for Session" means
for session rather than "while on this page".

Includes some updates since initial submission of patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agofix to CanBookBeIssued()
Galen Charlton [Mon, 11 May 2009 21:10:37 +0000 (16:10 -0500)]
fix to CanBookBeIssued()

Bail out if item does not exist - otherwise
subsequent checks can fail for lack of an
item branchcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agobug 2770: add RenewalPeriodBase syspref for 3.2 (DB rev 032)
Galen Charlton [Mon, 11 May 2009 20:25:14 +0000 (15:25 -0500)]
bug 2770: add RenewalPeriodBase syspref for 3.2 (DB rev 032)

Reconciliation patch to add the RenewalPeriodBase system
preference, which per code by Nahuel Angelinetti changes
the process of calculating the due date after a renewal:

If RenewalPeriodBase is set to 'now', the due date is
set to the current date + the loan period.  This is the
current behavior.

If RenewalPeriodBase is set to 'date_due', the due date
is set to the due date before the renewal + the loan period.

Unless like the corresonding database update in the 3.0.x branch
(3.00.01.007), the default value of RenewalPeriodBase is set to
'now' so as not to unexpectedly change the calculation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agofix the previous patch to add a syspref that permit to choose the renewal period...
Nahuel Angelinetti [Fri, 6 Mar 2009 10:38:04 +0000 (11:38 +0100)]
fix the previous patch to add a syspref that permit to choose the renewal period(day or date_due).

This patch just check the syspref and use it as base date of renew.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agochange the date calc, to set the date_due to date_due+loanlength.
Nahuel Angelinetti [Fri, 6 Mar 2009 10:38:03 +0000 (11:38 +0100)]
change the date calc, to set the date_due to date_due+loanlength.

At the moment when you renew a document the date_due calculated is now+loanlength, but it's a bad thing, It should be
date_due+loanlength.
This patch do change Circulation.pm to use the date_due as renew base and add the loanlength to get the new date_due after
renewal.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug # 3048 changed Descriptions label to Title Notes
brendan [Tue, 31 Mar 2009 23:20:52 +0000 (23:20 +0000)]
Bug # 3048 changed Descriptions label to Title Notes

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agobug 988 followup - tweak wording
Galen Charlton [Mon, 11 May 2009 19:26:23 +0000 (14:26 -0500)]
bug 988 followup - tweak wording

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agofix for #988
Paul Poulain [Sat, 18 Apr 2009 20:51:41 +0000 (22:51 +0200)]
fix for #988

When a borrower can't issue any book (issuingrules=0), the message should be
"this user can't issue book" and not "too many books already issued"wrong message

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoAdd a date field in news edition, and permit to set the "timestamp" field, that is...
Nahuel Angelinetti [Fri, 6 Mar 2009 10:38:00 +0000 (11:38 +0100)]
Add a date field in news edition, and permit to set the "timestamp" field, that is the publication date and modify the GetNewsToDisplay to return only news that timestamp is < to current date that permit to publish news later without any action.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agobug 2872: fix width of columns in branch_transfer_limits (DB rev 031)
Galen Charlton [Mon, 11 May 2009 17:22:46 +0000 (12:22 -0500)]
bug 2872: fix width of columns in branch_transfer_limits (DB rev 031)

change itemtype, tobranch, and frombranch from varchar(4)
to varchar(10)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agotweak removal of whitespace from barcodes
Galen Charlton [Mon, 11 May 2009 16:39:19 +0000 (11:39 -0500)]
tweak removal of whitespace from barcodes

Per suggestion from Joe Atzberger, match on \s
instead of [ \t] for stripping leading and
trailing whitespace from barcode lookups.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agofix to remove leading/trailing whitespace from entered barcode.
Mason James [Thu, 19 Mar 2009 22:52:26 +0000 (11:52 +1300)]
fix to remove leading/trailing whitespace from entered barcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agobugfix stickyduedate more sticky - couple more forms in circulation.tmpl
Michael Hafen [Wed, 6 May 2009 22:15:08 +0000 (16:15 -0600)]
bugfix stickyduedate more sticky - couple more forms in circulation.tmpl

There are a couple more forms in circulation.tmpl that need the
stickyduedate and duedatespec hidden inputs.  The 'Don't Check Out' form
of the needsconfirmation block, and the findborrower form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agobugfix stickyduedate more sticky - also patron search in quick search block
Michael Hafen [Wed, 6 May 2009 22:34:47 +0000 (16:34 -0600)]
bugfix stickyduedate more sticky - also patron search in quick search block

Forgot about the patron search for check out form in the quick search
block

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoadd windows quote to ignored chars
Nahuel ANGELINETTI [Mon, 11 May 2009 14:51:46 +0000 (16:51 +0200)]
add windows quote to ignored chars

This patch add the CP1252 "quote" (’) in ignored chars in zebra configuration.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agochange DOS newlines to Unix newlines in word-phrase-utf.chr
Galen Charlton [Mon, 11 May 2009 15:48:14 +0000 (10:48 -0500)]
change DOS newlines to Unix newlines in word-phrase-utf.chr

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoAdding some null words and mappings for Œ œ
Henri-Damien LAURENT [Wed, 28 Jan 2009 16:39:10 +0000 (17:39 +0100)]
Adding some null words and mappings for Œ œ
(cherry picked from commit e6e27bc80a7be792c228d2fef2e981539191ec36)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBugfix 3176 - Browser selected languages are not use by OPAC
Frédéric Demians [Thu, 30 Apr 2009 15:23:17 +0000 (17:23 +0200)]
Bugfix 3176 - Browser selected languages are not use by OPAC

This patch uses HTTP_ACCEPT_LANGUAGE web browser variable
to select OPAC available language.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoTweak ceilingDueDate and CalcDateDue
Michael Hafen [Wed, 29 Apr 2009 22:02:11 +0000 (16:02 -0600)]
Tweak ceilingDueDate and CalcDateDue

This patch moves ceilingDueDate and ReturnBeforeExpiry checking into
CalcDateDue(), so the renewal due date is also calculated with those.

Also restores a check in CanBookBeIssued.  If the due date isn't given
call CalcDateDue and make sure it's not in the past.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years ago(bug #3196) fix itemlost.pl
Nahuel ANGELINETTI [Thu, 7 May 2009 09:48:44 +0000 (11:48 +0200)]
(bug #3196) fix itemlost.pl

This patch fix 3 things:
* fix order by
* take care of item_level-itype
* use join in sql query

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug 1984 - added Javascript in the header to open, print, and close the slip window
Liz Rea [Fri, 1 May 2009 20:26:41 +0000 (15:26 -0500)]
Bug 1984 - added Javascript in the header to open, print, and close the slip window

This is for printing circulation slips.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agobug 1907 Partial fix: prevent bad records from truncating output.
Chris Catalfo [Fri, 1 May 2009 23:34:43 +0000 (23:34 +0000)]
bug 1907 Partial fix: prevent bad records from truncating output.

This patch starts improving export.pl by adding warnings, skipping invalid records, and not trying to access fields which don't exist.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agobug 3212: MARC21 bib leader plugin sets Leader/09 to 'a'
Galen Charlton [Fri, 8 May 2009 20:10:15 +0000 (15:10 -0500)]
bug 3212: MARC21 bib leader plugin sets Leader/09 to 'a'

Changed the plugin so that the form for editing the MARC21
leader now sets postion 9 (character coding) to 'a' (UCS/Unicode)
and no longer gives the cataloger the option to change it.  Koha
uses UTF-8 exclusively for MARC records, and a number of bugs
can be triggered by storing MARC21 bib and authority record
whose Leader/09 is anything other than 'a'.  Since internal
routines are increasingly ensuring that the MARC21 Leader/09 is
set to 'a', it doesn't make sense to give catalogers the idea
that it's possible (or a good idea) to set the Leader/09 to any
other value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agobug 3211: fix XHTML validation errors in MAR21 bib leader plugin
Galen Charlton [Fri, 8 May 2009 20:10:14 +0000 (15:10 -0500)]
bug 3211: fix XHTML validation errors in MAR21 bib leader plugin

Note that as a result of this patch, not only will the
page use valid XHTML, but the intranet stylesheets are
now used, IMO improving the display of the form.

This patch also fixes the descriptions of the Leader/09
and Leader/17.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agobug 3209: add 'p' (mixed materials) to MARC21 Leader/06 dropdown
Galen Charlton [Fri, 8 May 2009 20:10:13 +0000 (15:10 -0500)]
bug 3209: add 'p' (mixed materials) to MARC21 Leader/06 dropdown

Also made the following updates to the MARC21 leader plugin

[1] Changed description of Leader/08 to 'Type of control'
[2] Fixed typo in description value for 'z' in Leader/17
[3] Updated Leader/19, which is now 'Multipart resource record level'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agobug 3120: tweak splitting of Dewey call number
Galen Charlton [Fri, 8 May 2009 22:31:14 +0000 (17:31 -0500)]
bug 3120: tweak splitting of Dewey call number

If a call number prefix contains a hyphen, try not to
split on the hyphen.  For example, rather than
splitting the call number 'CD-ROM 787.87 EAS'
like this:

CD
-ROM
787.87
EAS

it should be

CD-ROM
787.87
EAS

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years ago(bug #3198) fix serial receive with autobarcode
Nahuel ANGELINETTI [Mon, 11 May 2009 08:46:58 +0000 (10:46 +0200)]
(bug #3198) fix serial receive with autobarcode

this add an arg to GetMarcFromKohaField, else it will always return (0,0).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoAdding the irc meeting and maintenance tree to the history
Chris Cormack [Sun, 10 May 2009 09:49:23 +0000 (21:49 +1200)]
Adding the irc meeting and maintenance tree to the history

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug 3213 - UNIMARC/MARC21 selection
Frédéric Demians [Mon, 11 May 2009 11:41:49 +0000 (13:41 +0200)]
Bug 3213 - UNIMARC/MARC21 selection

Modify how XSLT stylesheet are choosen
depending on 'marcflavour' syspref.

DOCUMENTATION: XSLTResultsDisplay and XSLTDetailsDisplay
sysprefs aren't MARC21-only anymore.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug 3213 - Add UNIMARC XSLT stylesheet
Frédéric Demians [Mon, 11 May 2009 11:41:50 +0000 (13:41 +0200)]
Bug 3213 - Add UNIMARC XSLT stylesheet

With those stylesheets result and detail pages
render better UNIMARC biblio record than normal
views. But works still have to be done in order
to reach UNIMARC-ISBD compliant display.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoMore fixes for Bug 2704, 440 Display Issues
Owen Leonard [Thu, 30 Apr 2009 16:36:19 +0000 (11:36 -0500)]
More fixes for Bug 2704, 440 Display Issues

Multiple series now display along with other detailed bibliographic information. Series title is displayed along with volume information. The template no longer displays information from biblioitems like volume and volumedesc in favor of information pulled directly from the MARC record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agobug 3205: fix another error in the OAI-PMH Identify response
Galen Charlton [Fri, 8 May 2009 16:54:29 +0000 (11:54 -0500)]
bug 3205: fix another error in the OAI-PMH Identify response

The optional description element of an Identify response
can't just be a string.  Identify.description is a container
for one or more elements; see http://www.openarchives.org/OAI/2.0/guidelines.htm

For now, simply commenting it out.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBugfix 3205 - Fix OAI server resonse to Identify request
Frédéric Demians [Fri, 8 May 2009 14:45:45 +0000 (16:45 +0200)]
Bugfix 3205 - Fix OAI server resonse to Identify request

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agobug 3195 : Item Transfers and Holds disrupted.
Ryan Higgins [Thu, 7 May 2009 18:19:05 +0000 (11:19 -0700)]
bug 3195 : Item Transfers and Holds disrupted.

This follows revert of commit 257a439d (bug 3025).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoRevert "(bug #3025) multiple check-in of a multiple times reserved item go wrong"
Ryan Higgins [Thu, 7 May 2009 18:19:04 +0000 (11:19 -0700)]
Revert "(bug #3025) multiple check-in of a multiple times reserved item go wrong"

This reverts commit 257a439dafa33d0c642f1ec7badedb5414027e64.
This patch causes Bug 3195 .

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years ago(bug #3190) allow right truncation in lot of records
Nahuel ANGELINETTI [Wed, 6 May 2009 08:50:51 +0000 (10:50 +0200)]
(bug #3190) allow right truncation in lot of records

This patch just add an option to zebra-biblios.cfg that allow to make right truncate requests on a huge request.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug 3173 Place Hold link visible in OPAC even if syspref turned off
Jane Wagner [Thu, 30 Apr 2009 14:58:39 +0000 (10:58 -0400)]
Bug 3173 Place Hold link visible in OPAC even if syspref turned off

If the syspref RequestOnOpac is turned off, the link to place a hold does not
show in the detail page.  However, the link is still present in the results
list as well as in the basket and in lists.  Modified templates to check
for the syspref and to obey it.

NOTE:  This does not turn off the display of the Holds tab in the OPAC
user account.  I think there are situations where library staff may be
allowed to place holds but users are not allowed to do so through the
OPAC.  Leaving the Holds tab visible shows users what they have on hold,
but does not allow them to place holds.  It does allow users to cancel
holds.  If there is a need to hide this tab, that would probably be
best accomplished by a separate syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years ago(bug #3187) authority search pagination doesn't work
Nahuel ANGELINETTI [Tue, 5 May 2009 09:53:30 +0000 (11:53 +0200)]
(bug #3187) authority search pagination doesn't work

this patch just set a marclist argument value on search authority, else the pagination won't work.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years ago(bug #3174) show the member name in reports
Nahuel ANGELINETTI [Mon, 4 May 2009 15:16:45 +0000 (17:16 +0200)]
(bug #3174) show the member name in reports

this patch show the member firstname and surname instead of only the borrowernumber in the guided reports page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoTweak offline_circ - honor itemBarcodeInputFilter and add to Makefile.PL
Michael Hafen [Tue, 5 May 2009 21:01:09 +0000 (15:01 -0600)]
Tweak offline_circ - honor itemBarcodeInputFilter and add to Makefile.PL

Add the ofline_circ directory to Makefile.PL as needing to be installed.
Add calls to barcodedecode() on issueing and returning.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agobug 2287: handle case where autoMemberNum is off
Galen Charlton [Fri, 8 May 2009 13:44:03 +0000 (08:44 -0500)]
bug 2287: handle case where autoMemberNum is off

When importing a patron file where new records
do not have a card number *and* autoMemberNum is
off, make sure that bororwers.cardnumber is set to NULL
for those new patrons rather than '' - otherwise, only
one patron with an empty barcode can be created, as there is
a uniqueness constraint on borrowers.cardnumber

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoAllow autogenerated cardnumbers again to solve http://bugs.koha.org/cgi-bin/bugzilla3...
MJ Ray [Tue, 5 May 2009 15:52:47 +0000 (16:52 +0100)]
Allow autogenerated cardnumbers again to solve bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2287

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years ago(bug #3183) fix the SetMarcUnicodeFlag function
Nahuel ANGELINETTI [Mon, 4 May 2009 09:22:15 +0000 (11:22 +0200)]
(bug #3183) fix the SetMarcUnicodeFlag function

This patch fix the funciton SetMarcUnicodeFlag for UNIMARC support, now the function will fix the length of the field, and set encoding as "50  " instead of "5050".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoOptimize XSLT.pm
Frédéric Demians [Thu, 7 May 2009 17:28:33 +0000 (19:28 +0200)]
Optimize XSLT.pm

Avoid reading marc_tag_structure for each biblo record to
transform by XSLT. Not totaly useless on OPAC result page.
Should be done via application variables rather than
request variable, but this is another story.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoAdd system preference search to administration home page (Bug 3181)
Owen Leonard [Sat, 2 May 2009 18:35:14 +0000 (13:35 -0500)]
Add system preference search to administration home page (Bug 3181)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBugfix 3199 - batchRebuildBiblioTables.pl failed due to missing argument [3.0.x]
Frédéric Demians [Thu, 7 May 2009 16:57:26 +0000 (18:57 +0200)]
Bugfix 3199 - batchRebuildBiblioTables.pl failed due to missing argument [3.0.x]

Thanks G. Henry

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agofix all templates errors reported by xt/author/valid-templates.t
Galen Charlton [Fri, 1 May 2009 22:59:04 +0000 (17:59 -0500)]
fix all templates errors reported by xt/author/valid-templates.t

In process, removed four disused HTML templates and one
disused script, serials/receipt.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug 2944 fix courtesy of Amr Denni
Chris Cormack [Sun, 3 May 2009 05:02:22 +0000 (17:02 +1200)]
Bug 2944 fix courtesy of Amr Denni

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years ago(bug #3197) Subfield code box was not present on new subfield tab in Admin/Authority
Colin Campbell [Thu, 7 May 2009 13:59:25 +0000 (14:59 +0100)]
(bug #3197) Subfield code box was not present on new subfield tab in Admin/Authority

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoSpelling correction
Owen Leonard [Sat, 2 May 2009 16:40:50 +0000 (11:40 -0500)]
Spelling correction

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoAdding David Birmingham as a developer
Chris Cormack [Fri, 1 May 2009 23:50:16 +0000 (11:50 +1200)]
Adding David Birmingham as a developer

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoMoved some variable definitions out of conditionals
Colin Campbell [Tue, 5 May 2009 09:36:41 +0000 (10:36 +0100)]
Moved some variable definitions out of conditionals

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug 3081 - The category code in the patron personal details page in opac showed the...
Garry Collum [Sun, 3 May 2009 04:23:14 +0000 (00:23 -0400)]
Bug 3081 - The category code in the patron personal details page in opac showed the category code and not the description. This patch makes the description appear instead. Looking at both opac-userupdate.pl and opac-userupdate.tmpl, the actual value of this text box is not retrieved for any purpose.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years ago(bug #3193) fix the comtd value in acqui-home.pl
Nahuel ANGELINETTI [Wed, 6 May 2009 10:26:55 +0000 (12:26 +0200)]
(bug #3193) fix the comtd value in acqui-home.pl

this patch fix the value of the comtd value which is not the same as in bookfund.pl, clicking on the value from acqui-home.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoRemove duplicate assignments for $template->param(script_name)
Joe Atzberger [Mon, 4 May 2009 20:16:01 +0000 (15:16 -0500)]
Remove duplicate assignments for $template->param(script_name)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoConvert shelves from using "toggle" code
Joe Atzberger [Mon, 4 May 2009 20:16:03 +0000 (15:16 -0500)]
Convert shelves from using "toggle" code

And one ELSIF.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug 3157: IE compatibility for label display
Joe Atzberger [Wed, 6 May 2009 19:41:51 +0000 (14:41 -0500)]
Bug 3157: IE compatibility for label display

Also fixed validation errors where label elements were "for" non-existant ids.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoAdding Colin Campbell to the history doc
Chris Cormack [Fri, 1 May 2009 22:37:45 +0000 (10:37 +1200)]
Adding Colin Campbell to the history doc

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoremoved extra /TMPL_IF introduce in previous Syndetics patch
Galen Charlton [Fri, 1 May 2009 22:27:04 +0000 (17:27 -0500)]
removed extra /TMPL_IF introduce in previous Syndetics patch

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug fix to OPAC shelf browsing query statement
David Birmingham [Thu, 30 Apr 2009 16:54:48 +0000 (12:54 -0400)]
Bug fix to OPAC shelf browsing query statement

If the items.location field was NULL, then the current
SQL query would produce no results.  I have turned this
into a conditional block that removes the location condition
in the query if the location is not specified.

In addition, there was a small change to opac-detail.tmpl
that changed Library to Shelves when the shelf browser was
open.  This removes a potential redundant Library Library
display if Library is contained in the starting_homebranch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoAdding warnings, fixing a bug that meant the title of an item that had a fine was...
Chris Cormack [Fri, 1 May 2009 21:39:25 +0000 (09:39 +1200)]
Adding warnings, fixing a bug that meant the title of an item that had a fine was never printed

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug #2974 Adding category code to BorrowerMandatoryField produced a "The following...
Garry Collum [Fri, 1 May 2009 01:54:31 +0000 (21:54 -0400)]
Bug #2974 Adding category code to BorrowerMandatoryField produced a "The following fields are mandatory: categorycode"

If you made a column that is implemented by a select box mandatory in
BorrowerMandatoryField, Members.js would throw an error on the first
element.  The original intent of the function was probably to catch
the first option for a drop-down list such as "Salutation" where the
text is blank.  Added code to check for an empty string in the first
element.

You can test this by making salutation (title) mandatory.

Also fixed some typos in some of the comments.  Why?  Because I'm a Librarian.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years ago(bug #3174) fill borrower number, and show author and creation date in saved reports
Nahuel ANGELINETTI [Thu, 30 Apr 2009 09:36:52 +0000 (11:36 +0200)]
(bug #3174) fill borrower number, and show author and creation date in saved reports

This patch add 2 columns in "Use Saved" page whith creation date, and the creator id.
It fix the creation of a report, to save the borrowernumber in reports table(to show it after).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agonew author test for syntax errors in HTML templates
Galen Charlton [Wed, 29 Apr 2009 21:51:11 +0000 (16:51 -0500)]
new author test for syntax errors in HTML templates

Added a new author test to look for syntax errors
in the HTML templates.  Run by doing

prove xt/author/valid-templates.t

from the root of a Koha source tree.

This test will help catch the following errors:

* unbalanced TMPL_IF, TMPL_UNLESS, and TMPL_LOOP contructs, e.g.,
  cases where a TMPL_IF is not closed by a /TMPL_IF.
* references to nonexistant include files
* syntax errors within a HTML::Template::Pro tag

This test currently ignores errors related to TMPL_IF EXPR, which
is currently deprecated for use in Koha -- this may be made
stricter in the future.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agofix XHTML validation error introduced in previous patch
Galen Charlton [Fri, 1 May 2009 21:17:26 +0000 (16:17 -0500)]
fix XHTML validation error introduced in previous patch

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoEnhancements/fixes for OPAC advanced search screen
Jane Wagner [Wed, 29 Apr 2009 18:14:56 +0000 (14:14 -0400)]
Enhancements/fixes for OPAC advanced search screen

Fixed opac-search.pl for correct test of expanded options and
to pass variable for MARC21 to advanced search screen.

Added Publication Date Range search to advanced search screen

Removed obsolete item type code section from advanced search screen
(wasn't displaying anyway because expanded options wasn't working,
superceded by site-specific item type searches).

Changed wording on Additional Content Types pulldown to make clear
it's limited to Books/Printed Materials -- this is basing off the
008 positions 24-27, but the options (and those positions) are only
valid for Book material types. Other material types have different
008 settings in those positions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoRemove unused $toggle code
Joe Atzberger [Thu, 30 Apr 2009 17:15:12 +0000 (12:15 -0500)]
Remove unused $toggle code

Some trivial other cleanups also.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoAdding the creation of sql library on the wiki
Chris Cormack [Thu, 30 Apr 2009 21:41:08 +0000 (09:41 +1200)]
Adding the creation of sql library on the wiki

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoSyndetics: add support for AVSUMMARY and AVPROFILE
Galen Charlton [Thu, 30 Apr 2009 20:09:42 +0000 (15:09 -0500)]
Syndetics: add support for AVSUMMARY and AVPROFILE

Added support for the Syndetics AV summary and AV profile
data elements.  The AV summary is displayed in the description
tab if present, while the AV profile is displayed as
a link off of the OPAC bib details page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoSyndetics: start switch to XML::LibXML to parse results
Galen Charlton [Thu, 30 Apr 2009 19:10:34 +0000 (14:10 -0500)]
Syndetics: start switch to XML::LibXML to parse results

XML::Simple doesn't handle mixed content, which is a
problem because reviews provided by Syndetics sometimes
contain HTML tags.  Furthermore, it's often easier to write
XPath to extract bits of an XML document than trying
to play with XML::Simple's options.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoSyndetics: add fiction notes/title profile link
Galen Charlton [Thu, 30 Apr 2009 19:29:54 +0000 (14:29 -0500)]
Syndetics: add fiction notes/title profile link

If a Syndetics title profile (AKA fiction notes page) exists
and is avaailable to the user, add a link to to in the OPAC
detail page.

TODO: add a system preference

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoCorrect comparison which was using an octal number
Colin Campbell [Fri, 1 May 2009 08:32:27 +0000 (09:32 +0100)]
Correct comparison which was using an octal number

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoAdding Liz Rea to the history.txt
Chris Cormack [Thu, 30 Apr 2009 03:33:13 +0000 (15:33 +1200)]
Adding Liz Rea to the history.txt

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoSyndetics: handle variations in reviews XML output
Galen Charlton [Thu, 30 Apr 2009 17:25:27 +0000 (12:25 -0500)]
Syndetics: handle variations in reviews XML output

For some reason different Syndetics users get
slightly different results when requesting
an XML-formatted review, so it's necessary to
handle both observed variations:

Here's one variation:

...
<Notes>
    <Fld520 I1="BLANK" I2="BLANK">
    <a>This is a review

And another:
...
<Notes>
    <Fld520 I1="BLANK" I2="BLANK">
        This is a review

This patch fixes a bug where some users the
source of a review but not the review itself.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agofix to C4::Koha::_isbn_cleanup
Galen Charlton [Thu, 30 Apr 2009 18:06:24 +0000 (13:06 -0500)]
fix to C4::Koha::_isbn_cleanup

Both valid ISBN-10s and -13s can use 'X' as a checkdigit
value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoVerbiage clarification in intranet advsearch.tmpl
root [Thu, 30 Apr 2009 16:42:23 +0000 (11:42 -0500)]
Verbiage clarification in intranet advsearch.tmpl

Changed verbiage from Limit type to: match any of the following to Limit to any of the following:

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoFix for Bug 2767, cart and lists buttons missing on opac-search.pl
Owen Leonard [Thu, 30 Apr 2009 16:40:14 +0000 (11:40 -0500)]
Fix for Bug 2767, cart and lists buttons missing on opac-search.pl

This fix adds alternate markup to be included on the advanced search page in order to mimic the placement of the cart and lists buttons on other opac pages.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoLibraryspeak extinction in OPAC: Verbiage Change opac-advsearch.tmpl
Liz Rea [Thu, 30 Apr 2009 16:30:26 +0000 (11:30 -0500)]
Libraryspeak extinction in OPAC: Verbiage Change opac-advsearch.tmpl

Changed verbiage from Limit type to: match any of the following to Limit to any of the following:

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug 3177 - haspermission offers bogus option
Joe Atzberger [Thu, 30 Apr 2009 15:04:38 +0000 (10:04 -0500)]
Bug 3177 - haspermission offers bogus option

$intflags was never used or returned if hashref instead of userid was passed.
Also cleaned up needless passing of $dbh.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
10 years agoBug 3179: Typo in C4::Circulation function call causes fatal error
Ryan Higgins [Thu, 30 Apr 2009 21:35:10 +0000 (14:35 -0700)]
Bug 3179: Typo in C4::Circulation function call causes fatal error

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>