wip/koha-chris_n.git
9 years agoMerge remote branch 'kc/new/bug_5651' into kcmaster
Chris Cormack [Wed, 6 Apr 2011 03:34:56 +0000 (15:34 +1200)]
Merge remote branch 'kc/new/bug_5651' into kcmaster

9 years agoBug 5651: Question marks break searches w/ICU
Jared Camins-Esakov [Tue, 5 Apr 2011 13:48:03 +0000 (15:48 +0200)]
Bug 5651: Question marks break searches w/ICU

When a user is doing a simple keyword search, they should not be expected to
deal with the magical behavior of question marks in Zebra. This fix escapes
question marks, and reduces the number of false positives for identifying a
"simple keyword search."

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug #6044 - Authority is deleted when mergeto and mergefrom are the same
Alex Arnaud [Tue, 5 Apr 2011 12:11:00 +0000 (14:11 +0200)]
Bug #6044 - Authority is deleted when mergeto and mergefrom are the same

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoUpdating database version number
Chris Cormack [Tue, 5 Apr 2011 07:56:12 +0000 (19:56 +1200)]
Updating database version number

9 years agoUpdating history
Chris Cormack [Tue, 5 Apr 2011 07:27:15 +0000 (19:27 +1200)]
Updating history

9 years agoBug 5970: Follow-up, freedeliveryplace was missing in kohastructure
Katrin Fischer [Mon, 4 Apr 2011 15:03:43 +0000 (17:03 +0200)]
Bug 5970: Follow-up, freedeliveryplace was missing in kohastructure

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5970: Adds the ability to use a free delivery address for basket
Matthias Meusburger [Mon, 28 Mar 2011 11:39:46 +0000 (13:39 +0200)]
Bug 5970: Adds the ability to use a free delivery address for basket

When editing a basket group, user can choose a library for delivery
place, or enter address of his choice in a text field.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Will send a follow-up for missing change in kohastructure.sql
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5593, Change cart markup to allow for easier icon styling
Owen Leonard [Fri, 7 Jan 2011 16:15:18 +0000 (11:15 -0500)]
Fix for Bug 5593, Change cart markup to allow for easier icon styling

Replacing inline cart image with a span with a unique ID. Adding
styling to the deafult CSS to give that span a background of the
same cart image as before. Custom CSS can override this with a
different image.

Example for OPACUserCSS preference:

  background-image : url("/opac-tmpl/prog/famfamfam/silk/basket.png");
  width:16px;
  height:16px;
}

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
    background-image: url("/opac-tmpl/prog/famfamfam/silk/basket.png");
}

Will also change the cart image in opac detail view.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoIncrementing database version
Chris Cormack [Tue, 5 Apr 2011 02:57:13 +0000 (14:57 +1200)]
Incrementing database version

9 years agowr76595 (bug 4157): Control barcode display with a borrower attribute
Srdjan Jankovic [Mon, 4 Apr 2011 12:25:27 +0000 (14:25 +0200)]
wr76595 (bug 4157): Control barcode display with a borrower attribute

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 4157: Display of barcode in checked out items in OPAC
Srdjan Jankovic [Mon, 4 Apr 2011 12:25:26 +0000 (14:25 +0200)]
Bug 4157: Display of barcode in checked out items in OPAC

wr76595: barcode display

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_5839' into kcmaster
Chris Cormack [Tue, 5 Apr 2011 02:50:58 +0000 (14:50 +1200)]
Merge remote branch 'kc/new/enh/bug_5839' into kcmaster

9 years agoFollow up fix for 5839 (items stocknumber)
Marcel de Rooy [Mon, 4 Apr 2011 10:38:42 +0000 (10:38 +0000)]
Follow up fix for 5839 (items stocknumber)

New installer file for norway was not yet included. Tested with mysql.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5963 : Add the ability to filter budgets using the active column
Christophe Croullebois [Mon, 4 Apr 2011 09:44:06 +0000 (11:44 +0200)]
Bug 5963 : Add the ability to filter budgets using the active column

(MT #4717) Add the capability to have a filter by active budget

the sub GetBudgetHierarchy return aqbudgetperiods.budget_period_active to have acces to a new filtering way,
 more the neworderempty.pl page have a check box "shox all".

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Bug 5963: Modify GetBudgetsHierarchy to returns all funds

GetBudgetHierarchy now returns all funds, not only those that are part
of an active budget.
Fixed a layout problem.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5949 : Popup alert when deleting items from basket, also change planning value...
Christophe Croullebois [Mon, 4 Apr 2011 10:29:36 +0000 (12:29 +0200)]
Bug 5949 : Popup alert when deleting items from basket, also change planning value to statistics

(MT #2391) : acqui/neworderempty.pl

Multiple fixes in neworderempty.pl, mainly about Modify order line page, link to edit catalog, user can delete items with popup information and can't add items also with popup explanation.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
- changed the the link from 'Edit Catalog' to 'Edit record' (like on result list)
- changed position of 'Edit record' to be shown behind the label 'Catalog details' instead of showing behind the Title.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5947 Suggestions : add date to the search query
Alex Arnaud [Mon, 4 Apr 2011 15:17:35 +0000 (17:17 +0200)]
Bug 5947 Suggestions : add date to the search query

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixes searching by dates, like 'Suggested on:'
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 3628: opacSerialDefaultTab
Marcel de Rooy [Mon, 4 Apr 2011 10:04:30 +0000 (12:04 +0200)]
Bug 3628: opacSerialDefaultTab

This partial fix makes this existing pref visible in the interface.
It should work for UNIMARC. Some work still needs to be done at the MARC side.

Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5962 : Budgets showing when they shouldn't (MT #4717) Bug in Koha 3.2 on acqui...
Christophe Croullebois [Mon, 4 Apr 2011 12:28:19 +0000 (14:28 +0200)]
Bug 5962 : Budgets showing when they shouldn't (MT #4717) Bug in Koha 3.2 on acqui-home.pl

In the screen all the budgets with budget_branchcode=NULL were displayed even if the budget_owner_id was not NULL. This patch fixes the bug

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
To test:
1) Add a new fund, leave library empty, owned by yourself
2) Go into the database and change aqbudgets.budget_branchcode to be NULL
3) Check acq home. Before patch the fund will not show up, although it's owned by you.
After patch it will.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5991 - Javascript error on purchase suggestion pages
Owen Leonard [Mon, 4 Apr 2011 14:13:33 +0000 (16:13 +0200)]
Fix for Bug 5991 - Javascript error on purchase suggestion pages

Rebased on master 2011-04-04

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge branch 'new/bug_5307' into kcmaster
Chris Cormack [Mon, 4 Apr 2011 22:06:02 +0000 (10:06 +1200)]
Merge branch 'new/bug_5307' into kcmaster

9 years agoBug 6046: suggestedby list on she filter was not created properly
Paul Poulain [Mon, 4 Apr 2011 13:53:19 +0000 (15:53 +0200)]
Bug 6046: suggestedby list on she filter was not created properly

The suggestedby patron list contained empty lines. This was because retrieving patron name was not correct

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6043: SQL error when IndependantBranches=ON on suggestion
Paul Poulain [Mon, 4 Apr 2011 13:19:32 +0000 (15:19 +0200)]
Bug 6043: SQL error when IndependantBranches=ON on suggestion

On suggestion page, when IndependantBranch=ON, the SQL built is wrong:
branchcode is ambiguous

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6045: Accepted by is empty when accepting from list
Paul Poulain [Mon, 4 Apr 2011 14:28:44 +0000 (16:28 +0200)]
Bug 6045: Accepted by is empty when accepting from list

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoUpdating database version
Chris Cormack [Mon, 4 Apr 2011 21:21:49 +0000 (09:21 +1200)]
Updating database version

9 years agoBug 5860: Adding duplicate stocknumber fails silently
Katrin Fischer [Mon, 4 Apr 2011 11:20:20 +0000 (11:20 +0000)]
Bug 5860: Adding duplicate stocknumber fails silently

When adding a duplicate stocknumber the duplicate was not saved to the database.
This happened, because the field stocknumber in table items was declared to be unique.
Discussion on bug suggests to lift this restriction.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested. Corrected typo in updatedatabase script. Version 3.01.00.095 introduced the index with double s, although structure had only one s in index name.
Unaware of this bug, I entered the more general bug 6041 for similar problems with modifying items.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5989 - Funds filter does not remember library choice
Owen Leonard [Mon, 4 Apr 2011 10:25:55 +0000 (12:25 +0200)]
Fix for Bug 5989 - Funds filter does not remember library choice

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoAdding a javascript function to check the validation of a record with a budget.
koha-preprod [Mon, 7 Feb 2011 16:12:49 +0000 (11:12 -0500)]
Adding a javascript function to check the validation of a record with a budget.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5948 : Creation of a quantity column in receipt summary
Christophe Croullebois [Mon, 4 Apr 2011 09:21:18 +0000 (11:21 +0200)]
Bug 5948 : Creation of a quantity column in receipt summary

In receipt summary the quantity did'nt appear in already received table, this patch fixes the omission

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch tested on current master. Works like advertised.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5839: Add mapping for items.stocknumber to MARC21
Katrin Fischer [Tue, 29 Mar 2011 21:48:46 +0000 (23:48 +0200)]
Bug 5839: Add mapping for items.stocknumber to MARC21

This patch adds 953$i 'Inventory number' to the frameworks.
952$i inventory number is not repeatable, not mandatory and mapped to items.stocknumber.
In a later patch a search index will be added to make inventory number/stocknumber  searchable.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5839: Add index stocknumber on 952$i
Katrin Fischer [Mon, 4 Apr 2011 08:38:02 +0000 (08:38 +0000)]
Bug 5839: Add index stocknumber on 952$i

This patch adds a new index for stocknumber on field 952$i.

Note: For testing you have to copy over the changed files
from  kohaclone/etc/zebradb/ to your koha-dev/etc/zebradb folders.
Reindex.

To test:
1) Add 952$i to your frameworks
2) Add an item with 952$i
3) Search for your 952$i value in keyword search
4) Search for stocknumber, using stocknumber:<your 952$i value> or inv:<...

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 4865: added dependency for using memcached for sessions
Galen Charlton [Sun, 3 Apr 2011 02:36:43 +0000 (22:36 -0400)]
bug 4865: added dependency for using memcached for sessions

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 4865: Enable session storage in Memcached
Chris Cormack [Sun, 3 Apr 2011 02:36:42 +0000 (22:36 -0400)]
bug 4865: Enable session storage in Memcached

Note: this requires CGI::Session::Driver::memcached to be installed

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix two small typos in MARC21 field 006 value builder
Jared Camins-Esakov [Sun, 3 Apr 2011 20:03:54 +0000 (16:03 -0400)]
Fix two small typos in MARC21 field 006 value builder

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_5548' into kcmaster
Chris Cormack [Sat, 2 Apr 2011 06:58:17 +0000 (19:58 +1300)]
Merge remote branch 'kc/new/enh/bug_5548' into kcmaster

9 years agoBug 5548: Correct punctuation in patch
Colin Campbell [Wed, 30 Mar 2011 18:53:46 +0000 (14:53 -0400)]
Bug 5548: Correct punctuation in patch

Punctuation should be a semi-colon not a comma
It works but is a trap for the unwary in the future

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'magnus/bug6002-sample-data' into new/enh/bug_6002
Chris Cormack [Sat, 2 Apr 2011 06:51:27 +0000 (19:51 +1300)]
Merge remote branch 'magnus/bug6002-sample-data' into new/enh/bug_6002

9 years agoBug 5870 : Follow up clean up patch
Stéphane Delaune [Mon, 28 Mar 2011 01:33:52 +0000 (14:33 +1300)]
Bug 5870 : Follow up clean up patch

(MT #4626) followup debug suggestion management : "accepted by" was not correctly displayed on suggestion's edit page

    suggestion's status, document's type and "accepted by" was not correctly displayed on suggestion's edit page
    (link with MT #4585)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5870 : suggestion management enhancements
Paul Poulain [Thu, 24 Mar 2011 09:08:59 +0000 (10:08 +0100)]
Bug 5870 : suggestion management enhancements

* changing suggestedy management
* adding a new status field & filter

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6026 : export.pl : removing useless condition
Henri-Damien LAURENT [Fri, 1 Apr 2011 08:34:51 +0000 (10:34 +0200)]
Bug 6026 : export.pl : removing useless condition

Some conditions added AND items.biblionumber=biblio/biblionumber
where JOIN USING (biblionumber) already added that.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoUpdating version
Chris Cormack [Fri, 1 Apr 2011 18:18:32 +0000 (07:18 +1300)]
Updating version

9 years agoMerge remote branch 'kc/new/enh/bug_4421' into kcmaster
Chris Cormack [Fri, 1 Apr 2011 18:15:47 +0000 (07:15 +1300)]
Merge remote branch 'kc/new/enh/bug_4421' into kcmaster

Conflicts:
C4/XSLT.pm
installer/data/mysql/fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql
installer/data/mysql/it-IT/necessari/sysprefs.sql
installer/data/mysql/ru-RU/mandatory/system_preferences_full_optimal_for_install_only.sql
installer/data/mysql/updatedatabase.pl

9 years agoBug 4421: Add alternate holdings display and prefs
Jared Camins-Esakov [Sat, 26 Mar 2011 14:43:06 +0000 (10:43 -0400)]
Bug 4421: Add alternate holdings display and prefs

This patch adds the ability to specify a field with alternate holdings
information for display when a biblio has no items associated with it.

Two sysprefs are added:
* AlternateHoldingsField specifies what field/subfields contain the alternate
holdings information. When blank, the alternate holdings information is not
displayed. The default is blank, as this is a new feature.
* AlternateHoldingsSeparator specifies the string to be used to separate
multiple subfields in the alternate holdings display. The default is ' '.

Example use case:
A library which does not have a 1-1 relationship between uncontrolled 852 fields
from a legacy system and actual physical items on the shelf wishes to display
holdings information from the 852, but does not want to create item records
which are almost certain to be inaccurate. By enabling the alternate holdings
feature (AlternateHoldingsField = '852abcdhi' and AlternateHoldingsSeparator =
' -- '), the library is able to gradually add item records as they locate the
physical items, without losing the holdings information presently stored in the
uncontrolled 852 fields.

To test:
1) Set AlternateHoldingsField to '852abcdhi'
2) Set AlternateHoldingsSeparator to ' -- '
3) Change the hidden value of subfields 'a', 'b', 'c', 'd', 'h', and/or 'i' of
   field 852 to 0 so that they display
4) Create a record which has data in the 852, but no item record
5) Look at holdings tab, where the data you entered should be displayed

Proof-of-concept initially developed for the American Numismatic Society.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_5548' into kcmaster
Chris Cormack [Fri, 1 Apr 2011 17:44:40 +0000 (06:44 +1300)]
Merge remote branch 'kc/new/enh/bug_5548' into kcmaster

9 years agoBug 5548 Follow up: Confirm Checkout message where it shouldn't be
Ian Walls [Fri, 1 Apr 2011 17:34:35 +0000 (13:34 -0400)]
Bug 5548 Follow up: Confirm Checkout message where it shouldn't be

Fixes the main Hard Due Dates conditional to first check for the existence
of $hardduedate, then the existences of its ISO export, then finally that that
value is not '0000-00-00'

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5625 : adding missing title (needed for lateorders.pl)
Paul POULAIN [Fri, 1 Apr 2011 15:04:47 +0000 (17:04 +0200)]
Bug 5625 : adding missing title (needed for lateorders.pl)

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 3727: Corrects the behaviour of the itemtype selectbox in addbiblio.pl
Frédérick Capovilla [Fri, 1 Apr 2011 10:23:12 +0000 (12:23 +0200)]
Bug 3727: Corrects the behaviour of the itemtype selectbox in addbiblio.pl

If the subfield is set as mandatory with an empty default value, an
empty value is added in the selectbox and this value is selected by
default. Before, the first element was automatically selected, so it was
easy to forget to set this mandatory value.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoSmall patch to make myself feel important
Robin Sheat [Tue, 29 Mar 2011 04:01:38 +0000 (17:01 +1300)]
Small patch to make myself feel important

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_5432' into kcmaster
Chris Cormack [Fri, 1 Apr 2011 17:08:43 +0000 (06:08 +1300)]
Merge remote branch 'kc/new/enh/bug_5432' into kcmaster

9 years agoFollow-up fix for Bug 5432 - Duplicate patron feature
Owen Leonard [Sat, 26 Mar 2011 18:29:39 +0000 (14:29 -0400)]
Follow-up fix for Bug 5432 - Duplicate patron feature

circ-toolbar.inc should get the same modification so that
all patron-related pages have the 'duplicate' button

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6006 - Move location from current location to home library column on detail.pl
Liz Rea [Wed, 30 Mar 2011 20:41:01 +0000 (16:41 -0400)]
Bug 6006 - Move location from current location to home library column on detail.pl

It doesn't make sense to have the home library's location (example: Adult) in
the "current (branch) location" column, since that location is assigned by the
home library.

This patch moves it to the "home location" column, where it belongs.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5478 - Automate MARC framework import/export
Salvador Zaragoza Rubio [Fri, 4 Mar 2011 09:05:34 +0000 (10:05 +0100)]
Bug 5478 - Automate MARC framework import/export

    Module to Import/Export a Framework structure to CSV/Excel-xml/ODS/SQL in Intranet Administration - MARC Frameworks section.
    There are two new links: "Export" to export to a format; and "Import" to import from a file.
    The data exported/imported is the one stored in the MySQL tables marc_tag_structure, marc_subfield_structure.

    Exported works as follows:
    1) CSV: As this format only allows one worksheet, the data from the tables is splitted with a row with #-# cells or with the
    names of the fields of the next MySQL table. Each row has as much cells as fields has the MySQL table. The first row contains the
    field names, the remaining holds the data.
    2) Excel: Excel xml 2003 format. Each MySQL table has its own worksheet in the spreadsheet. Rows and cells data as CSV.
    3) ODS: OpenDocument Spreadsheet compressed format, creates a temporary directory to generate the files needed to create the zip file.
    Each MySQL table has its own worksheet in the spreadsheet. Rows and cells data as CSV.
    4) SQL: Text file, the first row for each table is a delete and the remaining are inserts.

    Importing reads the rows from the spreadsheet/text-file as follows:
    1) CSV: Each row inserts or updates the associated MySQL table for this framework. At the end of the importing for a MySQL table, deletes the rows in the database that don't possess a correspondence with the spreadsheet.
    2) Excel: Imports each worksheet to the associated MySQL table. Works as the CSV for each worksheet.
    3) ODS: Creates a temporary directory to decompress and read the content.xml. This file has the data needed to import.
    Works as the CSV for each worksheet.
    4) Executes the SQL file.
    If the file imported has a different frameworkcode that the framework importing, the framecode is changed along the process.

    The Csv format will be the default.
    It uses perl module Archive::Zip or zip/unzip system command to process ODS files.
    To parse the sql files when importing it uses SQL::Statement or homemade parsing.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5857: longoverdue.pl needs a quiet mode for batch runs
ruth@bywatersolutions.com [Tue, 29 Mar 2011 01:06:18 +0000 (21:06 -0400)]
Bug 5857: longoverdue.pl needs a quiet mode for batch runs

This patch creates a --quiet flag for longoverdue that will squelch
the summary at the end of the run.  It also silences an unnecessary
warn in C4/Acounts.pm

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5952: Add another tab for relatives issues
Julian Maurice [Sat, 26 Mar 2011 09:49:10 +0000 (05:49 -0400)]
Bug 5952: Add another tab for relatives issues

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5952: Shows member relatives in issues lists
Matthias Meusburger [Sat, 26 Mar 2011 08:41:55 +0000 (04:41 -0400)]
Bug 5952: Shows member relatives in issues lists

Duplicate of '[PATCH] MT3747: Shows member relatives in issueslists' : Subject was wrong

MT3747, Follow-up: Adds siblings issues

MT3747, Follow-up: Shows member relatives in issues lists

 - Now displays patron's and relatives' issues apart

MT3747, Follow-up: Shows member relatives in issues lists

 - Removes renewal in circulation.pl
 - Adds links to moremember.pl

MT3747, Follow-up: Shows member relatives in issues lists

 - Remove unuseful warn

MT3747, Follow-up: Shows member relatives in issues lists

 - Removes renewal in moremember.pl

MT3747, Follow-up: Shows member relatives in issues lists

 - Adds sorting for circulation.pl

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5401, WYSIWYG for Koha news: Testing TinyMCE
Owen Leonard [Wed, 30 Mar 2011 11:42:48 +0000 (11:42 +0000)]
Bug 5401, WYSIWYG for Koha news: Testing TinyMCE

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoEscape the double quotes in authority search queries to prevent errors.
Frédérick Capovilla [Fri, 1 Apr 2011 07:16:51 +0000 (09:16 +0200)]
Escape the double quotes in authority search queries to prevent errors.

Before this fix, any search with double-quotes would return an error
500.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBumping database version
Chris Cormack [Fri, 1 Apr 2011 07:25:47 +0000 (20:25 +1300)]
Bumping database version

9 years agoBug 5959: Add search link for analytics to serial records
Katrin Fischer [Sun, 27 Mar 2011 21:42:18 +0000 (23:42 +0200)]
Bug 5959: Add search link for analytics to serial records

This will work similar to 'Show volumes' links from traced series records and
set records. A link to search for analytics linked to serials.

A new syspref will be added: UseControlNumber.

This syspref will make it possible to determine, if $w and Controlnumber are
used for linking of records in bibliographic records.

If syspref is OFF (default), the search links will not use control numbers
but keywords.
If syspref is ON links will be built using Control-number and rcn index.

NOTE: 773$a is added to index Host-item. For testing on a dev installation:
copy record.abs to your koha-dev folder and reindex!

Rebased against 3.03.00.035 and a small typo fixed by Jared Camins-Esakov.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBumping database version
Chris Cormack [Fri, 1 Apr 2011 07:17:39 +0000 (20:17 +1300)]
Bumping database version

9 years agoBug 5897: Add new syspref ShowReviewer
Katrin Fischer [Sat, 26 Mar 2011 10:26:34 +0000 (06:26 -0400)]
Bug 5897: Add new syspref ShowReviewer

This patch adds a new syspref ShowReviewer.

If ON (default) the reviewer/author of an OPAC comment will show.
If OFF the reviewer's name will be hidden.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5987: Add cl scripts to touch all biblios and items
Jared Camins-Esakov [Tue, 29 Mar 2011 13:39:52 +0000 (09:39 -0400)]
Bug 5987: Add cl scripts to touch all biblios and items

Add scripts that call ModBiblio and ModItem on all or some of the records in a
given catalog. For use when an upgrade changes the behavior of ModBiblio or
ModItem, and the change needs to be retroactively applied to records already in
the system. Usage is as follows:
misc/maintenance/touch_all_[biblios|items].pl [-v] [--where=STRING]

When invoked with a --where argument, the scripts will only modify those biblios
or items that match.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5975: Add id to "Don't have a card" instructions
Jared Camins-Esakov [Sat, 26 Mar 2011 17:39:25 +0000 (13:39 -0400)]
Bug 5975: Add id to "Don't have a card" instructions

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5973: Add spans to staff client results
Jared Camins-Esakov [Sat, 26 Mar 2011 17:37:28 +0000 (13:37 -0400)]
Bug 5973: Add spans to staff client results

This patch adds spans with named classes to the results page on the staff client
so that the formatting can be adjusted with CSS and/or jQuery.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFixing FSF address in license statements
Chris Cormack [Fri, 1 Apr 2011 02:55:06 +0000 (15:55 +1300)]
Fixing FSF address in license statements

9 years agoBumping database version
Chris Cormack [Fri, 1 Apr 2011 02:51:23 +0000 (15:51 +1300)]
Bumping database version

9 years agoBug 5578 : Follow up patch fixing FSF addresses
Chris Cormack [Fri, 1 Apr 2011 02:48:19 +0000 (15:48 +1300)]
Bug 5578 : Follow up patch fixing FSF addresses

9 years agoBug 5578: Self checkout by Login enhancement
Ian Walls [Wed, 30 Mar 2011 20:40:12 +0000 (16:40 -0400)]
Bug 5578: Self checkout by Login enhancement

Enables the library to choose whether to have patrons scan their barcodes for self checkout, or login
with username and password.  Uses 'checkpw' for compatibility with LDAP authentication.

Also introduces a few new system preferences to make Self Checkout more secure and manageable:

  SelfCheckTimeOut:      the number of seconds before the self-checkout login times out for a patron
  AllowSelfCheckReturns: indicate whether or not patrons can return materials via self-checkout
  SelfCheckHelpMessage:  user-configurable HTML to show specific text on the Help page.

Thank you to Marlboro College in Marlboro, VT for sponsoring and testing this development!

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5738 Display 856u As Image
Doug Dearden [Thu, 31 Mar 2011 21:22:26 +0000 (15:22 -0600)]
Bug 5738 Display 856u As Image

Add an option to the OPAC to display the URI that is stored in the 856u field
as an image instead of a text link.  This would be implemented in the OPAC XSLT
style sheets for the Results and Details pages, and would require that the
corresponding OPAC XSLT option be set.

This enhancement is designed to enable the staff to catalog images, then have
them appear on the resulting pages in the OPAC when searching.  Clicking on the
image would open it full size.  If the image option is in use, then the default
link text would be disabled.  Custom text would still appear if entered in the
"URLLinkText" option.

Add system preference "Display856uAsImage" with options of Results page,
Details page, Both Results and Details pages, Neither Results or Details page.

Notes for documentation manager:
There are two system preferences added for this enhancement:
OPACDisplay856uAsImage and Display856uAsImage.  These appear on the OPAC and
Staff Client screens under the System Preferences.

The preference can be set to one of four options:

Both Details and Results pages
Details page only
Neither Details or Results pages
Results page only

In addition to this option being set, the corresponding XSLT option must be
turned on. Also, the corresponding 856q field must have a valid MIME image
extension (e.g., "jpg") or MIME image type (i.e. starting with "image/"), or the
generic indicator "img" entered in the field.

As of 14 March 2011 the UNIMARC xslt display files also require a "0" in the
second indicator location of the 856u field for the links to be activated.  This
is not true for the MARC21 display files.

When all of the requirements are met, an image file will be displayed instead of
the standard link text. Clicking on the image will open it in the same way as
clicking on the link text.

Rebased and three original patches squashed into one on 30 March 2011 by Jared
Camins-Esakov.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Doug Dearden <dearden@sarsf.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_6003' into kcmaster
Chris Cormack [Fri, 1 Apr 2011 00:31:53 +0000 (13:31 +1300)]
Merge remote branch 'kc/new/enh/bug_6003' into kcmaster

9 years agoBug 6003 Display call number on return
Magnus Enger [Thu, 31 Mar 2011 03:09:24 +0000 (23:09 -0400)]
Bug 6003 Display call number on return

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5965 : Follow up patch, cleaned for style
Chris Cormack [Wed, 30 Mar 2011 10:24:20 +0000 (12:24 +0200)]
Bug 5965 : Follow up patch, cleaned for style

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5965 : Normalizing opac-detail.pl
Paul Poulain [Wed, 30 Mar 2011 10:24:19 +0000 (12:24 +0200)]
Bug 5965 : Normalizing opac-detail.pl

NFC on opac-detail

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5996 : MT2926: Fix default values for patron import
Matthias Meusburger [Wed, 30 Mar 2011 14:07:07 +0000 (16:07 +0200)]
Bug 5996 : MT2926: Fix default values for patron import

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5990: Lists and Cart show LOC code not Location Authorized value
Ian Walls [Wed, 30 Mar 2011 17:39:53 +0000 (13:39 -0400)]
Bug 5990: Lists and Cart show LOC code not Location Authorized value

Lists in the OPAC, and Cart on both sides, show the LOC code for items, rather
than the appropriate Description from Authorised Values.  This is because the
code uses GetItemInfo, which is a very heavy-weight call to only retrieve some
of the desired information.

This patch introduces a new subroutine in C4::Items, GetItemsLocationInfo, which
returns the branch names for both home- and holdingbranches, the location code,
both opac and intranet location descriptions, itemcallnumber and cn_sort. This
should be used instead of GetItemsInfo in any case where the locational
information is all that's required, as it's much more streamlined and efficient.

In the OPAC Lists, this only applies if OPACXSLTResultsDisplay is 'off' (set to
'normal').

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBumping database version number
Chris Cormack [Thu, 31 Mar 2011 23:06:20 +0000 (12:06 +1300)]
Bumping database version number

9 years agoBug 5957: Making COiNS in OPAC search results optional
Ian Walls [Wed, 30 Mar 2011 16:01:34 +0000 (12:01 -0400)]
Bug 5957: Making COiNS in OPAC search results optional

Adds a new system preference, COinSinOPACResults, which toggles the inclusion of
COiNS/OpenURL/Z39.88 in the search results display.  Default is 'on', continuing
the current behaviour.

Disabling this feature will result in a significant increase in search speed, since
each call to GetCOinSBiblio requires a separate parsing of the MARC record, and there are
<OPACnumSearchResults> calls to this routine with each search.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 4943: Search history cookie size limit
Matthias Meusburger [Wed, 30 Mar 2011 10:03:23 +0000 (12:03 +0200)]
Bug 4943: Search history cookie size limit

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5828 - notes for purchase suggestions not showing in the staff client
Owen Leonard [Thu, 31 Mar 2011 01:39:52 +0000 (21:39 -0400)]
Fix for Bug 5828 - notes for purchase suggestions not showing in the staff client

- Correcting the markup error that prevented the note from appearing
- Adding a little icon to set the note off from the other data

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/enh/bug_5548' into kcmaster
Chris Cormack [Thu, 31 Mar 2011 20:12:58 +0000 (09:12 +1300)]
Merge remote branch 'kc/new/enh/bug_5548' into kcmaster

9 years agoBug 5578 Followup: Hard Due Dates break hard-coded default circ rule
Ian Walls [Thu, 31 Mar 2011 19:33:17 +0000 (15:33 -0400)]
Bug 5578 Followup: Hard Due Dates break hard-coded default circ rule

If you do not have an applicable circulation rule for a combination of branch,
item type and patron category defined in your Circulation and Fines rules,
the Hard Due Dates development prevents circulation by introducing an error:

Can't call method "output" on an undefined value at /home/magnus/kohahead/C4/Circulation.pm line 2713

This is because the $hardduedate variable is not defined.  Changing the conditional
to check it, rather that it's output, fixes the issue.  That's what this patch does.

Is this the longest commit message for a single line fix?  Maybe.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6005: Fixes Transit slips cause FF4 to display "prevent this page from opening...
root [Wed, 30 Mar 2011 14:44:59 +0000 (10:44 -0400)]
Bug 6005: Fixes Transit slips cause FF4 to display "prevent this page from opening additional dialogs"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 6004/3270: Sending things "home"
ruth@bywatersolutions.com [Wed, 30 Mar 2011 15:52:27 +0000 (10:52 -0500)]
Bug 6004/3270: Sending things "home"

This patch addresses two problems:

Bug 6004:

If an item is returned at other than its' home library, and there is a hold for
it--at any library other than the return library--two prompts come up: one
telling the user to send the item home, and the other, to confirm and transfer
for the hold.  Only the latter should be displayed.

Bug 3270:

Cancelling a hold request after transfer initiated orphans item.

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5305: CCL query, then resort, loses reults.
ruth@bywatersolutions.com [Wed, 30 Mar 2011 16:11:51 +0000 (11:11 -0500)]
Bug 5305: CCL query, then resort, loses reults.

If you did a CCL query, then attempted resort, you would get the advanced-search page,
because of wonky URL escaping of the q= clause.  This patch fixes that.

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5988 - SearchMyLibraryFirst preference appears twice in preferences
Owen Leonard [Wed, 30 Mar 2011 13:06:44 +0000 (09:06 -0400)]
Fix for Bug 5988 - SearchMyLibraryFirst preference appears twice in preferences

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 3523 - Menu of existing lists limited to 10
Owen Leonard [Wed, 30 Mar 2011 13:34:25 +0000 (15:34 +0200)]
Fix for Bug 3523 - Menu of existing lists limited to 10

- adding "more" option to the search results dropdown
- offering a scrolling list on the add-to-list popup
- lists add popup shows the full list of all
  the patron's lists, divided into groups of private and
  public lists.

Can be improved by a fix for Bug 5529

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/master' into new/bug_5940
Chris Cormack [Thu, 31 Mar 2011 07:45:52 +0000 (20:45 +1300)]
Merge remote branch 'kc/master' into new/bug_5940

9 years agoBug 5940: Offline Circ & Patron Card Help Files for 3.4
Nicole C. Engard [Wed, 30 Mar 2011 20:47:13 +0000 (16:47 -0400)]
Bug 5940: Offline Circ & Patron Card Help Files for 3.4

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug5940: Authority, Labels, Circ help files for 3.4
Nicole C. Engard [Wed, 30 Mar 2011 19:48:04 +0000 (15:48 -0400)]
Bug5940: Authority, Labels, Circ help files for 3.4

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5940: Admin Help Files for 3.4
Nicole C. Engard [Tue, 29 Mar 2011 21:35:41 +0000 (17:35 -0400)]
Bug 5940: Admin Help Files for 3.4

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMT3289 : check_sysprefs.pl case sensitive variable names
Henri-Damien LAURENT [Sun, 11 Apr 2010 18:40:57 +0000 (20:40 +0200)]
MT3289 : check_sysprefs.pl case sensitive variable names

Variable names for systempreferences are now case sensitive.
Changing check_sysprefs in relation with this change

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoTypo in kohastructured.sql thanks to Marcel de Rooy for the catch
Chris Cormack [Wed, 30 Mar 2011 22:41:48 +0000 (11:41 +1300)]
Typo in kohastructured.sql thanks to Marcel de Rooy for the catch

9 years agoAnother wrong encoding in installer/data/mysql/nb-NO/2-Valgfritt/
Magnus Enger [Tue, 29 Mar 2011 19:15:08 +0000 (21:15 +0200)]
Another wrong encoding in installer/data/mysql/nb-NO/2-Valgfritt/

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
9 years agoFix wrong encodings in installer/data/mysql/nb-NO/2-Valgfritt/
Magnus Enger [Tue, 29 Mar 2011 19:13:41 +0000 (21:13 +0200)]
Fix wrong encodings in installer/data/mysql/nb-NO/2-Valgfritt/

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
9 years agoA couple of missing translations in installer/data/mysql/nb-NO/2-Valgfritt/
Magnus Enger [Tue, 29 Mar 2011 19:11:28 +0000 (21:11 +0200)]
A couple of missing translations in installer/data/mysql/nb-NO/2-Valgfritt/

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
9 years agoFix typo in installer/data/mysql/nb-NO/2-Valgfritt/sample_patrons.txt
Magnus Enger [Tue, 29 Mar 2011 19:06:47 +0000 (21:06 +0200)]
Fix typo in installer/data/mysql/nb-NO/2-Valgfritt/sample_patrons.txt

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
9 years agoAdd files to installer/data/mysql/nb-NO/2-Valgfritt/
Magnus Enger [Tue, 29 Mar 2011 14:26:47 +0000 (16:26 +0200)]
Add files to installer/data/mysql/nb-NO/2-Valgfritt/

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
9 years agoTranslate OPACSearchForTitleIn in installer/data/mysql/nb-NO/1-Obligatorisk/sysprefs.sql
Magnus Enger [Tue, 29 Mar 2011 11:32:25 +0000 (13:32 +0200)]
Translate OPACSearchForTitleIn in installer/data/mysql/nb-NO/1-Obligatorisk/sysprefs.sql

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
9 years agoAdd files in installer/data/mysql/nb-NO/1-Obligatorisk/
Magnus Enger [Tue, 29 Mar 2011 10:31:42 +0000 (12:31 +0200)]
Add files in installer/data/mysql/nb-NO/1-Obligatorisk/

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
9 years agoAdd a copy of MARC21 data
Magnus Enger [Mon, 28 Mar 2011 21:00:56 +0000 (23:00 +0200)]
Add a copy of MARC21 data

Copy installer/data/mysql/en/marcflavour/marc21
to   installer/data/mysql/nb-no/marcflavour/marc21

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
9 years agoAdd sample Z39.50 servers
Magnus Enger [Tue, 9 Mar 2010 11:38:23 +0000 (12:38 +0100)]
Add sample Z39.50 servers

Signed-off-by: Magnus Enger <magnus@enger.priv.no>