wip/koha-chris_n.git
11 years agoBug 2900: fix GetPendingIssues.
Joe Atzberger [Thu, 8 Jan 2009 03:47:36 +0000 (21:47 -0600)]
Bug 2900: fix GetPendingIssues.

GetPendingIssues did several bad things:
~ select * on a 4 table join,
~ including multiple namespace collisions,
~ including large fields marc and marcxml from biblioitems,
~ return ($count, \@array_being_counted).

Not everything is fixed here (see FIXMEs), but the situation is
improved considerably, with bug 2900 resolved.  The "timestamp"
namespace collision in query should be resolved by separate patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2747: avoid warning if items.itype is NULL
Galen Charlton [Wed, 7 Jan 2009 21:32:35 +0000 (15:32 -0600)]
bug 2747: avoid warning if items.itype is NULL

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoBug 2747 for staff interface itemtype display.
Joe Atzberger [Wed, 7 Jan 2009 20:57:28 +0000 (14:57 -0600)]
Bug 2747 for staff interface itemtype display.

Prefer accuracy over graphical icon.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoGetAuthValCode calls were positioned inside the loop,
Joe Atzberger [Wed, 7 Jan 2009 20:57:29 +0000 (14:57 -0600)]
GetAuthValCode calls were positioned inside the loop,

despite the same values being supplied each time.  Then
the conditional assignments would repeat the same calls again!
That means execution was liable to query the DB at least once
and as many as four times per item.  With a large number of items
this is an unnecessary burden.  By moving the calls outside
the loop, we can guarantee that we never have to call the DB for
that info more than twice (once for lost, once for damaged).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agofix permission error introduced in a previous patch
Galen Charlton [Wed, 7 Jan 2009 03:03:40 +0000 (21:03 -0600)]
fix permission error introduced in a previous patch

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoBug 2752 - comment out problematic DELETE op.
Joe Atzberger [Mon, 8 Dec 2008 16:01:23 +0000 (10:01 -0600)]
Bug 2752 - comment out problematic DELETE op.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agojavascript redirect when selecting a patron on circulation.pl Patron Selection Screen
Michael Hafen [Wed, 27 Aug 2008 22:46:57 +0000 (16:46 -0600)]
javascript redirect when selecting a patron on circulation.pl Patron Selection Screen

This adds a little javascript to the Patron Selection form input after searching for a patron to check out to.
On click it redirects to checking out to the clicked patron.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoPut patron Privilege 'updatecharges' to use on fines pages
Michael Hafen [Thu, 13 Nov 2008 23:11:35 +0000 (16:11 -0700)]
Put patron Privilege 'updatecharges' to use on fines pages

This changes the flags required for the fines pages to include the
updatecharges flag.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoHiding SMS messaging preferences if there is no SMSSendDriver defined in system prefe...
Owen Leonard [Tue, 21 Oct 2008 19:57:27 +0000 (14:57 -0500)]
Hiding SMS messaging preferences if there is no SMSSendDriver defined in system preferences.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoHiding SMS settings in OPAC if SMSSendDriver is not defined. Fixes Bug 2455, remove...
Owen Leonard [Tue, 21 Oct 2008 20:15:26 +0000 (15:15 -0500)]
Hiding SMS settings in OPAC if SMSSendDriver is not defined. Fixes Bug 2455, remove SMS column from patron messaging preferences if SMSSendDriver is not defined

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoBug 2842: ->regexp('syspref') failed for users of iso dateformat.
Joe Atzberger [Thu, 4 Dec 2008 04:33:02 +0000 (22:33 -0600)]
Bug 2842: ->regexp('syspref') failed for users of iso dateformat.

Sticky due date and patron import were the two areas affected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoDates expanding to expose some time (HH:MM:SS) granularity.
Joe Atzberger [Fri, 19 Sep 2008 00:02:48 +0000 (19:02 -0500)]
Dates expanding to expose some time (HH:MM:SS) granularity.

t/Dates.t is essentially restored from its previous state with
the revision that it now does not use C4::Context or check syspref
for the default date format.  Instead it sets the C4::Dates default
directly, taking cue from command line argument or ENV.  ISO format
revised to accept "T" separator and "Z" (zulu) terminator. POD
expanded and corrected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoa more readable way to test an array size.
Nahuel Angelinetti [Wed, 15 Oct 2008 09:03:25 +0000 (11:03 +0200)]
a more readable way to test an array size.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2505: enable warnings for admin/authorized_values.pl
Galen Charlton [Wed, 7 Jan 2009 01:43:35 +0000 (19:43 -0600)]
bug 2505: enable warnings for admin/authorized_values.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoauthorized_values cleanup
Joe Atzberger [Fri, 12 Dec 2008 21:28:01 +0000 (15:28 -0600)]
authorized_values cleanup

Moving towards being able to enable warnings.  Use one dbh, and stop
redeclaring it in each conditional chunk.  ($sth still need to be cleaned.)
Toggle in script removed (tmpl should use loop context var __odd__).
$sth->finish calls removed where unnecessary.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoREFACTOR: correcting indirect object method syntax
Andrew Moore [Wed, 17 Dec 2008 22:31:25 +0000 (16:31 -0600)]
REFACTOR: correcting indirect object method syntax

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoBug 2505: turning on "warnings" in catalogue/detail.pl
Andrew Moore [Wed, 17 Dec 2008 22:32:46 +0000 (16:32 -0600)]
Bug 2505: turning on "warnings" in catalogue/detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoA few more tweaks to the OPAC detail view menu
Owen Leonard [Wed, 31 Dec 2008 20:28:27 +0000 (14:28 -0600)]
A few more tweaks to the OPAC detail view menu

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoProviding options for adding to order when existing record search has failed.
Owen Leonard [Wed, 31 Dec 2008 20:28:38 +0000 (14:28 -0600)]
Providing options for adding to order when existing record search has failed.

I've duplicated the "Add to Order" block on the search results page to display after a user has searched for an existing record to add to an order. This block is displayed whether or not results were found on the assumption that a non-empty result set may not contain the desired result. Changes to neworderbiblio.pl allow supplier name to appear in breadcrumb nav.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agopatch followup: restore test in GetMarcItem
Galen Charlton [Wed, 7 Jan 2009 00:54:08 +0000 (18:54 -0600)]
patch followup: restore test in GetMarcItem

Change made to GetMarcItem to quell a warning
changed sense of a test; defined($foo) is *not*
the same as $foo ne ''.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2505: more warnings fixes to C4/Biblio.pm
Galen Charlton [Tue, 6 Jan 2009 14:59:09 +0000 (08:59 -0600)]
bug 2505: more warnings fixes to C4/Biblio.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoFix for Bug 2700, Keeping Data When Adding Multiple Items
Owen Leonard [Tue, 4 Nov 2008 16:21:47 +0000 (10:21 -0600)]
Fix for Bug 2700, Keeping Data When Adding Multiple Items

When cloning the set of inputs, the new js
increments the IDs of each form field (to keep them unique) and automatically
selects the option that was selected in the cloned group.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2505: enable warnings for labels/label-print-pdf.pl
Galen Charlton [Mon, 5 Jan 2009 22:33:41 +0000 (16:33 -0600)]
bug 2505: enable warnings for labels/label-print-pdf.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoLabels Cleanup (Part 2 of Many)
Joe Atzberger [Wed, 3 Dec 2008 15:31:50 +0000 (09:31 -0600)]
Labels Cleanup (Part 2 of Many)

CalcNextLabelPos pulled out of each subblock.
Print of header and initial structure deferred until later to allow fatals_to_browser to
display any fatal errors encountered in data preparation.  This does not fix Unicode "wide character" crashes.
Created subroutine for debug dump lines.
Comparisons corrected (numerical not string compare).

Note: this script is still insecure with NO AUTH CHECK.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoBug 2505: adding warnings to C4/Biblio.pm
Andrew Moore [Wed, 17 Dec 2008 22:28:04 +0000 (16:28 -0600)]
Bug 2505: adding warnings to C4/Biblio.pm

I added 'use warnings' to C4::Biblio and made a handful of changes to
reduce the number of warnings emitted.

One notable spot is the change in the regex in
C4::Biblio::GetNoZebraIndexes. I have replaced the parens with a character
class. The parens change the way 'split' works, making it return elements
for each delimiter. We did not want those elements returned, and they
only resulted in "'' => undef" being added to the final hash. They also
resulted in two "undefined" warnings for each pass through the loop. I've
included a simple test for this function.

There may be a few warnings still emitted in spots, but either I haven't
seen them yet, or I have chosen to not fix them yet because they require
too much change.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoUsing Warns would cause problems with NoZebra
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:16 +0000 (14:58 +0100)]
Using Warns would cause problems with NoZebra

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobarcodedecode() did not always return barcode
Joe Atzberger [Fri, 2 Jan 2009 20:35:03 +0000 (14:35 -0600)]
barcodedecode() did not always return barcode

This patch amends the function to return barcode, in particular when
filter is not defined.  It also adds an optional 2nd argument to
allow the filter to be specified by caller, enabling testing.

Non-DB-dependent test script included.  Note: T-prefix style
barcode filter is not documented, and drops the first nonzero
digit after the T.  This seems mistaken, but is not corrected here
to avoid any surprises.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoAllow AddIssue to log SIP transactions distinct from others.
Joe Atzberger (siptest [Tue, 28 Oct 2008 18:37:37 +0000 (13:37 -0500)]
Allow AddIssue to log SIP transactions distinct from others.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoLabels Cleanup (Part 1 of Many)
Joe Atzberger [Wed, 3 Dec 2008 15:31:49 +0000 (09:31 -0600)]
Labels Cleanup (Part 1 of Many)

Consolidated error catching after evals.
Removed unnecessary $sth->finish calls and some unused variables.
Pulled query for itemtype mappings outside DrawSpineText and added
a class level caching variable to eliminate repeated queries for
*each piece of text* on *each label*!  This was a major performance
downside.

Note: this does not fix Unicode problems, but it does add some notes
on unsuccessful attempted workaround using utf8::encode.

C4::Labels should likely be broken up to separate out the pieces that
do not touch the database (wrappers of PDF::Reuse) and those that are
CRUD API for table data.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoremove TMPL_IF EXPR in member.tmpl
Galen Charlton [Wed, 31 Dec 2008 21:52:44 +0000 (15:52 -0600)]
remove TMPL_IF EXPR in member.tmpl

Quells following error message in Apache log:

EXPR:at pos 8: non-initialized variable overdues,
referer: http://example.edu/cgi-bin/koha/members/members-home.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoperltidy lables/label-item-search.pl
Galen Charlton [Wed, 31 Dec 2008 21:34:26 +0000 (15:34 -0600)]
perltidy lables/label-item-search.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2505: turn on warnings in labels/label-item-search.pl
Galen Charlton [Wed, 31 Dec 2008 21:31:32 +0000 (15:31 -0600)]
bug 2505: turn on warnings in labels/label-item-search.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agofollowup to Mason's labels patch
Galen Charlton [Wed, 31 Dec 2008 20:46:09 +0000 (14:46 -0600)]
followup to Mason's labels patch

* fix XHTML errors
* fix problems with paging through results list

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoThe current searching in labels is a bit minimal, and current only does keyword searc...
Mason James [Wed, 12 Nov 2008 06:55:39 +0000 (19:55 +1300)]
The current searching in labels is a bit minimal, and current only does keyword searching.

there is some old 2.2 code for more complete labels-searching, thats been commented out

ive logged a 'bug' for this - 2777

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2777

this fix...
  - enables the index-searching functionality
  - adds date-ranges
  - uses the numSearchResults syspref, not a hardcoded '20'
  - rewrote old 2.2 page-num code, (didnt work for 3.x)
  - some indent and whitepages tidys.
  - unused 2.2 search-code removed.

Mason

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years ago(bug #2881) preselect default sorting
Nahuel ANGELINETTI [Tue, 23 Dec 2008 14:00:27 +0000 (15:00 +0100)]
(bug #2881) preselect default sorting

This patch just set a variable with the name of default sorting, and value 1

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoFormatting changes for OPAC xslt and staff client catalog detail pages. Fixes Bug...
Owen Leonard [Tue, 21 Oct 2008 16:13:36 +0000 (11:13 -0500)]
Formatting changes for OPAC xslt and staff client catalog detail pages. Fixes Bug 2704, 440 Display Issues.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years ago(bug #2887) Change the "Cart" box from js to tmpl
Nahuel ANGELINETTI [Mon, 29 Dec 2008 11:27:06 +0000 (12:27 +0100)]
(bug #2887) Change the "Cart" box from js to tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoremove disused script admin/letter.pl
Galen Charlton [Wed, 31 Dec 2008 16:28:03 +0000 (10:28 -0600)]
remove disused script admin/letter.pl

Was moved to tools/letter.pl in 2006, but old
(and nonfunctional) version was left in place.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoremoving *.old files
Galen Charlton [Wed, 31 Dec 2008 16:23:34 +0000 (10:23 -0600)]
removing *.old files

Don't need to do this when modifying a script --
this is what Git is for.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoAdds the ability to reference itemcallnumber within XSLT
Joshua Ferraro [Tue, 23 Dec 2008 22:17:58 +0000 (16:17 -0600)]
Adds the ability to reference itemcallnumber within XSLT

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agofollowup to prior patch: remove $toggle from script
Galen Charlton [Wed, 31 Dec 2008 16:10:02 +0000 (10:10 -0600)]
followup to prior patch: remove $toggle from script

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoRemove "toggle" from template, use loop_context_vars __odd__ instead.
Joe Atzberger [Tue, 30 Dec 2008 17:20:14 +0000 (11:20 -0600)]
Remove "toggle" from template, use loop_context_vars __odd__ instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoFixes bug #2875
Frederic Demians [Tue, 30 Dec 2008 06:54:44 +0000 (07:54 +0100)]
Fixes bug #2875

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoMinor updates to minor cronjob script.
Joe Atzberger [Tue, 30 Dec 2008 17:20:15 +0000 (11:20 -0600)]
Minor updates to minor cronjob script.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agocrontab.example - add back some useful comments
Galen Charlton [Wed, 31 Dec 2008 15:44:06 +0000 (09:44 -0600)]
crontab.example - add back some useful comments

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoExpand crontab.example
Joe Atzberger [Tue, 30 Dec 2008 17:20:16 +0000 (11:20 -0600)]
Expand crontab.example

Default overdues to "triggered" mode (-t).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoRevert "Updates to the example crontab"
Joe Atzberger [Tue, 23 Dec 2008 18:34:57 +0000 (12:34 -0600)]
Revert "Updates to the example crontab"

This reverts commit def09f5a21b47431ff107d9a530900cd5a4fb93d.

As I emailed to the patches list Oct 06, 2008:

I suggest we need to revert Josh' commit def09f5a21b47431ff107d9a530900cd5a4fb93d.

The effect on the crontab example is to invalidate the lines being executed.  The lines were apparently copied in from a cron source, not crontab, despite the header describing it NOT being an example for cron.  It also runs longoverdue twice, instead of fines.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoFixes bugs #2875-2879
Frederic Demians [Tue, 23 Dec 2008 07:57:15 +0000 (08:57 +0100)]
Fixes bugs #2875-2879

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoAdd 'use warnings' and correct uninitialized value warnings.
Stan Brinkerhoff [Wed, 24 Dec 2008 12:41:56 +0000 (07:41 -0500)]
Add 'use warnings' and correct uninitialized value warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoRemoving ':' from table headers.
Stan Brinkerhoff [Wed, 24 Dec 2008 12:13:16 +0000 (07:13 -0500)]
Removing ':' from table headers.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoAdded 'dbd::sqlite' as appears as an optional module during latest installers.
Stan Brinkerhoff [Wed, 24 Dec 2008 11:52:30 +0000 (06:52 -0500)]
Added 'dbd::sqlite' as appears as an optional module during latest installers.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2505: further warnings fixes to memberentry.pl
Galen Charlton [Tue, 30 Dec 2008 01:42:45 +0000 (19:42 -0600)]
bug 2505: further warnings fixes to memberentry.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoAdded 'warnings' support, fixed bug 2870.
stan [Wed, 24 Dec 2008 03:06:10 +0000 (22:06 -0500)]
Added 'warnings' support, fixed bug 2870.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2856 followup - display form correctly when modifying patron
Galen Charlton [Tue, 30 Dec 2008 01:19:30 +0000 (19:19 -0600)]
bug 2856 followup - display form correctly when modifying patron

Upon further testing, original patch for 2856 had effect
of displaying form with blank values when modifying
an existing patron record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2856 followup: remove unconditional warn
Galen Charlton [Mon, 29 Dec 2008 19:53:11 +0000 (13:53 -0600)]
bug 2856 followup: remove unconditional warn

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years ago(bug #2856) Activate the duplicate patrons detection and check birthdate only if...
Nahuel ANGELINETTI [Thu, 11 Dec 2008 09:08:15 +0000 (10:08 +0100)]
(bug #2856) Activate the duplicate patrons detection and check birthdate only if one is set

This patch activate the check of unique member, it was checked but not shown, and the member was added even if a duplicate was
detected.
It improve the duplicate detection, to check the birthdate only if it was specified in the form.
And fix an url of "Yes" link(if the borrower added IS the duplicate detected).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoTest suite: C4::Members::GetMemberDetails
Allen Reinmeyer [Wed, 24 Dec 2008 22:09:49 +0000 (16:09 -0600)]
Test suite: C4::Members::GetMemberDetails

Tests for C4::Members::GetMemberDetails.  Validates both calls
using either borrowernumber or cardnumber.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoTest suite: C4::Members::GetMember
Allen Reinmeyer [Wed, 24 Dec 2008 22:09:50 +0000 (16:09 -0600)]
Test suite: C4::Members::GetMember

Tests the functionality of C4::Members::GetMember.  Tests exist
for every way that GetMember could be called on to search for an
existing member.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2874 [3/3] flagsrequired => { circulate => "circulate_remaining_permissions" }
John Beppu [Mon, 22 Dec 2008 17:07:55 +0000 (11:07 -0600)]
bug 2874 [3/3] flagsrequired => { circulate => "circulate_remaining_permissions" }

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2874 [2/3]: added awareness of circulate/override_renewals subpermission
John Beppu [Mon, 22 Dec 2008 17:07:54 +0000 (11:07 -0600)]
bug 2874 [2/3]: added awareness of circulate/override_renewals subpermission

A few minor whitespace cleanups were thrown in as well.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2874 [1/3]: schema changes for overriding blocked renewals
John Beppu [Mon, 22 Dec 2008 17:07:53 +0000 (11:07 -0600)]
bug 2874 [1/3]: schema changes for overriding blocked renewals

Two new subpermissions of circulate were added:
- circulate_remaining_permissions
- override_renewals

Also, the following schema alterations were made
- permissions.code      : varchar(30) => varchar(64)
- user_permissions.code : varchar(30) => varchar(64)

  (The reason for this was because "circulate_remaining_permissions"
   was greater than 30 characters long and wouldn't fit.)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoImprovements to offline circ report (linking to title and patron records), and moving...
Owen Leonard [Thu, 2 Oct 2008 20:19:55 +0000 (15:19 -0500)]
Improvements to offline circ report (linking to title and patron records), and moving English strings from the script into the template to allow translation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoA script generating keyword clouds from Zebra Indexes
Frederic Demians [Thu, 18 Dec 2008 17:38:25 +0000 (18:38 +0100)]
A script generating keyword clouds from Zebra Indexes

See embedded perldoc to see how it works.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agotest suite: C4::ImportBatch
Andrew Moore [Fri, 19 Dec 2008 22:12:25 +0000 (16:12 -0600)]
test suite: C4::ImportBatch

Here are some tests for functions in C4::ImportBatch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoBug 2868: fixing typo in NoZebraIndexes setting in sysprefs
Andrew Moore [Wed, 17 Dec 2008 21:13:49 +0000 (15:13 -0600)]
Bug 2868: fixing typo in NoZebraIndexes setting in sysprefs

There was a missing ' in the value of the NoZebraIndexes syspref. This
patch fixes it.

It's not necessary to fix the existing settings because
C4::Biblio::GetNoZebraIndexes is liberal enough to be able to parse even
the deformed value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2799: DB rev 008 for library transfer limits
Galen Charlton [Wed, 17 Dec 2008 20:09:26 +0000 (14:09 -0600)]
bug 2799: DB rev 008 for library transfer limits

Also fix automatic merge that put the 008
update in the wrong place.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2799: followup 2
Galen Charlton [Wed, 17 Dec 2008 20:40:53 +0000 (14:40 -0600)]
bug 2799: followup 2

* fix TMPL_IF embedded in HTML tag
* convert a remaining <TMPL_VAR> to a comment

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2799: followup
Galen Charlton [Wed, 17 Dec 2008 20:09:27 +0000 (14:09 -0600)]
bug 2799: followup

Various fixes to meet coding standards, template
design, and basic functionality:

* (bug 2505) turned on warnings
* use correct loop names when populating
  $template
* put all TMPL_FOO in HTML comments
* assign UseBranchTransferLimits to circulation tab
* change template to use "library" instead of "branch"
* use standard YUI scripting for toolbar buttons
* add new script to admin menu

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoBug 2799: database update to "branch transfer limits"
Andrew Moore [Wed, 17 Dec 2008 20:09:25 +0000 (14:09 -0600)]
Bug 2799: database update to "branch transfer limits"

This patch cleans up kohastructure.sql a bit:
 * moved the table definition to above the ending comments
 * added a "drop table..." statement

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoAdded 'Branch Transfer Limits' Feature requested by Geauga County Library System.
Kyle Hall [Wed, 17 Dec 2008 20:09:24 +0000 (14:09 -0600)]
Added 'Branch Transfer Limits' Feature requested by Geauga County Library System.

Added syspref to updatedatabase.

Updated kohastructure.sql with the limits table.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agowhitespace cleanup - admin/systempreferences.pl
Galen Charlton [Wed, 17 Dec 2008 15:53:40 +0000 (09:53 -0600)]
whitespace cleanup - admin/systempreferences.pl

applied xt/perltidyrc to admin/systempreferences.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2860: allow setting of a syspref value to '0'
Galen Charlton [Wed, 17 Dec 2008 15:53:39 +0000 (09:53 -0600)]
bug 2860: allow setting of a syspref value to '0'

Fixed invalid test for the existence of CGI parameter; if it
is possible that the value of a parameter can be 0, it is
not sufficient to test like this:

if ($input->param('foo')) { ...

since the test will fail for *any* value that evaluates
to Perl false.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2505: turn on warnings in admin/systemprefernces.pl
Galen Charlton [Wed, 17 Dec 2008 15:53:38 +0000 (09:53 -0600)]
bug 2505: turn on warnings in admin/systemprefernces.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2867 [2/2]: db changes for single-screen syspref editing
Jesse Weaver [Mon, 10 Nov 2008 22:20:06 +0000 (16:20 -0600)]
bug 2867 [2/2]: db changes for single-screen syspref editing

Database revision 007.

[Includes a correction by Galen Charlton]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2867 [1/2]: Move basic editing to main system preferences screen
Jesse Weaver [Wed, 17 Dec 2008 15:53:37 +0000 (09:53 -0600)]
bug 2867 [1/2]: Move basic editing to main system preferences screen

This allows the user to edit system preferences from the main system
preferences screen, rather than having to dig down into each
preference.

[This patch includes some modifications by Galen Charlton
 to fix XHTML validation errors and a couple errors that
 would crop up under warnings.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2824: improving error messages from test suite errors
Andrew Moore [Wed, 17 Dec 2008 14:39:17 +0000 (08:39 -0600)]
bug 2824: improving error messages from test suite errors

This patch adds two warning messages to places in the test suite that
may fail. I don't think it changes any functionality, but it sure makes
it easier to figure out what has gone wrong.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agofixed "too many opened files" error during translation
Marc Chantreux [Fri, 12 Dec 2008 17:13:14 +0000 (18:13 +0100)]
fixed "too many opened files" error during translation

The problem was that the TmplTokenizer create global symbols to store file
handlers so the objects aren't destroyed by the garbage collector.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2864 [2/2]: move rss/* to misc/cronjobs/rss/*
Galen Charlton [Mon, 15 Dec 2008 15:58:47 +0000 (09:58 -0600)]
bug 2864 [2/2]: move rss/* to misc/cronjobs/rss/*

As rss.pl is not a CGI script, moved it to join the
other cronjobs.  Full documentation of the script
is in misc/cronjobs/rss/rss.pl, but to summarize:

[1] rss.pl is run on the command line to produce
    an RSS XML document.  The output should be
    placed in a directory accessible to the OPAC
    (or staff) web interface so that users can download
    the RSS feed.  An example of usage:

    misc/cronjobs/rss.pl lastAcquired.conf

    Normally rss.pl should be run periodically (e.g., daily)
    to keep the feed up-to-date.

[2] The configuration file (e.g., lastAcquired.conf) lists

    * name of the template file to use
    * path of output file
    * SQL query

    rss.pl runs the SQL query, then feeds the output of the
    query through the template to produce the output file.

[3] The template file (e.g., lastAcquired.tmpl) uses
    HTML::Template syntax like any of the HTML
    templates for the web interface.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2864 [1/2]: restore rss/rss.pl
Galen Charlton [Mon, 15 Dec 2008 15:58:46 +0000 (09:58 -0600)]
bug 2864 [1/2]: restore rss/rss.pl

Restored basic functionality of rss/rss.pl:

[1] Reverted "Add support for itemtypes. Still need to hardcode 'reservable'"
    Revert commit e7575b00edd6098a869425a69856916108e84914, which had
    replace the script with one of its templates.

[2] Minor fixes to update it, including using HTML::Template::Pro instead
    of HTML::Template, perltidy, and turning on warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2859: add index on bibioitems.issn (DB rev 006)
Galen Charlton [Thu, 11 Dec 2008 17:59:55 +0000 (11:59 -0600)]
bug 2859: add index on bibioitems.issn (DB rev 006)

Because of a query on biblioitems.issn in
C4::Breeding::ImportBreeding(), libraries doing a lot
of bib imports were experiencing performance problems,
which adding an index will alleviate.

A possible longer term solution is to index all
reservoir/import batch records in a Zebra database.

[LL bug 232]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agominor fixes to UNIMARC_sync_date_created_with_marc_biblio.pl
Galen Charlton [Thu, 11 Dec 2008 16:36:04 +0000 (10:36 -0600)]
minor fixes to UNIMARC_sync_date_created_with_marc_biblio.pl

- chmod 0755
- add newline in error message shown if attempting to
  run in MARC21 database

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoUpdate MARC to add 099$c and 099$d fields, with :
Henri-Damien LAURENT [Fri, 21 Nov 2008 21:37:59 +0000 (22:37 +0100)]
Update MARC to add 099$c and 099$d fields, with :

This allow the acquisition date sorting in UNIMARC.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoAdd default classification sources and filing rules to fr-FR
Frederic Demians [Mon, 17 Nov 2008 16:38:46 +0000 (17:38 +0100)]
Add default classification sources and filing rules to fr-FR

fr-FR install wasn't populating classication rules tables:

  * class_sort_rules
  * class_sources

This patch add default values for those tables
mandatory during installation process.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2841: add an hidden field with booksellerid
Nahuel Angelinetti [Wed, 3 Dec 2008 16:52:39 +0000 (17:52 +0100)]
bug 2841: add an hidden field with booksellerid

The bug throw because the booksellerid is not in the request, and the newordersuggestion.pl need this one to import
it in a new order.
So I just added an hidden input in the search form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2827: better language check
Nahuel Angelinetti [Thu, 27 Nov 2008 13:43:21 +0000 (14:43 +0100)]
bug 2827: better language check

This patch use a regexp instead 'eq' to find if french is an opaclanguage.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years ago(bug #2831) Add a variable, that create a js error, and make the script not working.
Nahuel ANGELINETTI [Thu, 11 Dec 2008 15:48:16 +0000 (16:48 +0100)]
(bug #2831) Add a variable, that create a js error, and make the script not working.

the variable added is numberpattern, and is get from the document.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2829: add a plugin for 010$a field and 210$c
Nahuel Angelinetti [Thu, 11 Dec 2008 15:39:27 +0000 (16:39 +0100)]
bug 2829: add a plugin for 010$a field and 210$c

This plugin use the 'ISBN' field(010$a) to search the "publishercode"(editor) and set it in as 210$c.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoadd calls to clear_syspref_cache()
Galen Charlton [Thu, 11 Dec 2008 15:48:37 +0000 (09:48 -0600)]
add calls to clear_syspref_cache()

temporary until mutator for sysprefs created

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoAdding some fixing for NoZebra
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:15 +0000 (14:58 +0100)]
Adding some fixing for NoZebra

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug in rebuild_zebra verbose logging - found another print I didn't want to see all...
Michael Hafen [Fri, 21 Nov 2008 16:34:44 +0000 (09:34 -0700)]
bug in rebuild_zebra verbose logging - found another print I didn't want to see all the time

Add the phrase 'if ( $verbose_logging )' to the two print statements
concerning the skipping of biblio or authority records.

I recently had to split biblio and authority index updating in my cron
script ( had some really big records so had to add the -x switch which
should only be used on biblios accourding to the help ).  So I noticed
that rebuild_zebra.pl printed messages that it was skipping biblios or
authorities.

This patch is to conditionalize those prints based on the verbose
logging switch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2689: Fix the checked box "manual history" and fix the "null" value of serial...
Nahuel Angelinetti [Fri, 17 Oct 2008 13:45:27 +0000 (15:45 +0200)]
bug 2689: Fix the checked box "manual history" and fix the "null" value of serial next issue publication date

first part of this patch is the manual history must be checked if in database its checked.
Then, when you do not enter a value "Next issue publication date", a null value was set in the database, now, if empty, the  "first issue date" is set as "next issue".
And finally, We check that "manual history" is checked to show the "Subscription history" part. Actually its never shown.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoMissing ";" in javascript
Nahuel Angelinetti [Tue, 9 Dec 2008 10:23:14 +0000 (11:23 +0100)]
Missing ";" in javascript

This patch fix a missing ; in javascript, that open the renew popup. Instead it open it in the current window.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoFix something that doesn't work in some perl versions.
Nahuel Angelinetti [Wed, 10 Dec 2008 09:24:36 +0000 (10:24 +0100)]
Fix something that doesn't work in some perl versions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years ago(bug #2853) fix an error in returned string
Nahuel Angelinetti [Tue, 9 Dec 2008 14:15:43 +0000 (15:15 +0100)]
(bug #2853) fix an error in returned string

this patch delete the last char of the returned string, that is not conform to unimarc, only one blankchar must be at the end of
the leader string.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2505: enable warnings for opac/sco/sco-main.pl
Galen Charlton [Mon, 8 Dec 2008 14:45:39 +0000 (08:45 -0600)]
bug 2505: enable warnings for opac/sco/sco-main.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agoMinor cleanup, unused variable removed.
Joe Atzberger [Mon, 8 Dec 2008 17:42:47 +0000 (11:42 -0600)]
Minor cleanup, unused variable removed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2857: fix UTF-8 conversion issues in web services
Galen Charlton [Wed, 10 Dec 2008 20:02:17 +0000 (14:02 -0600)]
bug 2857: fix UTF-8 conversion issues in web services

svc/bib and svc/new_bib had two problems related to UTF-8 character conversion:

[1] Couple instances of "Wide character" warnings
[2] When saving a new (MARC21) bib whose Leader/09 was not 'a', did not apply
default character conversion and set the Leader/09 to 'a'.

Fix includes two parts:

[1] Setting :utf8 on STDOUT
[2] Doing default MARC-8 to UTF-8 conversion if applicable

This patch also turns on warnings in all scripts under svc per bug 2505.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2505: turned on warnings for suggestion/acceptorreject.pl
Galen Charlton [Wed, 10 Dec 2008 23:30:03 +0000 (17:30 -0600)]
bug 2505: turned on warnings for suggestion/acceptorreject.pl

Also fixed case where HTML could have unclosed <form> elements,
leading to warnings in the error log when accepting pending
or rejected suggestions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2505: turn on warnings in reviews/reviewswaiting.pl
Galen Charlton [Wed, 10 Dec 2008 23:36:56 +0000 (17:36 -0600)]
bug 2505: turn on warnings in reviews/reviewswaiting.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
11 years agobug 2505: turn on warnings in two scripts
Galen Charlton [Thu, 11 Dec 2008 14:26:10 +0000 (08:26 -0600)]
bug 2505: turn on warnings in two scripts

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>