wip/koha-chris_n.git
8 years agoBug 4506: Add link to volumes of traced series to series record
Katrin Fischer [Mon, 27 Sep 2010 04:17:16 +0000 (06:17 +0200)]
Bug 4506: Add link to volumes of traced series to series record

Changed link to volumes of sets to work for traced series too.
Now if the user finds a series or set record in the database,
there is always a link to search for the associated recos with items.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>

8 years agoBug 4506: Traced series
Katrin Fischer [Mon, 27 Sep 2010 03:57:16 +0000 (05:57 +0200)]
Bug 4506: Traced series

Add separate display of traced series.
Use $w and index rcn for link if $w exists, else show text link.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>

8 years agoBug 4506: Add links to other editions, some minor corrections
Katrin Fischer [Sun, 26 Sep 2010 23:55:45 +0000 (01:55 +0200)]
Bug 4506: Add links to other editions, some minor corrections

A new label 'Other editions:' is added with links to other editions.
The link starts a search for control number from 775$w in index control number.

A check for existence of $w/001 is added to always provide a fallback to a search for the link text.

Take care of repeated 773 fields.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>

8 years agoBug 4506: Add volume > set link
Katrin Fischer [Sun, 26 Sep 2010 21:42:07 +0000 (23:42 +0200)]
Bug 4506: Add volume > set link

A new label 'Set:' is added with a link to the set.
The link starts a search for control number from 773$w in index control number.
A syspref UseControlNumber will be added later, to provide a fallback to a search by 245$a, which is also the title of the set.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>

8 years agoBug 4506: Add set > volume link
Katrin Fischer [Sun, 26 Sep 2010 21:21:43 +0000 (23:21 +0200)]
Bug 4506: Add set > volume link

A new label 'Volumes:' is added with a link 'Show volumes'.
The link starts a search fcontrol number from 001 in index rcn = Record control number.
A syspref UseControlNumber will be added later, to provide a fallback to a search by title.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>

8 years agoBug 4506: New icon for sets
Katrin Fischer [Sun, 26 Sep 2010 20:44:15 +0000 (22:44 +0200)]
Bug 4506: New icon for sets

Show an own icon for sets - LDR 19 = a

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>

8 years agoBUG 4506: Add 8xx $w subfields to MARC-Frameworks de-DE
Katrin Fischer [Thu, 17 Jun 2010 15:28:07 +0000 (17:28 +0200)]
BUG 4506: Add 8xx $w subfields to MARC-Frameworks de-DE

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>

8 years agoBug 4506: Some work on article to serial links
Katrin Fischer [Sun, 26 Sep 2010 19:35:34 +0000 (21:35 +0200)]
Bug 4506: Some work on article to serial links

- changes search links to use Title index
- show article icon in intranet like in opac

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>

8 years agoBUG 4506: Add 8xx $w subfields to MARC-Frameworks pl-PL
Katrin Fischer [Sun, 23 May 2010 14:36:29 +0000 (16:36 +0200)]
BUG 4506: Add 8xx $w subfields to MARC-Frameworks pl-PL

ru-RU and uk-UA have no files for MARC21

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>

8 years agoBUG 4506: Add 8xx $w subfields to MARC-Frameworks en, fr-FR
Katrin Fischer [Fri, 21 May 2010 16:00:05 +0000 (18:00 +0200)]
BUG 4506: Add 8xx $w subfields to MARC-Frameworks en, fr-FR

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>

8 years agoBug 4506: Add index Record-control-number = rcn for indexing of $w subfields
Katrin Fischer [Fri, 14 May 2010 16:01:56 +0000 (18:01 +0200)]
Bug 4506: Add index Record-control-number = rcn for indexing of $w subfields

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>

8 years agoIncremental fix for Bug 3285 - Location on Add Subscription should be pull down
Owen Leonard [Mon, 6 Dec 2010 11:56:12 +0000 (11:56 +0000)]
Incremental fix for Bug 3285 - Location on Add Subscription should be pull down

- Adds location dropdown to subscription edit form
- Pulls authorised value for display on subscription detail page
- Adds function for pulling authorised value description based
  on category and value

This patch does NOT implement automatic preselection of the shelving
location form field on the serial add item screen. This must be
worked out in order for the bug to be closed.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoBug 5460: AutoEmailPrimaryAddress set to invalid value in sysprefs.sql
Ian Walls [Thu, 2 Dec 2010 14:45:29 +0000 (09:45 -0500)]
Bug 5460: AutoEmailPrimaryAddress set to invalid value in sysprefs.sql

Fixes de-DE, en, fr-FR, pl-PL, ru-RU and uk-UA default install values for this system preference (changing from '0'
to 'OFF', the preferred value).

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoBug 5457: gather_print_notices.pl requires explicit stylesheet
Ian Walls [Thu, 2 Dec 2010 14:29:27 +0000 (09:29 -0500)]
Bug 5457: gather_print_notices.pl requires explicit stylesheet

Adds a conditional around the opening and closing of STYLESHEET, testing on whether the $stylesheet variable is set
or not.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agobug 5397: display renew count consistently
Galen Charlton [Sat, 13 Nov 2010 03:00:27 +0000 (22:00 -0500)]
bug 5397: display renew count consistently

Display the renewal count for loans consistently; in particular,
for loans that have never been renewed, display 0.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoMerge remote branch 'kc/new/enh/bug_4983' into kcmaster
Chris Cormack [Thu, 2 Dec 2010 23:55:25 +0000 (12:55 +1300)]
Merge remote branch 'kc/new/enh/bug_4983' into kcmaster

8 years agoMerge remote branch 'kc/new/bug_4851' into kcmaster
Chris Cormack [Thu, 2 Dec 2010 23:55:20 +0000 (12:55 +1300)]
Merge remote branch 'kc/new/bug_4851' into kcmaster

8 years agoFix for Bug 4983 - Add edit record / edit item links to search results
Owen Leonard [Sat, 13 Nov 2010 18:06:50 +0000 (13:06 -0500)]
Fix for Bug 4983 - Add edit record / edit item links to search results

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoFix for Bug 4851 - Batch delete shouldn't show delete button if no items were found
Owen Leonard [Sat, 13 Nov 2010 18:42:35 +0000 (13:42 -0500)]
Fix for Bug 4851 - Batch delete shouldn't show delete button if no items were found

- Adding template flag to indicate valid results (hidden or not)
 - Clarifying warning messages based on various outcomes

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agobug 4908: rename temlate variable to branchname
Galen Charlton [Sat, 13 Nov 2010 19:08:59 +0000 (14:08 -0500)]
bug 4908: rename temlate variable to branchname

Using branchname is more accurate and could avoid
a bug if/when the patron update function is made more
sophisticated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoFix for Bug 4908 - OPAC patron details page doesn't show patron's home library
Owen Leonard [Sat, 13 Nov 2010 19:08:58 +0000 (14:08 -0500)]
Fix for Bug 4908 - OPAC patron details page doesn't show patron's home library

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoBug 5104: Add control number as search option to acq z39.50 search
Katrin Fischer [Thu, 2 Dec 2010 12:45:13 +0000 (12:45 +0000)]
Bug 5104: Add control number as search option to acq z39.50 search

Adds control number as search option to z39.50 search in acquisitions.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoFix for Bug 5048, Error in menu/submenu for select language in intranet
Owen Leonard [Sat, 13 Nov 2010 19:14:39 +0000 (14:14 -0500)]
Fix for Bug 5048, Error in menu/submenu for select language in intranet

Patch for HEAD. This issue was apparently solved quite a while
ago in the OPAC. This patch copies that solution over to the staff client.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoMerge remote branch 'kc/new/bug_5030' into kcmaster
Chris Cormack [Wed, 1 Dec 2010 20:20:14 +0000 (09:20 +1300)]
Merge remote branch 'kc/new/bug_5030' into kcmaster

8 years agoFix for Bug 5030 - Improve handling of duplicate patrons
Owen Leonard [Sat, 13 Nov 2010 19:34:42 +0000 (14:34 -0500)]
Fix for Bug 5030 - Improve handling of duplicate patrons

- Making duplicate patron warning dialog simpler but more explicit
- Pointing duplicate patron preview window to new brief version
  of moremember.pl to display more patron details than the previous
  version.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoMerge remote branch 'kc/new/bug_5029' into kcmaster
Chris Cormack [Wed, 1 Dec 2010 20:14:49 +0000 (09:14 +1300)]
Merge remote branch 'kc/new/bug_5029' into kcmaster

8 years agoFix for Bug 5029 - Update patron deletion error page
Owen Leonard [Sat, 13 Nov 2010 19:42:05 +0000 (14:42 -0500)]
Fix for Bug 5029 - Update patron deletion error page

- Styling error message with "dialog alert" class
- Adding sidebar patron details to match other patron pages

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agobug 5405: remove disused script catalogue/suggest.pl
Galen Charlton [Sun, 14 Nov 2010 03:37:10 +0000 (22:37 -0500)]
bug 5405: remove disused script catalogue/suggest.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoMerge remote branch 'kc/new/bug_5142' into kcmaster
Chris Cormack [Wed, 1 Dec 2010 20:04:09 +0000 (09:04 +1300)]
Merge remote branch 'kc/new/bug_5142' into kcmaster

8 years agoFurther fixes for Bug 5142 - Untranslatable strings in tag review template
Owen Leonard [Fri, 19 Nov 2010 00:37:16 +0000 (19:37 -0500)]
Further fixes for Bug 5142 - Untranslatable strings in tag review template

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoBug 5444 Fix misc/translate script for 'standard' Koha install
Frédéric Demians [Thu, 25 Nov 2010 07:55:05 +0000 (08:55 +0100)]
Bug 5444 Fix misc/translate script for 'standard' Koha install

[3.2] Should apply

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoAdding 3.2.1 release to the history
Chris Cormack [Thu, 25 Nov 2010 20:18:06 +0000 (09:18 +1300)]
Adding 3.2.1 release to the history

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoFixing formatting and links in the history document
Chris Cormack [Thu, 25 Nov 2010 20:05:39 +0000 (09:05 +1300)]
Fixing formatting and links in the history document

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoFix some compile time errors reported in test suite
Colin Campbell [Fri, 26 Nov 2010 14:39:18 +0000 (14:39 +0000)]
Fix some compile time errors reported in test suite

redeclaration of itemnumber in RotatingCollections
A couple of errors caused by retaining commas in qw()

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoMerge remote branch 'kc/new/bug_5448' into kcmaster
Chris Cormack [Wed, 1 Dec 2010 19:52:49 +0000 (08:52 +1300)]
Merge remote branch 'kc/new/bug_5448' into kcmaster

8 years agoBug 5448: Refactor Boolean.pm
Colin Campbell [Fri, 26 Nov 2010 16:31:35 +0000 (16:31 +0000)]
Bug 5448: Refactor Boolean.pm

Remove unnecesssary export
Use Exporter according to best practices
Use Carp not warn so we know where the error string came from
Don't create warnings manipulating undefined input
Replace package variables by lexicals

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoBug 5448 Use Test::More in Boolean.t
Colin Campbell [Fri, 26 Nov 2010 16:31:34 +0000 (16:31 +0000)]
Bug 5448 Use Test::More in Boolean.t

Use Test::More's structure as more readable
Replaced a test of an used function with a use_ok test
of the module

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoBug 4449: AllowHoldPolicyOverride does not override all hold policies
Ian Walls [Tue, 30 Nov 2010 07:19:49 +0000 (02:19 -0500)]
Bug 4449: AllowHoldPolicyOverride does not override all hold policies

This patch provides a universal override to any hold policy if the AllowHoldPolicyOverride is set.
Amongst other overrides, this patch allows missing, non-checked out items to be placed on hold even with AllowShelfHolds turned off.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoFixes bug 5232: Shelfname won't display on high-numbered lists
Ian Walls [Tue, 30 Nov 2010 07:25:30 +0000 (02:25 -0500)]
Fixes bug 5232: Shelfname won't display on high-numbered lists

This bugfix adds an explicit GetShelf for the specific shelfnumber when viewing that individual shelfnumber.  This captures the
shelfname, which was originally pulled from shelflist->{$shelfnumber}, which may not have been populated if the List in question was
beyond the 20th private or public list in the system.

Also adds a more explicit sort: the sort from the CGI takes top priority, then it falls back to the default sort for the list, and
ultimate falls to 'title' if neither CGI nor default sort exist.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoBug 5450 Avoid a name clash in ILSDI modules
Colin Campbell [Fri, 26 Nov 2010 17:27:13 +0000 (17:27 +0000)]
Bug 5450 Avoid a name clash in ILSDI modules

C4::ILSDI::Utility exports a subroutine CanBookBeReserved
Both ILSDI were also importing a subroutine of that name from
C4::Reserves Remove conflict by listing subroutines
imported from C4::Reserves explicitly

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoFix for Bug 5402, "add to cart" shown on checkbox hover
Owen Leonard [Tue, 30 Nov 2010 15:14:23 +0000 (10:14 -0500)]
Fix for Bug 5402, "add to cart" shown on checkbox hover

This patch removes the title hint altogether. The checkbox might
be used for the cart, lists, holds, or tags, and expressing this
in a title hint seems overly complicated.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agobug 4451 followup - don't need /g for this replace
Galen Charlton [Sat, 13 Nov 2010 17:58:55 +0000 (12:58 -0500)]
bug 4451 followup - don't need /g for this replace

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoFix for Bug 4451 Batch item tool can't process file with Windows line endings
Owen Leonard [Sat, 13 Nov 2010 17:58:54 +0000 (12:58 -0500)]
Fix for Bug 4451 Batch item tool can't process file with Windows line endings

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoFix for Bug 4981, Tweak style of item listing on MARC display
Owen Leonard [Sat, 13 Nov 2010 17:55:02 +0000 (12:55 -0500)]
Fix for Bug 4981, Tweak style of item listing on MARC display

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoFix for Bug 5051, Renewal due date doesn't always show on patron Checkout tab
Owen Leonard [Sat, 13 Nov 2010 03:00:26 +0000 (22:00 -0500)]
Fix for Bug 5051, Renewal due date doesn't always show on patron Checkout tab

Display of the renewal date footer in the template was conditional upon
the existence of checkouts from today.

In order to fix this bug it was necessary to repeat the markup for the
table footer twice in the template, so I created an include file for it.
The same include file can now be used in moremember.tmpl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoFix for Bug 5269 - link to patron edit form when editing turned off
Owen Leonard [Fri, 12 Nov 2010 21:12:11 +0000 (16:12 -0500)]
Fix for Bug 5269 - link to patron edit form when editing turned off

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoMerge remote branch 'kc/new/bug_5281' into kcmaster
Chris Cormack [Mon, 29 Nov 2010 19:17:40 +0000 (08:17 +1300)]
Merge remote branch 'kc/new/bug_5281' into kcmaster

8 years agoFix for Bug 5281, "Check in" then "Renew" checkboxes checked in the same time
Owen Leonard [Fri, 12 Nov 2010 20:59:47 +0000 (15:59 -0500)]
Fix for Bug 5281, "Check in" then "Renew" checkboxes checked in the same time

This fix corrects the behavior of the checkboxes whether the user clicks the
checkbox itself or the <td> around it. Tested on a PC in Firefox 3.6, Chrome,
Safari 5, and IE 8.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoMerge remote branch 'kc/new/enh/bug_5430' into kcmaster
Chris Cormack [Mon, 29 Nov 2010 18:02:18 +0000 (07:02 +1300)]
Merge remote branch 'kc/new/enh/bug_5430' into kcmaster

8 years agoBug 5430: Follow-up, fixes error message when no 001 exists
Katrin Fischer [Sun, 28 Nov 2010 12:40:36 +0000 (13:40 +0100)]
Bug 5430: Follow-up, fixes error message when no 001 exists

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agobug 5217 incrementing db version number
Chris Cormack [Mon, 29 Nov 2010 17:57:09 +0000 (06:57 +1300)]
bug 5217 incrementing db version number

8 years agobug 5127: database update to add the suggestion notification templates
Galen Charlton [Sat, 13 Nov 2010 21:50:30 +0000 (16:50 -0500)]
bug 5127: database update to add the suggestion notification templates

Being especially careful to not scribble over any ones
that the library might have already defined.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

8 years agobug 5127: sample notice templates for suggestions
Galen Charlton [Sat, 13 Nov 2010 21:35:43 +0000 (16:35 -0500)]
bug 5127: sample notice templates for suggestions

* supply default suggestion status change email
  templates.
* remove the deprecated mail_suggestion_*.tmpl files

There are a couple suggestion statuses referred to
in the code and suggestion management page that currently
do not have notice templates defined: ASK and CHECKED.  These
seem to be internal, so perhaps default message templates
are not needed for these.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

8 years agobug 4211: ensure that suggestion emails have full details
Galen Charlton [Sat, 13 Nov 2010 21:27:47 +0000 (16:27 -0500)]
bug 4211: ensure that suggestion emails have full details

Because of how the ModFoo routines work, if you are only
changing selected columns but are also using the change
as a trigger to place a message in the queue, you need
to fetch the full row before generating the message.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

8 years agobug 4211: more fixes to suggestion letter template handling
Galen Charlton [Sat, 13 Nov 2010 20:43:27 +0000 (15:43 -0500)]
bug 4211: more fixes to suggestion letter template handling

* Now displays the correct list of fields to choose
  for suggestion letters.
* Clean up mixture of old and new column selection code
  introduced in commit 88bb1b63, thereby restoring
  the intent of the patch for bug 3522.
* Enable suggestion library to be used in suggestion
  letter templates

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

8 years agoBug 4211: This patch should provide a working way to send out mail from suggestions
Chris Cormack [Thu, 12 Aug 2010 21:44:46 +0000 (09:44 +1200)]
Bug 4211: This patch should provide a working way to send out mail from suggestions

Your suggestion notices template needs to contain things like
<<suggestions.title>>
<<suggestions.author>>
etc

Squashed commit of the following:

commit 3f4278bbe8d4c68be9f72d50e1eef6a411dc873d
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Fri Aug 13 09:41:34 2010 +1200

    bug 4211 parsing the letter before we enqueue it

commit ecdc0ff34c1aa9b96b68d541423ca693e2d63e67
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Fri Aug 13 09:32:09 2010 +1200

    Changing the query to fetch suggestions data, this is needed for suggestion mail to be sent

commit ece11d015b945ce119cf7cbc5e2563f4bc8aecf9
Author: Owen Leonard <oleonard@myacpl.org>
Date:   Thu Aug 12 12:36:26 2010 -0400

    Fix for Bug 4211, Acquisitions actions on suggestions don't generate email

    Assuming 1) The patch for Bug 5126 is approved and 2) Suggestions
    notices are added by hand (or from default sql--see Bug 5127) this
    correction should get suggestions notices properly enqueued.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

commit 5c3bbe7d557b1994be72518746217fc6fc4e5b83
Author: Owen Leonard <oleonard@myacpl.org>
Date:   Thu Aug 12 12:27:33 2010 -0400

    Fix for Bug 5126 - Suggestions module missing from "add notice" form

    - Adding "suggestions" entry
    - Re-ordering options in alphabetical order

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

8 years agoBug 5430: Add Control number as option to OPACSearchForTitleIn
Katrin Fischer [Wed, 24 Nov 2010 16:35:43 +0000 (11:35 -0500)]
Bug 5430: Add Control number as option to OPACSearchForTitleIn

Makes {CONTROLNUMBER} available as new placeholder in
system preference OPACSearchForTitleIn.

{CONTROLNUMBER} will be replaced by the number in tag 001.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

8 years agoMerge remote branch 'kc/new/bug_5175' into kcmaster
Chris Cormack [Sat, 20 Nov 2010 21:44:16 +0000 (10:44 +1300)]
Merge remote branch 'kc/new/bug_5175' into kcmaster

8 years agoBug 5175: Publisher link breaks display, if no publisher exists
Katrin Fischer [Sat, 20 Nov 2010 13:00:01 +0000 (14:00 +0100)]
Bug 5175: Publisher link breaks display, if no publisher exists

If there is no publisher the empty publisher link will break the record display
in staff and intranet.

This patch adds a check for existence of subfield b.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoMerge remote branch 'kc/new/bug_5004' into kcmaster
Chris Cormack [Thu, 18 Nov 2010 20:53:19 +0000 (09:53 +1300)]
Merge remote branch 'kc/new/bug_5004' into kcmaster

9 years agoAnother bug 5004 fix, this time for road types
Owen Leonard [Mon, 15 Nov 2010 23:13:32 +0000 (18:13 -0500)]
Another bug 5004 fix, this time for road types

The road types interface didn't block deletion of road
types in use, but the script included the same queries
that cities.pl did, as if it intended to.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoFix for Bug 5004, Don't block deletion of cities when instances exist in borrowers...
Owen Leonard [Mon, 15 Nov 2010 13:09:11 +0000 (08:09 -0500)]
Fix for Bug 5004, Don't block deletion of cities when instances exist in borrowers table

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoBug 4440: Fixing template syntax errors
Chris Cormack [Thu, 18 Nov 2010 02:29:04 +0000 (15:29 +1300)]
Bug 4440: Fixing template syntax errors

9 years agoBug 4440 Follow-up for English typography and alignment
Frédéric Demians [Tue, 16 Nov 2010 07:33:10 +0000 (08:33 +0100)]
Bug 4440 Follow-up for English typography and alignment

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoBug 4440 Layout tweaking follow-up patch
Koustubha Kale [Tue, 16 Nov 2010 07:33:09 +0000 (08:33 +0100)]
Bug 4440 Layout tweaking follow-up patch

Couple of tweaks to borders and Name.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoBug 4440: Revised combined patch to print fee receipts and invoices
Koustubha Kale [Tue, 16 Nov 2010 07:33:08 +0000 (08:33 +0100)]
Bug 4440: Revised combined patch to print fee receipts and invoices

This patch adds a small enhancement to allow printing of Fees  / Fines
receipts from the Fines page.

Patch adds print links to the Fines page next to Fines or Receipts
transactions.

Clicking on the link will pop a new window and will print that with
total outstanding as on date.

You can edit koha-tmpl/intranet-tmpl/prog/en/css/printreceiptinvoice.css
to better control printing this type of material.

18-Oct-2010 Changed template and script names to match. Corrected
invalid markup in the templates.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoBug 5412 double quotes break coins and thus search results in some scenarios
Tomás Cohen Arazi [Wed, 17 Nov 2010 14:43:10 +0000 (09:43 -0500)]
Bug 5412 double quotes break coins and thus search results in some scenarios

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoBug 5204 Followup
Frédéric Demians [Mon, 15 Nov 2010 23:11:09 +0000 (18:11 -0500)]
Bug 5204 Followup

- Typo
- Duplicate 955 tag

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agobug 5204: Unimarc XSLT, from French to English.
Zeno0 Tajoli [Mon, 15 Nov 2010 17:47:27 +0000 (18:47 +0100)]
bug 5204: Unimarc XSLT, from French to English.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoGerman and italian language updates
Chris Cormack [Wed, 17 Nov 2010 22:28:52 +0000 (11:28 +1300)]
German and italian language updates

9 years agoMerge remote branch 'kc/new/bug_5066' into kcmaster
Chris Cormack [Wed, 17 Nov 2010 20:43:25 +0000 (09:43 +1300)]
Merge remote branch 'kc/new/bug_5066' into kcmaster

9 years agoBug 5066 (Log timestamp consistently in _session_log)
Marcel de Rooy [Wed, 17 Nov 2010 12:18:00 +0000 (12:18 +0000)]
Bug 5066 (Log timestamp consistently in _session_log)

Small fix with thanks to Galen.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoBug 2122 follow-up for authorities editor
Owen Leonard [Mon, 15 Nov 2010 23:19:26 +0000 (18:19 -0500)]
Bug 2122 follow-up for authorities editor

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoFix for Bug 2122, Grayed out Fields not always visible
Owen Leonard [Mon, 15 Nov 2010 13:02:48 +0000 (08:02 -0500)]
Fix for Bug 2122, Grayed out Fields not always visible

- Adding "readonly" class to readonly fields to guarantee
  that readonly state is indicated visually
- Adding "locked" icon to the background of readonly
  fields for additional visual feedback

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoFix for Bug 5152 - confirm buttons different styles on lists
Owen Leonard [Tue, 16 Nov 2010 23:33:49 +0000 (18:33 -0500)]
Fix for Bug 5152 - confirm buttons different styles on lists

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoFix for Bug 5037 - If patron category is empty it shouldn't show
Owen Leonard [Tue, 16 Nov 2010 23:43:43 +0000 (18:43 -0500)]
Fix for Bug 5037 - If patron category is empty it shouldn't show

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoFix for Bug 3013, Value builder for 006 and 008 need choices for all format types
Owen Leonard [Tue, 16 Nov 2010 23:52:36 +0000 (18:52 -0500)]
Fix for Bug 3013, Value builder for 006 and 008 need choices for all format types

This partial fix adds a complete list of values for 006/00, "Form of material,"
following the list found here: http://www.loc.gov/marc/bibliographic/bd006.html

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoBug 4074 Fix fail to parse simple qualified search
Colin Campbell [Wed, 17 Nov 2010 00:33:38 +0000 (19:33 -0500)]
Bug 4074 Fix fail to parse simple qualified search

Searches such as au,phr and kw,wrdl were passing through the regexes
that should replace colon with equals
add wrdl and phr
use trn so not just rtrn is spotted
Where we were checking for multiple spaces specify that in the
regex not just two spaces

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoBrooke caught my april fools trick, its not 20004 yet!
Chris Cormack [Mon, 15 Nov 2010 12:55:43 +0000 (07:55 -0500)]
Brooke caught my april fools trick, its not 20004 yet!

Ok it wasn't an april fools trick, but just a typo, april fools trick
sounds better though right?

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoMerge remote branch 'kc/new/enh/bug_4866' into kcmaster
Chris Cormack [Mon, 15 Nov 2010 08:34:39 +0000 (21:34 +1300)]
Merge remote branch 'kc/new/enh/bug_4866' into kcmaster

9 years agobug 4866 follow-up - minor code formatting cleanup
Galen Charlton [Sat, 13 Nov 2010 17:05:47 +0000 (12:05 -0500)]
bug 4866 follow-up - minor code formatting cleanup

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoBug 4866 for master (Enable Change event for item plugins)
Marcel de Rooy [Sat, 13 Nov 2010 17:05:46 +0000 (12:05 -0500)]
Bug 4866 for master (Enable Change event for item plugins)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoCorrected patch for Bug 4520, facets "show more" doesn't work
Owen Leonard [Sat, 13 Nov 2010 04:22:24 +0000 (23:22 -0500)]
Corrected patch for Bug 4520, facets "show more" doesn't work

Re-doing Nahuel's fix so that it applies to master

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoFix for Bug 4913 - Budget pages should show currency name instead of symbol
Owen Leonard [Sat, 13 Nov 2010 03:53:23 +0000 (22:53 -0500)]
Fix for Bug 4913 - Budget pages should show currency name instead of symbol

This patch adds a new include file to handle the display of the active
currency name and a warning if no currency is active.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoFix for Bug 4912 - After editing private list redirect to private lists
Owen Leonard [Sat, 13 Nov 2010 03:48:41 +0000 (22:48 -0500)]
Fix for Bug 4912 - After editing private list redirect to private lists

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoFix for Bug 5175, XSL view doesn't link publisher name to search
Owen Leonard [Fri, 12 Nov 2010 22:03:42 +0000 (23:03 +0100)]
Fix for Bug 5175, XSL view doesn't link publisher name to search

Fixes the doubled up display of the publisher.

This patch fixes the bug in both the OPAC and staff client

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoFix for Bug 5210, back button on batch modification result page useless
Owen Leonard [Fri, 12 Nov 2010 20:58:00 +0000 (21:58 +0100)]
Fix for Bug 5210, back button on batch modification result page useless

I can't see any good use for a back button here, so I'm taking it out.

An improvement might be to build in a method to resubmit the same batch
of barcodes/item numbers again so that you could make additional
changes to the same set.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoMerge remote branch 'kc/new/bug_5381' into kcmaster
Chris Cormack [Sun, 14 Nov 2010 09:27:33 +0000 (22:27 +1300)]
Merge remote branch 'kc/new/bug_5381' into kcmaster

9 years agoBug 5381 - Fines in notices prints always 0.00
Chris Nighswonger [Fri, 12 Nov 2010 15:30:45 +0000 (16:30 +0100)]
Bug 5381 - Fines in notices prints always 0.00

This was due to passing off the biblionumber to GetFines rather than the itemnumber.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoAdditional fix for Bug 4423 - Staff Client XSLT is just a copy of the OPAC one
Owen Leonard [Sat, 13 Nov 2010 20:00:22 +0000 (15:00 -0500)]
Additional fix for Bug 4423 - Staff Client XSLT is just a copy of the OPAC one

- Adding "Lists that include this title" links
 - Also correcting minor XHTML error in the same section of opac-detail.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoMerge remote branch 'kc/new/bug_4498' into kcmaster
Chris Cormack [Sat, 13 Nov 2010 20:42:23 +0000 (09:42 +1300)]
Merge remote branch 'kc/new/bug_4498' into kcmaster

9 years agobug 5400: new test case to find files with merge conflict markers
Galen Charlton [Sat, 13 Nov 2010 14:36:15 +0000 (09:36 -0500)]
bug 5400: new test case to find files with merge conflict markers

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoFix for Bug 4498 - Acq always shows '1 suggestions waiting'
Owen Leonard [Tue, 7 Sep 2010 13:48:03 +0000 (15:48 +0200)]
Fix for Bug 4498 - Acq always shows '1 suggestions waiting'

- Removing 'suggestions waiting' link from left-hand menu. A plain
  'suggestions' link is still shown if suggestions are enabled.
- Putting back the 'pending suggestions' box that used to appear
  on the Acquisitions home page. This will show, with a count
  of pending suggestions, only if suggestions are turned on and
  there are pending suggestions.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoRemoving merge commit
Chris Cormack [Sat, 13 Nov 2010 16:40:55 +0000 (05:40 +1300)]
Removing merge commit

9 years agobug 4359: make other pages in the OPAC respect noItemTypeImages
Galen Charlton [Sat, 13 Nov 2010 03:41:32 +0000 (22:41 -0500)]
bug 4359: make other pages in the OPAC respect noItemTypeImages

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agobug 4359 follow-up: noItemTypeImages should just control image display
Galen Charlton [Sat, 13 Nov 2010 03:41:31 +0000 (22:41 -0500)]
bug 4359 follow-up: noItemTypeImages should just control image display

Tweaked so that the item type column is always displayed in the
checkout history in the OPAC; noItemTypeImages now just controls
whether the icon displays.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoFix for Bug 4359, noItemTypeImages not active in OPAC
Owen Leonard [Sat, 13 Nov 2010 03:41:30 +0000 (22:41 -0500)]
Fix for Bug 4359, noItemTypeImages not active in OPAC

- Auth.pm put the noItemTypeImages preference under "intranet only."
  Moved it to "OPAC or intranet."
- Added check for the preference on the OPAC advanced search page.
- Improved logic for displaying images on the reading history page.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoBug 5396: New system preference UseTablesortForCirc
Owen Leonard [Fri, 12 Nov 2010 20:54:50 +0000 (15:54 -0500)]
Bug 5396: New system preference UseTablesortForCirc

This system preference allows the librarian to toggle on or off whether the JQuery tablesort is used on the
circ/circulation.pl page.  For patrons with many checkouts, this sort may cause very slow page loading (and
therefore slow circulation transaction time), depending on the browser and local machine used.  Staff can
still see a sortable list of current checkouts on the members/moremember.pl page.

My revision prevents the template from including *any* tablesorter code if the
preference is feature is turned off: both the circulation list and
the holds list will have no jQuery tablesorter.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoFix for Bug 3271, Missing message when adding to a list with no items selected
Owen Leonard [Sat, 13 Nov 2010 04:16:56 +0000 (23:16 -0500)]
Fix for Bug 3271, Missing message when adding to a list with no items selected

There is no visible Lists button to "attach" our warning to
as there is in the OPAC, so warning message is displayed via
a javascript alert.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

9 years agoPartial fix for Bug 4924, Public/Internal notes missing in staff normal view
Owen Leonard [Sat, 13 Nov 2010 04:28:00 +0000 (23:28 -0500)]
Partial fix for Bug 4924, Public/Internal notes missing in staff normal view

This fix adds only public notes. A div is added as a hook for styling

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>