wip/koha-chris_n.git
9 years agoMerge remote branch 'kc/master' into new/bug_5105
Chris Cormack [Wed, 10 Nov 2010 22:33:10 +0000 (11:33 +1300)]
Merge remote branch 'kc/master' into new/bug_5105

Conflict fixed

Conflicts:
opac/opac-detail.pl

9 years agoBug 5105 - Remove use of depreciated Switch module
Colin Campbell [Wed, 8 Sep 2010 13:16:32 +0000 (14:16 +0100)]
Bug 5105 - Remove use of depreciated Switch module

Use of switch generates errors in perl 12 and above
Replaced uses of the Switch module by if- else constructs
Removed some mixed space+tab indentation around these where
it generated visual confusion

As of perl 10 you can use given/when constructs but this is not
supported in earlier perls.

9 years agoFix bug on opac-detail.pl with switch statement
Frédéric Demians [Wed, 10 Nov 2010 22:00:54 +0000 (23:00 +0100)]
Fix bug on opac-detail.pl with switch statement

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5003: Can not search for organisation by name
Katrin Fischer [Wed, 10 Nov 2010 13:45:33 +0000 (08:45 -0500)]
Bug 5003: Can not search for organisation by name

Rebased to current HEAD, small error fixed.
Should also apply to 3.2

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5380: remove copy-and-paste from authorities/detail.pl
Galen Charlton [Wed, 10 Nov 2010 05:09:37 +0000 (00:09 -0500)]
bug 5380: remove copy-and-paste from authorities/detail.pl

MARC editor code not needed here.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5372: identify empty field in authority record correctly
Galen Charlton [Wed, 10 Nov 2010 04:48:33 +0000 (23:48 -0500)]
bug 5372: identify empty field in authority record correctly

This is the sibling to the fix for this bug for the bib
editor.  However, note that this change won't have a
direct effect yet, as currently you can't specify a
default value for a field or subfield in the authority
MARC frameworks.  See bug 4887.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoUkranian and Russian syspref language updates
Chris Cormack [Mon, 8 Nov 2010 23:01:02 +0000 (12:01 +1300)]
Ukranian and Russian syspref language updates

9 years agoRussian and Ukranian opac language updates
Chris Cormack [Mon, 8 Nov 2010 23:00:40 +0000 (12:00 +1300)]
Russian and Ukranian opac language updates

9 years agoStaff interface .po file updates
Chris Cormack [Mon, 8 Nov 2010 22:59:41 +0000 (11:59 +1300)]
Staff interface .po file updates

9 years agoMerge remote branch 'kc/new/bug_5370' into kcmaster
Chris Cormack [Mon, 8 Nov 2010 21:49:01 +0000 (10:49 +1300)]
Merge remote branch 'kc/new/bug_5370' into kcmaster

9 years agoBug 5370: Fix all references to koha.org
Katrin Fischer [Mon, 8 Nov 2010 20:52:32 +0000 (21:52 +0100)]
Bug 5370: Fix all references to koha.org

Thx to Brooke for helping with the wiki.

This is the last patch.
We will have to change some more links, after translate.koha.org was moved.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge branch 'trivial_bugs' of git://git.koha-community.org/wip/koha-fbc into kcmaster
Chris Cormack [Mon, 8 Nov 2010 06:42:41 +0000 (19:42 +1300)]
Merge branch 'trivial_bugs' of git://git.koha-community.org/wip/koha-fbc into kcmaster

9 years agoBug 4515 (Few very small errors in opac-search.pl) RESENT fixing whitespace warning
Marcel de Rooy [Thu, 4 Nov 2010 11:38:45 +0000 (11:38 +0000)]
Bug 4515 (Few very small errors in opac-search.pl) RESENT fixing whitespace warning

Loop on results should stop before $i==@servers.  Adding fix for warnings on undefined values in comparison for lines 485, 488 and 510.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 4472 Apply it to MARC21
Frédéric Demians [Wed, 3 Nov 2010 17:38:35 +0000 (18:38 +0100)]
Bug 4472 Apply it to MARC21

For French installation of Koha using MARC21, the same issues as UNIMARC
affects handling of &nbsp; by translation scripts.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_5214' into kcmaster
Chris Cormack [Mon, 8 Nov 2010 02:31:49 +0000 (15:31 +1300)]
Merge remote branch 'kc/new/bug_5214' into kcmaster

9 years agoFix for Bug 5214 - undefined itype images cause broken image icon in request.pl
Owen Leonard [Thu, 28 Oct 2010 14:24:59 +0000 (10:24 -0400)]
Fix for Bug 5214 - undefined itype images cause broken image icon in request.pl

Also fixes the same bug on the Itemtypes administration page.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_5236' into kcmaster
Chris Cormack [Mon, 8 Nov 2010 02:26:37 +0000 (15:26 +1300)]
Merge remote branch 'kc/new/bug_5236' into kcmaster

9 years agobug 5236: remove hidemytags from CSS as well
Galen Charlton [Thu, 28 Oct 2010 13:23:12 +0000 (09:23 -0400)]
bug 5236: remove hidemytags from CSS as well

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5219: tidy cleanup_database.pl
Galen Charlton [Thu, 28 Oct 2010 13:05:21 +0000 (09:05 -0400)]
bug 5219: tidy cleanup_database.pl

Includes a bit of cleanup of the enhancement patch
for bug 5074 - adding comments about old and new
behavior isn't necessary for such small changes.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_5370' into kcmaster
Chris Cormack [Sun, 7 Nov 2010 20:42:52 +0000 (09:42 +1300)]
Merge remote branch 'kc/new/bug_5370' into kcmaster

9 years agoBug 5370: Fix all the references to koha.org
Katrin Fischer [Sun, 7 Nov 2010 10:59:00 +0000 (11:59 +0100)]
Bug 5370: Fix all the references to koha.org

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5370: Fix all references to koha.org
Katrin Fischer [Sun, 7 Nov 2010 07:42:49 +0000 (08:42 +0100)]
Bug 5370: Fix all references to koha.org

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge branch '5370_koha.org' of git://github.com/kfischer/Koha into new/bug_5370
Chris Cormack [Sun, 7 Nov 2010 20:31:28 +0000 (09:31 +1300)]
Merge branch '5370_koha.org' of git://github.com/kfischer/Koha into new/bug_5370

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5372 (v2) Existing value can be replace by default value
Frédéric Demians [Sun, 7 Nov 2010 13:33:36 +0000 (14:33 +0100)]
Bug 5372 (v2) Existing value can be replace by default value

The way an existing value was tested was wrong. 0 is a valid value but a
false value for Perl.

=> replace privious proposal.

[3.2] Should also apply.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5370: Fix references to koha.org and other old websites
Katrin Fischer [Sun, 7 Nov 2010 06:10:06 +0000 (07:10 +0100)]
Bug 5370: Fix references to koha.org and other old websites

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5370: Fix references to koha.org and other old websites
Katrin Fischer [Sun, 7 Nov 2010 06:10:06 +0000 (07:10 +0100)]
Bug 5370: Fix references to koha.org and other old websites

9 years agoAdding 3.2 Release Maintainer to Release Team List
Chris Nighswonger [Sat, 6 Nov 2010 06:56:01 +0000 (01:56 -0500)]
Adding 3.2 Release Maintainer to Release Team List

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5368 Browse Shelf link appears when no itemcallnumber
Frédéric Demians [Fri, 5 Nov 2010 11:23:08 +0000 (12:23 +0100)]
Bug 5368 Browse Shelf link appears when no itemcallnumber

Suppress Browse Shelf link on OPAC detail page when there is no item
call number.

[3.2] Should also apply on 3.2

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years ago(MT 2985) simplify CanBookBeReserved
Nahuel ANGELINETTI [Fri, 5 Nov 2010 13:13:21 +0000 (09:13 -0400)]
(MT 2985) simplify CanBookBeReserved

The function was too complex for so simple stuff, not we check if one of all items of the record can be issued.

[Note by Galen Charlton: not only does this patch simplify the routine,
 it also makes it behave correctly.]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_5227' into kcmaster
Chris Cormack [Thu, 4 Nov 2010 19:02:34 +0000 (08:02 +1300)]
Merge remote branch 'kc/new/bug_5227' into kcmaster

9 years agoFixing up a regexp to stop a trivial warn
Chris Nighswonger [Thu, 4 Nov 2010 18:14:10 +0000 (14:14 -0400)]
Fixing up a regexp to stop a trivial warn

9 years agoMerge remote branch 'kc/new/signoffs' into kcmaster
Chris Cormack [Thu, 4 Nov 2010 07:14:28 +0000 (20:14 +1300)]
Merge remote branch 'kc/new/signoffs' into kcmaster

Conflicts:
installer/data/mysql/updatedatabase.pl

Updated updatedatabase.pl to handle new version number

9 years agoBug 5363 - Removing unused module (C4::Cache::FastMemcached)
Chris Cormack [Wed, 3 Nov 2010 20:31:03 +0000 (16:31 -0400)]
Bug 5363 - Removing unused module (C4::Cache::FastMemcached)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 4141: fix upgrade of OPAC XSLT parameters from 3.0.x
Galen Charlton [Wed, 3 Nov 2010 17:49:00 +0000 (13:49 -0400)]
bug 4141: fix upgrade of OPAC XSLT parameters from 3.0.x

Note that OPACXSLTResultsDisplay and OPACXSLTDetailsDisplay
are boolean parameters in 3.2.x, not string parameters.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoUpdating version number and fixing the xxx in updatedatabase ... my bad
Chris Cormack [Wed, 3 Nov 2010 17:28:24 +0000 (06:28 +1300)]
Updating version number and fixing the xxx in updatedatabase ... my bad

9 years agoMerge remote branch 'kc/new/bug2567' into kcmaster
Chris Cormack [Wed, 3 Nov 2010 08:21:02 +0000 (21:21 +1300)]
Merge remote branch 'kc/new/bug2567' into kcmaster

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_5308' into kcmaster
Chris Cormack [Wed, 3 Nov 2010 03:52:21 +0000 (16:52 +1300)]
Merge remote branch 'kc/new/bug_5308' into kcmaster

9 years agoMerge remote branch 'kc/new/merge_help' into kcmaster
Chris Cormack [Wed, 3 Nov 2010 01:58:40 +0000 (14:58 +1300)]
Merge remote branch 'kc/new/merge_help' into kcmaster

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_4991' into kcmaster
Chris Cormack [Wed, 3 Nov 2010 01:48:37 +0000 (14:48 +1300)]
Merge remote branch 'kc/new/bug_4991' into kcmaster

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_5301' into kcmaster
Chris Cormack [Tue, 2 Nov 2010 17:54:50 +0000 (06:54 +1300)]
Merge remote branch 'kc/new/bug_5301' into kcmaster

9 years agoBug 5192 Enhancement to add new index for 658 curriculum field
dev2 [Fri, 29 Oct 2010 11:53:34 +0000 (07:53 -0400)]
Bug 5192 Enhancement to add new index for 658 curriculum field

Creates new curriculum index for 658 subfields a,b,c and search option in Advanced search (under More Options).  Also modifies the installer files to make 658abc display (they were hidden in the frameworks) and to create the new indexes.

The 658 already displays as part of the staff/OPAC subject display line.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5243: avoid crash when saving authority records on certain setups
Galen Charlton [Thu, 28 Oct 2010 12:09:47 +0000 (08:09 -0400)]
bug 5243: avoid crash when saving authority records on certain setups

This does not seem to occur on all platforms - C4::Search
exports SimpleSearch() by default - but adding the 'C4::Search::'
qualifier certainly doesn't hurt things.

Patch by Fridolyn Somers <fridolyn.somers@gmail.com>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5149: follow-up - remove extraneous character in link
Galen Charlton [Tue, 2 Nov 2010 02:09:10 +0000 (22:09 -0400)]
bug 5149: follow-up - remove extraneous character in link

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5149 fix broken link to noItemTypeImages preference
Nicole Engard [Tue, 2 Nov 2010 02:09:09 +0000 (22:09 -0400)]
bug 5149 fix broken link to noItemTypeImages preference

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5110 move NewItemsDefaultLocation to cataloging tab
Nicole Engard [Sat, 30 Oct 2010 20:29:24 +0000 (16:29 -0400)]
bug 5110 move NewItemsDefaultLocation to cataloging tab

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 4963, sys prefs need date hints and/or picker
Owen Leonard [Sat, 30 Oct 2010 20:25:19 +0000 (16:25 -0400)]
Fix for Bug 4963, sys prefs need date hints and/or picker

This patch adds the standard date format hint used elsewhere
in the interface.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 4254 - adding new patron advanced notice doesn't save
ByWater Solutions [Sat, 30 Oct 2010 13:50:29 +0000 (09:50 -0400)]
Bug 4254 - adding new patron advanced notice doesn't save

This was due to poorly constructed SQL which returned duplicate values for
certain fields. This patch corrects that SQL.

NOTE: There is also a formatting problem with the message prefs display table
when it is displayed in moremember.pl. This is due to there being no logic to
tell the table in that context to display checkboxes as appropriate. This patch
does not fix that. Bug 5328 has been opened for this problem.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5082 - Not translatable name of default framework 'Default' in MARCdetail...
Owen Leonard [Sat, 30 Oct 2010 05:52:50 +0000 (01:52 -0400)]
Fix for Bug 5082 - Not translatable name of default framework 'Default' in MARCdetail.tmpl

This patch also fixes an unreported bug where switching from any
other framework to 'Default' would bring up no MARC data.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 4980 - Acq: pull down 'Restrict access to:' for funds not translatable
Owen Leonard [Sat, 30 Oct 2010 05:52:49 +0000 (01:52 -0400)]
Fix for Bug 4980 - Acq: pull down 'Restrict access to:' for funds not translatable

Applied Owen's patch to current head, updated de-DE translation. The pull down values are now  translated.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5142, Untranslatable strings in tag review template
Owen Leonard [Sat, 30 Oct 2010 05:52:48 +0000 (01:52 -0400)]
Fix for Bug 5142, Untranslatable strings in tag review template

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5056, Untranslatable strings in members.js
Owen Leonard [Sat, 30 Oct 2010 05:52:47 +0000 (01:52 -0400)]
Fix for Bug 5056, Untranslatable strings in members.js

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5136, Replace SQL with call to GetAuthorisedValues
Owen Leonard [Sat, 30 Oct 2010 05:36:57 +0000 (01:36 -0400)]
Fix for Bug 5136, Replace SQL with call to GetAuthorisedValues

An embedded query in circulation.pl for BOR_NOTES authorized
values can be replaced with a call to GetAuthorisedValues

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5135 - Authorized value input maxlength should match table column
Owen Leonard [Sat, 30 Oct 2010 05:33:42 +0000 (01:33 -0400)]
Fix for Bug 5135 - Authorized value input maxlength should match table column

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 4991: follow-up tweaks
Galen Charlton [Sat, 30 Oct 2010 04:40:15 +0000 (00:40 -0400)]
bug 4991: follow-up tweaks

* make some strings translatable
* display library name instead of code in add/edit
  holiday panel
* minor textual fixes to hints

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
9 years agoFix for Bug 4991, Overhaul of Calendar interface
Owen Leonard [Mon, 12 Jul 2010 20:41:28 +0000 (16:41 -0400)]
Fix for Bug 4991, Overhaul of Calendar interface

- Put hints, key, and existing holidays into right column
- Style entry form for added clarity and consistency with other
  forms in Koha
- Change the way dynamically displayed hints are shown to better
  match existing static hints in Koha's interface
- Add branch name (instead of branch code) for clarity
- Add the ability to add and edit holiday titles (previously
  only description could be edited).
- Add links to the list of existing single-day holidays and
  exceptions which opens the calendar to that month/year

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
9 years agobug 5171 change 'edit items' to read 'edit item' when next to 1 item
Nicole Engard [Sat, 30 Oct 2010 04:48:19 +0000 (00:48 -0400)]
bug 5171 change 'edit items' to read 'edit item' when next to 1 item

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5168 change link text from holdings to items
Nicole Engard [Sat, 30 Oct 2010 04:48:18 +0000 (00:48 -0400)]
bug 5168 change link text from holdings to items

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix bug 3811; Index language as word
Jared CAMINS-ESAKOV [Sat, 30 Oct 2010 03:49:15 +0000 (23:49 -0400)]
Fix bug 3811; Index language as word

An incorrect definition in record.abs was resulting in searches on languages returning incorrect results.  By changing the indexing mode from numeric to word, this patch fixes that problem.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5311: correction to database update
Galen Charlton [Sat, 30 Oct 2010 03:49:14 +0000 (23:49 -0400)]
bug 5311: correction to database update

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoUpdate language mappings to fix Bug 5311
Jared Camins-Esakov [Sat, 30 Oct 2010 03:49:13 +0000 (23:49 -0400)]
Update language mappings to fix Bug 5311

This patch updates the language_rfc4646_to_iso639 mapping table with the
correct mappings for several languages that were not mapped correctly to
the codes used in MARC, including Finnish (which was not mapped at all),
and Armenian (which was mapped to an obsolete code). This patch also
changes English and French to use the proper three-letter codes, which
will eliminate false positives when, for example, limiting by French
brings up results in Afrikaans.

This patch adds the changes to the updatedatabase.pl script, and removes
the incorrectly specified DBversion in the previous patch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5190: improve linking to MARC field documentation
Galen Charlton [Sat, 30 Oct 2010 02:35:44 +0000 (22:35 -0400)]
bug 5190: improve linking to MARC field documentation

* zero-pad tag numbers as needed
* handle special case for linking to UNIMARC 0XX vs. 1-8XX
* add a wrapper function
* add comment about the poor linkability of IFLA's UNIMARC documentation

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5190: link to MARC21/UNIMARC online doc in the bib editor
Galen Charlton [Sat, 30 Oct 2010 02:35:43 +0000 (22:35 -0400)]
bug 5190: link to MARC21/UNIMARC online doc in the bib editor

Patch from  Tomás Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5326 fix link to old prefs editor on patron attributes
Nicole Engard [Sat, 30 Oct 2010 00:28:49 +0000 (20:28 -0400)]
bug 5326 fix link to old prefs editor on patron attributes

on the patron attributes page if you have ExtendedPatronAttributes
turned off the error points you to the old sys prefs editor - this
patch fixes that

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5326 fix extended patron attribute error
Nicole Engard [Sat, 30 Oct 2010 00:28:48 +0000 (20:28 -0400)]
bug 5326 fix extended patron attribute error

the error message if you have ExtendedPatronAttributes turned
off linked to the old sys prefs editor, link has been updated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5137, Remove obsolete code counting issues by item type in circ
Owen Leonard [Fri, 29 Oct 2010 12:37:41 +0000 (08:37 -0400)]
Fix for Bug 5137, Remove obsolete code counting issues by item type in circ

The removed section of code contained a "my $dbh = C4::Context->dbh"
which was required for the query of BOR_NOTES. That line has been
moved accordingly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5008 - "Remove" link missing when Cart in expanded view
Owen Leonard [Fri, 29 Oct 2010 12:29:02 +0000 (08:29 -0400)]
Fix for Bug 5008 - "Remove" link missing when Cart in expanded view

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 4986 move serials prefs from cataloging tab to serials tab
Nicole Engard [Fri, 29 Oct 2010 12:23:41 +0000 (08:23 -0400)]
bug 4986 move serials prefs from cataloging tab to serials tab

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5114 - Can't edit basket in Internet Explorer
Owen Leonard [Fri, 29 Oct 2010 12:15:37 +0000 (08:15 -0400)]
Fix for Bug 5114 - Can't edit basket in Internet Explorer

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5019 remove link to funds
Nicole Engard [Fri, 29 Oct 2010 12:10:44 +0000 (08:10 -0400)]
bug 5019 remove link to funds

This patch renames the link to budgets to say 'budgets & funds'
and removes the links to funds (which went no where).

This patch also adds the acq menu to the budget pages.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5177 Selecting default sort result by syspref
Frédéric Demians [Fri, 29 Oct 2010 11:47:33 +0000 (07:47 -0400)]
Bug 5177 Selecting default sort result by syspref

Syspref .pref file was defining a code for descending order which wasn't
expected by .tmpl files... 'desc' instead of 'dsc'.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_5162' into kcmaster
Chris Cormack [Tue, 2 Nov 2010 01:41:07 +0000 (14:41 +1300)]
Merge remote branch 'kc/new/bug_5162' into kcmaster

9 years agobug 5162: follow-up patch to not clear hidden input setting attribute type
Galen Charlton [Fri, 29 Oct 2010 11:40:37 +0000 (07:40 -0400)]
bug 5162: follow-up patch to not clear hidden input setting attribute type

Otherwise, can't saved new attributes set from a cloned
input or select control.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5162, patron attributes 'new' link should create blank value
Owen Leonard [Fri, 29 Oct 2010 11:40:36 +0000 (07:40 -0400)]
Fix for Bug 5162, patron attributes 'new' link should create blank value

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/for-3.4/enh_bulkmarcimport' into kcmaster
Chris Cormack [Tue, 2 Nov 2010 01:38:52 +0000 (14:38 +1300)]
Merge remote branch 'kc/new/for-3.4/enh_bulkmarcimport' into kcmaster

9 years agoMerge remote branch 'kc/new/for-3.4/spelling' into kcmaster
Chris Cormack [Mon, 1 Nov 2010 22:33:49 +0000 (11:33 +1300)]
Merge remote branch 'kc/new/for-3.4/spelling' into kcmaster

9 years agobug 5050 move language prefs to I18N/L10N tab
Nicole Engard [Thu, 28 Oct 2010 15:53:51 +0000 (11:53 -0400)]
bug 5050 move language prefs to I18N/L10N tab

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5151 removed bolded terms in breadcrumbs
Nicole Engard [Thu, 28 Oct 2010 15:42:12 +0000 (11:42 -0400)]
bug 5151 removed bolded terms in breadcrumbs

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5237: Testing renewals on patron barcodes with + signs at the end
Liz Rea [Thu, 28 Oct 2010 14:00:03 +0000 (10:00 -0400)]
bug 5237: Testing renewals on patron barcodes with + signs at the end

According to notes in bug, patch was originally by Chris Cormack.

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5163 change title of holds to pull page
Nicole Engard [Thu, 28 Oct 2010 13:52:47 +0000 (09:52 -0400)]
bug 5163 change title of holds to pull page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5258 change 'order' to 'order line' on receive page
Nicole Engard [Thu, 28 Oct 2010 13:45:04 +0000 (09:45 -0400)]
bug 5258 change 'order' to 'order line' on receive page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5224 Remove the adjective Shopping from basket
Colin Campbell [Thu, 28 Oct 2010 13:39:09 +0000 (09:39 -0400)]
Bug 5224 Remove the adjective Shopping from basket

New orders breadcrumbs were using the inappropriate term
Shopping basket whereas basket is used elsewhere

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBUG 5239 add space between number and words in acq search
Nicole Engard [Thu, 28 Oct 2010 13:35:15 +0000 (09:35 -0400)]
BUG 5239 add space between number and words in acq search

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5221 - Preselect tab containing itemtype/authval image in use
Owen Leonard [Thu, 28 Oct 2010 13:29:23 +0000 (09:29 -0400)]
Fix for Bug 5221 - Preselect tab containing itemtype/authval image in use

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'kc/new/bug_5236' into kcmaster
Chris Cormack [Mon, 1 Nov 2010 22:10:39 +0000 (11:10 +1300)]
Merge remote branch 'kc/new/bug_5236' into kcmaster

9 years agoFix for Bug 5236 - "hide my tags" link does nothing
Owen Leonard [Thu, 28 Oct 2010 13:23:11 +0000 (09:23 -0400)]
Fix for Bug 5236 - "hide my tags" link does nothing

Removing the link. The suggested functionality doesn't
seem useful.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoEnhancement 5074 (Adding possibility to cleanup_database.pl to purge only older sessi...
Marcel de Rooy [Thu, 28 Oct 2010 13:05:20 +0000 (09:05 -0400)]
Enhancement 5074 (Adding possibility to cleanup_database.pl to purge only older sessions) [UPDATED for master]

Currently, the misc/cronjobs script cleanup_database truncates the session table (deleting all records, including active sessions).
With an additional parameter sessdays, this behavior could be changed or (perhaps better) extended. If the parameter sessdays is passed along with a number of days, the script only deletes older session records. This is accomplished by examining the values of lasttime, atime or ctime in the record.
So, calling the script like:
  ./cleanup_database.pl -v -sessions -sessdays 7
will only delete sessions records older than 7 days. The "old style" call
  ./cleanup_database.pl -v -sessions
still works too and truncates the table as before.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoMerge remote branch 'galen/bug5308' into bug_5308
Chris Cormack [Mon, 1 Nov 2010 19:52:43 +0000 (08:52 +1300)]
Merge remote branch 'galen/bug5308' into bug_5308

9 years agobug 5301: improve escaping of XML characters in bib output
Galen Charlton [Wed, 27 Oct 2010 12:24:04 +0000 (08:24 -0400)]
bug 5301: improve escaping of XML characters in bib output

<, >, ', or " in an item call number will no longer make
the bib displays break when using XSLT mode.

Added a new routine to C4::Koha, xml_escape(), to implement
converting &, <, >, ', and " to their corresponding
entities.

Patch loosely based on work done by Daniel Latrémolière <daniel.latremoliere@bulac.fr>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5318: fix value of r4 rank weight
Galen Charlton [Wed, 27 Oct 2010 12:24:03 +0000 (08:24 -0400)]
bug 5318: fix value of r4 rank weight

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoremove unused template include
Galen Charlton [Wed, 27 Oct 2010 11:48:22 +0000 (07:48 -0400)]
remove unused template include

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5308: add foreign key constraints as well
Galen Charlton [Mon, 1 Nov 2010 12:23:35 +0000 (08:23 -0400)]
bug 5308: add foreign key constraints as well

Follows up on previous patch to require that routing
list entries be linked to subscriptions and patrons.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
9 years agobug 5308: subscriptionroutinglist more strict
Srdjan Jankovic [Fri, 15 Oct 2010 00:58:00 +0000 (13:58 +1300)]
bug 5308: subscriptionroutinglist more strict

borrowernumber and subscriptionid NOT NULL, UNIQUE(subscriptionid, borrowernumber)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
9 years agoMerge remote branch 'kc/new/background_jobs_tested' into kcmaster
Chris Cormack [Mon, 1 Nov 2010 08:03:06 +0000 (21:03 +1300)]
Merge remote branch 'kc/new/background_jobs_tested' into kcmaster

9 years agoMerge branch 'signoffs' into kcmaster
Chris Cormack [Mon, 1 Nov 2010 07:52:42 +0000 (20:52 +1300)]
Merge branch 'signoffs' into kcmaster

9 years agoBug 5227 [3.4] Enhance the label batch edit interface
Chris Nighswonger [Tue, 26 Oct 2010 13:10:57 +0000 (09:10 -0400)]
Bug 5227 [3.4] Enhance the label batch edit interface

This patch adds the ability to enter items into label batches via
barcode scanning

Work sponsored by Tamil - http://www.tamil.fr

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 5223, 'related subjects' should read 'subjects'
Owen Leonard [Tue, 26 Oct 2010 13:28:50 +0000 (09:28 -0400)]
Fix for Bug 5223, 'related subjects' should read 'subjects'

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFix for Bug 4261 - keyword mapping should show which framework the map is for
Owen Leonard [Tue, 26 Oct 2010 13:00:51 +0000 (09:00 -0400)]
Fix for Bug 4261 - keyword mapping should show which framework the map is for

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agohistory updates - recent releases
Galen Charlton [Mon, 1 Nov 2010 02:35:12 +0000 (22:35 -0400)]
history updates - recent releases

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agobug 5327: follow-up to fix SIP tests
Galen Charlton [Sun, 31 Oct 2010 22:25:47 +0000 (18:25 -0400)]
bug 5327: follow-up to fix SIP tests

* removed t/SIP_SIPServer.t - despite the file name,
  C4/SIP/SIPserver.pm is not actually a module and
  cannot be 'used' or 'required'
* set module search path so that t/SIP_ILS.t and
  t/SIP_Sip.t will pass

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 5327: More basic unit tests for C4 modules
Katrin Fischer [Sun, 31 Oct 2010 22:25:46 +0000 (18:25 -0400)]
Bug 5327: More basic unit tests for C4 modules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>