wip/koha-chris_n.git
10 years agoBug 2505 - Add commented use warnings where missing in the sms/ directory
Donovan Jones [Fri, 16 Apr 2010 03:27:11 +0000 (15:27 +1200)]
Bug 2505 - Add commented use warnings where missing in the sms/ directory

10 years agoBug 2505 - Add commented use warnings where missing in the opac/ directory
Donovan Jones [Fri, 16 Apr 2010 03:25:50 +0000 (15:25 +1200)]
Bug 2505 - Add commented use warnings where missing in the opac/ directory

10 years agoBug 2505 - Add commented use warnings where missing in the virtualshelves/ directory
Donovan Jones [Fri, 16 Apr 2010 03:14:43 +0000 (15:14 +1200)]
Bug 2505 - Add commented use warnings where missing in the virtualshelves/ directory

10 years agoBug 2505 - Add commented use warnings where missing in the suggestion/ directory
Donovan Jones [Fri, 16 Apr 2010 03:13:29 +0000 (15:13 +1200)]
Bug 2505 - Add commented use warnings where missing in the suggestion/ directory

10 years agoBug 2505 - Add commented use warnings where missing in the admin/ directory
Donovan Jones [Fri, 16 Apr 2010 03:00:19 +0000 (15:00 +1200)]
Bug 2505 - Add commented use warnings where missing in the admin/ directory

10 years agoBug 2505 - Add commented use warnings where missing in the circ/ directory
Donovan Jones [Fri, 16 Apr 2010 02:52:03 +0000 (14:52 +1200)]
Bug 2505 - Add commented use warnings where missing in the circ/ directory

10 years agoBug 2505 - Add commented use warnings where missing in the reports/ directory
Donovan Jones [Fri, 16 Apr 2010 02:47:08 +0000 (14:47 +1200)]
Bug 2505 - Add commented use warnings where missing in the reports/ directory

10 years agoBug 2505 - Add commented use warnings where missing in the members/ directory
Donovan Jones [Fri, 16 Apr 2010 02:40:27 +0000 (14:40 +1200)]
Bug 2505 - Add commented use warnings where missing in the members/ directory

10 years agoBug 2505 - Add commented use warnings where missing in the acqui/ directory
Donovan Jones [Fri, 16 Apr 2010 02:32:36 +0000 (14:32 +1200)]
Bug 2505 - Add commented use warnings where missing in the acqui/ directory

10 years agoBug 2505 - Add commented use warnings where missing in the errors/ directory
Donovan Jones [Fri, 16 Apr 2010 01:51:41 +0000 (13:51 +1200)]
Bug 2505 - Add commented use warnings where missing in the errors/ directory

10 years agoReplace branch codes in on returns screen with branch names.
Kyle M Hall [Thu, 1 Apr 2010 15:45:25 +0000 (15:45 +0000)]
Replace branch codes in on returns screen with branch names.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3293, changes to the xslt files to fix the wrong type/icon showing for music...
Chris Cormack [Fri, 26 Mar 2010 19:58:48 +0000 (08:58 +1300)]
Bug 3293, changes to the xslt files to fix the wrong type/icon showing for music scores. Courtesy of Bernardo Gonzalez Kriegel

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(bug #4318) remove the confirmation step in validating a form
Alex Arnaud [Tue, 16 Mar 2010 15:13:40 +0000 (16:13 +0100)]
(bug #4318) remove the confirmation step in validating a form

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(bug #4339) fix catalog stats
Nahuel ANGELINETTI [Wed, 24 Mar 2010 11:04:39 +0000 (12:04 +0100)]
(bug #4339) fix catalog stats

This fix the catalog stats to count items that have no barcode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAllow zebra search for Accelerated Reading Point in field 526$d
amit gupta [Fri, 16 Apr 2010 07:48:31 +0000 (13:18 +0530)]
Allow zebra search for Accelerated Reading Point in field 526$d

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAllow zebra search for Accelerated Reading Level in field 526$c
amit gupta [Fri, 16 Apr 2010 07:53:01 +0000 (13:23 +0530)]
Allow zebra search for Accelerated Reading Level in field 526$c

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAllow UNIMARC item callnumber splitting
Frédéric Demians [Fri, 9 Apr 2010 16:47:26 +0000 (18:47 +0200)]
Allow UNIMARC item callnumber splitting

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4382 Export batch label to CSV
Frédéric Demians [Fri, 9 Apr 2010 16:14:04 +0000 (18:14 +0200)]
Bug 4382 Export batch label to CSV

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoHistory updated - 4 New developers !
Chris Cormack [Wed, 7 Apr 2010 20:52:22 +0000 (08:52 +1200)]
History updated - 4 New developers !

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoChange #! line for cronjob to refer to sh using canonical path.
Lars Wirzenius [Tue, 13 Apr 2010 05:46:29 +0000 (17:46 +1200)]
Change #! line for cronjob to refer to sh using canonical path.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMT3160 : Fix plugin callback when subfields are cloned
Matthias Meusburger [Wed, 7 Apr 2010 13:01:18 +0000 (15:01 +0200)]
MT3160 : Fix plugin callback when subfields are cloned

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoReplace old, non-functional Debian packaging with a new one.
Lars Wirzenius [Fri, 16 Apr 2010 03:35:50 +0000 (15:35 +1200)]
Replace old, non-functional Debian packaging with a new one.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix file permissions: if it is not a script, it should not be executable.
Lars Wirzenius [Fri, 16 Apr 2010 03:34:11 +0000 (15:34 +1200)]
Fix file permissions: if it is not a script, it should not be executable.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4368 - Avoid reseting UNIMARC 100 tag when importing biblio records
Frédéric Demians [Sat, 3 Apr 2010 10:48:54 +0000 (12:48 +0200)]
Bug 4368 - Avoid reseting UNIMARC 100 tag when importing biblio records

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4233 HidePatronName values swapped
Nicole Engard [Mon, 29 Mar 2010 18:27:22 +0000 (14:27 -0400)]
bug 4233 HidePatronName values swapped

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4378 Missing option prompt for IntranetBiblioDefaultView syspref
Colin Campbell [Thu, 8 Apr 2010 11:02:22 +0000 (12:02 +0100)]
bug 4378 Missing option prompt for IntranetBiblioDefaultView syspref

labeled_marc ioption was omitted (spelling police?)
options available now match those in code

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMerge branch 'serials_mods' of git://github.com/colinsc/koha into to-push
Galen Charlton [Fri, 16 Apr 2010 04:16:16 +0000 (00:16 -0400)]
Merge branch 'serials_mods' of git://github.com/colinsc/koha into to-push

Description by Colin Campbell:

A number of commits, subsequent to enabling warnings in C4::Serials and
eradicating errors and removing dead code.
These are extracted from an install branch running at UN FAO in Rome.
Commits have been rebased on current 3.2 HEAD.
These are not major new functionality, but  a series of fixes to
eradicate some randomness caused by undefined values. Includes a commit
to fix Licenses in the serials directory.

* 'serials_mods' of git://github.com/colinsc/koha:
  Check value is defined before splitting it
  Fix FSF Address in directory serials/
  Bug 4380 Use syspref to resolve which bib display is used
  Remove bottleneck making claims page unuseable
  Clean up Pod Documentation
  add warnings to Serials.pm
  Add Text to claim date column's header
  Basic refactoring of serials-edit.pm
  Remove unused or unnecessary variables in claims processing

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4235, Date picker broken if placing multiple holds
Owen Leonard [Mon, 22 Feb 2010 18:28:40 +0000 (13:28 -0500)]
Fix for Bug 4235, Date picker broken if placing multiple holds

Also includes minor style change.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4262, changing matching rule add big message box
Owen Leonard [Tue, 2 Mar 2010 19:22:43 +0000 (14:22 -0500)]
Fix for Bug 4262, changing matching rule add big message box

Fix includes a change to the format of the page to consolidate
matching rule settings with matching rule controls. This
reduces potential confusion from the placement of the message
box. Assuming that matching rule settings and controls were
displayed separately for clarity and control, I've added
JavaScript which allows the user to change their mind after
changing a selection (but before submitting). It's a new
interaction which I hope is useful.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4121, Cataloging record modification should obey IntranetBiblioDefaultVie...
Owen Leonard [Fri, 5 Feb 2010 15:45:10 +0000 (10:45 -0500)]
Fix for Bug 4121, Cataloging record modification should obey IntranetBiblioDefaultView pref

- Re-used redirect logic found in search.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4251, click on show more in facet drops limit=branch in query
Owen Leonard [Wed, 24 Feb 2010 15:03:35 +0000 (10:03 -0500)]
Fix for Bug 4251, click on show more in facet drops limit=branch in query

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4251 in the staff client
Owen Leonard [Wed, 24 Feb 2010 15:16:31 +0000 (10:16 -0500)]
Fix for Bug 4251 in the staff client

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4250, cart missing print button
Owen Leonard [Wed, 24 Feb 2010 16:38:36 +0000 (11:38 -0500)]
Fix for Bug 4250, cart missing print button

- Print button was hidden by CSS for some reason (git blame me)
- Print formatting was off because of column mismatch
- Table style modified in print view for clarity
- Redirect from print view corrected by adding missing bib_list
  and verbose parameters

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4214, "Your Cart is Currently Empty" popup displays underneath News header
Owen Leonard [Wed, 24 Feb 2010 17:13:45 +0000 (12:13 -0500)]
Fix for Bug 4214, "Your Cart is Currently Empty" popup displays underneath News header

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdding Calyx to the about page and the history
Chris Cormack [Mon, 12 Apr 2010 08:06:09 +0000 (20:06 +1200)]
Adding Calyx to the about page and the history

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoCheck value is defined before splitting it
Colin Campbell [Thu, 8 Apr 2010 21:36:16 +0000 (22:36 +0100)]
Check value is defined before splitting it

splitting an undef generates a warning

10 years agoFix FSF Address in directory serials/
Colin Campbell [Thu, 8 Apr 2010 19:37:12 +0000 (20:37 +0100)]
Fix FSF Address in directory serials/

Add License statement to those files lacking it

10 years agoBug 4380 Use syspref to resolve which bib display is used
Colin Campbell [Thu, 8 Apr 2010 19:04:24 +0000 (20:04 +0100)]
Bug 4380 Use syspref to resolve which bib display is used

Be consistent with elsewhere in cataloguing
When switching there from serials

TODO Duplicates Code Should be in a common routine

10 years agoRemove bottleneck making claims page unuseable
Colin Campbell [Thu, 8 Apr 2010 16:58:20 +0000 (17:58 +0100)]
Remove bottleneck making claims page unuseable

While the idea of showing the number of late serials against the
vendor name was nice it does not scale and on large sites selecting claims
was just timing out. Improved the speed of the initial query but have removed
the big query for each user just to get a count.
Check for 0000-00-00 dates so that C4::Dates does not log error
Removed a variable that was never set and the bit of template used
if the impossible happened

10 years agoClean up Pod Documentation
Colin Campbell [Thu, 8 Apr 2010 13:44:39 +0000 (14:44 +0100)]
Clean up Pod Documentation

Ensured returns were documented
Fixed some language issues
Removed the host of podchecker warnings about missing lists
added a couple of explicit returns when subroutines
'fell off the end' to remove any ambiguity

10 years agoadd warnings to Serials.pm
Colin Campbell [Thu, 8 Apr 2010 12:28:40 +0000 (13:28 +0100)]
add warnings to Serials.pm

Change obvious warning generators:
     ( use of string comparisons in numeric comparison)
     ( declaration of variable in comnditional )
also some errors caused by undefined values:
    abouttoexpire was not checking for undef values
    Pass a valid planneddate in generation of next expected
    (undef here causes odd results)
Add a basic test script
    test is minimal but I fell over a bug this would have caught

10 years agoAdd Text to claim date column's header
Colin Campbell [Thu, 21 Jan 2010 15:27:02 +0000 (15:27 +0000)]
Add Text to claim date column's header

10 years agoBasic refactoring of serials-edit.pm
Colin Campbell [Thu, 8 Apr 2010 12:16:31 +0000 (13:16 +0100)]
Basic refactoring of serials-edit.pm

Removed some useless counts from serials-edit / Serials interfaces
Removed old commented out code. Unrequired variables
Reformatted some code so that improving logic can be done
more easily

10 years agoRemove unused or unnecessary variables in claims processing
Colin Campbell [Thu, 8 Apr 2010 11:46:06 +0000 (12:46 +0100)]
Remove unused or unnecessary variables in claims processing

Also cleaned the interface to the claims related functions
in C4::Serials so they do not return an extra count variable
moved generation of dropdown to template instead of inline code

10 years agoBug 2505 - remove unnecessary -w and replace with use warnings;
Donovan Jones [Wed, 24 Feb 2010 00:33:02 +0000 (13:33 +1300)]
Bug 2505 - remove unnecessary -w and replace with use warnings;

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMT2663 : Adds an itemcallnumber plugin
Matthias Meusburger [Wed, 10 Mar 2010 21:26:05 +0000 (22:26 +0100)]
MT2663 : Adds an itemcallnumber plugin

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMT2502 : Reports Editor's 200$b to biblio's 210$c within unimarc_field_210c plugin
Paul Poulain [Wed, 10 Mar 2010 21:25:47 +0000 (22:25 +0100)]
MT2502 : Reports Editor's 200$b to biblio's 210$c within unimarc_field_210c plugin

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdded plugin to automatically add brackets around the value in marc21 field 245h
Kyle M Hall [Thu, 22 Oct 2009 12:19:16 +0000 (12:19 +0000)]
Added plugin to automatically add brackets around the value in marc21 field 245h

This plugin will automatically add brackets around the value typed in at the time the field's focus is removed ( onblur ).
If the text in the field is already enclosed in brackets, it will do nothing.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4270 Instructions for loading patron attributes are wrong
Jane Wagner [Thu, 25 Feb 2010 17:15:00 +0000 (12:15 -0500)]
Bug 4270 Instructions for loading patron attributes are wrong

Corrects the on-screen instructions for loading multiple patron attribute fields

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoHide damaged loop in item form if empty
Paul Poulain [Wed, 24 Mar 2010 08:24:27 +0000 (09:24 +0100)]
Hide damaged loop in item form if empty

Follow-up : removing itemlost if empty as well

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoHide damaged loop in item form if empty
Jean-André Santoni [Wed, 10 Mar 2010 21:26:07 +0000 (22:26 +0100)]
Hide damaged loop in item form if empty

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoRemoved the language limit displaying twice in the OPAC advanced search
Jean-André Santoni [Mon, 8 Mar 2010 22:11:20 +0000 (23:11 +0100)]
Removed the language limit displaying twice in the OPAC advanced search

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4167, Tag link styled incorrectly on Cart popup
Owen Leonard [Tue, 23 Feb 2010 14:26:04 +0000 (09:26 -0500)]
Fix for Bug 4167, Tag link styled incorrectly on Cart popup

- Removing DOM creation of tag and hold links: if the Cart is working,
  the user must have JavaScript enabled. Therefore we can assume
  tagging and holds will work
- Conditionally displaying some JavaScript based on whether tagging
  or placing holds is allowed

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4294 use 'required' class on required fields on funds page
Nicole Engard [Tue, 2 Mar 2010 11:02:27 +0000 (06:02 -0500)]
bug 4294 use 'required' class on required fields on funds page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for acquisitions - Series title was not saving when adding new record
Chris Cormack [Sun, 28 Mar 2010 21:32:27 +0000 (10:32 +1300)]
Fix for acquisitions - Series title was not saving when adding new record

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(BUG #4346) replaces Basket grouping by Basket groups in acquisitions-toolbar.inc
Alex Arnaud [Mon, 29 Mar 2010 10:06:03 +0000 (12:06 +0200)]
(BUG #4346) replaces Basket grouping by Basket groups in acquisitions-toolbar.inc

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoRefactor for Human Readability
Colin Campbell [Fri, 19 Mar 2010 16:09:30 +0000 (16:09 +0000)]
Refactor for Human Readability

Fixes  generation of empty index page when total_parcels is a multiple of pagesize
Remove some calculations whose results were not used
Make variable names meaningful (results and count arnt)
Fix errors in pod syntax
Make what code does clearer to readers who are not computers
Use a subroutine

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4331 Remove cruft from acqui-home script
Colin Campbell [Tue, 23 Mar 2010 09:59:21 +0000 (09:59 +0000)]
Bug 4331 Remove cruft from acqui-home script

Remove unnecessary db calls and processing from acqui-home.pl
Do not duplicate processing of fields
Declare variables closer to use
Remove unnecessary holding vars
Replace some anonymous var names by something more meaningful
Do not generate a toggle variable use Template's LOOP vars

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4331 Index aqorders by budget_id
Colin Campbell [Tue, 23 Mar 2010 09:59:20 +0000 (09:59 +0000)]
Bug 4331 Index aqorders by budget_id

Calculation of budget spent and encumbered is done by
queries on aqorders by budget_id
Index budget_id to speed these queries

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for ampersand display problem in OPAC search results
Cindy Murdock Ames [Thu, 18 Mar 2010 21:01:43 +0000 (17:01 -0400)]
Fix for ampersand display problem in OPAC search results

This is a quick fix to XSLTParse4Display to make ampersands display
correctly in OPAC search results.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMT3204 : Fix unstranslatable strings in JavaScript
Henri-Damien LAURENT [Wed, 7 Apr 2010 13:01:20 +0000 (15:01 +0200)]
MT3204 : Fix unstranslatable strings in JavaScript

For an explanation, see:

http://wiki.koha.org/doku.php?id=en:development:codingguidelines#translatable_text

This bug blocks entirely serials module. It isn't possible
to create/edit a subscription. Brocken JavaScript prevents
Search for a vendor and Search for Biblio dialog box
to pop-up.

Problem with new strings and new html tags inside the strings
this patch removes them

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFixes bug 4365 hidelostitem syspref language reversed
Ian Walls [Thu, 1 Apr 2010 19:58:51 +0000 (19:58 +0000)]
Fixes bug 4365 hidelostitem syspref language reversed

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agotweak display of issuing library on staff reading history
Galen Charlton [Wed, 7 Apr 2010 14:54:08 +0000 (10:54 -0400)]
tweak display of issuing library on staff reading history

Following idea in patch submitted by Kyle Hall on 1 April 2010,
use issues.branchcode instead of issues.issuingbranch to set
displayed issuing library.  Also tweaked wording.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4375 - update koha link on auth template
Nicole Engard [Wed, 7 Apr 2010 10:17:25 +0000 (06:17 -0400)]
bug 4375 - update koha link on auth template

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofix POD for GetAllIssues
Galen Charlton [Wed, 7 Apr 2010 14:25:39 +0000 (10:25 -0400)]
fix POD for GetAllIssues

Please remember to update the POD if you change a
core function.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4358: remove disused ReadingHistory syspref and related code
Galen Charlton [Wed, 7 Apr 2010 14:21:01 +0000 (10:21 -0400)]
bug 4358: remove disused ReadingHistory syspref and related code

The ReadingHistory sytem preference is no longer used, and possibly
was used by only one library anyway.  Removed references to it; note
that had it been turned on, a patron viewing checkout history would have
seen old loans showing up twice.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug Fixing opac/opac-readingrecord.pl
Henri-Damien LAURENT [Fri, 26 Mar 2010 10:25:41 +0000 (11:25 +0100)]
Bug Fixing opac/opac-readingrecord.pl

There was some rebase issues on this script
Fixing Error 500
two calls to $issues as an array ref where it is now a hash ref

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(bug #4358) fix sql query in C4::Members::GetAllIssues
Nahuel ANGELINETTI [Wed, 31 Mar 2010 13:57:20 +0000 (15:57 +0200)]
(bug #4358) fix sql query in C4::Members::GetAllIssues

This fix the use of oldissues instead of old_issues table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago[MT3191] follow-up, removing warn
Paul Poulain [Wed, 24 Mar 2010 10:12:10 +0000 (11:12 +0100)]
[MT3191] follow-up, removing warn

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago[MT3191] various perl errors in script (merge conflict)
Paul Poulain [Tue, 23 Mar 2010 15:51:45 +0000 (16:51 +0100)]
[MT3191] various perl errors in script (merge conflict)

and SQL error solved

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago[MT2195] Display issuing branch in reading record
Jean-André Santoni [Fri, 12 Mar 2010 12:44:31 +0000 (13:44 +0100)]
[MT2195] Display issuing branch in reading record

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFollowup (MT #2920) fix reading record scripts:members/readingrec.pl
Henri-Damien LAURENT [Fri, 12 Mar 2010 16:09:06 +0000 (17:09 +0100)]
Followup (MT #2920) fix reading record scripts:members/readingrec.pl

Fixing Merge problem on opac/opac-readingrecord.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(MT #2920) fix reading record scripts
Nahuel ANGELINETTI [Mon, 15 Feb 2010 16:03:33 +0000 (17:03 +0100)]
(MT #2920) fix reading record scripts

This patch fix some perl ugly code to be more readable and lesser complex.
And it allow in intranet to order by issues.timestamp.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago[MT2358] Display issue date in member reading record
Jean-André Santoni [Wed, 3 Mar 2010 14:47:13 +0000 (15:47 +0100)]
[MT2358] Display issue date in member reading record

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4322 update typos on web services preferences
Nicole Engard [Sun, 14 Mar 2010 20:25:53 +0000 (16:25 -0400)]
bug 4322 update typos on web services preferences

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoUpdate copyright license to GPL version 2 or later for two cronjobs.
Lars Wirzenius [Wed, 17 Mar 2010 23:51:16 +0000 (12:51 +1300)]
Update copyright license to GPL version 2 or later for two cronjobs.

See http://lists.koha.org/pipermail/koha-devel/2010-March/011067.html
for confirmation that this is OK.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoTrapping fatal error that occurs if you call GetCOinsBiblio with a biblionumber that...
Chris Cormack [Mon, 22 Mar 2010 22:21:21 +0000 (11:21 +1300)]
Trapping fatal error that occurs if you call GetCOinsBiblio with a biblionumber that doesn't exist in the Koha database

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4317 fix typo in cataloging plugin
Nicole Engard [Mon, 29 Mar 2010 18:18:25 +0000 (14:18 -0400)]
bug 4317 fix typo in cataloging plugin

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoupdate patron help files
Nicole Engard [Mon, 29 Mar 2010 21:04:05 +0000 (17:04 -0400)]
update patron help files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoLower dependency on Storable to 2.20.
Lars Wirzenius [Tue, 30 Mar 2010 21:16:08 +0000 (10:16 +1300)]
Lower dependency on Storable to 2.20.

The Debian squeeze system has only 2.20, and the 2.21 does not
seem to be required for all tests to pass. Also, checked with
Galen Charlton and Henri-Damien LAURENT (who added the 2.21
dependency) on IRC that 2.21 did not have anything that was
required, compared to 2.20.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4361 Return Patron Expired to Sip Process
Colin Campbell [Wed, 7 Apr 2010 08:58:49 +0000 (09:58 +0100)]
Bug 4361 Return Patron Expired to Sip Process

Identify Patron Expiry so that it is returned in Patron Info Response

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4364 - SIP Checkout dates incorrect
Colin Campbell [Thu, 1 Apr 2010 20:02:14 +0000 (21:02 +0100)]
Bug 4364 - SIP Checkout dates incorrect

Change timestamp routine to do the right thing when passed an iso date
Otherwise was generating an epoch date of 0

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoSIP Patron management
Henri-Damien LAURENT [Wed, 10 Mar 2010 21:26:33 +0000 (22:26 +0100)]
SIP Patron management

Using Flag EXPIRED to notice whether Patron CAN or CANNOT checkout a book

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 2653 Protect against sending End of Message in Text
Colin Campbell [Tue, 23 Feb 2010 11:12:32 +0000 (11:12 +0000)]
Bug 2653 Protect against sending End of Message in Text

Remove any carriage returns in text data as they will be
interpreted as end of message by clients and cause communication failure

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoUpdating history
Chris Cormack [Mon, 5 Apr 2010 21:21:10 +0000 (09:21 +1200)]
Updating history

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdding when software.coop started supporting Koha to the history
Chris Cormack [Mon, 22 Feb 2010 20:10:55 +0000 (09:10 +1300)]
Adding when software.coop started supporting Koha to the history

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofix typo in variable name
Galen Charlton [Wed, 17 Mar 2010 13:15:45 +0000 (09:15 -0400)]
fix typo in variable name

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agotext for SCO Finish button
Nicolas Morin [Wed, 10 Mar 2010 21:26:27 +0000 (22:26 +0100)]
text for SCO Finish button

Simplifying finish button on SCO screen: it was a long sentence with a button saying "click here if you're done". Changed to "Finish". Changed the help accordingly.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoEscape input that goes in HTML; Reworked search history insert SQL
Srdjan Jankovic [Wed, 24 Feb 2010 00:41:24 +0000 (13:41 +1300)]
Escape input that goes in HTML; Reworked search history insert SQL

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4244, Use "checkouts" instead of "issues"
Owen Leonard [Tue, 23 Feb 2010 13:53:02 +0000 (08:53 -0500)]
Fix for Bug 4244, Use "checkouts" instead of "issues"

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3663 current head version changes to OPAC advanced search
Jane Wagner [Mon, 15 Mar 2010 17:32:32 +0000 (13:32 -0400)]
Bug 3663 current head version changes to OPAC advanced search

Copy Search button to top of screen, rearrange order of indexes in search
pulldown list (to Keyword, Title, Subject, then Author & the rest)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(MT #2962) add converted chars from ISO5426
Nahuel ANGELINETTI [Wed, 10 Mar 2010 21:45:21 +0000 (22:45 +0100)]
(MT #2962) add converted chars from ISO5426

This add 0xBE and 0xBD conversion to char table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(MT #3075) fix oe char from iso5426
Nahuel ANGELINETTI [Wed, 10 Mar 2010 21:45:20 +0000 (22:45 +0100)]
(MT #3075) fix oe char from iso5426

this add oe conversion in chartable for iso5426.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoUsing only default framework for koha2marclinks
Paul Poulain [Fri, 12 Mar 2010 17:23:20 +0000 (18:23 +0100)]
Using only default framework for koha2marclinks

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4291 - template edits to koha to marc mapping
Nicole Engard [Tue, 2 Mar 2010 09:43:16 +0000 (04:43 -0500)]
bug 4291 - template edits to koha to marc mapping

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoImprove display of information on Transfers to your library report
Owen Leonard [Thu, 11 Mar 2010 13:54:16 +0000 (08:54 -0500)]
Improve display of information on Transfers to your library report

- Use GetRecordValue() to show subtitle
- Show author
- Separate branch and call number display for better sorting
- Correct teriminology (reserve -> hold)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4316: Fixes leading and trailing spaces in barcode for cki.
Garry Collum [Sat, 13 Mar 2010 13:06:50 +0000 (08:06 -0500)]
Bug 4316: Fixes leading and trailing spaces in barcode for cki.

Copies the regexp from circulation.pl to strip leading and trailing spaces from barcodes to returns.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFixes for syndetics, some variables needed by the template were not being set
Chris Cormack [Tue, 16 Mar 2010 00:48:59 +0000 (13:48 +1300)]
Fixes for syndetics, some variables needed by the template were not being set

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4301, OPAC RSS feed link doesn't include sort parameter
Owen Leonard [Wed, 10 Mar 2010 14:43:50 +0000 (09:43 -0500)]
Fix for Bug 4301, OPAC RSS feed link doesn't include sort parameter

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4296, label search printing titles between buttons
Owen Leonard [Tue, 9 Mar 2010 19:59:51 +0000 (14:59 -0500)]
Fix for Bug 4296, label search printing titles between buttons

- Reformating display for readability
- Converting select/clear all buttons to links to match existing patterns
- Fixing "Results x of x" display which was broken for single-page sets

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>