wip/koha-chris_n.git
12 years agoSQL cleanup in new circ scripts: use placeholders
Galen Charlton [Tue, 1 Apr 2008 17:01:09 +0000 (12:01 -0500)]
SQL cleanup in new circ scripts: use placeholders

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agouse C4::Debug instead of checking DEBUG env var directly
Galen Charlton [Tue, 1 Apr 2008 17:01:08 +0000 (12:01 -0500)]
use C4::Debug instead of checking DEBUG env var directly

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofixed typo in template
Galen Charlton [Tue, 1 Apr 2008 17:01:07 +0000 (12:01 -0500)]
fixed typo in template

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoXHTML fixes for various circ templates
Galen Charlton [Tue, 1 Apr 2008 17:01:06 +0000 (12:01 -0500)]
XHTML fixes for various circ templates

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agochange references to 'reserves' in billing report template
Galen Charlton [Tue, 1 Apr 2008 17:01:05 +0000 (12:01 -0500)]
change references to 'reserves' in billing report template

New billing report has nothing to do with hold requests per se,
so change template variables in order to not confuse customizers.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agovarious date-related cleanups in circ
Galen Charlton [Tue, 1 Apr 2008 17:01:04 +0000 (12:01 -0500)]
various date-related cleanups in circ

* use Date::Calc to perform date arithmetic
* use Date::Calc::Today to consistently format the current date
* format date per syspref in overdue report

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agodisallow division by zero in hold ratio report
Galen Charlton [Tue, 1 Apr 2008 17:01:03 +0000 (12:01 -0500)]
disallow division by zero in hold ratio report

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoanother "Reserves" => "Hold" in template
Galen Charlton [Tue, 1 Apr 2008 17:01:02 +0000 (12:01 -0500)]
another "Reserves" => "Hold" in template

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agominor circ template cleanup
Galen Charlton [Tue, 1 Apr 2008 17:01:01 +0000 (12:01 -0500)]
minor circ template cleanup

[1] did some "Reserve" => "Hold" to keep language consistent
[2] Moved hold ratios report and billing report on circ
    home page to group with related reports

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAll patches to Koha 3 beta to date. All work with branches.
Darrell Ulm [Tue, 1 Apr 2008 17:01:00 +0000 (12:01 -0500)]
All patches to Koha 3 beta to date. All work with branches.

 Billing.pl     -- new, gives bills that occur in a range, works
 pendingreserves.pl  -- fixed, works now, with branches also
 reserveratios.pl  -- indicates distressed reserves
 itemslost.pl  -- Fix to this to make it more useful and fix bugs
 Itmes.pm -- small change to work for itemslost, should not affect
             anything else
 and all tmpl files.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding PATCRD print type
Chris Nighswonger [Tue, 1 Apr 2008 12:51:15 +0000 (08:51 -0400)]
Adding PATCRD print type

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofixed locating OPAC stylesheet in a "standard" install
Galen Charlton [Mon, 31 Mar 2008 22:08:55 +0000 (17:08 -0500)]
fixed locating OPAC stylesheet in a "standard" install

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofixed MODS biblio export on a "standard" install
Galen Charlton [Mon, 31 Mar 2008 22:08:54 +0000 (17:08 -0500)]
fixed MODS biblio export on a "standard" install

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobug 1986: fix card view in Z39.50 search results
Galen Charlton [Mon, 31 Mar 2008 21:58:02 +0000 (16:58 -0500)]
bug 1986: fix card view in Z39.50 search results

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofixed memory leak I introduced
Galen Charlton [Mon, 31 Mar 2008 21:19:53 +0000 (16:19 -0500)]
fixed memory leak I introduced

Accidentally introducing a circular reference in a
MARC::Record object does not lead to goodness, particularly
if you export lots and lots of them.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agowork around issue in MARC::Charset
Galen Charlton [Mon, 31 Mar 2008 16:57:18 +0000 (11:57 -0500)]
work around issue in MARC::Charset

Because of a bug in MARC::Charset 0.98, if a string to convert from
MARC-8 to UTF-8 has (a) one or more diacritics that (b) are only in character positions
128 to 255 inclusive, the resulting converted string is not in
UTF-8, but the legacy 8-bit encoding (e.g., ISO-8859-1).  As a result,
when such a record is converted to XML using ->as_xml_record(), the resulting
XML can be truncated at the offending character.  An example of such a record
is one that has a price in Briish pounds in the 260$c but no other diacritics.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding a couple of missing YUI js files; Adding comment preview to comments system...
Owen Leonard [Fri, 28 Mar 2008 19:23:43 +0000 (14:23 -0500)]
Adding a couple of missing YUI js files; Adding comment preview to comments system (needs review).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoImproving comments style and markup, adding highlighting for comments made by logged...
Owen Leonard [Fri, 28 Mar 2008 19:23:32 +0000 (14:23 -0500)]
Improving comments style and markup, adding highlighting for comments made by logged-in user.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrecting a small case-sensitive bug.
Chris Nighswonger [Fri, 28 Mar 2008 14:31:20 +0000 (10:31 -0400)]
Correcting a small case-sensitive bug.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofor DebugLevel=2; improved reporting of version numbers
Galen Charlton [Thu, 27 Mar 2008 19:40:15 +0000 (14:40 -0500)]
for DebugLevel=2; improved reporting of version numbers

Koha software and DB version numbers now reported;
also improved formatting of multi-line error messages.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoimproved formatting of fatal error messages sent to browser
Galen Charlton [Thu, 27 Mar 2008 19:40:14 +0000 (14:40 -0500)]
improved formatting of fatal error messages sent to browser

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofixed invocation of CGI::Carp::set_message
Galen Charlton [Thu, 27 Mar 2008 19:40:13 +0000 (14:40 -0500)]
fixed invocation of CGI::Carp::set_message

The message handler in C4::Context is now correctly
passed CGI::Carp.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobug 1890: fixing calls to C4::Search::SimpleSearch
Andrew Moore [Thu, 27 Mar 2008 16:39:20 +0000 (11:39 -0500)]
bug 1890: fixing calls to C4::Search::SimpleSearch

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug 1980: adding parameters to C4::Search::SimpleSearch to allow limiting the number...
Andrew Moore [Thu, 27 Mar 2008 16:39:19 +0000 (11:39 -0500)]
Bug 1980: adding parameters to C4::Search::SimpleSearch to allow limiting the number of results returned.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding file size limit to picture-upload.pl
Chris Nighswonger [Wed, 26 Mar 2008 14:32:51 +0000 (10:32 -0400)]
Adding file size limit to picture-upload.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFixes to make all label/patron card templates uniform
Chris Nighswonger [Wed, 26 Mar 2008 13:43:34 +0000 (09:43 -0400)]
Fixes to make all label/patron card templates uniform

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding sample label form for Patron Cards
Chris Nighswonger [Wed, 26 Mar 2008 13:21:12 +0000 (09:21 -0400)]
Adding sample label form for Patron Cards

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCatalogue => Search in staff home page
Galen Charlton [Wed, 26 Mar 2008 13:15:44 +0000 (08:15 -0500)]
Catalogue => Search in staff home page

Changed to match similar change in the menu
bar.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoavoid croak on latest CVS version of MARC::Record
Galen Charlton [Wed, 26 Mar 2008 12:54:58 +0000 (07:54 -0500)]
avoid croak on latest CVS version of MARC::Record

The semantics of MARC::Record->delete_field() changed
slightly in the latest CVS version of MARC::Record.
delete_field() will now croak if passed an undef
scalar, while the version of MARC::Record from CPAN
accepts that input.  Since some packages of MARC::Record
in the wild appear to be based on the CVS version, not
the CPAN version, added a check where needed to avoid
the croak.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMore work on patron card generation feature
Chris Nighswonger [Wed, 26 Mar 2008 10:01:35 +0000 (06:01 -0400)]
More work on patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding member search to patron card generation feature
Chris Nighswonger [Wed, 26 Mar 2008 10:01:34 +0000 (06:01 -0400)]
Adding member search to patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoWork on adding patron search to patron card generation feature.
Chris Nighswonger [Wed, 26 Mar 2008 10:01:33 +0000 (06:01 -0400)]
Work on adding patron search to patron card generation feature.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTweaking the interface of OPAC shelves to more closely match the pattern set by the...
Owen Leonard [Tue, 25 Mar 2008 20:22:56 +0000 (15:22 -0500)]
Tweaking the interface of OPAC shelves to more closely match the pattern set by the staff client. Simplifies and focuses on specific tasks.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoNotifying the user when they have selected no items and clicked 'Add to list.'
Owen Leonard [Tue, 25 Mar 2008 20:22:44 +0000 (15:22 -0500)]
Notifying the user when they have selected no items and clicked 'Add to list.'

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoVisual tweaks for login screen.
Owen Leonard [Tue, 25 Mar 2008 20:22:36 +0000 (15:22 -0500)]
Visual tweaks for login screen.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrection to prevent js error when table has no data.
Owen Leonard [Tue, 25 Mar 2008 20:22:29 +0000 (15:22 -0500)]
Correction to prevent js error when table has no data.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoChange LateOrders to inclusive <=, s/supplier/vendor , s/parcel/shipment.
Ryan Higgins [Tue, 25 Mar 2008 19:43:32 +0000 (14:43 -0500)]
Change LateOrders to inclusive <=, s/supplier/vendor , s/parcel/shipment.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agostill more rebuild_zebra refactoring
Galen Charlton [Tue, 25 Mar 2008 12:30:43 +0000 (07:30 -0500)]
still more rebuild_zebra refactoring

Merged duplicate code for indexing bibs and
authorities into a single index_records() function.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoIMPORTANT: added -z option to rebuild_zebra.pl
Galen Charlton [Tue, 25 Mar 2008 12:30:42 +0000 (07:30 -0500)]
IMPORTANT: added -z option to rebuild_zebra.pl

The -z option, when used in conjunction with -a and/or -b,
selects the records to reindex from the zebraqueue table.
Both record updates and record deletes are handled.

-z is cannot be used with -s or -r: the updated records
must always be freshly exported, and if zebraqueue
is to be processed, it's assumed that you don't want
to drop the Zebra index first.

This means that rebuild_zebra.pl -b -a -x can be
used as a cronjob to update the indexes periodically; it
is believed that this will offer much better indexing
performance on some setups as compared to zebraqueue_daemon.pl,
which uses Z39.50 extended services to send record updates
to Zebra.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agorebuild_zebra: exit if both -a and -x specified
Galen Charlton [Tue, 25 Mar 2008 12:30:41 +0000 (07:30 -0500)]
rebuild_zebra: exit if both -a and -x specified

At moment using both -a (index authorities) and
-x (export records as MARC XML) is not allowed -
if the Zebra authority database is using the DOM
filter, zebraidx will not be able to process the
exported records correctly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agomore rebuild_zebra.pl refactoring
Galen Charlton [Tue, 25 Mar 2008 12:30:40 +0000 (07:30 -0500)]
more rebuild_zebra.pl refactoring

1. Logic to fix up record IDs, UNIMARC 100 field,
   and record leader now in separate functions.
2. Removed (incorrect) logic to save corrected record
   in database.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agorefactor rebuild_zebra: new routine for invoking zebraidx
Galen Charlton [Tue, 25 Mar 2008 12:30:39 +0000 (07:30 -0500)]
refactor rebuild_zebra: new routine for invoking zebraidx

Created a routine for calling zebraidx, replacing
separate invocations for bibs and authorities.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agorebuild_zebra.pl: removed disused $limit option
Galen Charlton [Tue, 25 Mar 2008 12:30:38 +0000 (07:30 -0500)]
rebuild_zebra.pl: removed disused $limit option

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMarkup corrections. Tweaking holds interface.
Owen Leonard [Mon, 24 Mar 2008 20:20:11 +0000 (15:20 -0500)]
Markup corrections. Tweaking holds interface.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding function to empty cart when user logs out.
Owen Leonard [Mon, 24 Mar 2008 20:20:03 +0000 (15:20 -0500)]
Adding function to empty cart when user logs out.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMarkup correction.
Owen Leonard [Mon, 24 Mar 2008 20:19:56 +0000 (15:19 -0500)]
Markup correction.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRemoving a couple of unused templates
Owen Leonard [Mon, 24 Mar 2008 20:19:50 +0000 (15:19 -0500)]
Removing a couple of unused templates

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRemoving old patronimages js check, adding missing patron image variable to script.
Owen Leonard [Mon, 24 Mar 2008 20:19:39 +0000 (15:19 -0500)]
Removing old patronimages js check, adding missing patron image variable to script.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoReformatting holds list to better match checkouts list
Owen Leonard [Mon, 24 Mar 2008 20:19:31 +0000 (15:19 -0500)]
Reformatting holds list to better match checkouts list

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFixing bug that caused all items in checked-out list to show up as overdue; Reformatt...
Owen Leonard [Mon, 24 Mar 2008 20:19:24 +0000 (15:19 -0500)]
Fixing bug that caused all items in checked-out list to show up as overdue; Reformatting table and tweaking select all/none behavior.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFixing bug where language menu footer wouldn't "stick."
Owen Leonard [Mon, 24 Mar 2008 20:19:15 +0000 (15:19 -0500)]
Fixing bug where language menu footer wouldn't "stick."

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBeginning work on Calendar compatibility fixes
Owen Leonard [Mon, 24 Mar 2008 20:19:08 +0000 (15:19 -0500)]
Beginning work on Calendar compatibility fixes

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSend borrower mods to branchemail instead of syspref.
Ryan Higgins [Mon, 24 Mar 2008 09:07:52 +0000 (04:07 -0500)]
Send borrower mods to branchemail instead of syspref.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdd print slip to hold confirmation dialog.
Ryan Higgins [Mon, 24 Mar 2008 09:07:51 +0000 (04:07 -0500)]
Add print slip to hold confirmation dialog.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoReport borrower's home library on reserves library mismatch.
Ryan Higgins [Mon, 24 Mar 2008 09:07:50 +0000 (04:07 -0500)]
Report borrower's home library on reserves library mismatch.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agojust some notes for RMs :-)
Joshua Ferraro [Sun, 23 Mar 2008 05:49:25 +0000 (01:49 -0400)]
just some notes for RMs :-)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoupdating installation docs
Joshua Ferraro [Sun, 23 Mar 2008 04:42:11 +0000 (00:42 -0400)]
updating installation docs

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoupdating release notes
Joshua Ferraro [Sun, 23 Mar 2008 04:18:22 +0000 (00:18 -0400)]
updating release notes

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoupdating translations for release
Joshua Ferraro [Sun, 23 Mar 2008 03:34:33 +0000 (23:34 -0400)]
updating translations for release

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoTwo utilities to help manage translations
Joshua Ferraro [Sun, 23 Mar 2008 00:51:25 +0000 (20:51 -0400)]
Two utilities to help manage translations

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding some new translations
Joshua Ferraro [Sat, 22 Mar 2008 20:34:17 +0000 (16:34 -0400)]
Adding some new translations

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUpdating translations for release
Joshua Ferraro [Sat, 22 Mar 2008 19:43:35 +0000 (15:43 -0400)]
Updating translations for release

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoExperimental XSLT-based display of results and details pages To enable, create two...
Joshua Ferraro [Sat, 22 Mar 2008 02:32:19 +0000 (22:32 -0400)]
Experimental XSLT-based display of results and details pages To enable, create two new YesNo sysprefs: XSLTDetailsDisplay and XSLTResultsDisplay, and set them to ON. Feature to be expanded in a future version, this experimental code is for proof of concept only and doesn't introduce any changes if sysprefs are not created.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agodo not let MARC::Batch open MARC files
Galen Charlton [Fri, 21 Mar 2008 19:37:55 +0000 (14:37 -0500)]
do not let MARC::Batch open MARC files

The version of MARC::Batch->new() distributed with version
2.0.0 of MARC::Record, if given a file name, will
open it using the ':utf8' layer.  This results in an
incorrect character conversion when processing records
in the MARC-8 character encoding.

To avoid this, batch jobs that use MARC::Batch now
open the file themselves, then pass the file handle
to MARC::Batch->new().

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoremove some unneeded use statements
Galen Charlton [Fri, 21 Mar 2008 19:37:54 +0000 (14:37 -0500)]
remove some unneeded use statements

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFixing branch select onChange() function, hopefully fixes Bug 1957, Holiday Calendar...
Owen Leonard [Fri, 21 Mar 2008 13:20:04 +0000 (08:20 -0500)]
Fixing branch select onChange() function, hopefully fixes Bug 1957, Holiday Calendar broken in Internet Explorer

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agopartial fix for bug 1417
Galen Charlton [Thu, 20 Mar 2008 22:32:14 +0000 (17:32 -0500)]
partial fix for bug 1417

The Notes field should now be displayed correctly
when editing an order - the query in GetOrder
was modified to have aqorder's notes column
appear last, which means that it is the one
selected for the data hash (instead of biblio.notes
or biblioitems.notes).

This is an ugly fix - GetOrder needs to be
refactored so that it doesn't depend on
selecting all columns from several different
tables.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobug: 1953. cleaning up Acquisition::NewOrder just a little bit.
Andrew Moore [Thu, 20 Mar 2008 22:32:13 +0000 (17:32 -0500)]
bug: 1953. cleaning up Acquisition::NewOrder just a little bit.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobug: 1953. using placeholders in C4::Acquisition::NewOrder.
Andrew Moore [Thu, 20 Mar 2008 22:32:12 +0000 (17:32 -0500)]
bug: 1953. using placeholders in C4::Acquisition::NewOrder.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobug 1953: using placeholders in C4::Acquisition::GetParcel
Andrew Moore [Thu, 20 Mar 2008 22:32:11 +0000 (17:32 -0500)]
bug 1953: using placeholders in C4::Acquisition::GetParcel

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobug 1953: using placeholders in C4::Acquisition::GetParcel
Andrew Moore [Thu, 20 Mar 2008 22:32:10 +0000 (17:32 -0500)]
bug 1953: using placeholders in C4::Acquisition::GetParcel

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSome reworking of suggestions management interface in preparation for tackling hdl...
Owen Leonard [Thu, 20 Mar 2008 19:25:15 +0000 (14:25 -0500)]
Some reworking of suggestions management interface in preparation for tackling hdl's proposal of wider scope. Includes change to Suggestions.pm to enable passing of borrowernumber to the template.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobug fix : 1804 : Now empty authorities and empty search return results.
Henri-Damien LAURENT [Thu, 20 Mar 2008 16:31:11 +0000 (17:31 +0100)]
bug fix : 1804 : Now empty authorities and empty search return results.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoBug fixing : 1746 : password was not escaped.
Henri-Damien LAURENT [Thu, 20 Mar 2008 15:08:34 +0000 (16:08 +0100)]
Bug fixing : 1746 : password was not escaped.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoSome Bugfixing for Acquisitions : ModOrderReceive would create 2 lines in baskets...
Henri-Damien LAURENT [Thu, 20 Mar 2008 15:08:33 +0000 (16:08 +0100)]
Some Bugfixing for Acquisitions : ModOrderReceive would create 2 lines in baskets And titles were displayed twice in parcel.tmpl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobug fixing : when closing a basket, supplier was searched by name, not by id.
Henri-Damien LAURENT [Thu, 20 Mar 2008 10:36:53 +0000 (11:36 +0100)]
bug fixing : when closing a basket, supplier was searched by name, not by id.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agodon't display the name of the library in singleBranchMode
Joshua Ferraro [Thu, 20 Mar 2008 14:12:21 +0000 (10:12 -0400)]
don't display the name of the library in singleBranchMode

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofixing singlebranchmode display issues
Joshua Ferraro [Thu, 20 Mar 2008 13:58:52 +0000 (09:58 -0400)]
fixing singlebranchmode display issues

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadding OPACShelfbrowse to OPAC tab
Joshua Ferraro [Thu, 20 Mar 2008 13:39:33 +0000 (09:39 -0400)]
adding OPACShelfbrowse to OPAC tab

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agofixing availability limit
Joshua Ferraro [Thu, 20 Mar 2008 13:38:54 +0000 (09:38 -0400)]
fixing availability limit

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoadding title indexes for 780
Joshua Ferraro [Thu, 20 Mar 2008 12:54:49 +0000 (08:54 -0400)]
adding title indexes for 780

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agodon't show library facet if singleBranchMode is ON
Joshua Ferraro [Wed, 19 Mar 2008 21:46:26 +0000 (17:46 -0400)]
don't show library facet if singleBranchMode is ON

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoAdding a couple benchmark scripts
Joshua Ferraro [Wed, 19 Mar 2008 19:33:36 +0000 (15:33 -0400)]
Adding a couple benchmark scripts

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoobey opaclanguagesdisplay syspref
Joshua Ferraro [Wed, 19 Mar 2008 13:46:39 +0000 (09:46 -0400)]
obey opaclanguagesdisplay syspref

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agobug 1953: use bind variables in C4::Acquisition::GetPendingOrders
Andrew Moore [Wed, 19 Mar 2008 20:26:35 +0000 (15:26 -0500)]
bug 1953: use bind variables in C4::Acquisition::GetPendingOrders

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agouse bind variables in C4::Acquisition::GetPendingOrders
Andrew Moore [Wed, 19 Mar 2008 20:26:34 +0000 (15:26 -0500)]
use bind variables in C4::Acquisition::GetPendingOrders

I improved the tests a bit for this module so that they at least skip
if there's not enough data in the database to test with.
I was unable to test the actual execution path through the change I actually made.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMarkup correction.
Owen Leonard [Wed, 19 Mar 2008 20:19:02 +0000 (15:19 -0500)]
Markup correction.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoFix to enable OPACUserCSS preference (allows user to add CSS globally in the OPAC...
Owen Leonard [Wed, 19 Mar 2008 20:18:53 +0000 (15:18 -0500)]
Fix to enable OPACUserCSS preference (allows user to add CSS globally in the OPAC via an embedded style block)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMore changes to properly implement opacuserlogin preference.
Owen Leonard [Wed, 19 Mar 2008 20:18:41 +0000 (15:18 -0500)]
More changes to properly implement opacuserlogin preference.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoChanges to properly implement opacuserlogin preference.
Owen Leonard [Wed, 19 Mar 2008 20:18:34 +0000 (15:18 -0500)]
Changes to properly implement opacuserlogin preference.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoChanges to allow highlighting of current tab on user pages.
Owen Leonard [Wed, 19 Mar 2008 20:18:27 +0000 (15:18 -0500)]
Changes to allow highlighting of current tab on user pages.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUpdates to tweak the way suggestions and suggestions links display when various sugge...
Owen Leonard [Wed, 19 Mar 2008 20:18:20 +0000 (15:18 -0500)]
Updates to tweak the way suggestions and suggestions links display when various suggestions-related prefs are on or off.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCommenting out unused call to get_batches.
Chris Nighswonger [Wed, 19 Mar 2008 12:05:33 +0000 (08:05 -0400)]
Commenting out unused call to get_batches.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoModifications to viewlog.pl to keep it in the context from which it was called.
Chris Nighswonger [Wed, 19 Mar 2008 11:29:27 +0000 (07:29 -0400)]
Modifications to viewlog.pl to keep it in the context from which it was called.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoCorrecting warn concerning kohaversion.
Chris Nighswonger [Wed, 19 Mar 2008 11:20:08 +0000 (07:20 -0400)]
Correcting warn concerning kohaversion.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoUpdating patronimages syspref to reflect current sysprefs.sql
Chris Nighswonger [Wed, 19 Mar 2008 11:10:01 +0000 (07:10 -0400)]
Updating patronimages syspref to reflect current sysprefs.sql

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agouse bind variables in GetBorrowersWhoHaveNotBorrowedSince query
Galen Charlton [Wed, 19 Mar 2008 15:11:18 +0000 (10:11 -0500)]
use bind variables in GetBorrowersWhoHaveNotBorrowedSince query

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agomore old_issues SQL cleanup
Galen Charlton [Wed, 19 Mar 2008 15:11:17 +0000 (10:11 -0500)]
more old_issues SQL cleanup

* no need to test for 'returndate is null' in queries
  on old_issues
* added more stylistic corrections

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoRevert "Updatedatabase UPDATE For more_subfields_xml to be added to deleteditems...
Galen Charlton [Wed, 19 Mar 2008 15:11:16 +0000 (10:11 -0500)]
Revert "Updatedatabase UPDATE For more_subfields_xml to be added to deleteditems at the same time as it is to items."

This reverts commit eaac37aa6ea8c4f2b79adaa4186bc08a9ac9efd4.

Rev 052 in updatedatabase.pl already adds more_subfields_xml
to deleteditems - the reverted patch would attempt to add
more_subfields_xml to deleteditems twice for anybody
upgrading from < 048.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
12 years agoMore problems with old_issues.
Henri-Damien LAURENT [Wed, 19 Mar 2008 15:11:15 +0000 (10:11 -0500)]
More problems with old_issues.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>