wip/koha-chris_n.git
10 years agoCleanup date handling in routing.pl
Colin Campbell [Fri, 20 Nov 2009 19:41:08 +0000 (19:41 +0000)]
Cleanup date handling in routing.pl

Remove dead code
Clarify the loop assigning dates
Remove the cause of undef warnings in the log

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdd dependency Authen::CAS::Client
Colin Campbell [Wed, 2 Dec 2009 13:13:58 +0000 (13:13 +0000)]
Add dependency Authen::CAS::Client

Required CPAN module was missing from deoendency list

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix count in supplier dropdown in serials/claims.pl
Colin Campbell [Tue, 5 Jan 2010 17:35:56 +0000 (17:35 +0000)]
Fix count in supplier dropdown in serials/claims.pl

Previous patch still used old variable name to get count causing
incorrect value to be returned

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoCorrect misleading text
Colin Campbell [Thu, 14 Jan 2010 16:15:56 +0000 (16:15 +0000)]
Correct misleading text

Some koha acq terminology is confusing to new users so lets at least
be consistent in our usages we are adding to the basket here not an order

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 2576 - fix XHTML validation errors generated by previous commit
Galen Charlton [Mon, 8 Feb 2010 14:14:41 +0000 (09:14 -0500)]
bug 2576 - fix XHTML validation errors generated by previous commit

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 2576 reopened -- turn off fines elsewhere in OPAC account
Jane Wagner [Thu, 22 Oct 2009 15:21:21 +0000 (11:21 -0400)]
Bug 2576 reopened -- turn off fines elsewhere in OPAC account

The original patch allowed use of the OPACFinesTab syspref to turn off
the Fines tab in the OPAC patron record.  However, a column for fines
still appears in the listing of overdues, and as a tab on the line with
Overdues, Holds, Fines, etc.  This patch turns off the other instances of
fine columns/displays if the syspref is off.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoset koha_login_context in order to get auto-login for SCO working
Galen Charlton [Mon, 8 Feb 2010 14:01:25 +0000 (09:01 -0500)]
set koha_login_context in order to get auto-login for SCO working

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoDB rev 114 - tweak AutoSelfCheckAllowed, AutoSelfCheckID, and AutoShelfCheckPass
Galen Charlton [Mon, 8 Feb 2010 13:46:21 +0000 (08:46 -0500)]
DB rev 114 - tweak  AutoSelfCheckAllowed, AutoSelfCheckID, and AutoShelfCheckPass

* made AutoSelfCheckID and AUtoSelfCheckPass type free instead of textarea
* consolidated DB updates into one

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3738 Automate login to web-based self-check system
Jane Wagner [Fri, 30 Oct 2009 13:44:38 +0000 (09:44 -0400)]
Bug 3738 Automate login to web-based self-check system

Some small, single-branch corporate and special libraries use unattended self-checkout stations, and would like to automate the staff login, so that just going to the sco/sco-main.pl URL would bring the self-check up ready for patron use.  This patch create three sysprefs, AutoSelfCheckAllowed, and AutoSelfCheckID/AutoSelfCheckPass. If the site wants to allow automated login, staff would then need to create the selfcheck user record and enter that login ID and password into the sysprefs.  The kohaclone/opac/sco/sco-main.pl script has been modified to check these sysprefs and pass values (if present and allowed) into the self-check URL.  The URL then bypasses the staff login page and comes up ready for checkout, waiting for the first patron barcode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3920 - Add 2 syspref to activate XSLT use in OPAC/Intranet
Frédéric Demians [Sat, 6 Feb 2010 18:17:06 +0000 (19:17 +0100)]
Bug 3920 - Add 2 syspref to activate XSLT use in OPAC/Intranet

- Add two syspref:
  - OPACXSLTResultsDisplay
  - OPACXSLDetailsDispay
- Add them to .pref files and dispatch them beetween OPAC and Search
  tab.
- Upgrade DB version to 3.2 .113
- Fix something wrong in UNIMARCslim2intranetDetail.xsl
- Display OPAC result and detail pages using those syspref.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBZ4104: Removes tagging in staff client
Matthias Meusburger [Mon, 8 Feb 2010 12:46:32 +0000 (13:46 +0100)]
BZ4104: Removes tagging in staff client

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3752: Fixed XHTML errors in opac-MARCdetail.tmpl
Garry Collum [Tue, 3 Nov 2009 00:58:49 +0000 (19:58 -0500)]
Bug 3752: Fixed XHTML errors in opac-MARCdetail.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugs 3646 and 2651: Changes the output of compact.xsl from html to xhtml.
Garry Collum [Fri, 18 Sep 2009 16:29:57 +0000 (12:29 -0400)]
Bugs 3646 and 2651: Changes the output of compact.xsl from html to xhtml.

Changes the output of compact.xsl to XHTML for catalogue/showmarc.pl?viewas=card.

Adds <title> element in <head>.
Removes link to nonexistent css file (bug 2651).

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4129 fix display of html on the overdue report
Nicole Engard [Fri, 5 Feb 2010 04:18:01 +0000 (23:18 -0500)]
bug 4129 fix display of html on the overdue report

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3662: Invalid XHTML in update-child.tmpl - resubmission.
Garry Collum [Sun, 7 Feb 2010 13:50:15 +0000 (08:50 -0500)]
Bug 3662: Invalid XHTML in update-child.tmpl - resubmission.

Missing </td> closing tag.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 3923 OrderPdfFormat default was wrong on update
Nicole Engard [Fri, 5 Feb 2010 09:23:33 +0000 (04:23 -0500)]
bug 3923 OrderPdfFormat default was wrong on update

I went back and updated updatedatabase so that anyone else who updates
doesn't end up with the wrong value, this does not fix those who
upgraded and have the wrong value in there already.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoRemoving noisy warn in C4/XSLT.pm
Chris Cormack [Sun, 7 Feb 2010 21:49:27 +0000 (10:49 +1300)]
Removing noisy warn in C4/XSLT.pm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix: Correcting conditional for branch code check
Chris Nighswonger [Mon, 8 Feb 2010 03:06:36 +0000 (22:06 -0500)]
Bugfix: Correcting conditional for branch code check

Also removing needless conditionals on redirects.

Thanks to Braedon Vickers for catching the incorrect conditional.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoRemove cause of some warnings in order display
Colin Campbell [Mon, 8 Feb 2010 12:20:24 +0000 (12:20 +0000)]
Remove cause of some warnings in order display

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4125 - Reformat with perldoc bulkmarcimport.pl doc
Frédéric Demians [Sat, 6 Feb 2010 11:31:11 +0000 (12:31 +0100)]
Bug 4125 - Reformat with perldoc bulkmarcimport.pl doc

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4113, Failed renewal from circulation screen results in malformed table
Owen Leonard [Fri, 5 Feb 2010 17:36:21 +0000 (12:36 -0500)]
Fix for Bug 4113, Failed renewal from circulation screen results in malformed table

Renewal failure message should appear in renewal checkbox column just
like it does in moremember.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4114: Follow-up patch for duplicate id in opac-detail.
Garry Collum [Fri, 5 Feb 2010 20:47:34 +0000 (15:47 -0500)]
Bug 4114: Follow-up patch for duplicate id in opac-detail.

Adds the id back in <body>.  Renames the id in <div>.

The only reference to this id was in sanop.css, to which opac-detail.tmpl does not link.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug: 4124 - Submit button in csv-profile.tmpl floats to the right.
Garry Collum [Fri, 5 Feb 2010 23:54:47 +0000 (18:54 -0500)]
Bug: 4124 - Submit button in csv-profile.tmpl floats to the right.

Typo - class='actin' should be class='action' in the <form> tag.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobugs 3989, 3990, 3996, 3997 - sys prefs resolved
Nicole Engard [Thu, 4 Feb 2010 08:47:22 +0000 (03:47 -0500)]
bugs 3989, 3990, 3996, 3997 - sys prefs resolved

bug 3989 - RoutingSerials & RenewSerialAddsSuggestion
moved to serials tab and descriptions updated

bug 3990 - add RoutingListAddReserves pref to serials tab

bug 3996 - add intranetbookbag pref to staff client tab

but 3997 - add ReservesControlBranch to circulation tab

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 3993 & 4119 add WebBasedSelfCheck pref to interface
Nicole Engard [Thu, 4 Feb 2010 07:56:18 +0000 (02:56 -0500)]
bug 3993 & 4119 add WebBasedSelfCheck pref to interface

bug 4119 - add WebBasedSelfCheck to sys pref interface
bug 3993 - added quotes around OpacMaintenance description so it appears

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4033 add missing OverdueNoticeBcc to the interface
Nicole Engard [Thu, 4 Feb 2010 07:45:03 +0000 (02:45 -0500)]
bug 4033 add missing OverdueNoticeBcc to the interface

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 3994 & 3995 add missing OPAC privacy preferences to interface
Nicole Engard [Thu, 4 Feb 2010 07:36:27 +0000 (02:36 -0500)]
bug 3994 & 3995 add missing OPAC privacy preferences to interface

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4087 add missing OpacAddMastheadLibraryPulldown to prefs interface
Nicole Engard [Thu, 4 Feb 2010 07:08:31 +0000 (02:08 -0500)]
bug 4087 add missing OpacAddMastheadLibraryPulldown to prefs interface

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 3986 add CAS preferences to interface
Nicole Engard [Thu, 4 Feb 2010 07:24:16 +0000 (02:24 -0500)]
bug 3986 add CAS preferences to interface

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoadded subscription.enddate to kohastructure.sql
Galen Charlton [Fri, 5 Feb 2010 13:46:58 +0000 (08:46 -0500)]
added subscription.enddate to kohastructure.sql

kohastructure.sql update missed in DB rev 3.01.00.071

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4117 Fix system error in routing slip recepients popup
Colin Campbell [Fri, 5 Feb 2010 13:08:04 +0000 (13:08 +0000)]
Bug 4117 Fix system error in routing slip recepients popup

order_by parameter should be an arrayref of hashrefs
Have made order surname, firstname asc (see bug 4067)
do not generate logged warnings by manipulating undef

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 3985 add missing acq preferences
Nicole Engard [Thu, 4 Feb 2010 06:57:29 +0000 (01:57 -0500)]
bug 3985 add missing acq preferences

This patch adds AcqCreateItem, CurrencyFormat, gist, and OrderPdfFormat back into the sys prefs interface.

Still missing are acquisitions, OrderPdfTemplate, and emailPurchaseSuggestions.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agocorrected POD for GetMember()
Galen Charlton [Fri, 5 Feb 2010 13:21:36 +0000 (08:21 -0500)]
corrected POD for GetMember()

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofixed remaining calls to GetMember() that used old argument style
Galen Charlton [Fri, 5 Feb 2010 13:15:04 +0000 (08:15 -0500)]
fixed remaining calls to GetMember() that used old argument style

New way, correct way to use GetMember is

GetMember(field => fieldvalue[, field2 => field2value ...]);

e.g.,

GetMember(borrowernumber => $borrowernumber);

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoremoved unconditional warn
Galen Charlton [Fri, 5 Feb 2010 13:05:43 +0000 (08:05 -0500)]
removed unconditional warn

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4108 Catch cases when GetMember is generating errors
Colin Campbell [Thu, 4 Feb 2010 18:22:48 +0000 (18:22 +0000)]
Bug 4108 Catch cases when GetMember is generating errors

Fixed two calls where new interface was not used
Arguably new syntax allows more options than we require but it was not catching
error cases (when 0 or undef is passed). It also can now be called in ways
which would validly return multiple hits but explicitly does not
(nor does calling code expect this)
This patch should quieten the flood of errors

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofinished add SpineLabelShowPrintOnBibDetails (DBrev 112)
Galen Charlton [Fri, 5 Feb 2010 12:19:46 +0000 (07:19 -0500)]
finished add SpineLabelShowPrintOnBibDetails (DBrev 112)

* improve wording
* add to new system preferences editor

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 1248 - Add a "quick spine label" print to the bib item page in cataloging
Kyle M Hall [Mon, 21 Dec 2009 13:12:46 +0000 (13:12 +0000)]
Bug 1248 - Add a "quick spine label" print to the bib item page in cataloging

Turn on the system preference SpineLabelShowPrintOnBibDetails and a link for the spinelabel printer will appear for each item on catalogue/detail.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoadded two new intranet directories to installation list
Galen Charlton [Fri, 5 Feb 2010 11:48:35 +0000 (06:48 -0500)]
added two new intranet directories to installation list

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix: Fixing a broken link in the patron card layout editor
Chris Nighswonger [Fri, 5 Feb 2010 01:25:28 +0000 (20:25 -0500)]
Bugfix: Fixing a broken link in the patron card layout editor

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4114: Fixes duplicate id definition in opac-detail.tmpl
Garry Collum [Fri, 5 Feb 2010 01:58:12 +0000 (20:58 -0500)]
Bug 4114: Fixes duplicate id definition in opac-detail.tmpl

Removes "id=opac-detail" from <body> tag.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix: Adding Graphics::Magick module to About Koha page
Chris Nighswonger [Fri, 5 Feb 2010 02:37:38 +0000 (21:37 -0500)]
Bugfix: Adding Graphics::Magick module to About Koha page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix: Implimentation of JpegBlob and AltJpeg methods
Chris Nighswonger [Thu, 4 Feb 2010 19:47:30 +0000 (14:47 -0500)]
Bugfix: Implimentation of JpegBlob and AltJpeg methods

Implimentation of JpegBlob and AltJpeg methods in C4::Creators::PDF

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3691: Invalid XHTML in about.tmpl
Garry Collum [Sat, 3 Oct 2009 18:11:37 +0000 (14:11 -0400)]
Bug 3691: Invalid XHTML in about.tmpl

Fixes several missing closing html tags.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix: Correcting hash dereferencing for barcode data
Chris Nighswonger [Thu, 4 Feb 2010 21:25:31 +0000 (16:25 -0500)]
Bugfix: Correcting hash dereferencing for barcode data

This patch corrects hash dereferencing syntax.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoStyle correction
Owen Leonard [Thu, 4 Feb 2010 16:11:43 +0000 (11:11 -0500)]
Style correction

- Use <div class="dialog alert"> for warnings, not "dialog error"

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix: Correcting name of help file in Label Creator Tool
Chris Nighswonger [Thu, 4 Feb 2010 17:08:50 +0000 (12:08 -0500)]
Bugfix: Correcting name of help file in Label Creator Tool

The Label Profile Editor help file was mis-named. This patch corrects
the name.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix: Correcting hash dereferencing for image data
Chris Nighswonger [Thu, 4 Feb 2010 15:20:47 +0000 (10:20 -0500)]
Bugfix: Correcting hash dereferencing for image data

This patch corrects hash dereferencing syntax.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix: Adding error trapping for missing or invalid branch code
Chris Nighswonger [Thu, 4 Feb 2010 15:20:46 +0000 (10:20 -0500)]
Bugfix: Adding error trapping for missing or invalid branch code

This patch adds code to trap, log, and return an intelligent message to the user
when a missing or invalid branch code is passed in. This condition can occur if
the user is logged in as the kohaadmin or the user has multiple instances of the staff
client open and has switched users in some instance.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofix 4066 - add rotating collections to toolbar menu
Nicole Engard [Wed, 3 Feb 2010 18:28:37 +0000 (13:28 -0500)]
fix 4066 - add rotating collections to toolbar menu

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFollow up Patch for moving the itemtype icons directory from sfdicons to vokal
Brendan A. Gallagher [Thu, 4 Feb 2010 06:33:13 +0000 (06:33 +0000)]
Follow up Patch for moving the itemtype icons directory from sfdicons to vokal

Sponsered by vokal

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoChanged the folder location for Vokal icons from sdficons to vokal...
brendan [Wed, 3 Feb 2010 21:26:26 +0000 (21:26 +0000)]
Changed the folder location for Vokal icons from sdficons to vokal...

These icons where contributed by Vokal

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdding the vokal directory for icons
brendan [Wed, 3 Feb 2010 22:18:14 +0000 (22:18 +0000)]
Adding the vokal directory for icons

Contributed by VOKAL

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMore fixes for Bug 2600, HTML tags in titles not escaped in many places
Owen Leonard [Wed, 3 Feb 2010 20:20:17 +0000 (15:20 -0500)]
More fixes for Bug 2600, HTML tags in titles not escaped in many places

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFixes for Bug 2600, HTML tags in titles not escaped in many places
Owen Leonard [Wed, 3 Feb 2010 18:48:00 +0000 (13:48 -0500)]
Fixes for Bug 2600, HTML tags in titles not escaped in many places

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoadded intranetbookbag syspref to install scripts
Galen Charlton [Wed, 3 Feb 2010 21:44:24 +0000 (16:44 -0500)]
added intranetbookbag syspref to install scripts

Had been omitted, so wasn't appearing in fresh
installs.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4099: fix adding new patron category
Galen Charlton [Wed, 3 Feb 2010 21:14:55 +0000 (16:14 -0500)]
bug 4099: fix adding new patron category

Added categories.enrolmentperioddate to kohastructure.sql, which commit
dc9991 had omitted.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofix POD errors reported by xt/author/podcorrectness.t
Galen Charlton [Wed, 3 Feb 2010 20:56:19 +0000 (15:56 -0500)]
fix POD errors reported by xt/author/podcorrectness.t

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix pod markup errors in C4/Budgets.pm
Colin Campbell [Wed, 3 Feb 2010 14:45:27 +0000 (14:45 +0000)]
Fix pod markup errors in C4/Budgets.pm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFixes for Bug 3089, Date entry fields should indicate required date format
Owen Leonard [Wed, 3 Feb 2010 15:43:23 +0000 (10:43 -0500)]
Fixes for Bug 3089, Date entry fields should indicate required date format

- Added include, date-format.inc, which shows format, e.g. "(DD/MM/YYYY)"
- Hint shows expected date format based on system preference
- Removing calendar.inc include from templates which don't use it

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoremove mysql5.0 errors in patroncard upgrade
Nicole Engard [Tue, 2 Feb 2010 07:58:30 +0000 (02:58 -0500)]
remove mysql5.0 errors in patroncard upgrade

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4086, categorycode on patron search confusing
Owen Leonard [Wed, 3 Feb 2010 16:51:03 +0000 (11:51 -0500)]
Fix for Bug 4086, categorycode on patron search confusing

- Changed 'categorycode' to 'category'
- Formatted additional options to be more compact
- Returning patron search page to wide layout following
  removal of patron filter from the sidebar
- Corrected some other markup that was causing validation errors

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix: Upping the byte size limit of patron images
Chris Nighswonger [Wed, 3 Feb 2010 18:07:32 +0000 (13:07 -0500)]
Bugfix: Upping the byte size limit of patron images

This brings it more in line with the size limit placed on other images
uploaded for use on patron cards.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agofollow-up to bug 3854: resolve budget period language issues
Nicole Engard [Wed, 3 Feb 2010 13:42:51 +0000 (08:42 -0500)]
follow-up to bug 3854: resolve budget period language issues

top level: "Root Budget" becomes "Budget"
second level: "Budget" becomes "Fund"
third level and below: "Sub-Budget" is also a "Fund", but for things
like the "create sub-budget" link, they'll be changed to "create child
fund".

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agobug 4101 patroncards changed to patron card creator
Nicole Engard [Wed, 3 Feb 2010 14:21:26 +0000 (09:21 -0500)]
bug 4101 patroncards changed to patron card creator

There are references to patroncards in label text through out the patron card creator - I have changed it to 'patron card creator'

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 3808 Display correct number of records in neworderbiblio screen
Colin Campbell [Wed, 3 Feb 2010 19:34:58 +0000 (19:34 +0000)]
Bug 3808 Display correct number of records in neworderbiblio screen

New version of patch to apply against 3.2alpha
Also remove related FIXME message that was displaying to the user

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix:[3.2] Corrects bad behavior in opac-reserve.pl
Chris Nighswonger [Wed, 3 Feb 2010 13:47:33 +0000 (08:47 -0500)]
Bugfix:[3.2] Corrects bad behavior in opac-reserve.pl

When AllowOnShelfHolds is enabled, but maxreserves is NULL, attempting to reserve
an item results in a basically blank page being returned with no error message.

This patch adds a check to see if the check for maxreserves has returned a value and
bypasses the application of it if it has not.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago(bug #4075) add use of getrecordvalue in opac-detail
Nahuel ANGELINETTI [Wed, 3 Feb 2010 10:57:18 +0000 (11:57 +0100)]
(bug #4075) add use of getrecordvalue in opac-detail

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4085 - Subscription type length wasn't taken into account
Frédéric Demians [Wed, 3 Feb 2010 07:41:53 +0000 (08:41 +0100)]
Bug 4085 - Subscription type length wasn't taken into account

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoremove duplicate lines
Galen Charlton [Wed, 3 Feb 2010 00:43:31 +0000 (19:43 -0500)]
remove duplicate lines

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoset DB revision to 3.01.00.111 for 3.2-lapha release
Galen Charlton [Wed, 3 Feb 2010 00:39:18 +0000 (19:39 -0500)]
set DB revision to 3.01.00.111 for 3.2-lapha release

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoRevert "Populated MARC 952$2 field for serials-edit.pl"
Galen Charlton [Wed, 3 Feb 2010 00:26:04 +0000 (19:26 -0500)]
Revert "Populated MARC 952$2 field for serials-edit.pl"

This reverts commit 708b4797e3fc253b8dac2a0fa0d16e30839196ef.

Had introduced following error:

Global symbol "$value" requires explicit package name at C4/Biblio.pm line 2381.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoRotating Collections Fixes
Kyle M Hall [Wed, 27 Jan 2010 14:53:41 +0000 (14:53 +0000)]
Rotating Collections Fixes

This patch does the following:
  * Fixes the typos in updatedatabase.pl ( updates colBranchcode to varchar(10)
  * Adds the rotating_collections template files that somehow were not committed
  * Adds a missing sub from RotatingCollections.pm that must been deleted by accident
  * Adds the neccessary hooks in returns.pl to warn that and item needs to be returned
    to the branch that currently holds the collection.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4077 - Tweak UNIMARC default framework
Frédéric Demians [Fri, 29 Jan 2010 11:30:17 +0000 (12:30 +0100)]
Bug 4077 - Tweak UNIMARC default framework

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix updatedatabase.pl mess coming from last merge?
Frédéric Demians [Fri, 29 Jan 2010 07:46:08 +0000 (08:46 +0100)]
Fix updatedatabase.pl mess coming from last merge?

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix: Stop C4::Koha from filling the log with pesky warns
Chris Nighswonger [Thu, 28 Jan 2010 19:14:52 +0000 (14:14 -0500)]
Bugfix: Stop C4::Koha from filling the log with pesky warns

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix: Stop opac/opac-detail.pl from filling the log with pesky warns
Chris Nighswonger [Thu, 28 Jan 2010 19:49:29 +0000 (14:49 -0500)]
Bugfix: Stop opac/opac-detail.pl from filling the log with pesky warns

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4081: Fixes incorrect html tag in opac-advsearch.tmpl.
Garry Collum [Sat, 30 Jan 2010 17:23:36 +0000 (12:23 -0500)]
Bug 4081: Fixes incorrect html tag in opac-advsearch.tmpl.

Fixes <legend> that is closed with </label>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 2505: Adds warnings to opac-ics.pl and opac-search-history.pl
Garry Collum [Wed, 3 Feb 2010 00:05:16 +0000 (19:05 -0500)]
Bug 2505: Adds warnings to opac-ics.pl and opac-search-history.pl

No warnings generated from opac-ics.pl
Fixes warnings for opac-search-history.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMerge commit 'workbuffer.org-koha/translation' into to-push
Galen Charlton [Wed, 3 Feb 2010 00:10:11 +0000 (19:10 -0500)]
Merge commit 'workbuffer.org-koha/translation' into to-push

Conflicts:
installer/data/mysql/updatedatabase.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years ago4074 Bugfix: The 'Subject(s)' link(s) are malformed resulting in no search results
Chris Nighswonger [Tue, 2 Feb 2010 04:18:09 +0000 (23:18 -0500)]
4074 Bugfix: The 'Subject(s)' link(s) are malformed resulting in no search results

This bug was introduced by commit d51332698b2cce43542a58e53fd916df99329158
which removed the inability to do a search on anything contianing a colon (:).

This patch expands the regexp to only normalize true limit operators and leave
all other colons (:) intact.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoEnhancement: This patch adds a 'cardnumber' parameter and checks
Chris Nighswonger [Wed, 27 Jan 2010 02:32:05 +0000 (21:32 -0500)]
Enhancement: This patch adds a 'cardnumber' parameter and checks

to see if it is present when the script is called. If it is, the patron
information is retrieved and borrowernumber set from that. Otherwise,
the patron information is retrieved by borrowernumber.

The changes in this patch do not require porting to any other Koha code.

Sponsored by www.digital-loom.com

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4083 subroutine HasItems needs to be exported
Colin Campbell [Mon, 1 Feb 2010 11:27:44 +0000 (11:27 +0000)]
Bug 4083 subroutine HasItems needs to be exported

Calls to the unexported subroutine result in system error

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix some code issues in serials scripts
Colin Campbell [Mon, 1 Feb 2010 19:48:29 +0000 (19:48 +0000)]
Fix some code issues in serials scripts

Add use warnings where not present
Remove unused variables
Avoid redeclarations of variables
trailing spaces trimmed

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4088 Due Date Not formated in checkout response
Colin Campbell [Tue, 2 Feb 2010 12:51:02 +0000 (12:51 +0000)]
Bug 4088 Due Date Not formated in checkout response

due date was not being formatted as a timestamp
but being passed as epoch seconds

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4095 Remove incorrect help text
Colin Campbell [Tue, 2 Feb 2010 18:24:47 +0000 (18:24 +0000)]
Bug 4095 Remove incorrect help text

Subscription end date is required before receiving against
the subscription. If not set the subscription needs
renewal before use.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoChange style of return errors to be more noticable.
Michael Hafen [Tue, 2 Feb 2010 18:48:53 +0000 (11:48 -0700)]
Change style of return errors to be more noticable.

Changed the class of the div from message to error.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 3970, Warn user when there is no active currency
Owen Leonard [Fri, 29 Jan 2010 15:52:05 +0000 (10:52 -0500)]
Fix for Bug 3970, Warn user when there is no active currency

- Adds warning to budget admin pages
- Adds warning to currency admin page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoMarkup and formatting corrections.
Owen Leonard [Fri, 29 Jan 2010 16:02:22 +0000 (11:02 -0500)]
Markup and formatting corrections.

- XHTML validity
- Can't nest TMPL_IF inside <input>--breaks translator

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4080, OPAC hold screen doesn't obey OPACDisplayRequestPriority pref
Owen Leonard [Fri, 29 Jan 2010 20:06:53 +0000 (15:06 -0500)]
Fix for Bug 4080, OPAC hold screen doesn't obey OPACDisplayRequestPriority pref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoAdding missing images for collapsible syspref sections
Owen Leonard [Fri, 29 Jan 2010 20:47:06 +0000 (15:47 -0500)]
Adding missing images for collapsible syspref sections

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoUpdating history docs
Chris Cormack [Sat, 30 Jan 2010 22:37:22 +0000 (11:37 +1300)]
Updating history docs

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBugfix: Adding Creators system preferences to new system preferences editor
Chris Nighswonger [Sat, 30 Jan 2010 15:49:18 +0000 (10:49 -0500)]
Bugfix: Adding Creators system preferences to new system preferences editor

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4089, tools menu floating to bottom of CSV Profiles, and others
Owen Leonard [Tue, 2 Feb 2010 15:26:01 +0000 (10:26 -0500)]
Fix for Bug 4089, tools menu floating to bottom of CSV Profiles, and others

- Moving nested TMPL_IFs out of <option> tags (breaks translator)
- Fixing markup to match conventions for form structure
- Removing duplicate form fields (bad merge?)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4097, Problems with print stylesheet and add item screen
Owen Leonard [Tue, 2 Feb 2010 20:07:12 +0000 (15:07 -0500)]
Fix for Bug 4097, Problems with print stylesheet and add item screen

- consolidating some details in print.css
- moving overflow:scroll from additem.tmpl to staff-global.css
- overriding overflow:scroll in print.css

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 2505: Enables warnings in opac-readingrecord.pl
Garry Collum [Tue, 2 Feb 2010 20:31:49 +0000 (15:31 -0500)]
Bug 2505: Enables warnings in opac-readingrecord.pl

Enables warnings and fixes the resulting warnings in opac-readingrecord.pl.  The "description" variable in opac-readingrecord.tmpl was pulling a value from another source, probably an included template.  Change the name to 'itypedescription' to resolve the conflict.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoFix for Bug 4092, suggestion date missing from manage suggestions
Owen Leonard [Tue, 2 Feb 2010 21:00:54 +0000 (16:00 -0500)]
Fix for Bug 4092, suggestion date missing from manage suggestions

Date was missing because of incorrect variable name in opac-suggestions.pl
Thanks to HDL for the fix.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 2505: Enables warnings in the opac error pages.
Garry Collum [Tue, 2 Feb 2010 22:02:00 +0000 (17:02 -0500)]
Bug 2505: Enables warnings in the opac error pages.

No warnings were generated in the logs, except that the template for 402 does not exist.  I will follow this up with another patch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoBug 4098: Fixes missing error templates.
Garry Collum [Tue, 2 Feb 2010 22:21:38 +0000 (17:21 -0500)]
Bug 4098: Fixes missing error templates.

Adds the missing 402.tmpl.
Fixes the <h4> element in 400, 401, 403, and 500, all of which displayed 404.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
10 years agoNew Itemtype images from Vokal. This should create directory sfdicons
brendan [Fri, 29 Jan 2010 05:53:53 +0000 (00:53 -0500)]
New Itemtype images from Vokal. This should create directory sfdicons

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>