Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 36516: Fix useless warning from translation script

Browse source 
I lost too much time trying to know what the translation script outputs
  sh: 1: Syntax error: end of file unexpected

To recreate:
touch 'koha-tmpl/intranet-tmpl/prog/en/modules/<' (yes, don't ask!)
koha-translate -i de-DE --dev kohadev
or
koha-translate -u de-DE --dev kohadev

And you get the shell error without any ideas what's happening!

With this patch applied you will not get any errors because the quote
will actually copy the file (what is expected).

But without the quote the cp command will fail and the explanation will be
displayed
sh: 1: Syntax error: end of file unexpected
Cannot copy /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/< to /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/de-DE/modules/< at /kohadevbox/koha/misc/translator/tmpl_process3.pl line 385.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Jonathan Druart 2024-04-04 11:13:04 +02:00 committed by Katrin Fischer
parent cc94547524
commit 0026ee3e97
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
misc/translator/tmpl_process3.pl
View file

@ -381,7 +381,7 @@ if ($action eq 'install') {
} else {
# just copying the file
mkdir_recursive($targetdir) unless -d $targetdir;
system("cp -f $input $target");
system("cp -f '$input' '$target'") == 0 or warn "Cannot copy $input to $target";
print STDERR "Copying $input...\n" unless $quiet;
}
}