Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 13531: QA follow up

Browse source 
A minor QA comment.

::: misc/migration_tools/bulkmarcimport.pl
@@ +271,5 @@
>          my ( $error, $results, $totalhits ) = C4::Search::SimpleSearch( $query, 0, 3, [$server] );
> +        # changed to warn so able to continue with one broken record
> +        if ( defined $error ) {
> +            warn "unable to search the database for duplicates : $error";
> +            next;

For consistency with the rest of the script, should this perhaps be:

next RECORD;

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Thomas 2015-01-14 20:20:36 +00:00 committed by Tomas Cohen Arazi
parent e1cdb4ebfa
commit 002b79c200
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
misc/migration_tools/bulkmarcimport.pl
View file

@ -272,7 +272,7 @@ RECORD: while ( ) {
# changed to warn so able to continue with one broken record # changed to warn so able to continue with one broken record
if ( defined $error ) { if ( defined $error ) {
warn "unable to search the database for duplicates : $error"; warn "unable to search the database for duplicates : $error";
next; next RECORD;
} }
$debug && warn "$query $server : $totalhits"; $debug && warn "$query $server : $totalhits";
if ( $results && scalar(@$results) == 1 ) { if ( $results && scalar(@$results) == 1 ) {