Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 1953 [3/6]: refactoring to remove superfluous where clause.

Browse source 
refactored the SQL query to remove a confusing and superfluous 'WHERE 1' clause.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
This commit is contained in:
Andrew Moore 2008-07-29 11:42:47 -05:00 committed by Joshua Ferraro
parent 9ecd632001
commit 00ad2d7e69
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
C4/Koha.pm
View file

@ -891,17 +891,22 @@ sub displayServers {
my ( $position, $type ) = @_;
my $dbh = C4::Context->dbh;
my $strsth = "SELECT * FROM z3950servers where 1";
my $strsth = 'SELECT * FROM z3950servers';
my @where_clauses;
my @bind_params;
if ( $position ) {
push @bind_params, $position;
$strsth .= ' AND position = ? ';
push @where_clauses, ' position = ? ';
}
if ( $type ) {
push @bind_params, $type;
$strsth .= ' AND type = ? ';
push @where_clauses, ' type = ? ';
}
if ( @where_clauses ) {
$strsth .= ' WHERE ' . join( ' AND ', @where_clauses );
}
my $rq = $dbh->prepare($strsth);