Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34908: Sort item types alphabetically by description when adding a new empty record as an order to a basket

Browse source 
To test:

1. Go to Koha administration -> Item types. Add a new item type "B" with the description "Test" so it will be obvious if it is sorted by the code "B" instead of the description "Test".
2. Go to Acquisitions. Add to a basket from a new empty record
3. In the Catalog details section, note the Item type dropdown. Confirm your "Test" item type, is showing near the top of the list, indicating it has been sorted based on the code "B"
4. Apply patch and restart services. Refresh the page.
5. Open the Item type dropdown again and confirm your "Test" item type is showing in the expected alphabetical order.

NC amended patch - tidied

Sponsored-by: South Taranaki District Council
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 0ef83c041d)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Aleisha Amohia 2023-09-26 22:40:01 +00:00 committed by Fridolin Somers
parent 247b9da172
commit 0237ad8eb4
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
acqui/neworderempty.pl
View file

@ -361,7 +361,7 @@ if ($basketobj->effective_create_items eq 'ordering' && !$ordernumber) {
); );
} }
my @itemtypes = Koha::ItemTypes->search->as_list; my @itemtypes = Koha::ItemTypes->search( {}, { order_by => { -asc => "description" } } )->as_list;
if ( defined $from_subscriptionid ) { if ( defined $from_subscriptionid ) {
# Get the last received order for this subscription # Get the last received order for this subscription