Browse Source

Bug 23855: Fix "Mark selected suggestion as" status

On the suggestions management page (suggestion/suggestion.pl) you can
select suggestions and change their status.
But it only works for "ACCEPTED" or "REJECTED".

Maybe caused by bug 22905.

Test plan:
Select at least one suggestion on the screen and select the "Pending"
status.
=> The status of the selected suggestions must have been updated

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
remotes/origin/19.11.x
Jonathan Druart 5 years ago
committed by Martin Renvoize
parent
commit
030eb694a8
Signed by: martin.renvoize GPG Key ID: 422B469130441A0F
  1. 4
      suggestion/suggestion.pl

4
suggestion/suggestion.pl

@ -196,15 +196,12 @@ elsif ($op eq "change" ) {
my $accepted_by = $input->param('acceptedby');
if ( $STATUS eq "ACCEPTED" ) {
$suggestion = {
STATUS => $STATUS,
accepteddate => dt_from_string,
acceptedby => C4::Context->userenv->{number},
};
}
elsif ( $STATUS eq "REJECTED" ) {
$suggestion = {
STATUS => $STATUS,
rejecteddate => dt_from_string,
rejectedby => C4::Context->userenv->{number},
};
@ -212,6 +209,7 @@ elsif ($op eq "change" ) {
if ($STATUS) {
$suggestion->{manageddate} = dt_from_string;
$suggestion->{managedby} = C4::Context->userenv->{number};
$suggestion->{STATUS} = $STATUS;
}
if ( my $reason = $input->param("reason$tabcode") ) {
if ( $reason eq "other" ) {

Loading…
Cancel
Save