Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 25426: (QA follow-up) Small fixes to POD and INSERT IGNORE or datatabase update

Browse source 
* Makes sure the system preference is added with INSERT IGNORE
* Some smaller fixes/additions to the POD of get_return_branch_policy

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Katrin Fischer 2022-10-03 11:31:06 +02:00 committed by Tomas Cohen Arazi
parent ef0bf75eed
commit 0313a44ca7
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Koha/CirculationRules.pm
View file

@ -479,9 +479,9 @@ sub clone {
my $returnbranch = Koha::CirculationRules->get_return_branch_policy($item);
Returns the branch to use for returning the item based on the
item type, and a branch selected via CircControlReturnsBrnch.
item type, and a branch selected via CircControlReturnsBranch.
The return value is the branch to which to return item. Possible values:
The return value is the branch to which to return the item. Possible values:
noreturn: do not return, let item remain where checked in (floating collections)
homebranch: return to item's home branch
holdingbranch: return to issuer branch
@ -490,7 +490,7 @@ This searches branchitemrules in the following order:
* Same branchcode and itemtype
* Same branchcode, itemtype '*'
* branchcode '*', same itemtype
* branchcode and itemtype '*'
* branchcode '*' and itemtype '*'
=cut

2
installer/data/mysql/atomicupdate/bug_25426.pl
View file

@ -8,7 +8,7 @@ return {
my ($dbh, $out) = @$args{qw(dbh out)};
$dbh->do(q{
INSERT INTO systempreferences VALUES (
INSERT IGNORE INTO systempreferences VALUES (
'CircControlReturnsBranch','ItemHomeLibrary','ItemHomeLibrary|ItemHoldingLibrary|CheckInLibrary',
'Specify the agency that controls the return policy','Choice'
)