Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34972: (QA follow-up) Remove second transfer from Circulation.t

Browse source 
Removing the manual transfer and rightaway doing the Reserve
transfer. One test description was misleading too.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 7f22156b8f)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit dce78a0ecd)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Marcel de Rooy 2024-05-03 09:07:17 +00:00 committed by Lucas Gass
parent 292c334e61
commit 04126b54eb
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
t/db_dependent/Circulation.t
View file

@ -5498,12 +5498,8 @@ subtest 'Checkout should correctly terminate a transfer' => sub {
my $do_transfer = 1; my $do_transfer = 1;
ModItemTransfer( $item->itemnumber, $library_1->branchcode, ModItemTransfer( $item->itemnumber, $library_1->branchcode,
$library_2->branchcode, 'Manual' ); $library_2->branchcode, 'Reserve' );
ModReserveAffect( $item->itemnumber, undef, $do_transfer, $reserve_id ); ModReserveAffect( $item->itemnumber, undef, $do_transfer, $reserve_id );
ModItemTransfer(
$item->itemnumber, $library_1->branchcode,
$library_2->branchcode, 'Reserve'
); # To put the Reason, it's what does returns.pl...
my $hold = Koha::Holds->find($reserve_id); my $hold = Koha::Holds->find($reserve_id);
is( $hold->found, 'T', 'Hold is in transit' ); is( $hold->found, 'T', 'Hold is in transit' );
my $transfer = $item->get_transfer; my $transfer = $item->get_transfer;
@ -5516,7 +5512,7 @@ subtest 'Checkout should correctly terminate a transfer' => sub {
$transfer = $transfer->get_from_storage; $transfer = $transfer->get_from_storage;
isnt( $transfer->datearrived, undef ); isnt( $transfer->datearrived, undef );
$hold = $hold->get_from_storage; $hold = $hold->get_from_storage;
is( $hold->found, undef, 'Hold is waiting' ); is( $hold->found, undef, 'Hold is not waiting or transit' );
is( $hold->priority, 1, ); is( $hold->priority, 1, );
}; };