Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31214: Make subfield code non-editable in MARC framework editor

Browse source 
The subfield code field became editable in framework
editor due to a regression that happened during the
switch from a previous template framework koha used
to the new Template toolkit framework currently in use:
Bug 5917 : Swapping templates over (5884fb1000)
The regression happened due to the template syntax
not being updated to the new one in this particular
case.

Note: The subfield code field doesn't align with the
      other fields anymore after this patch. However,
      this alignment issue is in every other Koha form
      in intranet and should be fixed in the global
      CSS rules.

1) Apply patch
2) Browse to
   /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=995&frameworkcode=AR
3) Notice the subfield code is non-editable
4) Notice the subfield code is still editable in the New tab.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Joonas Kylmälä 2022-08-07 11:24:12 +00:00 committed by Tomas Cohen Arazi
parent 2395f781fd
commit 045ead15fd
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
View file

@ -159,11 +159,11 @@
<fieldset class="rows">
<legend>Basic constraints</legend>
<ol>
[% IF ( subfieldcode == 0 || subfieldcode ) %]
[% IF ( loo.subfieldcode == 0 || loo.subfieldcode ) %]
<li>
<span class="label">Subfield code:</span>
[% loo.subfieldcode | html %]
<input type="hidden" name="tagsubfield" value="[% loo.subfieldcode | html %]" />
<input type="hidden" id="tagsubfield[% loo.row | html %]" name="tagsubfield" value="[% loo.subfieldcode | html %]" />
</li>
[% ELSE %]
<li>