Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32379: Add check on existing item

Browse source 
Simplest fix; bail out with output_error.

Test plan:
Try /cgi-bin/koha/cataloguing/additem.pl?biblionumber=1&op=saveitem&itemnumber=999999
Note: Replace 1 by existing biblionumber, and iitem 999999 should not exist.
You should get the 404 screen now.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 0677a53e14)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 7890c068fa)
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
This commit is contained in:
Marcel de Rooy 2023-11-02 10:47:50 +00:00 committed by Pedro Amorim
parent 5027f0c8c1
commit 04feadb6bf
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
cataloguing/additem.pl
View file

@ -541,7 +541,10 @@ if ($op eq "additem") {
my $itemnumber = $input->param('itemnumber');
my $item = Koha::Items->find($itemnumber);
# FIXME Handle non existent item
unless ($item) {
C4::Output::output_error( $input, '404' );
exit;
}
my $olditemlost = $item->itemlost;
my @columns = Koha::Items->columns;
my $new_values = $item->unblessed;