Bug 31861: Table controls on checkouts table are buttons

This patch updates the style of DataTables buttons (columns, export, and
configure), in cases where the buttons are the only control being
displayed (no page controls, filter, etc).

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Circulation and check an item out to a patron.
- If necessary, click the "Show checkouts" button to reveal the table of
  checkouts.
- The "Columns," "Export," and "Configure" controls should look the same
  as they do in other situations, with no button-style border.
- Go to Circulation -> Check in and check in the item. The table of
  checked-in items should show the same style controls.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss

@@ -548,61 +548,6 @@ tbody {
         }
     }
 
-    button,
-    div,
-    a {
-        &.dt-button {
-            background: transparent none;
-            border: 0;
-            color: #000;
-            font-size: 1em;
-            line-height: 1.7em;
-            margin: 3px 3px 0;
-            padding: 0 .5em;
-
-            &::before {
-                content: "";
-            }
-
-            &.disabled {
-                color: #999;
-                cursor: default;
-
-                a,
-                span {
-                    background: transparent none;
-                }
-            }
-
-            &:active,
-            &:focus {
-                background: transparent none;
-                border: 0;
-                box-shadow: none;
-                text-shadow: none;
-
-                &:not( .disabled ):hover:not( .disabled ) {
-                    background: transparent none;
-                    box-shadow: none;
-                }
-            }
-
-            &:hover {
-                background: transparent none;
-                border: 0;
-
-                &:not( .disabled ) {
-                    background: transparent none;
-                }
-            }
-
-            &.active:not( .disabled ):hover:not( .disabled ) {
-                background: transparent none;
-                box-shadow: none;
-            }
-        }
-    }
-
     input {
         &[type="search"] {
             border: 1px solid #CCC;
@@ -615,6 +560,62 @@ tbody {
     }
 } /* /.pager */
 
+button,
+div,
+a {
+    &.dt-button {
+        background: transparent none;
+        border: 0;
+        color: #000;
+        font-size: 1em;
+        line-height: 1.7em;
+        margin: 3px 3px 0;
+        padding: 0 .5em;
+
+        &::before {
+            content: "";
+        }
+
+        &.disabled {
+            color: #999;
+            cursor: default;
+
+            a,
+            span {
+                background: transparent none;
+            }
+        }
+
+        &:active,
+        &:focus {
+            background: transparent none;
+            border: 0;
+            box-shadow: none;
+            text-shadow: none;
+
+            &:not( .disabled ):hover:not( .disabled ) {
+                background: transparent none;
+                box-shadow: none;
+            }
+        }
+
+        &:hover {
+            background: transparent none;
+            border: 0;
+
+            &:not( .disabled ) {
+                background: transparent none;
+                border: 0;
+            }
+        }
+
+        &.active:not( .disabled ):hover:not( .disabled ) {
+            background: transparent none;
+            box-shadow: none;
+        }
+    }
+}
+
 .toptabs {
     .pager {
         margin: 0;
@@ -781,6 +782,7 @@ div {
     border-top: 1px solid #EEE;
     display: flex;
     flex-grow: 1;
+    justify-content: flex-end;
     margin-top: .5em;
     padding-top: .5em;
 }

koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt

@@ -1417,7 +1417,7 @@
                     "bPaginate":false,
                     "bInfo":false,
                     "bSort":false,
-                    "dom": 'B<"clearfix">t',
+                    "dom": '<"table_controls"B>rt',
                     }, table_settings);
 
             $("#exemptcheck").change(function () {

koha-tmpl/intranet-tmpl/prog/js/checkouts.js

@@ -276,7 +276,7 @@ $(document).ready(function() {
                 "sProcessing": msg_loading,
             },
             "bAutoWidth": false,
-            "dom": 'B<"clearfix">rt',
+            "dom": '<"table_controls"B>rt',
             "aoColumns": [
                 {
                     "mDataProp": function( oObj ) {
@@ -708,7 +708,7 @@ $(document).ready(function() {
         if ( ! relativesIssuesTable ) {
             relativesIssuesTable = KohaTable("relatives-issues-table", {
                 "bAutoWidth": false,
-                "dom": 'B<"clearfix">rt',
+                "dom": '<"table_controls"B>rt',
                 "aaSorting": [],
                 "aoColumns": [
                     {