Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35006: OPAC holdings table - Fix sort for library columns

Browse source 
This patch updates the holdings table on the OPAC's bibliographic detail
page so that home and current library columns can be sorted correctly by
library name. There have been changes to the way the template shows
these values, but the DataTables "data-sort" attribute on the table cell
had not been updated accordingly.

To test, apply the patch set the OpacLocationBranchToDisplay system
preference to "home and holding libraries."

- Make sure home and holding library columns are not hidden in the
  table settings under Administration -> Table settings -> OPAC ->
  holdingst.
- Locate a bibliographic record in the OPAC which has multiple items
  from different libraries.
- Test that the home and current library columns sort correctly by
  library name.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2023-10-10 12:03:18 +00:00 committed by Tomas Cohen Arazi
parent 0128ce5b10
commit 06d182bc82
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
View file

@ -1249,13 +1249,13 @@
</td>
[% END %]
[% IF ( OpacLocationBranchToDisplay == 'holding' || OpacLocationBranchToDisplay == 'both' ) %]
<td class="location" property="seller" data-order="[% ITEM_RESULT.branchname| html %]">
<link property="itemOffered" href="#record" />
<link property="businessFunction" href="http://purl.org/goodrelations/v1#LeaseOut">
[%# Show opac_info or branchurl from holding library %]
[% SET holding_library_name = Branches.GetName( ITEM_RESULT.holdingbranch ) %]
[% SET holding_library_url = Branches.GetURL( ITEM_RESULT.holdingbranch ) %]
<td class="location" property="seller" data-order="[% holding_library_name | html %]">
<link property="itemOffered" href="#record" />
<link property="businessFunction" href="http://purl.org/goodrelations/v1#LeaseOut">
[% IF ( ITEM_RESULT.holding_library_info ) %]
<a href="[% holding_library_url | url %]" class="library_info" data-info="[% ITEM_RESULT.holding_library_info | html %]" data-name="[% holding_library_name | html %]">
<i class="fa fa-info-circle" aria-hidden="true"></i> [% holding_library_name | html %]
@ -1276,13 +1276,13 @@
[% END %]
[% IF ( OpacLocationBranchToDisplay == 'home' || OpacLocationBranchToDisplay == 'both' ) %]
<td class="location" property="seller">
<link property="itemOffered" href="#record" />
<link property="businessFunction" href="http://purl.org/goodrelations/v1#LeaseOut">
[%# Show opac_info or branchurl from home library %]
[% SET home_library_name = Branches.GetName( ITEM_RESULT.homebranch ) %]
[% SET home_library_url = Branches.GetURL( ITEM_RESULT.homebranch ) %]
<td class="location" property="seller" data-order="[% home_library_name | html %]">
<link property="itemOffered" href="#record" />
<link property="businessFunction" href="http://purl.org/goodrelations/v1#LeaseOut">
[% IF ( ITEM_RESULT.home_library_info ) %]
<a href="[% home_library_url | url %]" class="library_info" data-info="[% ITEM_RESULT.home_library_info | html %]" data-name="[% home_library_name | html %]">
<i class="fa fa-info-circle" aria-hidden="true"></i> [% home_library_name | html %]