Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 18372 - transits are not created at check in despite user responsing Yes to the prompt

Browse source 
If the AutomaticItemReturn system preference is set to "Don't" and you
check in an item which belongs to another library, a dialog will ask you
if you want to transfer. This patch corrects a bug to enable the "Yes"
buttons to work, triggering the transfer.

To test, apply the patch and check in an item which belongs to another
library. In the dialog, click the 'Yes' button and confirm that the item
has been made 'in transit' to the correct library.

Perform the same test with the 'Yes, print slip' and 'No' buttons and
confirm they are working correctly.

Since this patch changes the behavior of many other popups triggered
from this template, test other operations which trigger a 'print slip'
option like:

- Checking in an item which is part of a rotating collection
- Checking in an item which is on hold for a patron

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Owen Leonard 2017-04-11 16:45:40 +00:00 committed by Kyle M Hall
parent 8e5c9bab4e
commit 07156cf8fd
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
View file

@ -140,7 +140,6 @@ $(document).ready(function () {
});
[% END %]
$('.openWin').on("click",function(e){
e.preventDefault();
Dopop( $(this).data("url") );
});
});
@ -410,10 +409,10 @@ $(document).ready(function () {
Transfer now?<br />
<form method="post" action="returns.pl" name="mainform" id="mainform">
[% IF itemnumber %]
<button type="submit" name="dotransfer" class="print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber %]&amp;&amp;branchcode=[% returnbranch %]&amp;op=slip"><i class="fa fa-print"></i> Yes, print slip</button>
<button type="submit" name="dotransfer" value="Yes" class="print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber %]&amp;&amp;branchcode=[% returnbranch %]&amp;op=slip"><i class="fa fa-print"></i> Yes, print slip</button>
[% END %]
<button type="submit" name="dotransfer" class="submit"><i class="fa fa-check"></i> Yes</button>
<button type="submit" name="notransfer" class="submit"><i class="fa fa-times"></i> No</button>
<button type="submit" name="dotransfer" value="Yes" class="submit"><i class="fa fa-check"></i> Yes</button>
<button type="submit" name="notransfer" value="No" class="submit"><i class="fa fa-times"></i> No</button>
<input type="hidden" name="tobranch" value="[% returnbranch %]" />
<input type="hidden" name="transferitem" value="[% itemnumber %]" />
<input type="hidden" name="exemptfine" value="[% exemptfine %]" />