Browse Source

Bug 16224: Fix t/db_dependent/Reports_Guided.t

This test:

is( scalar @{ get_saved_reports( $report_ids[0] ) }, 1,
"filter takes report id" );

can fail when $report_ids[0] is a substring of some saved_sql fields
from other reports (reports that have a different id than
$report_ids[0]).
We can only be sure that get_saved_reports will return at least 1
report.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>
new_12478_elasticsearch
Julian Maurice 8 years ago
committed by Brendan Gallagher
parent
commit
08017f89f1
  1. 3
      t/db_dependent/Reports_Guided.t

3
t/db_dependent/Reports_Guided.t

@ -70,8 +70,7 @@ like( $report_ids[2], '/^\d+$/', "Save_report returns an id for third" );
is( scalar @{ get_saved_reports() },
$count, "$count reports have been added" );
is( scalar @{ get_saved_reports( $report_ids[0] ) },
1, "filter takes report id" );
ok( 0 < scalar @{ get_saved_reports( $report_ids[0] ) }, "filter takes report id" );
#Test delete_report
is (delete_report(),undef, "Without id delete_report returns undef");

Loading…
Cancel
Save