Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade

This patch fixes problems with show/hide actions on a few pages
caused by some problematic jQuery syntax.

To test, apply the patch and go to Acquisitions.

Testing basket.tt:

- Locate a vendor which has an open basket with multiple orders.
- View the details of that basket.
- Click the 'Show all details' checkbox above the table of orders.
  - Checking the box should trigger the display of additional columns in
    the table.
  - Unchecking the box should hide them again.

Testing invoice.tt:

- Go to Acquisitions -> Invoices and perform an invoice search.
- Click to view an invoice which includes one or more received records.
- Click the 'Show all details' checkbox above the table of titles and
  confirm that it fuctions as described above.

Testing newordersubscription.tt:

- Go to Acquisitions and locate a vendor which is linked to a
  subscription
- Create or add to a basket for that vendor.
- Add an order using the 'From a subscription' option.
- Perform a search for subscriptions.
- In the table of subscriptions search results, checking or
  unchecking the "Show only renewed" checkbox should work correctly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>

koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt

@@ -23,7 +23,7 @@
 
     $(document).ready(function() {
         $("#show_all_details").click(function(){
-            updateColumnsVisibility($(this+":checked").val());
+            updateColumnsVisibility($(this).is(":checked"));
         });
 
         $("#show_all_details").attr('checked', false);

koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt

@@ -41,7 +41,7 @@
         }));
 [% END %]
         $("#show_all_details").click(function(){
-            updateColumnsVisibility($(this+":checked").val());
+            updateColumnsVisibility( $(this).is(":checked") );
         });
 
         $("#show_all_details").attr('checked', false);

koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt

@@ -27,7 +27,7 @@
         } ) )
 
         $("#show_only_renewed").click(function(){
-            updateRowsVisibility($(this+":checked").val());
+            updateRowsVisibility( $(this).is(":checked") );
         });
         $("#show_only_renewed").attr('checked', false);
         updateRowsVisibility(false);