Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 25992: Make SIP2 logger subroutines exportable to prevent crash

Browse source 
If the subroutines are not exportable we get the following crash:

> Undefined subroutine &C4::SIP::SIPServer::set_logger

To test:
 In kohadevbox run for example:
 $ ps -aux # check that no existing sip server is running, kill the process if exists
 $ perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml
 $ koha/misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item 3999900000001 -m item_information

 After applying this patch the Undefined subroutine error should be gone.
 Note: when using the sip_cli_emulator.pl the credentials can be anything.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Joonas Kylmälä 2020-07-15 11:08:32 +00:00 committed by Martin Renvoize
parent 4b0c2e56e4
commit 082da615e6
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
C4/SIP/Logger.pm
View file

@ -3,6 +3,9 @@ package C4::SIP::Logger;
use Modern::Perl;
use base 'Exporter';
our @EXPORT_OK = qw ( get_logger set_logger );
our $activeSIPServer;
our $activeLogger;