Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 29145: (QA follow-up) Fix missing bug number in database update and typos

Browse source 
Fixes some typos in test and update message that were highlighted
by the QA tools.

Add missing bug number to the atomic update file.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Katrin Fischer 2022-10-30 10:54:20 +00:00 committed by Tomas Cohen Arazi
parent 4678505e1e
commit 0a66a4879a
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
installer/data/mysql/atomicupdate/bug_29145-modify_AutoRemoveOverduesRestrictions-syspref.pl
View file

@ -1,13 +1,13 @@
use Modern::Perl; use Modern::Perl;
return { return {
bug_number => "", bug_number => "29145",
description => "Change type of AutoRemoveOverduesRestrictions system preference", description => "Change type of AutoRemoveOverduesRestrictions system preference",
up => sub { up => sub {
my ($args) = @_; my ($args) = @_;
my ($dbh, $out) = @$args{qw(dbh out)}; my ($dbh, $out) = @$args{qw(dbh out)};
# Do you stuffs here # Do you stuffs here
$dbh->do(q{UPDATE `systempreferences` SET `type` = 'Choice', `options` = 'no|when_no_overdue|when_no_overdue_causing_debarment', `explanation` = 'Defines if and on what conditions OVERDUES debarments should automatically be lifted when overdue items are returned by the patron.', `value` = CASE `value` WHEN '1' THEN 'when_no_overdue' WHEN '0' THEN 'no' ELSE `value` END WHERE variable = 'AutoRemoveOverduesRestrictions'}); $dbh->do(q{UPDATE `systempreferences` SET `type` = 'Choice', `options` = 'no|when_no_overdue|when_no_overdue_causing_debarment', `explanation` = 'Defines if and on what conditions OVERDUES debarments should automatically be lifted when overdue items are returned by the patron.', `value` = CASE `value` WHEN '1' THEN 'when_no_overdue' WHEN '0' THEN 'no' ELSE `value` END WHERE variable = 'AutoRemoveOverduesRestrictions'});
say $out "Type of AutoRemoveOverduesRestrictions system prefernce has ben changed"; say $out "Type of AutoRemoveOverduesRestrictions system preference has been changed";
}, },
} }

2
t/db_dependent/Circulation/MarkIssueReturned.t
View file

@ -245,7 +245,7 @@ subtest 'AutoRemoveOverduesRestrictions' => sub {
C4::Circulation::MarkIssueReturned( $patron->borrowernumber, $item_1->itemnumber ); C4::Circulation::MarkIssueReturned( $patron->borrowernumber, $item_1->itemnumber );
$debarments = Koha::Patron::Debarments::GetDebarments({ borrowernumber => $patron->borrowernumber }); $debarments = Koha::Patron::Debarments::GetDebarments({ borrowernumber => $patron->borrowernumber });
is( scalar @$debarments, 0, 'OVERDUES debarment is removed if remaning items would not result in patron debarment' ); is( scalar @$debarments, 0, 'OVERDUES debarment is removed if remaining items would not result in patron debarment' );
$checkout_1 = AddIssue( $patron->unblessed, $item_1->barcode, $ten_days_ago ); # overdue and would trigger debarment $checkout_1 = AddIssue( $patron->unblessed, $item_1->barcode, $ten_days_ago ); # overdue and would trigger debarment