From 0cf8194d5f6d1a401eb78abad88476ef061928c5 Mon Sep 17 00:00:00 2001 From: Colin Campbell Date: Thu, 4 Aug 2011 12:57:52 +0100 Subject: [PATCH] Bug 6667 Correct documentation of function Return list was documented as being in the reverse order to how it is returned. Correct the perldoc description also removed comments which did not help anyone trying to make sense of this subroutine Signed-off-by: Marcel de Rooy Just improving text comments. No code changes involved. Signed-off-by: Chris Cormack --- C4/Members.pm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/C4/Members.pm b/C4/Members.pm index f009590cc8..1730d6cb62 100644 --- a/C4/Members.pm +++ b/C4/Members.pm @@ -1204,12 +1204,10 @@ sub GetMemberAccountRecords { =head2 GetBorNotifyAcctRecord - ($count, $acctlines, $total) = &GetBorNotifyAcctRecord($params,$notifyid); + ($total, $acctlines, $count) = &GetBorNotifyAcctRecord($params,$notifyid); Looks up accounting data for the patron with the given borrowernumber per file number. -(FIXME - I'm not at all sure what this is about.) - C<&GetBorNotifyAcctRecord> returns a three-element array. C<$acctlines> is a reference-to-array, where each element is a reference-to-hash; the keys are the fields of the C table in the Koha database. @@ -1231,7 +1229,6 @@ sub GetBorNotifyAcctRecord { AND amountoutstanding != '0' ORDER BY notify_id,accounttype "); -# AND (accounttype='FU' OR accounttype='N' OR accounttype='M'OR accounttype='A'OR accounttype='F'OR accounttype='L' OR accounttype='IP' OR accounttype='CH' OR accounttype='RE' OR accounttype='RL') $sth->execute( $borrowernumber, $notifyid ); my $total = 0;