Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32894: Fix test

Browse source 
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 45d882de53)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 278769067c)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
This commit is contained in:
Jonathan Druart 2023-02-28 17:14:52 +01:00 committed by Matt Blenkinsop
parent c62cf435e2
commit 0dead55b94
1 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
t/db_dependent/Koha/Biblios.t
View file

@ -27,7 +27,7 @@ use Test::MockModule;
use MARC::Field;
use C4::Items;
use C4::Biblio qw( AddBiblio ModBiblio );
use C4::Biblio qw( AddBiblio ModBiblio GetMarcFromKohaField );
use C4::Reserves qw( AddReserve );
use Koha::DateUtils qw( dt_from_string output_pref );
@ -200,20 +200,24 @@ subtest 'custom_cover_image_url' => sub {
my $isbn = '0553573403 | 9780553573404 (pbk.).png';
my $issn = 'my_issn';
my $cf_value = 'from_control_field';
my $marc_record = MARC::Record->new;
my ( $biblionumber, undef ) = C4::Biblio::AddBiblio($marc_record, '');
my $biblio = $builder->build_sample_biblio;
my $marc_record = $biblio->metadata->record;
my ( $isbn_tag, $isbn_subfield ) = GetMarcFromKohaField( 'biblioitems.isbn' );
my ( $issn_tag, $issn_subfield ) = GetMarcFromKohaField( 'biblioitems.issn' );
$marc_record->append_fields(
MARC::Field->new( $isbn_tag, '', '', $isbn_subfield => $isbn ),
MARC::Field->new( $issn_tag, '', '', $issn_subfield => $issn ),
);
C4::Biblio::ModBiblio( $marc_record, $biblio->biblionumber );
my $biblio = Koha::Biblios->find( $biblionumber );
my $biblioitem = $biblio->biblioitem->set(
{ isbn => $isbn, issn => $issn });
is( $biblio->custom_cover_image_url, "https://my_url/${isbn}_${issn}.png" );
is( $biblio->get_from_storage->custom_cover_image_url, "https://my_url/${isbn}_${issn}.png" );
my $marc_024a = '710347104926';
$marc_record->append_fields( MARC::Field->new( '024', '', '', a => $marc_024a ) );
C4::Biblio::ModBiblio( $marc_record, $biblio->biblionumber );
t::lib::Mocks::mock_preference( 'CustomCoverImagesURL', 'https://my_url/{024$a}.png' );
is( $biblio->custom_cover_image_url, "https://my_url/$marc_024a.png" );
is( $biblio->get_from_storage->custom_cover_image_url, "https://my_url/$marc_024a.png" );
t::lib::Mocks::mock_preference( 'CustomCoverImagesURL', 'https://my_url/{normalized_isbn}.png' );
my $normalized_isbn = C4::Koha::GetNormalizedISBN($isbn);
@ -226,7 +230,7 @@ subtest 'custom_cover_image_url' => sub {
is( $biblio->custom_cover_image_url, undef, 'Record does not have 001' );
$marc_record->append_fields(MARC::Field->new('001', $cf_value));
C4::Biblio::ModBiblio( $marc_record, $biblio->biblionumber );
$biblio = Koha::Biblios->find( $biblionumber );
$biblio = Koha::Biblios->find( $biblio->biblionumber );
is( $biblio->get_from_storage->custom_cover_image_url, "https://my_url/$cf_value.png", 'URL generated using 001' );
};