Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35578: Validate "Where" in OPAC Authority search

Browse source 
This patch adds validation to the "Where" field in OPAC Authority search.

Test plan:
0. Apply the patch and koha-plack --reload kohadev
1. Go to http://localhost:8080/cgi-bin/koha/opac-authorities-home.pl
2. Type "test" into "Term(s)" field
3. Click "Submit"
4. Confirm a result is found

5. Repeat the above using "Where" values of "in the complete record",
"in any heading", and "in main entry"

6. Using the HTML inspector in the browser, change the value of
the selected option of the "marclist" select element to
"this is broken"
7. Click "Submit"
8. Confirm a result is found (ie it's not throwing a fatal error
anymore)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
David Cook 2023-12-15 00:14:05 +00:00 committed by Katrin Fischer
parent 7ef044cffd
commit 0ecb02eff9
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
1 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
opac/opac-authorities-home.pl
View file

@ -47,7 +47,7 @@ my ( $template, $loggedinuser, $cookie );
my $authority_types = Koha::Authority::Types->search({}, { order_by => ['authtypetext']});
if ( $op eq "do_search" ) {
my @marclist = $query->multi_param('marclist');
my @input_marclist = $query->multi_param('marclist');
my @and_or = $query->multi_param('and_or');
my @excluding = $query->multi_param('excluding');
my @operator = $query->multi_param('operator');
@ -55,6 +55,21 @@ if ( $op eq "do_search" ) {
my @value = $query->multi_param('value');
$value[0] ||= q||;
my $valid_marc_list = {
"all" => 1,
"match" => 1,
"mainentry" => 1,
};
my @marclist = ();
foreach my $entry (@input_marclist) {
if ( $valid_marc_list->{$entry} ) {
push( @marclist, $entry );
}
}
if ( !@marclist ) {
push( @marclist, 'all' );
}
my $builder = Koha::SearchEngine::QueryBuilder->new(
{ index => $Koha::SearchEngine::AUTHORITIES_INDEX } );
my $searcher = Koha::SearchEngine::Search->new(